Re: [Intel-gfx] [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

2021-09-15 Thread Stephen Boyd
Quoting Hans de Goede (2021-08-17 14:52:01) > diff --git a/drivers/usb/typec/altmodes/displayport.c > b/drivers/usb/typec/altmodes/displayport.c > index aa669b9cf70e..c1d8c23baa39 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -125,6

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add support for querying hw info that UMDs need

2021-09-15 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/94717/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10594 -> Patchwork_21068 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Add support for querying hw info that UMDs need

2021-09-15 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/94717/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gt/uc/intel_guc.h:143: warning: Function parameter or member

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for querying hw info that UMDs need

2021-09-15 Thread Patchwork
== Series Details == Series: Add support for querying hw info that UMDs need URL : https://patchwork.freedesktop.org/series/94717/ State : warning == Summary == $ dim checkpatch origin/drm-tip 117fc7d59414 drm/i915/guc: Add fetch of hwconfig table -:97: WARNING:FILE_PATH_CHANGES: added, moved

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Add fetch of hwconfig table

2021-09-15 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc:

[Intel-gfx] [PATCH 2/2] drm/i915/uapi: Add query for hwconfig table

2021-09-15 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all

[Intel-gfx] [PATCH 0/2] Add support for querying hw info that UMDs need

2021-09-15 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. Test-with: 20210915215558.2473428-2-john.c.harri...@intel.com UMD:

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/hdcp: Pull HDCP auth/exchange/check into helpers

2021-09-15 Thread Patchwork
== Series Details == Series: drm/hdcp: Pull HDCP auth/exchange/check into helpers URL : https://patchwork.freedesktop.org/series/94712/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] [PATCH i-g-t 1/1] tests/i915/query: Query, parse and validate the hwconfig table

2021-09-15 Thread John . C . Harrison
From: Rodrigo Vivi Newer platforms have an embedded table giving details about that platform's hardware configuration. This table can be retrieved from the KMD via the existing query API. So add a test for it as both an example of how to fetch the table and to validate the contents as much as is

[Intel-gfx] [PATCH i-g-t 0/1] Add test for new hw info query

2021-09-15 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A new interface has been added to the KMD to return this information. So, add a test for the new interface. Signed-off-by: John Harrison Reviewed-by: Matthew Brost Rodrigo Vivi (1):

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Update memory bandwidth parameters (rev2)

2021-09-15 Thread Sripada, Radhakrishna
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, September 15, 2021 1:46 PM > To: intel-gfx@lists.freedesktop.org > Cc: Sripada, Radhakrishna ; Vudum, > Lakshminarayana ; Kijanczuk, Damian > > Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Update memory >

Re: [Intel-gfx] [PATCH 0/9] drm: Add privacy-screen class and connector properties

2021-09-15 Thread Lyude Paul
OK! Looked over all of these patches. Patches 2 and 4 have some comments that should be addressed, but otherwise this series is: Reviewed-by: Lyude Paul Let me know when/if you need help pushing this upstream On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: > Hi all, > > Here is the

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-15 Thread Lyude Paul
On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: > Add support for eDP panels with a built-in privacy screen using the > new drm_privacy_screen class. > > One thing which stands out here is the addition of these 2 lines to > intel_atomic_commit_tail: > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: zero fill vma name buffer

2021-09-15 Thread Patchwork
== Series Details == Series: drm/i915: zero fill vma name buffer URL : https://patchwork.freedesktop.org/series/94708/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10593 -> Patchwork_21066 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v9 04/17] drm/i915/pxp: allocate a vcs context for pxp usage

2021-09-15 Thread Rodrigo Vivi
On Wed, Sep 15, 2021 at 04:53:35PM +0300, Jani Nikula wrote: > On Fri, 10 Sep 2021, Daniele Ceraolo Spurio > wrote: > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.h > > b/drivers/gpu/drm/i915/pxp/intel_pxp.h > > new file mode 100644 > > index ..e87550fb9821 > > --- /dev/null >

Re: [Intel-gfx] [PATCH 14/27] drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_ids

2021-09-15 Thread Matthew Brost
On Wed, Sep 15, 2021 at 01:04:45PM -0700, John Harrison wrote: > On 8/20/2021 15:44, Matthew Brost wrote: > > Assign contexts in parent-child relationship consecutive guc_ids. This > > is accomplished by partitioning guc_id space between ones that need to > > be consecutive (1/16 available

Re: [Intel-gfx] [PATCH 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device

2021-09-15 Thread Lyude Paul
On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: > Register a privacy-screen device on laptops with a privacy-screen, > this exports the PrivacyGuard features to user-space using a > standardized vendor-agnostic sysfs interface. Note the sysfs interface > is read-only. > > Registering a

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Update memory bandwidth parameters (rev2)

2021-09-15 Thread Matt Roper
On Wed, Sep 15, 2021 at 03:28:44AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Update memory bandwidth parameters (rev2) > URL : https://patchwork.freedesktop.org/series/94620/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10586_full ->

[Intel-gfx] [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-09-15 Thread Sean Paul
From: Sean Paul This patch adds HDCP 1.x support to msm DP connectors using the new HDCP helpers. Cc: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-s...@poorly.run #v1 Changes in v2: -Squash [1] into this patch with the

[Intel-gfx] [PATCH v2 12/13] dt-bindings: msm/dp: Add bindings for HDCP registers

2021-09-15 Thread Sean Paul
From: Sean Paul This patch adds the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. Cc: Rob Herring Cc: Stephen Boyd Signed-off-by: Sean Paul

[Intel-gfx] [PATCH v2 11/13] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules

2021-09-15 Thread Sean Paul
From: Sean Paul Audio is initialized last, it should be de-initialized first to match the order in dp_init_sub_modules(). Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-s...@poorly.run #v1 Changes in v2: -None ---

[Intel-gfx] [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack

2021-09-15 Thread Sean Paul
From: Sean Paul encoder->commit() was being misused because there were some global resources which needed to be tweaked in encoder->enable() which were not accessible in dpu_encoder.c. That is no longer true and the redirect serves no purpose any longer. So remove the indirection.

[Intel-gfx] [PATCH v2 09/13] drm/msm/dpu: Remove useless checks in dpu_encoder

2021-09-15 Thread Sean Paul
From: Sean Paul A couple more useless checks to remove in dpu_encoder. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-s...@poorly.run #v1 Changes in v2: -None --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 1 file

[Intel-gfx] [PATCH v2 08/13] drm/msm/dpu_kms: Re-order dpu includes

2021-09-15 Thread Sean Paul
From: Sean Paul Make includes alphabetical in dpu_kms.c Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-9-s...@poorly.run #v1 Changes in v2: -None --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 1 file changed, 4 insertions(+), 4

[Intel-gfx] [PATCH v2 07/13] drm/i915/hdcp: Use HDCP helpers for i915

2021-09-15 Thread Sean Paul
From: Sean Paul Now that all of the HDCP 1.x logic has been migrated to the central HDCP helpers, use it in the i915 driver. The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, however there are a few helper hooks which are connector-specific and need to be partially or

[Intel-gfx] [PATCH v2 06/13] drm/i915/hdcp: Retain hdcp_capable return codes

2021-09-15 Thread Sean Paul
From: Sean Paul The shim functions return error codes, but they are discarded in intel_hdcp.c. This patch plumbs the return codes through so they are properly handled. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-7-s...@poorly.run #v1

[Intel-gfx] [PATCH v2 05/13] drm/i915/hdcp: Consolidate HDCP setup/state cache

2021-09-15 Thread Sean Paul
From: Sean Paul Stick all of the setup for HDCP into a dedicated function. No functional change, but this will facilitate moving HDCP logic into helpers. Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-6-s...@poorly.run #v1 Changes in v2:

[Intel-gfx] [PATCH v2 04/13] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-09-15 Thread Sean Paul
From: Sean Paul This patch expands upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new platform supported HDCP we could

[Intel-gfx] [PATCH v2 03/13] drm/hdcp: Update property value on content type and user changes

2021-09-15 Thread Sean Paul
From: Sean Paul This patch updates the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new content type. 2- Userspace sets value

[Intel-gfx] [PATCH v2 02/13] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2021-09-15 Thread Sean Paul
From: Sean Paul Instead of forcing a modeset in the hdcp atomic check, simply return true if the content protection value is changing and let the driver decide whether a modeset is required or not. Signed-off-by: Sean Paul Link:

[Intel-gfx] [PATCH v2 01/13] drm/hdcp: Add drm_hdcp_atomic_check()

2021-09-15 Thread Sean Paul
From: Sean Paul This patch moves the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Signed-off-by: Sean Paul Link:

Re: [Intel-gfx] [PATCH 12/27] drm/i915/guc: Add multi-lrc context registration

2021-09-15 Thread Matthew Brost
On Wed, Sep 15, 2021 at 01:23:19PM -0700, John Harrison wrote: > On 9/15/2021 12:31, Matthew Brost wrote: > > On Wed, Sep 15, 2021 at 12:21:35PM -0700, John Harrison wrote: > > > On 8/20/2021 15:44, Matthew Brost wrote: > > > > Add multi-lrc context registration H2G. In addition a workqueue and >

[Intel-gfx] [PATCH v2 00/13] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2021-09-15 Thread Sean Paul
From: Sean Paul Hello again, This is the second version of the HDCP helper patchset. See version 1 here: https://patchwork.freedesktop.org/series/94623/ In this second version, I've fixed up the oopsies exposed by 0-day and yamllint and incorporated early review feedback from the dt/dts

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: zero fill vma name buffer

2021-09-15 Thread Patchwork
== Series Details == Series: drm/i915: zero fill vma name buffer URL : https://patchwork.freedesktop.org/series/94708/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3215090a38c8 drm/i915: zero fill vma name buffer -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation (rev3)

2021-09-15 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation (rev3) URL : https://patchwork.freedesktop.org/series/94674/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10593 -> Patchwork_21065

Re: [Intel-gfx] [PATCH 4/9] drm/privacy-screen: Add notifier support

2021-09-15 Thread Lyude Paul
On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: > Add support for privacy-screen consumers to register a notifier to > be notified of external (e.g. done by the hw itself on a hotkey press) > state changes. > > Reviewed-by: Emil Velikov > Signed-off-by: Hans de Goede > --- >  

Re: [Intel-gfx] [PATCH 12/27] drm/i915/guc: Add multi-lrc context registration

2021-09-15 Thread John Harrison
On 9/15/2021 12:31, Matthew Brost wrote: On Wed, Sep 15, 2021 at 12:21:35PM -0700, John Harrison wrote: On 8/20/2021 15:44, Matthew Brost wrote: Add multi-lrc context registration H2G. In addition a workqueue and process descriptor are setup during multi-lrc context registration as these data

Re: [Intel-gfx] [PATCH 01/16] Revert "drm/i915/display: Disable audio, DRRS and PSR before planes"

2021-09-15 Thread Souza, Jose
On Wed, 2021-09-15 at 15:30 +0300, Ville Syrjälä wrote: > On Wed, Sep 15, 2021 at 12:00:28AM +, Souza, Jose wrote: > > On Tue, 2021-09-14 at 16:30 -0700, José Roberto de Souza wrote: > > > On Tue, 2021-09-14 at 11:20 +0300, Ville Syrjälä wrote: > > > > On Mon, Sep 13, 2021 at 04:28:35PM +,

Re: [Intel-gfx] [PATCH CI 1/2] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-09-15 Thread Souza, Jose
On Wed, 2021-09-15 at 19:49 +0300, Ville Syrjälä wrote: > On Wed, Sep 15, 2021 at 06:57:19PM +0300, Ville Syrjälä wrote: > > On Wed, Sep 15, 2021 at 04:48:49PM +0300, Ville Syrjälä wrote: > > > On Mon, Sep 13, 2021 at 10:54:14PM +, Souza, Jose wrote: > > > > On Thu, 2021-09-09 at 23:28 +0300,

Re: [Intel-gfx] [PATCH 14/27] drm/i915/guc: Assign contexts in parent-child relationship consecutive guc_ids

2021-09-15 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Assign contexts in parent-child relationship consecutive guc_ids. This is accomplished by partitioning guc_id space between ones that need to be consecutive (1/16 available guc_ids) and ones that do not (15/16 of available guc_ids). The consecutive search

Re: [Intel-gfx] [PATCH 2/9] drm: Add privacy-screen class (v3)

2021-09-15 Thread Lyude Paul
On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: > On some new laptops the LCD panel has a builtin electronic privacy-screen. > We want to export this functionality as a property on the drm connector > object. But often this functionality is not exposed on the GPU but on some > other (ACPI)

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,01/12] drm/ttm: stop setting page->index for the ttm_tt

2021-09-15 Thread Patchwork
== Series Details == Series: series starting with [v3,01/12] drm/ttm: stop setting page->index for the ttm_tt URL : https://patchwork.freedesktop.org/series/94705/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10593 -> Patchwork_21064

Re: [Intel-gfx] [PATCH v2] drm/i915/display: program audio CDCLK-TS for keepalives

2021-09-15 Thread Shankar, Uma
> -Original Message- > From: Kai Vehmanen > Sent: Monday, September 13, 2021 10:10 PM > To: intel-gfx@lists.freedesktop.org > Cc: Shankar, Uma ; ville.syrj...@linux.intel.com; > Nikula, > Jani ; Kai Vehmanen > Subject: [PATCH v2] drm/i915/display: program audio CDCLK-TS for

Re: [Intel-gfx] [PATCH CI 1/2] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-09-15 Thread Souza, Jose
On Wed, 2021-09-15 at 16:48 +0300, Ville Syrjälä wrote: > On Mon, Sep 13, 2021 at 10:54:14PM +, Souza, Jose wrote: > > On Thu, 2021-09-09 at 23:28 +0300, Ville Syrjälä wrote: > > > On Thu, Sep 09, 2021 at 08:23:20PM +, Souza, Jose wrote: > > > > On Thu, 2021-09-09 at 23:20 +0300, Ville

Re: [Intel-gfx] [PATCH 1/9] drm/connector: Add support for privacy-screen properties (v4)

2021-09-15 Thread Lyude Paul
On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: > From: Rajat Jain > > Add support for generic electronic privacy screen properties, that > can be added by systems that have an integrated EPS. > > Changes in v2 (Hans de Goede) > - Create 2 properties, "privacy-screen sw-state" and >  

Re: [Intel-gfx] [PATCH 13/27] drm/i915/guc: Ensure GuC schedule operations do not operate on child contexts

2021-09-15 Thread Matthew Brost
On Wed, Sep 15, 2021 at 12:24:41PM -0700, John Harrison wrote: > On 8/20/2021 15:44, Matthew Brost wrote: > > In GuC parent-child contexts the parent context controls the scheduling, > > ensure only the parent does the scheduling operations. > > > > Signed-off-by: Matthew Brost > > --- > >

Re: [Intel-gfx] [PATCH 12/27] drm/i915/guc: Add multi-lrc context registration

2021-09-15 Thread Matthew Brost
On Wed, Sep 15, 2021 at 12:21:35PM -0700, John Harrison wrote: > On 8/20/2021 15:44, Matthew Brost wrote: > > Add multi-lrc context registration H2G. In addition a workqueue and > > process descriptor are setup during multi-lrc context registration as > > these data structures are needed for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,01/12] drm/ttm: stop setting page->index for the ttm_tt

2021-09-15 Thread Patchwork
== Series Details == Series: series starting with [v3,01/12] drm/ttm: stop setting page->index for the ttm_tt URL : https://patchwork.freedesktop.org/series/94705/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,01/12] drm/ttm: stop setting page->index for the ttm_tt

2021-09-15 Thread Patchwork
== Series Details == Series: series starting with [v3,01/12] drm/ttm: stop setting page->index for the ttm_tt URL : https://patchwork.freedesktop.org/series/94705/ State : warning == Summary == $ dim checkpatch origin/drm-tip 13d749649308 drm/ttm: stop setting page->index for the ttm_tt

[Intel-gfx] [PATCH] drm/i915: zero fill vma name buffer

2021-09-15 Thread Tim Gardner
In capture_vma() Coverity complains of a possible buffer overrun. Even though this is a static function where all call sites can be checked, limiting the copy length could save some future grief. CID 93300 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 4. fixed_size_dest: You might

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: remove unneeded clflush calls

2021-09-15 Thread John Harrison
On 9/15/2021 12:24, Belgaumkar, Vinay wrote: On 9/14/2021 12:51 PM, Lucas De Marchi wrote: The clflush calls here aren't doing anything since we are not writting something and flushing the cache lines to be visible to GuC. Here the intention seems to be to make sure whatever GuC has written is

Re: [Intel-gfx] [PATCH 13/27] drm/i915/guc: Ensure GuC schedule operations do not operate on child contexts

2021-09-15 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: In GuC parent-child contexts the parent context controls the scheduling, ensure only the parent does the scheduling operations. Signed-off-by: Matthew Brost --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 24 ++- 1 file changed,

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: remove unneeded clflush calls

2021-09-15 Thread Belgaumkar, Vinay
On 9/14/2021 12:51 PM, Lucas De Marchi wrote: The clflush calls here aren't doing anything since we are not writting something and flushing the cache lines to be visible to GuC. Here the intention seems to be to make sure whatever GuC has written is visible to the CPU before we read them.

Re: [Intel-gfx] [PATCH 12/27] drm/i915/guc: Add multi-lrc context registration

2021-09-15 Thread John Harrison
On 8/20/2021 15:44, Matthew Brost wrote: Add multi-lrc context registration H2G. In addition a workqueue and process descriptor are setup during multi-lrc context registration as these data structures are needed for multi-lrc submission. Signed-off-by: Matthew Brost ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation (rev2)

2021-09-15 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation (rev2) URL : https://patchwork.freedesktop.org/series/94674/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10593 -> Patchwork_21063

[Intel-gfx] [PATCH v3 12/12] drm/i915/ttm: enable shmem tt backend

2021-09-15 Thread Matthew Auld
Enable shmem tt backend, and enable shrinking. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index

[Intel-gfx] [PATCH v3 10/12] drm/i915: try to simplify make_{un}shrinkable

2021-09-15 Thread Matthew Auld
Drop the atomic shrink_pin stuff, and just have make_{un}shrinkable update the shrinker visible lists immediately. This at least simplifies the next patch, and does make the behaviour more obvious. The potential downside is that make_unshrinkable now grabs a global lock even when the object itself

[Intel-gfx] [PATCH v3 11/12] drm/i915/ttm: make evicted shmem pages visible to the shrinker

2021-09-15 Thread Matthew Auld
We currently just evict lmem objects to system memory when under memory pressure. For this case we lack the usual object mm.pages, which effectively hides the pages from the i915-gem shrinker, until we actually "attach" the TT to the object, or in the case of lmem-only objects it just gets

[Intel-gfx] [PATCH v3 08/12] drm/i915/ttm: add tt shmem backend

2021-09-15 Thread Matthew Auld
For cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such objects. For now this is still disabled. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Christian König ---

[Intel-gfx] [PATCH v3 09/12] drm/i915/ttm: use cached system pages when evicting lmem

2021-09-15 Thread Matthew Auld
This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8

[Intel-gfx] [PATCH v3 07/12] drm/i915/gem: Break out some shmem backend utils

2021-09-15 Thread Matthew Auld
From: Thomas Hellström Break out some shmem backend utils for future reuse by the TTM backend: shmem_alloc_st(), shmem_free_st() and __shmem_writeback() which we can use to provide a shmem-backed TTM page pool for cached-only TTM buffer objects. Main functional change here is that we now

[Intel-gfx] [PATCH v3 06/12] drm/ttm: add TTM_PAGE_FLAG_EXTERNAL_MAPPABLE

2021-09-15 Thread Matthew Auld
In commit: commit 667a50db0477d47fdff01c666f5ee1ce26b5264c Author: Thomas Hellstrom Date: Fri Jan 3 11:17:18 2014 +0100 drm/ttm: Refuse to fault (prime-) imported pages we introduced the restriction that imported pages should not be directly mappable through TTM(this also extends to

[Intel-gfx] [PATCH v3 04/12] drm/ttm: s/FLAG_SG/FLAG_EXTERNAL/

2021-09-15 Thread Matthew Auld
It covers more than just ttm_bo_type_sg usage, like with say dma-buf, since one other user is userptr in amdgpu, and in the future we might have some more. Hence EXTERNAL is likely a more suitable name. Suggested-by: Christian König Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc:

[Intel-gfx] [PATCH v3 05/12] drm/ttm: add some kernel-doc for TTM_PAGE_FLAG_*

2021-09-15 Thread Matthew Auld
Move it to inline kernel-doc, otherwise we can't add empty lines it seems. Also drop the kernel-doc for pages_list, which doesn't seem to exist, and get rid of all the strange holes. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Christian König --- include/drm/ttm/ttm_tt.h | 57

[Intel-gfx] [PATCH v3 03/12] drm/ttm: remove TTM_PAGE_FLAG_NO_RETRY

2021-09-15 Thread Matthew Auld
No longer used it seems. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Christian König --- include/drm/ttm/ttm_tt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm/ttm/ttm_tt.h b/include/drm/ttm/ttm_tt.h index 89b15d673b22..842ce756213c 100644 ---

[Intel-gfx] [PATCH v3 02/12] drm/ttm: move ttm_tt_{add, clear}_mapping into amdgpu

2021-09-15 Thread Matthew Auld
Now that setting page->index shouldn't be needed anymore, we are just left with setting page->mapping, and here it looks like amdgpu is the only user, where pointing the page->mapping at the dev_mapping is used to verify that the pages do indeed belong to the device, if userspace later tries to

[Intel-gfx] [PATCH v3 01/12] drm/ttm: stop setting page->index for the ttm_tt

2021-09-15 Thread Matthew Auld
In commit: commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 Author: Thomas Hellstrom Date: Fri Jan 3 11:47:23 2014 +0100 drm/ttm: Correctly set page mapping and -index members we started setting the page->mapping and page->index to point to the virtual address space, if the pages were

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

2021-09-15 Thread Souza, Jose
On Wed, 2021-09-15 at 17:58 +0300, Ville Syrjälä wrote: > On Tue, Sep 14, 2021 at 02:25:05PM -0700, José Roberto de Souza wrote: > > Not sure why but when moving the cursor fast it causes some artifacts > > of the cursor to be left in the cursor path, adding some pixels above > > the cursor to the

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/1] drm/i915/adlp: Keep hardware default dbox B credits

2021-09-15 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/adlp: Keep hardware default dbox B credits URL : https://patchwork.freedesktop.org/series/94702/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10592 -> Patchwork_21062

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Clean up disabled warnings (rev2)

2021-09-15 Thread Nathan Chancellor
I don't really see how this patch could be responsible for either this or the sparse report that I got... it is a simple build time change, nothing at runtime should be affected. Cheers, Nathan On Wed, Sep 15, 2021 at 03:00:19PM -, Patchwork wrote: > == Series Details == > > Series:

Re: [Intel-gfx] [PATCH 1/1] drm/i915/adlp: Keep hardware default dbox B credits

2021-09-15 Thread Souza, Jose
On Wed, 2021-09-15 at 10:10 -0700, Yokoyama, Caz wrote: > From: Caz Yokoyama > > Do not overwrite registers that don't need to change from default > value to 0. Reviewed-by: José Roberto de Souza > > bspec 49213 > Cc: Radhakrishna Sripada > Cc: José Roberto de Souza > Cc: Matt Roper >

[Intel-gfx] [PATCH 1/1] drm/i915/adlp: Keep hardware default dbox B credits

2021-09-15 Thread Yokoyama, Caz
From: Caz Yokoyama Do not overwrite registers that don't need to change from default value to 0. bspec 49213 Cc: Radhakrishna Sripada Cc: José Roberto de Souza Cc: Matt Roper Signed-off-by: Caz Yokoyama --- drivers/gpu/drm/i915/display/intel_display.c | 13 + 1 file changed, 9

Re: [Intel-gfx] [PATCH 08/27] drm/i915: Add logical engine mapping

2021-09-15 Thread Matthew Brost
On Wed, Sep 15, 2021 at 09:24:15AM +0100, Tvrtko Ursulin wrote: > > On 14/09/2021 19:04, Matthew Brost wrote: > > On Tue, Sep 14, 2021 at 09:34:08AM +0100, Tvrtko Ursulin wrote: > > > > > 8< > > > > Today we have: > > > > > > for_each intel_engines: // intel_engines is a flat list of all

[Intel-gfx] ✗ Fi.CI.BUILD: failure for use DYNAMIC_DEBUG to implement DRM.debug (rev3)

2021-09-15 Thread Patchwork
== Series Details == Series: use DYNAMIC_DEBUG to implement DRM.debug (rev3) URL : https://patchwork.freedesktop.org/series/93914/ State : failure == Summary == Applying: dyndbg: add module to a vpr-info in dd-exec-queries Applying: dyndbg: pr-info in boot-param should say so Applying:

Re: [Intel-gfx] [PATCH CI 1/2] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-09-15 Thread Ville Syrjälä
On Wed, Sep 15, 2021 at 06:57:19PM +0300, Ville Syrjälä wrote: > On Wed, Sep 15, 2021 at 04:48:49PM +0300, Ville Syrjälä wrote: > > On Mon, Sep 13, 2021 at 10:54:14PM +, Souza, Jose wrote: > > > On Thu, 2021-09-09 at 23:28 +0300, Ville Syrjälä wrote: > > > > On Thu, Sep 09, 2021 at 08:23:20PM

[Intel-gfx] [PATCH v8 16/16] nouveau: fold multiple DRM_DEBUG_DRIVERs together

2021-09-15 Thread Jim Cromie
With DRM_USE_DYNAMIC_DEBUG, each callsite record requires 56 bytes. We can combine 12 into one here and save ~620 bytes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/nouveau/nouveau_drm.c | 36 +-- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git

[Intel-gfx] [PATCH v8 15/16] amdgpu_ucode: reduce number of pr_debug calls

2021-09-15 Thread Jim Cromie
There are blocks of DRM_DEBUG calls, consolidate their args into single calls. With dynamic-debug in use, each callsite consumes 56 bytes of callsite data, and this patch removes about 65 calls, so it saves ~3.5kb. no functional changes. RFC: this creates multi-line log messages, does that

[Intel-gfx] [PATCH v8 14/16] drm_print: instrument drm_debug_enabled

2021-09-15 Thread Jim Cromie
Duplicate drm_debug_enabled() code into both "basic" and "dyndbg" ifdef branches. Then add a pr_debug("todo: ...") into the "dyndbg" branch. Then convert the "dyndbg" branch's code to a macro, so that the pr_debug() get its callsite info from the invoking function, instead of from

[Intel-gfx] [PATCH v8 13/16] drm_print: add choice to use dynamic debug in drm-debug

2021-09-15 Thread Jim Cromie
drm's debug system writes 10 distinct categories of messages to syslog using a small API[1]: drm_dbg*(10 names), DRM_DEV_DEBUG*(3 names), DRM_DEBUG*(8 names). There are thousands of these callsites, each categorized in this systematized way. These callsites can be enabled at runtime by their

[Intel-gfx] [PATCH v8 12/16] amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES on existing prdbgs

2021-09-15 Thread Jim Cromie
logger_types.h defines many DC_LOG_*() categorized debug wrappers. Most of these already use DRM debug API, so are controllable using drm.debug, but others use a bare pr_debug("$prefix: .."), with 1 of 13 different class-prefixes matching ~/^\[[_A-Z]+\]:/ Use DEFINE_DYNAMIC_DEBUG_CATEGORIES to

[Intel-gfx] [PATCH v8 11/16] i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES for existing prdbgs

2021-09-15 Thread Jim Cromie
The gvt component of this driver has ~120 pr_debugs, in 9 categories quite similar to those in DRM. Following the interface model of drm.debug, add a parameter to map bits to these categorizations. DEFINE_DYNAMIC_DEBUG_CATEGORIES(debug_gvt, __gvt_debug, "dyndbg bitmap desc",

[Intel-gfx] [PATCH v8 10/16] i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes

2021-09-15 Thread Jim Cromie
Taking embedded spaces out of existing prefixes makes them better class-prefixes; simplifying the extra quoting needed otherwise: $> echo format "^gvt: core:" +p >control Dropping the internal spaces means any trailing space in a query will more clearly terminate the prefix being searched for.

[Intel-gfx] [PATCH v8 09/16] drm: fix doc grammar error

2021-09-15 Thread Jim Cromie
no code changes, good for rc Signed-off-by: Jim Cromie --- include/drm/drm_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index b439ae1921b8..ebb22166ace1 100644 --- a/include/drm/drm_drv.h +++ b/include/drm/drm_drv.h @@

[Intel-gfx] [PATCH v8 07/16] dyndbg-doc: fix bootparam usage example

2021-09-15 Thread Jim Cromie
This example uses dyndbg as a core/kernel param; it is a (fake) module param. Using it as given gets an "Unknown command line parameters:" warning. Fix the broken example. Signed-off-by: Jim Cromie --- Documentation/admin-guide/dynamic-debug-howto.rst | 6 ++ 1 file changed, 2

[Intel-gfx] [PATCH v8 08/16] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES bitmap and callbacks

2021-09-15 Thread Jim Cromie
DEFINE_DYNAMIC_DEBUG_CATEGORIES(fsname, var, bitmap_desc, @bit_descs) allows users to create a drm.debug style (bitmap) sysfs interface, mapping each bit to a pr_debug "category". Unlike drm, dyndbg has no coding of "category", but it can select a set of pr_debugs with a substr match on their

[Intel-gfx] [PATCH v8 06/16] dyndbg: no vpr-info on empty queries

2021-09-15 Thread Jim Cromie
when `echo $cmd > control` contains multiple queries, extra query separators (;\n) can parse as empty statements. This is normal, and pr-info on empty command is just noise. Also change varname. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 13 +++-- 1 file changed, 7

[Intel-gfx] [PATCH v8 05/16] dyndbg: vpr-info on remove-module complete, not starting

2021-09-15 Thread Jim Cromie
On qemu --smp 3 runs, remove-module can get called 3 times. Instead, print once at end, if entry was found and removed. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index

[Intel-gfx] [PATCH v8 03/16] dyndbg: rationalize verbosity

2021-09-15 Thread Jim Cromie
change current v*pr_info() calls to fit this new scheme: -1 module add/remove, callsite counts - a few v2s here now -2 command ingest, splitting -3 command parsing - many v1s here now -4 per-site changes - was v2 2 is new, to isolate a problem where a stress-test script (which feeds large

[Intel-gfx] [PATCH v8 04/16] dyndbg: use alt-quotes in vpr-infos, not those user might use

2021-09-15 Thread Jim Cromie
`echo $cmd > control` can be finicky with respect to quoting (mostly wrt * expansion), so lets not complicate things by adding our own in debug messages. Quote as <%s> instead of '%s' or \"%s\" Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 16 1 file changed, 8

[Intel-gfx] [PATCH v8 02/16] dyndbg: pr-info in boot-param should say so

2021-09-15 Thread Jim Cromie
add "bootparam" to format. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index dfe1e6a857bc..da91ff507117 100644 --- a/lib/dynamic_debug.c +++

[Intel-gfx] [PATCH v8 01/16] dyndbg: add module to a vpr-info in dd-exec-queries

2021-09-15 Thread Jim Cromie
dd-exec-queries accepts a separate module arg (so it can support $module.dyndbg cmdline arg), add it to the vpr-info for more context. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c

[Intel-gfx] [PATCH v8 00/16] use DYNAMIC_DEBUG to implement DRM.debug

2021-09-15 Thread Jim Cromie
Hi Jason, Greg, Daniel, DRM folks, In DRM-debug currently, drm_debug_enabled() is called a lot to decide whether or not to write debug messages. Each test is cheap, but costs continue with uptime. DYNAMIC_DEBUG "dyndbg", when built with JUMP_LABEL, replaces each of those tests with a patchable

[Intel-gfx] ✗ Fi.CI.BUILD: failure for lib, stackdepot: check stackdepot handle before accessing slabs

2021-09-15 Thread Patchwork
== Series Details == Series: lib, stackdepot: check stackdepot handle before accessing slabs URL : https://patchwork.freedesktop.org/series/94696/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

Re: [Intel-gfx] [PATCH CI 1/2] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-09-15 Thread Ville Syrjälä
On Wed, Sep 15, 2021 at 04:48:49PM +0300, Ville Syrjälä wrote: > On Mon, Sep 13, 2021 at 10:54:14PM +, Souza, Jose wrote: > > On Thu, 2021-09-09 at 23:28 +0300, Ville Syrjälä wrote: > > > On Thu, Sep 09, 2021 at 08:23:20PM +, Souza, Jose wrote: > > > > On Thu, 2021-09-09 at 23:20 +0300,

Re: [Intel-gfx] [PATCH 03/16] drm/i915: Extract intel_dp_use_bigjoiner()

2021-09-15 Thread Ville Syrjälä
On Wed, Sep 15, 2021 at 01:12:26PM +0300, Jani Nikula wrote: > On Mon, 13 Sep 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Suck the "do we need bigjoiner?" checks into a helper instead of > > duplicating them in two differentt places. > > Could've called it

Re: [Intel-gfx] [PATCH v9 03/17] drm/i915/pxp: define PXP device flag and kconfig

2021-09-15 Thread Rodrigo Vivi
On Wed, Sep 15, 2021 at 04:29:50PM +0300, Jani Nikula wrote: > On Fri, 10 Sep 2021, Daniele Ceraolo Spurio > wrote: > > Ahead of the PXP implementation, define the relevant define flag and > > kconfig option. > > > > v2: flip kconfig default to N. Some machines have IFWIs that do not > > support

Re: [Intel-gfx] [PATCH v9 12/17] drm/i915/pxp: Enable PXP power management

2021-09-15 Thread Rodrigo Vivi
On Wed, Sep 15, 2021 at 08:11:54AM -0700, Daniele Ceraolo Spurio wrote: > > > On 9/14/2021 12:13 PM, Rodrigo Vivi wrote: > > On Fri, Sep 10, 2021 at 08:36:22AM -0700, Daniele Ceraolo Spurio wrote: > > > From: "Huang, Sean Z" > > > > > > During the power event S3+ sleep/resume, hardware will

Re: [Intel-gfx] [PATCH v9 12/17] drm/i915/pxp: Enable PXP power management

2021-09-15 Thread Daniele Ceraolo Spurio
On 9/14/2021 12:13 PM, Rodrigo Vivi wrote: On Fri, Sep 10, 2021 at 08:36:22AM -0700, Daniele Ceraolo Spurio wrote: From: "Huang, Sean Z" During the power event S3+ sleep/resume, hardware will lose all the encryption keys for every hardware session, even though the session state might still

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Mark GPU wedging on driver unregister unrecoverable (rev2)

2021-09-15 Thread Matt Roper
On Mon, Sep 06, 2021 at 08:34:15AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Mark GPU wedging on driver unregister unrecoverable (rev2) > URL : https://patchwork.freedesktop.org/series/94247/ > State : success > > == Summary == > > CI Bug Log - changes from

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Clean up disabled warnings (rev2)

2021-09-15 Thread Patchwork
== Series Details == Series: drm/i915: Clean up disabled warnings (rev2) URL : https://patchwork.freedesktop.org/series/94009/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10590 -> Patchwork_21059 Summary ---

  1   2   >