[Intel-gfx] [PATCH 0/5] drm/i915: Improve DP link training further

2021-10-04 Thread Ville Syrjala
From: Ville Syrjälä A little bit more generic DP link training improvements before we finally get to the actual per-lane drive settings PHY programming stuff. Ville Syrjälä (5): drm/i915: Tweak the DP "max vswing reached?" condition drm/i915: Show LTTPR in the TPS debug print drm/i915:

Re: [Intel-gfx] [PATCH 1/4] drm: Introduce drm_modeset_lock_ctx_retry()

2021-10-04 Thread Ville Syrjälä
On Tue, Jul 20, 2021 at 03:44:49PM +0200, Daniel Vetter wrote: > On Thu, Jul 15, 2021 at 09:49:51PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Quite a few places are hand rolling the modeset lock backoff dance. > > Let's suck that into a helper macro that is easier to use

[Intel-gfx] i915 MST HDCP code looks broken

2021-10-04 Thread Ville Syrjälä
Hi, I took a quick peek at intel_dp_add_mst_connector() the other day and noticed that it calls intel_dp_hdcp_init() and passes in the SST dig_port. And digging in a bit further that seems to clobber all kinds of things in dig_port->hdcp_port_data. This looks rather broken to me. So has anyone

Re: [Intel-gfx] [PATCH 01/28] dma-buf: add dma_resv_for_each_fence_unlocked v7

2021-10-04 Thread Tvrtko Ursulin
On 04/10/2021 11:44, Christian König wrote: Am 04.10.21 um 12:34 schrieb Tvrtko Ursulin: On 04/10/2021 10:53, Christian König wrote: Am 04.10.21 um 11:29 schrieb Tvrtko Ursulin: On 01/10/2021 11:05, Christian König wrote: Abstract the complexity of iterating over all the fences in a

[Intel-gfx] [PATCH] drm/i915/tc: Delete bogus NULL check in intel_ddi_encoder_destroy()

2021-10-04 Thread Dan Carpenter
The "digi_port" pointer can't be NULL and we have already dereferenced it so checking for NULL is not necessary. Delete the check. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/display/intel_ddi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Rewrite CL/CTG L-shaped memory detection

2021-10-04 Thread Ville Syrjälä
On Tue, Apr 27, 2021 at 10:58:07AM +0200, Daniel Vetter wrote: > On Mon, Apr 26, 2021 at 08:18:39PM +0300, Ville Syrjälä wrote: > > On Mon, Apr 26, 2021 at 06:08:59PM +0200, Daniel Vetter wrote: > > > On Thu, Apr 22, 2021 at 04:11:22PM +0300, Ville Syrjälä wrote: > > > > On Thu, Apr 22, 2021 at

Re: [Intel-gfx] [PATCH 01/28] dma-buf: add dma_resv_for_each_fence_unlocked v7

2021-10-04 Thread Tvrtko Ursulin
On 04/10/2021 10:53, Christian König wrote: Am 04.10.21 um 11:29 schrieb Tvrtko Ursulin: On 01/10/2021 11:05, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences

Re: [Intel-gfx] [PATCH 01/28] dma-buf: add dma_resv_for_each_fence_unlocked v7

2021-10-04 Thread Tvrtko Ursulin
On 01/10/2021 11:05, Christian König wrote: Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they

Re: [Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-10-04 Thread Jani Nikula
On Mon, 04 Oct 2021, Ville Syrjälä wrote: > On Sun, Oct 03, 2021 at 12:32:14AM +0200, Fernando Ramos wrote: >> On 21/10/02 09:13AM, Fernando Ramos wrote: >> > >> > Sean, could you revert the whole patch series? I'll have a deeper look >> > into the >> > patch set and come up with a v3 where all

Re: [Intel-gfx] [RFC 1/6] sched: Add nice value change notifier

2021-10-04 Thread Peter Zijlstra
On Mon, Oct 04, 2021 at 09:12:37AM +0100, Tvrtko Ursulin wrote: > On 01/10/2021 16:48, Peter Zijlstra wrote: > > Hmm? That's for normalize_rt_tasks() only, right? Just don't have it > > call the notifier in that special case (that's a magic sysrq thing > > anyway). > > You mean my talk about

Re: [Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-10-04 Thread Ville Syrjälä
On Sun, Oct 03, 2021 at 12:32:14AM +0200, Fernando Ramos wrote: > On 21/10/02 09:13AM, Fernando Ramos wrote: > > > > Sean, could you revert the whole patch series? I'll have a deeper look into > > the > > patch set and come up with a v3 where all these issues will be addressed. > > > > Hi

Re: [Intel-gfx] [RFC 1/6] sched: Add nice value change notifier

2021-10-04 Thread Tvrtko Ursulin
On 01/10/2021 16:48, Peter Zijlstra wrote: On Fri, Oct 01, 2021 at 11:32:16AM +0100, Tvrtko Ursulin wrote: On 01/10/2021 10:04, Tvrtko Ursulin wrote: Hi Peter, On 30/09/2021 19:33, Peter Zijlstra wrote: On Thu, Sep 30, 2021 at 06:15:47PM +0100, Tvrtko Ursulin wrote:   void

Re: [Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-10-04 Thread Ville Syrjälä
On Sat, Oct 02, 2021 at 07:28:02PM +0200, Fernando Ramos wrote: > On 21/10/02 09:13AM, Fernando Ramos wrote: > > On 21/10/02 05:30AM, Ville Syrjälä wrote: > > > On Sat, Oct 02, 2021 at 01:05:47AM +0300, Ville Syrjälä wrote: > > > > On Fri, Oct 01, 2021 at 04:48:15PM -0400, Sean Paul wrote: > > > >

Re: [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc

2021-10-04 Thread Jani Nikula
On Mon, 04 Oct 2021, "Saarinen, Jani" wrote: >> -Original Message- >> From: Intel-gfx On Behalf Of Dave >> Airlie >> Sent: maanantai 4. lokakuuta 2021 3.33 >> To: Ville Syrjälä >> Cc: Nikula, Jani ; Intel Graphics Development > g...@lists.freedesktop.org>; Dave Airlie ; Sarvela, Tomi

Re: [Intel-gfx] [PATCH] drm/i915: fix regression with uncore refactoring.

2021-10-04 Thread Jani Nikula
On Mon, 04 Oct 2021, Dave Airlie wrote: > From: Dave Airlie > > This was causing infinite recursion on snb/ivb. > > Fixes: 5716c8c6f4b6 ("drm/i915/uncore: split the fw get function into > separate vfunc") > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/i915/intel_uncore.c | 2 +- > 1

Re: [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc

2021-10-04 Thread Sarvela, Tomi P
> From: Ville Syrjälä > On Wed, Sep 29, 2021 at 01:57:45AM +0300, Jani Nikula wrote: > > From: Dave Airlie > > > > constify it while here. drop the put function since it was never > > overloaded and always has done the same thing, no point in > > indirecting it for show. > > > > Reviewed-by:

Re: [Intel-gfx] [BUG 5.15-rc3] kernel BUG at drivers/gpu/drm/i915/i915_sw_fence.c:245!

2021-10-04 Thread Jani Nikula
On Sat, 02 Oct 2021, Hugh Dickins wrote: > On Sat, 2 Oct 2021, Linus Torvalds wrote: >> On Sat, Oct 2, 2021 at 5:17 AM Steven Rostedt wrote: >> > On Sat, 2 Oct 2021 03:17:29 -0700 (PDT) >> > Hugh Dickins wrote: >> > >> > > Yes (though bisection doesn't work right on this one): the fix >> > >> >

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-10-04 Thread Jani Nikula
On Fri, 24 Sep 2021, Ville Syrjälä wrote: > On Tue, Sep 21, 2021 at 06:50:39PM -0700, Matthew Brost wrote: >> From: Hugh Dickins >> >> 5.15-rc1 crashes with blank screen when booting up on two ThinkPads >> using i915. Bisections converge convincingly, but arrive at different >> and surprising

Re: [Intel-gfx] [PATCH 01/24] drm/i915/uncore: split the fw get function into separate vfunc

2021-10-04 Thread Saarinen, Jani
> -Original Message- > From: Intel-gfx On Behalf Of Dave > Airlie > Sent: maanantai 4. lokakuuta 2021 3.33 > To: Ville Syrjälä > Cc: Nikula, Jani ; Intel Graphics Development g...@lists.freedesktop.org>; Dave Airlie ; Sarvela, Tomi P > > Subject: Re: [Intel-gfx] [PATCH 01/24]

<    1   2