Re: [Intel-gfx] [PATCH 14/14] Doc/gpu/rfc/i915: i915 DG2 uAPI

2021-10-11 Thread Lucas De Marchi
On Mon, Oct 11, 2021 at 9:10 AM Ramalingam C wrote: > > Details of the new features getting added as part of DG2 enabling and their > implicit impact on the uAPI. > > Signed-off-by: Ramalingam C > cc: Daniel Vetter > cc: Matthew Auld > --- > Documentation/gpu/rfc/i915_dg2.rst | 47

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: refactor plane config + pin out (rev2)

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/display: refactor plane config + pin out (rev2) URL : https://patchwork.freedesktop.org/series/95541/ State : success == Summary == CI Bug Log - changes from CI_DRM_10720 -> Patchwork_21314 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: refactor plane config + pin out (rev2)

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/display: refactor plane config + pin out (rev2) URL : https://patchwork.freedesktop.org/series/95541/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: refactor plane config + pin out (rev2)

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/display: refactor plane config + pin out (rev2) URL : https://patchwork.freedesktop.org/series/95541/ State : warning == Summary == $ dim checkpatch origin/drm-tip 569a494f9314 drm/i915/display: move plane prepare/cleanup to intel_atomic_plane.c -:38:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest URL : https://patchwork.freedesktop.org/series/95702/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10719_full -> Patchwork_21313_full

[Intel-gfx] [PATCH 8/8] drm/i915/display: drop unused parameter to dpt pin

2021-10-11 Thread Dave Airlie
From: Dave Airlie The uses_fence isn't used. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_fb_pin.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c b/drivers/gpu/drm/i915/display/intel_fb_pin.c index

[Intel-gfx] [PATCH 7/8] drm/i915/display: move fbdev pin code into fb_pin

2021-10-11 Thread Dave Airlie
From: Dave Airlie This moves the fbdev pin code over and moves the internal interfaces to static. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_fb_pin.c | 34 +++-- drivers/gpu/drm/i915/display/intel_fb_pin.h | 15 -

[Intel-gfx] [PATCH 6/8] drm/i915/display: refactor fbdev pin/unpin out into functions.

2021-10-11 Thread Dave Airlie
From: Dave Airlie This just cleans up the calls a bit. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_fbdev.c | 64 +- 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c

[Intel-gfx] [PATCH 5/8] drm/i915/display: move pin/unpin fb/plane code to a new file.

2021-10-11 Thread Dave Airlie
From: Dave Airlie This just moves this code out of the i915_display.c into a new standalone file. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/Makefile | 1 + .../gpu/drm/i915/display/intel_atomic_plane.c | 1 + drivers/gpu/drm/i915/display/intel_cursor.c | 2 +-

[Intel-gfx] [PATCH 4/8] drm/i915/display: refactor initial plane config to a separate file

2021-10-11 Thread Dave Airlie
From: Dave Airlie This moves this functionality out of intel_display.c to separate self-contained file. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 279 +

[Intel-gfx] [PATCH 3/8] drm/i915/display: refactor out initial plane config for crtcs

2021-10-11 Thread Dave Airlie
From: Dave Airlie This just pulls this out into a function so it can be moved to another file easier. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_display.c | 44 +++- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git

[Intel-gfx] [PATCH 1/8] drm/i915/display: move plane prepare/cleanup to intel_atomic_plane.c

2021-10-11 Thread Dave Airlie
From: Dave Airlie Start to refactor more stuff out of intel_display.c. These fit better in this file. This moves the rps boosting code as well as this is the only user of it. Signed-off-by: Dave Airlie --- .../gpu/drm/i915/display/intel_atomic_plane.c | 208 ++

[Intel-gfx] [PATCH 2/8] drm/i915/display: let intel_plane_uses_fence be used from other places.

2021-10-11 Thread Dave Airlie
From: Dave Airlie I want to refactor some stuff using this so make it shared. Signed-off-by: Dave Airlie --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_display.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [RFC PATCH 0/8] drm/i915/display: refactor plane config + pin out (v2)

2021-10-11 Thread Dave Airlie
This is another series in the refactor intel_display.c into more manageable places. This moves the initial plane config and all the fb pin/unpin code out. It also refactors both a little to make the interfaces cleaner. v2: just address the minor comments from Jani. Jani, I think Ville doesn't

Re: [Intel-gfx] [RFC PATCH 0/8] drm/i915/display: refactor plane config + pin out

2021-10-11 Thread Dave Airlie
On Thu, 7 Oct 2021 at 21:09, Ville Syrjälä wrote: > > On Thu, Oct 07, 2021 at 01:52:42PM +0300, Jani Nikula wrote: > > On Thu, 07 Oct 2021, Dave Airlie wrote: > > > This is another series in the refactor intel_display.c into more > > > manageable > > > places. > > > > > > This moves the initial

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Skip hangcheck selftest on DG1

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Skip hangcheck selftest on DG1 URL : https://patchwork.freedesktop.org/series/95693/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10719_full -> Patchwork_21312_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev9)

2021-10-11 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev9) URL : https://patchwork.freedesktop.org/series/95127/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10719_full -> Patchwork_21310_full

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2021-10-11 Thread Stephen Rothwell
=unused-variable] 491 | u32 inst, aper; | ^~~~ cc1: all warnings being treated as errors Caused by commit 404046cf4805 ("drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.") I have used the drm-misc tree from next-20211011 for today. -- Cheers, Stephe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest URL : https://patchwork.freedesktop.org/series/95702/ State : success == Summary == CI Bug Log - changes from CI_DRM_10719 -> Patchwork_21313

[Intel-gfx] [PATCH] drm/i915/selftests: Allow engine reset failure to do a GT reset in hangcheck selftest

2021-10-11 Thread Matthew Brost
The hangcheck selftest blocks per engine resets by setting magic bits in the reset flags. This is incorrect for GuC submission because if the GuC fails to reset an engine we would like to do a full GT reset. Do no set these magic bits when using GuC submission. Side note this lockless algorithm

[Intel-gfx] ✗ Fi.CI.IGT: failure for Fixup header includes (rev3)

2021-10-11 Thread Patchwork
== Series Details == Series: Fixup header includes (rev3) URL : https://patchwork.freedesktop.org/series/95587/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10717_full -> Patchwork_21309_full Summary ---

Re: [Intel-gfx] [PATCH 20/26] drm/i915/guc: Implement no mid batch preemption for multi-lrc

2021-10-11 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: For some users of multi-lrc, e.g. split frame, it isn't safe to preempt mid BB. To safely enable preemption at the BB boundary, a handshake between to parent and child is needed. This is implemented via custom between to parent -> between parent

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip hangcheck selftest on DG1

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Skip hangcheck selftest on DG1 URL : https://patchwork.freedesktop.org/series/95693/ State : success == Summary == CI Bug Log - changes from CI_DRM_10719 -> Patchwork_21312 Summary ---

[Intel-gfx] [PATCH 2/4] drm/ttm: do not set NULL to debugfs dentry

2021-10-11 Thread Nirmoy Das
For debugfs directory, it is recommended to save the result and pass over to next debugfs API for creating debugfs files/directories. Error conditions are handled by debugfs APIs. CC: Christian Koenig CC: Huang Rui CC: David Airlie CC: Daniel Vetter Signed-off-by: Nirmoy Das ---

[Intel-gfx] [PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-11 Thread Nirmoy Das
Debugfs APIs returns encoded error on failure so use debugfs_lookup() instead of checking for NULL. CC: Lukas Wunner CC: David Airlie CC: Daniel Vetter CC: Maarten Lankhorst CC: Maxime Ripard CC: Thomas Zimmermann Signed-off-by: Nirmoy Das --- drivers/gpu/vga/vga_switcheroo.c | 2 +- 1

[Intel-gfx] [PATCH 3/4] drm/i915/gt: do not check for NULL debugfs dentry

2021-10-11 Thread Nirmoy Das
Do not check for NULL value as drm.primary->debugfs_root will either contain a valid pointer or an encoded error instead of NULL. CC: Jani Nikula CC: Joonas Lahtinen CC: Rodrigo Vivi CC: David Airlie CC: Daniel Vetter Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/debugfs_gt.c | 3

[Intel-gfx] [PATCH 1/4] dri: do not check for NULL debugfs dentry

2021-10-11 Thread Nirmoy Das
Debugfs APIs returns encoded error on failure instead of NULL and for drm primary/minor debugfs directories, we save the returned value in the dentry pointer and pass it on to drm drivers to further create debugfs files/directories. Error conditions are handled by debugfs APIs, so no need to check

Re: [Intel-gfx] [PATCH 17/26] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 03:09:43PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > Introduce 'set parallel submit' extension to connect UAPI to GuC > > multi-lrc interface. Kernel doc in new uAPI should explain it all. > > > > IGT:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached()

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached() URL : https://patchwork.freedesktop.org/series/95689/ State : success == Summary == CI Bug Log - changes from CI_DRM_10717_full -> Patchwork_21308_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] dri: do not check for NULL debugfs dentry

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [1/4] dri: do not check for NULL debugfs dentry URL : https://patchwork.freedesktop.org/series/95691/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10719 -> Patchwork_21311

Re: [Intel-gfx] [PATCH 24/26] drm/i915: Update I915_GEM_BUSY IOCTL to understand composite fences

2021-10-11 Thread Daniele Ceraolo Spurio
On 10/4/2021 3:06 PM, Matthew Brost wrote: Parallel submission create composite fences (dma_fence_array) for excl / shared slots in objects. The I915_GEM_BUSY IOCTL checks these slots to determine the busyness of the object. Prior to patch it only check if the fence in the slot was a

Re: [Intel-gfx] [PATCH 17/26] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

2021-10-11 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: Introduce 'set parallel submit' extension to connect UAPI to GuC multi-lrc interface. Kernel doc in new uAPI should explain it all. IGT: https://patchwork.freedesktop.org/patch/447008/?series=93071=1 media UMD:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] dri: do not check for NULL debugfs dentry

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [1/4] dri: do not check for NULL debugfs dentry URL : https://patchwork.freedesktop.org/series/95691/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev9)

2021-10-11 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev9) URL : https://patchwork.freedesktop.org/series/95127/ State : success == Summary == CI Bug Log - changes from CI_DRM_10719 -> Patchwork_21310

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev9)

2021-10-11 Thread Patchwork
== Series Details == Series: drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev9) URL : https://patchwork.freedesktop.org/series/95127/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

Re: [Intel-gfx] [PATCH v3] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

2021-10-11 Thread Souza, Jose
On Thu, 2021-10-07 at 12:31 +0300, Gwan-gyeong Mun wrote: > > On 10/6/21 11:04 PM, Souza, Jose wrote: > > On Wed, 2021-10-06 at 11:50 +0300, Gwan-gyeong Mun wrote: > > > > > > On 10/6/21 2:18 AM, José Roberto de Souza wrote: > > > > Alderlake-P was getting 'max time under evasion' messages when

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Inject probe errors for MMIO send, CT send

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/guc: Inject probe errors for MMIO send, CT send URL : https://patchwork.freedesktop.org/series/95683/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10716_full -> Patchwork_21305_full

Re: [Intel-gfx] [PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-11 Thread Lukas Wunner
On Mon, Oct 11, 2021 at 09:06:07PM +0200, Nirmoy Das wrote: > Debugfs APIs returns encoded error on failure so use > debugfs_lookup() instead of checking for NULL. [...] > --- a/drivers/gpu/vga/vga_switcheroo.c > +++ b/drivers/gpu/vga/vga_switcheroo.c > @@ -914,7 +914,7 @@ static void

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixup header includes (rev3)

2021-10-11 Thread Patchwork
== Series Details == Series: Fixup header includes (rev3) URL : https://patchwork.freedesktop.org/series/95587/ State : success == Summary == CI Bug Log - changes from CI_DRM_10717 -> Patchwork_21309 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-11 Thread Umesh Nerlige Ramappa
On Mon, Oct 11, 2021 at 12:41:19PM +0100, Tvrtko Ursulin wrote: On 07/10/2021 23:55, Umesh Nerlige Ramappa wrote: With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixup header includes (rev3)

2021-10-11 Thread Patchwork
== Series Details == Series: Fixup header includes (rev3) URL : https://patchwork.freedesktop.org/series/95587/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v8,1/8] drm/i915/gem: Break out some shmem backend utils

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [v8,1/8] drm/i915/gem: Break out some shmem backend utils URL : https://patchwork.freedesktop.org/series/95677/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10716_full -> Patchwork_21304_full

[Intel-gfx] [PATCH] drm/i915/selftests: Skip hangcheck selftest on DG1

2021-10-11 Thread Matthew Brost
The hangcheck selftest blows on DG1 CI and aborts the BAT run. Investigation is underway to root cause the failure but in the meantime disable to this test on DG1 to unblock CI. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 8 1 file changed, 8

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached()

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached() URL : https://patchwork.freedesktop.org/series/95689/ State : success == Summary == CI Bug Log - changes from CI_DRM_10717 -> Patchwork_21308

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached()

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached() URL : https://patchwork.freedesktop.org/series/95689/ State : warning == Summary == $ dim checkpatch origin/drm-tip 89b690d2e4c1 drm/i915/dp: abstract

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Increase timeout in requests perf selftest

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Increase timeout in requests perf selftest URL : https://patchwork.freedesktop.org/series/95688/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10717 -> Patchwork_21307

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers (rev8)

2021-10-11 Thread Lyude Paul
ok - CI on this failed like, multiple times last week - each time with something slightly different and pretty clearly not related, so I'm going to give this one last shot at retesting now that some time has passed - otherwise I'll just file some bugs. On Sat, 2021-10-09 at 01:58 +, Patchwork

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Enabling 64k page size and flat ccs

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Enabling 64k page size and flat ccs URL : https://patchwork.freedesktop.org/series/95686/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10717 -> Patchwork_21306 Summary ---

[Intel-gfx] [PATCH 1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached()

2021-10-11 Thread Jani Nikula
Add per-lane abstraction for max vswing reached to make follow-up cleaner, as this one reverses the conditions. v2: both conditions need to be true, reverse (Ville) Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- .../drm/i915/display/intel_dp_link_training.c | 42 +++ 1 file

[Intel-gfx] [PATCH 2/2] drm/i915/dg2: update link training for 128b/132b

2021-10-11 Thread Jani Nikula
The 128b/132b channel coding link training uses more straightforward TX FFE preset values. Reuse voltage tries and max vswing for retry logic. The delays for 128b/132b are still all wrong, but this is regardless a step forward. v2: Fix UHBR rate checks, use intel_dp_is_uhbr() helper v3: -

Re: [Intel-gfx] [PATCH 2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 08:51:04PM +0530, Thanneeru Srinivasulu wrote: > Replace DRM_ERROR with i915_probe_error to report early HuC failures. > > Signed-off-by: Thanneeru Srinivasulu Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 4 ++-- > 1 file changed, 2

Re: [Intel-gfx] [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote: > Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. > > Signed-off-by: Thanneeru Srinivasulu Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++-- > 1 file changed, 2

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Inject probe errors for MMIO send

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 08:51:05PM +0530, Thanneeru Srinivasulu wrote: > Injecting probe errors -ENXIO for MMIO send. > > Signed-off-by: Thanneeru Srinivasulu Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Enabling 64k page size and flat ccs

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Enabling 64k page size and flat ccs URL : https://patchwork.freedesktop.org/series/95686/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Inject probe errors for CT send

2021-10-11 Thread Matthew Brost
On Mon, Oct 11, 2021 at 08:51:06PM +0530, Thanneeru Srinivasulu wrote: > Inject probe errors -ENXIO, -EBUSY for CT send. > > Signed-off-by: Thanneeru Srinivasulu > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 > 1 file changed, 8 insertions(+) > > diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Enabling 64k page size and flat ccs

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Enabling 64k page size and flat ccs URL : https://patchwork.freedesktop.org/series/95686/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5bf9ba0e1d7d drm/i915: Add has_64k_pages flag 70d612d1a872 drm/i915/xehpsdv: set min page-size to

[Intel-gfx] [PATCH] drm/i915/selftests: Increase timeout in requests perf selftest

2021-10-11 Thread Matthew Brost
perf_parallel_engines is micro benchmark to test i915 request scheduling. The test creates a thread per physical engine and submits NOP requests and waits the requests to complete in a loop. In execlists mode this works perfectly fine as powerful CPU has enough cores to feed each engine and

Re: [Intel-gfx] [PATCH 14/14] Doc/gpu/rfc/i915: i915 DG2 uAPI

2021-10-11 Thread Tang, CQ
> -Original Message- > From: C, Ramalingam > Sent: Monday, October 11, 2021 9:12 AM > To: dri-devel ; intel-gfx g...@lists.freedesktop.org> > Cc: Daniel Vetter ; Auld, Matthew > ; Tang, CQ ; Hellstrom, > Thomas ; C, Ramalingam > ; Daniel Vetter > Subject: [PATCH 14/14]

Re: [Intel-gfx] [PATCH] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()

2021-10-11 Thread Vlastimil Babka
On 10/7/21 13:01, Marco Elver wrote: > On Thu, Oct 07, 2021 at 11:58AM +0200, Vlastimil Babka wrote: > [...] >> - Add a CONFIG_STACKDEPOT_ALWAYS_INIT flag to keep using the current >> well-defined point of allocation as part of mem_init(). Make CONFIG_KASAN >> select this flag. >> - Other

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Inject probe errors for MMIO send, CT send

2021-10-11 Thread Patchwork
== Series Details == Series: drm/i915/guc: Inject probe errors for MMIO send, CT send URL : https://patchwork.freedesktop.org/series/95683/ State : success == Summary == CI Bug Log - changes from CI_DRM_10716 -> Patchwork_21305 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v8,1/8] drm/i915/gem: Break out some shmem backend utils

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [v8,1/8] drm/i915/gem: Break out some shmem backend utils URL : https://patchwork.freedesktop.org/series/95677/ State : success == Summary == CI Bug Log - changes from CI_DRM_10716 -> Patchwork_21304

[Intel-gfx] [PATCH 14/14] Doc/gpu/rfc/i915: i915 DG2 uAPI

2021-10-11 Thread Ramalingam C
Details of the new features getting added as part of DG2 enabling and their implicit impact on the uAPI. Signed-off-by: Ramalingam C cc: Daniel Vetter cc: Matthew Auld --- Documentation/gpu/rfc/i915_dg2.rst | 47 ++ Documentation/gpu/rfc/index.rst| 3 ++ 2

[Intel-gfx] [PATCH 13/14] drm/i915/uapi: document behaviour for DG2 64K support

2021-10-11 Thread Ramalingam C
From: Matthew Auld On discrete platforms like DG2, we need to support a minimum page size of 64K when dealing with device local-memory. This is quite tricky for various reasons, so try to document the new implicit uapi for this. Signed-off-by: Matthew Auld Signed-off-by: Ramalingam C ---

[Intel-gfx] [PATCH 12/14] drm/i915/gt: Clear compress metadata for Gen12.5 >= platforms

2021-10-11 Thread Ramalingam C
From: Ayaz A Siddiqui Gen12.5+ devices support Flat CCS which reserved a portion of the device memory to store compression metadata, during the clearing of device memory buffer object we also need to clear the associated CCS buffer. Flat CCS memory can not be directly accessed by S/W. Address

[Intel-gfx] [PATCH 11/14] drm/i915/lmem: Enable lmem for platforms with Flat CCS

2021-10-11 Thread Ramalingam C
From: Abdiel Janulgue A portion of device memory is reserved for Flat CCS so usable device memory will be reduced by size of Flat CCS. Size of Flat CCS is specified in “XEHPSDV_FLAT_CCS_BASE_ADDR”. So to get effective device memory we need to subtract total device memory by Flat CCS memory size.

[Intel-gfx] [PATCH 10/14] drm/i915/xehpsdv: Add has_flat_ccs to device info

2021-10-11 Thread Ramalingam C
From: CQ Tang Gen12+ devices support 3D surface (buffer) compression and various compression formats. This is accomplished by an additional compression control state (CCS) stored for each surface. Gen 12 devices(TGL family and DG1) stores compression states in a separate region of memory. It is

[Intel-gfx] [PATCH 09/14] drm/i915/xehpsdv: implement memory coloring

2021-10-11 Thread Ramalingam C
From: Matthew Auld The basic idea is that each 2M block(page-table) has a color, depending on if the page-table is occupied by LMEM objects(64K) or SMEM objects(4K), where our goal is to prevent mixing 64K and 4K GTT pages in the page-table, which is not supported by the HW. Signed-off-by:

[Intel-gfx] [PATCH 08/14] drm/i915/selftests: account for min_alignment in GTT selftests

2021-10-11 Thread Ramalingam C
From: Matthew Auld We need to support vm->min_alignment > 4K, depending on the vm itself and the type of object we are inserting. With this in mind update the GTT selftests to take this into account. Signed-off-by: Matthew Auld Signed-off-by: Ramalingam C ---

[Intel-gfx] [PATCH 07/14] drm/i915: Add vm min alignment support

2021-10-11 Thread Ramalingam C
From: Bommu Krishnaiah Replace the hard coded 4K alignment value with vm->min_alignment. Cc: Wilson Chris P Signed-off-by: Bommu Krishnaiah Signed-off-by: Ramalingam C --- .../i915/gem/selftests/i915_gem_client_blt.c | 23 --- drivers/gpu/drm/i915/gt/intel_gtt.c |

[Intel-gfx] [PATCH 06/14] drm/i915/xehpsdv: support 64K GTT pages

2021-10-11 Thread Ramalingam C
From: Matthew Auld XEHPSDV optimises 64K GTT pages for local-memory, since everything should be allocated at 64K granularity. We say goodbye to sparse entries, and instead get a compact 256B page-table for 64K pages, which should be more cache friendly. 4K pages for local-memory are no longer

[Intel-gfx] [PATCH 05/14] drm/i915/gtt/xehpsdv: move scratch page to system memory

2021-10-11 Thread Ramalingam C
From: Matthew Auld On some platforms the hw has dropped support for 4K GTT pages when dealing with LMEM, and due to the design of 64K GTT pages in the hw, we can only mark the *entire* page-table as operating in 64K GTT mode, since the enable bit is still on the pde, and not the pte. And since

[Intel-gfx] [PATCH 04/14] drm/i915: enforce min page size for scratch

2021-10-11 Thread Ramalingam C
From: Matthew Auld If the device needs 64K minimum GTT pages for device local-memory, like on XEHPSDV, then we need to fail the allocation if we can't meet it, instead of falling back to 4K pages, otherwise we can't safely support the insertion of device local-memory pages for this vm, since the

[Intel-gfx] [PATCH 03/14] drm/i915/xehpsdv: enforce min GTT alignment

2021-10-11 Thread Ramalingam C
From: Matthew Auld For local-memory objects we need to align the GTT addresses to 64K, both for the ppgtt and ggtt. Signed-off-by: Matthew Auld Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_vma.c | 9 +++--

[Intel-gfx] [PATCH 02/14] drm/i915/xehpsdv: set min page-size to 64K

2021-10-11 Thread Ramalingam C
From: Matthew Auld LMEM should be allocated at 64K granularity, since 4K page support will eventually be dropped for LMEM when using the PPGTT. Signed-off-by: Matthew Auld Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C Cc: Joonas Lahtinen Cc: Rodrigo Vivi ---

[Intel-gfx] [PATCH 01/14] drm/i915: Add has_64k_pages flag

2021-10-11 Thread Ramalingam C
From: Stuart Summers Add a new platform flag, has_64k_pages, for platforms supporting base page sizes of 64k. Signed-off-by: Stuart Summers Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 2 ++

[Intel-gfx] [PATCH 00/14] drm/i915/dg2: Enabling 64k page size and flat ccs

2021-10-11 Thread Ramalingam C
This series introduces the enabling patches for new flat ccs feature and 64k page support for i915 local memory, along with documentation on the uAPI impact. 64k page support On discrete platforms, starting from DG2, we have to contend with GTT page size restrictions when

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v8,1/8] drm/i915/gem: Break out some shmem backend utils

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [v8,1/8] drm/i915/gem: Break out some shmem backend utils URL : https://patchwork.freedesktop.org/series/95677/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v8,1/8] drm/i915/gem: Break out some shmem backend utils

2021-10-11 Thread Patchwork
== Series Details == Series: series starting with [v8,1/8] drm/i915/gem: Break out some shmem backend utils URL : https://patchwork.freedesktop.org/series/95677/ State : warning == Summary == $ dim checkpatch origin/drm-tip 099555c40683 drm/i915/gem: Break out some shmem backend utils

[Intel-gfx] [PATCH 0/4] drm/i915/guc: Inject probe errors for MMIO send, CT send

2021-10-11 Thread Thanneeru Srinivasulu
Injecting probe errors for MMIO send, CT send to make probe flow more robust. Use i915_probe_error to report probe injection errors. Thanneeru Srinivasulu (4): drm/i915/huc: Use i915_probe_error to report early CTB failures drm/i915/huc: Use i915_probe_error to report early HuC failures

[Intel-gfx] [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures

2021-10-11 Thread Thanneeru Srinivasulu
Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. Signed-off-by: Thanneeru Srinivasulu --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c

[Intel-gfx] [PATCH 4/4] drm/i915/guc: Inject probe errors for CT send

2021-10-11 Thread Thanneeru Srinivasulu
Inject probe errors -ENXIO, -EBUSY for CT send. Signed-off-by: Thanneeru Srinivasulu --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index

[Intel-gfx] [PATCH 3/4] drm/i915/guc: Inject probe errors for MMIO send

2021-10-11 Thread Thanneeru Srinivasulu
Injecting probe errors -ENXIO for MMIO send. Signed-off-by: Thanneeru Srinivasulu --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c index 8f8182bf7c11..490d66712afc

[Intel-gfx] [PATCH 2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures

2021-10-11 Thread Thanneeru Srinivasulu
Replace DRM_ERROR with i915_probe_error to report early HuC failures. Signed-off-by: Thanneeru Srinivasulu --- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c

[Intel-gfx] [PATCH v8 7/8] drm/i915/ttm: use cached system pages when evicting lmem

2021-10-11 Thread Matthew Auld
This should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström ---

[Intel-gfx] [PATCH v8 8/8] drm/i915/ttm: enable shmem tt backend

2021-10-11 Thread Matthew Auld
Turn on the shmem tt backend, and enable shrinking. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c

[Intel-gfx] [PATCH v8 6/8] drm/i915/ttm: move shrinker management into adjust_lru

2021-10-11 Thread Matthew Auld
We currently just evict lmem objects to system memory when under memory pressure. For this case we might lack the usual object mm.pages, which effectively hides the pages from the i915-gem shrinker, until we actually "attach" the TT to the object, or in the case of lmem-only objects it just gets

[Intel-gfx] [PATCH v8 2/8] drm/i915/ttm: add tt shmem backend

2021-10-11 Thread Matthew Auld
For cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such objects. For now this is still disabled. v2(Thomas): - Add optional try_to_writeback hook for objects. Importantly we need

[Intel-gfx] [PATCH v8 5/8] drm/i915: add some kernel-doc for shrink_pin and friends

2021-10-11 Thread Matthew Auld
Attempt to document shrink_pin and the other relevant interfaces that interact with it, before we start messing with it. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- .../gpu/drm/i915/gem/i915_gem_object_types.h | 24 +-

[Intel-gfx] [PATCH v8 1/8] drm/i915/gem: Break out some shmem backend utils

2021-10-11 Thread Matthew Auld
From: Thomas Hellström Break out some shmem backend utils for future reuse by the TTM backend: shmem_alloc_st(), shmem_free_st() and __shmem_writeback() which we can use to provide a shmem-backed TTM page pool for cached-only TTM buffer objects. Main functional change here is that we now

[Intel-gfx] [PATCH v8 3/8] drm/i915/gtt: drop unneeded make_unshrinkable

2021-10-11 Thread Matthew Auld
We already do this when mapping the pages. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 1 - drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 1 - 2 files changed, 2 deletions(-) diff --git

[Intel-gfx] [PATCH v8 4/8] drm/i915: drop unneeded make_unshrinkable in free_object

2021-10-11 Thread Matthew Auld
The comment here is no longer accurate, since the current shrinker code requires a full ref before touching any objects. Also unset_pages() should already do the required make_unshrinkable() for us, if needed, which is also nicely balanced with set_pages(). Signed-off-by: Matthew Auld Cc: Thomas

Re: [Intel-gfx] [Linaro-mm-sig] [PATCH] dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion

2021-10-11 Thread Christian König
Am 11.10.21 um 14:32 schrieb Tvrtko Ursulin: On 08/10/2021 13:19, Christian König wrote: Am 08.10.21 um 12:49 schrieb Tvrtko Ursulin: On 08/10/2021 11:21, Christian König wrote: Am 08.10.21 um 11:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Cache the count of shared fences in the

Re: [Intel-gfx] [PATCH] drm/i915: Prefer struct_size over open coded arithmetic

2021-10-11 Thread Len Baker
Hi, On Sun, Oct 03, 2021 at 12:42:58PM +0200, Len Baker wrote: > As noted in the "Deprecated Interfaces, Language Features, Attributes, > and Conventions" documentation [1], size calculations (especially > multiplication) should not be performed in memory allocator (or similar) > function

Re: [Intel-gfx] [PATCH] dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion

2021-10-11 Thread Tvrtko Ursulin
On 08/10/2021 13:19, Christian König wrote: Am 08.10.21 um 12:49 schrieb Tvrtko Ursulin: On 08/10/2021 11:21, Christian König wrote: Am 08.10.21 um 11:50 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Cache the count of shared fences in the iterator to avoid dereferencing the

[Intel-gfx] ✓ Fi.CI.IGT: success for dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion (rev4)

2021-10-11 Thread Patchwork
== Series Details == Series: dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion (rev4) URL : https://patchwork.freedesktop.org/series/95605/ State : success == Summary == CI Bug Log - changes from CI_DRM_10712_full -> Patchwork_21303_full

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-11 Thread Tvrtko Ursulin
On 07/10/2021 23:55, Umesh Nerlige Ramappa wrote: With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using

[Intel-gfx] ✓ Fi.CI.BAT: success for dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion (rev4)

2021-10-11 Thread Patchwork
== Series Details == Series: dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion (rev4) URL : https://patchwork.freedesktop.org/series/95605/ State : success == Summary == CI Bug Log - changes from CI_DRM_10712 -> Patchwork_21303

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion (rev4)

2021-10-11 Thread Patchwork
== Series Details == Series: dma-resv: Fix dma_resv_get_fences and dma_resv_copy_fences after conversion (rev4) URL : https://patchwork.freedesktop.org/series/95605/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2ef0df1434bf dma-resv: Fix dma_resv_get_fences and

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915/xehpsdv: Initialize multi-tiles

2021-10-11 Thread Tvrtko Ursulin
On 09/10/2021 00:33, Matt Roper wrote: From: Tvrtko Ursulin Check how many extra GT tiles are available on the system and setup register access for all of them. We can detect how may GT tiles are available by reading a register on the root tile. The same register returns the tile ID on all