== Series Details ==
Series: series starting with [1/9] drm/i915: mark dmabuf objects as ALLOC_USER
URL : https://patchwork.freedesktop.org/series/95982/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753_full -> Patchwork_21376_full
== Series Details ==
Series: drm/i915: Move PCH modeset code into its own file (rev2)
URL : https://patchwork.freedesktop.org/series/95863/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753_full -> Patchwork_21375_full
== Series Details ==
Series: drm/i915/dp: Fix link parameter use in lack of a valid DPCD (rev2)
URL : https://patchwork.freedesktop.org/series/95948/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10753_full -> Patchwork_21374_full
== Series Details ==
Series: drm/i915/display: Remove unused assignment
URL : https://patchwork.freedesktop.org/series/95967/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753_full -> Patchwork_21373_full
Summary
---
== Series Details ==
Series: drm/i915/display: Remove unused variable and its assignment.
URL : https://patchwork.freedesktop.org/series/95966/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10753_full -> Patchwork_21372_full
== Series Details ==
Series: drm/i915/display: Remove unused variable and corresponding assignment
URL : https://patchwork.freedesktop.org/series/95965/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753_full -> Patchwork_21371_full
== Series Details ==
Series: drm/i915: Remove redundant assignments
URL : https://patchwork.freedesktop.org/series/95964/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753_full -> Patchwork_21370_full
Summary
---
Am 13.10.21 um 15:38 schrieb Arunpravin:
Move vram related defines and inline functions into
a separate header file
Signed-off-by: Arunpravin
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 72
1 file changed, 72 insertions(+)
create mode 100644
On Mon, Oct 18, 2021 at 11:35:44AM -0700, Umesh Nerlige Ramappa wrote:
On Mon, Oct 18, 2021 at 08:58:01AM +0100, Tvrtko Ursulin wrote:
On 16/10/2021 00:47, Umesh Nerlige Ramappa wrote:
With GuC handling scheduling, i915 is not aware of the time that a
context is scheduled in and out of the
On Tue, Oct 19, 2021 at 1:35 AM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Nuke the hsw_get_ddi_port_state() eyesore by putting the
> readout code into intel_pch_display.c, and calling it directly
> from hsw_crt_get_config().
>
> Note that the nuked TRANS_DDI_FUNC_CTL readout from
>
== Series Details ==
Series: series starting with [1/9] drm/i915: mark dmabuf objects as ALLOC_USER
URL : https://patchwork.freedesktop.org/series/95982/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753 -> Patchwork_21376
== Series Details ==
Series: series starting with [1/9] drm/i915: mark dmabuf objects as ALLOC_USER
URL : https://patchwork.freedesktop.org/series/95982/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
== Series Details ==
Series: series starting with [1/9] drm/i915: mark dmabuf objects as ALLOC_USER
URL : https://patchwork.freedesktop.org/series/95982/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1ad5557daeac drm/i915: mark dmabuf objects as ALLOC_USER
9dfe83b2167d
== Series Details ==
Series: drm/i915: Move PCH modeset code into its own file (rev2)
URL : https://patchwork.freedesktop.org/series/95863/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753 -> Patchwork_21375
Summary
== Series Details ==
Series: drm/i915: Move PCH modeset code into its own file (rev2)
URL : https://patchwork.freedesktop.org/series/95863/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
== Series Details ==
Series: drm/i915: Move PCH modeset code into its own file (rev2)
URL : https://patchwork.freedesktop.org/series/95863/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fe78f7aa4624 drm/i915: Move PCH refclok stuff into its own file
-:803:
On Mon, Oct 18, 2021 at 08:58:01AM +0100, Tvrtko Ursulin wrote:
On 16/10/2021 00:47, Umesh Nerlige Ramappa wrote:
With GuC handling scheduling, i915 is not aware of the time that a
context is scheduled in and out of the engine. Since i915 pmu relies on
this info to provide engine busyness to
== Series Details ==
Series: drm/i915/dp: Fix link parameter use in lack of a valid DPCD (rev2)
URL : https://patchwork.freedesktop.org/series/95948/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753 -> Patchwork_21374
Just like we do for internal objects. Also just use
i915_gem_object_set_cache_coherency() here. No need for over-flushing on
LLC platforms.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 7 ++-
1 file changed, 6 insertions(+), 1
Add some details around non-LLC platforms and cflushing, when dealing
with the flush-on-acquire, which is potentially security sensitive.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
Cc: Daniel Vetter
---
.../gpu/drm/i915/gem/i915_gem_execbuffer.c| 11
While the pages can't be swapped out, they can be discarded by the shrinker.
Normally such objects are marked with __I915_MADV_PURGED, which can't be
unset, and therefore requires a new object. For kernel internal objects
this is not true, since the madv hint is reset for our special volatile
== Series Details ==
Series: drm/i915/dp: Fix link parameter use in lack of a valid DPCD (rev2)
URL : https://patchwork.freedesktop.org/series/95948/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
== Series Details ==
Series: drm/i915/dp: Fix link parameter use in lack of a valid DPCD (rev2)
URL : https://patchwork.freedesktop.org/series/95948/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8f1a6421dfe5 drm/i915/dp: Skip the HW readout of DPCD on disabled encoders
== Series Details ==
Series: drm/i915/display: Remove unused assignment
URL : https://patchwork.freedesktop.org/series/95967/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753 -> Patchwork_21373
Summary
---
On non-LLC platforms, force the flush-on-acquire if this is ever
swapped-in. Our async flush path is not trust worthy enough yet(and
happens in the wrong order), and with some tricks it's conceivable for
userspace to change the cache-level to I915_CACHE_NONE after the pages
are swapped-in, and
Even though userptr objects are always coherent with the GPU, with no
way for userspace to change this with the set_caching ioctl, even on
non-LLC platforms, there is still the 'Bypass LCC' mocs setting, which
might permit reading the contents of main memory directly.
Signed-off-by: Matthew Auld
As pointed out by Thomas, we likely need to flush the pages here if the
GPU can read the page contents directly from main memory. Underneath we
don't know what the sg_table is pointing to, so just add a
wbinvd_on_all_cpus() here, for now.
Reported-by: Thomas Hellström
Signed-off-by: Matthew Auld
It looks like we will need this in some more places, so extract as a
helper.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_object.c | 26 ++
drivers/gpu/drm/i915/gem/i915_gem_object.h | 1 +
drivers/gpu/drm/i915/gem/i915_gem_shmem.c
These are userspace objects, so mark them as such. In a later patch it's
useful to determine how paranoid we need to be when managing cache
flushes. In theory no functional changes.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 3 ++-
1 file
These are userspace objects, so mark them as such. In a later patch it's
useful to determine how paranoid we need to be when managing cache
flushes. In theory no functional changes.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 ++-
1 file
== Series Details ==
Series: drm/i915/display: Remove unused assignment
URL : https://patchwork.freedesktop.org/series/95967/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
64ace63151cd drm/i915/display: Remove unused assignment
-:29: WARNING:FROM_SIGN_OFF_MISMATCH:
== Series Details ==
Series: drm/i915/display: Remove unused variable and its assignment.
URL : https://patchwork.freedesktop.org/series/95966/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753 -> Patchwork_21372
Summary
On Mon, Oct 18, 2021 at 08:14:04PM +0300, Ville Syrjälä wrote:
> On Mon, Oct 18, 2021 at 03:06:34PM +0300, Lisovskiy, Stanislav wrote:
> > On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > Chop skl_program_plane() into two halves. Fist half
On Mon, Oct 18, 2021 at 03:06:34PM +0300, Lisovskiy, Stanislav wrote:
> On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Chop skl_program_plane() into two halves. Fist half becomes
> > the _noarm() variant, second part the _arm() variant.
> >
> >
== Series Details ==
Series: drm/i915/display: Remove unused variable and its assignment.
URL : https://patchwork.freedesktop.org/series/95966/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
96c9d1f9af61 drm/i915/display: Remove unused variable and its assignment.
-:38:
== Series Details ==
Series: drm/i915/display: Remove unused variable and corresponding assignment
URL : https://patchwork.freedesktop.org/series/95965/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753 -> Patchwork_21371
== Series Details ==
Series: drm/i915: Split plane updates to noarm+arm phases
URL : https://patchwork.freedesktop.org/series/95962/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10752_full -> Patchwork_21368_full
Summary
== Series Details ==
Series: drm/i915/display: Remove unused variable and corresponding assignment
URL : https://patchwork.freedesktop.org/series/95965/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
608df2105157 drm/i915/display: Remove unused variable and corresponding
== Series Details ==
Series: drm/i915: Remove redundant assignments
URL : https://patchwork.freedesktop.org/series/95964/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10753 -> Patchwork_21370
Summary
---
On Mon, Oct 18, 2021 at 06:42:38PM +0300, Petri Latvala wrote:
> On Mon, Oct 18, 2021 at 03:10:54PM +0300, Imre Deak wrote:
> > Hi Petri, Tomi,
> >
> > could you check the failure below?
> >
> > On Fri, Oct 15, 2021 at 11:19:13AM +, Patchwork wrote:
> > > == Series Details ==
> > >
> > >
== Series Details ==
Series: series starting with [v9,1/8] drm/i915/gem: Break out some shmem
backend utils
URL : https://patchwork.freedesktop.org/series/95942/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10752_full -> Patchwork_21366_full
== Series Details ==
Series: drm/i915/display: Remove unused variable in the for loop.
URL : https://patchwork.freedesktop.org/series/95963/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK
On Mon, Oct 18, 2021 at 03:10:54PM +0300, Imre Deak wrote:
> Hi Petri, Tomi,
>
> could you check the failure below?
>
> On Fri, Oct 15, 2021 at 11:19:13AM +, Patchwork wrote:
> > == Series Details ==
> >
> > Series: drm/i915: Simplify handling of modifiers (rev10)
> > URL :
From: Ville Syrjälä
Nuke the hsw_get_ddi_port_state() eyesore by putting the
readout code into intel_pch_display.c, and calling it directly
from hsw_crt_get_config().
Note that the nuked TRANS_DDI_FUNC_CTL readout from
hsw_get_ddi_port_state() is now etirely redundant since we
get called from
On Mon, Oct 18, 2021 at 06:13:19PM +0300, Imre Deak wrote:
> On Mon, Oct 18, 2021 at 06:04:18PM +0300, Ville Syrjälä wrote:
> > On Mon, Oct 18, 2021 at 12:41:52PM +0300, Imre Deak wrote:
> > > Print an error if the DPCD sink max lane count is invalid and fix it up.
> > >
> > > While at it also
On Mon, Oct 18, 2021 at 06:04:18PM +0300, Ville Syrjälä wrote:
> On Mon, Oct 18, 2021 at 12:41:52PM +0300, Imre Deak wrote:
> > Print an error if the DPCD sink max lane count is invalid and fix it up.
> >
> > While at it also add an assert that the link max lane count (derived
> > from
On Mon, Oct 18, 2021 at 12:41:52PM +0300, Imre Deak wrote:
> Print an error if the DPCD sink max lane count is invalid and fix it up.
>
> While at it also add an assert that the link max lane count (derived
> from intel_dp_max_common_lane_count(), potentially reduced by the LT
> fallback logic)
== Series Details ==
Series: drm/locking: fix __stack_depot_* name conflict
URL : https://patchwork.freedesktop.org/series/95940/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10752_full -> Patchwork_21365_full
Summary
Atm, there are no sink rate values set for DP (vs. eDP) sinks until the
DPCD capabilities are successfully read from the sink. During this time
intel_dp->num_common_rates is 0 which can lead to a
intel_dp->common_rates[-1](*)
access, which is an undefined behaviour, in the following cases:
== Series Details ==
Series: drm/i915: Split plane updates to noarm+arm phases
URL : https://patchwork.freedesktop.org/series/95962/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10752 -> Patchwork_21368
Summary
---
On Mon, Oct 18, 2021 at 11:24:21AM +0300, Jani Nikula wrote:
> On Fri, 15 Oct 2021, Rodrigo Vivi wrote:
> > We should stop using the gen name and the "+" to reference
> > the newer platforms.
> > And on this case specifically we can simplify the debug
> > message even further.
>
> Reviewed-by:
On Mon, Oct 18, 2021 at 11:25:00AM +0300, Jani Nikula wrote:
> On Fri, 15 Oct 2021, Rodrigo Vivi wrote:
> > There's no such thing as gen13. It is either display 13
> > or graphics 13. Don't propagate the gen12 confusion
> > further.
>
> Reviewed-by: Jani Nikula
thanks, pushed
>
> >
> > Cc:
On Mon, Oct 18, 2021 at 11:13:41AM +0300, Ville Syrjälä wrote:
> On Mon, Oct 18, 2021 at 09:56:33AM +1000, David Airlie wrote:
> > On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala
> > wrote:
> > >
> > > From: Ville Syrjälä
> > >
> > > Move the PCH refclk stuff (including all the LPT/WPT
> > >
== Series Details ==
Series: drm/i915: Split plane updates to noarm+arm phases
URL : https://patchwork.freedesktop.org/series/95962/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
== Series Details ==
Series: drm/i915: Split plane updates to noarm+arm phases
URL : https://patchwork.freedesktop.org/series/95962/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
4347a5768329 drm/i915: Reject planar formats when doing async flips
9ca3181d87a4 drm/i915: Fix
== Series Details ==
Series: drm/i915/dp: Fix link parameter use in lack of a valid DPCD
URL : https://patchwork.freedesktop.org/series/95948/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10752 -> Patchwork_21367
Summary
== Series Details ==
Series: drm/i915/dp: Fix link parameter use in lack of a valid DPCD
URL : https://patchwork.freedesktop.org/series/95948/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
== Series Details ==
Series: drm/i915/dp: Fix link parameter use in lack of a valid DPCD
URL : https://patchwork.freedesktop.org/series/95948/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
07ef5697be87 drm/i915/dp: Skip the HW readout of DPCD on disabled encoders
3e749fec1e8a
== Series Details ==
Series: series starting with [v9,1/8] drm/i915/gem: Break out some shmem
backend utils
URL : https://patchwork.freedesktop.org/series/95942/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10752 -> Patchwork_21366
On 10/17/2021 10:03 PM, Lukas Wunner wrote:
On Wed, Oct 13, 2021 at 08:36:01PM +0200, Nirmoy Das wrote:
Debugfs APIs returns encoded error on failure so use
debugfs_lookup() instead of checking for NULL.
The commit message no longer matches up with the patch itself
(debugfs_lookup() isn't
Am 15.10.21 um 14:52 schrieb Maarten Lankhorst:
Op 15-10-2021 om 14:07 schreef Christian König:
Am 15.10.21 um 13:57 schrieb Maarten Lankhorst:
Commit 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled")
accidentally forgot to test whether the dma-buf is actually signaled,
The assignment will be overwritten by the later, but the variable
is not used.
The clang_analyzer complains as follows:
drivers/gpu/drm/i915/display/intel_dpll.c:1568:2 warning:
Value stored to 'dpio_val' is never read
Reported-by: Zeal Robot
Signed-off-by: luo penghao
---
Am 15.10.21 um 13:57 schrieb Maarten Lankhorst:
Commit ada5c48b11a3 ("dma-buf: use new iterator in dma_resv_wait_timeout")
accidentally started mishandling timeout = 0, by forcing a blocking wait
with timeout = 1 passed to fences. This is not intended, as timeout = 0
may be used for peeking,
Thanks for the notice. Going to take a deeper look into this tomorrow.
Basically looks like we messed up the fence ref count somehow.
Thanks,
Christian.
Am 17.10.21 um 16:40 schrieb Nicolas Frattaroli:
On Dienstag, 5. Oktober 2021 13:37:30 CEST Christian König wrote:
Simplifying the code a
Variable is not used in functions, and its assignment is redundant too.
So it should be deleted.
The clang_analyzer complains as follows:
drivers/gpu/drm/i915/display/intel_dpll.c:1653:2 warning:
Value stored to 'bestm1' is never read.
drivers/gpu/drm/i915/display/intel_dpll.c:1651:2 warning:
Hi Jani,
On Fri, 15 Oct 2021 12:56:58 +0300 Jani Nikula wrote:
>
> The fix looks good, but I'd rename __stack_depot_print too added in the
> same commit. Do you want to respin or shall I take it from here?
If you are happy to take it on, then thanks.
--
Cheers,
Stephen Rothwell
Hi Daniel and Jani,
On Wed, Oct 13, 2021 at 01:51:30PM +0200, Daniel Vetter wrote:
> On Wed, Oct 13, 2021 at 02:24:05PM +0300, Jani Nikula wrote:
> > On Mon, 11 Oct 2021, Len Baker wrote:
> > > Hi,
> > >
> > > On Sun, Oct 03, 2021 at 12:42:58PM +0200, Len Baker wrote:
> > >> As noted in the
On Dienstag, 5. Oktober 2021 13:37:30 CEST Christian König wrote:
> Simplifying the code a bit.
>
> v2: use dma_resv_for_each_fence
>
> Signed-off-by: Christian König
> Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/scheduler/sched_main.c | 26 ++
> 1 file changed,
Variable is not used in functions, and its assignment is redundant too.
So it should be deleted.
The clang_analyzer complains as follows:
drivers/gpu/drm/i915/display/vlv_dsi.c:143:2 warning:
Value stored to 'data' is never read.
Reported-by: Zeal Robot
Signed-off-by: luo penghao
---
From: penghao luo
The assignment of variables will be overwritten later, so the
assignment here is meaningless.
The clang_analyzer complains as follows:
drivers/gpu/drm/i915/gem/i915_gem_userptr.c:291: warning:
Although the value stored to 'ret' is used in the enclosing expression,
the value
Variable is not used in the loop, and its assignment is redundant too.
So it should be deleted.
The clang_analyzer complains as follows:
drivers/gpu/drm/i915/display/intel_fb.c:1018:3 warning:
Value stored to 'cpp' is never read.
Reported-by: Zeal Robot
Signed-off-by: luo penghao
---
Hi luo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20211015]
url:
https://github.com/0day-ci/linux/commits/luo-penghao/drm-i915-display-Remove-unused-variable-in-the-for-loop/20211018-164557
base:7c832d2f9b959e3181370c8b0dacaf9efe13fc05
config
Hi Petri, Tomi,
could you check the failure below?
On Fri, Oct 15, 2021 at 11:19:13AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Simplify handling of modifiers (rev10)
> URL : https://patchwork.freedesktop.org/series/95579/
> State : failure
>
> == Summary ==
>
>
On Mon, Oct 18, 2021 at 02:50:26PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Chop skl_program_plane() into two halves. Fist half becomes
> the _noarm() variant, second part the _arm() variant.
>
> Fortunately I have already previously grouped the register
> writes into roughtly the
== Series Details ==
Series: series starting with [v9,1/8] drm/i915/gem: Break out some shmem
backend utils
URL : https://patchwork.freedesktop.org/series/95942/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be
== Series Details ==
Series: series starting with [v9,1/8] drm/i915/gem: Break out some shmem
backend utils
URL : https://patchwork.freedesktop.org/series/95942/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
53802cc4ee04 drm/i915/gem: Break out some shmem backend utils
== Series Details ==
Series: drm/locking: fix __stack_depot_* name conflict
URL : https://patchwork.freedesktop.org/series/95940/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10752 -> Patchwork_21365
Summary
---
From: Ville Syrjälä
Chop vlv_sprite_update() into two halves. Fist half becomes
the _noarm() variant, second part the _arm() variant.
Fortunately I have already previously grouped the register
writes into roughtly the correct order, so the split looks
surprisingly clean.
Looks like most of the
From: Ville Syrjälä
Chop ivb_sprite_update() into two halves. Fist half becomes
the _noarm() variant, second part the _arm() variant.
Fortunately I have already previously grouped the register
writes into roughtly the correct order, so the split looks
surprisingly clean.
Didn't bother with
From: Ville Syrjälä
Chop g4x_sprite_update() into two halves. Fist half becomes
the _noarm() variant, second part the _arm() variant.
Fortunately I have already previously grouped the register
writes into roughtly the correct order, so the split looks
surprisingly clean.
Not much of a change
From: Ville Syrjälä
Chop i9xx_plane_update() into two halves. Fist half becomes
the _noarm() variant, second part the _arm() variant.
Fortunately I have already previously grouped the register
writes into roughtly the correct order, so the split looks
surprisingly clean.
One slightly
From: Ville Syrjälä
Chop skl_program_plane() into two halves. Fist half becomes
the _noarm() variant, second part the _arm() variant.
Fortunately I have already previously grouped the register
writes into roughtly the correct order, so the split looks
surprisingly clean.
A few notable oddities
From: Ville Syrjälä
The amount of plane registers we have to write has been steadily
increasing, putting more pressure on the vblank evasion mechanism
and forcing us to increase its time budget. Let's try to take some
of the pressure off by splitting plane updates into two parts:
1) write all
From: Ville Syrjälä
Give all sprite exclusive functions/etc. a proper namespace.
Cc: Stanislav Lisovskiy
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c | 106 ++--
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git
From: Ville Syrjälä
We're currently forgetting to set the PLANE_SURF_DECRYPT
flag in the async flip path. So if the hardware were to
latch that bit despite this being an async flip we'd start
scanning out garbage. And if it doesn't latch it then I
guess we'd just end up with a weird register
From: Ville Syrjälä
Async flips are only capable of changing PLANE_SURF, hence we
they can't easily be used with planar formats.
Older platforms could require updating AUX_DIST as well, which
is not possible. We'd have to make sure AUX_DIST doesn't change
before allowing the async flip through.
From: Ville Syrjälä
Write all non-arming double buffered plane registers ahead of
the vblank evade critical section. This reduces the amount of
work we have to inside the critical section and thus should
speed it up a bit.
I didn't convert cursors yet because IIRC they had some
intersting
== Series Details ==
Series: drm/locking: fix __stack_depot_* name conflict
URL : https://patchwork.freedesktop.org/series/95940/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
bc53b22a35fb drm/locking: fix __stack_depot_* name conflict
-:13: WARNING:COMMIT_LOG_LONG_LINE:
Op 14-10-2021 om 15:56 schreef Tvrtko Ursulin:
>
> On 14/10/2021 14:45, Maarten Lankhorst wrote:
>> Op 14-10-2021 om 15:25 schreef Tvrtko Ursulin:
>>>
>>> On 14/10/2021 13:05, Maarten Lankhorst wrote:
Op 14-10-2021 om 10:37 schreef Tvrtko Ursulin:
>
> On 13/10/2021 11:41, Maarten
On Sat, 16 Oct 2021, Len Baker wrote:
> Hi Daniel and Jani,
>
> On Wed, Oct 13, 2021 at 01:51:30PM +0200, Daniel Vetter wrote:
>> On Wed, Oct 13, 2021 at 02:24:05PM +0300, Jani Nikula wrote:
>> > On Mon, 11 Oct 2021, Len Baker wrote:
>> > > Hi,
>> > >
>> > > On Sun, Oct 03, 2021 at 12:42:58PM
Add an assert that lookups from the intel_dp->common_rates[] array
are always valid.
Cc: Ville Syrjälä
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git
If the DPCD sink rate values read from the sink are invalid, the
driver will sanitize this in intel_dp_set_common_rates(), by setting a
default 162000 link rate in common rates and printing a WARN().
WARN()s should only be triggered by bugs in the code and not by external
factors like the above
Print an error if the DPCD sink max lane count is invalid and fix it up.
While at it also add an assert that the link max lane count (derived
from intel_dp_max_common_lane_count(), potentially reduced by the LT
fallback logic) value is also valid.
Cc: Ville Syrjälä
Signed-off-by: Imre Deak
---
Atm, there are no sink rate values set for DP (vs. eDP) sinks until the
DPCD capabilities are successfully read from the sink. During this time
intel_dp->num_common_rates is 0 which can lead to a
intel_dp->common_rates[-1](*)
access, which is an undefined behaviour, in the following cases:
Reading out the DP encoders' DPCD during booting or resume is only
required for enabled encoders: such encoders may be modesetted during
the initial commit and the link training this involves depends on an
initialized DPCD. For DDI encoders reading out the DPCD is skipped, do
the same on pre-DDI
Atm until the DPCD for a connector is read the max link rate and lane
count params are invalid. If the connector is modeset, in
intel_dp_compute_config(), intel_dp_common_len_rate_limit(max_link_rate)
will return 0, leading to a intel_dp->common_rates[-1] access.
Fix the above by making sure the
This patchset fixes a few issues, related to invalid accesses from the
intel_dp->common_rates[] array and in general the link rate, lane count
parameters being invalid until a valid DPCD is read from the sink.
One issue in intel_dp_sync_state() was caught by the CONFIG_UBSAN
feature. The first 3
This should let us do an accelerated copy directly to the shmem pages
when temporarily moving lmem-only objects, where the i915-gem shrinker
can later kick in to swap out the pages, if needed.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
Reviewed-by: Thomas Hellström
---
On Mon, 18 Oct 2021, luo penghao wrote:
> Variable is not used in the loop, and its assignment is redundant too.
> So it should be deleted.
>
> The clang_analyzer complains as follows:
>
> drivers/gpu/drm/i915/display/intel_fb.c:1018:3 warning:
>
> Value stored to 'cpp' is never read.
>
>
Turn on the shmem tt backend, and enable shrinking.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
Reviewed-by: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
1 - 100 of 126 matches
Mail list logo
