Re: [Intel-gfx] [PATCH] drm/i915/selftests: Skip hangcheck selftest on DG1

2021-10-20 Thread Thomas Hellström
On Mon, 2021-10-11 at 12:40 -0700, Matthew Brost wrote: > The hangcheck selftest blows on DG1 CI and aborts the BAT run. > Investigation is underway to root cause the failure but in the > meantime > disable to this test on DG1 to unblock CI. > > Signed-off-by: Matthew Brost Reviewed-by: Thomas

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix recursive lock in GuC submission

2021-10-20 Thread Thomas Hellström
On Wed, 2021-10-20 at 12:21 -0700, Matthew Brost wrote: > Use __release_guc_id (lock held) rather than release_guc_id (acquires > lock), add lockdep annotations. > > 213.280129] i915: Running i915_perf_live_selftests/live_noa_gpr > [ 213.283459] > [

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Increase timeout in requests perf selftest

2021-10-20 Thread Thomas Hellström
On Wed, 2021-10-20 at 13:34 -0700, John Harrison wrote: > On 10/11/2021 10:57, Matthew Brost wrote: > > perf_parallel_engines is micro benchmark to test i915 request > > scheduling. The test creates a thread per physical engine and > > submits > > NOP requests and waits the requests to complete in

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/dp: Use DP2.0 DPCD 248h updated register/field names for DP PHY CTS

2021-10-20 Thread Patchwork
== Series Details == Series: drm/dp: Use DP2.0 DPCD 248h updated register/field names for DP PHY CTS URL : https://patchwork.freedesktop.org/series/96096/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp: Use DP2.0 DPCD 248h updated register/field names for DP PHY CTS

2021-10-20 Thread Patchwork
== Series Details == Series: drm/dp: Use DP2.0 DPCD 248h updated register/field names for DP PHY CTS URL : https://patchwork.freedesktop.org/series/96096/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2bdec9c1bda4 drm/dp: Rename DPCD 248h according to DP 2.0 specs -:9:

[Intel-gfx] [RFC PATCH 4/4] drm/msm/dp: Use DPCD 248h DP 2.0 new names/definitions

2021-10-20 Thread Khaled Almahallawy
Use DP 2.0 DPCD 248h new name (LINK_QUAL_PATTERN_SELECT) and rename selected phy test patterns to LINK_QUAL_PATTERN_* Note: TPS4 LT pattern is CP2520 Pattern 3 (refer to DP2.0 spaces Table 3-11, DPCD 00248h LINK_QUAL_PATTERN_SELECT, and DP PHY 1.4 CTS - Appendix A - Compliance EYE

[Intel-gfx] [RFC PATCH 3/4] drm/amd/dc: Use DPCD 248h DP 2.0 new name

2021-10-20 Thread Khaled Almahallawy
Use the new definition of DPCD 248h (DP_LINK_QUAL_PATTERN_SELECT) No functional changes. Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [RFC PATCH 2/4] drm/i915/dp: Use DP 2.0 LINK_QUAL_PATTERN_* Phy test pattern definitions

2021-10-20 Thread Khaled Almahallawy
Update selected phy test pattern names to use the new names/definitions of DPCD 248h in DP2.0/drm_dp_helpers.h No functional changes Cc: Manasi Navare CC: Jani Nikula Cc: Imre Deak Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp.c | 12 ++-- 1 file

[Intel-gfx] [RFC PATCH 1/4] drm/dp: Rename DPCD 248h according to DP 2.0 specs

2021-10-20 Thread Khaled Almahallawy
DPCD 248h name was changed from “PHY_TEST_PATTERN” in DP 1.4 to “LINK_QUAL_PATTERN_SELECT” in DP 2.0. Also, DPCD 248h [6:0] is the same as DPCDs 10Bh/10Ch/10Dh/10Eh [6:0]. So removed the repeated definition of PHY patterns. Reference: “DPCD 248h/10Bh/10Ch/10Dh/10Eh Name/Description

[Intel-gfx] [RFC PATCH 0/4] drm/dp: Use DP2.0 DPCD 248h updated register/field names for DP PHY CTS

2021-10-20 Thread Khaled Almahallawy
This series updates DPCD 248h register name and PHY test patterns names to follow DP 2.0 Specs. Also updates the DP PHY CTS codes of the affected drivers (i915, amd, msm) No functional changes expected. Reference: “DPCD 248h/10Bh/10Ch/10Dh/10Eh Name/Description Consistency”

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Set all engine props values for GuC virtual engines

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915/guc: Set all engine props values for GuC virtual engines URL : https://patchwork.freedesktop.org/series/96085/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10766_full -> Patchwork_21397_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Split plane updates to noarm+arm phases (rev2)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: Split plane updates to noarm+arm phases (rev2) URL : https://patchwork.freedesktop.org/series/95962/ State : success == Summary == CI Bug Log - changes from CI_DRM_10766_full -> Patchwork_21396_full

Re: [Intel-gfx] [PATCH v3 00/10] Move vfio_ccw to the new mdev API

2021-10-20 Thread Jason Gunthorpe
On Fri, Oct 01, 2021 at 02:52:41PM -0300, Jason Gunthorpe wrote: > This addresses Cornelia's remark on the earlier patch that ccw has a > confusing lifecycle. While it doesn't seem like the original attempt was > functionally wrong, the result can be made better with a lot of further > work. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: (near)atomic gamma LUT updates via vblank workers

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: (near)atomic gamma LUT updates via vblank workers URL : https://patchwork.freedesktop.org/series/96089/ State : success == Summary == CI Bug Log - changes from CI_DRM_10767 -> Patchwork_21399 Summary

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2021-10-20 Thread Stephen Rothwell
Hi all, On Tue, 5 Oct 2021 10:23:23 +0200 Christian König wrote: > > Am 05.10.21 um 09:59 schrieb Stephen Rothwell: > > > > After merging the drm-misc tree, today's linux-next build (htmldocs) > > produced this warning: > > > > include/linux/dma-buf.h:456: warning: Function parameter or member

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: (near)atomic gamma LUT updates via vblank workers

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: (near)atomic gamma LUT updates via vblank workers URL : https://patchwork.freedesktop.org/series/96089/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: (near)atomic gamma LUT updates via vblank workers

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: (near)atomic gamma LUT updates via vblank workers URL : https://patchwork.freedesktop.org/series/96089/ State : warning == Summary == $ dim checkpatch origin/drm-tip 889072d8ac0e drm/i915: Move function prototypes to the correct header 0b7c1b5f5243

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Weak parallel submission support for execlists

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Weak parallel submission support for execlists URL : https://patchwork.freedesktop.org/series/96088/ State : success == Summary == CI Bug Log - changes from CI_DRM_10767 -> Patchwork_21398

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Simplify handling of modifiers (rev12)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers (rev12) URL : https://patchwork.freedesktop.org/series/95579/ State : success == Summary == CI Bug Log - changes from CI_DRM_10765_full -> Patchwork_21393_full Summary

[Intel-gfx] [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-20 Thread Bhawanpreet Lakha
From: Fangzhi Zuo [Why] configure/call DC interface for DP2 mst support. This is needed to make DP2 mst work. [How] - add encoding type, logging, mst update/reduce payload functions Use the link encoding to determine the DP type (1.4 or 2.0) and add a flag to dc_stream_update to determine

[Intel-gfx] [PATCH 2/4] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-20 Thread Bhawanpreet Lakha
8b/10b encoding format requires to reserve the first slot for recording metadata. Real data transmission starts from the second slot, with a total of available 63 slots available. In 128b/132b encoding format, metadata is transmitted separately in LLCP packet before MTP. Real data transmission

[Intel-gfx] [PATCH 2/4] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-20 Thread Bhawanpreet Lakha
8b/10b encoding format requires to reserve the first slot for recording metadata. Real data transmission starts from the second slot, with a total of available 63 slots available. In 128b/132b encoding format, metadata is transmitted separately in LLCP packet before MTP. Real data transmission

[Intel-gfx] [PATCH 1/4] drm: Remove slot checks in dp mst topology during commit

2021-10-20 Thread Bhawanpreet Lakha
This code path is used during commit, and we dont expect things to fail during the commit stage, so remove this. Signed-off-by: Bhawanpreet Lakha Reviewed-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH 4/4] drm/amd/display: Add DP 2.0 MST DM Support

2021-10-20 Thread Bhawanpreet Lakha
[Why] Add DP2 MST and debugfs support [How] Update the slot info based on the link encoding format Signed-off-by: Bhawanpreet Lakha Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +++ .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 3 ++

[Intel-gfx] [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-20 Thread Bhawanpreet Lakha
From: Fangzhi Zuo Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/core/dc.c | 14 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 280 ++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 19 ++ drivers/gpu/drm/amd/display/dc/dc_link.h | 7 +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Set all engine props values for GuC virtual engines

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915/guc: Set all engine props values for GuC virtual engines URL : https://patchwork.freedesktop.org/series/96085/ State : success == Summary == CI Bug Log - changes from CI_DRM_10766 -> Patchwork_21397

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Nuke PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE

2021-10-20 Thread Navare, Manasi
On Mon, Sep 13, 2021 at 05:44:40PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Now that the bigjoiner state readout/computation has been > made to do the right thing nuke the related state checker > quirk. > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare Manasi > --- >

Re: [Intel-gfx] [PATCH 15/16] drm/i915: Reduce bigjoiner special casing

2021-10-20 Thread Navare, Manasi
On Mon, Sep 13, 2021 at 05:44:39PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Try to make bigjoiner pipes less special. > > The main things here are that each pipe now does full > clock computation/readout with its own shared_dpll reference. > Also every pipe's cpu_transcoder always

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Fix recursive lock in GuC submission (rev2)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix recursive lock in GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/96076/ State : success == Summary == CI Bug Log - changes from CI_DRM_10765_full -> Patchwork_21392_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Split plane updates to noarm+arm phases (rev2)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: Split plane updates to noarm+arm phases (rev2) URL : https://patchwork.freedesktop.org/series/95962/ State : success == Summary == CI Bug Log - changes from CI_DRM_10766 -> Patchwork_21396 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Split plane updates to noarm+arm phases (rev2)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: Split plane updates to noarm+arm phases (rev2) URL : https://patchwork.freedesktop.org/series/95962/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Split plane updates to noarm+arm phases (rev2)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: Split plane updates to noarm+arm phases (rev2) URL : https://patchwork.freedesktop.org/series/95962/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0af9d48ba766 drm/i915: Reject planar formats when doing async flips d6008f7429e8 drm/i915:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: Implement waitboost for SLPC

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Implement waitboost for SLPC URL : https://patchwork.freedesktop.org/series/96082/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10766 -> Patchwork_21394 Summary ---

[Intel-gfx] [PATCH 3/4] drm/i915: Use vblank workers for gamma updates

2021-10-20 Thread Ville Syrjala
From: Ville Syrjälä The pipe gamma registers are single buffered so they should only be updated during the vblank to avoid screen tearing. In fact they really should only be updated between start of vblank and frame start because that is the only time the pipe is guaranteed to be empty. Already

[Intel-gfx] [PATCH 4/4] drm/i915: Use unlocked register accesses for LUT loads

2021-10-20 Thread Ville Syrjala
From: Ville Syrjälä We have to bash in a lot of registers to load the higher precision LUT modes. The locking overhead is significant, especially as we have to get this done as quickly as possible during vblank. So let's switch to unlocked accesses for these. Fortunately the LUT registers are

[Intel-gfx] [PATCH 0/4] drm/i915: (near)atomic gamma LUT updates via vblank workers

2021-10-20 Thread Ville Syrjala
From: Ville Syrjälä Finally got around to refreshing my vblank worker gamma LUT series. Since I started this (ahem, some years ago) Lyude took over the actual vblank worker implementation, mostly rewrote it I think, and landed it for use in nouveau. So now I'm just left with the easy task of

[Intel-gfx] [PATCH 2/4] drm/i915: Do vrr push before sampling the freame counter

2021-10-20 Thread Ville Syrjala
From: Ville Syrjälä Do the vrr push before we sample the frame counter to know when the commit has been latched. Doing these in the wrong order could lead us to complete the flip before it has actually happened. Cc: Manasi Navare Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 1/4] drm/i915: Move function prototypes to the correct header

2021-10-20 Thread Ville Syrjala
From: Ville Syrjälä A bunch of function prototypes were left behind when the plane/crtc code got reshuffled to new files. Move the prototypes as well. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.h | 5 + drivers/gpu/drm/i915/display/intel_psr.c| 2 +-

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/4] drm: Remove slot checks in dp mst topology during commit (rev3)

2021-10-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm: Remove slot checks in dp mst topology during commit (rev3) URL : https://patchwork.freedesktop.org/series/96079/ State : failure == Summary == Applying: drm: Remove slot checks in dp mst topology during commit Applying: drm: Update

Re: [Intel-gfx] [PATCH] drm/i915/dp: Add missing TPS4 programming bits

2021-10-20 Thread Almahallawy, Khaled
On Tue, 2021-10-19 at 15:01 +0300, Ville Syrjälä wrote: > On Tue, Oct 19, 2021 at 02:52:15PM +0300, Jani Nikula wrote: > > On Mon, 19 Jul 2021, Khaled Almahallawy < > > khaled.almahall...@intel.com> wrote: > > > Bits 20:19 are used to set CP2520 Patterns 1/2/3 (refer to > > > Specs:50484). > > >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc/slpc: Implement waitboost for SLPC

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Implement waitboost for SLPC URL : https://patchwork.freedesktop.org/series/96082/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0eb920836a06 drm/i915/guc/slpc: Define and initialize boost frequency cda3c12346d8

[Intel-gfx] [PATCH] drm/i915/execlists: Weak parallel submission support for execlists

2021-10-20 Thread Matthew Brost
A weak implementation of parallel submission (multi-bb execbuf IOCTL) for execlists. Doing as little as possible to support this interface for execlists - basically just passing submit fences between each request generated and virtual engines are not allowed. This is on par with what is there for

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915: Add support for panels with VESA backlights with PWM enable/disable

2021-10-20 Thread Lyude Paul
On Tue, 2021-10-19 at 21:09 +0300, Ville Syrjälä wrote: > On Tue, Oct 05, 2021 at 10:40:14PM -0400, Lyude Paul wrote: > > This simply adds proper support for panel backlights that can be > > controlled > > via VESA's backlight control protocol, but which also require that we > > enable and disable

[Intel-gfx] [PATCH] drm/i915/guc: Set all engine props values for GuC virtual engines

2021-10-20 Thread Matthew Brost
Set all engine props values for GuC virtual engines as a request can point to a virtual engine with GuC submission and these props are used all over the driver. This differs from execlists where a request can only point to a virtual engine. Signed-off-by: Matthew Brost ---

[Intel-gfx] [PATCH v2 6/9] drm/i915: Split pre-skl primary plane update into noarm+arm pair

2021-10-20 Thread Ville Syrjala
From: Ville Syrjälä Chop i9xx_plane_update() into two halves. Fist half becomes the _noarm() variant, second part the _arm() variant. Fortunately I have already previously grouped the register writes into roughtly the correct order, so the split looks surprisingly clean. One slightly

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Simplify handling of modifiers (rev12)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers (rev12) URL : https://patchwork.freedesktop.org/series/95579/ State : success == Summary == CI Bug Log - changes from CI_DRM_10765 -> Patchwork_21393 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Increase timeout in requests perf selftest

2021-10-20 Thread John Harrison
On 10/11/2021 10:57, Matthew Brost wrote: perf_parallel_engines is micro benchmark to test i915 request scheduling. The test creates a thread per physical engine and submits NOP requests and waits the requests to complete in a loop. In execlists mode this works perfectly fine as powerful CPU has

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/display: Rename POWER_DOMAIN_DPLL_DC_OFF to POWER_DOMAIN_DC_OFF

2021-10-20 Thread Souza, Jose
On Wed, 2021-10-20 at 05:49 +, Patchwork wrote: > Patch Details > Series: series starting with [1/2] drm/i915/display: Rename > POWER_DOMAIN_DPLL_DC_OFF to POWER_DOMAIN_DC_OFF > URL: https://patchwork.freedesktop.org/series/96039/ > State:failure > Details: >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Simplify handling of modifiers (rev12)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers (rev12) URL : https://patchwork.freedesktop.org/series/95579/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

Re: [Intel-gfx] [PATCH 14/16] drm/i915: Perform correct cpu_transcoder readout for bigjoiner

2021-10-20 Thread Navare, Manasi
On Mon, Sep 13, 2021 at 05:44:38PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Read out cpu_transcoder correctly for the bigjoiner slave pipes. > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/i915/display/intel_display.c | 66

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Simplify handling of modifiers (rev12)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915: Simplify handling of modifiers (rev12) URL : https://patchwork.freedesktop.org/series/95579/ State : warning == Summary == $ dim checkpatch origin/drm-tip 78f3fdfcbe6d drm/i915: Add a table with a descriptor for all i915 modifiers -:30:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix recursive lock in GuC submission (rev2)

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix recursive lock in GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/96076/ State : success == Summary == CI Bug Log - changes from CI_DRM_10765 -> Patchwork_21392 Summary

Re: [Intel-gfx] [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-20 Thread Alex Deucher
On Wed, Oct 20, 2021 at 3:50 PM Bhawanpreet Lakha wrote: > > From: Fangzhi Zuo Please include a patch description. Alex > > Signed-off-by: Fangzhi Zuo > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 14 + > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 280 ++ >

[Intel-gfx] [PATCH 3/3] drm/i915/guc/slpc: Update boost sysfs hooks for SLPC

2021-10-20 Thread Vinay Belgaumkar
Add a helper to sort through the SLPC/RPS cases of get/set methods. Boost frequency will be modified as long as it is within the constraints of RP0 and if it is different from the existing one. We will set min freq to boost only if there is an active waiter. Signed-off-by: Vinay Belgaumkar ---

[Intel-gfx] [PATCH 2/3] drm/i915/guc/slpc: Add waitboost functionality for SLPC

2021-10-20 Thread Vinay Belgaumkar
Add helpers in RPS code for handling SLPC and non-SLPC cases. When a boost is requested in the SLPC case, we can ask GuC to ramp up the frequency by setting the minimum frequency to RP0. Reset the frequency back to the min softlimit when there are no more waiters. Signed-off-by: Vinay Belgaumkar

[Intel-gfx] [PATCH 1/3] drm/i915/guc/slpc: Define and initialize boost frequency

2021-10-20 Thread Vinay Belgaumkar
Boost frequency is initialized at RP0. Also define num_waiters which can track the pending boost requests. This is set to 0 when we enable SLPC. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 10 ++

[Intel-gfx] [PATCH 0/3] drm/i915/guc/slpc: Implement waitboost for SLPC

2021-10-20 Thread Vinay Belgaumkar
Waitboost is a legacy feature implemented in the Host Turbo algorithm. This patch set implements it for the SLPC path. A "boost" happens when user calls gem_wait ioctl on a submission that has not landed on HW yet. GT frequency gets temporarily bumped to RP0 to allow the previous request to finish

[Intel-gfx] [PATCH v4 11/11] drm/i915: Add functions to check for RC CCS CC and MC CCS modifiers

2021-10-20 Thread Imre Deak
Instead of open-coding the checks add functions for this, simplifying the handling of CCS modifiers on future platforms. Cc: Juha-Pekka Heikkila Signed-off-by: Imre Deak Reviewed-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_fb.c | 24 +++

[Intel-gfx] [PATCH v4 09/11] drm/i915: Add a platform independent way to check for CCS AUX planes

2021-10-20 Thread Imre Deak
Future platforms change the location of CCS AUX planes in CCS framebuffers, so add intel_fb_is_ccs_aux_plane() to query for these planes independently of the platform. This function can be used everywhere instead of is_ccs_plane() (or is_ccs_plane() && !cc_plane()), since all the callers are only

[Intel-gfx] [PATCH v4 07/11] drm/i915: Add a platform independent way to get the RC CCS CC plane

2021-10-20 Thread Imre Deak
On future platforms the index of the color-clear plane will change from the one used by the GEN12 RC CCS CC modifier, so add a way to retrieve the index independently of the platform/modifier. Cc: Juha-Pekka Heikkila Signed-off-by: Imre Deak Reviewed-by: Juha-Pekka Heikkila ---

[Intel-gfx] [PATCH v4 08/11] drm/i915: Handle CCS CC planes separately from CCS AUX planes

2021-10-20 Thread Imre Deak
CCS CC planes are quite different from CCS AUX planes, even though we regard the CC planes as a linear buffer having a 64 byte stride. Thus it's clearer to check for either CCS plane types explicitly when we need to handle them; add the required CCS CC planes check here, while the next patch will

[Intel-gfx] [PATCH v4 05/11] drm/i915: Unexport is_semiplanar_uv_plane()

2021-10-20 Thread Imre Deak
This function is only used by intel_fb.c, so unexport it. Cc: Juha-Pekka Heikkila Signed-off-by: Imre Deak Reviewed-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- drivers/gpu/drm/i915/display/intel_fb.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff

[Intel-gfx] [PATCH v4 10/11] drm/i915: Move is_ccs_modifier() to intel_fb.c

2021-10-20 Thread Imre Deak
Move the function to intel_fb.c and rename it adding the intel_fb_ prefix following the naming of exported functions. Cc: Juha-Pekka Heikkila Signed-off-by: Imre Deak Reviewed-by: Juha-Pekka Heikkila --- .../drm/i915/display/intel_display_types.h| 9 --

[Intel-gfx] [PATCH v4 06/11] drm/i915: Move intel_format_info_is_yuv_semiplanar() to intel_fb.c

2021-10-20 Thread Imre Deak
Move intel_format_info_is_yuv_semiplanar() to intel_fb.c . The number of planes for YUV semiplanar formats using CCS modifiers will change on future platforms. We can use the modifier descriptors to simplify getting the plane numbers for all modifiers, prepare for that here. Cc: Juha-Pekka

[Intel-gfx] [PATCH v4 03/11] drm/i915: Add tiling attribute to the modifier descriptor

2021-10-20 Thread Imre Deak
Add a tiling atttribute to the modifier descriptor, which let's us get the tiling without listing the modifiers twice. v1-v2: Unchanged. v3: - Initialize .tiling to I915_TILING_NONE explicitly (Ville) - Move from previous patch lookup_modifier() to here, where it's first used. Cc: Juha-Pekka

[Intel-gfx] [PATCH v4 01/11] drm/i915: Add a table with a descriptor for all i915 modifiers

2021-10-20 Thread Imre Deak
Add a table describing all the framebuffer modifiers used by i915 at one place. This has the benefit of deduplicating the listing of supported modifiers for each platform and checking the support of these modifiers on a given plane. This also simplifies in a similar way getting some attribute for

[Intel-gfx] [PATCH v4 04/11] drm/i915: Simplify the modifier check for interlaced scanout support

2021-10-20 Thread Imre Deak
Checking the modifiers that support interlacing makes the condition simpler and avoids us having to add new modifiers to the list (presuming all/most of the new modifiers won't support interlacing). Cc: Juha-Pekka Heikkila Signed-off-by: Imre Deak Reviewed-by: Juha-Pekka Heikkila ---

[Intel-gfx] [PATCH v4 02/11] drm/i915: Move intel_get_format_info() to intel_fb.c

2021-10-20 Thread Imre Deak
Move the function retrieving the format override information for a given format/modifier to intel_fb.c. We can store a pointer to the format list in each modifier's descriptor instead of the corresponding switch/case logic, avoiding the listing of the modifiers twice. v1: Unchanged. v2: Handle

[Intel-gfx] [PATCH v4 00/11] drm/i915: Simplify handling of modifiers

2021-10-20 Thread Imre Deak
This is v4 of [1] addressing review comments from Jani and Ville in patch 1 and 9. [1] https://patchwork.freedesktop.org/series/95579/ Cc: Juha-Pekka Heikkila Cc: Ville Syrjälä Cc: Jani Nikula Imre Deak (11): drm/i915: Add a table with a descriptor for all i915 modifiers drm/i915: Move

Re: [Intel-gfx] [PATCH 2/4] mm: add a io_mapping_map_user helper

2021-10-20 Thread Peter Zijlstra
On Wed, Oct 20, 2021 at 08:40:05AM -0700, Lucas De Marchi wrote: > On Fri, Mar 26, 2021 at 06:55:03AM +0100, Christoph Hellwig wrote: > > Add a helper that calls remap_pfn_range for an struct io_mapping, relying > > on the pgprot pre-validation done when creating the mapping instead of > > doing

Re: [Intel-gfx] [PATCH 2/4] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-20 Thread Lyude Paul
Awesome! So this all looks fine to me, just some formatting changes: On Wed, 2021-10-20 at 10:16 -0400, Bhawanpreet Lakha wrote: > 8b/10b encoding format requires to reserve the first slot for > recording metadata. Real data transmission starts from the second slot, > with a total of available 63

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add struct to hold IP version

2021-10-20 Thread Souza, Jose
On Wed, 2021-10-20 at 12:47 +0300, Jani Nikula wrote: > On Tue, 19 Oct 2021, José Roberto de Souza wrote: > > The constant platform display version is not using this new struct but > > the runtime variant will definitely use it. > > Cc: Some more folks to hijack this thread. Sorry! ;) > > We

[Intel-gfx] [PATCH] drm/i915/guc: Fix recursive lock in GuC submission

2021-10-20 Thread Matthew Brost
Use __release_guc_id (lock held) rather than release_guc_id (acquires lock), add lockdep annotations. 213.280129] i915: Running i915_perf_live_selftests/live_noa_gpr [ 213.283459] [ 213.283462] WARNING: possible recursive locking detected {{[

Re: [Intel-gfx] [PATCH 1/4] drm: Remove slot checks in dp mst topology during commit

2021-10-20 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2021-10-20 at 10:16 -0400, Bhawanpreet Lakha wrote: > This code path is used during commit, and we dont expect things to fail > during the commit stage, so remove this. > > Signed-off-by: Bhawanpreet Lakha > --- >  drivers/gpu/drm/drm_dp_mst_topology.c | 6

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add struct to hold IP version

2021-10-20 Thread Souza, Jose
On Wed, 2021-10-20 at 15:00 +, Yokoyama, Caz wrote: > On Tue, 2021-10-19 at 17:23 -0700, José Roberto de Souza wrote: > > Adding a structure to standardize access to IP versioning as future > > platforms will have this information populated at runtime. > > > > The constant platform display

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/guc: Fix recursive lock in GuC submission

2021-10-20 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix recursive lock in GuC submission URL : https://patchwork.freedesktop.org/series/96076/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

[Intel-gfx] [PATCH] drm/i915/guc: Fix recursive lock in GuC submission

2021-10-20 Thread Matthew Brost
Use __release_guc_id (lock held) rather than release_guc_id (acquires lock), add lockdep annotations. 213.280129] i915: Running i915_perf_live_selftests/live_noa_gpr [ 213.283459] [ 213.283462] WARNING: possible recursive locking detected {{[

[Intel-gfx] [PATCH 4/4] drm/amd/display: Add DP 2.0 MST DM Support

2021-10-20 Thread Bhawanpreet Lakha
[Why] Add DP2 MST and debugfs support [How] Update the slot info based on the link encoding format Signed-off-by: Bhawanpreet Lakha Signed-off-by: Fangzhi Zuo --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +++ .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 3 ++

[Intel-gfx] [PATCH 1/4] drm: Remove slot checks in dp mst topology during commit

2021-10-20 Thread Bhawanpreet Lakha
This code path is used during commit, and we dont expect things to fail during the commit stage, so remove this. Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/drm_dp_mst_topology.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH 2/4] drm: Update MST First Link Slot Information Based on Encoding Format

2021-10-20 Thread Bhawanpreet Lakha
8b/10b encoding format requires to reserve the first slot for recording metadata. Real data transmission starts from the second slot, with a total of available 63 slots available. In 128b/132b encoding format, metadata is transmitted separately in LLCP packet before MTP. Real data transmission

[Intel-gfx] [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-20 Thread Bhawanpreet Lakha
From: Fangzhi Zuo Signed-off-by: Fangzhi Zuo --- drivers/gpu/drm/amd/display/dc/core/dc.c | 14 + drivers/gpu/drm/amd/display/dc/core/dc_link.c | 280 ++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 19 ++ drivers/gpu/drm/amd/display/dc/dc_link.h | 7 +

[Intel-gfx] [PATCH 09/13] drm: remove i915 selftest config check

2021-10-20 Thread Arunpravin
i915 buddy selftests will be moved to drm selftest folder, hence the config condition check may be removed. Signed-off-by: Arunpravin --- drivers/gpu/drm/drm_buddy.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c index

[Intel-gfx] [PATCH 06/13] drm: implement top-down allocation method

2021-10-20 Thread Arunpravin
Implemented a function which walk through the order list, compares the offset and returns the maximum offset block, this method is unpredictable in obtaining the high range address blocks which depends on allocation and deallocation. for instance, if driver requests address at a low specific

[Intel-gfx] [PATCH 10/13] drm/i915: cleanup i915 buddy and apply DRM buddy

2021-10-20 Thread Arunpravin
Remove i915 buddy references and add DRM buddy functions Signed-off-by: Arunpravin --- drivers/gpu/drm/i915/Makefile | 1 - drivers/gpu/drm/i915/i915_module.c| 3 - drivers/gpu/drm/i915/i915_scatterlist.c | 11 +--

[Intel-gfx] [PATCH 12/13] drm/amdgpu: add cursor support for drm buddy

2021-10-20 Thread Arunpravin
- Add res cursor support for drm buddy - Replace if..else statement with switch case statement Signed-off-by: Arunpravin --- .../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h| 97 +++ 1 file changed, 78 insertions(+), 19 deletions(-) diff --git

[Intel-gfx] [PATCH 07/13] drm: Implement method to free unused pages

2021-10-20 Thread Arunpravin
On contiguous allocation, we round up the size to the nearest power of 2, implement a function to free unused pages. Signed-off-by: Arunpravin --- drivers/gpu/drm/drm_buddy.c | 87 + include/drm/drm_buddy.h | 4 ++ 2 files changed, 91 insertions(+) diff

[Intel-gfx] [PATCH 08/13] drm: export functions and write description

2021-10-20 Thread Arunpravin
Export functions and write kerneldoc description Signed-off-by: Arunpravin --- drivers/gpu/drm/drm_buddy.c | 89 ++--- 1 file changed, 83 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c index

[Intel-gfx] [PATCH 00/13] drm: Enable buddy allocator support

2021-10-20 Thread Arunpravin
This series of patches implemented to move i915 buddy allocator to drm root, and introduce new features include - make drm_buddy_alloc a prime vehicle for allocation - TOPDOWN range of address allocation support - a function to free unused pages on contiguous allocation - a function to allocate

[Intel-gfx] [PATCH 01/13] drm: Move and rename i915 buddy header

2021-10-20 Thread Arunpravin
- Move i915_buddy.h to include/drm - rename "i915" string to "drm" - rename "I915" string to "DRM" Signed-off-by: Arunpravin --- drivers/gpu/drm/i915/i915_buddy.h | 143 -- include/drm/drm_buddy.h | 143 ++ 2 files changed, 143

[Intel-gfx] [PATCH 11/13] drm/amdgpu: move vram defines into a header

2021-10-20 Thread Arunpravin
Move vram defines and inline functions into a header file Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 18 + drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 72 2 files changed, 73 insertions(+), 17 deletions(-) create mode 100644

[Intel-gfx] [PATCH 05/13] drm: remove drm_buddy_alloc_range

2021-10-20 Thread Arunpravin
This function becomes obsolete and may be removed. Signed-off-by: Arunpravin --- drivers/gpu/drm/drm_buddy.c | 101 include/drm/drm_buddy.h | 4 -- 2 files changed, 105 deletions(-) diff --git a/drivers/gpu/drm/drm_buddy.c

[Intel-gfx] [PATCH 03/13] drm: add Makefile support for drm buddy

2021-10-20 Thread Arunpravin
- Include drm buddy to DRM root Makefile - Add drm buddy init and exit function calls to drm core Signed-off-by: Arunpravin --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_drv.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile

[Intel-gfx] [PATCH 02/13] drm: Move and rename i915 buddy source

2021-10-20 Thread Arunpravin
- Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix header file dependencies - Fix alignment issues Signed-off-by: Arunpravin --- .../drm/{i915/i915_buddy.c => drm_buddy.c}|

[Intel-gfx] [PATCH 13/13] drm/amdgpu: cleanup drm_mm and apply DRM buddy

2021-10-20 Thread Arunpravin
Remove drm_mm references and add DRM buddy functions Signed-off-by: Arunpravin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 233 +++ 2 files changed, 138 insertions(+), 99 deletions(-) diff --git

[Intel-gfx] [PATCH 04/13] drm: make drm_buddy_alloc a commonplace

2021-10-20 Thread Arunpravin
- Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands. - Implemented a new function alloc_range() which allocates the requested order (in bytes) comply with range limitations - Moved memory alignment logic from i915 driver Signed-off-by:

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Fix link parameter use in lack of a valid DPCD (rev2)

2021-10-20 Thread Imre Deak
On Tue, Oct 19, 2021 at 02:45:53PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Fix link parameter use in lack of a valid DPCD (rev2) > URL : https://patchwork.freedesktop.org/series/95948/ > State : success Pushed to drm-intel-next, thanks for the reviews. > > ==

Re: [Intel-gfx] [PATCH 2/4] mm: add a io_mapping_map_user helper

2021-10-20 Thread Lucas De Marchi
On Fri, Mar 26, 2021 at 06:55:03AM +0100, Christoph Hellwig wrote: Add a helper that calls remap_pfn_range for an struct io_mapping, relying on the pgprot pre-validation done when creating the mapping instead of doing it at runtime. Signed-off-by: Christoph Hellwig ---

[Intel-gfx] ✓ Fi.CI.IGT: success for replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev5)

2021-10-20 Thread Patchwork
== Series Details == Series: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev5) URL : https://patchwork.freedesktop.org/series/95880/ State : success == Summary == CI Bug Log - changes from CI_DRM_10762_full -> Patchwork_21384_full

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Add warn_on in intel_psr_pause()

2021-10-20 Thread Yokoyama, Caz
On Tue, 2021-10-19 at 17:35 -0700, José Roberto de Souza wrote: > Right now the only user of psr_pause/resume is intel_cdclk but > additional users will be added in the future and we may need > do reference counting for PSR pause and resume, for now only adding a do -> to do? > warn_on so this

Re: [Intel-gfx] [PATCH 8/9] drm/i915: mark up internal objects with start_cpu_write

2021-10-20 Thread Thomas Hellström
On Mon, 2021-10-18 at 18:45 +0100, Matthew Auld wrote: > While the pages can't be swapped out, they can be discarded by the > shrinker. > Normally such objects are marked with __I915_MADV_PURGED, which can't > be > unset, and therefore requires a new object. For kernel internal > objects > this is

  1   2   >