[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Sanity Check for device memory region (rev4)

== Series Details == Series: drm/i915: Sanity Check for device memory region (rev4) URL : https://patchwork.freedesktop.org/series/97715/ State : success == Summary == CI Bug Log - changes from CI_DRM_10984_full -> Patchwork_21806_full

Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice

Thanks Tvrtko, I will try the patch you mentioned. BTW, how do you think we use this patch in our project, any side-effect it may have? If no side-effect we can take it as WA for temporally fix till we got the final root fixed. Thanks, Dong -Original Message- From: Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/debugfs: add noreclaim annotations (rev2)

== Series Details == Series: drm/i915/debugfs: add noreclaim annotations (rev2) URL : https://patchwork.freedesktop.org/series/97966/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10996_full -> Patchwork_21842_full Summary

Re: [Intel-gfx] [PATCH 6/7] drm/amdgpu: Ensure kunmap is called on error

On Mon, Dec 13, 2021 at 09:37:32PM +0100, Christian König wrote: > Am 11.12.21 um 00:24 schrieb ira.we...@intel.com: > > From: Ira Weiny > > > > The default case leaves the buffer object mapped in error. > > > > Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. > > Mhm,

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix implicit use of struct pci_dev

On Tue, Dec 14, 2021 at 01:36:33AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix implicit use of struct pci_dev > URL : https://patchwork.freedesktop.org/series/97975/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_10995_full ->

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix implicit use of struct pci_dev

== Series Details == Series: drm/i915: Fix implicit use of struct pci_dev URL : https://patchwork.freedesktop.org/series/97975/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10995_full -> Patchwork_21841_full Summary

[Intel-gfx] [CI] PR for new DMC v2.14 for ADL-P

The following changes since commit b0e898fbaf377c99a36aac6fdeb7250003648ca4: linux-firmware: Update firmware file for Intel Bluetooth 9462 (2021- 11-23 12:31:45 -0500) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware adlp_dmc_v2.14_update for you to

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency (rev2)

== Series Details == Series: series starting with [v2,1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency (rev2) URL : https://patchwork.freedesktop.org/series/97964/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10997 -> Patchwork_21843

Re: [Intel-gfx] [PATCH 6/7] drm/i915/guc: Kick G2H tasklet if no credits

On 12/11/2021 09:35, Matthew Brost wrote: Let's be paranoid and kick the G2H tasklet, which dequeues messages, if G2H credits are exhausted. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 9 - 1 file changed, 8

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbc: More multi-FBC refactoring (rev3)

== Series Details == Series: drm/i915/fbc: More multi-FBC refactoring (rev3) URL : https://patchwork.freedesktop.org/series/97821/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10995_full -> Patchwork_21839_full Summary

Re: [Intel-gfx] [PATCH 7/7] drm/i915/guc: Selftest for stealing of guc ids

On 12/11/2021 09:35, Matthew Brost wrote: Testing the stealing of guc ids is hard from user space as we have 64k guc_ids. Add a selftest, which artificially reduces the number of guc ids, and forces a steal. Description of test below. Last sentence seems redundant. The test creates a spinner

Re: [Intel-gfx] [Mesa-dev] [PATCH v3 13/17] uapi/drm/dg2: Format modifier for DG2 unified compression and clear color

On 2021-12-09 at 14:41:57 -0500, Nanley Chery wrote: > Ping. I see that a v4 has been sent out without these comments being > addressed. Sorry for the miss. I will address it soon. Ram. > > -Nanley > > On Tue, Dec 7, 2021 at 6:51 PM Nanley Chery wrote: > > > > Hi Ramalingam, > > > > On Wed,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency (rev2)

== Series Details == Series: series starting with [v2,1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency (rev2) URL : https://patchwork.freedesktop.org/series/97964/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used,

[Intel-gfx] [PATCH i-g-t 09/11] tests/i915/i915_hangman: Remove reliance on context persistance

From: John Harrison The hang test was relying on context persitence for no particular reason. That is, it would set a bunch of background spinners running then immediately destroy the active contexts but expect the spinners to keep spinning. With the current implementation of context persistence

[Intel-gfx] [PATCH i-g-t 06/11] tests/i915/i915_hangman: Use the correct context in hangcheck_unterminated

From: John Harrison The hangman framework sets up a context that is valid for all engines and has things like banning disabled. The 'unterminated' test then ignores it and uses the default context. Fix that. Signed-off-by: John Harrison --- tests/i915/i915_hangman.c | 1 + 1 file changed, 1

[Intel-gfx] [PATCH i-g-t 10/11] tests/i915/i915_hangman: Run background task on all engines

From: John Harrison As opposed to only on the non-target engines. This means that there is some other workload present for the scheduler to switch between and so detet the hang immediately. Signed-off-by: John Harrison --- tests/i915/i915_hangman.c | 10 ++ 1 file changed, 6

[Intel-gfx] [PATCH i-g-t 07/11] tests/i915/i915_hangman: Add alive-ness test after error capture

From: John Harrison Added a an extra step to the i915_hangman tests to check that the system is still alive after the hang and recovery. This submits a simple batch to each engine which does a write to memory and checks that the write occurred. Signed-off-by: John Harrison ---

[Intel-gfx] [PATCH i-g-t 05/11] tests/i915/i915_hangman: Add uevent test & fix detector

From: John Harrison Some of the IGT framework relies on receving a uevent when a hang occurs. So add a test that this actually works. While testing this, noticed that hangs could sometimes be missed because the uevent was (presumably) still in flight by the time the handler was de-registered.

[Intel-gfx] [PATCH i-g-t 11/11] tests/i915/gem_exec_fence: Configure correct context

From: John Harrison The update to use intel_ctx_t missed a line that configures the context to allow hanging. Fix that. Fixes: 09c36188b23f83ef9a7b5414e2a10100adc4291f Signed-off-by: John Harrison --- tests/i915/gem_exec_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH i-g-t 03/11] tests/i915/i915_hangman: Update capture test to use engine structure

From: John Harrison The capture test was still using old style ring_id and ring_name (derived from the engine structure at the higher level). Update it to just take the engine structure directly. Signed-off-by: John Harrison --- tests/i915/i915_hangman.c | 10 +- 1 file changed, 5

[Intel-gfx] [PATCH i-g-t 08/11] lib/store: Refactor common store code into helper function

From: John Harrison A lot of tests use almost identical code for creating a batch buffer which does a single write to memory. This patch collects two such instances into a common helper function. Unfortunately, the other instances are all subtly different enough to make it not so trivial to try

[Intel-gfx] [PATCH i-g-t 01/11] tests/i915/i915_hangman: Add descriptions

From: John Harrison Added descriptions of the various sub-tests and the test as a whole. Signed-off-by: John Harrison --- tests/i915/i915_hangman.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c index

[Intel-gfx] [PATCH i-g-t 04/11] tests/i915/i915_hangman: Explicitly test per engine reset vs full GPU reset

From: John Harrison Although the hangman test was ensuring that *some* reset functionality was enabled, it did not differentiate what kind. The infrastructure required to choose between per engine reset or full GT reset was recently added. So update this test to use it as well. Signed-off-by:

[Intel-gfx] [PATCH i-g-t 02/11] lib/hang: Fix igt_require_hang_ring to work with all engines

From: John Harrison The above function was checking for valid rings via the old interface. The new scheme is to check for engines on contexts as there are now more engines than could be supported. Signed-off-by: John Harrison --- lib/igt_gt.c | 6 +++--- lib/igt_gt.h

[Intel-gfx] [PATCH i-g-t 00/11] Fixes for i915_hangman and gem_exec_capture

From: John Harrison Fix a bunch of issues with i915_hangman and gem_exec_capture with the ultimate aim of making them pass on GuC enabled platforms. Signed-off-by: John Harrison John Harrison (11): tests/i915/i915_hangman: Add descriptions lib/hang: Fix igt_require_hang_ring to work with

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Pass plane to watermark calculation functions (rev3)

== Series Details == Series: series starting with [1/4] drm/i915: Pass plane to watermark calculation functions (rev3) URL : https://patchwork.freedesktop.org/series/97652/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10995_full -> Patchwork_21835_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: add noreclaim annotations (rev2)

== Series Details == Series: drm/i915/debugfs: add noreclaim annotations (rev2) URL : https://patchwork.freedesktop.org/series/97966/ State : success == Summary == CI Bug Log - changes from CI_DRM_10996 -> Patchwork_21842 Summary ---

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

On Mon, 13 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Parametrize ilk+ FBC register offsets based on the FBC instance. > > v2: More intel_ namespace (Jani) > > Cc: Jani Nikula > Signed-off-by: Ville Syrjälä Some questions below, apart from that, Reviewed-by: Jani Nikula > ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix implicit use of struct pci_dev

== Series Details == Series: drm/i915: Fix implicit use of struct pci_dev URL : https://patchwork.freedesktop.org/series/97975/ State : success == Summary == CI Bug Log - changes from CI_DRM_10995 -> Patchwork_21841 Summary ---

Re: [Intel-gfx] [PATCH v2 0/3] drm/i915: Support bigger GuC RSA keys

On 12/10/2021 4:07 PM, Daniele Ceraolo Spurio wrote: Some of the newer platforms use a bigger RSA key to authenticate the GuC, which is provided to the HW via a ggtt-pinned object instead of mmio. While doing the changes for this I've also spotted an inconsistency in the error status of the

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Support bigger GuC RSA keys

On 12/11/2021 2:12 PM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915: Support bigger GuC RSA keys *URL:* https://patchwork.freedesktop.org/series/97891/ *State:*failure *Details:*

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix implicit use of struct pci_dev

== Series Details == Series: drm/i915: Fix implicit use of struct pci_dev URL : https://patchwork.freedesktop.org/series/97975/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix implicit use of struct pci_dev

== Series Details == Series: drm/i915: Fix implicit use of struct pci_dev URL : https://patchwork.freedesktop.org/series/97975/ State : warning == Summary == $ dim checkpatch origin/drm-tip be0180f70dc2 drm/i915: Fix implicit use of struct pci_dev -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] ✗ Fi.CI.BUILD: failure for DRM kmap() fixes and kmap_local_page() conversions (rev2)

== Series Details == Series: DRM kmap() fixes and kmap_local_page() conversions (rev2) URL : https://patchwork.freedesktop.org/series/97889/ State : failure == Summary == Applying: drm/i915: Replace kmap() with kmap_local_page() error: patch failed: include/linux/highmem-internal.h:246 error:

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/fbc: Register per-crtc debugfs files

On Mon, 13 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Expose FBC debugfs files for each crtc. These may or may not point > to the same FBC instance depending on the platform. > > We leave the old global debugfs files in place until > igt catches up to the new per-crtc approach. > >

Re: [Intel-gfx] [PATCH v4 2/6] drm: improve drm_buddy_alloc function

On 09/12/2021 15:47, Paneer Selvam, Arunpravin wrote: [AMD Official Use Only] Hi Matthew, Ping on this? No new comments from me :) I guess just a question of what we should do with the selftests, and then ofc at some point being able to throw this at CI, or at least test locally, once the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: More multi-FBC refactoring (rev3)

== Series Details == Series: drm/i915/fbc: More multi-FBC refactoring (rev3) URL : https://patchwork.freedesktop.org/series/97821/ State : success == Summary == CI Bug Log - changes from CI_DRM_10995 -> Patchwork_21839 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Fix implicit use of struct pci_dev

On Mon, 13 Dec 2021, broo...@kernel.org wrote: > From: Mark Brown > > intel_device_info.h references struct pci_dev but does not ensure that > the struct has been declared, causing build failures if something in > other headers changes so that the implicit dependency it is relying on > is no

Re: [Intel-gfx] [PATCH v4 4/6] drm: implement a method to free unused pages

On 01/12/2021 16:39, Arunpravin wrote: On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for More fixes/tweaks to GuC support

On 12/11/2021 18:43, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* More fixes/tweaks to GuC support *URL:* https://patchwork.freedesktop.org/series/97898/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21832/index.html CI

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/fbc: More multi-FBC refactoring (rev3)

== Series Details == Series: drm/i915/fbc: More multi-FBC refactoring (rev3) URL : https://patchwork.freedesktop.org/series/97821/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH RESEND v7 12/12] drm/i915: Move the GGTT from i915 private data to the GT

Hi Matt, On Mon, Dec 13, 2021 at 10:16:47AM -0800, Matt Roper wrote: > On Sun, Dec 12, 2021 at 05:21:17PM +0200, Andi Shyti wrote: > > GGTT was available both through i915->ggtt and gt->ggtt, and we > > eventually want to get rid of the i915->ggtt one. > > Move the GGTT from i915 to gt and use

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fbc: More multi-FBC refactoring (rev3)

== Series Details == Series: drm/i915/fbc: More multi-FBC refactoring (rev3) URL : https://patchwork.freedesktop.org/series/97821/ State : warning == Summary == $ dim checkpatch origin/drm-tip 88faeb3cb9ee drm/i915/fbc: Parametrize FBC register offsets ca4050953f1b drm/i915/fbc: Loop through

Re: [Intel-gfx] [PATCH RESEND v7 12/12] drm/i915: Move the GGTT from i915 private data to the GT

On Sun, Dec 12, 2021 at 05:21:17PM +0200, Andi Shyti wrote: > GGTT was available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Move the GGTT from i915 to gt and use to_gt() for accesssing the > ggtt. > > Signed-off-by: Andi Shyti > Cc: Michal

Re: [Intel-gfx] [PATCH RESEND v7 11/12] drm/i915: Use to_gt() helper for GGTT accesses

Hi Matt, > > diff --git a/drivers/gpu/drm/i915/i915_driver.c > > b/drivers/gpu/drm/i915/i915_driver.c > > index 95174938b160..2619bb17b6eb 100644 > > --- a/drivers/gpu/drm/i915/i915_driver.c > > +++ b/drivers/gpu/drm/i915/i915_driver.c > > @@ -571,6 +571,8 @@ static int

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/debugfs: add noreclaim annotations

== Series Details == Series: drm/i915/debugfs: add noreclaim annotations URL : https://patchwork.freedesktop.org/series/97966/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10995 -> Patchwork_21838 Summary ---

Re: [Intel-gfx] [PATCH RESEND v7 11/12] drm/i915: Use to_gt() helper for GGTT accesses

On Sun, Dec 12, 2021 at 05:21:16PM +0200, Andi Shyti wrote: > From: Michał Winiarski > > GGTT is currently available both through i915->ggtt and gt->ggtt, and we > eventually want to get rid of the i915->ggtt one. > Use to_gt() for all i915->ggtt accesses to help with the future > refactoring. >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency

== Series Details == Series: series starting with [v2,1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency URL : https://patchwork.freedesktop.org/series/97964/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10995 -> Patchwork_21837

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Don't leak the capture list items (rev2)

Regressions are related to https://gitlab.freedesktop.org/drm/intel/-/issues/4729 igt@kms_plane_cursor@.* - fail - Failed assertion: !mismatch || igt_skip_crc_compare https://gitlab.freedesktop.org/drm/intel/-/issues/3653 igt@kms_big_fb.*

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: fix large buffer population trucation

Similar failures are noticed from https://patchwork.freedesktop.org/series/97804/ I address the failures and updated the filters. These are related to https://gitlab.freedesktop.org/drm/intel/-/issues/4729 igt@kms_plane_cursor@.* - fail - Failed assertion:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ttm: fix large buffer population trucation

== Series Details == Series: drm/i915/ttm: fix large buffer population trucation URL : https://patchwork.freedesktop.org/series/97881/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988_full -> Patchwork_21826_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency

== Series Details == Series: series starting with [v2,1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency URL : https://patchwork.freedesktop.org/series/97964/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Don't leak the capture list items (rev2)

== Series Details == Series: drm/i915: Don't leak the capture list items (rev2) URL : https://patchwork.freedesktop.org/series/97804/ State : success == Summary == CI Bug Log - changes from CI_DRM_10988_full -> Patchwork_21820_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/dp: Move DisplayPort helpers into own module

== Series Details == Series: drm/dp: Move DisplayPort helpers into own module URL : https://patchwork.freedesktop.org/series/97961/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10995 -> Patchwork_21836 Summary ---

[Intel-gfx] [PATCH] drm/i915: Fix implicit use of struct pci_dev

From: Mark Brown intel_device_info.h references struct pci_dev but does not ensure that the struct has been declared, causing build failures if something in other headers changes so that the implicit dependency it is relying on is no longer satisfied: In file included from

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp: Move DisplayPort helpers into own module

== Series Details == Series: drm/dp: Move DisplayPort helpers into own module URL : https://patchwork.freedesktop.org/series/97961/ State : warning == Summary == $ dim checkpatch origin/drm-tip b1594004c5f8 drm/dp_mst: Remove trailing whitespace. 0253bcc87c2b drm/dp: Move DP declarations into

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Pass plane to watermark calculation functions (rev3)

== Series Details == Series: series starting with [1/4] drm/i915: Pass plane to watermark calculation functions (rev3) URL : https://patchwork.freedesktop.org/series/97652/ State : success == Summary == CI Bug Log - changes from CI_DRM_10995 -> Patchwork_21835

Re: [Intel-gfx] [PATCH RESEND v7 12/12] drm/i915: Move the GGTT from i915 private data to the GT

-randconfig-a003-20211213 (https://download.01.org/0day-ci/archive/20211213/202112132358.iwecweww-...@intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c) reproduce (this is a W=1 build): wget https

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915: Pass plane to watermark calculation functions (rev3)

== Series Details == Series: series starting with [1/4] drm/i915: Pass plane to watermark calculation functions (rev3) URL : https://patchwork.freedesktop.org/series/97652/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Pass plane to watermark calculation functions (rev3)

== Series Details == Series: series starting with [1/4] drm/i915: Pass plane to watermark calculation functions (rev3) URL : https://patchwork.freedesktop.org/series/97652/ State : warning == Summary == $ dim checkpatch origin/drm-tip d760c31a88db drm/i915: Pass plane to watermark

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

On Mon, Dec 13, 2021 at 01:04:07AM -0800, Christoph Hellwig wrote: > On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > > - vaddr = kmap(page); > > + vaddr = kmap_local_page(page); > > memcpy(vaddr, data, len); > > - kunmap(page); > > +

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

On Mon, Dec 13, 2021 at 02:39:59PM +0200, Ville Syrjälä wrote: > On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > kmap() is being deprecated and these usages are all local to the thread > > so there is no reason kmap_local_page() can't be used. > >

Re: [Intel-gfx] [PATCH v3 5/8] drm/i915/gtt: allow overriding the pt alignment

On 2021-12-06 at 13:31:37 +, Matthew Auld wrote: > On some platforms we have alignment restrictions when accessing LMEM > from the GTT. In the next patch few patches we need to be able to modify probably extra "patch" Apart from that looks good to me Reviewed-by : Ramalingam C > the

[Intel-gfx] [PATCH v3 4/4] drm/i915/fbc: Register per-crtc debugfs files

From: Ville Syrjälä Expose FBC debugfs files for each crtc. These may or may not point to the same FBC instance depending on the platform. We leave the old global debugfs files in place until igt catches up to the new per-crtc approach. v2: Take a trip via intel_crtc_debugfs_add() (Jani) Cc:

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/fbc: Register per-crtc debugfs files

On Mon, Dec 13, 2021 at 04:01:15PM +0200, Jani Nikula wrote: > On Mon, 13 Dec 2021, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Expose FBC debugfs files for each crtc. These may or may not point > > to the same FBC instance depending on the platform. > > > > We leave the old global

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fix inconsistent object in IS_ERR and PTR_ERR

I have no idea why it failed without a detailed log, from my humble opinion, this bug indeed exists and is easy to understand, I hope someone could look into it. Patchwork 于2021年12月11日周六 00:40写道： > *Patch Details* > *Series:* drm/i915/selftests: Fix inconsistent object in IS_ERR and > PTR_ERR >

Re: [Intel-gfx] [PATCH 7/9] drm/i915/gvt: Constify formats

On Fri, Dec 10, 2021 at 08:20:22AM +, Wang, Zhi A wrote: > On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > > These are never modified, so make them const to allow the compiler to > > put them in read-only memory. WHile at it, make the description const > > char* since it is never modified. >

Re: [Intel-gfx] [PATCH 0/9] drm/i915/gvt: Constify static structs

On Fri, Dec 10, 2021 at 09:00:56AM +, Wang, Zhi A wrote: > On 12/4/2021 12:55 PM, Rikard Falkeborn wrote: > > Constify a number of static structs that are never modified to allow the > > compiler to put them in read-only memory. In order to do this, constify a > > number of local variables and

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915/fbc: Register per-crtc debugfs files

On Mon, 13 Dec 2021, Ville Syrjala wrote: > From: Ville Syrjälä > > Expose FBC debugfs files for each crtc. These may or may not point > to the same FBC instance depending on the platform. > > We leave the old global debugfs files in place until > igt catches up to the new per-crtc approach. > >

Re: [Intel-gfx] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

Hi Am 13.12.21 um 14:34 schrieb Jani Nikula: On Mon, 13 Dec 2021, Thomas Zimmermann wrote: Split-off DisplayPort functions from KMS helper library and move them into their own module. Reduces the size of drm_kms_helper.ko by ~50%. This patchset is part of an on-going effort to reduce the

Re: [Intel-gfx] KMS start locks up RocketLake-S GT1

Felix Miata composed on 2021-12-12 00:37 (UTC-0500): > Is there a command line option needed for RocketLake-S GT1 on i5-11400? Is it > supposed to use some module other than i915? Tumbleweed kernel 5.15.6 locks > up, > apparently when KMS should be kicking in. I can't get any logs or dmesg

[Intel-gfx] [PATCH v2 4/4] drm/i915/fbc: Register per-crtc debugfs files

From: Ville Syrjälä Expose FBC debugfs files for each crtc. These may or may not point to the same FBC instance depending on the platform. We leave the old global debugfs files in place until igt catches up to the new per-crtc approach. Cc: Jani Nikula Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 3/4] drm/i915/fbc: Introduce device info fbc_mask

From: Ville Syrjälä Declare which FBC instances are present via a fbc_mask in device info. For the moment there is just the one. TODO: Need to figure out how to expose multiple FBC instances in debugs. Just different file names, or move the files under some subdirectory (per-crtc maybe), or

[Intel-gfx] [PATCH v2 2/4] drm/i915/fbc: Loop through FBC instances in various places

From: Ville Syrjälä Convert i915->fbc into an array in preparation for multiple FBC instances, and loop through all instances in all places where the caller does not know which instance(s) (if any) are relevant. This is the case for eg. frontbuffer tracking and FIFO underrun hadling. v2: More

[Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Parametrize FBC register offsets

From: Ville Syrjälä Parametrize ilk+ FBC register offsets based on the FBC instance. v2: More intel_ namespace (Jani) Cc: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fbc.c | 34 +--- drivers/gpu/drm/i915/display/intel_fbc.h | 6 +

[Intel-gfx] [PATCH v2 0/4] drm/i915/fbc: More multi-FBC refactoring

From: Ville Syrjälä A bit more prep work towards multiple FBC instances. Main changes since v1: - More intel_ namespace - per-crtc debugfs files - a few other review comments addressed Cc: Jani Nikula Ville Syrjälä (4):

Re: [Intel-gfx] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split-off DisplayPort functions from KMS helper library and move them > into their own module. Reduces the size of drm_kms_helper.ko by ~50%. > > This patchset is part of an on-going effort to reduce the minimum > binary size of the DRM core and

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: fix large buffer population trucation

On Sat, 11 Dec 2021 at 18:46, Patchwork wrote: > *Patch Details* > *Series:* drm/i915/ttm: fix large buffer population trucation > *URL:* https://patchwork.freedesktop.org/series/97881/ > *State:* failure > *Details:* > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21826/index.html CI > Bug

Re: [Intel-gfx] [PATCH] drm/i915/ttm: fix large buffer population trucation

On 10/12/2021 19:50, Robert Beckett wrote: ttm->num_pages is uint32_t which was causing very large buffers to only populate a truncated size. This fixes gem_create@create-clear igt test on large memory systems. Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") Signed-off-by: Robert

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: add noreclaim annotations

On 12/13/21 13:55, Matthew Auld wrote: We have a debugfs hook to directly call into i915_gem_shrink() with the fs_reclaim acquire annotations to simulate hitting direct reclaim. However we should also annotate this with memalloc_noreclaim, which will set PF_MEMALLOC for us on the current

[Intel-gfx] [PATCH] drm/i915/debugfs: add noreclaim annotations

We have a debugfs hook to directly call into i915_gem_shrink() with the fs_reclaim acquire annotations to simulate hitting direct reclaim. However we should also annotate this with memalloc_noreclaim, which will set PF_MEMALLOC for us on the current context, to ensure we can't re-enter direct

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/cdclk: move struct intel_cdclk_funcs to intel_cdclk.c

On Mon, Dec 13, 2021 at 01:41:06PM +0200, Jani Nikula wrote: > The funcs struct can be opaque, make it internal to intel_cdclk.c. > > Suggested-by: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 11 +++ >

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Replace kmap() with kmap_local_page()

On Fri, Dec 10, 2021 at 03:23:58PM -0800, ira.we...@intel.com wrote: > From: Ira Weiny > > kmap() is being deprecated and these usages are all local to the thread > so there is no reason kmap_local_page() can't be used. > > Replace kmap() calls with kmap_local_page(). > > Signed-off-by: Ira

[Intel-gfx] [PATCH v2 2/2] drm/i915/cdclk: move struct intel_cdclk_funcs to intel_cdclk.c

The funcs struct can be opaque, make it internal to intel_cdclk.c. Suggested-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_cdclk.c | 11 +++ drivers/gpu/drm/i915/i915_drv.h| 12 +--- 2 files changed, 12 insertions(+), 11

[Intel-gfx] [PATCH v2 1/2] drm/i915/cdclk: turn around i915_drv.h and intel_cdclk.h dependency

intel_cdclk.h only needs i915_drv.h for struct intel_cdclk_config. Move the definition to intel_cdclk.h and turn the includes around to avoid including i915_drv.h from other headers. The intel cdclk state macros in intel_cdclk.h still reference struct drm_i915_private, but as macros they don't

Re: [Intel-gfx] [PATCH 2/3] drm/dp: Move DP declarations into separate header file

On Mon, 13 Dec 2021, Thomas Zimmermann wrote: > Split the DP declarations from other helpers before moving the > DP functions into a separate module. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_crtc_helper_internal.h | 27 - >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Don't leak the capture list items (rev2)

On Sat, 2021-12-11 at 09:49 +, Patchwork wrote: > Patch Details > Series:drm/i915: Don't leak the capture list items > (rev2)URL:https://patchwork.freedesktop.org/series/97804/State:failur > e > Details:https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21820/index.html > CI Bug Log - changes

Re: [Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice

On 13/12/2021 01:53, Yang, Dong wrote: I am working on a customized kernel based on 5.4.39, issue can only reproduced when system facing low memory pressure, and system try to reclaim memory, then wrong double insert i915_reqeust coming from the i915_gem_shrink() path. 5.4 is quite old

[Intel-gfx] [PATCH 3/3] drm/dp: Move DisplayPort helpers into separate helper module

Move DisplayPort functions into a separate module to reduce the size of the KMS helpers. Select DRM_DP_HELPER for all users of the code. To avoid naming conflicts, rename drm_dp_helper.c to drm_dp.c This change can help to reduce the size of the kernel binary. Some numbers from a x86-64 test

[Intel-gfx] [PATCH 2/3] drm/dp: Move DP declarations into separate header file

Split the DP declarations from other helpers before moving the DP functions into a separate module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_crtc_helper_internal.h | 27 - drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- drivers/gpu/drm/drm_dp_helper.c

[Intel-gfx] [PATCH 1/3] drm/dp_mst: Remove trailing whitespace.

Fix coding style. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index f3d79eda94bb..7f0ff96261cf 100644 ---

[Intel-gfx] [PATCH 0/3] drm/dp: Move DisplayPort helpers into own module

Split-off DisplayPort functions from KMS helper library and move them into their own module. Reduces the size of drm_kms_helper.ko by ~50%. This patchset is part of an on-going effort to reduce the minimum binary size of the DRM core and helpers. It's helpful for systems with early-boot DRM

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't disable interrupts and pretend a lock as been acquired in __timeline_mark_lock().

On 10/12/2021 20:44, Sebastian Andrzej Siewior wrote: This is a revert of commits d67739268cf0e ("drm/i915/gt: Mark up the nested engine-pm timeline lock as irqsafe") 6c69a45445af9 ("drm/i915/gt: Mark context->active_count as protected by timeline->mutex") 6dcb85a0ad990

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Bump DMC to v2.14 on ADL-P (rev2)

Hi, > -Original Message- > From: Intel-gfx On Behalf Of > Patchwork > Sent: torstai 2. joulukuuta 2021 1.35 > To: Tolakanahalli Pradeep, Madhumitha > > Cc: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] ✓ Fi.CI.BAT: success for Bump DMC to v2.14 on ADL-P > (rev2) > > Patch