Re: [Intel-gfx] [PATCH 4/4] drm/i915: Don't allocate extra ddb during async flip for DG2

2022-01-23 Thread Ville Syrjälä
On Sun, Jan 23, 2022 at 10:34:17PM +0200, Lisovskiy, Stanislav wrote: > On Fri, Jan 21, 2022 at 02:06:12PM +0200, Ville Syrjälä wrote: > > On Fri, Jan 21, 2022 at 10:06:15AM +0200, Stanislav Lisovskiy wrote: > > > In terms of async flip optimization we don't to allocate > > > extra ddb space, so le

Re: [Intel-gfx] [PATCH] drm/i915: fix header file inclusion for might_alloc()

2022-01-23 Thread Thomas Hellström
On Mon, 2022-01-24 at 03:08 +0200, Andi Shyti wrote: > Replace "linux/slab.h" with "linux/sched/mm.h" header inclusion > as the first is not required, while the second, if not included, > prdouces the following error: > > drivers/gpu/drm/i915/i915_vma_resource.c: In function > ‘i915_vma_resource_b

[Intel-gfx] ✗ Fi.CI.IGT: failure for DRM kmap() fixes and kmap_local_page() conversions (rev4)

2022-01-23 Thread Patchwork
== Series Details == Series: DRM kmap() fixes and kmap_local_page() conversions (rev4) URL : https://patchwork.freedesktop.org/series/97889/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120_full -> Patchwork_22074_full S

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: fix header file inclusion for might_alloc()

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915: fix header file inclusion for might_alloc() URL : https://patchwork.freedesktop.org/series/99215/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120_full -> Patchwork_22073_full Summa

[Intel-gfx] ✓ Fi.CI.BAT: success for DRM kmap() fixes and kmap_local_page() conversions (rev4)

2022-01-23 Thread Patchwork
== Series Details == Series: DRM kmap() fixes and kmap_local_page() conversions (rev4) URL : https://patchwork.freedesktop.org/series/97889/ State : success == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22074 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DRM kmap() fixes and kmap_local_page() conversions (rev4)

2022-01-23 Thread Patchwork
== Series Details == Series: DRM kmap() fixes and kmap_local_page() conversions (rev4) URL : https://patchwork.freedesktop.org/series/97889/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH V2 7/7] drm/radeon: Ensure kunmap is called on error

2022-01-23 Thread ira . weiny
From: Ira Weiny The default case leaves the buffer object mapped in error. Add radeon_bo_kunmap() to that case to ensure the mapping is cleaned up. Signed-off-by: Ira Weiny --- NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual

[Intel-gfx] [PATCH V2 6/7] drm/amdgpu: Ensure kunmap is called on error

2022-01-23 Thread ira . weiny
From: Ira Weiny The default case leaves the buffer object mapped in error. Add amdgpu_bo_kunmap() to that case to ensure the mapping is cleaned up. Signed-off-by: Ira Weiny --- NOTE: It seems like this function could use a fair bit of refactoring but this is the easiest way to fix the actual

[Intel-gfx] [PATCH V2 3/7] drm/gma: Remove calls to kmap()

2022-01-23 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated and these instances are easy to convert to kmap_local_page(). Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper instead of an open coded use of kmap_local_page(). Signed-off-by: Ira Weiny --- drivers/gpu/drm/gma500/gma_display.c

[Intel-gfx] [PATCH V2 5/7] drm/msm: Alter comment to use kmap_local_page()

2022-01-23 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated. So this comment could be misleading in the future. Change this comment to point to using kmap_local_page(). While here remove 'we' from the comment. Signed-off-by: Ira Weiny --- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- 1 file changed, 2 inse

[Intel-gfx] [PATCH V2 1/7] drm/i915: Replace kmap() with kmap_local_page()

2022-01-23 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated and these usages are all local to the thread so there is no reason kmap_local_page() can't be used. Replace kmap() calls with kmap_local_page(). Signed-off-by: Ira Weiny --- Changes for V2: From Christoph Helwig Prefer the use of memc

[Intel-gfx] [PATCH V2 4/7] drm/radeon: Replace kmap() with kmap_local_page()

2022-01-23 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated and this usage is local to the thread. Use kmap_local_page() instead. Signed-off-by: Ira Weiny --- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/driv

[Intel-gfx] [PATCH V2 0/7] DRM kmap() fixes and kmap_local_page() conversions

2022-01-23 Thread ira . weiny
From: Ira Weiny Changes from V1: Use memcpy_to_page() where appropriate Rebased to latest The kmap() call may cause issues with work being done with persistent memory. For this and other reasons it is being deprecated. This series starts by converting the last easy kmap() uses i

[Intel-gfx] [PATCH V2 2/7] drm/amd: Replace kmap() with kmap_local_page()

2022-01-23 Thread ira . weiny
From: Ira Weiny kmap() is being deprecated. These maps are thread local and can be replaced with kmap_local_page(). Replace kmap() with kmap_local_page() Signed-off-by: Ira Weiny --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix header file inclusion for might_alloc()

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915: fix header file inclusion for might_alloc() URL : https://patchwork.freedesktop.org/series/99215/ State : success == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22073 Summary ---

[Intel-gfx] [PATCH] drm/i915: fix header file inclusion for might_alloc()

2022-01-23 Thread Andi Shyti
Replace "linux/slab.h" with "linux/sched/mm.h" header inclusion as the first is not required, while the second, if not included, prdouces the following error: drivers/gpu/drm/i915/i915_vma_resource.c: In function ‘i915_vma_resource_bind_dep_await’: drivers/gpu/drm/i915/i915_vma_resource.c:381:9:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: Add Wa_18018781329 (rev7)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev7) URL : https://patchwork.freedesktop.org/series/99128/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120_full -> Patchwork_22072_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Add Wa_18018781329 (rev7)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev7) URL : https://patchwork.freedesktop.org/series/99128/ State : success == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22072 Summary --- **SUCCESS*

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Add Wa_18018781329 (rev7)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev7) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Add Wa_18018781329 (rev7)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev7) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim checkpatch origin/drm-tip 75775f06764b drm/i915/dg2: Add Wa_18018781329 -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit de

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Use less in contexts steal guc id test (rev3)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use less in contexts steal guc id test (rev3) URL : https://patchwork.freedesktop.org/series/99179/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120_full -> Patchwork_22071_full ===

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Don't allocate extra ddb during async flip for DG2

2022-01-23 Thread Lisovskiy, Stanislav
On Fri, Jan 21, 2022 at 02:06:12PM +0200, Ville Syrjälä wrote: > On Fri, Jan 21, 2022 at 10:06:15AM +0200, Stanislav Lisovskiy wrote: > > In terms of async flip optimization we don't to allocate > > extra ddb space, so lets skip it. > > > > v2: - Extracted min ddb async flip check to separate func

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Use less in contexts steal guc id test (rev3)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use less in contexts steal guc id test (rev3) URL : https://patchwork.freedesktop.org/series/99179/ State : success == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22071 Sum

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Add Wa_18018781329 (rev6)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev6) URL : https://patchwork.freedesktop.org/series/99128/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22070 Summary --- **FAILURE*

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Add Wa_18018781329 (rev6)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev6) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Add Wa_18018781329 (rev6)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev6) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim checkpatch origin/drm-tip d6d332ac43bd drm/i915/dg2: Add Wa_18018781329 -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit de

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dg2: Add Wa_18018781329 (rev5)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev5) URL : https://patchwork.freedesktop.org/series/99128/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11120 -> Patchwork_22069 Summary --- **FAILURE*

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Add Wa_18018781329 (rev5)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev5) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Add Wa_18018781329 (rev5)

2022-01-23 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add Wa_18018781329 (rev5) URL : https://patchwork.freedesktop.org/series/99128/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0b7255177bf4 drm/i915/dg2: Add Wa_18018781329 -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit de