[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v1,1/1] drm/i915/selftests: Replace too verbose for-loop with simpler while

2022-02-16 Thread Patchwork
== Series Details == Series: series starting with [v1,1/1] drm/i915/selftests: Replace too verbose for-loop with simpler while URL : https://patchwork.freedesktop.org/series/100189/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11238_full -> Patchwork_22285_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Refactor ADS access to use iosys_map (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use iosys_map (rev3) URL : https://patchwork.freedesktop.org/series/99711/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22301 Summary

Re: [Intel-gfx] [PATCH v2] drm/i915: fix build issue when using clang

2022-02-16 Thread Jani Nikula
On Tue, 15 Feb 2022, Nathan Chancellor wrote: > On Mon, Feb 14, 2022 at 11:58:20AM -0800, Tong Zhang wrote: >> drm/i915 adds some extra cflags, namely -Wall, which causes >> instances of -Wformat-security to appear when building with clang, even >> though this warning is turned off kernel-wide in

Re: [Intel-gfx] [PATCH] drm/i915/gvt: #include drm_edid.h for drm_edid_block_valid()

2022-02-16 Thread Jani Nikula
On Wed, 16 Feb 2022, "Wang, Zhi A" wrote: > On 2/15/22 12:20 PM, Nikula, Jani wrote: >> As the excessive #includes from i915_drv.h were axed, kvmgt.c build >> started failing. Add the necessary #include where needed. >> >> Reported-by: Stephen Rothwell >> Fixes: 14da21cc4671 ("drm/i915: axe

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use iosys_map (rev3) URL : https://patchwork.freedesktop.org/series/99711/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/guc: Refactor ADS access to use iosys_map (rev3) URL : https://patchwork.freedesktop.org/series/99711/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3c4f364a17be iosys-map: Add offset to iosys_map_memcpy_to() 7ab81996b485 iosys-map: Add a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ttm: fixup the mock_bo

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fixup the mock_bo URL : https://patchwork.freedesktop.org/series/100255/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22300 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: fix build issue when using clang (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915: fix build issue when using clang (rev2) URL : https://patchwork.freedesktop.org/series/100114/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11238_full -> Patchwork_22284_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/ttm: fixup the mock_bo

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/ttm: fixup the mock_bo URL : https://patchwork.freedesktop.org/series/100255/ State : warning == Summary == $ dim checkpatch origin/drm-tip f26bf9b55a4d drm/i915/ttm: fixup the mock_bo -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

Re: [Intel-gfx] [PATCH] drm/i915: Kill the fake lmem support

2022-02-16 Thread Lucas De Marchi
On Wed, Feb 16, 2022 at 03:18:49PM -0800, Lucas De Marchi wrote: This was useful for early development of lmem, but it's not used anymore, so remove it. Cc: Chris Wilson Cc: Matthew Auld Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/Kconfig.unstable | 8 --

Re: [Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/solomon/ssd130x.c:451:18: error: incomplete definition of type 'struct dma_buf_map'

2022-02-16 Thread Lucas De Marchi
+Javier On Thu, Feb 17, 2022 at 02:25:08PM +0800, kernel test robot wrote: tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: e141e36b2871c529379f7ec7d5d6ebae3137a51b commit: 7ca6504c36709f35c4cc38ae6acc1c9c3d72136f [4/8] Merge remote-tracking branch 'drm-misc/drm-misc-next'

[Intel-gfx] [drm-tip:drm-tip 4/8] drivers/gpu/drm/solomon/ssd130x.c:451:18: error: incomplete definition of type 'struct dma_buf_map'

2022-02-16 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: e141e36b2871c529379f7ec7d5d6ebae3137a51b commit: 7ca6504c36709f35c4cc38ae6acc1c9c3d72136f [4/8] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip config: mips-buildonly-randconfig-r002-20220217

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use wrapper for reading RP_STATE_CAP

2022-02-16 Thread Matt Roper
On Tue, Feb 15, 2022 at 06:58:17PM -0800, Vinay Belgaumkar wrote: > This will ensure correct values for Gen12+ platforms. > > Cc: Matt Roper > Signed-off-by: Vinay Belgaumkar Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 5 +++-- > 1 file changed, 3

[Intel-gfx] ✓ Fi.CI.BAT: success for treewide: Replace zero-length arrays with flexible-array members

2022-02-16 Thread Patchwork
== Series Details == Series: treewide: Replace zero-length arrays with flexible-array members URL : https://patchwork.freedesktop.org/series/100251/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22299

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Introduce intel_crtc_planes_update_arm()

2022-02-16 Thread Jani Nikula
On Thu, 17 Feb 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > No reason the high level intel_update_crtc() needs to know > that there is something magical about the commit order of > planes between different platforms. So let's hide that > detail even better. > > In order to keep to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for treewide: Replace zero-length arrays with flexible-array members

2022-02-16 Thread Patchwork
== Series Details == Series: treewide: Replace zero-length arrays with flexible-array members URL : https://patchwork.freedesktop.org/series/100251/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for treewide: Replace zero-length arrays with flexible-array members

2022-02-16 Thread Patchwork
== Series Details == Series: treewide: Replace zero-length arrays with flexible-array members URL : https://patchwork.freedesktop.org/series/100251/ State : warning == Summary == $ dim checkpatch origin/drm-tip ff9fe74a5f35 treewide: Replace zero-length arrays with flexible-array members

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: fix unsigned integer to signed assignment

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: fix unsigned integer to signed assignment URL : https://patchwork.freedesktop.org/series/100250/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22298 Summary

Re: [Intel-gfx] [PATCH 4/4] drm/i915/reg: split out icl_dsi_regs.h

2022-02-16 Thread Matt Roper
On Wed, Feb 16, 2022 at 05:47:11PM +0200, Jani Nikula wrote: > The ICL DSI registers have fairly isolated usage. Split the register > macros to a separate file. > > Cc: Matt Roper > Signed-off-by: Jani Nikula Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/icl_dsi.c | 1

Re: [Intel-gfx] [PATCH 3/4] drm/i915/reg: split out vlv_dsi_regs.h and vlv_dsi_pll_regs.h

2022-02-16 Thread Matt Roper
On Wed, Feb 16, 2022 at 05:47:10PM +0200, Jani Nikula wrote: > The VLV (including CHV, BXT, and GLK) DSI registers have fairly isolated > usage. Split the register macros to separated files. > > Cc: Matt Roper > Signed-off-by: Jani Nikula Header split looks sane and all of the registers were

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: fix unsigned integer to signed assignment

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/gt: fix unsigned integer to signed assignment URL : https://patchwork.freedesktop.org/series/100250/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/tgl+: Implement new PLL programming step (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl+: Implement new PLL programming step (rev3) URL : https://patchwork.freedesktop.org/series/99867/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22296

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/4] drm/i915/dsi: disassociate VBT video transfer mode from register values

2022-02-16 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/dsi: disassociate VBT video transfer mode from register values URL : https://patchwork.freedesktop.org/series/100249/ State : failure == Summary == Applying: drm/i915/dsi: disassociate VBT video transfer mode from register

Re: [Intel-gfx] [PATCH 2/4] drm/i915/dsi: add separate init timer mask definition for ICL DSI

2022-02-16 Thread Matt Roper
On Wed, Feb 16, 2022 at 05:47:09PM +0200, Jani Nikula wrote: > Having a separate definition will be useful for splitting VLV and ICL > register files. > > Cc: Matt Roper > Signed-off-by: Jani Nikula Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- >

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dsi: disassociate VBT video transfer mode from register values

2022-02-16 Thread Matt Roper
On Wed, Feb 16, 2022 at 05:47:08PM +0200, Jani Nikula wrote: > The VBT DSI video transfer mode field values have been defined in terms > of the VLV MIPI_VIDEO_MODE_FORMAT register. The ICL DSI code maps that > to ICL DSI_TRANS_FUNC_CONF() register. The values are the same, though > the shift is

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display/tgl+: Implement new PLL programming step (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl+: Implement new PLL programming step (rev3) URL : https://patchwork.freedesktop.org/series/99867/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/tgl+: Implement new PLL programming step (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl+: Implement new PLL programming step (rev3) URL : https://patchwork.freedesktop.org/series/99867/ State : warning == Summary == $ dim checkpatch origin/drm-tip ab74bc303b59 drm/i915/display/tgl+: Implement new PLL programming step -:247:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: prefer forward declaration over includes (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/pxp: prefer forward declaration over includes (rev2) URL : https://patchwork.freedesktop.org/series/100117/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22295

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/lrc: move lrc_get_runtime() to intel_lrc.c (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/lrc: move lrc_get_runtime() to intel_lrc.c (rev2) URL : https://patchwork.freedesktop.org/series/100118/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22294

[Intel-gfx] [PATCH 10/13] drm_print: refine drm_debug_enabled for dyndbg+jump-label

2022-02-16 Thread Jim Cromie
In order to use dynamic-debug's jump-label optimization in drm-debug, its clarifying to refine drm_debug_enabled into 3 uses: 1. drm_debug_enabled - legacy, public 2. __drm_debug_enabled - optimized for dyndbg jump-label enablement. 3. _drm_debug_enabled - pr_debug instrumented, observable 1.

[Intel-gfx] [PATCH 11/13] drm_print: prefer bare printk KERN_DEBUG on generic fn

2022-02-16 Thread Jim Cromie
drm_print.c calls pr_debug() just once, from __drm_printfn_debug(), which is a generic/service fn. The callsite is compile-time enabled by DEBUG in both DYNAMIC_DEBUG=y/n builds. For dyndbg builds, reverting this callsite back to bare printk is correcting a few anti-features: 1- callsite is

[Intel-gfx] [PATCH 13/13] drm_print: use DEFINE_DYNAMIC_DEBUG_CLASSBITS for drm.debug

2022-02-16 Thread Jim Cromie
if CONFIG_DRM_USE_DYNAMIC_DEBUG=y, use new macro to create the sysfs bitmap to control drm.debug callsites. DEFINE_DYNAMIC_DEBUG_CLASSBITS( debug, __drm_debug, "p", "drm.debug - control summary", /* inline vector of _ddebug.class_id's to be controlled, max 14 vals */

[Intel-gfx] [PATCH 12/13] drm_print: add _ddebug desc to drm_*dbg prototypes

2022-02-16 Thread Jim Cromie
Add a struct _ddebug ptr to drm_dbg() and drm_dev_dbg() protos. And upgrade the current use of _dynamic_func_call_no_desc(); ie drop the '_no_desc', since the factory macro's callees (these 2 functions) are now expecting the arg. This lets those functions act more like pr_debug(). It also means

[Intel-gfx] [PATCH 06/13] dyndbg: abstract dyndbg_site_is_printing

2022-02-16 Thread Jim Cromie
Hide flags test in a macro. no functional changes. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 664bb83778d2..106065244f73 100644 ---

[Intel-gfx] [PATCH 08/13] drm_print: interpose drm_*dbg with forwarding macros

2022-02-16 Thread Jim Cromie
drm_dev_dbg() & drm_dbg() sit below the categorized layer of the DRM debug API, and implement most of it. These are good places to insert dynamic-debug jump-label mechanics, allowing DRM to avoid the runtime cost of drm_debug_enabled(). Set up for this by changing the func names by adding '__'

[Intel-gfx] [PATCH 09/13] drm_print: wrap drm_*_dbg in dyndbg jumplabel

2022-02-16 Thread Jim Cromie
For CONFIG_DRM_USE_DYNAMIC_DEBUG=y, wrap drm_dbg() & drm_dev_dbg() in one of dyndbg's Factory macros: _dynamic_func_call_no_desc(). This makes the (~4000) callsites controllable, typically by class: # 0 is DRM_UT_CORE #> echo module drm class 0 +p > /proc/dynamic_debug/control =N: keeps

[Intel-gfx] [PATCH 05/13] dyndbg: improve change-info to have old and new

2022-02-16 Thread Jim Cromie
move site.flag update after the v4pr_info("change") message, and improve the message to print both old and new flag values. Heres new form: dyndbg: changed net/ipv4/tcp.c:2424 [tcp]tcp_recvmsg_locked pT -> _ Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 11 ++- 1 file changed,

[Intel-gfx] [PATCH 07/13] drm_print: condense enum drm_debug_category

2022-02-16 Thread Jim Cromie
enum drm_debug_category has 10 "classes", explicitly initialized with 0x-bitmasks which could be simplified as BIT(X)s. But lets go further: use natural enumeration (int, starting at 0), and do the BIT(cat) in drm_debug_enabled(cat) at runtime. While this slightly pessimizes the bit-test, the

[Intel-gfx] [PATCH 02/13] dyndbg: add class_id field and query support

2022-02-16 Thread Jim Cromie
DRM defines/uses 10 enum drm_debug_category's to create exclusive classes of debug messages. To support this directly in dynamic-debug, add the following: - struct _ddebug.class_id:4 - 4 bits is enough - define _DPRINTK_SITE_UNCLASSED 15 - see below and the query support: - struct

[Intel-gfx] [PATCH 04/13] dyndbg: drop EXPORTed dynamic_debug_exec_queries

2022-02-16 Thread Jim Cromie
This exported fn is effectively obsoleted by Commit:HEAD~2, so remove it. The export was added here: commit a2d375eda771 ("dyndbg: refine export, rename to dynamic_debug_exec_queries()") commit 4c0d77828d4f ("dyndbg: export ddebug_exec_queries") Its intent was to allow drm.debug to use the

[Intel-gfx] [PATCH 03/13] dyndbg: add DEFINE_DYNAMIC_DEBUG_CLASSBITS macro and callbacks

2022-02-16 Thread Jim Cromie
DEFINE_DYNAMIC_DEBUG_CLASSBITS(fsname, var, bitmap_desc, classes..) allows users to create a drm.debug style (bitmap) sysfs interface, to control sets of pr_debug's according to their .class_id's This wraps existing "class" keyword and behavior: echo "module drm -p ; module drm class 0 +p ;

[Intel-gfx] [PATCH 01/13] dyndbg: fix static_branch manipulation

2022-02-16 Thread Jim Cromie
In https://lore.kernel.org/lkml/20211209150910.ga23...@axis.com/ Vincent's patch commented on, and worked around, a bug toggling static_branch's, when a 2nd PRINTK-ish flag was added. The bug results in a premature static_branch_disable when the 1st of 2 flags was disabled. The cited commit

[Intel-gfx] [PATCH 00/12] use dynamic-debug under drm.debug api

2022-02-16 Thread Jim Cromie
drm.debug api provides ~23 macros to issue 10 categories of debug messages, each enabled by a bit in /sys/module/drm/parameters/debug. drm_debug_enabled(category) tests these bits at runtime; while cheap individually, the costs accumulate. For CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this patchset

[Intel-gfx] ✓ Fi.CI.BAT: success for Add data flow metering support for HDMI2.1 (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: Add data flow metering support for HDMI2.1 (rev3) URL : https://patchwork.freedesktop.org/series/99668/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22293 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add data flow metering support for HDMI2.1 (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: Add data flow metering support for HDMI2.1 (rev3) URL : https://patchwork.freedesktop.org/series/99668/ State : warning == Summary == $ dim checkpatch origin/drm-tip a99528e005f6 drm/hdmi21: Define frl_dfm structure -:13: WARNING:FILE_PATH_CHANGES: added, moved or

[Intel-gfx] ✗ Fi.CI.IGT: failure for DGFX OpRegion (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: DGFX OpRegion (rev2) URL : https://patchwork.freedesktop.org/series/99738/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11236_full -> Patchwork_22283_full Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Move misplaced 'ctx' & 'gt' wa's to engine wa list

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Move misplaced 'ctx' & 'gt' wa's to engine wa list URL : https://patchwork.freedesktop.org/series/100212/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22291

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/guc/slpc: Use wrapper for reading RP_STATE_CAP

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Use wrapper for reading RP_STATE_CAP URL : https://patchwork.freedesktop.org/series/100217/ State : failure == Summary == Applying: drm/i915/guc/slpc: Use wrapper for reading RP_STATE_CAP Using index info to reconstruct a base tree... M

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev3) URL : https://patchwork.freedesktop.org/series/98801/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22288

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Splitting up platform-specific calls (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: Splitting up platform-specific calls (rev3) URL : https://patchwork.freedesktop.org/series/99126/ State : failure == Summary == Applying: i915/drm: Split out x86/arm64 for run_as_guest Using index info to reconstruct a base tree... M

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add DG2 PCI IDs

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Add DG2 PCI IDs URL : https://patchwork.freedesktop.org/series/100206/ State : failure == Summary == Applying: drm/i915: Add DG2 PCI IDs Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/i915_pci.c M

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/fbdev: add intel_fbdev_framebuffer() helper

2022-02-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/fbdev: add intel_fbdev_framebuffer() helper URL : https://patchwork.freedesktop.org/series/100170/ State : success == Summary == CI Bug Log - changes from CI_DRM_11236_full -> Patchwork_22282_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev3) URL : https://patchwork.freedesktop.org/series/98801/ State : warning == Summary == $ dim checkpatch origin/drm-tip eceba9ce6889 drm/i915/display/vrr: Reset VRR capable property on a long hpd

[Intel-gfx] ✓ Fi.CI.BAT: success for Bump DMC Version on ADL-P to v2.16 (rev3)

2022-02-16 Thread Patchwork
== Series Details == Series: Bump DMC Version on ADL-P to v2.16 (rev3) URL : https://patchwork.freedesktop.org/series/99938/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22287 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: #include drm_edid.h for drm_edid_block_valid()

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/gvt: #include drm_edid.h for drm_edid_block_valid() URL : https://patchwork.freedesktop.org/series/100169/ State : success == Summary == CI Bug Log - changes from CI_DRM_11236_full -> Patchwork_22281_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move bigjoiner refactoring

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915: Move bigjoiner refactoring URL : https://patchwork.freedesktop.org/series/100195/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22286 Summary --- **FAILURE**

[Intel-gfx] [PATCH v2 3/3] drm/i915: Polish ilk+ wm register bits

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä Use REG_GENMASK() & co. for ilk+ watermark registers. v2: Stick to the current bitmask sizes (Jani) Fix "watermarm" typo (Jani) Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_display_debugfs.c | 2 +-

[Intel-gfx] [PATCH v2 2/3] drm/i915: Clean up SSKPD/MLTR defines

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä Give names to the SSKPD/MLTR fields, and use the REG_GENMASK* and REG_FIELD_GET*. Also drop the bogus non-mirrored SSKP register define. v2: Rebase due to intel_mchbar_regs.h Leave gen6_check_mch_setup() in place for the moment Reviewed-by: Jani Nikula Signed-off-by:

[Intel-gfx] [PATCH v2 1/3] drm/i915: Introduce intel_crtc_planes_update_arm()

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä No reason the high level intel_update_crtc() needs to know that there is something magical about the commit order of planes between different platforms. So let's hide that detail even better. In order to keep to somewhat consistent naming between things we shall call this

[Intel-gfx] [PATCH v2 0/3] drm/i915: Plane/wm cleanups

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä Leftovers from the earlier series. Addressed Jani's review comments to some degree and dealt with intel_mchbar_regs.h appearing in the tree. Ville Syrjälä (3): drm/i915: Introduce intel_crtc_planes_update_arm() drm/i915: Clean up SSKPD/MLTR defines drm/i915: Polish

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v1,1/1] drm/i915/selftests: Replace too verbose for-loop with simpler while

2022-02-16 Thread Patchwork
== Series Details == Series: series starting with [v1,1/1] drm/i915/selftests: Replace too verbose for-loop with simpler while URL : https://patchwork.freedesktop.org/series/100189/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22285

[Intel-gfx] [PATCH] drm/i915: Kill the fake lmem support

2022-02-16 Thread Lucas De Marchi
This was useful for early development of lmem, but it's not used anymore, so remove it. Cc: Chris Wilson Cc: Matthew Auld Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/Kconfig.unstable | 8 -- drivers/gpu/drm/i915/gt/intel_gt.c | 2 -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix build issue when using clang (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915: fix build issue when using clang (rev2) URL : https://patchwork.freedesktop.org/series/100114/ State : success == Summary == CI Bug Log - changes from CI_DRM_11238 -> Patchwork_22284 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: fix build issue when using clang (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915: fix build issue when using clang (rev2) URL : https://patchwork.freedesktop.org/series/100114/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix build issue when using clang (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915: fix build issue when using clang (rev2) URL : https://patchwork.freedesktop.org/series/100114/ State : warning == Summary == $ dim checkpatch origin/drm-tip 69063f68d63d drm/i915: fix build issue when using clang -:10: WARNING:COMMIT_LOG_LONG_LINE:

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Use bigjoiner_pipes more

2022-02-16 Thread Navare, Manasi
On Tue, Feb 15, 2022 at 08:32:07PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the hardcoded 2 pipe assumptions when we're massaging > pipe_mode and the pipe_src rect to be suitable for bigjoiner. > Instead we can just count the number of pipes in the bitmask. > >

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Eliminate bigjoiner boolean

2022-02-16 Thread Navare, Manasi
On Tue, Feb 15, 2022 at 08:32:06PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Since we now have the bigjoiner_pipes bitmask the boolean > is redundant. Get rid of it. > > Also, populating bigjoiner_pipes already during > encoder->compute_config() allows us to use it much earlier >

Re: [Intel-gfx] [PATCH topic/for-CI] drm/i915: Add DG2 PCI IDs

2022-02-16 Thread Matt Roper
Applied to the topic/core-for-CI branch so that CI testing can get started on DG2 soon. Thanks for the review. Matt On Wed, Feb 16, 2022 at 04:13:14PM +, Yokoyama, Caz wrote: > Reviewed-by: Caz Yokoyama > -caz > > On Tue, 2022-02-15 at 13:45 -0800, Matt Roper wrote: > > DG2 hardware will

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915: Define MCH registers relative to MCHBAR_MIRROR_BASE

2022-02-16 Thread Matt Roper
On Wed, Feb 16, 2022 at 11:22:45AM +, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/2] drm/i915: Define MCH registers relative > to MCHBAR_MIRROR_BASE > URL : https://patchwork.freedesktop.org/series/100153/ > State : failure > > == Summary == > > CI Bug

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Print PHY name properly on calibration error

2022-02-16 Thread Dhanavanthri, Swathi
Reviewed-by: Swathi Dhanavanthri -Original Message- From: Intel-gfx On Behalf Of Matt Roper Sent: Tuesday, February 15, 2022 8:36 AM To: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH] drm/i915/dg2: Print PHY name properly on calibration error We need to use phy_name()

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for More GT register cleanup

2022-02-16 Thread Matt Roper
On Wed, Feb 09, 2022 at 07:07:41AM +, Patchwork wrote: > == Series Details == > > Series: More GT register cleanup > URL : https://patchwork.freedesktop.org/series/99872/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11205_full -> Patchwork_22217_full >

[Intel-gfx] [PATCH v8 4/5] mei: gsc: add runtime pm handlers

2022-02-16 Thread Alexander Usyskin
From: Tomas Winkler Implement runtime handlers for mei-gsc, to track idle state of the device properly. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- V4: drop debug prints V5: Rebase V6: Rebase V7: add Greg KH Reviewed-by V8: Rebase ---

[Intel-gfx] [PATCH v8 5/5] mei: gsc: retrieve the firmware version

2022-02-16 Thread Alexander Usyskin
Add a hook to retrieve the firmware version of the GSC devices to bus-fixup. GSC has a different MKHI clients GUIDs but the same message structure to retrieve the firmware version as MEI so mei_fwver() can be reused. CC: Ashutosh Dixit Signed-off-by: Alexander Usyskin Signed-off-by: Tomas

[Intel-gfx] [PATCH v8 3/5] mei: gsc: setup char driver alive in spite of firmware handshake failure

2022-02-16 Thread Alexander Usyskin
Setup char device in spite of firmware handshake failure. In order to provide host access to the firmware status registers and other information required for the manufacturing process. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V5: Rebase V6: Rebase V7: add Greg KH

[Intel-gfx] [PATCH v8 2/5] mei: add support for graphics system controller (gsc) devices

2022-02-16 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, based on CSE, it provides a chassis controller for graphics discrete cards, as well as it supports media protection on selected devices. mei_gsc binds to a auxiliary devices exposed by Intel discrete driver i915. Signed-off-by: Alexander

[Intel-gfx] [PATCH v8 1/5] drm/i915/gsc: add gsc as a mei auxiliary device

2022-02-16 Thread Alexander Usyskin
From: Tomas Winkler GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. Both interfaces are on the BAR0 at offsets 0x00258000 and 0x00259000. GSC is a GT Engine (class 4: instance 6). HECI1

[Intel-gfx] [PATCH v8 0/5] Add driver for GSC controller

2022-02-16 Thread Alexander Usyskin
GSC is a graphics system controller, it provides a chassis controller for graphics discrete cards. There are two MEI interfaces in GSC: HECI1 and HECI2. This series includes instantiation of the auxiliary devices for HECI2 and mei-gsc auxiliary device driver that binds to the auxiliary device.

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Fix MSO vs. bigjoiner timings confusion

2022-02-16 Thread Navare, Manasi
On Tue, Feb 15, 2022 at 08:32:04PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > When calculating pipe_mode and when doing readout we need > to order our steps correctly. > > 1. We start with adjusted_mode crtc timings being populated >with the transcoder timings (either via readout

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Extract intel_crtc_compute_pipe_src()

2022-02-16 Thread Ville Syrjälä
On Wed, Feb 16, 2022 at 11:35:39AM -0800, Navare, Manasi wrote: > On Tue, Feb 15, 2022 at 08:32:02PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > intel_crtc_compute_config() doesn't really tell a unified story. > > Let's chunk it up into pieces. We'll start with > >

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Extract intel_crtc_compute_pipe_mode()

2022-02-16 Thread Navare, Manasi
On Tue, Feb 15, 2022 at 08:32:03PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Pull intel_crtc_compute_pipe_mode() out from > intel_crtc_compute_config(). Since it's semi related > we'll suck in the max dotclock/double wide checks in > as well. > > And we'll pimp the debugs while at

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Extract intel_crtc_compute_pipe_src()

2022-02-16 Thread Navare, Manasi
On Tue, Feb 15, 2022 at 08:32:02PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > intel_crtc_compute_config() doesn't really tell a unified story. > Let's chunk it up into pieces. We'll start with > intel_crtc_compute_pipe_src(). > > Signed-off-by: Ville Syrjälä Reviewed-by: Manasi

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Extract intel_bigjoiner_adjust_timings()

2022-02-16 Thread Navare, Manasi
On Tue, Feb 15, 2022 at 08:32:01PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Deduplicate the code to convert the full timings to > per-pipe timings for bigjoiner usage. > > Signed-off-by: Ville Syrjälä Makes sense to have a helper to do this: Reviewed-by: Manasi Navare Manasi

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Rename variables in intel_crtc_compute_config()

2022-02-16 Thread Navare, Manasi
On Tue, Feb 15, 2022 at 08:31:59PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Do the s/dev_priv/i915/ and s/pipe_config/crtc_state/ renames > to intel_crtc_compute_config(). I want to start splitting this > up a bit and doing the renames now avoids spreading these old > nameing

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Fix cursor coordinates on bigjoiner slave

2022-02-16 Thread Navare, Manasi
On Wed, Feb 16, 2022 at 10:39:56AM +0200, Ville Syrjälä wrote: > On Tue, Feb 15, 2022 at 07:25:36PM -0800, Navare, Manasi wrote: > > On Tue, Feb 15, 2022 at 08:31:57PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Adjust the cursor dst coordinates appripriately when it's on >

[Intel-gfx] ✓ Fi.CI.BAT: success for DGFX OpRegion (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: DGFX OpRegion (rev2) URL : https://patchwork.freedesktop.org/series/99738/ State : success == Summary == CI Bug Log - changes from CI_DRM_11236 -> Patchwork_22283 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH][next] treewide: Replace zero-length arrays with flexible-array members

2022-02-16 Thread Rafael J. Wysocki
On Tue, Feb 15, 2022 at 8:24 PM Gustavo A. R. Silva wrote: > > On Tue, Feb 15, 2022 at 09:19:29PM +0200, Leon Romanovsky wrote: > > On Tue, Feb 15, 2022 at 01:21:10PM -0600, Gustavo A. R. Silva wrote: > > > On Tue, Feb 15, 2022 at 10:17:40AM -0800, Kees Cook wrote: > > > > On Tue, Feb 15, 2022 at

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for DGFX OpRegion (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: DGFX OpRegion (rev2) URL : https://patchwork.freedesktop.org/series/99738/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DGFX OpRegion (rev2)

2022-02-16 Thread Patchwork
== Series Details == Series: DGFX OpRegion (rev2) URL : https://patchwork.freedesktop.org/series/99738/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6d79d75ff620 drm/i915/opregion: Add intel_opregion_init() wrapper 768f0a166cf5 drm/i915/opregion: Abstract opregion function

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/fbdev: add intel_fbdev_framebuffer() helper

2022-02-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/fbdev: add intel_fbdev_framebuffer() helper URL : https://patchwork.freedesktop.org/series/100170/ State : success == Summary == CI Bug Log - changes from CI_DRM_11236 -> Patchwork_22282

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param

2022-02-16 Thread Vinay Belgaumkar
SLPC unset param H2G only needs one parameter - the id of the param. Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits") Suggested-by: Umesh Nerlige Ramappa Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +- 1 file changed, 1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/fbdev: add intel_fbdev_framebuffer() helper

2022-02-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/fbdev: add intel_fbdev_framebuffer() helper URL : https://patchwork.freedesktop.org/series/100170/ State : warning == Summary == $ dim checkpatch origin/drm-tip b96b00c05a02 drm/i915/fbdev: add intel_fbdev_framebuffer()

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: #include drm_edid.h for drm_edid_block_valid()

2022-02-16 Thread Patchwork
== Series Details == Series: drm/i915/gvt: #include drm_edid.h for drm_edid_block_valid() URL : https://patchwork.freedesktop.org/series/100169/ State : success == Summary == CI Bug Log - changes from CI_DRM_11236 -> Patchwork_22281

[Intel-gfx] [PATCH v2 6/6] drm/i915: Extract intel_bw_check_data_rate()

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä Extract the data rate calculation loop out from intel_bw_atomic_check() to make it a bit less confusing. Cc: Stanislav Lisovskiy Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 63 +++-- 1 file changed, 37 insertions(+), 26

[Intel-gfx] [PATCH v2 5/6] drm/i915: Extract icl_qgv_points_mask()

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä Declutter intel_bw_atomic_check() a bit by pulling the max QGV mask calculation out. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bw.c | 35 - 1 file changed, 22 insertions(+), 13 deletions(-) diff --git

[Intel-gfx] [PATCH v2 4/6] drm/i915: Pimp icl+ sagv pre/post update

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä Add some debugs on what exactly we're doing to the QGV point mask in the icl+ sagv pre/post plane update hooks. Currently we're just guessing. v2: s/u32/u16/ for consistency with the mask sizes (Stan) Reviewed-by: Stanislav Lisovskiy Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 3/6] drm/i915: Split pre-icl vs. icl+ SAGV hooks apart

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä To further reduce the confusion between the pre-icl vs. icl+ SAGV codepaths let's do a full split. Cc: Stanislav Lisovskiy Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_pm.c | 120 1 file changed, 77 insertions(+), 43

[Intel-gfx] [PATCH v2 2/6] drm/i915: Fix bw atomic check when switching between SAGV vs. no SAGV

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä If the only thing that is changing is SAGV vs. no SAGV but the number of active planes and the total data rates end up unchanged we currently bail out of intel_bw_atomic_check() early and forget to actually compute the new WGV point mask and thus won't actually enable/disable

[Intel-gfx] [PATCH v2 1/6] drm/i915: Correctly populate use_sagv_wm for all pipes

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä When changing between SAGV vs. no SAGV on tgl+ we have to update the use_sagv_wm flag for all the crtcs or else an active pipe not already in the state will end up using the wrong watermarks. That is especially bad when we end up with the tighter non-SAGV watermarks with SAGV

[Intel-gfx] [PATCH v2 0/6] drm/i915: SAGV fixes

2022-02-16 Thread Ville Syrjala
From: Ville Syrjälä While pokingaround the watermarks/etc. I noticed our SAGV code has a bunch of bugs. Let's try to fix it. Pushed a few patches from v1 already. And based on the discussion with Stan I added a few extra refactoring patches to the end in the hopes of making the logic less

[Intel-gfx] [PATCH v3 12/16] drm/i915/guc: Convert mapping table to iosys_map

2022-02-16 Thread Lucas De Marchi
Use iosys_map to write the fields system_info.mapping_table[][]. Since we already have the info_map around where needed, just use it instead of going through guc->ads_map. Cc: Matt Roper Cc: Thomas Hellström Cc: Daniel Vetter Cc: John Harrison Cc: Matthew Brost Cc: Daniele Ceraolo Spurio

  1   2   >