Hi Dmitry,
On Tue, Feb 22, 2022 at 06:32:50AM +0300, Dmitry Baryshkov wrote:
> On Thu, 10 Feb 2022 at 07:59, Laurent Pinchart wrote:
> > On Wed, Feb 09, 2022 at 05:40:29PM -0800, Abhinav Kumar wrote:
> > > Hi Laurent
> > >
> > > Gentle reminder on this.
> >
> > I won't have time before next week
On Tue, Feb 22, 2022 at 12:25:39AM +0100, Andrzej Hajda wrote:
> -static noinline depot_stack_handle_t
> +static intel_wakeref_t
> track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
> {
> - depot_stack_handle_t stack, *stacks;
> - unsigned long flags;
> -
> - if
== Series Details ==
Series: drm/i915: fix one mem leak in mmap_offset_attach()
URL : https://patchwork.freedesktop.org/series/100532/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11264_full -> Patchwork_22347_full
== Series Details ==
Series: drm/i915/tgl: Simply subplatform detection
URL : https://patchwork.freedesktop.org/series/100517/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11264_full -> Patchwork_22345_full
Summary
== Series Details ==
Series: drm/i915: fix one mem leak in mmap_offset_attach()
URL : https://patchwork.freedesktop.org/series/100532/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11264 -> Patchwork_22347
Summary
---
== Series Details ==
Series: series starting with [v13,1/5] drm: improve drm_buddy_alloc function
URL : https://patchwork.freedesktop.org/series/100509/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11264_full -> Patchwork_22344_full
== Series Details ==
Series: drm/i915: fix one mem leak in mmap_offset_attach()
URL : https://patchwork.freedesktop.org/series/100532/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7dffc282c26b drm/i915: fix one mem leak in mmap_offset_attach()
-:9: WARNING:COMMIT_MESSAGE:
We are seeking nominations for candidates for election to the X.Org Foundation
Board of Directors. All X.Org Foundation members are eligible for election to
the board.
Nominations for the 2022 election are now open and will remain open until
23:59 UTC on 06 March 2022.
The Board consists of
The below memory leak information is caught:
---
unreferenced object 0x997dd4e3b240 (size 64):
comm "gem_tiled_fence", pid 10332, jiffies 4294959326 (age
220778.420s)
hex dump (first 32 bytes):
01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00
' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Yongzhi-Liu/drm-i915-Check-input-parameter-for-NULL/20220221-225508
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a004-20220221
(https://download.01
== Series Details ==
Series: drm/i915/ttm: fixup the mock_bo (rev3)
URL : https://patchwork.freedesktop.org/series/100255/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11264_full -> Patchwork_22342_full
Summary
---
'--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Yongzhi-Liu/drm-i915-Check-input-parameter-for-NULL/20220221-225508
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a001-20220221
(https
== Series Details ==
Series: drm/i915: use ref_tracker library for tracking wakerefs (rev3)
URL : https://patchwork.freedesktop.org/series/100327/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11264 -> Patchwork_22346
== Series Details ==
Series: drm/i915: use ref_tracker library for tracking wakerefs (rev3)
URL : https://patchwork.freedesktop.org/series/100327/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: use ref_tracker library for tracking wakerefs (rev3)
URL : https://patchwork.freedesktop.org/series/100327/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
eec39ef01f2c ref_tracker: implement use-after-free detection
e7636c41be32
'--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Yongzhi-Liu/drm-i915-Check-input-parameter-for-NULL/20220221-225508
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a014-20220221
(https
From: Chris Wilson
Track every intel_gt_pm_get() until its corresponding release in
intel_gt_pm_put() by returning a cookie to the caller for acquire that
must be passed by on rleased. When there is an imbalance, we can see who
either tried to free a stale wakeref, or who forgot to free theirs.
Beside reusing existing code, the main advantage of ref_tracker is
tracking per instance of wakeref. It allows also to catch double
put.
On the other side we lose information about the first acquire and
the last release, but the advantages outweigh it.
Signed-off-by: Andrzej Hajda
Reviewed-by:
In case one wants to show stats via debugfs.
Signed-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 ++
lib/ref_tracker.c | 56 +++--
2 files changed, 56 insertions(+), 8 deletions(-)
diff --git
Wakeref has dedicated type. Assumption it will be int
compatible forever is incorrect.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
From: Chris Wilson
Extract the callstack tracking of intel_runtime_pm.c into its own
utility so that that we can reuse it for other online debugging of
scoped wakerefs.
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug
Library can handle allocation failures. To avoid allocation warnings
__GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
replaced with GFP_NOWAIT in case of stack allocation on tracker free
call.
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 5 +++--
1 file changed, 3
To improve readibility of ref_tracker printing following changes
have been performed:
- reports are printed per stack_handle - log is more compact,
- added display name for ref_tracker_dir,
- stack trace is printed indented, in the same printk call,
- total number of references is printed every
To have reliable detection of leaks, caller must be able to check under the same
lock both: tracked counter and the leaks. dir.lock is natural candidate for such
lock and unlocked print helper can be called with this lock taken.
As a bonus we can reuse this helper in ref_tracker_dir_exit.
From: Eric Dumazet
After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
in stack_depot_save()") it became unnecessary to filter the stack
before calling stack_depot_save().
Signed-off-by: Eric Dumazet
Cc: Marco Elver
Cc: Alexander Potapenko
Cc: Dmitry Vyukov
From: Eric Dumazet
We are still chasing a netdev refcount imbalance, and we suspect
we have one rogue dev_put() that is consuming a reference taken
from a dev_hold_track()
To detect this case, allow ref_tracker_alloc() and ref_tracker_free()
to be called with a NULL @trackerp parameter, and use
From: Eric Dumazet
Whenever ref_tracker_dir_init() is called, mark the struct ref_tracker_dir
as dead.
Test the dead status from ref_tracker_alloc() and ref_tracker_free()
This should detect buggy dev_put()/dev_hold() happening too late
in netdevice dismantle process.
Signed-off-by: Eric
Hi,
Appearance of ref_tracker library allows to drop custom solution for wakeref
tracking used in i915 and reuse the library.
For this few adjustements has been made to ref_tracker, details in patches.
I hope changes are OK for original author.
The patchset has been rebased on top of drm-tip to
On 22.02.2022 00:16, Andrzej Hajda wrote:
Hi,
Appearance of ref_tracker library allows to drop custom solution for wakeref
tracking used in i915 and reuse the library.
For this few adjustements has been made to ref_tracker, details in patches.
I hope changes are OK for original author.
The
Beside reusing existing code, the main advantage of ref_tracker is
tracking per instance of wakeref. It allows also to catch double
put.
On the other side we lose information about the first acquire and
the last release, but the advantages outweigh it.
Signed-off-by: Andrzej Hajda
Reviewed-by:
Wakeref has dedicated type. Assumption it will be int
compatible forever is incorrect.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
From: Chris Wilson
Track every intel_gt_pm_get() until its corresponding release in
intel_gt_pm_put() by returning a cookie to the caller for acquire that
must be passed by on rleased. When there is an imbalance, we can see who
either tried to free a stale wakeref, or who forgot to free theirs.
Beside reusing existing code, the main advantage of ref_tracker is
tracking per instance of wakeref. It allows also to catch double
put.
On the other side we lose information about the first acquire and
the last release, but the advantages outweigh it.
Signed-off-by: Andrzej Hajda
Reviewed-by:
From: Chris Wilson
Extract the callstack tracking of intel_runtime_pm.c into its own
utility so that that we can reuse it for other online debugging of
scoped wakerefs.
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug
Wakeref has dedicated type. Assumption it will be int
compatible forever is incorrect.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
Library can handle allocation failures. To avoid allocation warnings
__GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been
replaced with GFP_NOWAIT in case of stack allocation on tracker free
call.
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 5 +++--
1 file changed, 3
From: Chris Wilson
Track every intel_gt_pm_get() until its corresponding release in
intel_gt_pm_put() by returning a cookie to the caller for acquire that
must be passed by on rleased. When there is an imbalance, we can see who
either tried to free a stale wakeref, or who forgot to free theirs.
In case one wants to show stats via debugfs.
Signed-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 ++
lib/ref_tracker.c | 56 +++--
2 files changed, 56 insertions(+), 8 deletions(-)
diff --git
From: Chris Wilson
Extract the callstack tracking of intel_runtime_pm.c into its own
utility so that that we can reuse it for other online debugging of
scoped wakerefs.
Signed-off-by: Chris Wilson
Reviewed-by: Andrzej Hajda
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/Kconfig.debug
To improve readibility of ref_tracker printing following changes
have been performed:
- reports are printed per stack_handle - log is more compact,
- added display name for ref_tracker_dir,
- stack trace is printed indented, in the same printk call,
- total number of references is printed every
Library can be called in non-sleeping context, so it should not use
__GFP_NOFAIL. Instead it should calmly handle allocation fails, for
this __GFP_NOWARN has been added as well.
Signed-off-by: Andrzej Hajda
---
lib/ref_tracker.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
In case one wants to show stats via debugfs.
Signed-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
include/linux/ref_tracker.h | 8 ++
lib/ref_tracker.c | 52 -
2 files changed, 54 insertions(+), 6 deletions(-)
diff --git
To have reliable detection of leaks, caller must be able to check under the same
lock both: tracked counter and the leaks. dir.lock is natural candidate for such
lock and unlocked print helper can be called with this lock taken.
As a bonus we can reuse this helper in ref_tracker_dir_exit.
From: Eric Dumazet
After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
in stack_depot_save()") it became unnecessary to filter the stack
before calling stack_depot_save().
Signed-off-by: Eric Dumazet
Cc: Marco Elver
Cc: Alexander Potapenko
Cc: Dmitry Vyukov
To improve readibility of ref_tracker printing following changes
have been performed:
- added display name for ref_tracker_dir,
- stack trace is printed indented, in the same printk call,
- total number of references is printed every time,
- print info about dropped references.
Signed-off-by:
From: Eric Dumazet
We are still chasing a netdev refcount imbalance, and we suspect
we have one rogue dev_put() that is consuming a reference taken
from a dev_hold_track()
To detect this case, allow ref_tracker_alloc() and ref_tracker_free()
to be called with a NULL @trackerp parameter, and use
From: Eric Dumazet
After commit e94006608949 ("lib/stackdepot: always do filter_irq_stacks()
in stack_depot_save()") it became unnecessary to filter the stack
before calling stack_depot_save().
Signed-off-by: Eric Dumazet
Cc: Marco Elver
Cc: Alexander Potapenko
Cc: Dmitry Vyukov
In cases references are taken alternately on multiple exec paths leak
report can grow substantially, sorting and grouping leaks by stack_handle
allows to compact it.
Signed-off-by: Andrzej Hajda
Reviewed-by: Chris Wilson
---
lib/ref_tracker.c | 35 +++
1 file
From: Eric Dumazet
We are still chasing a netdev refcount imbalance, and we suspect
we have one rogue dev_put() that is consuming a reference taken
from a dev_hold_track()
To detect this case, allow ref_tracker_alloc() and ref_tracker_free()
to be called with a NULL @trackerp parameter, and use
From: Eric Dumazet
Whenever ref_tracker_dir_init() is called, mark the struct ref_tracker_dir
as dead.
Test the dead status from ref_tracker_alloc() and ref_tracker_free()
This should detect buggy dev_put()/dev_hold() happening too late
in netdevice dismantle process.
Signed-off-by: Eric
To have reliable detection of leaks, caller must be able to check under the same
lock both: tracked counter and the leaks. dir.lock is natural candidate for such
lock and unlocked print helper can be called with this lock taken.
As a bonus we can reuse this helper in ref_tracker_dir_exit.
From: Eric Dumazet
Whenever ref_tracker_dir_init() is called, mark the struct ref_tracker_dir
as dead.
Test the dead status from ref_tracker_alloc() and ref_tracker_free()
This should detect buggy dev_put()/dev_hold() happening too late
in netdevice dismantle process.
Signed-off-by: Eric
Hi,
Appearance of ref_tracker library allows to drop custom solution for wakeref
tracking used in i915 and reuse the library.
For this few adjustements has been made to ref_tracker, details in patches.
I hope changes are OK for original author.
The patchset has been rebased on top of drm-tip to
== Series Details ==
Series: series starting with [1/4] drm/i915: Move framestart_delay to crtc_state
URL : https://patchwork.freedesktop.org/series/100484/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11263_full -> Patchwork_22341_full
== Series Details ==
Series: drm/i915/tgl: Simply subplatform detection
URL : https://patchwork.freedesktop.org/series/100517/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11264 -> Patchwork_22345
Summary
---
== Series Details ==
Series: drm/i915/tgl: Simply subplatform detection
URL : https://patchwork.freedesktop.org/series/100517/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: series starting with [v13,1/5] drm: improve drm_buddy_alloc function
URL : https://patchwork.freedesktop.org/series/100509/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11264 -> Patchwork_22344
== Series Details ==
Series: series starting with [v13,1/5] drm: improve drm_buddy_alloc function
URL : https://patchwork.freedesktop.org/series/100509/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1ae185a2649e drm: improve drm_buddy_alloc function
-:372: WARNING:AVOID_BUG:
== Series Details ==
Series: linux-next: manual merge of the drm-intel-gt tree with the drm-intel
tree (rev3)
URL : https://patchwork.freedesktop.org/series/99294/
State : failure
== Summary ==
Applying: linux-next: manual merge of the drm-intel-gt tree with the drm-intel
tree
Using index
In the past we had a need to differentiate TGL U and TGL Y, there
was a different voltage swing table for each subplatform and some PCI
ids of this subplatforms are shared but it turned out that it was a
specification mistake and the voltage swing table was indeed the same
but we went ahead with
== Series Details ==
Series: drm/i915/ttm: fixup the mock_bo (rev3)
URL : https://patchwork.freedesktop.org/series/100255/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11264 -> Patchwork_22342
Summary
---
== Series Details ==
Series: drm/i915/ttm: fixup the mock_bo (rev3)
URL : https://patchwork.freedesktop.org/series/100255/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a5ab96652684 drm/i915/ttm: fixup the mock_bo
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit
== Series Details ==
Series: series starting with [1/4] drm/i915: Move framestart_delay to crtc_state
URL : https://patchwork.freedesktop.org/series/100484/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11263 -> Patchwork_22341
On 18/02/2022 10:46, Joonas Lahtinen wrote:
Quoting Andi Shyti (2022-02-17 17:53:58)
Hi Tvrtko,
Now tiles have their own sysfs interfaces under the gt/
directory. Because RC6 is a property that can be configured on a
tile basis, then each tile should have its own interface
The new sysfs
== Series Details ==
Series: series starting with [1/4] drm/i915: Move framestart_delay to crtc_state
URL : https://patchwork.freedesktop.org/series/100484/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
Hi all,
Today's linux-next merge of the drm-intel-gt tree got conflicts in:
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
between commits:
b508d01fa577e ("drm/i915: split out
Sanity check that the kernel does indeed reject LMEM buffers marked with
EXEC_OBJECT_CAPTURE, that are not also marked with NEEDS_CPU_ACCESS.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
tests/i915/gem_exec_capture.c | 69 +++
1 file changed, 69
Add some basic tests for this new flag.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
tests/i915/gem_create.c | 334
1 file changed, 334 insertions(+)
diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
index a6c3c9d9..318e6491 100644
Most users shouldn't care about such an interface, but where required,
this should be useful to aid in setting NEEDS_CPU_ACCESS for a given BO.
Underneath we try to smooth over needing to provide an explicit SMEM
region, or if this is SMEM-only, we don't want the kernel to throw an
error.
Put it
kms_frontbuffer_tracking@basic falls over if the fb needs to be migrated
from non-mappable device memory, to the mappable part, due to being
temporarily pinned for scanout, when hitting the CPU fault handler,
which just gives us SIGBUS. If the device has a small BAR let's attempt
to use the
For now limit to direct callers.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
lib/i915/gem_create.c | 9 ++---
lib/i915/gem_create.h | 5 +++--
lib/i915/intel_memory_region.c | 2 +-
tests/i915/gem_create.c| 24
For now dump into i915_drm_local.h. Once the uapi on the kernel side is
merged, and is part of drm-next, we can sync the kernel headers and
remove this.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
lib/i915/i915_drm_local.h | 27 +++
1 file changed, 27
Add some initial tests for the new I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS
flag.
v2: Add missing cover letter. Likely also needed when using 'Test-with:'
--
2.34.1
kms_frontbuffer_tracking@basic falls over if the fb needs to be migrated
from non-mappable device memory, to the mappable part, due to being
temporarily pinned for scanout, when hitting the CPU fault handler,
which just gives us SIGBUS. If the device has a small BAR let's attempt
to use the
Sanity check that the kernel does indeed reject LMEM buffers marked with
EXEC_OBJECT_CAPTURE, that are not also marked with NEEDS_CPU_ACCESS.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
tests/i915/gem_exec_capture.c | 69 +++
1 file changed, 69
Most users shouldn't care about such an interface, but where required,
this should be useful to aid in setting NEEDS_CPU_ACCESS for a given BO.
Underneath we try to smooth over needing to provide an explicit SMEM
region, or if this is SMEM-only, we don't want the kernel to throw an
error.
Put it
Add some basic tests for this new flag.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
tests/i915/gem_create.c | 334
1 file changed, 334 insertions(+)
diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
index a6c3c9d9..318e6491 100644
For now dump into i915_drm_local.h. Once the uapi on the kernel side is
merged, and is part of drm-next, we can sync the kernel headers and
remove this.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
lib/i915/i915_drm_local.h | 27 +++
1 file changed, 27
For now limit to direct callers.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
lib/i915/gem_create.c | 9 ++---
lib/i915/gem_create.h | 5 +++--
lib/i915/intel_memory_region.c | 2 +-
tests/i915/gem_create.c| 24
Make it play nice on at least DG1.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
tests/i915/gem_exec_await.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_exec_await.c b/tests/i915/gem_exec_await.c
index bf8eb682..fe176595 100644
---
Make it play nice on at least DG1.
Signed-off-by: Matthew Auld
Cc: Thomas Hellström
---
tests/i915/gem_ctx_shared.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
index 37444185..b38b7f73 100644
---
On Fri, 2022-02-18 at 14:31 +0200, Imre Deak wrote:
> Add display workaround # 1309179469 , which fixes a PHY hang when
> switching from TBT mode to DP-alt/legacy mode. The workaround also
> requires an IFWI/PHY firmware change, before that this change has no
> effect (the DKL_PCS_DW5/SOFTRESET
On Mon, 2022-02-21 at 12:11 +, Matthew Auld wrote:
> When running the mock selftests we currently blow up with:
>
> <6> [299.836278] i915: Running
> i915_gem_huge_page_mock_selftests/igt_mock_memory_region_huge_pages
> <1> [299.836356] BUG: kernel NULL pointer dereference, address:
>
On 16/02/2022 10:36, Christian König wrote:
Am 15.02.22 um 23:23 schrieb Vivek Kasireddy:
This iterator relies on drm_mm_first_hole() and drm_mm_next_hole()
functions to identify suitable holes for an allocation of a given
size by efficiently traversing the rbtree associated with the given
On 18/02/2022 03:47, Kasireddy, Vivek wrote:
Hi Tvrtko,
On 17/02/2022 07:50, Vivek Kasireddy wrote:
While looking for next holes suitable for an allocation, although,
it is highly unlikely, make sure that the DECLARE_NEXT_HOLE_ADDR
macro is using a valid node before it extracts the rb_node
When running the mock selftests we currently blow up with:
<6> [299.836278] i915: Running
i915_gem_huge_page_mock_selftests/igt_mock_memory_region_huge_pages
<1> [299.836356] BUG: kernel NULL pointer dereference, address: 00c8
<1> [299.836361] #PF: supervisor read access in kernel
Hi Matthias,
could you open a ticket at gitlab, providing a dmesg as described at
https://gitlab.freedesktop.org/drm/intel/-/wikis/How-to-file-i915-bugs
Thanks,
Imre
On Sun, Feb 20, 2022 at 03:33:56PM +0100, Matthias Walther wrote:
> Hm, no ideas on this?
>
>
> Am 28.01.22 um 20:50 schrieb
On Thu, Feb 10, 2022 at 08:23:59AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> On icl+ all plane registers are armed by PLANE_SURF, so we can
> move almost everything over into the update_noarm() hook.
>
> The PLANE_CTL write has to stay in the icl_update_arm() hook though
> as it
On Thu, Feb 10, 2022 at 08:24:02AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Drop the locks around most primary plane register writes.
> The lock isn't needed since each plane's register are neatly
> contained on their own cachelines.
>
> The one exception we have to make is
On Thu, Feb 10, 2022 at 08:24:03AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Drop the locks around sprite plane register writes. The
> lock isn't needed since each plane's register are neatly
> contained on their own cachelines.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by:
Hi Rob,
On 25/01/2022 10:24, Tvrtko Ursulin wrote:
On 21/01/2022 11:50, Tvrtko Ursulin wrote:
On 20/01/2022 16:44, Rob Clark wrote:
[snip]
If there is a tool somewhere that displays this info, that would be
useful for testing my implementation.
I have a patch to Intel specific
On Fri, Feb 18, 2022 at 08:40:38AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Declutter intel_bw_atomic_check() a bit by pulling
> the max QGV mask calculation out.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Stanislav Lisovskiy
> ---
> drivers/gpu/drm/i915/display/intel_bw.c
On Fri, 18 Feb 2022, Jani Nikula wrote:
> The VBT DSI video transfer mode field values have been defined in terms
> of the VLV MIPI_VIDEO_MODE_FORMAT register. The ICL DSI code maps that
> to ICL DSI_TRANS_FUNC_CONF() register. The values are the same, though
> the shift is different.
>
> Make a
From: Ville Syrjälä
Move intel_crtc_pch_transcoder() and has_pch_trancoder() to a
more appropritate place (intel_pch_display.c).
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 19 +--
drivers/gpu/drm/i915/display/intel_display.h | 1 -
From: Ville Syrjälä
Move the ibx pch port sanitation code into intel_pch_display.c
where it now belongs.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_display.c | 63 +
.../gpu/drm/i915/display/intel_pch_display.c | 67 +++
From: Ville Syrjälä
Now that we track framestart_delay in the crtc state with readout
and state checker support we can remove the explicit framestart_delay
sanitation code.
Also I'm not convinced reprogramming this while the pipe is running
is even valid. CHICKEN_TRANS (hsw+) and TRANS_CHICKEN2
From: Ville Syrjälä
We need to make framestart_delay dynamic for DRRS on PCH
ports. To that end move it into the crtc state. As a bonus
we get state check+dump for it. Will also allow us to get
rid of the somewhat questionable framestart_delay sanitation
code.
Signed-off-by: Ville Syrjälä
---
On Fri, 18 Feb 2022 12:03:58 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> struct drm_display_mode embeds a list head, so overwriting
> the full struct with another one will corrupt the list
> (if the destination mode is on a list). Use drm_mode_copy()
> instead which explicitly
On 15/02/2022 16:35, Matt Roper wrote:
We need to use phy_name() to convert the PHY value into a human-readable
character in the error message.
Fixes: a6a128116e55 ("drm/i915/dg2: Wait for SNPS PHY calibration during display
init")
I picked this for drm-intel-fixes, and as it did not apply
On Mon, 21 Feb 2022, Dave Airlie wrote:
> On Thu, 17 Feb 2022 at 20:26, Joonas Lahtinen
> wrote:
>>
>> Hi Dave & Daniel,
>>
>> Here is the first drm-intel-gt-next feature PR towards v5.18.
>
> Am I missing some previous drm-intel pull?
>
>
100 matches
Mail list logo
