[Intel-gfx] [PULL] drm-intel-gt-next

Hi Dave & Daniel, Here is the last feature PR for v5.18. For new platforms we have got more DG2 enabling: small BAR foundations, 64K page support and accelerated migration. For XeHP SDV we've got flat CCS detection and compute command streamer being added. Disabling i915 build on PREEMPT_RT for

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/gt: Clear compress metadata for Xe_HP platforms

On Wed, 2022-03-02 at 03:23 +0530, Ramalingam C wrote: > From: Ayaz A Siddiqui > > Xe-HP and latest devices support Flat CCS which reserved a portion of > the device memory to store compression metadata, during the clearing > of > device memory buffer object we also need to clear the associated >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: missing boundary check in vm_access leads to OOB read/write (rev2)

== Series Details == Series: drm/i915/gem: missing boundary check in vm_access leads to OOB read/write (rev2) URL : https://patchwork.freedesktop.org/series/100932/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11316 -> Patchwork_22468

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Remove the vma refcount

On Wed, 2022-03-02 at 14:01 -0800, Niranjana Vishwanathapura wrote: > On Wed, Mar 02, 2022 at 11:21:59AM +0100, Thomas Hellström wrote: > > Now that i915_vma_parked() is taking the object lock on vma > > destruction, > > and the only user of the vma refcount, i915_gem_object_unbind() > > also takes

[Intel-gfx] [v2] drm/i915/gem: missing boundary check in vm_access leads to OOB read/write

Intel ID: PSIRT-PTK0002429 A missing bounds check in vm_access()can lead to an out-of-bounds read or write in the adjacent memory area.The len attribute is not validated before the memcpy at [1]or [2] occurs. [ 183.637831] BUG: unable to handle page fault for address: c9c86000 [ 183.63

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: avoid concurrent writes to aux_inv (rev3)

== Series Details == Series: drm/i915: avoid concurrent writes to aux_inv (rev3) URL : https://patchwork.freedesktop.org/series/100772/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11313_full -> Patchwork_22465_full Summar

Re: [Intel-gfx] [PATCH 15/15] drm/i915/gt: Clear compress metadata for Xe_HP platforms

On Sun, Feb 27, 2022 at 10:22:20PM +0530, Ramalingam C wrote: > Matt, > > Thanks for the review. > > On 2022-02-18 at 17:47:22 -0800, Matt Roper wrote: > > On Sat, Feb 19, 2022 at 12:17:52AM +0530, Ramalingam C wrote: > > > From: Ayaz A Siddiqui > > > > > > Xe-HP and latest devices support Flat

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

From: Xiaomeng Tong > Sent: 03 March 2022 02:27 > > On Wed, 2 Mar 2022 14:04:06 +, David Laight > wrote: > > I think that it would be better to make any alternate loop macro > > just set the variable to NULL on the loop exit. > > That is easier to code for and the compiler might be persuaded

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Handle errors for i915_gem_object_trylock

== Series Details == Series: drm/i915/gt: Handle errors for i915_gem_object_trylock URL : https://patchwork.freedesktop.org/series/100951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11313_full -> Patchwork_22464_full Sum

Re: [Intel-gfx] [intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv (rev3)

Hi Chris, for some reason I didn't receive the review email, so I copied your comments from patchwork and faked this email. >> static void execlists_dequeue(struct intel_engine_cs *engine) >> { >> struct intel_engine_execlists * const execlists = &engine->execlists; >> @@ -1538,6 +1566,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/cdclk: Add cdclk check to atomic check (rev2)

== Series Details == Series: drm/i915/cdclk: Add cdclk check to atomic check (rev2) URL : https://patchwork.freedesktop.org/series/100671/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11316 -> Patchwork_22467 Summary -

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/cdclk: Add cdclk check to atomic check (rev2)

== Series Details == Series: drm/i915/cdclk: Add cdclk check to atomic check (rev2) URL : https://patchwork.freedesktop.org/series/100671/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_cdclk.c:2034: warning: Function parameter

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/cdclk: Add cdclk check to atomic check (rev2)

== Series Details == Series: drm/i915/cdclk: Add cdclk check to atomic check (rev2) URL : https://patchwork.freedesktop.org/series/100671/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/adlp: Remove code related to underrun recovery

== Series Details == Series: drm/i915/display/adlp: Remove code related to underrun recovery URL : https://patchwork.freedesktop.org/series/100965/ State : success == Summary == CI Bug Log - changes from CI_DRM_11316 -> Patchwork_22466 Summ

[Intel-gfx] [PATCH] drm/i915/cdclk: Add cdclk check to atomic check

Checking cdclk conditions during atomic check and preparing for commit phase so we can have atomic commit as simple as possible. Add the specific steps to be taken during cdclk changes, prepare for squashing, crawling and modeset scenarios. Rename functions intel_cdclk_can_squash() and intel_cdclk

[Intel-gfx] [PATCH] drm/i915/display/adlp: Remove code related to underrun recovery

This is not supported for ADLP and is not needed. Signed-off-by: Swathi Dhanavanthri --- drivers/gpu/drm/i915/display/intel_display.c | 21 1 file changed, 21 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_displa

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for iommu/vt-d: Add RPLS to quirk list to skip TE disabling (rev3)

Thank you all. I had reviewed this patch already in the iommu list. Now pushed. Thanks, Rodrigo. On Thu, 2022-03-03 at 00:38 +0800, Vudum, Lakshminarayana wrote: > Filed this issue and reported. > https://gitlab.freedesktop.org/drm/intel/-/issues/5239 >   > Lakshmi. >   > From: Surendrakumar Upa

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Remove the vma refcount

On Wed, Mar 02, 2022 at 11:21:59AM +0100, Thomas Hellström wrote: Now that i915_vma_parked() is taking the object lock on vma destruction, and the only user of the vma refcount, i915_gem_object_unbind() also takes the object lock, remove the vma refcount. Signed-off-by: Thomas Hellström --- dri

Re: [Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

Quoting fei.y...@intel.com (2022-03-02 18:26:57) > From: Fei Yang > > GPU hangs have been observed when multiple engines write to the > same aux_inv register at the same time. To avoid this each engine > should only invalidate its own auxiliary table. The function > gen12_emit_flush_xcs() current

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

On Wed, Mar 02, 2022 at 12:18:45PM -0800, Linus Torvalds wrote: > On Wed, Mar 2, 2022 at 12:07 PM Kees Cook wrote: > > > > I've long wanted to change kfree() to explicitly set pointers to NULL on > > free. https://github.com/KSPP/linux/issues/87 > > We've had this discussion with the gcc people i

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Remove the vm open count

On Wed, Mar 02, 2022 at 11:21:58AM +0100, Thomas Hellström wrote: vms are not getting properly closed. Rather than fixing that, Remove the vm open count and instead rely on the vm refcount. The vm open count existed solely to break the strong references the vmas had on the vms. Now instead make

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/gem: Remove some unnecessary code

On Wed, Mar 02, 2022 at 11:22:00AM +0100, Thomas Hellström wrote: The test for vma should always return true, and when assigning -EBUSY to ret, the variable should already have that value. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_gem.c | 32 ++--

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

On Wed, Mar 2, 2022 at 12:07 PM Kees Cook wrote: > > I've long wanted to change kfree() to explicitly set pointers to NULL on > free. https://github.com/KSPP/linux/issues/87 We've had this discussion with the gcc people in the past, and gcc actually has some support for it, but it's sadly tied to

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

On Wed, Mar 02, 2022 at 10:29:31AM +0100, Rasmus Villemoes wrote: > This won't help the current issue (because it doesn't exist and might > never), but just in case some compiler people are listening, I'd like to > have some sort of way to tell the compiler "treat this variable as > uninitialized f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: avoid concurrent writes to aux_inv (rev3)

== Series Details == Series: drm/i915: avoid concurrent writes to aux_inv (rev3) URL : https://patchwork.freedesktop.org/series/100772/ State : success == Summary == CI Bug Log - changes from CI_DRM_11313 -> Patchwork_22465 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for vm- and vma cleanups

== Series Details == Series: vm- and vma cleanups URL : https://patchwork.freedesktop.org/series/100945/ State : success == Summary == CI Bug Log - changes from CI_DRM_11308_full -> Patchwork_22462_full Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: avoid concurrent writes to aux_inv (rev3)

== Series Details == Series: drm/i915: avoid concurrent writes to aux_inv (rev3) URL : https://patchwork.freedesktop.org/series/100772/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: avoid concurrent writes to aux_inv (rev3)

== Series Details == Series: drm/i915: avoid concurrent writes to aux_inv (rev3) URL : https://patchwork.freedesktop.org/series/100772/ State : warning == Summary == $ dim checkpatch origin/drm-tip 48f4099e5fa7 drm/i915: avoid concurrent writes to aux_inv -:82: CHECK:BRACES: Unbalanced braces

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Handle errors for i915_gem_object_trylock

== Series Details == Series: drm/i915/gt: Handle errors for i915_gem_object_trylock URL : https://patchwork.freedesktop.org/series/100951/ State : success == Summary == CI Bug Log - changes from CI_DRM_11313 -> Patchwork_22464 Summary -

[Intel-gfx] [PATCH] drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because the

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

Hi Abhinav, On Wed, Mar 02, 2022 at 10:28:03AM -0800, Abhinav Kumar wrote: > On 2/28/2022 5:42 AM, Laurent Pinchart wrote: > > On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: > >> On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: > >>> On Mon, 28 Feb 2022, Laurent Pinc

Re: [Intel-gfx] [PATCH 5/6] drm/rcar_du: changes to rcar-du driver resulting from drm_writeback_connector structure changes

On 2/28/2022 5:42 AM, Laurent Pinchart wrote: Hello, On Mon, Feb 28, 2022 at 02:28:27PM +0200, Laurent Pinchart wrote: On Mon, Feb 28, 2022 at 02:09:15PM +0200, Jani Nikula wrote: On Mon, 28 Feb 2022, Laurent Pinchart wrote: On Sat, Feb 26, 2022 at 10:27:59AM -0800, Rob Clark wrote: On We

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

On 3/2/2022 01:49, Tvrtko Ursulin wrote: On 25/02/2022 20:41, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

On 3/2/2022 01:20, Tvrtko Ursulin wrote: On 01/03/2022 19:57, John Harrison wrote: On 3/1/2022 02:50, Tvrtko Ursulin wrote: On 28/02/2022 18:32, John Harrison wrote: On 2/28/2022 08:11, Tvrtko Ursulin wrote: On 25/02/2022 17:39, John Harrison wrote: On 2/25/2022 09:06, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

On 3/2/2022 03:07, Tvrtko Ursulin wrote: On 01/03/2022 20:59, John Harrison wrote: On 3/1/2022 04:09, Tvrtko Ursulin wrote: I'll trim it a bit again.. On 28/02/2022 18:55, John Harrison wrote: On 2/28/2022 09:12, Tvrtko Ursulin wrote: On 25/02/2022 18:48, John Harrison wrote: On 2/25/2022

Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

On 3/2/2022 03:21, Tvrtko Ursulin wrote: On 28/02/2022 19:17, John Harrison wrote: On 2/28/2022 07:32, Tvrtko Ursulin wrote: On 25/02/2022 19:03, John Harrison wrote: On 2/25/2022 10:29, Tvrtko Ursulin wrote: On 25/02/2022 18:01, John Harrison wrote: On 2/25/2022 09:39, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH 6/6] treewide: remove check of list iterator against head past the loop body

On 28/02/2022 11:08, Jakob Koschel wrote: When list_for_each_entry() completes the iteration over the whole list without breaking the loop, the iterator value will be a bogus pointer computed based on the head element. While it is safe to use the pointer to determine if it was computed based o

Re: [Intel-gfx] [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

On Wed, Mar 2, 2022 at 10:55 AM Michael Cheng wrote: > > Thanks for the feedback Robin! > > Sorry my choices of word weren't that great, but what I meant is to > understand how ARM flushes a range of dcache for device drivers, and not > an equal to x86 clflush. > > I believe the concern is if the

Re: [Intel-gfx] [PATCH v5 4/7] drm/i915/gt: create per-tile sysfs interface

On 17.02.2022 15:41, Andi Shyti wrote: Now that we have tiles we want each of them to have its own interface. A directory "gt/" is created under "cardN/" that will contain as many diroctories as the tiles. In the coming patches tile related interfaces will be added. For now the sysfs gt struc

[Intel-gfx] ✓ Fi.CI.IGT: success for iommu/vt-d: Add RPLS to quirk list to skip TE disabling (rev3)

== Series Details == Series: iommu/vt-d: Add RPLS to quirk list to skip TE disabling (rev3) URL : https://patchwork.freedesktop.org/series/100165/ State : success == Summary == CI Bug Log - changes from CI_DRM_11308_full -> Patchwork_22458_full =

Re: [Intel-gfx] [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

Thanks for the feedback Robin! Sorry my choices of word weren't that great, but what I meant is to understand how ARM flushes a range of dcache for device drivers, and not an equal to x86 clflush. I believe the concern is if the CPU writes an update, that update might only be sitting in the

Re: [Intel-gfx] [PATCH v2 0/4] drm/i915/ttm: Evict and store of compressed object

Reviewed-by: Nirmoy Das for the series as well. On 01/03/2022 22:53, Ramalingam C wrote: On Xe-HP and later devices, we use dedicated compression control state (CCS) stored in local memory for each surface, to support the 3D and media compression formats. The memory required for the CCS of the

[Intel-gfx] ✗ Fi.CI.BAT: failure for Remove frontbuffer tracking from the gem code

== Series Details == Series: Remove frontbuffer tracking from the gem code URL : https://patchwork.freedesktop.org/series/100950/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11311 -> Patchwork_22463 Summary --- **F

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for i915: Prepare for Xe_HP compute engines (rev4)

On Wed, Mar 02, 2022 at 01:23:49PM +, Patchwork wrote: > == Series Details == > > Series: i915: Prepare for Xe_HP compute engines (rev4) > URL : https://patchwork.freedesktop.org/series/100833/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_11308_full -> Patchwork

Re: [Intel-gfx] [PATCH] drm/i915: add more TMDS clock rate supported by HDMI driver

On Tue, Mar 01, 2022 at 01:01:41PM +0800, Lee Shawn C wrote: > VBT 249 update to support more TMDS clock rate 3.00G, 3.40G > and 5.94G. Refer to this new definition to configure max > TMDS clock rate for HDMI driver. The patch itself looks fine. The patch subject is pretty much incomprehensible to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Remove frontbuffer tracking from the gem code

== Series Details == Series: Remove frontbuffer tracking from the gem code URL : https://patchwork.freedesktop.org/series/100950/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 2/2] drm/i915/mtl: Don't use PIN_MAPPABLE for dpt

Cannot use PIN_MAPPABLE pin on MTL because there's no mappable window. Change dpt allocation as per suggestion from Chris. v2: - Added forgotten/dropped include Signed-off-by: Stanslav Lisovskiy Signed-off-by: Juha-Pekka Heikkilä Cc: Chris Wilson --- drivers/gpu/drm/i915/display/intel_dpt.c |

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: missing boundary check in vm_access leads to OOB read/write

== Series Details == Series: drm/i915/gem: missing boundary check in vm_access leads to OOB read/write URL : https://patchwork.freedesktop.org/series/100932/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11308_full -> Patchwork_22460_full =

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Fix prime_mmap to work when using LMEM (rev2)

The regression reported below is not related to this patch. On TGL platforms that do not use local memory, this patch has no logic changes. This patch relates to the results of the mmap_prime test on dg1 using local memory. (mmap_prime is a different test from mmap_prime_coherency.) >

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

Hi Andrey, On Tue, 1 Mar 2022 22:26:12 -0500 Andrey Grodzovsky wrote: > > Please check you have commit c7703ce38c1e Andrey Grodzovsky   3 weeks ago    > drm/amdgpu: Fix htmldoc warning That has arrived in linux-next today for the first time. It is in the drm tree, but that tree has had build

Re: [Intel-gfx] [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

On 2022-02-25 19:27, Michael Cheng wrote: Hi Robin, [ +arm64 maintainers for their awareness, which would have been a good thing to do from the start ]  * Thanks for adding the arm64 maintainer and sorry I didn't rope them    in sooner. Why does i915 need to ensure the CPU's instruction ca

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

On Mon, 28 Feb 2022 16:41:04 -0800, Linus Torvalds wrote: > > But basically to _me_, the important part is that the end result is > maintainable longer-term. I couldn't agree more. And because of that, I stick with the following approach because it's maintainable longer-term than "type(pos) pos"

[Intel-gfx] [PATCH] drm/i915/gt: Handle errors for i915_gem_object_trylock

As the potential failure of the i915_gem_object_trylock(), it should be better to check it and return error if fails. Fixes: 94ce0d65076c ("drm/i915/gt: Setup a default migration context on the GT") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 6 +- 1 file c

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

From: Xiaomeng Tong > Sent: 02 March 2022 09:31 > > On Mon, 28 Feb 2022 16:41:04 -0800, Linus Torvalds > wrote: > > > > But basically to _me_, the important part is that the end result is > > maintainable longer-term. > > I couldn't agree more. And because of that, I stick with the following > a

[Intel-gfx] [RFC PATCH 2/2] drm/i915: Remove all frontbuffer tracking calls from the gem code

We should now rely on userspace doing dirtyfb. There is no need to have separate frontbuffer tracking hooks in gem code. This patch is removing all frontbuffer tracking calls from the gem code. Signed-off-by: Jouni Högander Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_

[Intel-gfx] [RFC PATCH 1/2] drm/i915/fbdev: Remove frontbuffer tracking calls

Intel_fbdev can use drm_helper functions which are calling dirtyfb callback. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fbdev.c | 62 ++ 1 file changed, 4 insertions(+), 58 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/driv

[Intel-gfx] [RFC PATCH 0/2] Remove frontbuffer tracking from the gem code

We should now rely on userspace doing dirtyfb. There is no need to have separate frontbuffer tracking hooks in gem code. It was found out that fbdev code calling intel_frontbuffer_invalidate caused psr being left disabled. Tackle this by removing intel_frontbuffer_invalidate calls from intel_fbde

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Prepare for Xe_HP compute engines (rev4)

== Series Details == Series: i915: Prepare for Xe_HP compute engines (rev4) URL : https://patchwork.freedesktop.org/series/100833/ State : success == Summary == CI Bug Log - changes from CI_DRM_11308_full -> Patchwork_22459_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for iommu/vt-d: Add RPLS to quirk list to skip TE disabling (rev3)

Regression is not related to the patch. Please mark it pass and requesting to merge. Thanks, Tejas From: Patchwork Sent: 02 March 2022 17:56 To: Surendrakumar Upadhyay, TejaskumarX Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.IGT: failure for iommu/vt-d: Add RPLS to quirk list to skip

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/gem: Extra pages in ttm_tt for ccs data

On Wed, 2022-03-02 at 03:23 +0530, Ramalingam C wrote: > On Xe-HP and later devices, we use dedicated compression control > state (CCS) stored in local memory for each surface, to support the > 3D and media compression formats. > > The memory required for the CCS of the entire local memory is 1/25

Re: [Intel-gfx] [PATCH v2 2/4] drm/ttm: parameter to add extra pages into ttm_tt

On Wed, 2022-03-02 at 03:23 +0530, Ramalingam C wrote: > When a driver needs extra pages in ttm_tt, to facilidate such > requirement, parameter called "extra_pages" is added for > ttm_tt_init nit: Please use imperative wording in commit title and description, "Add a parameter to add extra pages.."

Re: [Intel-gfx] [PATCH] drm/i915: Depend on !PREEMPT_RT.

On 2022-03-02 11:42:35 [+], Tvrtko Ursulin wrote: > > > > 0005-drm-i915-Don-t-check-for-atomic-context-on-PREEMPT_R.patch > > > > > > What do preempt_disable/enable do on PREEMPT_RT? Thinking if instead the > > > solution could be to always force the !ATOMIC path (for the whole > > > _wai

[Intel-gfx] ✗ Fi.CI.IGT: failure for iommu/vt-d: Add RPLS to quirk list to skip TE disabling (rev3)

== Series Details == Series: iommu/vt-d: Add RPLS to quirk list to skip TE disabling (rev3) URL : https://patchwork.freedesktop.org/series/100165/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11308_full -> Patchwork_22458_full =

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmabuf: Fix prime_mmap to work when using LMEM

LGTM Reviewed-by: Nirmoy Das On 25/02/2022 14:13, Gwan-gyeong Mun wrote: The current implementation of i915 prime mmap only works when initializing drm_i915_gem_object with shmem_region. When using LMEM, drm_i915_gem_object is initialized with ttm_system_region. In order to make prime mmap work

[Intel-gfx] ✓ Fi.CI.BAT: success for vm- and vma cleanups

== Series Details == Series: vm- and vma cleanups URL : https://patchwork.freedesktop.org/series/100945/ State : success == Summary == CI Bug Log - changes from CI_DRM_11308 -> Patchwork_22462 Summary --- **SUCCESS** No regression

Re: [Intel-gfx] [PATCH] drm/i915: Depend on !PREEMPT_RT.

On 01/03/2022 15:13, Sebastian Andrzej Siewior wrote: On 2022-03-01 14:27:18 [+], Tvrtko Ursulin wrote: you see: 0003-drm-i915-Use-preempt_disable-enable_rt-where-recomme.patch 0004-drm-i915-Don-t-disable-interrupts-on-PREEMPT_RT-duri.patch Two for the display folks. 000

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for vm- and vma cleanups

== Series Details == Series: vm- and vma cleanups URL : https://patchwork.freedesktop.org/series/100945/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for vm- and vma cleanups

== Series Details == Series: vm- and vma cleanups URL : https://patchwork.freedesktop.org/series/100945/ State : warning == Summary == $ dim checkpatch origin/drm-tip 67a198829865 drm/i915: Remove the vm open count -:26: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (pre

Re: [Intel-gfx] [PATCH 0/3] Improve anti-pre-emption w/a for compute workloads

On 28/02/2022 19:17, John Harrison wrote: On 2/28/2022 07:32, Tvrtko Ursulin wrote: On 25/02/2022 19:03, John Harrison wrote: On 2/25/2022 10:29, Tvrtko Ursulin wrote: On 25/02/2022 18:01, John Harrison wrote: On 2/25/2022 09:39, Tvrtko Ursulin wrote: On 25/02/2022 17:11, John Harrison wro

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Improve anti-pre-emption w/a for compute workloads (rev3)

== Series Details == Series: Improve anti-pre-emption w/a for compute workloads (rev3) URL : https://patchwork.freedesktop.org/series/100428/ State : failure == Summary == Applying: drm/i915/guc: Limit scheduling properties to avoid overflow error: patch failed: drivers/gpu/drm/i915/gt/uc/inte

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Make the heartbeat play nice with long pre-emption timeouts

On 01/03/2022 20:59, John Harrison wrote: On 3/1/2022 04:09, Tvrtko Ursulin wrote: I'll trim it a bit again.. On 28/02/2022 18:55, John Harrison wrote: On 2/28/2022 09:12, Tvrtko Ursulin wrote: On 25/02/2022 18:48, John Harrison wrote: On 2/25/2022 10:14, Tvrtko Ursulin wrote: [snip] Y

Re: [Intel-gfx] [PATCH] drm/i915/gt: Handle errors for i915_gem_object_trylock

+ Thomas, Matt On 02/03/2022 06:19, Jiasheng Jiang wrote: As the potential failure of the i915_gem_object_trylock(), it should be better to check it and return error if fails. Fixes: 94ce0d65076c ("drm/i915/gt: Setup a default migration context on the GT") Signed-off-by: Jiasheng Jiang ---

[Intel-gfx] [PATCH v2 3/3] drm/i915/gem: Remove some unnecessary code

The test for vma should always return true, and when assigning -EBUSY to ret, the variable should already have that value. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_gem.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH v2 2/3] drm/i915: Remove the vma refcount

Now that i915_vma_parked() is taking the object lock on vma destruction, and the only user of the vma refcount, i915_gem_object_unbind() also takes the object lock, remove the vma refcount. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_gem.c | 17 + drivers/

[Intel-gfx] [PATCH v2 1/3] drm/i915: Remove the vm open count

vms are not getting properly closed. Rather than fixing that, Remove the vm open count and instead rely on the vm refcount. The vm open count existed solely to break the strong references the vmas had on the vms. Now instead make those references weak and ensure vmas are destroyed when the vm is d

[Intel-gfx] [PATCH v2 0/3] vm- and vma cleanups

The first patch of the series addresses a vm open count bug by removing the vm open count. The second patch removes the vma refcount that is no longer needed; the vma is kept a live by taking the vm refcount and object lock. Finally the last patch removes some unnecessary code. There should be no

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

On 25/02/2022 20:41, john.c.harri...@intel.com wrote: From: John Harrison GuC converts the pre-emption timeout and timeslice quantum values into clock ticks internally. That significantly reduces the point of 32bit overflow. On current platforms, worst case scenario is approximately 110 secon

Re: [Intel-gfx] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

On 02/03/2022 00.55, Linus Torvalds wrote: > On Tue, Mar 1, 2022 at 3:19 PM David Laight wrote: >> > With the "don't use iterator outside the loop" approach, the exact > same code works in both the old world order and the new world order, > and you don't have the semantic confusion. And *if* you

[Intel-gfx] ✗ Fi.CI.IGT: failure for Prep work for next GuC release (rev4)

== Series Details == Series: Prep work for next GuC release (rev4) URL : https://patchwork.freedesktop.org/series/99805/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11308_full -> Patchwork_22457_full Summary --- **

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Limit scheduling properties to avoid overflow

On 01/03/2022 19:57, John Harrison wrote: On 3/1/2022 02:50, Tvrtko Ursulin wrote: On 28/02/2022 18:32, John Harrison wrote: On 2/28/2022 08:11, Tvrtko Ursulin wrote: On 25/02/2022 17:39, John Harrison wrote: On 2/25/2022 09:06, Tvrtko Ursulin wrote: On 24/02/2022 19:19, John Harrison wro

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Count engine instances per uabi class

On 01/03/2022 19:34, Umesh Nerlige Ramappa wrote: On Tue, Feb 22, 2022 at 02:04:21PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin This will be useful to have at hand in a following patch. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_engine_user.c | 11 ++- dr

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/mm: Add an iterator to optimally walk over holes suitable for an allocation (rev2)

Hi Vivek, On 01/03/2022 19:23, Patchwork wrote: *Patch Details* *Series:* drm/mm: Add an iterator to optimally walk over holes suitable for an allocation (rev2) *URL:* https://patchwork.freedesktop.org/series/100847/ *State:*failure

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Evict and store of compressed object (rev2)

== Series Details == Series: drm/i915/ttm: Evict and store of compressed object (rev2) URL : https://patchwork.freedesktop.org/series/99759/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11308_full -> Patchwork_22455_full S

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove the vm open count

On Tue, 2022-03-01 at 19:45 -0800, Niranjana Vishwanathapura wrote: > On Tue, Feb 22, 2022 at 06:10:30PM +0100, Thomas Hellström wrote: > > vms are not getting properly closed. Rather than fixing that, > > Remove the vm open count and instead rely on the vm refcount. > > > > The vm open count exis