Re: [Intel-gfx] [PATCH] drm/i915/dmc: Add MMIO range restrictions

Hi Anusha, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip v5.18-rc1 next-20220405] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[Intel-gfx] ✗ Fi.CI.IGT: failure for Splitting up platform-specific calls (rev2)

== Series Details == Series: Splitting up platform-specific calls (rev2) URL : https://patchwork.freedesktop.org/series/102041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11459_full -> Patchwork_22790_full Summary --

Re: [Intel-gfx] [PATCH] drm/i915/uncore: Warn on previous unclaimed accesses

On Tue, Apr 05, 2022 at 09:02:42PM -0700, Matt Roper wrote: On Mon, Apr 04, 2022 at 05:11:49PM -0700, Lucas De Marchi wrote: Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers. This register is in the display engine IP and can only ever detect unclaimed accesses to registers

Re: [Intel-gfx] linux-next: build warnings after merge of the drm-misc tree

Hi all, On Wed, 6 Apr 2022 15:44:31 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME) This was an "htmldocs" build. -- Cheers, Stephen Rothwell pgp21BZgJxF3c.pgp Description: OpenPGP digital signature

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/drm/ttm/ttm_resource.h:226: warning: Function parameter or member 'pos' not described in 'ttm_lru_bulk_move' Introduced by commit b0e2c9ea5afc ("drm/ttm: allow bulk moves for all domai

[Intel-gfx] linux-next: build warnings after merge of the drm-misc tree

Hi all, After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME) produced these warnings: drivers/gpu/drm/drm_edid.c:1589: warning: Function parameter or member '_edid' not described in 'drm_edid_header_is_valid' drivers/gpu/drm/drm_edid.c:1589: warning: Excess function parameter

[Intel-gfx] ✓ Fi.CI.IGT: success for ALSA: hda/i915 - skip acomp init if no matching display

== Series Details == Series: ALSA: hda/i915 - skip acomp init if no matching display URL : https://patchwork.freedesktop.org/series/102218/ State : success == Summary == CI Bug Log - changes from CI_DRM_11459_full -> Patchwork_22789_full Su

Re: [Intel-gfx] [RFC PATCH v2 2/3] drm/i915: Define WD trancoder for i915

Hi All, ++Uma Regards, Suraj Kandpal > -Original Message- > From: Kandpal, Suraj > Sent: Thursday, March 17, 2022 2:09 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; ville.syrj...@linux.intel.com; > Murthy, Arun R ; Kandpal, Suraj > > Subject: [RFC PATCH v2 2/3] drm/i915:

Re: [Intel-gfx] [RFC PATCH v2 3/3] drm/i915: Enabling WD Transcoder

Hi All, ++Uma Regards, Suraj Kandpal > Adding support for writeback transcoder to start capturing frames using > interrupt mechanism > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/display/intel_acpi.c | 1 + > drivers

Re: [Intel-gfx] [RFC PATCH v2 1/3] drm/i915: Creating writeback pipeline to bypass drm_writeback framework

++Uma Regards, Suraj Kandpal > Changes to create a i915 private pipeline to enable the WD transcoder > without relying on the current drm_writeback framework. > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/Makefile | 1 + > .../drm/i915/display/intel_display_ty

Re: [Intel-gfx] [RFC PATCH v2 0/3] i915 writeback private framework

Hi All, Gentle Reminder. ++Uma Regards Suraj Kandapal > A patch series was floated in the drm mailing list which aimed to change the > drm_connector and drm_encoder fields to pointer in the > drm_connector_writeback structure, this received a huge pushback from the > community but since i915 expe

Re: [Intel-gfx] [PATCH] drm/i915/uncore: Warn on previous unclaimed accesses

On Mon, Apr 04, 2022 at 05:11:49PM -0700, Lucas De Marchi wrote: > Since gen6 we use FPGA_DBG register to detect unclaimed MMIO registers. > This register is in the display engine IP and can only ever detect > unclaimed accesses to registers in this area. However sometimes there > are reports of th

[Intel-gfx] ✓ Fi.CI.BAT: success for linux-next: build failure after merge of the drm-misc tree

== Series Details == Series: linux-next: build failure after merge of the drm-misc tree URL : https://patchwork.freedesktop.org/series/102234/ State : success == Summary == CI Bug Log - changes from CI_DRM_11459 -> Patchwork_22795 Summary -

[Intel-gfx] ✗ Fi.CI.DOCS: warning for linux-next: build failure after merge of the drm-misc tree

== Series Details == Series: linux-next: build failure after merge of the drm-misc tree URL : https://patchwork.freedesktop.org/series/102234/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for linux-next: build failure after merge of the drm-misc tree

== Series Details == Series: linux-next: build failure after merge of the drm-misc tree URL : https://patchwork.freedesktop.org/series/102234/ State : warning == Summary == $ dim checkpatch origin/drm-tip e9f5f04870a7 linux-next: build failure after merge of the drm-misc tree -:18: WARNING:COM

[Intel-gfx] ✓ Fi.CI.BAT: success for GSC support (rev4)

== Series Details == Series: GSC support (rev4) URL : https://patchwork.freedesktop.org/series/102160/ State : success == Summary == CI Bug Log - changes from CI_DRM_11459 -> Patchwork_22793 Summary --- **SUCCESS** No regressions

[Intel-gfx] ✗ Fi.CI.BUILD: failure for linux-next: manual merge of the amdgpu tree with the drm-misc tree

== Series Details == Series: linux-next: manual merge of the amdgpu tree with the drm-misc tree URL : https://patchwork.freedesktop.org/series/102232/ State : failure == Summary == Applying: linux-next: manual merge of the amdgpu tree with the drm-misc tree error: sha1 information is lacking o

[Intel-gfx] ✗ Fi.CI.DOCS: warning for GSC support (rev4)

== Series Details == Series: GSC support (rev4) URL : https://patchwork.freedesktop.org/series/102160/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function parameter or member 'client_link' not de

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for GSC support (rev4)

== Series Details == Series: GSC support (rev4) URL : https://patchwork.freedesktop.org/series/102160/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support (rev4)

== Series Details == Series: GSC support (rev4) URL : https://patchwork.freedesktop.org/series/102160/ State : warning == Summary == $ dim checkpatch origin/drm-tip ba37d4d833f3 drm/i915/gsc: add gsc as a mei auxiliary device -:65: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), do

[Intel-gfx] ✓ Fi.CI.BAT: success for Splitting intel-gtt calls for non-x86 platforms (rev8)

== Series Details == Series: Splitting intel-gtt calls for non-x86 platforms (rev8) URL : https://patchwork.freedesktop.org/series/101552/ State : success == Summary == CI Bug Log - changes from CI_DRM_11459 -> Patchwork_22792 Summary -

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Splitting intel-gtt calls for non-x86 platforms (rev8)

== Series Details == Series: Splitting intel-gtt calls for non-x86 platforms (rev8) URL : https://patchwork.freedesktop.org/series/101552/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function para

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

On 4/6/22 02:58, Stephen Rothwell wrote: Hi all, Hi, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: drivers/gpu/drm/bridge/chipone-icn6211.prelink.o(.exit.data+0x0): Section mismatch in reference from the variable __

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Splitting intel-gtt calls for non-x86 platforms (rev8)

== Series Details == Series: Splitting intel-gtt calls for non-x86 platforms (rev8) URL : https://patchwork.freedesktop.org/series/101552/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Splitting intel-gtt calls for non-x86 platforms (rev8)

== Series Details == Series: Splitting intel-gtt calls for non-x86 platforms (rev8) URL : https://patchwork.freedesktop.org/series/101552/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4091a3a0963e drm/i915/gt: Split intel-gtt functions by arch -:368: CHECK:PARENTHESIS_ALIGNMEN

[Intel-gfx] ✓ Fi.CI.BAT: success for fbcon cleanups

== Series Details == Series: fbcon cleanups URL : https://patchwork.freedesktop.org/series/102223/ State : success == Summary == CI Bug Log - changes from CI_DRM_11459 -> Patchwork_22791 Summary --- **SUCCESS** No regressions foun

[Intel-gfx] ✗ Fi.CI.DOCS: warning for fbcon cleanups

== Series Details == Series: fbcon cleanups URL : https://patchwork.freedesktop.org/series/102223/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function parameter or member 'client_link' not descri

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for fbcon cleanups

== Series Details == Series: fbcon cleanups URL : https://patchwork.freedesktop.org/series/102223/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sr

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fbcon cleanups

== Series Details == Series: fbcon cleanups URL : https://patchwork.freedesktop.org/series/102223/ State : warning == Summary == $ dim checkpatch origin/drm-tip dfa32370def4 fbcon: delete a few unneeded forward decl -:66: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mism

[Intel-gfx] ✓ Fi.CI.BAT: success for Splitting up platform-specific calls (rev2)

== Series Details == Series: Splitting up platform-specific calls (rev2) URL : https://patchwork.freedesktop.org/series/102041/ State : success == Summary == CI Bug Log - changes from CI_DRM_11459 -> Patchwork_22790 Summary --- **SUC

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: drivers/gpu/drm/bridge/chipone-icn6211.prelink.o(.exit.data+0x0): Section mismatch in reference from the variable __cfi_jt_cleanup_module to the function .init.text:

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/panel/panel-newvision-nv3052c.c:478:19: error: initialization of 'void (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *)' [-Werror=incom

[Intel-gfx] ✗ Fi.CI.DOCS: warning for Splitting up platform-specific calls (rev2)

== Series Details == Series: Splitting up platform-specific calls (rev2) URL : https://patchwork.freedesktop.org/series/102041/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function parameter or me

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Splitting up platform-specific calls (rev2)

== Series Details == Series: Splitting up platform-specific calls (rev2) URL : https://patchwork.freedesktop.org/series/102041/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for ALSA: hda/i915 - skip acomp init if no matching display

== Series Details == Series: ALSA: hda/i915 - skip acomp init if no matching display URL : https://patchwork.freedesktop.org/series/102218/ State : success == Summary == CI Bug Log - changes from CI_DRM_11459 -> Patchwork_22789 Summary

[Intel-gfx] linux-next: manual merge of the amdgpu tree with the drm-misc tree

Hi all, Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c between commit: fee2ede15542 ("drm/ttm: rework bulk move handling v5") from the drm-misc tree and commit: 184a69ca4d41 ("drm/amdgpu: separate VM PT handling into amdgpu_vm_pt.c"

[Intel-gfx] ✗ Fi.CI.DOCS: warning for ALSA: hda/i915 - skip acomp init if no matching display

== Series Details == Series: ALSA: hda/i915 - skip acomp init if no matching display URL : https://patchwork.freedesktop.org/series/102218/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function par

Re: [Intel-gfx] [PATCH v3 01/17] fbcon: delete a few unneeded forward decl

On Tue, Apr 5, 2022 at 6:04 PM Daniel Vetter wrote: > > I didn't bother with any code movement to fix the others, these just > got a bit in the way. > > v2: Rebase on top of Helge's reverts. > > Acked-by: Thomas Zimmermann > Acked-by: Sam Ravnborg (v1) > Reviewed-by: Geert Uytterhoeven (v1) > S

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching

== Series Details == Series: drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching URL : https://patchwork.freedesktop.org/series/102213/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11458 -> Patchwork_22788 ==

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Add MMIO range restrictions

Hi Anusha, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.18-rc1 next-20220405] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching

== Series Details == Series: drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching URL : https://patchwork.freedesktop.org/series/102213/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warnin

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching

== Series Details == Series: drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching URL : https://patchwork.freedesktop.org/series/102213/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separ

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching

== Series Details == Series: drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching URL : https://patchwork.freedesktop.org/series/102213/ State : warning == Summary == $ dim checkpatch origin/drm-tip 05d9638c2980 drm/i915/bios: Use the cached BDB version 578166bc3056 drm/i915

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: Add MMIO range restrictions (rev2)

== Series Details == Series: drm/i915/dmc: Add MMIO range restrictions (rev2) URL : https://patchwork.freedesktop.org/series/102168/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11458 -> Patchwork_22787 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fixup kerneldoc in struct i915_gem_context

== Series Details == Series: drm/i915: Fixup kerneldoc in struct i915_gem_context URL : https://patchwork.freedesktop.org/series/102210/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11456_full -> Patchwork_22786_full Summa

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dmc: Add MMIO range restrictions (rev2)

== Series Details == Series: drm/i915/dmc: Add MMIO range restrictions (rev2) URL : https://patchwork.freedesktop.org/series/102168/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_context_types.h:417: warning: Function parameter

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: Add MMIO range restrictions (rev2)

== Series Details == Series: drm/i915/dmc: Add MMIO range restrictions (rev2) URL : https://patchwork.freedesktop.org/series/102168/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8f8a6288aa4a drm/i915/dmc: Add MMIO range restrictions -:42: CHECK:PARENTHESIS_ALIGNMENT: Alignment

Re: [Intel-gfx] [PATCH] drm/i915: Fix skl_pcode_try_request function

Hi Stan Nice Find! Couple of clarifications, please check inline... On Tue, 2022-04-05 at 13:41 +0300, Stanislav Lisovskiy wrote: > Currently skl_pcode_try_request function doesn't > properly handle return value it gets from > snb_pcode_rw, but treats status != 0 as success, > returning true, whi

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch

== Series Details == Series: series starting with [CI,1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch URL : https://patchwork.freedesktop.org/series/102209/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11456_full -> Patchwork_22785_full

[Intel-gfx] [PATCH v3 15/17] fbcon: Move more code into fbcon_release

con2fb_release_oldinfo() has a bunch more kfree() calls than fbcon_exit(), but since kfree() on NULL is harmless doing that in both places should be ok. This is also a bit more symmetric now again with fbcon_open also allocating the fbcon_ops structure. Acked-by: Sam Ravnborg Signed-off-by: Danie

[Intel-gfx] [PATCH v3 17/17] fbcon: Maintain a private array of fb_info

Accessing the one in fbmem.c without taking the right locks is a bad idea. Instead maintain our own private copy, which is fully protected by console_lock() (like everything else in fbcon.c). That copy is serialized through fbcon_fb_registered/unregistered() calls. Also this means we do not need t

[Intel-gfx] [PATCH v3 16/17] fbcon: untangle fbcon_exit

There's a bunch of confusions going on here: - The deferred fbcon setup notifier should only be cleaned up from fb_console_exit(), to be symmetric with fb_console_init() - We also need to make sure we don't race with the work, which means temporarily dropping the console lock (or we can deadloc

[Intel-gfx] [PATCH v3 14/17] fbcon: Move console_lock for register/unlink/unregister

Ideally console_lock becomes an implementation detail of fbcon.c and doesn't show up anywhere in fbmem.c. We're still pretty far from that, but at least the register/unregister code is there now. With this the do_fb_ioctl() handler is the only code in fbmem.c still calling console_lock(). Acked-b

[Intel-gfx] [PATCH v3 13/17] fbcon: Consistently protect deferred_takeover with console_lock()

This shouldn't be a problem in practice since until we've actually taken over the console there's nothing we've registered with the console/vt subsystem, so the exit/unbind path that check this can't do the wrong thing. But it's confusing, so fix it by moving it a tad later. Acked-by: Sam Ravnborg

[Intel-gfx] [PATCH v3 11/17] fbcon: move more common code into fb_open()

No idea why con2fb_acquire_newinfo() initializes much less than fbcon_startup(), but so be it. From a quick look most of the un-initialized stuff should be fairly harmless, but who knows. Note that the error handling for the con2fb_acquire_newinfo() failure case was very strange: Callers updated c

[Intel-gfx] [PATCH v3 10/17] fbcon: Ditch error handling for con2fb_release_oldinfo

It doesn't ever fail anymore. Acked-by: Sam Ravnborg Acked-by: Thomas Zimmermann Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Thomas Zimmermann Cc: Greg Kroah-Hartman Cc: Claudio Suarez Cc: Du Cheng Cc: Tetsuo Handa --- drivers/video/fbdev/core/fbcon.c | 37 +++-

[Intel-gfx] [PATCH v3 08/17] fb: Delete fb_info->queue

It was only used by fbcon, and that now switched to its own, private work. Acked-by: Sam Ravnborg Acked-by: Thomas Zimmermann Signed-off-by: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@vger.kernel.org --- include/linux/fb.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/f

[Intel-gfx] [PATCH v3 12/17] fbcon: use lock_fb_info in fbcon_open/release

Now we get to the real motiviation, because fbmem.c insists that that's the right lock for these. Ofc fbcon.c has a lot more places where it probably should call lock_fb_info(). But looking at fbmem.c at least most of these seem to be protected by console_lock() too, which is probably what papers

[Intel-gfx] [PATCH v3 09/17] fbcon: Extract fbcon_open/release helpers

There's two minor behaviour changes in here: - in error paths we now consistently call fb_ops->fb_release - fb_release really can't fail (fbmem.c ignores it too) and there's no reasonable cleanup we can do anyway. Note that everything in fbcon.c is protected by the big console_lock() lock (espec

[Intel-gfx] [PATCH v3 05/17] fbdev/sysfs: Fix locking

fb_set_var requires we hold the fb_info lock. Or at least this now matches what the ioctl does ... Note that ps3fb and sh_mobile_lcdcfb are busted in different ways here, but I will not fix them up. Also in practice this isn't a big deal, because really variable fbdev state is actually protected

[Intel-gfx] [PATCH v3 07/17] fbcon: Replace FBCON_FLAGS_INIT with a boolean

It's only one flag and slightly tidier code. Acked-by: Thomas Zimmermann Acked-by: Sam Ravnborg Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Tetsuo Handa Cc: Greg Kroah-Hartman Cc: Du Cheng Cc: Thomas Zimmermann Cc: Claudio Suarez --- drivers/video/fbdev/core/fbcon.c | 11 +

[Intel-gfx] [PATCH v3 06/17] fbcon: Use delayed work for cursor

Allows us to delete a bunch of hand-rolled stuff using a timer plus a separate work). Also to simplify the code we initialize the cursor_work completely when we allocate the fbcon_ops structure, instead of trying to cope with console re-initialization. The motiviation here is that fbcon code stops

[Intel-gfx] [PATCH v3 04/17] fbcon: delete delayed loading code

Before commit 6104c37094e729f3d4ce65797002112735d49cd1 Author: Daniel Vetter Date: Tue Aug 1 17:32:07 2017 +0200 fbcon: Make fbcon a built-time depency for fbdev it was possible to load fbcon and fbdev drivers in any order, which means that fbcon init had to handle the case where fbdev dr

[Intel-gfx] [PATCH v3 03/17] fbcon: Introduce wrapper for console->fb_info lookup

Half of it is protected by console_lock, but the other half is a lot more awkward: Registration/deregistration of fbdev are serialized, but we don't really clear out anything in con2fb_map and so there's potential for use-after free mixups. First step is to encapsulate the lookup. Acked-by: Thoma

[Intel-gfx] [PATCH v3 02/17] fbcon: Move fbcon_bmove(_rec) functions

Avoids two forward declarations, and more importantly, matches what I've done in my fbcon scrolling restore patches - so I need this to avoid a bunch of conflicts in rebasing since we ended up merging Helge's series instead. Acked-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Signe

[Intel-gfx] [PATCH v3 01/17] fbcon: delete a few unneeded forward decl

I didn't bother with any code movement to fix the others, these just got a bit in the way. v2: Rebase on top of Helge's reverts. Acked-by: Thomas Zimmermann Acked-by: Sam Ravnborg (v1) Reviewed-by: Geert Uytterhoeven (v1) Signed-off-by: Daniel Vetter Cc: Helge Deller Cc: Daniel Vetter Cc: T

[Intel-gfx] [PATCH v3 00/17] fbcon cleanups

Hi all, Finally got around to respin this. Changes: - Bunch more acks and r-b, still not yet all patches. - one tiny fix for a bisect issue, end result was all fine - I dropped the last to patches to make registered_fb private, that needs more work around how we handle the unregister vs driver l

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: Evict and restore of compressed object (rev9)

== Series Details == Series: drm/i915/ttm: Evict and restore of compressed object (rev9) URL : https://patchwork.freedesktop.org/series/101106/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11456_full -> Patchwork_22783_full

Re: [Intel-gfx] [PATCH v2 06/19] fbcon: Use delayed work for cursor

On Thu, Feb 10, 2022 at 08:43:36PM +0900, Tetsuo Handa wrote: > On 2022/02/09 6:08, Daniel Vetter wrote: > > @@ -714,6 +700,8 @@ static int con2fb_acquire_newinfo(struct vc_data *vc, > > struct fb_info *info, > > ops = kzalloc(sizeof(struct fbcon_ops), GFP_KERNEL); > > if (

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Improve on suspend / resume time with VT-d enabled

== Series Details == Series: drm/i915: Improve on suspend / resume time with VT-d enabled URL : https://patchwork.freedesktop.org/series/102187/ State : success == Summary == CI Bug Log - changes from CI_DRM_11456_full -> Patchwork_22781_full ===

Re: [Intel-gfx] [PATCH v6 1/1] Split i915_run_as_guest into x86 and non-x86

On Tue, Apr 05, 2022 at 11:04:54AM -0700, Casey Bowman wrote: @Jani/Lucas, any other thoughts here? last version didn't pass CI: https://patchwork.freedesktop.org/series/102041/ when this happens, developer should analyze the results to check if it's a regression from their changes. When it's

[Intel-gfx] [PATCH topic/core-for-CI] ALSA: hda/i915 - skip acomp init if no matching display

From: Kai Vehmanen In systems with only a discrete i915 GPU, the acomp init will always timeout for the PCH HDA controller instance. Avoid the timeout by checking the PCI device hierarchy whether any display class PCI device can be found on the system, and at the same level as the HDA PCI device

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix skl_pcode_try_request function

== Series Details == Series: drm/i915: Fix skl_pcode_try_request function URL : https://patchwork.freedesktop.org/series/102186/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11456_full -> Patchwork_22780_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fixup kerneldoc in struct i915_gem_context

== Series Details == Series: drm/i915: Fixup kerneldoc in struct i915_gem_context URL : https://patchwork.freedesktop.org/series/102210/ State : success == Summary == CI Bug Log - changes from CI_DRM_11456 -> Patchwork_22786 Summary ---

Re: [Intel-gfx] [PATCH v2 12/12] drm/i915/dp: Disable DFP RGB->YCbCr conversion for now

On Fri, Apr 01, 2022 at 07:00:02AM +, Shankar, Uma wrote: > > > > -Original Message- > > From: Ville Syrjala > > Sent: Tuesday, March 22, 2022 5:30 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Nautiyal, Ankit K ; Shankar, Uma > > > > Subject: [PATCH v2 12/12] drm/i915/dp: Disa

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/gt: Split intel-gtt functions by arch

@Jani/Lucas, any other thoughts here? Regards, Casey On 3/31/22 07:36, Tvrtko Ursulin wrote: On 31/03/2022 00:48, Casey Bowman wrote: Some functions defined in the intel-gtt module are used in several areas, but is only supported on x86 platforms. By separating these calls and their static u

Re: [Intel-gfx] [PATCH v6 1/1] Split i915_run_as_guest into x86 and non-x86

@Jani/Lucas, any other thoughts here? Regards, Casey On 3/31/22 13:43, Casey Bowman wrote: Splitting i915_run_as_guest into a more arch-friendly function as non-x86 builds do not support this functionality. Signed-off-by: Casey Bowman Acked-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fixup kerneldoc in struct i915_gem_context

== Series Details == Series: drm/i915: Fixup kerneldoc in struct i915_gem_context URL : https://patchwork.freedesktop.org/series/102210/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Add MMIO range restrictions

On Tue, Apr 05, 2022 at 10:14:29AM -0700, Anusha Srivatsa wrote: Bspec has added some steps that check for DMC MMIO range before programming them. v2: Fix for CI failure for v1 Cc: Lucas De Marchi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dmc.c | 42 +++

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch

== Series Details == Series: series starting with [CI,1/3] drm/i915/display/psr: Set partial frame enable when forcing full frame fetch URL : https://patchwork.freedesktop.org/series/102209/ State : success == Summary == CI Bug Log - changes from CI_DRM_11456 -> Patchwork_22785 ==

[Intel-gfx] [PATCH v2 22/22] drm/i915/bios: Dump PNPID and panel name

From: Ville Syrjälä Dump the panel PNPID and name from the VBT. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 24 +++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/inte

[Intel-gfx] [PATCH v2 21/22] drm/edid: Extract drm_edid_decode_mfg_id()

From: Ville Syrjälä Make the PNPID decoding available for other users. Cc: dri-de...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- include/drm/drm_edid.h | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_edid.h b/include/drm/drm

[Intel-gfx] [PATCH v2 20/22] drm/i915: Respect VBT seamless DRRS min refresh rate

From: Ville Syrjälä Make sure our choice of downclock mode respects the VBT seameless DRRS min refresh rate limit. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_panel.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH v2 14/22] drm/i915/pps: Reinit PPS delays after VBT has been fully parsed

From: Ville Syrjälä During the eDP probe we may not yet know the panel_type used to index the VBT panel tables. So the initial eDP probe will have to be done without that, and thus we won't yet have the PPS delays from the VBT. Once the VBT has been fully parse we should reinit the PPS delays to

[Intel-gfx] [PATCH v2 12/22] drm/i915/bios: Split VBT parsing to global vs. panel specific parts

From: Ville Syrjälä Parsing the panel specific data from VBT is currently happening too early. Split the whole thing into global vs. panel specific parts so that we can start doing the panel specific parsing at a later time. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_b

[Intel-gfx] [PATCH v2 16/22] drm/i915/bios: Extract get_panel_type()

From: Ville Syrjälä Pull the code to determine the panel type into its own set of sane functions. v2: rebase Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 58 +++ 1 file changed, 39 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 19/22] drm/i915/bios: Parse the seamless DRRS min refresh rate

From: Ville Syrjälä Extract the seamless DRRS min refresh rate from the VBT. v2: Do a version check Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 9 - drivers/gpu/drm/i915/i915_drv.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff

[Intel-gfx] [PATCH v2 18/22] drm/i915/bios: Determine panel type via PNPID match

From: Ville Syrjälä Apparently when the VBT panel_type==0xff we should trawl through the PNPID table and check for a match against the EDID. If a match is found the index gives us the panel_type. Tried to match the Windows behaviour here with first looking for an exact match, and if one isn't fo

[Intel-gfx] [PATCH v2 17/22] drm/i915/bios: Refactor panel_type code

From: Ville Syrjälä Make the panel type code a bit more abstract along the lines of the source of the panel type. For the moment we have three classes: OpRegion, VBT, fallback. Well introduce another one shortly. We can now also print out all the different panel types, and indicate which one we

[Intel-gfx] [PATCH v2 08/22] drm/i915/bios: Generate LFP data table pointers if the VBT lacks them

From: Ville Syrjälä Modern VBTs no longer contain the LFP data table pointers block (41). We are expecting to have one in order to be able to parse the LFP data block (42), so let's make one up. Since the fp_timing table has variable size we must somehow determine its size. Rather than just hard

[Intel-gfx] [PATCH v2 07/22] drm/i915/bios: Reorder panel DTD parsing

From: Ville Syrjälä Reorder things so that we can parse the entier LFP data block in one go. For now we just stick to parsing the DTD from it. Also fix the misleading comment about block 42 being deprecated. Only the DTD part is deprecated, the rest is still very much needed. Signed-off-by: Vil

[Intel-gfx] [PATCH v2 15/22] drm/i915/bios: Do panel specific VBT parsing later

From: Ville Syrjälä Move the panel specific VBT parsing to happen during the output probing stage. Needs to be done because the VBT parsing will need to look at the EDID to determine the correct panel_type on some machines. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/icl_dsi.

[Intel-gfx] [PATCH v2 13/22] drm/i915/pps: Split PPS init+sanitize in two

From: Ville Syrjälä Split the PPS init to something we do at the start of the eDP probe and a second part we do at the end. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ drivers/gpu/drm/i915/display/intel_pps.c | 30 drivers/gpu/drm

[Intel-gfx] [PATCH v2 09/22] drm/i915/bios: Get access to the tail end of the LFP data block

From: Ville Syrjälä We need to start parsing stuff from the tail end of the LFP data block. This is made awkward by the fact that the fp_timing table has variable size. So we must use a bit more finesse to get the tail end, and to make sure we allocate enough memory for it to make sure our struct

[Intel-gfx] [PATCH v2 11/22] drm/i915/bios: Split parse_driver_features() into two parts

From: Ville Syrjälä We use the "driver features" block for two different kinds of data: global data, and per panel data. Split the function into two parts along that line so that we can start doing the parsing in two different locations. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/di

[Intel-gfx] [PATCH v2 05/22] drm/i915/bios: Trust the LFP data pointers

From: Ville Syrjälä Now that we've sufficiently validated the LFP data pointers we can trust them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 60 ++- 1 file changed, 16 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/i915/displ

[Intel-gfx] [PATCH v2 10/22] drm/i915/bios: Assume panel_type==0 if the VBT has bogus data

From: Ville Syrjälä Just assume panel_type==0 always if the VBT gives us bogus data. We actually already do this everywhere else except in parse_panel_options() since we just leave i915->vbt.panel_type zeroed. This also seems to be what Windows does. Signed-off-by: Ville Syrjälä --- drivers/gp

[Intel-gfx] [PATCH v2 06/22] drm/i915/bios: Validate the panel_name table

From: Ville Syrjälä In addition to the fp_timing,dvo_timing,panel_pnp_id tables there also exists a panel_name table. Unlike the others this is just one offset+table_size even though there are still 16 actual panel_names in the data block. The panel_name table made its first appearance somewhere

[Intel-gfx] [PATCH v2 04/22] drm/i915/bios: Validate LFP data table pointers

From: Ville Syrjälä Make sure the LFP data table pointers sane. Sensible looking table entries, everything points correctly into the data block, etc. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 82 ++- 1 file changed, 81 insertions(+), 1 del

[Intel-gfx] [PATCH v2 00/22] drm/i915/bios: Rework BDB block handling and PNPID->panel_type matching

From: Ville Syrjälä Several changes to our BDB block handling: 1) The current way of trusting the version checks to avoid out of bounds accesses to the BDB blocks is fragile. We might just get the version check wrong, or the VBT may be corrupted/malicious. So instead of doing blind accesses into

  1   2   >