[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

2022-04-11 Thread Patchwork
== Series Details == Series: i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi URL : https://patchwork.freedesktop.org/series/102553/ State : success == Summary == CI Bug Log - changes from CI_DRM_11484_full -> Patchwork_102553v1_full

Re: [Intel-gfx] [PATCH v9 1/3] i915/gvt: Separate the MMIO tracking table from GVT-g

2022-04-11 Thread Wang, Zhi A
Ping. :) On 4/8/22 2:07 PM, Zhi Wang wrote: > Hi Jani: > > Thanks so much for the help. Can you generate a new tag on drm-intel-next? I > noticed that there was one patch moving the DMC related registers into > display/intel_dmc_regs.h, which is not included in the latest tag on >

[Intel-gfx] [PATCH] drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-11 Thread Jouni Högander
We have now seen panel (XMG Core 15 e21 laptop) avertizing support for Intel proprietary eDP backlight control via DPCD registers, but actually working only with legacy pwm control. This patch adds panel EDID check for possible HDR static metadata and does detection from DPCD registers only if

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

2022-04-11 Thread Vudum, Lakshminarayana
Yeah that something new https://gitlab.freedesktop.org/drm/intel/-/issues/5631 igt@i915_selftest@live@gt_engines - fail - rcs0 Mismatch between ring timestamp and walltime! i915/live_engine_pm_selftests: live_engine_timestamps failed with error -22 Thanks, Lakshmi. -Original Message-

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

2022-04-11 Thread Patchwork
== Series Details == Series: i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi URL : https://patchwork.freedesktop.org/series/102553/ State : success == Summary == CI Bug Log - changes from CI_DRM_11484 -> Patchwork_102553v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

2022-04-11 Thread Patchwork
== Series Details == Series: i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi URL : https://patchwork.freedesktop.org/series/102553/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11484 -> Patchwork_102553v1 Summary ---

Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Modem, Bhanuprakash
On Tue-12-04-2022 08:37 am, Murthy, Arun R wrote: +static int output_bpc_show(struct seq_file *m, void *data) { Would it be better to have this function name as drm_output_bpc_show() As we are using DEFINE_SHOW_ATTRIBUTE() to define file_operations, this function name must be _show().

Re: [Intel-gfx] [V2 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-04-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com;

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

2022-04-11 Thread Matt Roper
On Tue, Apr 12, 2022 at 12:43:28AM +, Patchwork wrote: > == Series Details == > > Series: i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi > URL : https://patchwork.freedesktop.org/series/102553/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11484 ->

Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Would it be better to have this function name as drm_output_bpc_show() Thanks and Regards, Arun R Murthy

Re: [Intel-gfx] [PATCH v5 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2022-04-11 Thread kernel test robot
Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on v5.18-rc2 next-20220411] [cannot apply to drm/drm-next drm-intel/for-linux-next robh/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note

[Intel-gfx] ✓ Fi.CI.IGT: success for Add DP MST DSC support to i915 (rev4)

2022-04-11 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev4) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_11484_full -> Patchwork_101492v4_full Summary ---

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915/guc: use the memcpy_from_wc call from the drm

2022-04-11 Thread Ceraolo Spurio, Daniele
On 3/21/2022 2:14 PM, Lucas De Marchi wrote: On Thu, Mar 03, 2022 at 11:30:10PM +0530, Balasubramani Vivekanandan wrote: memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. v2:

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

2022-04-11 Thread Patchwork
== Series Details == Series: i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi URL : https://patchwork.freedesktop.org/series/102553/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11484 -> Patchwork_102553v1 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Add support for render/media decompression (rev2)

2022-04-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add support for render/media decompression (rev2) URL : https://patchwork.freedesktop.org/series/102147/ State : success == Summary == CI Bug Log - changes from CI_DRM_11484_full -> Patchwork_102147v2_full

Re: [Intel-gfx] [PATCH 3/3] drm/i915/guc: Update to GuC version 70.1.1

2022-04-11 Thread Ceraolo Spurio, Daniele
On 4/8/2022 11:03 AM, john.c.harri...@intel.com wrote: From: John Harrison Update to the latest GuC firmware release. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio Daniele --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 32 1 file

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Update scheduling policies to new GuC API

2022-04-11 Thread Ceraolo Spurio, Daniele
On 4/8/2022 11:03 AM, john.c.harri...@intel.com wrote: From: John Harrison The latest GuC firmware drops the individual scheduling policy update H2G commands in favour of a single KLV based H2G. So, change the update wrappers accordingly. Unfortunately, the API changes also mean losing the

Re: [Intel-gfx] [PATCH v5 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2022-04-11 Thread kernel test robot
Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on v5.18-rc2 next-20220411] [cannot apply to drm/drm-next drm-intel/for-linux-next robh/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

2022-04-11 Thread Patchwork
== Series Details == Series: i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi URL : https://patchwork.freedesktop.org/series/102553/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Update context registration to new GuC API

2022-04-11 Thread Ceraolo Spurio, Daniele
On 4/8/2022 11:03 AM, john.c.harri...@intel.com wrote: From: John Harrison The latest GuC firmware drops the context descriptor pool in favour of passing all creation data in the create H2G. It also greatly simplifies the work queue and removes the process descriptor used for multi-LRC

Re: [Intel-gfx] [PATCH v4 RFC] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-04-11 Thread Matt Roper
On Fri, Apr 01, 2022 at 03:19:26PM -0700, Francisco Jerez wrote: > Daniel Vetter writes: > > > On Wed, Mar 30, 2022 at 02:53:11PM -0700, Matt Atwood wrote: ... > >> @@ -2718,6 +2719,9 @@ struct drm_i915_query_item { > >> * - DRM_I915_QUERY_PERF_CONFIG_LIST > >> * -

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen region

2022-04-11 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region URL : https://patchwork.freedesktop.org/series/102540/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11484 -> Patchwork_102540v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen region

2022-04-11 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region URL : https://patchwork.freedesktop.org/series/102540/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Add DP MST DSC support to i915 (rev4)

2022-04-11 Thread Patchwork
== Series Details == Series: Add DP MST DSC support to i915 (rev4) URL : https://patchwork.freedesktop.org/series/101492/ State : success == Summary == CI Bug Log - changes from CI_DRM_11484 -> Patchwork_101492v4 Summary ---

[Intel-gfx] [PATCH 1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc

2022-04-11 Thread Matt Roper
This structure has a great comment describing the fields, but it's not currently in kerneldoc form and does not show up in the generated documentation. Let's fix that and also clarify the description of what "subslice" refers to on gen12 platforms and beyond and that "slice" is no longer

[Intel-gfx] [PATCH 3/4] drm/i915/doc: Link query items to their uapi structs

2022-04-11 Thread Matt Roper
Document the possible options for drm_i915_query_item.query_id with links to the corresponding uapi structures. Signed-off-by: Matt Roper --- include/uapi/drm/i915_drm.h | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git

[Intel-gfx] [PATCH 2/4] drm/i915/doc: Convert perf UAPI comments to kerneldoc

2022-04-11 Thread Matt Roper
Convert the comments for drm_i915_query_perf_config and drm_i915_perf_oa_config to kerneldoc so that they will show up in the generated documentation. Also correct a couple places that referred to query_id when they actually meant to refer to query_item.flags. Signed-off-by: Matt Roper ---

[Intel-gfx] [PATCH 4/4] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-04-11 Thread Matt Roper
From: Matt Atwood Newer platforms have DSS that aren't necessarily available for both geometry and compute, two queries will need to exist. This introduces the first, when passing a valid engine class and engine instance in the flags returns a topology describing geometry. Based on past

[Intel-gfx] [PATCH 0/4] i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

2022-04-11 Thread Matt Roper
This is a continuation of Matt Atwood's new geometry topology query from here: https://patchwork.freedesktop.org/series/101219/#rev4 This does a bit of initial cleanup/clarification of the query interface documentation (including converting more of it to kerneldoc so it will actually show up

[Intel-gfx] ✗ Fi.CI.BAT: failure for drivers: Fix spelling mistake "writting" -> "writing"

2022-04-11 Thread Patchwork
== Series Details == Series: drivers: Fix spelling mistake "writting" -> "writing" URL : https://patchwork.freedesktop.org/series/102525/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11484 -> Patchwork_102525v1 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drivers: Fix spelling mistake "writting" -> "writing"

2022-04-11 Thread Patchwork
== Series Details == Series: drivers: Fix spelling mistake "writting" -> "writing" URL : https://patchwork.freedesktop.org/series/102525/ State : warning == Summary == Error: dim checkpatch failed 6dc04b2a73d1 drivers: Fix spelling mistake "writting" -> "writing" -:4: WARNING:TYPO_SPELLING:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Add support for render/media decompression (rev2)

2022-04-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add support for render/media decompression (rev2) URL : https://patchwork.freedesktop.org/series/102147/ State : success == Summary == CI Bug Log - changes from CI_DRM_11484 -> Patchwork_102147v2

Re: [Intel-gfx] [PATCH 09/20] drm/i915/gsc: add slow_fw flag to the gsc device definition

2022-04-11 Thread Ceraolo Spurio, Daniele
On 4/7/2022 5:58 AM, Alexander Usyskin wrote: Add slow_fw flag to the gsc device definition and pass it to mei auxiliary device. Signed-off-by: Alexander Usyskin Reviewed-by: Daniele Ceraolo Spurio Daniele --- drivers/gpu/drm/i915/gt/intel_gsc.c | 2 ++ 1 file changed, 2

Re: [Intel-gfx] [PATCH 08/20] drm/i915/gsc: add slow_fw flag to the mei auxiliary device

2022-04-11 Thread Ceraolo Spurio, Daniele
On 4/7/2022 5:58 AM, Alexander Usyskin wrote: Add slow_fw flag to the mei auxiliary device info to inform the mei driver about slow underlying firmware. Such firmware will require to use larger operation timeouts. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Might be

Re: [Intel-gfx] [PATCH 07/20] drm/i915/gsc: skip irq initialization if using polling

2022-04-11 Thread Ceraolo Spurio, Daniele
On 4/7/2022 5:58 AM, Alexander Usyskin wrote: From: Vitaly Lubart If we use polling instead of interrupts, irq initialization should be skipped. This needs at least a 1 line explanation if why we might need to use polling. Something like "some platforms require the host to poll on the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Add support for render/media decompression (rev2)

2022-04-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Add support for render/media decompression (rev2) URL : https://patchwork.freedesktop.org/series/102147/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: low level EDID block read refactoring etc. (rev5)

2022-04-11 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev5) URL : https://patchwork.freedesktop.org/series/102329/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11482_full -> Patchwork_102329v5_full

[Intel-gfx] [PATCH v5 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2022-04-11 Thread Sean Paul
From: Sean Paul This patch adds HDCP 1.x support to msm DP connectors using the new HDCP helpers. Cc: Stephen Boyd Cc: Abhinav Kumar Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-s...@poorly.run #v1 Link:

[Intel-gfx] [PATCH v5 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2022-04-11 Thread Sean Paul
From: Sean Paul This patch adds the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Now that these are supported, change the compatible string to "dp-hdcp". Signed-off-by: Sean Paul Link:

[Intel-gfx] [PATCH v5 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2022-04-11 Thread Sean Paul
From: Sean Paul This patch adds the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. We'll use a new compatible string for this since the fields

[Intel-gfx] [PATCH v5 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2022-04-11 Thread Sean Paul
From: Sean Paul Now that all of the HDCP 1.x logic has been migrated to the central HDCP helpers, use it in the i915 driver. The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, however there are a few helper hooks which are connector-specific and need to be partially or

[Intel-gfx] [PATCH v5 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2022-04-11 Thread Sean Paul
From: Sean Paul The shim functions return error codes, but they are discarded in intel_hdcp.c. This patch plumbs the return codes through so they are properly handled. Acked-by: Jani Nikula Signed-off-by: Sean Paul Link:

[Intel-gfx] [PATCH v5 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2022-04-11 Thread Sean Paul
From: Sean Paul Stick all of the setup for HDCP into a dedicated function. No functional change, but this will facilitate moving HDCP logic into helpers. Acked-by: Jani Nikula Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-6-s...@poorly.run

[Intel-gfx] [PATCH v5 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2022-04-11 Thread Sean Paul
From: Sean Paul This patch expands upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new platform supported HDCP we could

[Intel-gfx] [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-11 Thread Sean Paul
From: Sean Paul This patch updates the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new content type. 2- Userspace sets value

[Intel-gfx] [PATCH v5 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2022-04-11 Thread Sean Paul
From: Sean Paul Instead of forcing a modeset in the hdcp atomic check, simply return true if the content protection value is changing and let the driver decide whether a modeset is required or not. Acked-by: Jani Nikula Signed-off-by: Sean Paul Link:

[Intel-gfx] [PATCH v5 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2022-04-11 Thread Sean Paul
From: Sean Paul This patch moves the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Acked-by: Jani Nikula Reviewed-by: Abhinav Kumar Signed-off-by: Sean Paul Link:

[Intel-gfx] [PATCH v5 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2022-04-11 Thread Sean Paul
From: Sean Paul Rebased set from November. Fixed a nit from Stephen in the msm patch and moved hdcp registers into the trogdor dtsi file to avoid differences with sc7180-based windows devices. The set is 4 patches lighter since some of the changes were accepted into msm. I'm still waiting for

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3)

2022-04-11 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3) URL : https://patchwork.freedesktop.org/series/102428/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11482_full -> Patchwork_102428v3_full

Re: [Intel-gfx] [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-11 Thread Thomas Zimmermann
Am 11.04.22 um 10:56 schrieb Matthew Auld: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent changes in this area this now just results in NULL deref

[Intel-gfx] [PATCH 5/5] drm/i915: stolen memory use ttm backend

2022-04-11 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 -

[Intel-gfx] [PATCH 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-11 Thread Robert Beckett
stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 + 1 file changed, 27 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH 3/5] drm/i915: ttm move/clear logic fix

2022-04-11 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that

[Intel-gfx] [PATCH 2/5] drm/i915: sanitize mem_flags for stolen buffers

2022-04-11 Thread Robert Beckett
stolen regions are not page backed or considered iomem. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c

[Intel-gfx] [PATCH 0/5] drm/i915: ttm for stolen region

2022-04-11 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. Robert Beckett (5): drm/i915: instantiate ttm ranger manager for stolen memory drm/i915: sanitize mem_flags for stolen buffers drm/i915: ttm move/clear logic fix drm/i915: ttm backend dont provide mmap_offset for kernel buffers

[Intel-gfx] [PATCH 1/5] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-11 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++- 2 files changed, 27

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Do not explode on phy calibration error

2022-04-11 Thread Vudum, Lakshminarayana
ICL issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/4767 igt@kms_fbcon_fbt@fbc(-suspend)? - fail - Failed assertion: feature->wait_until_update(drm) Thanks, Lakshmi. -Original Message- From: De Marchi, Lucas Sent: Monday, April 11, 2022 11:17 AM To: Roper,

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Do not explode on phy calibration error

2022-04-11 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Do not explode on phy calibration error URL : https://patchwork.freedesktop.org/series/102458/ State : success == Summary == CI Bug Log - changes from CI_DRM_11480_full -> Patchwork_22834_full

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Do not explode on phy calibration error

2022-04-11 Thread Lucas De Marchi
On Mon, Apr 11, 2022 at 08:34:35AM -0700, Matt Roper wrote: On Sat, Apr 09, 2022 at 11:15:36PM -0700, Lucas De Marchi wrote: When the PHY fails on calibration we were previously skipping the ddi initialization. However the driver is not really prepared for that, ultimately leading to a NULL

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: low level EDID block read refactoring etc. (rev5)

2022-04-11 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev5) URL : https://patchwork.freedesktop.org/series/102329/ State : success == Summary == CI Bug Log - changes from CI_DRM_11482 -> Patchwork_102329v5

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3)

2022-04-11 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3) URL : https://patchwork.freedesktop.org/series/102428/ State : success == Summary == CI Bug Log - changes from CI_DRM_11482 -> Patchwork_102428v3

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3)

2022-04-11 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3) URL : https://patchwork.freedesktop.org/series/102428/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3)

2022-04-11 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/dp: Factor out a function to probe a DPCD address (rev3) URL : https://patchwork.freedesktop.org/series/102428/ State : warning == Summary == Error: dim checkpatch failed 7a09c6bb44f9 drm/dp: Factor out a function to probe a DPCD

Re: [Intel-gfx] [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-11 Thread Christoph Hellwig
On Mon, Apr 11, 2022 at 07:11:03PM +0300, Jani Nikula wrote: > > Up to you but I usually sort these lists > > Yeah, please do. Otherwise matches what I sent, so ack. Let's just merge your 2 patch series ASAP and I'll rebase on top of that. What branch in drm-intel should I use as the base for

[Intel-gfx] [PATCH 2/2] drm/i915: Add DSC support to MST path

2022-04-11 Thread Stanislav Lisovskiy
Whenever we are not able to get enough timeslots for required PBN, let's try to allocate those using DSC, just same way as we do for SST. v2: Removed intel_dp_mst_dsc_compute_config and refactored intel_dp_dsc_compute_config to support timeslots as a parameter(Ville Syrjälä)

[Intel-gfx] [PATCH 1/2] drm: Add missing DP DSC extended capability definitions.

2022-04-11 Thread Stanislav Lisovskiy
Adding DP DSC register definitions, we might need for further DSC implementation, supporting MST and DP branch pass-through mode. v2: - Fixed checkpatch comment warning v3: - Removed function which is not yet used(Jani Nikula) Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH 0/2] Add DP MST DSC support to i915

2022-04-11 Thread Stanislav Lisovskiy
Currently we have only DSC support for DP SST. Stanislav Lisovskiy (2): drm: Add missing DP DSC extended capability definitions. drm/i915: Add DSC support to MST path drivers/gpu/drm/i915/display/intel_dp.c | 75 +- drivers/gpu/drm/i915/display/intel_dp.h | 17 +++

Re: [Intel-gfx] [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-11 Thread Jani Nikula
On Mon, 11 Apr 2022, Jason Gunthorpe wrote: > On Mon, Apr 11, 2022 at 04:13:34PM +0200, Christoph Hellwig wrote: >> Match the style of the main i915 Makefile in the gvt-specfic one and >> remove the GVT_DIR and GVT_SOURCE variables. >> >> Signed-off-by: Christoph Hellwig >>

Re: [Intel-gfx] [PATCH 04/34] drm/i915/gvt: don't override the include path

2022-04-11 Thread Jani Nikula
On Mon, 11 Apr 2022, Christoph Hellwig wrote: > drivers/gpu/drm/i915/gvt/Makefile is included > from drivers/gpu/drm/i915/Makefile and thus inherits the normal include > path relative to drivers/gpu/drm/i915/. Fix up the gvt-specific trace > header and just do away with the include path

[Intel-gfx] [PATCH 14/16] drm/i915: drop bo->moving dependency

2022-04-11 Thread Christian König
That should now be handled by the common dma_resv framework. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gem/i915_gem_object.c| 41 --- drivers/gpu/drm/i915/gem/i915_gem_object.h| 8 +---

[Intel-gfx] [PATCH 13/15] drm/ttm: remove bo->moving

2022-04-11 Thread Christian König
This is now handled by the DMA-buf framework in the dma_resv obj. Also remove the workaround inside VMWGFX to update the moving fence. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 13 ---

[Intel-gfx] [PATCH 15/15] seqlock: drop seqcount_ww_mutex_t

2022-04-11 Thread Christian König
Daniel pointed out that this series removes the last user of seqcount_ww_mutex_t, so let's drop this. Signed-off-by: Christian König Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: linux-ker...@vger.kernel.org --- include/linux/seqlock.h | 8 ++--

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Christian König
Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to the min_page_size. when size is not aligned to min_page_size, driver module should handle in their own way either to round_up() the size value

[Intel-gfx] [PATCH 01/15] dma-buf: add enum dma_resv_usage v4

2022-04-11 Thread Christian König
This change adds the dma_resv_usage enum and allows us to specify why a dma_resv object is queried for its containing fences. Additional to that a dma_resv_usage_rw() helper function is added to aid retrieving the fences for a read or write userspace submission. This is then deployed to the

[Intel-gfx] [PATCH 09/15] dma-buf: add DMA_RESV_USAGE_BOOKKEEP v3

2022-04-11 Thread Christian König
Add an usage for submissions independent of implicit sync but still interesting for memory management. v2: cleanup the kerneldoc a bit v3: separate amdgpu changes from this Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 4 ++--

[Intel-gfx] [PATCH 12/15] drm/i915: drop bo->moving dependency

2022-04-11 Thread Christian König
That should now be handled by the common dma_resv framework. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gem/i915_gem_object.c| 41 --- drivers/gpu/drm/i915/gem/i915_gem_object.h| 8 +---

Re: [Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

2022-04-11 Thread Christian König
Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam: On 11/04/22 7:02 pm, Matthew Auld wrote: On 11/04/2022 13:42, Christian König wrote: Am 11.04.22 um 11:47 schrieb Matthew Auld: On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote: Add a simple check to reject any size not aligned to

[Intel-gfx] [PATCH 10/15] drm/amdgpu: use DMA_RESV_USAGE_BOOKKEEP

2022-04-11 Thread Christian König
Use DMA_RESV_USAGE_BOOKKEEP for VM page table updates and KFD preemption fence. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH] drivers: Fix spelling mistake "writting" -> "writing"

2022-04-11 Thread cgel . zte
From: Lv Ruyi There are some spelling mistakes in the comments. Fix it. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/net/ethernet/sfc/mcdi_pcol.h

Re: [Intel-gfx] [PATCH 12/15] drm/i915: drop bo->moving dependency

2022-04-11 Thread Christian König
Am 08.04.22 um 11:33 schrieb Daniel Vetter: On Fri, 8 Apr 2022 at 11:27, Christian König wrote: Am 08.04.22 um 11:05 schrieb Jani Nikula: On Thu, 07 Apr 2022, "Christian König" wrote: That should now be handled by the common dma_resv framework. Signed-off-by: Christian König Reviewed-by:

[Intel-gfx] [PATCH 03/15] dma-buf & drm/amdgpu: remove dma_resv workaround

2022-04-11 Thread Christian König
Rework the internals of the dma_resv object to allow adding more than one write fence and remember for each fence what purpose it had. This allows removing the workaround from amdgpu which used a container for this instead. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Cc:

[Intel-gfx] [PATCH 08/15] RDMA: use DMA_RESV_USAGE_KERNEL

2022-04-11 Thread Christian König
We only need to wait for kernel submissions here. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/infiniband/core/umem_dmabuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/umem_dmabuf.c

[Intel-gfx] [PATCH 02/15] dma-buf: specify usage while adding fences to dma_resv obj v7

2022-04-11 Thread Christian König
Instead of distingting between shared and exclusive fences specify the fence usage while adding fences. Rework all drivers to use this interface instead and deprecate the old one. v2: some kerneldoc comments suggested by Daniel v3: fix a missing case in radeon v4: rebase on nouveau changes, fix

[Intel-gfx] [PATCH 11/15] dma-buf: wait for map to complete for static attachments

2022-04-11 Thread Christian König
We have previously done that in the individual drivers but it is more defensive to move that into the common code. Dynamic attachments should wait for map operations to complete by themselves. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-buf.c

[Intel-gfx] [PATCH 14/15] dma-buf: drop seq count based update

2022-04-11 Thread Christian König
This should be possible now since we don't have the distinction between exclusive and shared fences any more. The only possible pitfall is that a dma_fence would be reused during the RCU grace period, but even that could be handled with a single extra check. Signed-off-by: Christian König

[Intel-gfx] [PATCH 07/15] drm/nouveau: only wait for kernel fences in nouveau_bo_vm_cleanup

2022-04-11 Thread Christian König
Don't wait for user space submissions. I'm not 100% sure if that is correct, but it seems to match what the code initially intended. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 04/15] dma-buf: add DMA_RESV_USAGE_KERNEL v3

2022-04-11 Thread Christian König
Add an usage for kernel submissions. Waiting for those are mandatory for dynamic DMA-bufs. As a precaution this patch also changes all occurrences where fences are added as part of memory management in TTM, VMWGFX and i915 to use the new value because it now becomes possible for drivers to ignore

[Intel-gfx] [PATCH 05/15] drm/amdgpu: use DMA_RESV_USAGE_KERNEL

2022-04-11 Thread Christian König
Wait only for kernel fences before kmap or UVD direct submission. This also makes sure that we always wait in amdgpu_bo_kmap() even when returning a cached pointer. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 10 +-

[Intel-gfx] [PATCH 06/15] drm/radeon: use DMA_RESV_USAGE_KERNEL

2022-04-11 Thread Christian König
Always wait for kernel fences before kmap and not only for UVD kmaps. Signed-off-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_object.c | 7 ++- drivers/gpu/drm/radeon/radeon_uvd.c| 12 ++-- 2 files changed, 8 insertions(+), 11 deletions(-)

[Intel-gfx] DMA-resv usage

2022-04-11 Thread Christian König
Hi Daniel, only patch #2 had some significant changes. The rest ist pretty much the same except for the dropped exynos change and the added cleanup for the seqlock. Thanks, Christian.

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Do not explode on phy calibration error

2022-04-11 Thread Matt Roper
On Sat, Apr 09, 2022 at 11:15:36PM -0700, Lucas De Marchi wrote: > When the PHY fails on calibration we were previously skipping the ddi > initialization. However the driver is not really prepared for that, > ultimately leading to a NULL pointer dereference: > > [ 75.748348] i915 :03:00.0:

Re: [Intel-gfx] [PATCH 0/4] drm/i915/dg2: Add support for render/media decompression

2022-04-11 Thread Imre Deak
On Mon, Apr 11, 2022 at 04:38:16PM +0300, Jani Nikula wrote: > On Mon, 11 Apr 2022, Imre Deak wrote: > > Hi Rodrigo, Jani, > > TL;DR, all done, for details read on. ;) > > > On Mon, Apr 04, 2022 at 04:38:42PM +0300, Imre Deak wrote: > >> This is a rebased version of patches 15-17 of [1], adding

[Intel-gfx] [PATCH v2 4/4] drm/i915/dg2: Add support for DG2 clear color compression

2022-04-11 Thread Imre Deak
From: Juha-Pekka Heikkilä Add support for the DG2 specific render compression with clear color framebuffer format. DG2 onwards discrete gfx has support for new flat CCS mapping, which brings in display feature in to avoid Aux walk for compressed surface. This support build on top of Flat CCS

[Intel-gfx] [PATCH v2 3/4] drm/fourcc: Introduce format modifier for DG2 clear color

2022-04-11 Thread Imre Deak
From: Mika Kahola DG2 clear color render compression uses Tile4 layout. Therefore, we need to define a new format modifier for uAPI to support clear color rendering. v2: Display version is fixed. [Imre] KDoc is enhanced for cc modifier. [Nanley & Lionel] v3: Split out the modifier

[Intel-gfx] [PATCH v2 2/4] drm/i915/dg2: Add support for DG2 render and media compression

2022-04-11 Thread Imre Deak
From: Matt Roper Add support for DG2 render and media compression, for the description of buffer layouts see the previous patch adding the corresponding frame buffer modifiers. v2: Display version fix [Imre] v3: Split out modifier addition to separate patch. Signed-off-by: Matt Roper cc:

[Intel-gfx] [PATCH v2 1/4] drm/fourcc: Introduce format modifiers for DG2 render and media compression

2022-04-11 Thread Imre Deak
From: Matt Roper The render/media engines on DG2 unify render compression and media compression into a single format for the first time, using the Tile 4 layout for main surfaces. The compression algorithm is different from any previous platform and the display engine must still be configured to

[Intel-gfx] [PATCH v2 0/4] drm/i915/dg2: Add support for render/media decompression

2022-04-11 Thread Imre Deak
This is v2 of [1] amending the authorship and commit log in patch 4 and adding the r-bs, acks. Resending for CI as well for retesting on drm-tip where the dependency patchset [2] is now also part of the drm-intel-next branch. [1] https://patchwork.freedesktop.org/series/102147/ [2]

[Intel-gfx] [PATCH 34/34] vfio/mdev: Remove mdev drvdata

2022-04-11 Thread Christoph Hellwig
From: Jason Gunthorpe This is no longer used, remove it. All usages were moved over to either use container_of() from a vfio_device or to use dev_drvdata() directly on the mdev. Signed-off-by: Jason Gunthorpe Signed-off-by: Christoph Hellwig --- include/linux/mdev.h | 9 - 1 file

[Intel-gfx] [PATCH 33/34] vfio/mdev: Use the driver core to create the 'remove' file

2022-04-11 Thread Christoph Hellwig
From: Jason Gunthorpe The device creator is supposed to use the dev.groups value to add sysfs files before device_add is called, not call sysfs_create_files() after device_add() returns. This creates a race with uevent delivery where the extra attribute will not be visible. This was being done

[Intel-gfx] [PATCH 32/34] vfio/mdev: Remove mdev_parent_ops

2022-04-11 Thread Christoph Hellwig
From: Jason Gunthorpe The last useful member in this struct is the supported_type_groups, move it to the mdev_driver and delete mdev_parent_ops. Replace it with mdev_driver as an argument to mdev_register_device() Signed-off-by: Jason Gunthorpe Signed-off-by: Christoph Hellwig ---

  1   2   >