Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-13 Thread Dixit, Ashutosh
On Wed, 13 Apr 2022 18:00:29 -0700, Patchwork wrote: > > > Possible regressions > > * igt@gem_lmem_swapping@parallel-random-engines: > > * bat-dg1-5: NOTRUN -> FAIL > > * bat-dg1-6: NOTRUN -> FAIL These failures are unrelated. They are showing up everywhere and causing all recent pre-merge CI

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails (rev2)

2022-04-13 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails (rev2) URL : https://patchwork.freedesktop.org/series/102663/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Don't show client busyness in fdinfo with GuC submission

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Don't show client busyness in fdinfo with GuC submission URL : https://patchwork.freedesktop.org/series/102676/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102676v1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: low level EDID block read refactoring etc. (rev7)

2022-04-13 Thread Patchwork
== Series Details == Series: drm/edid: low level EDID block read refactoring etc. (rev7) URL : https://patchwork.freedesktop.org/series/102329/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102329v7

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Reserving some Multi-thread forcewake bits.

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Reserving some Multi-thread forcewake bits. URL : https://patchwork.freedesktop.org/series/102673/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102673v1 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: Load DMC on DG2 (rev3)

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on DG2 (rev3) URL : https://patchwork.freedesktop.org/series/102630/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102630v3 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Start reordering modeset clock calculations (rev4)

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Start reordering modeset clock calculations (rev4) URL : https://patchwork.freedesktop.org/series/101789/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_101789v4

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: Load DMC on DG2

2022-04-13 Thread Srivatsa, Anusha
From: Patchwork Sent: Wednesday, April 13, 2022 1:01 PM To: Srivatsa, Anusha Cc: intel-gfx@lists.freedesktop.org Subject: ✗ Fi.CI.BAT: failure for drm/i915/dmc: Load DMC on DG2 Patch Details Series: drm/i915/dmc: Load DMC on DG2 URL: https://patchwork.freedesktop.org/series/102630/ State:

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Tian, Kevin
> From: Wang, Zhi A > Sent: Thursday, April 14, 2022 5:09 AM > > > Or is it that only the page table levels themselves are GFNs and the > > actual DMA's are IOVA? The unclear mixing of GFN as IOVA in the code > > makes it inscrutible. > > > > No. Even the HW is capable of controlling the level

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Start reordering modeset clock calculations (rev4)

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Start reordering modeset clock calculations (rev4) URL : https://patchwork.freedesktop.org/series/101789/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Start reordering modeset clock calculations (rev4)

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Start reordering modeset clock calculations (rev4) URL : https://patchwork.freedesktop.org/series/101789/ State : warning == Summary == Error: dim checkpatch failed 380dc39b162a drm/i915: Make .get_dplls() return int 83841bcb2f20 drm/i915: Pass dev_priv

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, April 14, 2022 7:12 AM > > On Wed, Apr 13, 2022 at 09:08:40PM +, Wang, Zhi A wrote: > > On 4/13/22 8:04 PM, Jason Gunthorpe wrote: > > > On Wed, Apr 13, 2022 at 07:17:52PM +, Wang, Zhi A wrote: > > >> On 4/13/22 5:37 PM, Jason Gunthorpe wrote: >

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable compute and related WAs for DG2

2022-04-13 Thread Patchwork
== Series Details == Series: Enable compute and related WAs for DG2 URL : https://patchwork.freedesktop.org/series/102667/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102667v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable compute and related WAs for DG2

2022-04-13 Thread Patchwork
== Series Details == Series: Enable compute and related WAs for DG2 URL : https://patchwork.freedesktop.org/series/102667/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable compute and related WAs for DG2

2022-04-13 Thread Patchwork
== Series Details == Series: Enable compute and related WAs for DG2 URL : https://patchwork.freedesktop.org/series/102667/ State : warning == Summary == Error: dim checkpatch failed e449143c2530 drm/i915/guc: Update context registration to new GuC API -:419: WARNING:IF_0: Consider removing

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Eliminate PIPECONF RMWs from .color_commit()

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() URL : https://patchwork.freedesktop.org/series/102666/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102666v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Eliminate PIPECONF RMWs from .color_commit()

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Eliminate PIPECONF RMWs from .color_commit() URL : https://patchwork.freedesktop.org/series/102666/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes URL : https://patchwork.freedesktop.org/series/102665/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102665v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim checkpatch failed 92ac366cc868 drm/i915: Introduce has_media_ratio_mode 4b1b7f68f558 drm/i915/gt: Add media

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-13 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails URL : https://patchwork.freedesktop.org/series/102663/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 ->

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc

2022-04-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc URL : https://patchwork.freedesktop.org/series/102657/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102657v1

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm-misc-fixes tree

2022-04-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/radeon/radeon_sync.c between commit: 022074918042 ("drm/radeon: fix logic inversion in radeon_sync_resv") from the drm-misc-fixes tree and commit: 7bc80a5462c3 ("dma-buf: add enum dma_resv_usage

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/adl-n: Differentiate ADLP and ADLN steppings

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Differentiate ADLP and ADLN steppings URL : https://patchwork.freedesktop.org/series/102652/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102652v1 Summary

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Wang, Zhi A
Hi folks: Thanks so much for the efforts. I prepared a branch which contains all our patches.The aim of the branch is for the VFIO maintainers to pull the whole bunch easily after the drm-intel-next got merged through drm (as one of the MMIO patches depends on a patch in drm-intel-next). I

[Intel-gfx] ✗ Fi.CI.IGT: failure for fbcon: Fix delayed takeover locking

2022-04-13 Thread Patchwork
== Series Details == Series: fbcon: Fix delayed takeover locking URL : https://patchwork.freedesktop.org/series/102641/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11496_full -> Patchwork_102641v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/adl-n: Differentiate ADLP and ADLN steppings

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915/adl-n: Differentiate ADLP and ADLN steppings URL : https://patchwork.freedesktop.org/series/102652/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915: Don't show client busyness in fdinfo with GuC submission

2022-04-13 Thread Ashutosh Dixit
Client busyness is not available when GuC submission is used. Don't show it in fdinfo till this is supported by GuC. Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/5564 Fixes: 055634e4b62f ("drm/i915: Expose client engine utilisation via fdinfo") Cc: Umesh Nerlige Ramappa Cc: John

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove intel_gvt_init_host declaration

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Remove intel_gvt_init_host declaration URL : https://patchwork.freedesktop.org/series/102646/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102646v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Check EDID for HDR static metadata when choosing blc

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Check EDID for HDR static metadata when choosing blc URL : https://patchwork.freedesktop.org/series/102645/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102645v1

[Intel-gfx] ✗ Fi.CI.IGT: failure for Expose max and current bpc via debugfs (rev2)

2022-04-13 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs (rev2) URL : https://patchwork.freedesktop.org/series/102502/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11496_full -> Patchwork_102502v2_full Summary

Re: [Intel-gfx] [PATCH 1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc

2022-04-13 Thread Francisco Jerez
Looks good to me, series is: Reviewed-by: Francisco Jerez Matt Roper writes: > This structure has a great comment describing the fields, but it's not > currently in kerneldoc form and does not show up in the generated > documentation. Let's fix that and also clarify the description of what >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Check EDID for HDR static metadata when choosing blc

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: Check EDID for HDR static metadata when choosing blc URL : https://patchwork.freedesktop.org/series/102645/ State : warning == Summary == Error: dim checkpatch failed 0cc97e8784e7 drm/i915: Check EDID for HDR static metadata when choosing blc -:71:

[Intel-gfx] [PATCH] drm/i915: Reserving some Multi-thread forcewake bits.

2022-04-13 Thread Rodrigo Vivi
Bit 0: Currently bit used by i915. Ideally only i915 touches it in a Linux stack. Bits 1 and 2: A while ago we were using Bit 1 for i915 and bit 2 for the user space, until commit 7130630323c5 ("drm/i915: Use fallback forcewake if primary ack missing") changed

[Intel-gfx] ✓ Fi.CI.IGT: success for Update to GuC v70

2022-04-13 Thread Patchwork
== Series Details == Series: Update to GuC v70 URL : https://patchwork.freedesktop.org/series/102626/ State : success == Summary == CI Bug Log - changes from CI_DRM_11496_full -> Patchwork_102626v1_full Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.BAT: success for fbcon: Fix delayed takeover locking

2022-04-13 Thread Patchwork
== Series Details == Series: fbcon: Fix delayed takeover locking URL : https://patchwork.freedesktop.org/series/102641/ State : success == Summary == CI Bug Log - changes from CI_DRM_11496 -> Patchwork_102641v1 Summary ---

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Wang, Zhi A
On 4/13/22 8:04 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 07:17:52PM +, Wang, Zhi A wrote: >> On 4/13/22 5:37 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Check EDID before dpcd for possible HDR aux bl support

2022-04-13 Thread Lyude Paul
On Wed, 2022-04-13 at 08:31 +, Hogander, Jouni wrote: > Hello Lyude, > > See my respose below. > > On Tue, 2022-04-12 at 13:50 -0400, Lyude Paul wrote: > > On Tue, 2022-04-12 at 08:25 +0300, Jouni Högander wrote: > > > We have now seen panel (XMG Core 15 e21 laptop) avertizing support > > >

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

2022-04-13 Thread Rodrigo Vivi
On Tue, Apr 12, 2022 at 05:57:07PM -0700, Anusha Srivatsa wrote: > Add Support for DC states on Dg2. > > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- > drivers/gpu/drm/i915/display/intel_dmc.c | 10 +- > 2 files changed, 10

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Use i915_probe_error instead of drm_err URL : https://patchwork.freedesktop.org/series/102625/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11496_full -> Patchwork_102625v1_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fbcon: Fix delayed takeover locking

2022-04-13 Thread Patchwork
== Series Details == Series: fbcon: Fix delayed takeover locking URL : https://patchwork.freedesktop.org/series/102641/ State : warning == Summary == Error: dim checkpatch failed 8854f9cee658 fbcon: Fix delayed takeover locking -:7: ERROR:GIT_COMMIT_ID: Please use git commit description style

[Intel-gfx] ✓ Fi.CI.BAT: success for Expose max and current bpc via debugfs (rev2)

2022-04-13 Thread Patchwork
== Series Details == Series: Expose max and current bpc via debugfs (rev2) URL : https://patchwork.freedesktop.org/series/102502/ State : success == Summary == CI Bug Log - changes from CI_DRM_11496 -> Patchwork_102502v2 Summary ---

Re: [Intel-gfx] [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Nathan Chancellor
On Wed, Apr 13, 2022 at 11:25:02AM +0200, Daniel Vetter wrote: > On Wed, Apr 13, 2022 at 10:21:28AM +0200, Daniel Vetter wrote: > > I messed up the delayed takover path in the locking conversion in > > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > > > > Fix it by

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: Load DMC on DG2

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on DG2 URL : https://patchwork.freedesktop.org/series/102630/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11496 -> Patchwork_102630v1 Summary --- **FAILURE**

[Intel-gfx] [PATCH 09/10] drm/i915/dg2: Enable Wa_14014475959 - RCS / CCS context exit

2022-04-13 Thread Umesh Nerlige Ramappa
From: Matthew Brost There is bug in DG2 where if the CCS contexts switches out while the RCS is running it can cause memory corruption. To workaround this add an atomic to a memory address with a value 1 and semaphore wait to the same address for a value of 0. The GuC firmware is responsible for

[Intel-gfx] [PATCH 10/10] drm/i915/dg2: Enable Wa_22012727170/Wa_22012727685

2022-04-13 Thread Umesh Nerlige Ramappa
From: John Harrison The above two workaronuds regarding context isolation are implemented by GuC. The KMD just needs to enable them. v2: Use dg2 stepping for ctx isolation WA (Umesh) v3: Rebase (Umesh) v4: Fix WA comments (Daniele) v5: Drop Wa_22012727685 for G10 as it is n/a v6: Undo v5 change

[Intel-gfx] [PATCH 08/10] drm/i915/guc: Apply Wa_16011777198

2022-04-13 Thread Umesh Nerlige Ramappa
From: Vinay Belgaumkar Enable GuC Wa to reset RCS/CCS before it goes into RC6. v2: Comments from Matt R. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 + drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 1 + 2 files changed, 6 insertions(+) diff --git

[Intel-gfx] [PATCH 05/10] drm/i915: Xe_HP SDV and DG2 have 4 CCS engines

2022-04-13 Thread Umesh Nerlige Ramappa
From: Daniele Ceraolo Spurio Cc: Vinay Belgaumkar Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_pci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c

[Intel-gfx] [PATCH 07/10] drm/i915/guc: Enable GuC based workarounds for DG2

2022-04-13 Thread Umesh Nerlige Ramappa
From: John Harrison There are some workarounds for DG2 that are implemented in the GuC firmware. However, the KMD is required to enable these by setting the appropriate flag as GuC does not know what platform it is running on. Wa_16011759253 Wa_14012630569 Wa_14013746162 v2: Add a couple

[Intel-gfx] [PATCH 04/10] drm/i915/xehp: Add compute engine ABI

2022-04-13 Thread Umesh Nerlige Ramappa
From: Matt Roper We're now ready to start exposing compute engines to userspace. While we're at it, let's extend the kerneldoc description for the other engine types as well. Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Cc: Vinay Belgaumkar Cc: Jordan Justen Cc: Szymon Morek UMD (mesa):

[Intel-gfx] [PATCH 01/10] drm/i915/guc: Update context registration to new GuC API

2022-04-13 Thread Umesh Nerlige Ramappa
From: John Harrison The latest GuC firmware drops the context descriptor pool in favour of passing all creation data in the create H2G. It also greatly simplifies the work queue and removes the process descriptor used for multi-LRC submission. So, remove all mention of LRC and process

[Intel-gfx] [PATCH 06/10] drm/i915: Add Wa_22011802037 force cs halt

2022-04-13 Thread Umesh Nerlige Ramappa
From: Tilak Tangudu Prior to doing a reset, SW must ensure command streamer is stopped, as a workaround, to eliminate a race condition in GPM flow. Setting both the ring stop and prefetch disable bits, will cause the command streamer to halt. v2: 1. Removed duplicate code and added only

[Intel-gfx] [PATCH 03/10] drm/i915/guc: Update to GuC version 70.1.1

2022-04-13 Thread Umesh Nerlige Ramappa
From: John Harrison Update to the latest GuC firmware release. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

[Intel-gfx] [PATCH 02/10] drm/i915/guc: Update scheduling policies to new GuC API

2022-04-13 Thread Umesh Nerlige Ramappa
From: John Harrison The latest GuC firmware drops the individual scheduling policy update H2G commands in favour of a single KLV based H2G. So, change the update wrappers accordingly. Unfortunately, the API changes also mean losing the ability to set any scheduling policy values during context

[Intel-gfx] [PATCH 00/10] Enable compute and related WAs for DG2

2022-04-13 Thread Umesh Nerlige Ramappa
Enable compute, work arounds and relevant GuC FW for DG2. Signed-off-by: Matt Roper Signed-off-by: Umesh Nerlige Ramappa Signed-off-by: John Harrison Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Vinay Belgaumkar Signed-off-by: Tilak Tangudu Daniele Ceraolo Spurio (1): drm/i915:

[Intel-gfx] [PATCH] drm/i915: Eliminate PIPECONF RMWs from .color_commit()

2022-04-13 Thread Ville Syrjala
From: Ville Syrjälä Eliminate the PIPECONF RMWs from .comit_commit() so that we can finally declare the whole vblank evade part (and the noarm() part) of the pipe commit free of register reads. Or at least I hope that's the last read... Only the i9xx/ilk codepaths need this for now, but let's

[Intel-gfx] ✓ Fi.CI.BAT: success for Update to GuC v70

2022-04-13 Thread Patchwork
== Series Details == Series: Update to GuC v70 URL : https://patchwork.freedesktop.org/series/102626/ State : success == Summary == CI Bug Log - changes from CI_DRM_11496 -> Patchwork_102626v1 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-13 Thread Dixit, Ashutosh
On Wed, 13 Apr 2022 11:11:07 -0700, Ashutosh Dixit wrote: > > All kmalloc'd kobjects need a kobject_put() to free memory. For example in > previous code, kobj_gt_release() never gets called. Even if kobj_gt_release() were to get called, the code allocates 'struct kobj_gt' and frees 'struct

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Wang, Zhi A
On 4/13/22 5:37 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: >> On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: >>> Yeah, I was thinking about that too, but on the other hand I think it >>> is completely wrong that gvt requires

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Use i915_probe_error instead of drm_err URL : https://patchwork.freedesktop.org/series/102625/ State : success == Summary == CI Bug Log - changes from CI_DRM_11496 -> Patchwork_102625v1

Re: [Intel-gfx] [PATCH 14/20] drm/i915/dg2: add gsc with special gsc bar offsets

2022-04-13 Thread Ceraolo Spurio, Daniele
On 4/7/2022 5:58 AM, Alexander Usyskin wrote: From: Tomas Winkler DG2 uses different GSC offsets on memory bar and uses PXP head (HECI1). Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Reviewed-by: Daniele Ceraolo Spurio Daniele ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update to GuC v70

2022-04-13 Thread Patchwork
== Series Details == Series: Update to GuC v70 URL : https://patchwork.freedesktop.org/series/102626/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 1/8] drm/i915: Introduce has_media_ratio_mode

2022-04-13 Thread Ashutosh Dixit
Media ratio mode (the ability for media IP to work at a different frequency from the GT) is available for a subset of dGfx platforms supporting GuC/SLPC. Introduce 'has_media_ratio_mode' flag in intel_device_info to identify these platforms and set it for XEHPSDV and DG2/ATS-M. Cc: Rodrigo Vivi

[Intel-gfx] [PATCH 8/8] drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs

2022-04-13 Thread Ashutosh Dixit
Add the following sysfs file to gt/gtN/.defaults: * media_freq_factor Cc: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 18 ++ drivers/gpu/drm/i915/gt/intel_gt_types.h| 1 +

[Intel-gfx] [PATCH 5/8] drm/i915/gt: Add media RP0/RPn to per-gt sysfs

2022-04-13 Thread Ashutosh Dixit
Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs: * media_RP0_freq_mhz * media_RPn_freq_mhz Cc: Rodrigo Vivi Cc: Joonas Lahtinen Original-author: Dale B Stimson Signed-off-by: Dale B Stimson Signed-off-by:

[Intel-gfx] [PATCH 4/8] drm/i915/pcode: Add a couple of pcode helpers

2022-04-13 Thread Ashutosh Dixit
Add a couple of helpers to help formatting pcode commands and improve code readability. Cc: Mike Ruhl Cc: Rodrigo Vivi Original-author: Dale B Stimson Signed-off-by: Dale B Stimson Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_reg.h| 3 +++

[Intel-gfx] [PATCH 6/8] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-04-13 Thread Ashutosh Dixit
All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization. Cc: Andi Shyti Cc: Andrzej Hajda Cc: Rodrigo Vivi Fixes: b770bcfae9ad

[Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-13 Thread Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. Previous (GT0) pcode read/write interfaces are preserved. Cc: Rodrigo Vivi Cc: Mike Ruhl Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/intel_pcode.c | 108

[Intel-gfx] [PATCH 7/8] drm/i915/gt: Expose per-gt RPS defaults in sysfs

2022-04-13 Thread Ashutosh Dixit
Create a gt/gtN/.defaults directory (similar to engine//.defaults) to expose default parameter values for each gt in sysfs. Populate the .defaults directory with RPS parameter default values in order to allow userspace to revert to default values when needed. This patch adds the following sysfs

[Intel-gfx] [PATCH 2/8] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-13 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed

[Intel-gfx] [PATCH 0/8] drm/i915: Media freq factor and per-gt enhancements/fixes

2022-04-13 Thread Ashutosh Dixit
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new

Re: [Intel-gfx] commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes with spots in console screeens.

2022-04-13 Thread Jani Nikula
On Mon, 11 Apr 2022, François Valenduc wrote: > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots > to appears on the right upper corner of all console screens see the > attached photo). git-bisect shows that this is the

Re: [Intel-gfx] [PATCH] drm/i915: Remove intel_gvt_init_host declaration

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, Cong Liu wrote: > this function has been deleted since commit 9bdb073464d6 ("drm/i915/gvt: > Change KVMGT as self load module"), remove the deprecated function > declaration. I don't want to push this right now avoid conflicts in other pending work. Cc'd Zhi & Zhenyu to pick

Re: [Intel-gfx] commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, François Valenduc wrote: > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots > to appears on the right upper corner of all console screens (see >

[Intel-gfx] [PATCH v2 1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-13 Thread José Roberto de Souza
If any of the PSR2 checks after intel_psr2_sel_fetch_config_valid() fails, enable_psr2_sel_fetch will be kept enabled causing problems in the functions that only checks for it and not for has_psr2. So here moving the check that do not depend on enable_psr2_sel_fetch and for the remaning ones

[Intel-gfx] [PATCH v2 2/2] drm/i915/display/psr: Do not check for PSR2_MAN_TRK_CTL_ENABLE on alderlake-P

2022-04-13 Thread José Roberto de Souza
Alderlake-P don't have PSR2_MAN_TRK_CTL_ENABLE bit, instead it have ADLP_PSR2_MAN_TRK_CTL_SF_PARTIAL_FRAME_UPDATE in the same bit but this bit is clearead after each vblank so we can't count on having it set after planes are programmed. Cc: Jouni Högander Fixes: 73262db68c27 ("drm/i915/display:

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: > Yeah, I was thinking about that too, but on the other hand I think it > is completely wrong that gvt requires kvm at all. A vfio_device is not > supposed to be tightly linked to KVM - the only exception possibly > being s390.. So

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 06:58:47PM +0300, Jani Nikula wrote: > Acked-by: Jani Nikula I've only added this to the i915 patches for now, let me know if you also want me to add it to the vfio/mdev ones.

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 07:04:54PM +0300, Jani Nikula wrote: > > v6: > > - Remove the reference of intel_gvt_device_info.(Christoph) > > - Refine the save_mmio() function. (Christoph) > > > > which don't belong in the commit log. It might be worth to fix that > > before sending a pull request.

Re: [Intel-gfx] [PATCH 9/9] vfio: Remove calls to vfio_group_add_container_user()

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 11:03:05AM -0300, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 08:11:05AM +0200, Christoph Hellwig wrote: > > On Tue, Apr 12, 2022 at 12:53:36PM -0300, Jason Gunthorpe wrote: > > > + if (WARN_ON(!READ_ONCE(vdev->open_count))) > > > + return -EINVAL; > > > > I

Re: [Intel-gfx] [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 08:39:52AM -0300, Jason Gunthorpe wrote: > I already looked into that for a while, it is a real mess too because > of how the notifiers are used by the current drivers, eg gvt assumes > the notifier is called during its open_device callback to setup its > kvm. gvt very

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 03:25:37PM +0300, Jani Nikula wrote: >> This is [1] rebased on gvt-next. (Which means it won't build on CI.) > > Btw, now that I found that gvt-next branch: > > Zhi, your commits still have per-commit changelog like: > > v6:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/psr: Clear more PSR state during disable

2022-04-13 Thread Souza, Jose
On Wed, 2022-04-13 at 07:27 +, Hogander, Jouni wrote: > Hello Jose, > > See my comment below. > > On Tue, 2022-04-12 at 13:55 -0700, José Roberto de Souza wrote: > > After commit 805f04d42a6b ("drm/i915/display/psr: Use continuos full > > frame to handle frontbuffer invalidations") was

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 01:47:05PM +, Wang, Zhi A wrote: >> > the GVT code in the i915 is a bit of a mess right now due to strange >> > abstractions and lots of indirect calls. This series refactors various >> > bits to clean that up. The main

[Intel-gfx] [PULL] drm-intel-next

2022-04-13 Thread Jani Nikula
Hi Dave & Daniel - The first drm/i915 pull for v5.19. BR, Jani. drm-intel-next-2022-04-13-1: drm/i915 feature pull for v5.19: Features and functionality: - Add support for new Tile 4 format on DG2 (Stan) - Add support for new CCS clear color compression on DG2 (Mika, Juha-Pekka) - Add

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 01:47:05PM +, Wang, Zhi A wrote: > > the GVT code in the i915 is a bit of a mess right now due to strange > > abstractions and lots of indirect calls. This series refactors various > > bits to clean that up. The main user visible change is that almost all > > of the

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 03:25:37PM +0300, Jani Nikula wrote: > This is [1] rebased on gvt-next. (Which means it won't build on CI.) Btw, now that I found that gvt-next branch: Zhi, your commits still have per-commit changelog like: v6: - Remove the reference of

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: better align the Makefile with i915 Makefile

2022-04-13 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gvt: fix trace TRACE_INCLUDE_PATH

2022-04-13 Thread Christoph Hellwig
On Wed, Apr 13, 2022 at 03:25:38PM +0300, Jani Nikula wrote: > TRACE_INCLUDE_PATH should be a path relative to define_trace.h, not the > file including it. (See the comment in include/trace/define_trace.h.) Looks good: Reviewed-by: Christoph Hellwig

[Intel-gfx] [PATCH 2/2] drm/i915/fbc: s/false/0/

2022-04-13 Thread Ville Syrjala
From: Ville Syrjälä intel_fbc_check_plane() is supposed to an int, not a boolean. So replace the bogus 'return false's with the correct 'return 0's. These were accidental copy-paste mistakes when the code got moved into intel_fbc_check_plane() from somewhere else tht did return a boolean. No

[Intel-gfx] [PATCH 1/2] drm/i915/fbc: Consult hw.crtc instead of uapi.crtc

2022-04-13 Thread Ville Syrjala
From: Ville Syrjälä plane_state->uapi.crtc is not what we want to be looking at. If bigjoiner is used hw.crtc is what tells us what crtc the plane is supposedly using. Not an actual problem on current hardware as the only FBC capable pipe (A) can't be a bigjoiner slave and thus

[Intel-gfx] ✓ Fi.CI.IGT: success for Make the rest of the VFIO driver interface use vfio_device

2022-04-13 Thread Patchwork
== Series Details == Series: Make the rest of the VFIO driver interface use vfio_device URL : https://patchwork.freedesktop.org/series/102606/ State : success == Summary == CI Bug Log - changes from CI_DRM_11493_full -> Patchwork_102606v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails

2022-04-13 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/psr: Unset enable_psr2_sel_fetch if other checks in intel_psr2_config_valid() fails URL : https://patchwork.freedesktop.org/series/102615/ State : success == Summary == CI Bug Log - changes from CI_DRM_11494 ->

Re: [Intel-gfx] [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 1:43 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > >> It seems Jani's makefile clean patch has already included this one, I can >> just simply drop this one so that Christoph won't need to re-send everything. >> >> For the branch to move

Re: [Intel-gfx] [PATCH 0/7] drm/i915/fbc: FBC frontbuffer stuff

2022-04-13 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, March 15, 2022 4:00 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 0/7] drm/i915/fbc: FBC frontbuffer stuff > > From: Ville Syrjälä > > Avoid all the FBC frontbuffer vs. atomic

Re: [Intel-gfx] refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Wang, Zhi A
On 4/11/22 2:13 PM, Christoph Hellwig wrote: > Hi all, > > the GVT code in the i915 is a bit of a mess right now due to strange > abstractions and lots of indirect calls. This series refactors various > bits to clean that up. The main user visible change is that almost all > of the GVT code

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen region (rev3)

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region (rev3) URL : https://patchwork.freedesktop.org/series/102540/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11493 -> Patchwork_102540v3 Summary ---

Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 12:25 PM, Jani Nikula wrote: > This is [1] rebased on gvt-next. (Which means it won't build on CI.) > > BR, > Jani. > > > [1] https://patchwork.freedesktop.org/series/102003/ > > > Cc: Zhi Wang > Cc: Christoph Hellwig > > > Jani Nikula (2): > drm/i915/gvt: fix trace

Re: [Intel-gfx] [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 12:33 PM, Jani Nikula wrote: > On Mon, 11 Apr 2022, Christoph Hellwig wrote: >> On Mon, Apr 11, 2022 at 07:11:03PM +0300, Jani Nikula wrote: Up to you but I usually sort these lists >>> >>> Yeah, please do. Otherwise matches what I sent, so ack. >> >> Let's just merge your 2 patch

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen region (rev3)

2022-04-13 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen region (rev3) URL : https://patchwork.freedesktop.org/series/102540/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

  1   2   >