If any of the PSR2 checks after intel_psr2_sel_fetch_config_valid()
fails, enable_psr2_sel_fetch will be kept enabled causing problems
in the functions that only checks for it and not for has_psr2.
So here moving the check that do not depend on enable_psr2_sel_fetch
and for the remaning ones
Convert drm_find_cea_extension() to a predicate function to check if the
EDID has a CTA extension or a DisplayID CTA data block. This is mainly
to avoid adding new users that only find the first CTA extension.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 19
The DisplayID CTA data block version does not necessarily match the CTA
revision. Simplify by postponing drm_edid_to_eld() slightly, and reusing
the CTA revision extracted by drm_parse_cea_ext().
By not bailing out early in drm_edid_to_eld() we may end up filling
meaningless data to the ELD.
Convert drm_find_cea_extension() to EDID block iterator in color format
and CTA revision detection. Detect them in all CTA extensions.
Also parse CTA Data Blocks in DisplayID even if there's no CTA EDID
extension.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c |
Convert drm_find_cea_extension() to EDID block iterator in basic audio
detection. Detect basic audio in all CEA extensions.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git
During the transition, we accepted a void pointer for a poor C
programmer's version of polymorphism. Switch the functions to use struct
cea_db * to regain some more type safety.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 21 +
1 file
Iterate through all CTA data blocks across all CTA Extensions and
DisplayID data blocks.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c
All CTA data block iteration has now been converted to the new cea db
iterators.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 45 --
1 file changed, 45 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c
Use the cea db iterator for short audio descriptors. We'll still stop at
the first audio data block, but not at the first CTA Extension if that
doesn't have the info.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 34 +-
1 file
Iterate through all CTA data blocks across all CTA extensions and
DisplayID data blocks. This may gather more data than before, and if
there's duplicated data, some is overwritten by whichever comes last.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 64
On 4/13/2022 11:41 PM, Anshuman Gupta wrote:
On 2022-04-13 at 04:18:52 +0530, Vinay Belgaumkar wrote:
This will ensure we don't have false positives when we run
error injection tests.
Signed-off-by: Vinay Belgaumkar
---
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 42
Iterate through all CEA data blocks.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index
Iterate through all CTA data blocks, not just the first CTA extension.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c
Iterate through all CTA EDID extension blocks and DisplayID CTA data
blocks to add CEA modes.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 67 ++
1 file changed, 31 insertions(+), 36 deletions(-)
diff --git
Use the cea db iterator for speaker allocation. We'll still stop at the
first speaker data block, but not at the first CTA extension if that
doesn't have the info.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 47 --
1 file
Add an iterator abstraction for going through all the EDID blocks.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 48 ++
1 file changed, 48 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
Abstract helpers for matching vendor data blocks and extended tags, and
use them to simplify all the cea_db_is_*() functions.
Take void pointer as parameter to allow transitional use for both u8 *
and struct cea_db *.
v2: Remove superfluous parens (Ville)
Cc: Ville Syrjälä
Signed-off-by: Jani
Add an iterator for CTA Data Blocks across EDID CTA Extensions and
DisplayID CTA Data Blocks.
v2: Update references, note why we can trust displayid ranges (Ville)
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 202 ++---
1 file
Add prefixed names, group, sort, add references.
v2:
- Updated references to CTA-861-H
- s/CEA/CTA/ in data block macros
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
---
drivers/gpu/drm/drm_edid.c | 65 --
1 file changed, 35
Get back to the CEA data block iterator stuff now that a bunch of prep
work has landed.
My git repo at [1], branch edid-hfeeodb-2022-04-14, contains where this
is all headed after this.
[1] https://cgit.freedesktop.org/~jani/drm/log/?h=edid-hfeeodb-2022-04-14
Jani Nikula (18):
drm/edid: reset
From: Lee Shawn C
Find HF-SCDB information in CEA extensions block. And retrieve
Max_TMDS_Character_Rate that support by sink device.
v2: HF-SCDB and HF-VSDBS carry the same SCDS data. Reuse
drm_parse_hdmi_forum_vsdb() to parse this packet.
Cc: Jani Nikula
Cc: Ville Syrjala
Cc: Ankit
If a NULL edid gets passed to drm_add_edid_modes(), we should probably
also reset the display info.
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index
== Series Details ==
Series: drm/i915/rpl-p: Add PCI IDs
URL : https://patchwork.freedesktop.org/series/102701/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/rpl-p: Add PCI IDs
URL : https://patchwork.freedesktop.org/series/102701/
State : warning
== Summary ==
Error: dim checkpatch failed
c6b5a4897d53 drm/i915/rpl-p: Add PCI IDs
-:107: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in
Hi,
On 4/12/22 21:38, Robert Beckett wrote:
+struct ttm_resource *
+i915_gem_stolen_reserve_range(struct drm_i915_private *i915,
+ resource_size_t size,
+ u64 start, u64 end)
{
- int ret;
+ struct intel_memory_region *mem =
On Thu, Apr 14, 2022 at 05:22:47PM +0300, Jani Nikula wrote:
> On Thu, 14 Apr 2022, Greg Kroah-Hartman wrote:
> > On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote:
> >> Hey, I've sent this before, ages ago, but haven't really followed
> >> through with it. I still think it would be
On Thu, 2022-04-14 at 11:13 +, Hogander, Jouni wrote:
> On Wed, 2022-04-13 at 09:43 -0700, José Roberto de Souza wrote:
> > Alderlake-P don't have PSR2_MAN_TRK_CTL_ENABLE bit, instead it have
> > ADLP_PSR2_MAN_TRK_CTL_SF_PARTIAL_FRAME_UPDATE in the same bit but
> > this
> > bit is clearead
On 4/14/22 1:43 PM, Jason Gunthorpe wrote:
> On Thu, Apr 14, 2022 at 04:40:11PM +0300, Jani Nikula wrote:
>
>> git clone https://github.com/intel/gvt-linux -b for-christoph
>
> There are alot of extra commits on there - is it possible to base this
> straight on rc1 not on some
== Series Details ==
Series: drm/edid: low level EDID block read refactoring etc. (rev8)
URL : https://patchwork.freedesktop.org/series/102329/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11499_full -> Patchwork_102329v8_full
On Thu, 14 Apr 2022, Greg Kroah-Hartman wrote:
> On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote:
>> Hey, I've sent this before, ages ago, but haven't really followed
>> through with it. I still think it would be useful for many scenarios
>> where a plain number is a clumsy interface
== Series Details ==
Series: add support for enum module parameters
URL : https://patchwork.freedesktop.org/series/102695/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11499 -> Patchwork_102695v1
Summary
---
From: Matt Atwood
Adding initial PCI ids for RPL-P.
RPL-P behaves identically to ADL-P from i915's point of view.
Bspec: 55376
Signed-off-by: Matt Atwood
Signed-off-by: Madhumitha Tolakanahalli Pradeep
Signed-off-by: Tejas Upadhyay
---
arch/x86/kernel/early-quirks.c | 1 +
On Mon, 11 Apr 2022, Jani Nikula wrote:
> v3 of [1] fixing the (!x == 0) mistake. Resending the entire thing with
> hopes the test robot picks up the baseline better; I haven't had much
> luck with --in-reply-to for that.
There were some issues with our CI, but I'm pretty sure they were not
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote:
> stolen/kernel buffers should not be mmapable by userland.
> do not provide callbacks to facilitate this for these buffers.
>
> Signed-off-by: Robert Beckett
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 +--
>
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote:
> ttm managed buffers start off with system resource definitions and
> ttm_tt
> tracking structures allocated (though unpopulated).
> currently this prevents clearing of buffers on first move to desired
> placements.
>
> The desired
On Tue, 2022-04-12 at 15:18 +, Robert Beckett wrote:
> stolen regions are not page backed or considered iomem.
thus...
A little more elaborate commit message please.
>
> Signed-off-by: Robert Beckett
Reviewed-by: Thomas Hellström
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
== Series Details ==
Series: add support for enum module parameters
URL : https://patchwork.freedesktop.org/series/102695/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: add support for enum module parameters
URL : https://patchwork.freedesktop.org/series/102695/
State : warning
== Summary ==
Error: dim checkpatch failed
8c6849f919aa module: add enum module parameter type to map names to values
-:73: ERROR:OPEN_BRACE: open brace
On Thu, Apr 14, 2022 at 03:30:32PM +0300, Jani Nikula wrote:
> Hey, I've sent this before, ages ago, but haven't really followed
> through with it. I still think it would be useful for many scenarios
> where a plain number is a clumsy interface for a module param.
>
> Thoughts?
We should not be
Hello,
Can anyone review please? Pre-merge failure is not related to the patch.
Thanks,
Tejas
> -Original Message-
> From: Surendrakumar Upadhyay, TejaskumarX
>
> Sent: 13 April 2022 16:28
> To: intel-gfx@lists.freedesktop.org
> Cc: Surendrakumar Upadhyay, TejaskumarX
>
> Subject:
== Series Details ==
Series: drm/edid: low level EDID block read refactoring etc. (rev9)
URL : https://patchwork.freedesktop.org/series/102329/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11499 -> Patchwork_102329v9
On Thu, 14 Apr 2022, Jason Gunthorpe wrote:
> On Thu, Apr 14, 2022 at 01:39:11PM +, Wang, Zhi A wrote:
>> This one belongs to i915, which has already been queued in drm-intel-next,
>> but
>> not yet reached to the top. When it is landed in -rc, I will rebase this
>> branch
>> on it, then we
On Thu, 14 Apr 2022, Jason Gunthorpe wrote:
> On Thu, Apr 14, 2022 at 12:20:42PM +, Wang, Zhi A wrote:
>> On 4/13/22 11:20 PM, Jason Gunthorpe wrote:
>> > On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote:
>> >> Hi folks:
>> >>
>> >> Thanks so much for the efforts. I prepared a
On 4/14/22 1:34 PM, Jason Gunthorpe wrote:
> On Thu, Apr 14, 2022 at 12:20:42PM +, Wang, Zhi A wrote:
>> On 4/13/22 11:20 PM, Jason Gunthorpe wrote:
>>> On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote:
Hi folks:
Thanks so much for the efforts. I prepared a branch
From: Cooper Chiou
commit 5662abf6e21338be6d085d6375d3732ac6147fd2 upstream.
Tag code stored in bit7:5 for CTA block byte[3] is not the same as
CEA extension block definition. Only check CEA block has
basic audio support.
v3: update commit message.
Cc: sta...@vger.kernel.org
Cc: Jani Nikula
On Wed, 13 Apr 2022, Ashutosh Dixit wrote:
> Each gt contains an independent instance of pcode. Extend pcode functions
> to interface with pcode on different gt's. Previous (GT0) pcode read/write
> interfaces are preserved.
The big problem here is that this hard couples display code to gt code,
On 4/12/22 21:38, Robert Beckett wrote:
prepare for ttm based stolen region by using ttm range manager
as the resource manager for stolen region.
Signed-off-by: Robert Beckett
LGTM.
Reviewed-by: Thomas Hellström
---
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++--
From: Cooper Chiou
commit 5662abf6e21338be6d085d6375d3732ac6147fd2 upstream.
Tag code stored in bit7:5 for CTA block byte[3] is not the same as
CEA extension block definition. Only check CEA block has
basic audio support.
v3: update commit message.
Cc: sta...@vger.kernel.org
Cc: Jani Nikula
On Thu, 2022-04-14 at 11:08 +, Hogander, Jouni wrote:
> On Wed, 2022-04-13 at 15:59 +, Souza, Jose wrote:
> > On Wed, 2022-04-13 at 07:27 +, Hogander, Jouni wrote:
> > > Hello Jose,
> > >
> > > See my comment below.
> > >
> > > On Tue, 2022-04-12 at 13:55 -0700, José Roberto de Souza
Add enum module parameter type that's internally an int and externally
maps names to values. This makes the userspace interface more intuitive
to use and somewhat easier to document, while also limiting the allowed
values set by userspace to the defined set.
For example, given this code to define
Hey, I've sent this before, ages ago, but haven't really followed
through with it. I still think it would be useful for many scenarios
where a plain number is a clumsy interface for a module param.
Thoughts?
BR,
Jani.
Cc: Andrew Morton
Cc: Greg Kroah-Hartman
Cc: Lucas De Marchi
Jani Nikula
On 4/13/22 11:20 PM, Jason Gunthorpe wrote:
> On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote:
>> Hi folks:
>>
>> Thanks so much for the efforts. I prepared a branch which contains all our
>> patches.The aim of the branch is for the VFIO maintainers to pull the whole
>> bunch easily
On 04.04.2022 15:01, Mullati Siva wrote:
> From: Siva Mullati
>
> Convert CT commands and descriptors to use iosys_map rather
> than plain pointer and save it in the intel_guc_ct_buffer struct.
> This will help with ct_write and ct_read for cmd send and receive
> after the initialization by
On Wed, 2022-04-13 at 17:08 -0400, Lyude Paul wrote:
> On Wed, 2022-04-13 at 08:31 +, Hogander, Jouni wrote:
> > Hello Lyude,
> >
> > See my respose below.
> >
> > On Tue, 2022-04-12 at 13:50 -0400, Lyude Paul wrote:
> > > On Tue, 2022-04-12 at 08:25 +0300, Jouni Högander wrote:
> > > > We
On Wed, 2022-04-13 at 09:43 -0700, José Roberto de Souza wrote:
> Alderlake-P don't have PSR2_MAN_TRK_CTL_ENABLE bit, instead it have
> ADLP_PSR2_MAN_TRK_CTL_SF_PARTIAL_FRAME_UPDATE in the same bit but
> this
> bit is clearead after each vblank so we can't count on having it
> set after planes are
== Series Details ==
Series: drm/edid: low level EDID block read refactoring etc. (rev8)
URL : https://patchwork.freedesktop.org/series/102329/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11499 -> Patchwork_102329v8
On Wed, 2022-04-13 at 15:59 +, Souza, Jose wrote:
> On Wed, 2022-04-13 at 07:27 +, Hogander, Jouni wrote:
> > Hello Jose,
> >
> > See my comment below.
> >
> > On Tue, 2022-04-12 at 13:55 -0700, José Roberto de Souza wrote:
> > > After commit 805f04d42a6b ("drm/i915/display/psr: Use
On Sat, 09 Apr 2022, Imre Deak wrote:
> Some ADLP DP link configuration at least with multiple LTTPRs expects
> the first DPCD access during the LTTPR/DPCD detection after hotplug to
> be a read from the LTTPR range starting with
> DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV. The side
On Mon, 11 Apr 2022, Imre Deak wrote:
> Factor out from drm_dp_dpcd_read() a function to probe a DPCD address
> with a 1-byte read access. This will be needed by the next patch doing a
> read from an LTTPR address, which must happen without the preceding
> wake-up read in drm_dp_dpcd_read().
>
>
> -Original Message-
> From: Intel-gfx On Behalf Of Jani
> Nikula
> Sent: torstai 14. huhtikuuta 2022 11.32
> To: François Valenduc ; Lisovskiy, Stanislav
>
> Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org
> Subject: Re: [Intel-gfx] commit
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes
URL : https://patchwork.freedesktop.org/series/102665/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11497_full -> Patchwork_102665v1_full
On Thu, 14 Apr 2022, François Valenduc wrote:
> Le 14/04/22 à 10:03, Lisovskiy, Stanislav a écrit :
>> On Thu, Apr 14, 2022 at 08:33:35AM +0200, François Valenduc wrote:
>>> Le 14/04/22 à 08:31, Lisovskiy, Stanislav a écrit :
On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote:
>
On Thu, Apr 14, 2022 at 08:33:35AM +0200, François Valenduc wrote:
> Le 14/04/22 à 08:31, Lisovskiy, Stanislav a écrit :
> > On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote:
> > > On Wed, 13 Apr 2022, François Valenduc wrote:
> > > > Commit 15512021eb3975a8c2366e3883337e252bb0eee5
> >
== Series Details ==
Series: drm/edid: low level EDID block read refactoring etc. (rev7)
URL : https://patchwork.freedesktop.org/series/102329/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11497_full -> Patchwork_102329v7_full
Hi Daniel, Dave,
Here's this week drm-misc-next PR
Maxime
drm-misc-next-2022-04-14:
drm-misc-next for $kernel-version:
UAPI Changes:
Cross-subsystem Changes:
- fbcon: various loading and locking cleanups
Core Changes:
- buddy: Check for page size alignment at allocation
- dma-buf: Add
Issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/5701
Re-reported.
Lakshmi.
-Original Message-
From: Dixit, Ashutosh
Sent: Wednesday, April 13, 2022 10:57 PM
To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana
Subject: Re: ✗ Fi.CI.BAT: failure for
== Series Details ==
Series: drm/i915/display: Communicate display configuration to pcode
URL : https://patchwork.freedesktop.org/series/102678/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11498 -> Patchwork_102678v1
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes
URL : https://patchwork.freedesktop.org/series/102665/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11497 -> Patchwork_102665v1
On 2022-04-13 at 04:18:52 +0530, Vinay Belgaumkar wrote:
> This will ensure we don't have false positives when we run
> error injection tests.
>
> Signed-off-by: Vinay Belgaumkar
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 42 ++---
> 1 file changed, 21 insertions(+),
== Series Details ==
Series: drm/i915/display: Communicate display configuration to pcode
URL : https://patchwork.freedesktop.org/series/102678/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/display: Communicate display configuration to pcode
URL : https://patchwork.freedesktop.org/series/102678/
State : warning
== Summary ==
Error: dim checkpatch failed
a4a6dfddbdd5 drm/i915/display: Communicate display configuration to pcode
-:66:
On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote:
> On Wed, 13 Apr 2022, François Valenduc wrote:
> > Commit 15512021eb3975a8c2366e3883337e252bb0eee5
> > (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots
> > to appears on the right upper corner of all console
Display to communicate "display configuration" to Pcode for more accurate
power accounting for DG2. Existing sequence is only sending the voltage
value to the Pcode. Adding new sequence with current cdclk associate
with voltage value masking. Adding pcode request when any power well
will disable
Display to communicate "display configuration" to Pcode for more accurate
power accounting for DG2. Existing sequence is sending only voltage.
New sequence is sending cdclk along with number pipe of active pipes
to Pcode.
Jigar Bhatt (1):
drm/i915/display: Communicate display configuration to
101 - 174 of 174 matches
Mail list logo
