[Intel-gfx] [PATCH v2 5/9] drm/i915/bios: Assume panel_type==0 if the VBT has bogus data

2022-05-04 Thread Ville Syrjala
From: Ville Syrjälä Just assume panel_type==0 always if the VBT gives us bogus data. We actually already do this everywhere else except in parse_panel_options() since we just leave i915->vbt.panel_type zeroed. This also seems to be what Windows does. Reviewed-by: Jani Nikula Signed-off-by:

[Intel-gfx] [PATCH v2 4/9] drm/i915/bios: Document the mess around the LFP data tables

2022-05-04 Thread Ville Syrjala
From: Ville Syrjälä Document the fact that struct lvds_lfp_data_entry can't be used directly and instead must be accessed via the data table pointers. Also remove the bogus comment implying that there might be a variable number of panel entries in the table. There are always exactly 16.

[Intel-gfx] [PATCH v2 3/9] drm/i915/bios: Get access to the tail end of the LFP data block

2022-05-04 Thread Ville Syrjala
From: Ville Syrjälä We need to start parsing stuff from the tail end of the LFP data block. This is made awkward by the fact that the fp_timing table has variable size. So we must use a bit more finesse to get the tail end, and to make sure we allocate enough memory for it to make sure our

[Intel-gfx] [PATCH v2 2/9] drm/i915/bios: Generate LFP data table pointers if the VBT lacks them

2022-05-04 Thread Ville Syrjala
From: Ville Syrjälä Modern VBTs no longer contain the LFP data table pointers block (41). We are expecting to have one in order to be able to parse the LFP data block (42), so let's make one up. Since the fp_timing table has variable size we must somehow determine its size. Rather than just

[Intel-gfx] [PATCH v2 1/9] drm/i915/bios: Reorder panel DTD parsing

2022-05-04 Thread Ville Syrjala
From: Ville Syrjälä Reorder things so that we can parse the entier LFP data block in one go. For now we just stick to parsing the DTD from it. Also fix the misleading comment about block 42 being deprecated. Only the DTD part is deprecated, the rest is still very much needed. v2: Move the

[Intel-gfx] [PATCH v2 0/9] drm/i915/bios: Rework BDB block handling

2022-05-04 Thread Ville Syrjala
From: Ville Syrjälä Here are the easy parts of the previous BDB series, without the PNPID->panel_type bits (the PPS stuff still needs some more thinking). Everything here has been reviewed so should be good to go in if CI is happy. Ville Syrjälä (9): drm/i915/bios: Reorder panel DTD parsing

Re: [Intel-gfx] [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-05-04 Thread Matt Roper
On Wed, May 04, 2022 at 02:24:07PM +0200, Daniel Vetter wrote: > On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe > wrote: > > I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by > > both Iris and Vulkan , and stood for the guarantee that, when creating a > > new context, all

Re: [Intel-gfx] [PATCH 1/1] drm/i915/dmc: Load DMC on DG2

2022-05-04 Thread Imre Deak
On Tue, May 03, 2022 at 04:57:29PM -0700, Anusha Srivatsa wrote: > Add Support for DC states on Dg2. > > v2: Add dc9 as the max supported DC states and disable DC5. > > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa > Reviewed-by: Rodrigo Vivi (v1) > --- >

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Clear SET_PREDICATE_RESULT prior to executing the ring

2022-05-04 Thread Tvrtko Ursulin
On 25/04/2022 16:23, Ramalingam C wrote: From: Chris Wilson Userspace may leave predication enabled upon return from the batch buffer, which has the consequent of preventing all operation from the ring from being executed, including all the synchronisation, coherency control, arbitration and

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config URL : https://patchwork.freedesktop.org/series/103536/ State : success == Summary == CI Bug Log - changes from CI_DRM_11602 -> Patchwork_103536v1

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix race in __i915_vma_remove_closed (rev4)

2022-05-04 Thread Patchwork
== Series Details == Series: drm/i915: Fix race in __i915_vma_remove_closed (rev4) URL : https://patchwork.freedesktop.org/series/102845/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11597_full -> Patchwork_102845v4_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: use IOMEM_ERR_PTR() directly

2022-05-04 Thread Patchwork
== Series Details == Series: drm/i915: use IOMEM_ERR_PTR() directly URL : https://patchwork.freedesktop.org/series/103485/ State : success == Summary == CI Bug Log - changes from CI_DRM_11597_full -> Patchwork_103485v1_full Summary ---

[Intel-gfx] [PATCH v2 10/26] drm/i915: Extract intel_crtc_dotclock()

2022-05-04 Thread Ville Syrjala
From: Ville Syrjälä Extract intel_crtc_dotclock() from ddi_dotclock_get(). We'll reuse this during state computation in order to determine the actual final dotclcok after the DPLL computation has been done (which may not give us the exact same port_clock that we fed in). v2: Add the prototype

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/fbdev: print error in case drm_fb_helper_initial_config fails

2022-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/fbdev: print error in case drm_fb_helper_initial_config fails URL : https://patchwork.freedesktop.org/series/103533/ State : success == Summary == CI Bug Log - changes from CI_DRM_11601 -> Patchwork_103533v1

Re: [Intel-gfx] [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-05-04 Thread Daniel Vetter
On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe wrote: > I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by > both Iris and Vulkan , and stood for the guarantee that, when creating a > new context, all state set by it will not leak to any other context. > > However the actual

Re: [Intel-gfx] [PATCH] drm/i915: use IOMEM_ERR_PTR() directly

2022-05-04 Thread Tvrtko Ursulin
On 02/05/2022 09:30, Jani Nikula wrote: On Mon, 02 May 2022, Kefeng Wang wrote: Use IOMEM_ERR_PTR() instead of self defined IO_ERR_PTR(). Signed-off-by: Kefeng Wang Reviewed-by: Jani Nikula Pushed to drm-intel-gt-next, thanks for the patch and review! Regards, Tvrtko ---

[Intel-gfx] [PATCH 2/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for ring unexpectedly not idle

2022-05-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be sure CI will have all the possible SKUs and parts, or that it will catch all possible error conditions. Use

[Intel-gfx] [PATCH 1/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for unexpected l3bank/mslice config

2022-05-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed to exercise a certain code path, so in case of values coming from MMIO reads we cannot be sure CI will have all the possible SKUs and parts. Use drm_warn instead and move logging to init phase while

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/fbdev: print error in case drm_fb_helper_initial_config fails

2022-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/fbdev: print error in case drm_fb_helper_initial_config fails URL : https://patchwork.freedesktop.org/series/103533/ State : warning == Summary == Error: dim checkpatch failed 049b4153799b drm/i915/fbdev: print error in case

Re: [Intel-gfx] [PATCH] drm/i915: Change semantics of context isolation reporting to UM

2022-05-04 Thread Adrian Larumbe
Hi, Tvrtko On 03.05.2022 15:44, Tvrtko Ursulin wrote: > > Hi, > > On 29/04/2022 16:11, Adrian Larumbe wrote: > > I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by > > both Iris and Vulkan , and stood for the guarantee that, when creating a > > new context, all state set by

[Intel-gfx] [PATCH 1/2] drm/i915/fbdev: print error in case drm_fb_helper_initial_config fails

2022-05-04 Thread Andrzej Hajda
On some configurations drm_fb_helper_initial_config sometimes fails. Logging error value should help debugging such issues. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_fbdev.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 2/2] [DO NOT MERGE] tty/vt: add some logging to vt error path

2022-05-04 Thread Andrzej Hajda
Intel CI contains machine which permanently fails with fb initialization with crashes. Add extra logs to debug the issue. Signed-off-by: Andrzej Hajda --- drivers/tty/vt/vt.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/tty/vt/vt.c

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: add helper for reading SPI

2022-05-04 Thread Patchwork
== Series Details == Series: drm/i915/bios: add helper for reading SPI URL : https://patchwork.freedesktop.org/series/103480/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11595_full -> Patchwork_103480v1_full Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/edid: CEA data block iterators, and more (rev3)

2022-05-04 Thread Patchwork
== Series Details == Series: drm/edid: CEA data block iterators, and more (rev3) URL : https://patchwork.freedesktop.org/series/102703/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11595_full -> Patchwork_102703v3_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: warn about missing ->get_buf_trans initialization

2022-05-04 Thread Patchwork
== Series Details == Series: drm/i915: warn about missing ->get_buf_trans initialization URL : https://patchwork.freedesktop.org/series/103473/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11595_full -> Patchwork_103473v1_full

Re: [Intel-gfx] [PATCH 0/3] i915 private writeback framework

2022-05-04 Thread Daniel Vetter
On Wed, May 04, 2022 at 09:52:34AM +, Kandpal, Suraj wrote: > Hi Daniel, > > > > A patch series was floated in the drm mailing list which aimed to > > > change the drm_connector and drm_encoder fields to pointer in the > > > drm_connector_writeback structure, this received a huge pushback

Re: [Intel-gfx] [PATCH 0/3] i915 private writeback framework

2022-05-04 Thread Kandpal, Suraj
Hi Daniel, > > A patch series was floated in the drm mailing list which aimed to > > change the drm_connector and drm_encoder fields to pointer in the > > drm_connector_writeback structure, this received a huge pushback from > > the community but since i915 expects each connector present in the >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Enable THP on Icelake and beyond (rev2)

2022-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Enable THP on Icelake and beyond (rev2) URL : https://patchwork.freedesktop.org/series/103330/ State : success == Summary == CI Bug Log - changes from CI_DRM_11594_full -> Patchwork_103330v2_full

Re: [Intel-gfx] [PATCH 0/3] i915 private writeback framework

2022-05-04 Thread Daniel Vetter
On Mon, May 02, 2022 at 11:12:16AM +0530, Suraj Kandpal wrote: > A patch series was floated in the drm mailing list which aimed to change > the drm_connector and drm_encoder fields to pointer in the > drm_connector_writeback structure, this received a huge pushback from > the community but since

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Enable THP on Icelake and beyond (rev2)

2022-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Enable THP on Icelake and beyond (rev2) URL : https://patchwork.freedesktop.org/series/103330/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11594_full -> Patchwork_103330v2_full

Re: [Intel-gfx] [PATCH 1/2] module: add a function to add module references

2022-05-04 Thread Daniel Vetter
On Fri, Apr 29, 2022 at 12:36:01PM +0200, Greg KH wrote: > On Fri, Apr 29, 2022 at 11:23:51AM +0100, Mauro Carvalho Chehab wrote: > > Em Fri, 29 Apr 2022 12:10:07 +0200 > > Greg KH escreveu: > > > > > On Fri, Apr 29, 2022 at 10:15:03AM +0100, Mauro Carvalho Chehab wrote: > > > > HI Greg, > > > >

Re: [Intel-gfx] [PATCH] drm/i915: warn about missing ->get_buf_trans initialization

2022-05-04 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Tuesday, May 3, 2022 1:52 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCH] drm/i915: warn about missing ->get_buf_trans > initialization > > Make sure each DDI platform

Re: [Intel-gfx] [PATCH] drm/i915/reset: Add Wa_22011802037 for gen11 and execlist backend

2022-05-04 Thread Tvrtko Ursulin
On 03/05/2022 20:49, Umesh Nerlige Ramappa wrote: On Tue, May 03, 2022 at 09:42:52AM +0100, Tvrtko Ursulin wrote: On 02/05/2022 23:18, Umesh Nerlige Ramappa wrote: Current implementation of Wa_22011802037 is limited to the GuC backend and gen12. Add support for execlist backend and gen11 as

Re: [Intel-gfx] [PATCH v2 00/20] drm/edid: CEA data block iterators, and more

2022-05-04 Thread Jani Nikula
On Tue, 03 May 2022, Jani Nikula wrote: > I've kind of lost track of the version numbers on some of the iterator > patches, but this is the next version (or mostly a resend) of > [1]. There's an additional rename patch for SCDS. Argh, forgot to send this series to dri-devel. Instead of sending

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Implement Wa_14015648006

2022-05-04 Thread Patchwork
== Series Details == Series: drm/i915/display: Implement Wa_14015648006 URL : https://patchwork.freedesktop.org/series/103518/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11599 -> Patchwork_103518v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Implement Wa_14015648006

2022-05-04 Thread Patchwork
== Series Details == Series: drm/i915/display: Implement Wa_14015648006 URL : https://patchwork.freedesktop.org/series/103518/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/guc: Support programming the EU priority in the GuC descriptor

2022-05-04 Thread Tvrtko Ursulin
On 04/05/2022 02:06, Ceraolo Spurio, Daniele wrote: On 5/3/2022 5:44 PM, Daniele Ceraolo Spurio wrote: From: Matthew Brost The EU priority register must be updated by the GuC rather than the driver as it is context specific and only the GuC knows which context is currently executing. Cc:

[Intel-gfx] [PATCH] drm/i915/display: Implement Wa_14015648006

2022-05-04 Thread Mika Kahola
Add 4th pipe to extend TGL Wa_16013835468 to support DG2 platform. BSpec: 54077 Cc: Jouni Högander Cc: José Roberto de Souza Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_psr.c | 7 +-- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 6 insertions(+),

Re: [Intel-gfx] Xorg SEGV in Xen PV dom0 after updating from 5.16.18 to 5.17.5

2022-05-04 Thread Thorsten Leemhuis
On 04.05.22 08:48, Juergen Gross wrote: > On 04.05.22 07:46, Thorsten Leemhuis wrote: >> Hi, this is your Linux kernel regression tracker. Sending this just to >> CC the developers of the culprit mentioned below (bdd8b6c98239cad >> ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()")) and the

<    1   2