[Intel-gfx] [PATCH] drm/i915: fix typos in comments

2022-05-23 Thread Julia Lawall
Spelling mistakes (triple letters) in comments. Detected with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/gpu/drm/i915/display/intel_color.c |2 +- drivers/gpu/drm/i915/display/intel_pps.c |2 +- drivers/gpu/drm/i915/gt/intel_execlists_submissio

Re: [Intel-gfx] [PATCH v3] drm/i915: Enable Tile4 tiling mode

2022-05-23 Thread Zbigniew Kempczyński
On Fri, May 13, 2022 at 10:47:54AM +0200, Nirmoy Das wrote: > From: Bommu Krishnaiah > > Enable Tile4 tiling mode on platform that supports > Tile4 but no TileY like DG2. > > v3: add a function to find X-tile availability for a platform. > v2: disable X-tile for iGPU in fastblit > fix checkp

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: SSEU handling updates (rev2)

2022-05-23 Thread Patchwork
== Series Details == Series: i915: SSEU handling updates (rev2) URL : https://patchwork.freedesktop.org/series/104244/ State : success == Summary == CI Bug Log - changes from CI_DRM_11693 -> Patchwork_104244v2 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Add HWMON power sensor support

2022-05-23 Thread Dixit, Ashutosh
On Mon, 23 May 2022 04:08:39 -0700, Badal Nilawar wrote: > A few initial comments. > +static void > +i915_hwmon_get_preregistration_info(struct drm_i915_private *i915) > +{ > + struct i915_hwmon *hwmon = i915->hwmon; > + struct intel_uncore *uncore = &i915->uncore; > + struct i915_hwm

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: SSEU handling updates (rev2)

2022-05-23 Thread Patchwork
== Series Details == Series: i915: SSEU handling updates (rev2) URL : https://patchwork.freedesktop.org/series/104244/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11693 -> Patchwork_104244v2 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Add HWMON support

2022-05-23 Thread Dixit, Ashutosh
On Mon, 23 May 2022 04:08:38 -0700, Badal Nilawar wrote: > > This series adds the HWMON support for DG1, DG2 > > Dale B Stimson (2): > drm/i915/hwmon: Add HWMON power sensor support > drm/i915/hwmon: Add HWMON energy support I would suggest a slight reorganization of the series. I think the fi

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for i915: SSEU handling updates (rev2)

2022-05-23 Thread Matt Roper
On Mon, May 23, 2022 at 09:23:33PM +, Patchwork wrote: > == Series Details == > > Series: i915: SSEU handling updates (rev2) > URL : https://patchwork.freedesktop.org/series/104244/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11693 -> Patchwork_104244v2 > =

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: SSEU handling updates (rev2)

2022-05-23 Thread Patchwork
== Series Details == Series: i915: SSEU handling updates (rev2) URL : https://patchwork.freedesktop.org/series/104244/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11693 -> Patchwork_104244v2 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915/hwconfig: Report no hwconfig support on ADL-N

2022-05-23 Thread Matt Roper
On Mon, May 23, 2022 at 01:21:16PM +0530, Balasubramani Vivekanandan wrote: > ADL-N being a subplatform of ADL-P, it lacks support for hwconfig > table. Explicit check added to skip ADL-N. > > Signed-off-by: Balasubramani Vivekanandan > Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/gt

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: SSEU handling updates (rev2)

2022-05-23 Thread Patchwork
== Series Details == Series: i915: SSEU handling updates (rev2) URL : https://patchwork.freedesktop.org/series/104244/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: SSEU handling updates (rev2)

2022-05-23 Thread Patchwork
== Series Details == Series: i915: SSEU handling updates (rev2) URL : https://patchwork.freedesktop.org/series/104244/ State : warning == Summary == Error: dim checkpatch failed 65fb3ea005ad drm/i915/xehp: Use separate sseu init function 0299a3bc6a24 drm/i915/xehp: Drop GETPARAM lookups of I91

[Intel-gfx] [PATCH v5 5/6] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

2022-05-23 Thread Matt Roper
As with EU masks, it's easier to store subslice/DSS masks internally in a format that's more natural for the driver to work with, and then only covert into the u8[] uapi form when the query ioctl is invoked. Since the hardware design changed significantly with Xe_HP, we'll use a union to choose be

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hwconfig: Report no hwconfig support on ADL-N

2022-05-23 Thread Patchwork
== Series Details == Series: drm/i915/hwconfig: Report no hwconfig support on ADL-N URL : https://patchwork.freedesktop.org/series/104270/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11690_full -> Patchwork_104270v1_full

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-05-23 Thread Niranjana Vishwanathapura
On Thu, May 19, 2022 at 04:07:30PM -0700, Zanoni, Paulo R wrote: On Tue, 2022-05-17 at 11:32 -0700, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Ensure proper kernel-doc formatting with cross references. Also add new uapi and documentation as per review comments

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-05-23 Thread Niranjana Vishwanathapura
On Mon, May 23, 2022 at 12:05:05PM -0700, Niranjana Vishwanathapura wrote: On Thu, May 19, 2022 at 03:52:01PM -0700, Zanoni, Paulo R wrote: On Tue, 2022-05-17 at 11:32 -0700, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. v2: Add more documenta

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-05-23 Thread Niranjana Vishwanathapura
On Thu, May 19, 2022 at 03:52:01PM -0700, Zanoni, Paulo R wrote: On Tue, 2022-05-17 at 11:32 -0700, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. v2: Add more documentation and format as per review comments from Daniel. Signed-off-by: Nira

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev7)

2022-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev7) URL : https://patchwork.freedesktop.org/series/102665/ State : warning == Summary == Error: dim checkpatch failed 9e468bd7db66 drm/i915/gt: Add media freq factor to per-gt sysfs 10b8fc18842f drm/i915/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add HWMON support

2022-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support URL : https://patchwork.freedesktop.org/series/104278/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11691 -> Patchwork_104278v1 Summary --- **FAILURE** Ser

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add HWMON support

2022-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support URL : https://patchwork.freedesktop.org/series/104278/ State : warning == Summary == Error: dim checkpatch failed 461a66ade2f0 drm/i915/hwmon: Add HWMON power sensor support Traceback (most recent call last): File "scripts/spdxcheck.py

Re: [Intel-gfx] [PATCH v3 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM

2022-05-23 Thread Alex Williamson
Hi Zhi & Zhenyu, Please review gvt changes below, I'd prefer to get your ack included. Thanks! Alex On Thu, 19 May 2022 14:33:11 -0400 Matthew Rosato wrote: > Rather than relying on a notifier for associating the KVM with > the group, let's assume that the association has already been > made

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hwconfig: Report no hwconfig support on ADL-N

2022-05-23 Thread Patchwork
== Series Details == Series: drm/i915/hwconfig: Report no hwconfig support on ADL-N URL : https://patchwork.freedesktop.org/series/104270/ State : success == Summary == CI Bug Log - changes from CI_DRM_11690 -> Patchwork_104270v1 Summary --

[Intel-gfx] [PATCH 4/4] drm/i915/gt: Fix memory leaks in per-gt sysfs

2022-05-23 Thread Ashutosh Dixit
All kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization. v2: s/gtn/gt/ (Andi) Fixes: b770bcfae9ad ("drm/i915/gt: create per-tile sysfs inte

[Intel-gfx] [PATCH 3/4] drm/i915/gt: Add media RP0/RPn to per-gt sysfs

2022-05-23 Thread Ashutosh Dixit
From: Dale B Stimson Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs: * media_RP0_freq_mhz * media_RPn_freq_mhz v2: Fixed commit author (Rodrigo) v3: Convert to new uncore interface for pcode functions v4: Adapt t

[Intel-gfx] [PATCH 2/4] drm/i915/pcode: Init pcode on different gt's

2022-05-23 Thread Ashutosh Dixit
Extend pcode initialization to pcode on different gt's. Cc: Tvrtko Ursulin Cc: Jani Nikula Signed-off-by: Ashutosh Dixit Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_driver.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 1/4] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-05-23 Thread Ashutosh Dixit
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively). Media freq factor is converted to media_ratio_mode for GuC. It is programmed i

[Intel-gfx] [PATCH 0/4] drm/i915: Media freq factor and per-gt enhancements/fixes

2022-05-23 Thread Ashutosh Dixit
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new functionalit

Re: [Intel-gfx] [PATCH 3/4] drm/i915: allow volatile buffers to use ttm pool allocator

2022-05-23 Thread Robert Beckett
On 11/05/2022 13:42, Thomas Hellström wrote: Hi, Bob, On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: internal buffers should be shmem backed. if a volatile buffer is requested, allow ttm to use the pool allocator to provide volatile pages as backing Signed-off-by: Robert Beckett

Re: [Intel-gfx] [PATCH 1/4] drm/i915: add gen6 ppgtt dummy creation function

2022-05-23 Thread Robert Beckett
On 11/05/2022 11:13, Thomas Hellström wrote: Hi, On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: Internal gem objects will soon just be volatile system memory region objects. To enable this, create a separate dummy object creation function for gen6 ppgtt It's not clear from the c

Re: [Intel-gfx] [PATCH 4/4] drm/i915: internal buffers use ttm backend

2022-05-23 Thread Robert Beckett
On 11/05/2022 15:14, Thomas Hellström wrote: On Tue, 2022-05-03 at 19:13 +, Robert Beckett wrote: refactor internal buffer backend to allocate volatile pages via ttm pool allocator Signed-off-by: Robert Beckett ---  drivers/gpu/drm/i915/gem/i915_gem_internal.c | 264 - -

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/d12+: Disable DMC firmware flip queue handlers (rev4)

2022-05-23 Thread Imre Deak
On Sat, May 21, 2022 at 03:09:30PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/d12+: Disable DMC firmware flip queue handlers (rev4) > URL : https://patchwork.freedesktop.org/series/103888/ > State : success Pushed to drm-intel-next, thanks for the reviews. > == Summary

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Add HWMON current voltage support

2022-05-23 Thread Jani Nikula
On Mon, 23 May 2022, Badal Nilawar wrote: > From: Riana Tauro > > As part of the System Managemenent Interface (SMI), use the HWMON > subsystem to display current voltage > > Cc: Anshuman Gupta > Signed-off-by: Riana Tauro > Signed-off-by: Badal Nilawar > --- > .../ABI/testing/sysfs-driver-in

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Add HWMON power sensor support

2022-05-23 Thread Jani Nikula
On Mon, 23 May 2022, Badal Nilawar wrote: > From: Dale B Stimson > > As part of the System Managemenent Interface (SMI), use the HWMON > subsystem to display power utilization. > > Signed-off-by: Dale B Stimson > Signed-off-by: Ashutosh Dixit > Signed-off-by: Riana Tauro > Signed-off-by: Badal

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Add HWMON power sensor support

2022-05-23 Thread Jani Nikula
On Mon, 23 May 2022, Badal Nilawar wrote: > From: Dale B Stimson > > As part of the System Managemenent Interface (SMI), use the HWMON > subsystem to display power utilization. > > Signed-off-by: Dale B Stimson > Signed-off-by: Ashutosh Dixit > Signed-off-by: Riana Tauro > Signed-off-by: Badal

Re: [Intel-gfx] [PATCH v1 2/2] drm/i915: Reject the atomic modeset if an associated Type-C port is disconnected

2022-05-23 Thread Imre Deak
On Fri, May 20, 2022 at 10:28:31AM +0300, Kasireddy, Vivek wrote: > Hi Imre, > [...] > > > > > @@ -131,6 +137,20 @@ int intel_digital_connector_atomic_check(struct > > > > > drm_connector *conn, > > > > > > > > > > crtc_state = drm_atomic_get_new_crtc_state(state, > > > > > new_state->crtc)

[Intel-gfx] [PATCH 2/3] drm/i915/hwmon: Add HWMON energy support

2022-05-23 Thread Badal Nilawar
From: Dale B Stimson As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display energy utilization Signed-off-by: Dale B Stimson Signed-off-by: Ashutosh Dixit Signed-off-by: Riana Tauro Signed-off-by: Badal Nilawar --- .../ABI/testing/sysfs-driver-intel-i915-hwmo

[Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Add HWMON current voltage support

2022-05-23 Thread Badal Nilawar
From: Riana Tauro As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display current voltage Cc: Anshuman Gupta Signed-off-by: Riana Tauro Signed-off-by: Badal Nilawar --- .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 +++ drivers/gpu/drm/i915/gt/intel_gt_reg

[Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Add HWMON power sensor support

2022-05-23 Thread Badal Nilawar
From: Dale B Stimson As part of the System Managemenent Interface (SMI), use the HWMON subsystem to display power utilization. Signed-off-by: Dale B Stimson Signed-off-by: Ashutosh Dixit Signed-off-by: Riana Tauro Signed-off-by: Badal Nilawar --- .../ABI/testing/sysfs-driver-intel-i915-hwmo

[Intel-gfx] [PATCH 0/3] drm/i915: Add HWMON support

2022-05-23 Thread Badal Nilawar
This series adds the HWMON support for DG1, DG2 Dale B Stimson (2): drm/i915/hwmon: Add HWMON power sensor support drm/i915/hwmon: Add HWMON energy support Riana Tauro (1): drm/i915/hwmon: Add HWMON current voltage support .../ABI/testing/sysfs-driver-intel-i915-hwmon | 43 ++ drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915: Rename block_size()/block_offset()

2022-05-23 Thread Jani Nikula
On Thu, 19 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Give block_size()/block_offset() a "raw_" prefix since they > both operate on the "raw" (as in not duplicated) BDB block > contents. > > What actually spurred this was a conflict between intel_bios.c > block_size() vs. block_size

Re: [Intel-gfx] [PATCH v6 0/7] drm/i915: Media freq factor and per-gt enhancements/fixes

2022-05-23 Thread Tvrtko Ursulin
On 13/05/2022 02:36, Ashutosh Dixit wrote: Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are

Re: [Intel-gfx] [CI 0/3] Expose max and current bpc via debugfs

2022-05-23 Thread Jani Nikula
On Thu, 19 May 2022, Bhanuprakash Modem wrote: > This series will expose the Connector's max supported bpc via connector > debugfs and Crtc's current bpc via crtc debugfs. Also move the existing > vendor specific "output_bpc" logic to drm. Pushed the series to drm-misc-next, thanks for that patch

Re: [Intel-gfx] [PULL] drm-intel-next -> drm-intel-gt-next cross-merge sync

2022-05-23 Thread Tvrtko Ursulin
On 20/05/2022 12:02, Jani Nikula wrote: Hi all, This is for Tvrtko to pull to cross-merge sync drm-intel-next to drm-intel-gt-next. Dave, Daniel, IIUC this is what you prefer over having topic branches for all the small things that are needed between drm-intel branches. I don't think we've d

Re: [Intel-gfx] [PATCH] drm/i915: Write zero wms if we disable planes for icl+

2022-05-23 Thread Lisovskiy, Stanislav
On Mon, May 23, 2022 at 11:06:05AM +0300, Govindapillai, Vinod wrote: > Hi Stan > > Pls see some comments inline.. > > BR > Vinod > > On Wed, 2022-05-18 at 13:59 +0300, Stanislav Lisovskiy wrote: > > Otherwise we seem to get FIFO underruns. It is being disabled > > anyway, so kind of logical to

Re: [Intel-gfx] [PATCH] drm/i915/dsi: fix VBT send packet port selection for ICL+

2022-05-23 Thread Jani Nikula
On Fri, 20 May 2022, Ville Syrjälä wrote: > On Fri, May 20, 2022 at 12:46:00PM +0300, Jani Nikula wrote: >> The VBT send packet port selection was never updated for ICL+ where the >> 2nd link is on port B instead of port C as in VLV+ DSI. >> >> First, single link DSI needs to use the configured p

Re: [Intel-gfx] [PATCH] drm/i915: Write zero wms if we disable planes for icl+

2022-05-23 Thread Govindapillai, Vinod
Hi Stan Pls see some comments inline.. BR Vinod On Wed, 2022-05-18 at 13:59 +0300, Stanislav Lisovskiy wrote: > Otherwise we seem to get FIFO underruns. It is being disabled > anyway, so kind of logical to write those as zeroes, even if > disabling is temporary. > > Signed-off-by: Stanislav Lis

Re: [Intel-gfx] [PATCH v4 5/6] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

2022-05-23 Thread Tvrtko Ursulin
On 21/05/2022 00:04, Matt Roper wrote: As with EU masks, it's easier to store subslice/DSS masks internally in a format that's more natural for the driver to work with, and then only covert into the u8[] uapi form when the query ioctl is invoked. Since the hardware design changed significantly

[Intel-gfx] [PATCH] drm/i915/hwconfig: Report no hwconfig support on ADL-N

2022-05-23 Thread Balasubramani Vivekanandan
ADL-N being a subplatform of ADL-P, it lacks support for hwconfig table. Explicit check added to skip ADL-N. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/u