Re: [Intel-gfx] [RFC PATCH v2 0/1] Replace shmem memory region and object backend

2022-05-30 Thread Matthew Auld
On Fri, 27 May 2022 at 16:37, Adrian Larumbe wrote: > > On 18.05.2022 16:00, Matthew Auld wrote: > > On Tue, 17 May 2022 at 21:45, Adrian Larumbe > > wrote: > > > > > > This patch is a second attempt at eliminating the old shmem memory region > > > and GEM object backend, in favour of a

Re: [Intel-gfx] [PATCH 03/10] drm/i915/uapi: expose the avail tracking

2022-05-30 Thread Matthew Auld
On 26/05/2022 09:33, Tvrtko Ursulin wrote: On 26/05/2022 09:10, Matthew Auld wrote: On 26/05/2022 08:58, Tvrtko Ursulin wrote: On 25/05/2022 19:43, Matthew Auld wrote: Vulkan would like to have a rough measure of how much device memory can in theory be allocated. Also add

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Treat DMRRS as static DRRS

2022-05-30 Thread Jani Nikula
On Mon, 30 May 2022, Jani Nikula wrote: > On Fri, 27 May 2022, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Some machines declare DRRS type = seamless, DRRS = no, DMRRS = yes. >> I *think* DMRRS stands for "dynamcic media refresh rate", and >> I suspect the way it's meant to work is that

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/3] lib/igt_device_scan: Free filtered devices in igt_devices_free

2022-05-30 Thread Petri Latvala
On Mon, May 30, 2022 at 04:40:06AM +0200, Zbigniew Kempczyński wrote: > On Fri, May 27, 2022 at 11:50:40AM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Fix a possible oversight. > > Yes, properly coded in igt_device_scan() only. Thanks for spotting this. > > > > >

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Treat DMRRS as static DRRS

2022-05-30 Thread Jani Nikula
On Fri, 27 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Some machines declare DRRS type = seamless, DRRS = no, DMRRS = yes. > I *think* DMRRS stands for "dynamcic media refresh rate", and > I suspect the way it's meant to work is that it lets the driver > switch refresh rates to

Re: [Intel-gfx] [PATCH i-g-t 3/3] intel_gpu_top: Free all memory on exit

2022-05-30 Thread Petri Latvala
On Fri, May 27, 2022 at 11:50:42AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Be nice and explicitly free all memory on exit. > > Also fix a Valgrind reported unitilised conditional jump. > > Signed-off-by: Tvrtko Ursulin > Cc: Petri Latvala Reviewed-by: Petri Latvala > --- >

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib/drm_fdinfo: Ensure buffer is null terminated

2022-05-30 Thread Petri Latvala
On Fri, May 27, 2022 at 11:50:41AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Ensure buffer is null terminated at the point where the read ended and not > at the end of the whole buffer. Otherwise string parsing can stray into > un-initialised memory. > > Signed-off-by: Tvrtko

Re: [Intel-gfx] [PATCH 5/6] drm/i915/bios: Define more BDB contents

2022-05-30 Thread Jani Nikula
On Fri, 27 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a bunch of new struff we're missing in various BDB blocks. > > TODO: Bunch of these might actually need to be taken > into use... Cc: Jouni, Lyude for some HDR backlight stuff below. > > Signed-off-by: Ville Syrjälä > ---

Re: [Intel-gfx] [PATCH 4/6] drm/i915/bios: Fix aggressiveness typos

2022-05-30 Thread Jani Nikula
On Fri, 27 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Fix various typos around "aggressiveness". Note that > the VBT spec also sometimes missspells it as > "agressiveness" so I guess that's where some of the typos > came from. Could nitpick unrelated things like space before ":"

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Accept more fixed modes with VRR panels

2022-05-30 Thread Jani Nikula
On Fri, 27 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > It seem that when dealing with VRR capable eDP panels we need > to accept fixed modes with variable vblank length (which is what > VRR varies dynamically). Typically the preferred mode seems to be > a non-VRR more (lowish

Re: [Intel-gfx] [PATCH 2/6] drm/i915: Print out rejected fixed modes

2022-05-30 Thread Jani Nikula
On Fri, 27 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > To help with debugging DRRS/VRR panel init let's dump out all > the fixed modes we rejected for whatever reason. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_panel.c |

Re: [Intel-gfx] [PATCH] drm/syncobj: flatten dma_fence_chains on transfer

2022-05-30 Thread Lionel Landwerlin
On 30/05/2022 14:40, Christian König wrote: Am 30.05.22 um 12:09 schrieb Lionel Landwerlin: On 30/05/2022 12:52, Christian König wrote: Am 25.05.22 um 23:59 schrieb Lucas De Marchi: On Wed, May 25, 2022 at 12:38:51PM +0200, Christian König wrote: Am 25.05.22 um 11:35 schrieb Lionel

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Parse VRR capability from VBT

2022-05-30 Thread Jani Nikula
On Fri, 27 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > VBT seems to have an extra flag for VRR vs. not. Let's consult > that for eDP panels. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_bios.c | 5 + >

Re: [Intel-gfx] [PATCH 26/26] drm/i915: Round TMDS clock to nearest

2022-05-30 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Use round-to-nearest behavour when calculating the TMDS clock. > Matches what we co for most other clock related things. *do Acked-by: Jani Nikula > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 25/26] drm/i915: Round to closest in M/N calculations

2022-05-30 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Rounding to nearest is what we do for most other clock calculations > so should probably do that for M/N too. > > TODO: GOP seems to truncate instead so fastboot is going to be > a PITA to get right. Not sure what to do about it

Re: [Intel-gfx] [PATCH 24/26] drm/i915: Use a fixed N value always

2022-05-30 Thread Jani Nikula
On Tue, 03 May 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Windows/BIOS always uses fixed N values. Let's match that > behaviour. > > Allows us to also get rid of that constant_n quirk stuff. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH v10 0/4] Separate panel orientation property creating and value setting

2022-05-30 Thread Hsin-Yi Wang
On Mon, May 30, 2022 at 4:53 PM Hans de Goede wrote: > > Hi, > > On 5/30/22 10:19, Hsin-Yi Wang wrote: > > Some drivers, eg. mtk_drm and msm_drm, rely on the panel to set the > > orientation. Panel calls drm_connector_set_panel_orientation() to create > > orientation property and sets the value.

Re: [Intel-gfx] [PATCH] drm/syncobj: flatten dma_fence_chains on transfer

2022-05-30 Thread Lionel Landwerlin
On 30/05/2022 12:52, Christian König wrote: Am 25.05.22 um 23:59 schrieb Lucas De Marchi: On Wed, May 25, 2022 at 12:38:51PM +0200, Christian König wrote: Am 25.05.22 um 11:35 schrieb Lionel Landwerlin: [SNIP] Err... Let's double check with my colleagues. It seems we're running into a test

Re: [Intel-gfx] [PATCH v6 04/22] drm/panfrost: Fix shrinker list corruption by madvise IOCTL

2022-05-30 Thread Steven Price
On 27/05/2022 00:50, Dmitry Osipenko wrote: > Calling madvise IOCTL twice on BO causes memory shrinker list corruption > and crashes kernel because BO is already on the list and it's added to > the list again, while BO should be removed from from the list before it's > re-added. Fix it. > > Cc:

[Intel-gfx] ✗ Fi.CI.BAT: failure for Separate panel orientation property creating and value setting (rev2)

2022-05-30 Thread Patchwork
== Series Details == Series: Separate panel orientation property creating and value setting (rev2) URL : https://patchwork.freedesktop.org/series/101530/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11705 -> Patchwork_101530v2

Re: [Intel-gfx] [PATCH v10 1/4] gpu: drm: separate panel orientation property creating and value setting

2022-05-30 Thread Hans de Goede
Hi, On 5/30/22 10:57, Hans de Goede wrote: > Hi, > > On 5/30/22 10:19, Hsin-Yi Wang wrote: >> drm_dev_register() sets connector->registration_state to >> DRM_CONNECTOR_REGISTERED and dev->registered to true. If >> drm_connector_set_panel_orientation() is first called after >> drm_dev_register(),

Re: [Intel-gfx] [PATCH v10 1/4] gpu: drm: separate panel orientation property creating and value setting

2022-05-30 Thread Hans de Goede
Hi, On 5/30/22 10:19, Hsin-Yi Wang wrote: > drm_dev_register() sets connector->registration_state to > DRM_CONNECTOR_REGISTERED and dev->registered to true. If > drm_connector_set_panel_orientation() is first called after > drm_dev_register(), it will fail several checks and results in following

Re: [Intel-gfx] [PATCH v10 0/4] Separate panel orientation property creating and value setting

2022-05-30 Thread Hans de Goede
Hi, On 5/30/22 10:19, Hsin-Yi Wang wrote: > Some drivers, eg. mtk_drm and msm_drm, rely on the panel to set the > orientation. Panel calls drm_connector_set_panel_orientation() to create > orientation property and sets the value. However, connector properties > can't be created after

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Separate panel orientation property creating and value setting (rev2)

2022-05-30 Thread Patchwork
== Series Details == Series: Separate panel orientation property creating and value setting (rev2) URL : https://patchwork.freedesktop.org/series/101530/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Separate panel orientation property creating and value setting (rev2)

2022-05-30 Thread Patchwork
== Series Details == Series: Separate panel orientation property creating and value setting (rev2) URL : https://patchwork.freedesktop.org/series/101530/ State : warning == Summary == Error: dim checkpatch failed bf8654ee2da6 gpu: drm: separate panel orientation property creating and value

[Intel-gfx] [PATCH v10 4/4] arm64: dts: mt8183: Add panel rotation

2022-05-30 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra Tested-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] [PATCH v10 3/4] drm/msm: init panel orientation property

2022-05-30 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c

[Intel-gfx] [PATCH v10 2/4] drm/mediatek: init panel orientation property

2022-05-30 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Intel-gfx] [PATCH v10 1/4] gpu: drm: separate panel orientation property creating and value setting

2022-05-30 Thread Hsin-Yi Wang
drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel

[Intel-gfx] [PATCH v10 0/4] Separate panel orientation property creating and value setting

2022-05-30 Thread Hsin-Yi Wang
Some drivers, eg. mtk_drm and msm_drm, rely on the panel to set the orientation. Panel calls drm_connector_set_panel_orientation() to create orientation property and sets the value. However, connector properties can't be created after drm_dev_register() is called. The goal is to separate the

Re: [Intel-gfx] [PATCH RESEND v6] drm/i915/display: disable HPD workers before display driver unregister

2022-05-30 Thread Govindapillai, Vinod
On Fri, 2022-05-20 at 00:35 +0200, Andrzej Hajda wrote: > Handling HPD during driver removal is pointless, and can cause different > use-after-free/concurrency issues: > 1. Setup of deferred fbdev after fbdev unregistration. > 2. Access to DP-AUX after DP-AUX removal. Thanks. Reviewed-by: Vinod