[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Extract, polish, and document multicast handling

2022-06-15 Thread Patchwork
== Series Details == Series: i915: Extract, polish, and document multicast handling URL : https://patchwork.freedesktop.org/series/105134/ State : success == Summary == CI Bug Log - changes from CI_DRM_11758_full -> Patchwork_105134v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: add payload receiving code (rev3)

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add payload receiving code (rev3) URL : https://patchwork.freedesktop.org/series/105096/ State : success == Summary == CI Bug Log - changes from CI_DRM_11763 -> Patchwork_105096v3 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsi: add payload receiving code (rev2)

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add payload receiving code (rev2) URL : https://patchwork.freedesktop.org/series/105096/ State : success == Summary == CI Bug Log - changes from CI_DRM_11763_full -> Patchwork_105096v2_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Get dsc optimal output bpp

2022-06-15 Thread Patchwork
== Series Details == Series: Get dsc optimal output bpp URL : https://patchwork.freedesktop.org/series/105200/ State : success == Summary == CI Bug Log - changes from CI_DRM_11763 -> Patchwork_105200v1 Summary --- **SUCCESS** No r

[Intel-gfx] [PATCH v3] drm/i915/dsi: add payload receiving code

2022-06-15 Thread William Tseng
To support Host to read data from Peripheral after a DCS read command is sent over DSI. Cc: Jani Nikula Cc: Ville Syrjälä Cc: Vandita Kulkarni Cc: Lee Shawn C Signed-off-by: William Tseng --- drivers/gpu/drm/i915/display/icl_dsi.c | 75 +++-- drivers/gpu/drm/i915/display

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Extract, polish, and document multicast handling

2022-06-15 Thread Matt Roper
On Thu, Jun 16, 2022 at 03:11:40AM +, Patchwork wrote: > == Series Details == > > Series: i915: Extract, polish, and document multicast handling > URL : https://patchwork.freedesktop.org/series/105134/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11758_full -> P

[Intel-gfx] [RFC PATCH 3/3] drm/i915/dp: Get optimal link config to have best compressed bpp

2022-06-15 Thread Ankit Nautiyal
Currently, we take the max lane, rate and pipe bpp, to get the maximum compressed bpp possible. We then set the output bpp to this value. This patch provides support to have max bpp, min rate and min lanes, that can support the min compressed bpp. This patch also takes care of the validation case w

[Intel-gfx] [RFC PATCH 2/3] drm/i915/dp: Rename helper to get max pipe bpp with DSC

2022-06-15 Thread Ankit Nautiyal
The helper intel_dp_dsc_compute_bpp gives the maximum pipe bpp that is allowed with DSC. Renaming the function to reflect the same. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a

[Intel-gfx] [RFC PATCH 1/3] drm/i915/dp: Rename helper to calculate dsc output bpp

2022-06-15 Thread Ankit Nautiyal
Currently we the required dsc output bpp is set to be the largest compressed bpp supported for max, lane, rate, and bpp. The helper intel_dp_dsc_get_output_bpp gets the maximum supported compressed bpp taking into account link configuration, input bpp, bigjoiner considerations etc. This patch appe

[Intel-gfx] [RFC PATCH 0/3] Get dsc optimal output bpp

2022-06-15 Thread Ankit Nautiyal
Currently, when going with DSC for DP, we take the max lane, rate and pipe bpp, to get the maximum compressed bpp possible. We then set the output bpp to this value. It might be possible to have lesser rate or lane count, for which the same compressed bpp works. This RFC series attempts to get the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: add payload receiving code (rev2)

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add payload receiving code (rev2) URL : https://patchwork.freedesktop.org/series/105096/ State : success == Summary == CI Bug Log - changes from CI_DRM_11763 -> Patchwork_105096v2 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: add payload receiving code (rev2)

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add payload receiving code (rev2) URL : https://patchwork.freedesktop.org/series/105096/ State : warning == Summary == Error: dim checkpatch failed 45422b4b5f8a drm/i915/dsi: add payload receiving code -:27: CHECK:PARENTHESIS_ALIGNMENT: Alignment shou

[Intel-gfx] [PATCH v2] drm/i915/dsi: add payload receiving code

2022-06-15 Thread William Tseng
To support Host to read data from Peripheral after a DCS read command is sent over DSI. Cc: Jani Nikula Cc: Ville Syrjälä Cc: Vandita Kulkarni Cc: Lee Shawn C Signed-off-by: William Tseng --- drivers/gpu/drm/i915/display/icl_dsi.c | 76 +++-- drivers/gpu/drm/i915/display

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Extract, polish, and document multicast handling

2022-06-15 Thread Patchwork
== Series Details == Series: i915: Extract, polish, and document multicast handling URL : https://patchwork.freedesktop.org/series/105134/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11758_full -> Patchwork_105134v1_full

Re: [Intel-gfx] linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
Pushed to drm-misc-next. Alex On Wed, Jun 15, 2022 at 7:26 PM Stephen Rothwell wrote: > > Hi all, > > On Wed, 15 Jun 2022 13:52:34 -0700 Nathan Chancellor > wrote: > > > > On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > > > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor >

Re: [Intel-gfx] [PATCH 00/15] HuC loading for DG2

2022-06-15 Thread Zhang, Carl
> On From: Ye, Tony > Sent: Thursday, June 16, 2022 12:15 AM > > > On 6/15/2022 3:13 AM, Tvrtko Ursulin wrote: > > > > On 15/06/2022 00:15, Ye, Tony wrote: > >> On 6/14/2022 8:30 AM, Ceraolo Spurio, Daniele wrote: > >>> On 6/14/2022 12:44 AM, Tvrtko Ursulin wrote: > > On 13/06/2022 19

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Extract intel_sanitize_fifo_underrun_reporting()

2022-06-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Extract intel_sanitize_fifo_underrun_reporting() URL : https://patchwork.freedesktop.org/series/105180/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11762_full -> Patchwork_105180v1_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for Fix TLB invalidate issues with Broadwell

2022-06-15 Thread Patchwork
== Series Details == Series: Fix TLB invalidate issues with Broadwell URL : https://patchwork.freedesktop.org/series/105167/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11761_full -> Patchwork_105167v1_full Summary --

Re: [Intel-gfx] linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Stephen Rothwell
Hi all, On Wed, 15 Jun 2022 13:52:34 -0700 Nathan Chancellor wrote: > > On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > > On Wed, Jun 15, 2022 at 4:24 PM Nathan Chancellor > > wrote: > > > > > > On Wed, Jun 15, 2022 at 03:28:52PM -0400, Alex Deucher wrote: > > > > On Wed, Ju

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/bios: Move panel_type stuff out of parse_panel_options()

2022-06-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/bios: Move panel_type stuff out of parse_panel_options() URL : https://patchwork.freedesktop.org/series/105166/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11759_full -> Patchwork_105166v1_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Extract, polish, and document multicast handling

2022-06-15 Thread Patchwork
== Series Details == Series: i915: Extract, polish, and document multicast handling URL : https://patchwork.freedesktop.org/series/105134/ State : success == Summary == CI Bug Log - changes from CI_DRM_11758 -> Patchwork_105134v1 Summary --

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Extract, polish, and document multicast handling

2022-06-15 Thread Vudum, Lakshminarayana
Yes, I see we don't have an issue. So I have created https://gitlab.freedesktop.org/drm/intel/-/issues/6246 igt@i915_module_load@load - dmesg-warn - drm_WARN_ON(lpt_iclkip_freq(&p) != clock), WARNING: .* at drivers/gpu/drm/i915/display/intel_pch_refclk.c:\d+ lpt_program_iclkip Thanks, Lakshmi.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Extract, polish, and document multicast handling

2022-06-15 Thread Matt Roper
On Wed, Jun 15, 2022 at 01:03:06AM +, Patchwork wrote: > == Series Details == > > Series: i915: Extract, polish, and document multicast handling > URL : https://patchwork.freedesktop.org/series/105134/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_11758 -> Patchw

Re: [Intel-gfx] [PATCH] drm/dp/mst: Read the extended DPCD capabilities during system resume

2022-06-15 Thread Lyude Paul
If you add a Cc: to sta...@vger.kernel.org then this is: Reviewed-by: Lyude Paul I assume you have the privileges to push this to drm-misc-next On Tue, 2022-06-14 at 12:45 +0300, Imre Deak wrote: > The WD22TB4 Thunderbolt dock at least will revert its DP_MAX_LINK_RATE > from HBR3 to HBR2 after

Re: [Intel-gfx] [PATCH] drm/i915: Implement w/a 22010492432 for adl-s

2022-06-15 Thread Matt Roper
On Mon, Jun 13, 2022 at 11:14:39PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > adl-s needs the combo PLL DCO fraction w/a as well. > Get us slightly more accurate clock out of the PLL. > > Cc: sta...@vger.kernel.org > Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper > --- > dr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Extract intel_sanitize_fifo_underrun_reporting()

2022-06-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Extract intel_sanitize_fifo_underrun_reporting() URL : https://patchwork.freedesktop.org/series/105180/ State : success == Summary == CI Bug Log - changes from CI_DRM_11762 -> Patchwork_105180v1

Re: [Intel-gfx] [PATCH v3 2/8] drm: Drop drm_framebuffer.h from drm_crtc.h

2022-06-15 Thread Sam Ravnborg
On Tue, Jun 14, 2022 at 12:54:49PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_crtc.h has no need for drm_frambuffer.h, so don't include it. > Avoids useless rebuilds of the entire universe when > touching drm_framebuffer.h. > > Quite a few placs do currently depend on drm_framebuf

Re: [Intel-gfx] [PATCH 1/8] drm: Drop drm_edid.h from drm_crtc.h

2022-06-15 Thread Sam Ravnborg
Hi Ville, On Mon, Jun 13, 2022 at 11:03:10PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_crtc.h has no need for drm_edid.h, so don't include it. > Avoids useless rebuilds of the entire universe when > touching drm_edid.h. > > Quite a few placs do currently depend on drm_edid.h wit

Re: [Intel-gfx] [PATCH 0/8] drm: Clean up drm_crtc.h

2022-06-15 Thread Sam Ravnborg
Hi Ville, On Mon, Jun 13, 2022 at 11:03:09PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Eliminate unnecessary includes from drm_crtc.h to avoid > pointless rebuilds of the entire universe when touching > some random header. > > I didn't really feel like splitting this up per-driver s

Re: [Intel-gfx] [PATCH 3/8] drm: Drop drm_blend.h from drm_crtc.h

2022-06-15 Thread Sam Ravnborg
Hi Ville. On Mon, Jun 13, 2022 at 11:03:12PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > drm_crtc.h has no need for drm_blend.h, so don't include it. > Avoids useless rebuilds of the entire universe when > touching drm_blend.h. s/drm_blend.h/drm_crtc.h/ > > Quite a few placs do curren

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/display: split out verifation, compare and dump from intel_display.c URL : https://patchwork.freedesktop.org/series/105156/ State : success == Summary == CI Bug Log - changes from CI_DRM_11759_full -> Patchwork_105156v1_full ==

Re: [Intel-gfx] [PATCH v7] drm/i915/display: disable HPD workers before display driver unregister

2022-06-15 Thread Ville Syrjälä
On Tue, Jun 14, 2022 at 05:06:40PM +0200, Andrzej Hajda wrote: > On 10.06.2022 20:37, Ville Syrjälä wrote: > > On Fri, Jun 10, 2022 at 06:00:24PM +0200, Andrzej Hajda wrote: > >> Handling HPD during driver removal is pointless, and can cause different > >> use-after-free/concurrency issues: > >> 1.

Re: [Intel-gfx] [Intel-gfx 1/1] drm/i915/guc: Don't update engine busyness stats too frequently

2022-06-15 Thread Lucas De Marchi
On Tue, Jun 14, 2022 at 08:07:04AM +0100, Tvrtko Ursulin wrote: On 14/06/2022 02:10, Umesh Nerlige Ramappa wrote: On Sat, Jun 11, 2022 at 10:27:11AM -0700, Alan Previn wrote: Using igt's gem-create and with additional patches to track object creation time, it was measured that guc_update_engin

[Intel-gfx] ✓ Fi.CI.IGT: success for Bump up CDCLK for DG2 (rev2)

2022-06-15 Thread Patchwork
== Series Details == Series: Bump up CDCLK for DG2 (rev2) URL : https://patchwork.freedesktop.org/series/105110/ State : success == Summary == CI Bug Log - changes from CI_DRM_11759_full -> Patchwork_105110v2_full Summary --- **SUCCE

Re: [Intel-gfx] [PULL] drm-misc-next

2022-06-15 Thread Daniel Vetter
On Wed, Jun 08, 2022 at 12:34:41PM +0200, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > here's the first PR for drm-misc-next that will go into v5.20. > > Best regards > Thomas > > drm-misc-next-2022-06-08: > drm-misc-next for 5.20: > > UAPI Changes: > > * connector: export bpc limits in

[Intel-gfx] ✗ Fi.CI.IGT: failure for Do not enable PSR2 if no active planes (rev2)

2022-06-15 Thread Patchwork
== Series Details == Series: Do not enable PSR2 if no active planes (rev2) URL : https://patchwork.freedesktop.org/series/105109/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11759_full -> Patchwork_105109v2_full Summary -

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pvc: Add recommended MMIO setting

2022-06-15 Thread Matt Roper
On Tue, Jun 14, 2022 at 11:48:24PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/pvc: Add recommended MMIO setting > URL : https://patchwork.freedesktop.org/series/105063/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_11755_full -> Patchwork_105

[Intel-gfx] [PATCH 2/2] drm/i915: Sanitize underrun reporting before turning off any pipes

2022-06-15 Thread Ville Syrjala
From: Ville Syrjälä Make sure FIFO underrun reporting is flagged as disabled very early during the state readout so that we don't get any spurious FIFO underruns reports from intel_crtc_disable_noatomic(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++--

[Intel-gfx] [PATCH 1/2] drm/i915: Extract intel_sanitize_fifo_underrun_reporting()

2022-06-15 Thread Ville Syrjala
From: Ville Syrjälä Pull the underrun status sanitation into its own helper. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 65 +++- 1 file changed, 37 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix TLB invalidate issues with Broadwell

2022-06-15 Thread Patchwork
== Series Details == Series: Fix TLB invalidate issues with Broadwell URL : https://patchwork.freedesktop.org/series/105167/ State : success == Summary == CI Bug Log - changes from CI_DRM_11761 -> Patchwork_105167v1 Summary --- **SUC

Re: [Intel-gfx] [PATCH] i915/pmu: Wire GuC backend to per-client busyness

2022-06-15 Thread Umesh Nerlige Ramappa
On Wed, Jun 15, 2022 at 08:08:40AM +0100, Tvrtko Ursulin wrote: On 14/06/2022 17:32, Umesh Nerlige Ramappa wrote: On Tue, Jun 14, 2022 at 02:30:42PM +0100, Tvrtko Ursulin wrote: On 14/06/2022 01:46, Nerlige Ramappa, Umesh wrote: From: John Harrison GuC provides engine_id and last_switch_in

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fix TLB invalidate issues with Broadwell

2022-06-15 Thread Patchwork
== Series Details == Series: Fix TLB invalidate issues with Broadwell URL : https://patchwork.freedesktop.org/series/105167/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_e

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fix TLB invalidate issues with Broadwell

2022-06-15 Thread Patchwork
== Series Details == Series: Fix TLB invalidate issues with Broadwell URL : https://patchwork.freedesktop.org/series/105167/ State : warning == Summary == Error: dim checkpatch failed f4a32c9a2c4b drm/i915/gt: Ignore TLB invalidations on idle engines -:135: CHECK:MACRO_ARG_REUSE: Macro argumen

Re: [Intel-gfx] [PATCH 2/6] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-06-15 Thread Umesh Nerlige Ramappa
On Wed, Jun 15, 2022 at 04:27:36PM +0100, Mauro Carvalho Chehab wrote: From: Chris Wilson On gen12 HW, ensure that the TLB of the OA unit is also invalidated as just invalidating the TLB of an engine is not enough. Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Si

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/bios: Move panel_type stuff out of parse_panel_options()

2022-06-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/bios: Move panel_type stuff out of parse_panel_options() URL : https://patchwork.freedesktop.org/series/105166/ State : success == Summary == CI Bug Log - changes from CI_DRM_11759 -> Patchwork_105166v1 =

Re: [Intel-gfx] [PATCH 00/15] HuC loading for DG2

2022-06-15 Thread Ye, Tony
On 6/15/2022 3:13 AM, Tvrtko Ursulin wrote: On 15/06/2022 00:15, Ye, Tony wrote: On 6/14/2022 8:30 AM, Ceraolo Spurio, Daniele wrote: On 6/14/2022 12:44 AM, Tvrtko Ursulin wrote: On 13/06/2022 19:13, Ceraolo Spurio, Daniele wrote: On 6/13/2022 10:39 AM, Tvrtko Ursulin wrote: On 13/06/202

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-06-15 Thread Das, Nirmoy
Hi Gwan-gyeong, On 6/3/2022 11:38 AM, Gwan-gyeong Mun wrote: The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size i

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-15 Thread Vudum, Lakshminarayana
Comments below -Original Message- From: Roper, Matthew D Sent: Tuesday, June 14, 2022 2:17 PM To: Vudum, Lakshminarayana Cc: intel-gfx@lists.freedesktop.org Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT() Looks like the logs

[Intel-gfx] [PATCH 2/6] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-06-15 Thread Mauro Carvalho Chehab
From: Chris Wilson On gen12 HW, ensure that the TLB of the OA unit is also invalidated as just invalidating the TLB of an engine is not enough. Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") Signed-off-by: Chris Wilson Cc: Fei Yang Cc: Andi Shyti Cc: sta...@vger.

[Intel-gfx] [PATCH 1/6] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-06-15 Thread Mauro Carvalho Chehab
From: Chris Wilson As an extension of the current skip TLB invalidations, check if the device is powered down prior to any engine activity, as, on such cases, all the TLBs were already invalidated, so an explicit TLB invalidation is not needed. This becomes more significant with GuC, as it can

[Intel-gfx] [PATCH 3/6] drm/i915/gt: Skip TLB invalidations once wedged

2022-06-15 Thread Mauro Carvalho Chehab
From: Chris Wilson Skip all further TLB invalidations once the device is wedged and had been reset, as, on such cases, it can no longer process instructions on the GPU and the user no longer has access to the TLB's in each engine. Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backi

[Intel-gfx] [PATCH 0/6] Fix TLB invalidate issues with Broadwell

2022-06-15 Thread Mauro Carvalho Chehab
i915 selftest hangcheck is causing the i915 driver timeouts, as reported by Intel CI bot: http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4 When such test runs, the only output is: [ 68.811639] i915: Performing liv

[Intel-gfx] [PATCH 4/6] drm/i915/gt: Only invalidate TLBs exposed to user manipulation

2022-06-15 Thread Mauro Carvalho Chehab
From: Chris Wilson Don't flush TLBs when the buffer is only used in the GGTT under full control of the kernel, as there's no risk of of concurrent access and stale access from prefetch. We only need to invalidate the TLB if they are accessible by the user. Fixes: 7938d61591d3 ("drm/i915: Flush

[Intel-gfx] [PATCH 6/6] drm/i915/gt: Serialize TLB invalidates with GT resets

2022-06-15 Thread Mauro Carvalho Chehab
From: Chris Wilson Avoid trying to invalidate the TLB in the middle of performing an engine reset, as this may result in the reset timing out. Currently, the TLB invalidate is only serialised by its own mutex, forgoing the uncore lock, but we can take the uncore->lock as well to serialise the mmi

[Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-15 Thread Mauro Carvalho Chehab
From: Chris Wilson Don't allow two engines to be reset in parallel, as they would both try to select a reset bit (and send requests to common registers) and wait on that register, at the same time. Serialize control of the reset requests/acks using the uncore->lock, which will also ensure that no

Re: [Intel-gfx] [PATCH 0/7] drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Ville Syrjälä
On Wed, Jun 15, 2022 at 06:15:58PM +0300, Jani Nikula wrote: > On Wed, 15 Jun 2022, Jani Nikula wrote: > > On Wed, 15 Jun 2022, Ville Syrjälä wrote: > >> On Wed, Jun 15, 2022 at 03:47:54PM +0300, Jani Nikula wrote: > >>> The state verification and pipe config comparison/dumping are fairly > >>> i

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-15 Thread Niranjana Vishwanathapura
On Wed, Jun 15, 2022 at 08:22:23AM +0100, Tvrtko Ursulin wrote: On 14/06/2022 17:42, Niranjana Vishwanathapura wrote: On Tue, Jun 14, 2022 at 05:07:37PM +0100, Tvrtko Ursulin wrote: On 14/06/2022 17:02, Tvrtko Ursulin wrote: On 14/06/2022 16:43, Niranjana Vishwanathapura wrote: On Tue, Jun

Re: [Intel-gfx] [PATCH 0/7] drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Jani Nikula
On Wed, 15 Jun 2022, Jani Nikula wrote: > On Wed, 15 Jun 2022, Ville Syrjälä wrote: >> On Wed, Jun 15, 2022 at 03:47:54PM +0300, Jani Nikula wrote: >>> The state verification and pipe config comparison/dumping are fairly >>> isolated pieces of code within intel_display.c. Move them to separate >>

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT()

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/pvc: Adjust EU per SS according to HAS_ONE_EU_PER_FUSE_BIT() URL : https://patchwork.freedesktop.org/series/105010/ State : success == Summary == CI Bug Log - changes from CI_DRM_11753_full -> Patchwork_105010v1_full ===

[Intel-gfx] [PATCH 2/3] drm/i915/bios: Don't parse the DPS panel type when the VBT does not have it

2022-06-15 Thread Ville Syrjala
From: Ville Syrjälä Older VBTs don't have all the stuff we've defined for the LVDS options block (40). In particular we're currently parsing the DPS panel type bits even though they may not exist, which could mean we end up flagging the machine as supporting static DRRS when the VBT declared no s

[Intel-gfx] [PATCH 1/3] drm/i915/bios: Move panel_type stuff out of parse_panel_options()

2022-06-15 Thread Ville Syrjala
From: Ville Syrjälä Parsing the panel_type is a bit special and should be done before we parse anything else potentially panel-specific from the VBT. So move it out from parse_panel_options(). It doesn't neet to be there anyway since it'll do its own LVDS options block lookup. Signed-off-by: Vil

[Intel-gfx] [PATCH 3/3] drm/i915/bios: Introduce panel_bits() and panel_bool()

2022-06-15 Thread Ville Syrjala
From: Ville Syrjälä Abstract the bit extraction from the VBT per-panel bitfields slightly. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_bios.c | 31 +-- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 -- 2 files changed, 21 insertions(+), 13 delet

Re: [Intel-gfx] [PATCH 00/15] HuC loading for DG2

2022-06-15 Thread Tvrtko Ursulin
On 15/06/2022 15:35, Ceraolo Spurio, Daniele wrote: On 6/15/2022 3:13 AM, Tvrtko Ursulin wrote: On 15/06/2022 00:15, Ye, Tony wrote: On 6/14/2022 8:30 AM, Ceraolo Spurio, Daniele wrote: On 6/14/2022 12:44 AM, Tvrtko Ursulin wrote: On 13/06/2022 19:13, Ceraolo Spurio, Daniele wrote: On 6/

Re: [Intel-gfx] [PATCH] drm/i915/pvc: Add recommended MMIO setting

2022-06-15 Thread Souza, Jose
On Mon, 2022-06-13 at 09:53 -0700, Matt Roper wrote: > As with past platforms, the bspec's performance tuning guide provides > recommended MMIO settings. Although not technically "workarounds" we > apply these through the workaround framework to ensure that they're > re-applied at the proper times

Re: [Intel-gfx] [PATCH 00/15] HuC loading for DG2

2022-06-15 Thread Ceraolo Spurio, Daniele
On 6/15/2022 3:13 AM, Tvrtko Ursulin wrote: On 15/06/2022 00:15, Ye, Tony wrote: On 6/14/2022 8:30 AM, Ceraolo Spurio, Daniele wrote: On 6/14/2022 12:44 AM, Tvrtko Ursulin wrote: On 13/06/2022 19:13, Ceraolo Spurio, Daniele wrote: On 6/13/2022 10:39 AM, Tvrtko Ursulin wrote: On 13/06/20

Re: [Intel-gfx] [PATCH 0/7] drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Jani Nikula
On Wed, 15 Jun 2022, Ville Syrjälä wrote: > On Wed, Jun 15, 2022 at 03:47:54PM +0300, Jani Nikula wrote: >> The state verification and pipe config comparison/dumping are fairly >> isolated pieces of code within intel_display.c. Move them to separate >> files in a long overdue cleanup. >> >> Jani

Re: [Intel-gfx] [PATCH 7/7] drm/i915/display: split out pipe config dump to a separate file

2022-06-15 Thread Jani Nikula
On Wed, 15 Jun 2022, Ville Syrjälä wrote: > On Wed, Jun 15, 2022 at 03:48:01PM +0300, Jani Nikula wrote: >> Declutter intel_display.c by splitting out pipe config dumping to a >> separate file. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/Makefile | 1 + >>

[Intel-gfx] ✓ Fi.CI.IGT: success for Add support for LMEM PCIe resizable bar

2022-06-15 Thread Patchwork
== Series Details == Series: Add support for LMEM PCIe resizable bar URL : https://patchwork.freedesktop.org/series/105142/ State : success == Summary == CI Bug Log - changes from CI_DRM_11759_full -> Patchwork_105142v1_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/display: split out verifation, compare and dump from intel_display.c URL : https://patchwork.freedesktop.org/series/105156/ State : success == Summary == CI Bug Log - changes from CI_DRM_11759 -> Patchwork_105156v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/display: split out verifation, compare and dump from intel_display.c URL : https://patchwork.freedesktop.org/series/105156/ State : warning == Summary == Error: dim checkpatch failed e82e76f8105d drm/i915/wm: move wm state verification to intel_pm.c 63ac5

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Patchwork
== Series Details == Series: drm/i915/display: split out verifation, compare and dump from intel_display.c URL : https://patchwork.freedesktop.org/series/105156/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separate

Re: [Intel-gfx] [PATCH 0/7] drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Ville Syrjälä
On Wed, Jun 15, 2022 at 03:47:54PM +0300, Jani Nikula wrote: > The state verification and pipe config comparison/dumping are fairly > isolated pieces of code within intel_display.c. Move them to separate > files in a long overdue cleanup. > > Jani Nikula (7): > drm/i915/wm: move wm state verific

Re: [Intel-gfx] [PATCH 7/7] drm/i915/display: split out pipe config dump to a separate file

2022-06-15 Thread Ville Syrjälä
On Wed, Jun 15, 2022 at 03:48:01PM +0300, Jani Nikula wrote: > Declutter intel_display.c by splitting out pipe config dumping to a > separate file. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/display/intel_display.c | 311

[Intel-gfx] ✓ Fi.CI.BAT: success for Bump up CDCLK for DG2 (rev2)

2022-06-15 Thread Patchwork
== Series Details == Series: Bump up CDCLK for DG2 (rev2) URL : https://patchwork.freedesktop.org/series/105110/ State : success == Summary == CI Bug Log - changes from CI_DRM_11759 -> Patchwork_105110v2 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH 6/7] drm/i915/display: split out pipe config compare to a separate file

2022-06-15 Thread Jani Nikula
Declutter intel_display.c by splitting out pipe config comparison to a separate file. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 571 + drivers/gpu/drm/i915/display/intel_display.h | 3 -

[Intel-gfx] [PATCH 7/7] drm/i915/display: split out pipe config dump to a separate file

2022-06-15 Thread Jani Nikula
Declutter intel_display.c by splitting out pipe config dumping to a separate file. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 311 + drivers/gpu/drm/i915/display/intel_display.h | 3 - .

[Intel-gfx] [PATCH 5/7] drm/i915/display: split out modeset verification code

2022-06-15 Thread Jani Nikula
Add new file intel_modeset_verify.c for high level modeset verification code to declutter intel_display.h. The new file is supposed to be about crtc/encoder/connector verification; the state verification for very specific functionality such as plls or wm should be placed next to the code it verifie

[Intel-gfx] [PATCH 4/7] drm/i915/mpllb: move mpllb state check to intel_snps_phy.c

2022-06-15 Thread Jani Nikula
Keep the mpllb implementation details together in intel_snps_phy.c. Also declutter intel_display.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 46 +-- drivers/gpu/drm/i915/display/intel_snps_phy.c | 43 + drivers/gpu/drm/i915/di

[Intel-gfx] [PATCH 3/7] drm/i915/mpllb: use I915_STATE_WARN() for state mismatch warnings

2022-06-15 Thread Jani Nikula
The pipe_config_mismatch() function is primarily for logging comparison results. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/

[Intel-gfx] [PATCH 2/7] drm/i915/dpll: move shared dpll state verification to intel_dpll_mgr.c

2022-06-15 Thread Jani Nikula
Keep the shared dpll implementation details together by moving the dpll state verification to intel_dpll_mgr.c. Also declutter intel_display.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 94 +-- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 8

[Intel-gfx] [PATCH 1/7] drm/i915/wm: move wm state verification to intel_pm.c

2022-06-15 Thread Jani Nikula
By moving wm state verification to intel_pm.c, we can make a bunch of functions static, hiding the wm details better. Also declutter intel_display.c. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 122 +--- drivers/gpu/drm/i915/intel_pm.c |

[Intel-gfx] [PATCH 0/7] drm/i915/display: split out verifation, compare and dump from intel_display.c

2022-06-15 Thread Jani Nikula
The state verification and pipe config comparison/dumping are fairly isolated pieces of code within intel_display.c. Move them to separate files in a long overdue cleanup. Jani Nikula (7): drm/i915/wm: move wm state verification to intel_pm.c drm/i915/dpll: move shared dpll state verification

[Intel-gfx] ✓ Fi.CI.BAT: success for Do not enable PSR2 if no active planes (rev2)

2022-06-15 Thread Patchwork
== Series Details == Series: Do not enable PSR2 if no active planes (rev2) URL : https://patchwork.freedesktop.org/series/105109/ State : success == Summary == CI Bug Log - changes from CI_DRM_11759 -> Patchwork_105109v2 Summary ---

Re: [Intel-gfx] [RFC PATCH v2 1/1] drm/i915: Replace shmem memory region and object backend with TTM

2022-06-15 Thread Ruhl, Michael J
Hi Adrian, Sorry for the delayed response, this got buried in my inbox... >-Original Message- >From: Adrian Larumbe >Sent: Monday, June 6, 2022 4:20 PM >To: Ruhl, Michael J >Cc: dan...@ffwll.ch; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [RFC PATCH v2 1/1] drm/i915: Repla

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add support for LMEM PCIe resizable bar

2022-06-15 Thread Matthew Auld
On 15/06/2022 06:43, priyanka.dandam...@intel.com wrote: From: Akeem G Abodunrin This patch adds support for the local memory PICe resizable bar, so that local memory can be resized to the maximum size supported by the device, and mapped correctly to the PCIe memory bar. It is usual that GPU de

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add lmem_bar_size modparam

2022-06-15 Thread Matthew Auld
On 15/06/2022 06:43, priyanka.dandam...@intel.com wrote: From: Priyanka Dandamudi lmem_bar_size is used to resize lmem bar. It sets to only one of the supported sizes. Setting this param will be in MB unit. Maybe add some more information here for why we want to add this? Something like: "F

Re: [Intel-gfx] [PATCH 00/15] HuC loading for DG2

2022-06-15 Thread Tvrtko Ursulin
On 15/06/2022 00:15, Ye, Tony wrote: On 6/14/2022 8:30 AM, Ceraolo Spurio, Daniele wrote: On 6/14/2022 12:44 AM, Tvrtko Ursulin wrote: On 13/06/2022 19:13, Ceraolo Spurio, Daniele wrote: On 6/13/2022 10:39 AM, Tvrtko Ursulin wrote: On 13/06/2022 18:06, Ceraolo Spurio, Daniele wrote: On 6/

Re: [Intel-gfx] [RFC v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-15 Thread Tvrtko Ursulin
On 08/06/2022 21:45, Niranjana Vishwanathapura wrote: On Wed, Jun 08, 2022 at 09:54:24AM +0100, Tvrtko Ursulin wrote: On 08/06/2022 09:45, Lionel Landwerlin wrote: On 08/06/2022 11:36, Tvrtko Ursulin wrote: On 08/06/2022 07:40, Lionel Landwerlin wrote: On 03/06/2022 09:53, Niranjana Vishw

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for LMEM PCIe resizable bar

2022-06-15 Thread Patchwork
== Series Details == Series: Add support for LMEM PCIe resizable bar URL : https://patchwork.freedesktop.org/series/105142/ State : success == Summary == CI Bug Log - changes from CI_DRM_11759 -> Patchwork_105142v1 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add support for LMEM PCIe resizable bar

2022-06-15 Thread Patchwork
== Series Details == Series: Add support for LMEM PCIe resizable bar URL : https://patchwork.freedesktop.org/series/105142/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for LMEM PCIe resizable bar

2022-06-15 Thread Patchwork
== Series Details == Series: Add support for LMEM PCIe resizable bar URL : https://patchwork.freedesktop.org/series/105142/ State : warning == Summary == Error: dim checkpatch failed a4fabe36823d drm/i915: Add support for LMEM PCIe resizable bar -:110: CHECK:PARENTHESIS_ALIGNMENT: Alignment sh

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Do not enable PSR2/selective fetch if there are no planes

2022-06-15 Thread Lisovskiy, Stanislav
On Tue, Jun 14, 2022 at 03:55:04PM +0300, Hogander, Jouni wrote: > On Tue, 2022-06-14 at 15:22 +0300, Stanislav Lisovskiy wrote: > > We seem to enable PSR2 and selective fetch even if there are no > > active > > planes. That seems to causes FIFO underruns at least for ADLP. > > Those are gone if we

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Do not enable PSR2/selective fetch if there are no planes

2022-06-15 Thread Lisovskiy, Stanislav
On Tue, Jun 14, 2022 at 03:55:04PM +0300, Hogander, Jouni wrote: > On Tue, 2022-06-14 at 15:22 +0300, Stanislav Lisovskiy wrote: > > We seem to enable PSR2 and selective fetch even if there are no > > active > > planes. That seems to causes FIFO underruns at least for ADLP. > > Those are gone if we

Re: [Intel-gfx] [PATCH 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-15 Thread Tvrtko Ursulin
On 14/06/2022 17:42, Niranjana Vishwanathapura wrote: On Tue, Jun 14, 2022 at 05:07:37PM +0100, Tvrtko Ursulin wrote: On 14/06/2022 17:02, Tvrtko Ursulin wrote: On 14/06/2022 16:43, Niranjana Vishwanathapura wrote: On Tue, Jun 14, 2022 at 08:16:41AM +0100, Tvrtko Ursulin wrote: On 14/06/

Re: [Intel-gfx] [PATCH] i915/pmu: Wire GuC backend to per-client busyness

2022-06-15 Thread Tvrtko Ursulin
On 14/06/2022 17:32, Umesh Nerlige Ramappa wrote: On Tue, Jun 14, 2022 at 02:30:42PM +0100, Tvrtko Ursulin wrote: On 14/06/2022 01:46, Nerlige Ramappa, Umesh wrote: From: John Harrison GuC provides engine_id and last_switch_in ticks for an active context in the pphwsp. The context image p