Re: [Intel-gfx] [PATCH] drm/i915: Fix spelling typo in comment

On 16/06/2022 08:08, 1064094...@qq.com wrote: From: pengfuyuan Fix spelling typo in comment. Reported-by: k2ci Signed-off-by: pengfuyuan --- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_t

Re: [Intel-gfx] [PATCH] drm/i915/gem: remove unused assignments

On 21/06/2022 03:26, Katrin Jo wrote: On Mon, Jun 20, 2022 at 6:19 PM Tvrtko Ursulin wrote: On 20/06/2022 11:02, zys.zlj...@gmail.com wrote: From: katrinzhou The variable ret is reassigned and the value EINVAL is never used. Thus, remove the unused assignments. Addresses-Coverity: ("Unu

[Intel-gfx] [PATCH v3 2/3] drm/i915: Update i915 uapi documentation

Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld --- include/uapi/drm/i915_drm.h | 205 1 file changed, 160 insertions(+), 45 deleti

[Intel-gfx] [PATCH v3 0/3] drm/doc/rfc: i915 VM_BIND feature design + uapi

This is the i915 driver VM_BIND feature design RFC patch series along with the required uapi definition and description of intended use cases. v2: Reduce the scope to simple Mesa use case. Remove all compute related uapi, vm_bind/unbind queue support and only support a timeline out fence i

[Intel-gfx] [PATCH v3 1/3] drm/doc/rfc: VM_BIND feature design document

VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. v3: Expand documentation on dma-resv usage, TLB flushing and execbuf3. Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/rfc/i915_vm_bind.rst | 247

[Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/rfc/i915_vm_bind.h | 243

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: add missing else

== Series Details == Series: drm/i915/gem: add missing else URL : https://patchwork.freedesktop.org/series/105429/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11788_full -> Patchwork_105429v1_full Summary --- **FAI

Re: [Intel-gfx] [PATCH] drm/i915/guc: ADL-N should use the same GuC FW as ADL-S

On 6/21/2022 5:34 PM, Matt Roper wrote: On Tue, Jun 21, 2022 at 04:30:05PM -0700, Daniele Ceraolo Spurio wrote: The only difference between the ADL S and P GuC FWs is the HWConfig support. ADL-N does not support HWConfig, so we should use the same binary as ADL-S, otherwise the GuC might atte

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

Hi all, On Tue, 21 Jun 2022 10:48:17 +0300 Ville Syrjälä wrote: > > On Tue, Jun 21, 2022 at 12:36:56PM +1000, Stephen Rothwell wrote: > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > drivers/gpu/drm/xlnx/zynqmp_disp.c: In fun

Re: [Intel-gfx] [PATCH] drm/i915/guc: ADL-N should use the same GuC FW as ADL-S

On Tue, Jun 21, 2022 at 04:30:05PM -0700, Daniele Ceraolo Spurio wrote: > The only difference between the ADL S and P GuC FWs is the HWConfig > support. ADL-N does not support HWConfig, so we should use the same > binary as ADL-S, otherwise the GuC might attempt to fetch a config > table that does

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

On Sat, 14 May 2022 23:05:06 -0700, Vinay Belgaumkar wrote: > > SLPC min/max frequency updates require H2G calls. We are seeing > timeouts when GuC channel is backed up and it is unable to respond > in a timely fashion causing warnings and affecting CI. > > This is seen when waitboosting happens du

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/bios: debug log ddi port info after parsing

== Series Details == Series: drm/i915/bios: debug log ddi port info after parsing URL : https://patchwork.freedesktop.org/series/105428/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11788_full -> Patchwork_105428v1_full Su

[Intel-gfx] [PATCH] drm/i915/guc: ADL-N should use the same GuC FW as ADL-S

The only difference between the ADL S and P GuC FWs is the HWConfig support. ADL-N does not support HWConfig, so we should use the same binary as ADL-S, otherwise the GuC might attempt to fetch a config table that does not exist. ADL-N is internally identified as an ADL-P, so we need to special-cas

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix spelling typo in comment

== Series Details == Series: drm/i915: Fix spelling typo in comment URL : https://patchwork.freedesktop.org/series/105424/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788_full -> Patchwork_105424v1_full Summary ---

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Add i915_save/load_pci_state helpers

Hi Tilak, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tilak-Tangudu/drm-i915-Add-D3Cold-Off-support-for-runtime-pm/20220621-202453 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915/uapi: tweak error capture on recoverable contexts

Hi Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on linus/master v5.19-rc3 next-20220621] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev6)

== Series Details == Series: drm/i915: ttm for stolen (rev6) URL : https://patchwork.freedesktop.org/series/101396/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11793 -> Patchwork_101396v6 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.IGT: failure for small BAR uapi bits (rev2)

== Series Details == Series: small BAR uapi bits (rev2) URL : https://patchwork.freedesktop.org/series/104369/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11788_full -> Patchwork_104369v2_full Summary --- **FAILURE

Re: [Intel-gfx] [PATCH 3/4] drm/i915/hwmon: Add HWMON power sensor support

On Tue, Jun 21, 2022 at 12:29:21PM -0700, Dixit, Ashutosh wrote: > On Tue, 21 Jun 2022 10:44:21 -0700, Guenter Roeck wrote: > > > > On Mon, Jun 20, 2022 at 11:41:41PM -0700, Dixit, Ashutosh wrote: > > > On Mon, 20 Jun 2022 13:58:49 -0700, Guenter Roeck wrote: > > > Hi Guenter, Thanks for taking a l

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen (rev6)

== Series Details == Series: drm/i915: ttm for stolen (rev6) URL : https://patchwork.freedesktop.org/series/101396/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3)

== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3) URL : https://patchwork.freedesktop.org/series/103837/ State : success == Summary == CI Bug Log - changes from CI_DRM_11793 -> Patchwork_103837v3 ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3)

== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3) URL : https://patchwork.freedesktop.org/series/103837/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked se

[Intel-gfx] [PATCH v8 10/10] drm/i915: stolen memory use ttm backend

refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 - drivers/gpu

[Intel-gfx] [PATCH v8 09/10] drm/i915/ttm: add buffer pin on alloc flag

For situations where allocations need to fail on alloc instead of delayed get_pages, add a new alloc flag to pin the ttm bo. This makes sure that the resource has been allocated during buffer creation, allowing it to fail with an error if the placement is exhausted. This allows existing fallback op

[Intel-gfx] [PATCH v8 08/10] drm/i915: allow memory region creators to alloc and free the region

add callbacks for alloc and free. this allows region creators to allocate any extra storage they may require. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_memory_region.c | 16 +--- drivers/gpu/drm/i915/intel_memory_region.h | 2 ++ 2 files changed, 15 insertions(+),

[Intel-gfx] [PATCH v8 07/10] drm/i915: ttm move/clear logic fix

ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specif

[Intel-gfx] [PATCH v8 06/10] drm/i915: sanitize mem_flags for stolen buffers

Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by: Robert

[Intel-gfx] [PATCH v8 04/10] drm/i915/gem: selftest should not attempt mmap of private regions

During testing make can_mmap consider whether the region is private. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftest

[Intel-gfx] [PATCH v8 05/10] drm/i915: instantiate ttm ranger manager for stolen memory

prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++

[Intel-gfx] [PATCH v8 02/10] drm/i915: limit ttm to dma32 for i965G[M]

i965G[M] cannot relocate objects above 4GiB. Ensure ttm uses dma32 on these systems. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_region_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v8 01/10] drm/i915/ttm: dont trample cache_level overrides during ttm move

Various places within the driver override the default chosen cache_level. Before ttm, these overrides were permanent until explicitly changed again or for the lifetime of the buffer. TTM movement code came along and decided that it could make that decision at that time, which is usually well after

[Intel-gfx] [PATCH v8 03/10] drm/i915/ttm: only trust snooping for dgfx when deciding default cache_level

By default i915_ttm_cache_level() decides I915_CACHE_LLC if HAS_SNOOP. This is divergent from existing backends code which only considers HAS_LLC. Testing shows that trusting snooping on gen5- is unreliable and bsw via ggtt mappings, so limit DGFX for now and maintain previous behaviour. Signed-of

[Intel-gfx] [PATCH v8 00/10] drm/i915: ttm for stolen

This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2 code

Re: [Intel-gfx] [PATCH v2 03/12] drm/i915/uapi: expose the avail tracking

Hi Matthew, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v5.19-rc3 next-20220621] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Add i915_save/load_pci_state helpers

Hi Tilak, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tilak-Tangudu/drm-i915-Add-D3Cold-Off-support-for-runtime-pm/20220621-202453 base: git://anongit.freedesktop.org/drm/drm-tip

Re: [Intel-gfx] [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

On 2022-06-21 11:31:39, Lionel Landwerlin wrote: > On 21/06/2022 13:44, Matthew Auld wrote: > > Add an entry for the new uapi needed for small BAR on DG2+. > > > > v2: > >- Some spelling fixes and other small tweaks. (Akeem & Thomas) > >- Rework error capture interactions, including no long

Re: [Intel-gfx] [PATCH 3/4] drm/i915/hwmon: Add HWMON power sensor support

On Tue, 21 Jun 2022 10:44:21 -0700, Guenter Roeck wrote: > > On Mon, Jun 20, 2022 at 11:41:41PM -0700, Dixit, Ashutosh wrote: > > On Mon, 20 Jun 2022 13:58:49 -0700, Guenter Roeck wrote: > > Hi Guenter, Thanks for taking a look. > > > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-

[Intel-gfx] [PATCH] drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend

From: Umesh Nerlige Ramappa For execlists backend, current implementation of Wa_22011802037 is to stop the CS before doing a reset of the engine. This WA was further extended to wait for any pending MI FORCE WAKEUPs before issuing a reset. Add the extended steps in the execlist path of reset. In

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

On 21/06/2022 18:37, Patchwork wrote: *Patch Details* *Series:* drm/i915: ttm for stolen (rev5) *URL:* https://patchwork.freedesktop.org/series/101396/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchw

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

On 21.6.2022 13.53, Matthew Auld wrote: On Mon, 20 Jun 2022 at 10:38, Juha-Pekka Heikkila wrote: On 10.6.2022 20.43, Matthew Auld wrote: On Fri, 10 Jun 2022 at 15:53, Matthew Auld wrote: On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: From: CQ Tang Display might allocate a sm

Re: [Intel-gfx] [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

On 21/06/2022 13:44, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Th

Re: [Intel-gfx] [PATCH 3/4] drm/i915/hwmon: Add HWMON power sensor support

On Mon, Jun 20, 2022 at 11:41:41PM -0700, Dixit, Ashutosh wrote: > On Mon, 20 Jun 2022 13:58:49 -0700, Guenter Roeck wrote: > > > > Hi Guenter, Thanks for taking a look. > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > > b/Documentation/ABI/testing/sysfs-driver-in

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

== Series Details == Series: drm/i915: ttm for stolen (rev5) URL : https://patchwork.freedesktop.org/series/101396/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11790 -> Patchwork_101396v5 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen (rev5)

== Series Details == Series: drm/i915: ttm for stolen (rev5) URL : https://patchwork.freedesktop.org/series/101396/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915: Call i915_gem_suspend() only after display is turned off

On Fri, 2022-06-17 at 12:28 -0700, Matt Roper wrote: > On Fri, Jun 17, 2022 at 12:06:29PM -0700, José Roberto de Souza wrote: > > Gem buffers could still be in use by display after i915_gem_suspend() > > is executed so there is chances that i915_gem_flush_free_objects() > > will be being executed a

Re: [Intel-gfx] [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

20.06.2022 18:37, Rob Clark пишет: >> +static unsigned long >> +drm_gem_shmem_shrinker_scan_objects(struct shrinker *shrinker, >> + struct shrink_control *sc) >> +{ >> + unsigned long nr_to_scan = sc->nr_to_scan; >> + bool lock_contention = false; >> +

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Add i915_save/load_pci_state helpers

Hi Tilak, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tilak-Tangudu/drm-i915-Add-D3Cold-Off-support-for-runtime-pm/20220621-202453 base: git://anongit.freedesktop.org/drm/drm-tip

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add HWMON support (rev2)

== Series Details == Series: drm/i915: Add HWMON support (rev2) URL : https://patchwork.freedesktop.org/series/104278/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11786_full -> Patchwork_104278v2_full Summary --- *

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev4)

== Series Details == Series: drm/i915: ttm for stolen (rev4) URL : https://patchwork.freedesktop.org/series/101396/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_101396v4 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/fbc: Move flip_pending assignmnt

== Series Details == Series: series starting with [1/2] drm/i915/fbc: Move flip_pending assignmnt URL : https://patchwork.freedesktop.org/series/105383/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11786_full -> Patchwork_105383v1_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen (rev4)

== Series Details == Series: drm/i915: ttm for stolen (rev4) URL : https://patchwork.freedesktop.org/series/101396/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: add missing else

== Series Details == Series: drm/i915/gem: add missing else URL : https://patchwork.freedesktop.org/series/105429/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_105429v1 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2 1/3] drm/doc/rfc: VM_BIND feature design document

On Tue, Jun 21, 2022 at 09:35:16AM +0100, Tvrtko Ursulin wrote: On 20/06/2022 17:29, Niranjana Vishwanathapura wrote: On Mon, Jun 20, 2022 at 11:43:10AM +0100, Tvrtko Ursulin wrote: Hi, On 17/06/2022 06:14, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intende

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Added is_intel_rpm_allowed helper

> -Original Message- > From: Gupta, Anshuman > Sent: Tuesday, June 21, 2022 7:47 PM > To: Tangudu, Tilak ; intel-gfx@lists.freedesktop.org; > Ewins, Jon ; Vivi, Rodrigo ; > Belgaumkar, Vinay ; Wilson, Chris P > ; Dixit, Ashutosh ; > Nilawar, Badal ; Roper, Matthew D > ; Gupta, saurabhg

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Added is_intel_rpm_allowed helper

> -Original Message- > From: Tangudu, Tilak > Sent: Tuesday, June 21, 2022 6:05 PM > To: intel-gfx@lists.freedesktop.org; Ewins, Jon ; Vivi, > Rodrigo ; Belgaumkar, Vinay > ; Wilson, Chris P ; > Dixit, Ashutosh ; Nilawar, Badal > ; Gupta, Anshuman ; > Tangudu, Tilak ; Roper, Matthew D >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: debug log ddi port info after parsing

== Series Details == Series: drm/i915/bios: debug log ddi port info after parsing URL : https://patchwork.freedesktop.org/series/105428/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_105428v1 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add D3Cold-Off support for runtime-pm

== Series Details == Series: drm/i915: Add D3Cold-Off support for runtime-pm URL : https://patchwork.freedesktop.org/series/105427/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/

Re: [Intel-gfx] [PATCH 11/11] drm/i915 : Add D3COLD OFF support

> -Original Message- > From: Tangudu, Tilak > Sent: Tuesday, June 21, 2022 6:05 PM > To: intel-gfx@lists.freedesktop.org; Ewins, Jon ; Vivi, > Rodrigo ; Belgaumkar, Vinay > ; Wilson, Chris P ; > Dixit, Ashutosh ; Nilawar, Badal > ; Gupta, Anshuman ; > Tangudu, Tilak ; Roper, Matthew D >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix spelling typo in comment

== Series Details == Series: drm/i915: Fix spelling typo in comment URL : https://patchwork.freedesktop.org/series/105424/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_105424v1 Summary --- **SUCCE

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2 6/9] tests/i915/query: sanity check the unallocated tracking

On 21/06/2022 13:41, Petri Latvala wrote: On Tue, Jun 21, 2022 at 11:29:58AM +0100, Matthew Auld wrote: Sanity both the unallocated_size & unallocated_cpu_visible_size tracking. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- tests/i915/i915_query.c | 274 +

[Intel-gfx] [CI] drm/i915/gem: add missing else

From: katrinzhou Add missing else in set_proto_ctx_param() to fix coverity issue. Addresses-Coverity: ("Unused value") Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Suggested-by: Tvrtko Ursulin Signed-off-by: katrinzhou [tursulin: fixup alignment

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2 6/9] tests/i915/query: sanity check the unallocated tracking

On Tue, Jun 21, 2022 at 11:29:58AM +0100, Matthew Auld wrote: > Sanity both the unallocated_size & unallocated_cpu_visible_size tracking. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Reviewed-by: Nirmoy Das > --- > tests/i915/i915_query.c | 274 +

[Intel-gfx] [PATCH] drm/i915/bios: debug log ddi port info after parsing

The ddc pin and aux channel sanitization may disable DVI/HDMI and DP, respectively, of ports parsed earlier, in "last one wins" fashion. With parsing and printing interleaved, we'll end up logging support first and disabling later anyway. Now that we've split ddi port info parsing and printing, ta

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Make fastset not suck and allow seamless M/N changes (rev6)

== Series Details == Series: drm/i915: Make fastset not suck and allow seamless M/N changes (rev6) URL : https://patchwork.freedesktop.org/series/103491/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11785_full -> Patchwork_103491v6_full ===

Re: [Intel-gfx] [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

On 6/21/22 12:44, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Tho

[Intel-gfx] [PATCH 11/11] drm/i915 : Add D3COLD OFF support

Added lmem deep suspend/resume, which covers lmem eviction and added GT/GUC deep suspend/resume using i915_gem_backup_suspend, i915_gem_suspend_late and i915_gem_resume. Added HAS_D3COLD_OFF feature macro to use for D3COLD OFF feature Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/i915_d

[Intel-gfx] [PATCH 10/11] drm/i915: Guard rpm helpers at gt_park/unpark

Guard rpm helpers at gt_park/unpark with is_intel_rpm_allowed to guard (gt/engine)_pm_(get/put) Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 9 ++--- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 10 ++ 2 files changed, 12 insertions(+), 7 deletions(-)

[Intel-gfx] [PATCH 09/11] drm/i915: Add i915_save/load_pci_state helpers

Add i915_save/load_pci_state helpers which saves pci config state and restores the saved state. Signed-off-by: Iddamsetty Aravind Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/i915_driver.c | 34 ++ drivers/gpu/drm/i915/i915_drv.h| 1 + 2 files changed,

[Intel-gfx] [PATCH 08/11] drm/i915: Guard rpm helpers in rpm_get/put

Guard rpm helpers in rpm_get/put with is_intel_rpm_allowed to avoid rpm helpers in intel_engine/gt_pm_get/put called from user_forcewake, intel_gt_resume, i915_ttm_accel_move and intel_context_enter/exit_engine Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/intel_wakeref.c | 8 +---

[Intel-gfx] [PATCH 07/11] drm/i915: Guard rc6 helpers with is_intel_rpm_allowed

Guard intel_rc6_sanitize/intel_rc6_enable/intel_rc6_disable rc6 helpers with is_intel_rpm_allowed as these are called in intel_gt_resume/intel_gt_suspend_late. Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/gt/intel_rc6.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-

[Intel-gfx] [PATCH 06/11] drm/i915: Avoid rpm helpers in try_context_registration

Guard rpm helpers in try_context_registration with is_intel_rpm_allowed Avoid rpm helpers in guc_init_engine_stats and rpm helpers not needed at higher level functions. as intel_guc_submission_enable is called from intel_gt_init_hw (which already holds wakeref) Signed-off-by: Tilak Tangudu ---

[Intel-gfx] [PATCH 05/11] drm/i915: Guard rpm helpers in gt helpers functions

Guard rpm helpers in gt_sanitize and intel_gt_set_wedged with is_intel_rpm_allowed Acquire rpm wakeref for higherlevel function i915_gem_resume Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 12 ++-- drivers/gpu/drm/i915/gt/intel_reset.c | 10 +++--- driver

[Intel-gfx] [PATCH 04/11] drm/i915: Added is_intel_rpm_allowed helper

Added is_intel_rpm_allowed function to query the runtime_pm status and disllow during suspending and resuming. Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/intel_runtime_pm.c | 15 +++ drivers/gpu/drm/i915/intel_runtime_pm.h | 1 + 2 files changed, 16 insertions(+) diff --

[Intel-gfx] [PATCH 03/11] drm/i915: Avoid rpm helpers in intel_gt_suspend_late

Removed rpm helpers from intel_gt_suspend_late and added rpm helpers at below high level functions -__intel_gt_disable -live_gt_resume intel_gt_suspend_late is used in i915_gem_suspend_late and i915_gem_suspend_late need to avoid rpm helpers so added rpm helpers at higher level functions -i915_gem

[Intel-gfx] [PATCH 02/11] drm/i915: Avoid rpm helpers in intel_guc_slpc_set_media_ratio_mode

Removed rpm helpers from intel_guc_slpc_set_media_ratio_mode and added rpm helpers at below high level functions. -media_freq_factor_store -intel_guc_slpc_enable via intel_gt_init_hw (already rpm wakeref is hold) Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 2 ++

[Intel-gfx] [PATCH 01/11] drm/i915: Avoid rpm helpers in intel_guc_global_policies_update

1. Removed rpm helpers in intel_guc_global_policies_update and added rpm helpers in below higher level functions, -intel_selftest_modify_policy -intel_selftest_restore_policy -notify_guc -intel_uc_reset_finish calls intel_guc_global_policies_update via intel_guc_submission_reset_finish 2. Removed

[Intel-gfx] [PATCH 00/11] drm/i915: Add D3Cold-Off support for runtime-pm

1. Added D3Cold-Off support for runtime pm for discrete gpu. 2. LMEM is switched off and gpu is in off state in D3Cold-Off so, lmem & GT deep suspend/resume is added. 3. Re-used i915_gem_backup_suspend, i915_gem_suspend_late and i915_gem_resume to handle above 2. 4. These functions use runti

[Intel-gfx] ✓ Fi.CI.BAT: success for small BAR uapi bits (rev2)

== Series Details == Series: small BAR uapi bits (rev2) URL : https://patchwork.freedesktop.org/series/104369/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_104369v2 Summary --- **SUCCESS** No r

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for small BAR uapi bits (rev2)

== Series Details == Series: small BAR uapi bits (rev2) URL : https://patchwork.freedesktop.org/series/104369/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for small BAR uapi bits (rev2)

== Series Details == Series: small BAR uapi bits (rev2) URL : https://patchwork.freedesktop.org/series/104369/ State : warning == Summary == Error: dim checkpatch failed 49aedfbb1bdf drm/doc: add rfc section for small BAR uapi -:43: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), d

Re: [Intel-gfx] [PATCH v2 1/2] vfio: Replace the DMA unmapping notifier with a callback

Reviewed-by: Tony Krowiak On 6/7/22 7:02 PM, Jason Gunthorpe wrote: Instead of having drivers register the notifier with explicit code just have them provide a dma_unmap callback op in their driver ops and rely on the core code to wire it up. Suggested-by: Christoph Hellwig Reviewed-by: Chris

Re: [Intel-gfx] [PATCH v6 04/22] drm/panfrost: Fix shrinker list corruption by madvise IOCTL

Acked-by: Alyssa Rosenzweig On Fri, May 27, 2022 at 02:50:22AM +0300, Dmitry Osipenko wrote: > Calling madvise IOCTL twice on BO causes memory shrinker list corruption > and crashes kernel because BO is already on the list and it's added to > the list again, while BO should be removed from from t

Re: [Intel-gfx] [PATCH v6 22/22] drm/panfrost: Switch to generic memory shrinker

Acked-by: Alyssa Rosenzweig On Fri, May 27, 2022 at 02:50:40AM +0300, Dmitry Osipenko wrote: > Replace Panfrost's memory shrinker with a generic drm-shmem memory > shrinker. > > Tested-by: Steven Price > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/panfrost/Makefile |

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

On Mon, 20 Jun 2022 at 10:38, Juha-Pekka Heikkila wrote: > > On 10.6.2022 20.43, Matthew Auld wrote: > > On Fri, 10 Jun 2022 at 15:53, Matthew Auld > > wrote: > >> > >> On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila > >> wrote: > >>> > >>> From: CQ Tang > >>> > >>> Display might allocate a s

[Intel-gfx] [PATCH v2 12/12] HAX: force small BAR on dg2

Just for CI. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c index 82c3d2d0f0e0..62c3f8185852 100644 --- a/drivers/gpu/d

[Intel-gfx] [PATCH v2 11/12] drm/i915: turn on small BAR support

With the uAPI in place we should now have enough in place to ensure a working system on small BAR configurations. v2: (Nirmoy & Thomas): - s/full BAR/Resizable BAR/ which is hopefully more easily understood by users. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin

[Intel-gfx] [PATCH v2 09/12] drm/i915/selftests: ensure we reserve a fence slot

We should always be explicit and allocate a fence slot before adding a new fence. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin --- drivers/gpu/drm

[Intel-gfx] [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

If the move or clear operation somehow fails, and the memory underneath is not cleared, like when moving to lmem, then we currently fallback to memcpy or memset. However with small-BAR systems this fallback might no longer be possible. For now we use the set_wedged sledgehammer if we ever encounter

[Intel-gfx] [PATCH v2 08/12] drm/i915/uapi: tweak error capture on recoverable contexts

A non-recoverable context must be used if the user wants proper error capture on discrete platforms. In the future the kernel may want to blit the contents of some objects when later doing the capture stage. Also extend to newer integrated platforms. v2(Thomas): - Also extend to newer integrated p

[Intel-gfx] [PATCH v2 07/12] drm/i915/error: skip non-mappable pages

Skip capturing any lmem pages that can't be copied using the CPU. This in now only best effort on platforms that have small BAR. Testcase: igt@gem-exec-capture@capture-invisible Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Da

[Intel-gfx] [PATCH v2 06/12] drm/i915/uapi: add NEEDS_CPU_ACCESS hint

If set, force the allocation to be placed in the mappable portion of I915_MEMORY_CLASS_DEVICE. One big restriction here is that system memory (i.e I915_MEMORY_CLASS_SYSTEM) must be given as a potential placement for the object, that way we can always spill the object into system memory if we can't

[Intel-gfx] [PATCH v2 05/12] drm/i915/uapi: apply ALLOC_GPU_ONLY by default

On small BAR configurations, when dealing with I915_MEMORY_CLASS_DEVICE allocations, we assume that by default, all userspace allocations should be placed in the non-CPU visible portion. Note that dumb buffers are not included here, since these are not "GPU accelerated" and likely need CPU access.

[Intel-gfx] [PATCH v2 04/12] drm/i915: remove intel_memory_region avail

No longer used. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/intel_memory_region.c | 4 +--

[Intel-gfx] [PATCH v2 03/12] drm/i915/uapi: expose the avail tracking

Vulkan would like to have a rough measure of how much device memory can in theory be allocated. Also add unallocated_cpu_visible_size to track the visible portion, in case the device is using small BAR. Also tweak the locking so we nice consistent values for both the mm->avail and the visible track

[Intel-gfx] [PATCH v2 02/12] drm/i915/uapi: add probed_cpu_visible_size

Userspace wants to know the size of CPU visible portion of device local-memory, and on small BAR devices the probed_size is no longer enough. In Vulkan, for example, it would like to know the size in bytes for CPU visible VkMemoryHeap. We already track the io_size for each region, so plumb that thr

[Intel-gfx] [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Thomas) - Add probed_cpu_visible_size. (Lionel

[Intel-gfx] [PATCH v2 00/12] small BAR uapi bits

Test-with: 20220621103001.184373-1-matthew.a...@intel.com IGT: https://patchwork.freedesktop.org/series/104368/#rev2 Mesa: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16739 (WIP) -- 2.36.1

[Intel-gfx] [PATCH i-g-t v2 9/9] lib/i915: request CPU_ACCESS for fb objects

kms_frontbuffer_tracking@basic falls over if the fb needs to be migrated from non-mappable device memory, to the mappable part, due to being temporarily pinned for scanout, when hitting the CPU fault handler, which just gives us SIGBUS. If the device has a small BAR let's attempt to use the mappabl

[Intel-gfx] [PATCH i-g-t v2 7/9] lib/i915/intel_memory_region: plumb through the cpu_size

Will be useful later. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- lib/i915/intel_memory_region.c | 2 ++ lib/i915/intel_memory_region.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/i915/intel_memory_region.c b/lib/i915/intel_memory_region.c index 3

[Intel-gfx] [PATCH i-g-t v2 5/9] tests/i915/query: sanity check the probed_cpu_visible_size

Add some basic sanity checks for this, like checking if this falls within the probed_size. On older kernels the value reported here should be zero. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- tests/i915/i915_query.c | 19 --- 1 file changed, 16

  1   2   >