Re: [Intel-gfx] [RFC PATCH 4/5] drm/i915/display: prepend connector name to the backlight

2022-06-21 Thread Jani Nikula
On Tue, 21 Jun 2022, "Murthy, Arun R" wrote: >> On Fri, 03 Jun 2022, "Murthy, Arun R" wrote: >> >> On Thu, 02 Jun 2022, Animesh Manna >> wrote: >> >> > From: Arun R Murthy >> >> > >> >> > With the enablement of dual eDP, there will have to exist two >> >> > entries of backlight sysfs file. In o

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2022-06-21 Thread Ville Syrjälä
On Tue, Jun 21, 2022 at 12:36:56PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/xlnx/zynqmp_disp.c: In function 'zynqmp_disp_create_planes': > drivers/gpu/drm/xlnx/zynqmp_disp.c

Re: [Intel-gfx] [PATCH v2 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-21 Thread Tvrtko Ursulin
On 20/06/2022 17:29, Niranjana Vishwanathapura wrote: On Mon, Jun 20, 2022 at 11:43:10AM +0100, Tvrtko Ursulin wrote: Hi, On 17/06/2022 06:14, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. si

Re: [Intel-gfx] [PATCH 09/10] drm/i915: turn on small BAR support

2022-06-21 Thread Matthew Auld
On 17/06/2022 13:33, Thomas Hellström wrote: On 5/25/22 20:43, Matthew Auld wrote: With the uAPI in place we should now have enough in place to ensure a working system on small BAR configurations. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc:

Re: [Intel-gfx] [PATCH 09/10] drm/i915: turn on small BAR support

2022-06-21 Thread Das, Nirmoy
On 6/21/2022 10:38 AM, Matthew Auld wrote: On 17/06/2022 13:33, Thomas Hellström wrote: On 5/25/22 20:43, Matthew Auld wrote: With the uAPI in place we should now have enough in place to ensure a working system on small BAR configurations. Signed-off-by: Matthew Auld Cc: Thomas Hellström

Re: [Intel-gfx] [PATCH 09/10] drm/i915: turn on small BAR support

2022-06-21 Thread Thomas Hellström
On Tue, 2022-06-21 at 11:05 +0200, Das, Nirmoy wrote: > > On 6/21/2022 10:38 AM, Matthew Auld wrote: > > On 17/06/2022 13:33, Thomas Hellström wrote: > > > > > > On 5/25/22 20:43, Matthew Auld wrote: > > > > With the uAPI in place we should now have enough in place to > > > > ensure a > > > > wor

Re: [Intel-gfx] [PATCH 01/14] ACPI: video: Add a native function parameter to acpi_video_get_backlight_type()

2022-06-21 Thread Hans de Goede
Hi, On 5/19/22 11:02, Jani Nikula wrote: > On Wed, 18 May 2022, Hans de Goede wrote: >> Hi, >> >> On 5/18/22 10:55, Jani Nikula wrote: >>> On Tue, 17 May 2022, Hans de Goede wrote: ATM on x86 laptops where we want userspace to use the acpi_video backlight device we often register both

Re: [Intel-gfx] [PATCH v5] drm/i915/dsi: add payload receiving code

2022-06-21 Thread Jani Nikula
On Mon, 20 Jun 2022, William Tseng wrote: > To support Host to read data from Peripheral after > a DCS read command is sent over DSI. So the spec isn't all that clear on all the small details here. Since this pretty much doesn't interfere with other code, I'll put more weight on test results. If

[Intel-gfx] [PATCH i-g-t v2 0/9] small BAR uapi bits

2022-06-21 Thread Matthew Auld
-- 2.36.1

[Intel-gfx] [PATCH i-g-t v2 1/9] lib/i915_drm_local: Add I915_GEM_CREATE_EXT_FLAG_NEEDS_CPU_ACCESS

2022-06-21 Thread Matthew Auld
For now dump into i915_drm_local.h. Once the uapi on the kernel side is merged, and is part of drm-next, we can sync the kernel headers and remove this. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- lib/i915/i915_drm_local.h | 21 + 1 file cha

[Intel-gfx] [PATCH i-g-t v2 2/9] lib/i915: wire up optional flags for gem_create_ext

2022-06-21 Thread Matthew Auld
For now limit to direct callers. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- lib/i915/gem_create.c | 9 ++--- lib/i915/gem_create.h | 5 +++-- lib/i915/intel_memory_region.c | 2 +- tests/i915/gem_create.c| 24 --

[Intel-gfx] [PATCH i-g-t v2 3/9] tests/i915/gem_create: exercise NEEDS_CPU_ACCESS

2022-06-21 Thread Matthew Auld
Add some basic tests for this new flag. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- tests/i915/gem_create.c | 309 +++- 1 file changed, 308 insertions(+), 1 deletion(-) diff --git a/tests/i915/gem_create.c b/tests/i915/gem_c

[Intel-gfx] [PATCH i-g-t v2 4/9] lib/i915: add gem_create_with_cpu_access_in_memory_regions

2022-06-21 Thread Matthew Auld
Most users shouldn't care about such an interface, but where required, this should be useful to aid in setting NEEDS_CPU_ACCESS for a given BO. Underneath we try to smooth over needing to provide an explicit SMEM region, or if this is SMEM-only, we don't want the kernel to throw an error. Signed-o

[Intel-gfx] [PATCH i-g-t v2 8/9] tests/i915/capture: handle uapi changes

2022-06-21 Thread Matthew Auld
We should mark the objects that need to be captured with NEEDS_CPU_ACCESS to ensure we can capture them if they are allocated in lmem. We also need to consider that capture only properly works on non-recoverable context, for discrete platforms. We can now also expect CPU invisible objects to be ski

[Intel-gfx] [PATCH i-g-t v2 6/9] tests/i915/query: sanity check the unallocated tracking

2022-06-21 Thread Matthew Auld
Sanity both the unallocated_size & unallocated_cpu_visible_size tracking. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- tests/i915/i915_query.c | 274 +++- 1 file changed, 273 insertions(+), 1 deletion(-) diff --git a/tests/i9

[Intel-gfx] [PATCH i-g-t v2 5/9] tests/i915/query: sanity check the probed_cpu_visible_size

2022-06-21 Thread Matthew Auld
Add some basic sanity checks for this, like checking if this falls within the probed_size. On older kernels the value reported here should be zero. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- tests/i915/i915_query.c | 19 --- 1 file changed, 16

[Intel-gfx] [PATCH i-g-t v2 7/9] lib/i915/intel_memory_region: plumb through the cpu_size

2022-06-21 Thread Matthew Auld
Will be useful later. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- lib/i915/intel_memory_region.c | 2 ++ lib/i915/intel_memory_region.h | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/i915/intel_memory_region.c b/lib/i915/intel_memory_region.c index 3

[Intel-gfx] [PATCH i-g-t v2 9/9] lib/i915: request CPU_ACCESS for fb objects

2022-06-21 Thread Matthew Auld
kms_frontbuffer_tracking@basic falls over if the fb needs to be migrated from non-mappable device memory, to the mappable part, due to being temporarily pinned for scanout, when hitting the CPU fault handler, which just gives us SIGBUS. If the device has a small BAR let's attempt to use the mappabl

[Intel-gfx] [PATCH v2 00/12] small BAR uapi bits

2022-06-21 Thread Matthew Auld
Test-with: 20220621103001.184373-1-matthew.a...@intel.com IGT: https://patchwork.freedesktop.org/series/104368/#rev2 Mesa: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16739 (WIP) -- 2.36.1

[Intel-gfx] [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

2022-06-21 Thread Matthew Auld
Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Thomas) - Add probed_cpu_visible_size. (Lionel

[Intel-gfx] [PATCH v2 02/12] drm/i915/uapi: add probed_cpu_visible_size

2022-06-21 Thread Matthew Auld
Userspace wants to know the size of CPU visible portion of device local-memory, and on small BAR devices the probed_size is no longer enough. In Vulkan, for example, it would like to know the size in bytes for CPU visible VkMemoryHeap. We already track the io_size for each region, so plumb that thr

[Intel-gfx] [PATCH v2 03/12] drm/i915/uapi: expose the avail tracking

2022-06-21 Thread Matthew Auld
Vulkan would like to have a rough measure of how much device memory can in theory be allocated. Also add unallocated_cpu_visible_size to track the visible portion, in case the device is using small BAR. Also tweak the locking so we nice consistent values for both the mm->avail and the visible track

[Intel-gfx] [PATCH v2 04/12] drm/i915: remove intel_memory_region avail

2022-06-21 Thread Matthew Auld
No longer used. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/intel_memory_region.c | 4 +--

[Intel-gfx] [PATCH v2 05/12] drm/i915/uapi: apply ALLOC_GPU_ONLY by default

2022-06-21 Thread Matthew Auld
On small BAR configurations, when dealing with I915_MEMORY_CLASS_DEVICE allocations, we assume that by default, all userspace allocations should be placed in the non-CPU visible portion. Note that dumb buffers are not included here, since these are not "GPU accelerated" and likely need CPU access.

[Intel-gfx] [PATCH v2 06/12] drm/i915/uapi: add NEEDS_CPU_ACCESS hint

2022-06-21 Thread Matthew Auld
If set, force the allocation to be placed in the mappable portion of I915_MEMORY_CLASS_DEVICE. One big restriction here is that system memory (i.e I915_MEMORY_CLASS_SYSTEM) must be given as a potential placement for the object, that way we can always spill the object into system memory if we can't

[Intel-gfx] [PATCH v2 07/12] drm/i915/error: skip non-mappable pages

2022-06-21 Thread Matthew Auld
Skip capturing any lmem pages that can't be copied using the CPU. This in now only best effort on platforms that have small BAR. Testcase: igt@gem-exec-capture@capture-invisible Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Da

[Intel-gfx] [PATCH v2 08/12] drm/i915/uapi: tweak error capture on recoverable contexts

2022-06-21 Thread Matthew Auld
A non-recoverable context must be used if the user wants proper error capture on discrete platforms. In the future the kernel may want to blit the contents of some objects when later doing the capture stage. Also extend to newer integrated platforms. v2(Thomas): - Also extend to newer integrated p

[Intel-gfx] [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

2022-06-21 Thread Matthew Auld
If the move or clear operation somehow fails, and the memory underneath is not cleared, like when moving to lmem, then we currently fallback to memcpy or memset. However with small-BAR systems this fallback might no longer be possible. For now we use the set_wedged sledgehammer if we ever encounter

[Intel-gfx] [PATCH v2 09/12] drm/i915/selftests: ensure we reserve a fence slot

2022-06-21 Thread Matthew Auld
We should always be explicit and allocate a fence slot before adding a new fence. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin Cc: Tvrtko Ursulin Cc: Jon Bloomfield Cc: Daniel Vetter Cc: Jordan Justen Cc: Kenneth Graunke Cc: Akeem G Abodunrin --- drivers/gpu/drm

[Intel-gfx] [PATCH v2 11/12] drm/i915: turn on small BAR support

2022-06-21 Thread Matthew Auld
With the uAPI in place we should now have enough in place to ensure a working system on small BAR configurations. v2: (Nirmoy & Thomas): - s/full BAR/Resizable BAR/ which is hopefully more easily understood by users. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: Lionel Landwerlin

[Intel-gfx] [PATCH v2 12/12] HAX: force small BAR on dg2

2022-06-21 Thread Matthew Auld
Just for CI. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c index 82c3d2d0f0e0..62c3f8185852 100644 --- a/drivers/gpu/d

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-21 Thread Matthew Auld
On Mon, 20 Jun 2022 at 10:38, Juha-Pekka Heikkila wrote: > > On 10.6.2022 20.43, Matthew Auld wrote: > > On Fri, 10 Jun 2022 at 15:53, Matthew Auld > > wrote: > >> > >> On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila > >> wrote: > >>> > >>> From: CQ Tang > >>> > >>> Display might allocate a s

Re: [Intel-gfx] [PATCH v6 04/22] drm/panfrost: Fix shrinker list corruption by madvise IOCTL

2022-06-21 Thread Alyssa Rosenzweig
Acked-by: Alyssa Rosenzweig On Fri, May 27, 2022 at 02:50:22AM +0300, Dmitry Osipenko wrote: > Calling madvise IOCTL twice on BO causes memory shrinker list corruption > and crashes kernel because BO is already on the list and it's added to > the list again, while BO should be removed from from t

Re: [Intel-gfx] [PATCH v6 22/22] drm/panfrost: Switch to generic memory shrinker

2022-06-21 Thread Alyssa Rosenzweig
Acked-by: Alyssa Rosenzweig On Fri, May 27, 2022 at 02:50:40AM +0300, Dmitry Osipenko wrote: > Replace Panfrost's memory shrinker with a generic drm-shmem memory > shrinker. > > Tested-by: Steven Price > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/panfrost/Makefile |

Re: [Intel-gfx] [PATCH v2 1/2] vfio: Replace the DMA unmapping notifier with a callback

2022-06-21 Thread Tony Krowiak
Reviewed-by: Tony Krowiak On 6/7/22 7:02 PM, Jason Gunthorpe wrote: Instead of having drivers register the notifier with explicit code just have them provide a dma_unmap callback op in their driver ops and rely on the core code to wire it up. Suggested-by: Christoph Hellwig Reviewed-by: Chris

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for small BAR uapi bits (rev2)

2022-06-21 Thread Patchwork
== Series Details == Series: small BAR uapi bits (rev2) URL : https://patchwork.freedesktop.org/series/104369/ State : warning == Summary == Error: dim checkpatch failed 49aedfbb1bdf drm/doc: add rfc section for small BAR uapi -:43: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), d

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for small BAR uapi bits (rev2)

2022-06-21 Thread Patchwork
== Series Details == Series: small BAR uapi bits (rev2) URL : https://patchwork.freedesktop.org/series/104369/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for small BAR uapi bits (rev2)

2022-06-21 Thread Patchwork
== Series Details == Series: small BAR uapi bits (rev2) URL : https://patchwork.freedesktop.org/series/104369/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_104369v2 Summary --- **SUCCESS** No r

[Intel-gfx] [PATCH 00/11] drm/i915: Add D3Cold-Off support for runtime-pm

2022-06-21 Thread Tilak Tangudu
1. Added D3Cold-Off support for runtime pm for discrete gpu. 2. LMEM is switched off and gpu is in off state in D3Cold-Off so, lmem & GT deep suspend/resume is added. 3. Re-used i915_gem_backup_suspend, i915_gem_suspend_late and i915_gem_resume to handle above 2. 4. These functions use runti

[Intel-gfx] [PATCH 01/11] drm/i915: Avoid rpm helpers in intel_guc_global_policies_update

2022-06-21 Thread Tilak Tangudu
1. Removed rpm helpers in intel_guc_global_policies_update and added rpm helpers in below higher level functions, -intel_selftest_modify_policy -intel_selftest_restore_policy -notify_guc -intel_uc_reset_finish calls intel_guc_global_policies_update via intel_guc_submission_reset_finish 2. Removed

[Intel-gfx] [PATCH 02/11] drm/i915: Avoid rpm helpers in intel_guc_slpc_set_media_ratio_mode

2022-06-21 Thread Tilak Tangudu
Removed rpm helpers from intel_guc_slpc_set_media_ratio_mode and added rpm helpers at below high level functions. -media_freq_factor_store -intel_guc_slpc_enable via intel_gt_init_hw (already rpm wakeref is hold) Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 2 ++

[Intel-gfx] [PATCH 03/11] drm/i915: Avoid rpm helpers in intel_gt_suspend_late

2022-06-21 Thread Tilak Tangudu
Removed rpm helpers from intel_gt_suspend_late and added rpm helpers at below high level functions -__intel_gt_disable -live_gt_resume intel_gt_suspend_late is used in i915_gem_suspend_late and i915_gem_suspend_late need to avoid rpm helpers so added rpm helpers at higher level functions -i915_gem

[Intel-gfx] [PATCH 04/11] drm/i915: Added is_intel_rpm_allowed helper

2022-06-21 Thread Tilak Tangudu
Added is_intel_rpm_allowed function to query the runtime_pm status and disllow during suspending and resuming. Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/intel_runtime_pm.c | 15 +++ drivers/gpu/drm/i915/intel_runtime_pm.h | 1 + 2 files changed, 16 insertions(+) diff --

[Intel-gfx] [PATCH 05/11] drm/i915: Guard rpm helpers in gt helpers functions

2022-06-21 Thread Tilak Tangudu
Guard rpm helpers in gt_sanitize and intel_gt_set_wedged with is_intel_rpm_allowed Acquire rpm wakeref for higherlevel function i915_gem_resume Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 12 ++-- drivers/gpu/drm/i915/gt/intel_reset.c | 10 +++--- driver

[Intel-gfx] [PATCH 06/11] drm/i915: Avoid rpm helpers in try_context_registration

2022-06-21 Thread Tilak Tangudu
Guard rpm helpers in try_context_registration with is_intel_rpm_allowed Avoid rpm helpers in guc_init_engine_stats and rpm helpers not needed at higher level functions. as intel_guc_submission_enable is called from intel_gt_init_hw (which already holds wakeref) Signed-off-by: Tilak Tangudu ---

[Intel-gfx] [PATCH 07/11] drm/i915: Guard rc6 helpers with is_intel_rpm_allowed

2022-06-21 Thread Tilak Tangudu
Guard intel_rc6_sanitize/intel_rc6_enable/intel_rc6_disable rc6 helpers with is_intel_rpm_allowed as these are called in intel_gt_resume/intel_gt_suspend_late. Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/gt/intel_rc6.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-

[Intel-gfx] [PATCH 08/11] drm/i915: Guard rpm helpers in rpm_get/put

2022-06-21 Thread Tilak Tangudu
Guard rpm helpers in rpm_get/put with is_intel_rpm_allowed to avoid rpm helpers in intel_engine/gt_pm_get/put called from user_forcewake, intel_gt_resume, i915_ttm_accel_move and intel_context_enter/exit_engine Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/intel_wakeref.c | 8 +---

[Intel-gfx] [PATCH 09/11] drm/i915: Add i915_save/load_pci_state helpers

2022-06-21 Thread Tilak Tangudu
Add i915_save/load_pci_state helpers which saves pci config state and restores the saved state. Signed-off-by: Iddamsetty Aravind Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/i915_driver.c | 34 ++ drivers/gpu/drm/i915/i915_drv.h| 1 + 2 files changed,

[Intel-gfx] [PATCH 10/11] drm/i915: Guard rpm helpers at gt_park/unpark

2022-06-21 Thread Tilak Tangudu
Guard rpm helpers at gt_park/unpark with is_intel_rpm_allowed to guard (gt/engine)_pm_(get/put) Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 9 ++--- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 10 ++ 2 files changed, 12 insertions(+), 7 deletions(-)

[Intel-gfx] [PATCH 11/11] drm/i915 : Add D3COLD OFF support

2022-06-21 Thread Tilak Tangudu
Added lmem deep suspend/resume, which covers lmem eviction and added GT/GUC deep suspend/resume using i915_gem_backup_suspend, i915_gem_suspend_late and i915_gem_resume. Added HAS_D3COLD_OFF feature macro to use for D3COLD OFF feature Signed-off-by: Tilak Tangudu --- drivers/gpu/drm/i915/i915_d

Re: [Intel-gfx] [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

2022-06-21 Thread Thomas Hellström
On 6/21/22 12:44, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Tho

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Make fastset not suck and allow seamless M/N changes (rev6)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: Make fastset not suck and allow seamless M/N changes (rev6) URL : https://patchwork.freedesktop.org/series/103491/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11785_full -> Patchwork_103491v6_full ===

[Intel-gfx] [PATCH] drm/i915/bios: debug log ddi port info after parsing

2022-06-21 Thread Jani Nikula
The ddc pin and aux channel sanitization may disable DVI/HDMI and DP, respectively, of ports parsed earlier, in "last one wins" fashion. With parsing and printing interleaved, we'll end up logging support first and disabling later anyway. Now that we've split ddi port info parsing and printing, ta

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2 6/9] tests/i915/query: sanity check the unallocated tracking

2022-06-21 Thread Petri Latvala
On Tue, Jun 21, 2022 at 11:29:58AM +0100, Matthew Auld wrote: > Sanity both the unallocated_size & unallocated_cpu_visible_size tracking. > > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Reviewed-by: Nirmoy Das > --- > tests/i915/i915_query.c | 274 +

[Intel-gfx] [CI] drm/i915/gem: add missing else

2022-06-21 Thread Tvrtko Ursulin
From: katrinzhou Add missing else in set_proto_ctx_param() to fix coverity issue. Addresses-Coverity: ("Unused value") Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Suggested-by: Tvrtko Ursulin Signed-off-by: katrinzhou [tursulin: fixup alignment

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v2 6/9] tests/i915/query: sanity check the unallocated tracking

2022-06-21 Thread Matthew Auld
On 21/06/2022 13:41, Petri Latvala wrote: On Tue, Jun 21, 2022 at 11:29:58AM +0100, Matthew Auld wrote: Sanity both the unallocated_size & unallocated_cpu_visible_size tracking. Signed-off-by: Matthew Auld Cc: Thomas Hellström Reviewed-by: Nirmoy Das --- tests/i915/i915_query.c | 274 +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix spelling typo in comment

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: Fix spelling typo in comment URL : https://patchwork.freedesktop.org/series/105424/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_105424v1 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH 11/11] drm/i915 : Add D3COLD OFF support

2022-06-21 Thread Gupta, Anshuman
> -Original Message- > From: Tangudu, Tilak > Sent: Tuesday, June 21, 2022 6:05 PM > To: intel-gfx@lists.freedesktop.org; Ewins, Jon ; Vivi, > Rodrigo ; Belgaumkar, Vinay > ; Wilson, Chris P ; > Dixit, Ashutosh ; Nilawar, Badal > ; Gupta, Anshuman ; > Tangudu, Tilak ; Roper, Matthew D >

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add D3Cold-Off support for runtime-pm

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: Add D3Cold-Off support for runtime-pm URL : https://patchwork.freedesktop.org/series/105427/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: debug log ddi port info after parsing

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915/bios: debug log ddi port info after parsing URL : https://patchwork.freedesktop.org/series/105428/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_105428v1 Summary

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Added is_intel_rpm_allowed helper

2022-06-21 Thread Gupta, Anshuman
> -Original Message- > From: Tangudu, Tilak > Sent: Tuesday, June 21, 2022 6:05 PM > To: intel-gfx@lists.freedesktop.org; Ewins, Jon ; Vivi, > Rodrigo ; Belgaumkar, Vinay > ; Wilson, Chris P ; > Dixit, Ashutosh ; Nilawar, Badal > ; Gupta, Anshuman ; > Tangudu, Tilak ; Roper, Matthew D >

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Added is_intel_rpm_allowed helper

2022-06-21 Thread Tangudu, Tilak
> -Original Message- > From: Gupta, Anshuman > Sent: Tuesday, June 21, 2022 7:47 PM > To: Tangudu, Tilak ; intel-gfx@lists.freedesktop.org; > Ewins, Jon ; Vivi, Rodrigo ; > Belgaumkar, Vinay ; Wilson, Chris P > ; Dixit, Ashutosh ; > Nilawar, Badal ; Roper, Matthew D > ; Gupta, saurabhg

Re: [Intel-gfx] [PATCH v2 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-21 Thread Niranjana Vishwanathapura
On Tue, Jun 21, 2022 at 09:35:16AM +0100, Tvrtko Ursulin wrote: On 20/06/2022 17:29, Niranjana Vishwanathapura wrote: On Mon, Jun 20, 2022 at 11:43:10AM +0100, Tvrtko Ursulin wrote: Hi, On 17/06/2022 06:14, Niranjana Vishwanathapura wrote: VM_BIND design document with description of intende

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: add missing else

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915/gem: add missing else URL : https://patchwork.freedesktop.org/series/105429/ State : success == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_105429v1 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen (rev4)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev4) URL : https://patchwork.freedesktop.org/series/101396/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/fbc: Move flip_pending assignmnt

2022-06-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/fbc: Move flip_pending assignmnt URL : https://patchwork.freedesktop.org/series/105383/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11786_full -> Patchwork_105383v1_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev4)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev4) URL : https://patchwork.freedesktop.org/series/101396/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11788 -> Patchwork_101396v4 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add HWMON support (rev2)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: Add HWMON support (rev2) URL : https://patchwork.freedesktop.org/series/104278/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11786_full -> Patchwork_104278v2_full Summary --- *

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Add i915_save/load_pci_state helpers

2022-06-21 Thread kernel test robot
Hi Tilak, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tilak-Tangudu/drm-i915-Add-D3Cold-Off-support-for-runtime-pm/20220621-202453 base: git://anongit.freedesktop.org/drm/drm-tip

Re: [Intel-gfx] [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-21 Thread Dmitry Osipenko
20.06.2022 18:37, Rob Clark пишет: >> +static unsigned long >> +drm_gem_shmem_shrinker_scan_objects(struct shrinker *shrinker, >> + struct shrink_control *sc) >> +{ >> + unsigned long nr_to_scan = sc->nr_to_scan; >> + bool lock_contention = false; >> +

Re: [Intel-gfx] [PATCH] drm/i915: Call i915_gem_suspend() only after display is turned off

2022-06-21 Thread Souza, Jose
On Fri, 2022-06-17 at 12:28 -0700, Matt Roper wrote: > On Fri, Jun 17, 2022 at 12:06:29PM -0700, José Roberto de Souza wrote: > > Gem buffers could still be in use by display after i915_gem_suspend() > > is executed so there is chances that i915_gem_flush_free_objects() > > will be being executed a

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen (rev5)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev5) URL : https://patchwork.freedesktop.org/series/101396/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev5) URL : https://patchwork.freedesktop.org/series/101396/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11790 -> Patchwork_101396v5 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 3/4] drm/i915/hwmon: Add HWMON power sensor support

2022-06-21 Thread Guenter Roeck
On Mon, Jun 20, 2022 at 11:41:41PM -0700, Dixit, Ashutosh wrote: > On Mon, 20 Jun 2022 13:58:49 -0700, Guenter Roeck wrote: > > > > Hi Guenter, Thanks for taking a look. > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > > b/Documentation/ABI/testing/sysfs-driver-in

Re: [Intel-gfx] [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

2022-06-21 Thread Lionel Landwerlin
On 21/06/2022 13:44, Matthew Auld wrote: Add an entry for the new uapi needed for small BAR on DG2+. v2: - Some spelling fixes and other small tweaks. (Akeem & Thomas) - Rework error capture interactions, including no longer needing NEEDS_CPU_ACCESS for objects marked for capture. (Th

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Fix i915_vma_pin_iomap()

2022-06-21 Thread Juha-Pekka Heikkila
On 21.6.2022 13.53, Matthew Auld wrote: On Mon, 20 Jun 2022 at 10:38, Juha-Pekka Heikkila wrote: On 10.6.2022 20.43, Matthew Auld wrote: On Fri, 10 Jun 2022 at 15:53, Matthew Auld wrote: On Fri, 10 Jun 2022 at 13:12, Juha-Pekka Heikkila wrote: From: CQ Tang Display might allocate a sm

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev5)

2022-06-21 Thread Robert Beckett
On 21/06/2022 18:37, Patchwork wrote: *Patch Details* *Series:* drm/i915: ttm for stolen (rev5) *URL:* https://patchwork.freedesktop.org/series/101396/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchw

[Intel-gfx] [PATCH] drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend

2022-06-21 Thread Nerlige Ramappa, Umesh
From: Umesh Nerlige Ramappa For execlists backend, current implementation of Wa_22011802037 is to stop the CS before doing a reset of the engine. This WA was further extended to wait for any pending MI FORCE WAKEUPs before issuing a reset. Add the extended steps in the execlist path of reset. In

Re: [Intel-gfx] [PATCH 3/4] drm/i915/hwmon: Add HWMON power sensor support

2022-06-21 Thread Dixit, Ashutosh
On Tue, 21 Jun 2022 10:44:21 -0700, Guenter Roeck wrote: > > On Mon, Jun 20, 2022 at 11:41:41PM -0700, Dixit, Ashutosh wrote: > > On Mon, 20 Jun 2022 13:58:49 -0700, Guenter Roeck wrote: > > Hi Guenter, Thanks for taking a look. > > > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-

Re: [Intel-gfx] [PATCH v2 01/12] drm/doc: add rfc section for small BAR uapi

2022-06-21 Thread Jordan Justen
On 2022-06-21 11:31:39, Lionel Landwerlin wrote: > On 21/06/2022 13:44, Matthew Auld wrote: > > Add an entry for the new uapi needed for small BAR on DG2+. > > > > v2: > >- Some spelling fixes and other small tweaks. (Akeem & Thomas) > >- Rework error capture interactions, including no long

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Add i915_save/load_pci_state helpers

2022-06-21 Thread kernel test robot
Hi Tilak, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Tilak-Tangudu/drm-i915-Add-D3Cold-Off-support-for-runtime-pm/20220621-202453 base: git://anongit.freedesktop.org/drm/drm-tip

Re: [Intel-gfx] [PATCH v2 03/12] drm/i915/uapi: expose the avail tracking

2022-06-21 Thread kernel test robot
Hi Matthew, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v5.19-rc3 next-20220621] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop

[Intel-gfx] [PATCH v8 00/10] drm/i915: ttm for stolen

2022-06-21 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2 code

[Intel-gfx] [PATCH v8 03/10] drm/i915/ttm: only trust snooping for dgfx when deciding default cache_level

2022-06-21 Thread Robert Beckett
By default i915_ttm_cache_level() decides I915_CACHE_LLC if HAS_SNOOP. This is divergent from existing backends code which only considers HAS_LLC. Testing shows that trusting snooping on gen5- is unreliable and bsw via ggtt mappings, so limit DGFX for now and maintain previous behaviour. Signed-of

[Intel-gfx] [PATCH v8 01/10] drm/i915/ttm: dont trample cache_level overrides during ttm move

2022-06-21 Thread Robert Beckett
Various places within the driver override the default chosen cache_level. Before ttm, these overrides were permanent until explicitly changed again or for the lifetime of the buffer. TTM movement code came along and decided that it could make that decision at that time, which is usually well after

[Intel-gfx] [PATCH v8 05/10] drm/i915: instantiate ttm ranger manager for stolen memory

2022-06-21 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++

[Intel-gfx] [PATCH v8 02/10] drm/i915: limit ttm to dma32 for i965G[M]

2022-06-21 Thread Robert Beckett
i965G[M] cannot relocate objects above 4GiB. Ensure ttm uses dma32 on these systems. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_region_ttm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_region_ttm.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v8 04/10] drm/i915/gem: selftest should not attempt mmap of private regions

2022-06-21 Thread Robert Beckett
During testing make can_mmap consider whether the region is private. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftest

[Intel-gfx] [PATCH v8 06/10] drm/i915: sanitize mem_flags for stolen buffers

2022-06-21 Thread Robert Beckett
Stolen regions are not page backed or considered iomem. Prevent flags indicating such. This correctly prevents stolen buffers from attempting to directly map them. See i915_gem_object_has_struct_page() and i915_gem_object_has_iomem() usage for where it would break otherwise. Signed-off-by: Robert

[Intel-gfx] [PATCH v8 07/10] drm/i915: ttm move/clear logic fix

2022-06-21 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specif

[Intel-gfx] [PATCH v8 08/10] drm/i915: allow memory region creators to alloc and free the region

2022-06-21 Thread Robert Beckett
add callbacks for alloc and free. this allows region creators to allocate any extra storage they may require. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/intel_memory_region.c | 16 +--- drivers/gpu/drm/i915/intel_memory_region.h | 2 ++ 2 files changed, 15 insertions(+),

[Intel-gfx] [PATCH v8 09/10] drm/i915/ttm: add buffer pin on alloc flag

2022-06-21 Thread Robert Beckett
For situations where allocations need to fail on alloc instead of delayed get_pages, add a new alloc flag to pin the ttm bo. This makes sure that the resource has been allocated during buffer creation, allowing it to fail with an error if the placement is exhausted. This allows existing fallback op

[Intel-gfx] [PATCH v8 10/10] drm/i915: stolen memory use ttm backend

2022-06-21 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 - drivers/gpu

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3) URL : https://patchwork.freedesktop.org/series/103837/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked se

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915/reset: Add additional steps for Wa_22011802037 for execlist backend (rev3) URL : https://patchwork.freedesktop.org/series/103837/ State : success == Summary == CI Bug Log - changes from CI_DRM_11793 -> Patchwork_103837v3 ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen (rev6)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev6) URL : https://patchwork.freedesktop.org/series/101396/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 3/4] drm/i915/hwmon: Add HWMON power sensor support

2022-06-21 Thread Guenter Roeck
On Tue, Jun 21, 2022 at 12:29:21PM -0700, Dixit, Ashutosh wrote: > On Tue, 21 Jun 2022 10:44:21 -0700, Guenter Roeck wrote: > > > > On Mon, Jun 20, 2022 at 11:41:41PM -0700, Dixit, Ashutosh wrote: > > > On Mon, 20 Jun 2022 13:58:49 -0700, Guenter Roeck wrote: > > > Hi Guenter, Thanks for taking a l

[Intel-gfx] ✗ Fi.CI.IGT: failure for small BAR uapi bits (rev2)

2022-06-21 Thread Patchwork
== Series Details == Series: small BAR uapi bits (rev2) URL : https://patchwork.freedesktop.org/series/104369/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11788_full -> Patchwork_104369v2_full Summary --- **FAILURE

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ttm for stolen (rev6)

2022-06-21 Thread Patchwork
== Series Details == Series: drm/i915: ttm for stolen (rev6) URL : https://patchwork.freedesktop.org/series/101396/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11793 -> Patchwork_101396v6 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH v2 08/12] drm/i915/uapi: tweak error capture on recoverable contexts

2022-06-21 Thread kernel test robot
Hi Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on linus/master v5.19-rc3 next-20220621] [cannot apply to drm-intel/for-linux-next drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note

  1   2   >