Re: [Intel-gfx] [PATCH v5 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Niranjana Vishwanathapura
On Thu, Jun 23, 2022 at 10:32:08PM -0700, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. v4: Remove

[Intel-gfx] [PATCH v5 2/3] drm/i915: Update i915 uapi documentation

2022-06-23 Thread Niranjana Vishwanathapura
Add some missing i915 upai documentation which the new i915 VM_BIND feature documentation will be refer to. Signed-off-by: Niranjana Vishwanathapura Reviewed-by: Matthew Auld --- include/uapi/drm/i915_drm.h | 205 1 file changed, 160 insertions(+), 45

[Intel-gfx] [PATCH v5 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Niranjana Vishwanathapura
VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation and add I915_GEM_VM_BIND/UNBIND_FENCE_VALID and I915_GEM_VM_BIND_TLB_FLUSH flags. v4: Remove I915_GEM_VM_BIND_TLB_FLUSH flag and add additional documentation for

[Intel-gfx] [PATCH v5 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-23 Thread Niranjana Vishwanathapura
VM_BIND design document with description of intended use cases. v2: Reduce the scope to simple Mesa use case. v3: Expand documentation on dma-resv usage, TLB flushing and execbuf3. v4: Remove vm_bind tlb flush request support. v5: Update TLB flushing documentation. Signed-off-by: Niranjana

[Intel-gfx] [PATCH v5 0/3] drm/doc/rfc: i915 VM_BIND feature design + uapi

2022-06-23 Thread Niranjana Vishwanathapura
This is the i915 driver VM_BIND feature design RFC patch series along with the required uapi definition and description of intended use cases. v2: Reduce the scope to simple Mesa use case. Remove all compute related uapi, vm_bind/unbind queue support and only support a timeline out fence

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: Check for Low voltage IO only for eDP

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915/dp: Check for Low voltage IO only for eDP URL : https://patchwork.freedesktop.org/series/105573/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11802 -> Patchwork_105573v1 Summary

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add support for LMEM PCIe resizable bar

2022-06-23 Thread Dandamudi, Priyanka
> -Original Message- > From: Christian König > Sent: 18 June 2022 08:45 PM > To: De Marchi, Lucas ; Bjorn Helgaas > > Cc: linux-...@vger.kernel.org; intel-gfx@lists.freedesktop.org; Sergei > Miroshnichenko ; linux- > ker...@vger.kernel.org; Dandamudi, Priyanka > ; Auld, Matthew > ;

[Intel-gfx] [PATCH] drm/i915/dp: Check for Low voltage IO only for eDP

2022-06-23 Thread Ankit Nautiyal
The low voltage sku check can be ignored as OEMs need to consider that when designing the board and then put any limits in VBT. Due to this check many DP sink that can be run with higher link rate, are run at lower link rate, thereby pruning the resolutions that are intended to be working as per

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc/slpc: Add a new SLPC selftest (rev3)

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Add a new SLPC selftest (rev3) URL : https://patchwork.freedesktop.org/series/105005/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11800 -> Patchwork_105005v3 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc/slpc: Add a new SLPC selftest (rev3)

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915/guc/slpc: Add a new SLPC selftest (rev3) URL : https://patchwork.freedesktop.org/series/105005/ State : warning == Summary == Error: dim checkpatch failed 4982a0bd3fa6 drm/i915/guc/slpc: Add a new SLPC selftest -:13: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-23 Thread Vinay Belgaumkar
This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a test to request for max, but don't fail the test if RP0 is not granted due to throttle reasons. Also

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Add a new SLPC selftest

2022-06-23 Thread Belgaumkar, Vinay
On 6/22/2022 1:32 PM, Dixit, Ashutosh wrote: On Fri, 10 Jun 2022 16:47:12 -0700, Vinay Belgaumkar wrote: This test will validate we can achieve actual frequency of RP0. Pcode grants frequencies based on what GuC is requesting. However, thermal throttling can limit what is being granted. Add a

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Zeng, Oak
Regards, Oak > -Original Message- > From: Intel-gfx On Behalf Of Tvrtko > Ursulin > Sent: June 23, 2022 7:06 AM > To: Landwerlin, Lionel G ; Vishwanathapura, > Niranjana > Cc: Zanoni, Paulo R ; > intel-gfx@lists.freedesktop.org; > dri-de...@lists.freedesktop.org; Hellstrom, Thomas >

Re: [Intel-gfx] [PATCH 03/16] drm/i915: add initial runtime info into device info

2022-06-23 Thread Ville Syrjälä
On Mon, Jun 20, 2022 at 11:38:02AM +0300, Jani Nikula wrote: > Add initial runtime info that we can copy to runtime info at i915 > creation time. This lets us define the initial values for runtime info > statically while making it possible to change them runtime. This will be > the new home for

Re: [Intel-gfx] [PATCH 01/16] drm/i915: use GRAPHICS_VER() instead of accessing match_info directly

2022-06-23 Thread Ville Syrjälä
On Mon, Jun 20, 2022 at 11:37:40AM +0300, Jani Nikula wrote: > We've just set up device info in i915_driver_create() so we can use > GRAPHICS_VER() intead of looking at match_info directly. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_driver.c | 4 +--- > 1 file changed, 1

Re: [Intel-gfx] [PATCH] drm/i915/bios: debug log ddi port info after parsing

2022-06-23 Thread Ville Syrjälä
On Thu, Jun 23, 2022 at 08:04:54PM +0300, Jani Nikula wrote: > On Thu, 23 Jun 2022, Ville Syrjälä wrote: > > On Tue, Jun 21, 2022 at 03:37:32PM +0300, Jani Nikula wrote: > >> The ddc pin and aux channel sanitization may disable DVI/HDMI and DP, > >> respectively, of ports parsed earlier, in "last

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Enable atomic by default on ctg/elk

2022-06-23 Thread Jani Nikula
On Wed, 22 Jun 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > The watermark code for ctg/elk has been atomic ready for a long time > so let's just flip the switch now that some of the last CxSR issues > have been sorted out (which granted was a problem for vlv/chv as well > despite them

Re: [Intel-gfx] [PATCH 0/9] drm/i915: Display info cleanup

2022-06-23 Thread Jani Nikula
On Thu, 23 Jun 2022, Jani Nikula wrote: > On Thu, 23 Jun 2022, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> Collect more stuff under INTEL_INFO->display, and clean up >> some messy stuff in the related register macros. > > Makes me wonder if we should have DISPLAY_INFO(i915) macro that

Re: [Intel-gfx] [PATCH 0/9] drm/i915: Display info cleanup

2022-06-23 Thread Jani Nikula
On Thu, 23 Jun 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Collect more stuff under INTEL_INFO->display, and clean up > some messy stuff in the related register macros. Makes me wonder if we should have DISPLAY_INFO(i915) macro that returns a pointer to the display sub-struct. Anyway,

Re: [Intel-gfx] [PATCH] drm/i915: Call i915_gem_suspend() only after display is turned off

2022-06-23 Thread Matt Roper
On Thu, Jun 23, 2022 at 07:48:32AM -0700, Souza, Jose wrote: > On Wed, 2022-06-22 at 15:19 -0700, Matt Roper wrote: > > On Tue, Jun 21, 2022 at 10:03:04AM -0700, Souza, Jose wrote: > > > On Fri, 2022-06-17 at 12:28 -0700, Matt Roper wrote: > > > > On Fri, Jun 17, 2022 at 12:06:29PM -0700, José

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Added is_intel_rpm_allowed helper

2022-06-23 Thread Jani Nikula
On Thu, 23 Jun 2022, "Tangudu, Tilak" wrote: >> -Original Message- >> From: Vivi, Rodrigo >> Sent: Thursday, June 23, 2022 2:11 AM >> To: Jani Nikula >> Cc: Tangudu, Tilak ; Gupta, Anshuman >> ; intel-gfx@lists.freedesktop.org; Ewins, Jon >> ; Belgaumkar, Vinay ; >> Wilson, Chris P ;

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: stop HPD workers before display driver unregister

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915/display: stop HPD workers before display driver unregister URL : https://patchwork.freedesktop.org/series/105557/ State : success == Summary == CI Bug Log - changes from CI_DRM_11799 -> Patchwork_105557v1

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add D3Cold-Off support for runtime-pm (rev2)

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Add D3Cold-Off support for runtime-pm (rev2) URL : https://patchwork.freedesktop.org/series/105427/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/105427/revisions/2/mbox/ not applied Applying: drm/i915:

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Added is_intel_rpm_allowed helper

2022-06-23 Thread Tangudu, Tilak
> -Original Message- > From: Vivi, Rodrigo > Sent: Thursday, June 23, 2022 2:11 AM > To: Jani Nikula > Cc: Tangudu, Tilak ; Gupta, Anshuman > ; intel-gfx@lists.freedesktop.org; Ewins, Jon > ; Belgaumkar, Vinay ; > Wilson, Chris P ; Dixit, Ashutosh > ; Nilawar, Badal ; > Roper, Matthew

Re: [Intel-gfx] [PATCH] drm/i915/bios: debug log ddi port info after parsing

2022-06-23 Thread Jani Nikula
On Thu, 23 Jun 2022, Ville Syrjälä wrote: > On Tue, Jun 21, 2022 at 03:37:32PM +0300, Jani Nikula wrote: >> The ddc pin and aux channel sanitization may disable DVI/HDMI and DP, >> respectively, of ports parsed earlier, in "last one wins" fashion. With >> parsing and printing interleaved, we'll

Re: [Intel-gfx] [PATCH] GPU: drm: i915: drop unexpected word 'for' in comments

2022-06-23 Thread Jani Nikula
On Thu, 23 Jun 2022, Jiang Jian wrote: > there is an unexpected word 'for' in the comments that need to be dropped While it's also unexpected, it's really *duplicated* word. > file - drivers/gpu/drm/i915/i915_reg.h > line - 2537 > > * Please check the detailed lore in the commit message for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch

2022-06-23 Thread Patchwork
== Series Details == Series: drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch URL : https://patchwork.freedesktop.org/series/105550/ State : success == Summary == CI Bug Log - changes from CI_DRM_11799 -> Patchwork_105550v1

[Intel-gfx] [PATCH 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-06-23 Thread Andrzej Hajda
HPD event after fbdev unregistration can cause registration of deferred fbdev which will not be unregistered later, causing use-after-free. To avoid it HPD handling should be suspended before fbdev unregistration. It should fix following GPF: [272.634530] general protection fault, probably for

[Intel-gfx] [PATCH 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

2022-06-23 Thread Andrzej Hajda
i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst. To avoid re-queuing lets cancel HPD work after intel_dp_mst_suspend. It should fix following WARNINGS: [283.405824] cpu_latency_qos_update_request called for

[Intel-gfx] [PATCH 0/2] drm/i915/display: stop HPD workers before display driver unregister

2022-06-23 Thread Andrzej Hajda
Hi Jani, Ville, This patchset is replacement of patch "drm/i915/display: disable HPD workers before display driver unregister" [1]. Ive decided to split patch into two parts - fbdev and MST, there are different issues. Ive also dropped shutdown path, as it has slightly different requirements, and

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch

2022-06-23 Thread Patchwork
== Series Details == Series: drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch URL : https://patchwork.freedesktop.org/series/105550/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915: Fix a lockdep warning at error capture

2022-06-23 Thread Das, Nirmoy
Hi G.G. On 6/23/2022 5:31 PM, Gwan-gyeong Mun wrote: Commit message and code changes look good to me. Reviewed-by: Gwan-gyeong Mun This is a question about the issue mentioned in this patch, not the patch. The tests (igt@gem_ctx_persistence@legacy-engines-hostile@render) mentioned in this

Re: [Intel-gfx] [PATCH] drm/i915: Fix a lockdep warning at error capture

2022-06-23 Thread Gwan-gyeong Mun
Commit message and code changes look good to me. Reviewed-by: Gwan-gyeong Mun This is a question about the issue mentioned in this patch, not the patch. The tests (igt@gem_ctx_persistence@legacy-engines-hostile@render) mentioned in this issue (

Re: [Intel-gfx] [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

2022-06-23 Thread Matthew Auld
On 23/06/2022 15:52, Christian König wrote: Am 23.06.22 um 16:13 schrieb Matthew Auld: [SNIP] TTM_BO_VM_NUM_PREFAULT); +   /* +    * Ensure we check for any fatal errors if we had to move/clear +    * the object. The device should already be wedged if we hit

[Intel-gfx] [PATCH] drm/fourcc: Document the Intel CCS modifiers' CC plane expected pitch

2022-06-23 Thread Imre Deak
The driver expects the pitch of the Intel CCS CC color planes to be 64 bytes aligned, adjust the modifier descriptions accordingly. Cc: Nanley Chery Signed-off-by: Imre Deak --- include/uapi/drm/drm_fourcc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Call i915_gem_suspend() only after display is turned off

2022-06-23 Thread Souza, Jose
On Wed, 2022-06-22 at 15:19 -0700, Matt Roper wrote: > On Tue, Jun 21, 2022 at 10:03:04AM -0700, Souza, Jose wrote: > > On Fri, 2022-06-17 at 12:28 -0700, Matt Roper wrote: > > > On Fri, Jun 17, 2022 at 12:06:29PM -0700, José Roberto de Souza wrote: > > > > Gem buffers could still be in use by

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Niranjana Vishwanathapura
On Thu, Jun 23, 2022 at 09:27:22AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 17:44, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 04:57:17PM +0100, Tvrtko Ursulin wrote: On 22/06/2022 16:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Niranjana Vishwanathapura
On Thu, Jun 23, 2022 at 12:28:32PM +0300, Lionel Landwerlin wrote: On 22/06/2022 18:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 04:56, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Display info cleanup

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Display info cleanup URL : https://patchwork.freedesktop.org/series/105544/ State : success == Summary == CI Bug Log - changes from CI_DRM_11797 -> Patchwork_105544v1 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

2022-06-23 Thread Matthew Auld
On 23/06/2022 08:00, Thomas Hellström wrote: On Tue, 2022-06-21 at 11:44 +0100, Matthew Auld wrote: If the move or clear operation somehow fails, and the memory underneath is not cleared, like when moving to lmem, then we currently fallback to memcpy or memset. However with small-BAR systems

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Display info cleanup

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Display info cleanup URL : https://patchwork.freedesktop.org/series/105544/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Display info cleanup

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915: Display info cleanup URL : https://patchwork.freedesktop.org/series/105544/ State : warning == Summary == Error: dim checkpatch failed bcf8c9fff0b4 drm/i915: Move dbuf details to INTEL_INFO->display 1822c399b492 drm/i195: Move pipe_offsets[] & co. to

Re: [Intel-gfx] [PATCH] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-06-23 Thread Souza, Jose
On Thu, 2022-06-23 at 13:44 +, Souza, Jose wrote: > On Mon, 2022-05-16 at 15:19 +0800, Hangyu Hua wrote: > > If drm_connector_init fails, intel_connector_free will be called to take > > care of proper free. So it is necessary to drop the refcount of port > > before intel_connector_free. > >

Re: [Intel-gfx] [PATCH] drm: i915: fix a possible refcount leak in intel_dp_add_mst_connector()

2022-06-23 Thread Souza, Jose
On Mon, 2022-05-16 at 15:19 +0800, Hangyu Hua wrote: > If drm_connector_init fails, intel_connector_free will be called to take > care of proper free. So it is necessary to drop the refcount of port > before intel_connector_free. Reviewed-by: José Roberto de Souza > > Fixes: 091a4f91942a

[Intel-gfx] [PATCH 9/9] drm/i915: Move the color stuff under INTEL_INFO->display

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä The LUTs are a display feature so move the details into the display portion of the device info. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 28 drivers/gpu/drm/i915/i915_pci.c| 38 --

[Intel-gfx] [PATCH 8/9] drm/i915: Get rid of XE_LPD_CURSOR_OFFSETS

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä XE_LPD_CURSOR_OFFSETS is a duplicate of TGL_CURSOR_OFFSETS. Just use the latter. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_pci.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c

[Intel-gfx] [PATCH 0/9] drm/i915: Display info cleanup

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä Collect more stuff under INTEL_INFO->display, and clean up some messy stuff in the related register macros. Ville Syrjälä (9): drm/i915: Move dbuf details to INTEL_INFO->display drm/i195: Move pipe_offsets[] & co. to INTEL_INFO->display drm/i915: Move

[Intel-gfx] [PATCH 1/9] drm/i915: Move dbuf details to INTEL_INFO->display

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä DBUF is a display thing, so move it into the display portion of the device info. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.h | 2 +- .../gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/i915_pci.c

[Intel-gfx] [PATCH 7/9] drm/i915: Use _MMIO_PIPE2() where appropriate

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä Stop hand rolling _MMIO_TRANS2() and just use the real thing. Note that this register isn't even used atm, hence why this builds despite the _PIPE2() macro not actually existing. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH 6/9] drm/i915: Use _MMIO_TRANS2() where appropriate

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä Stop hand rolling _MMIO_TRANS2() and just use the real thing. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 5/9] drm/i915: s/_CURSOR2/_MMIO_CURSOR2//

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä The other similar macros have the _MMIO prefix, so give it also to _CURSOR2. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 4/9] drm/i915: Make pipe_offsets[] & co. u32

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä Using a signed type for the register offsets doesn't really make sense. Switch to u32. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_device_info.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 2/9] drm/i195: Move pipe_offsets[] & co. to INTEL_INFO->display

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä The display register offsets are display stuff so stick into the display portion of the device info. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_pci.c | 44 drivers/gpu/drm/i915/i915_reg.h | 18 +-

[Intel-gfx] [PATCH 3/9] drm/i915: Move display_mmio_offset under INTEL_INFO->display

2022-06-23 Thread Ville Syrjala
From: Ville Syrjälä The display register offsets are display stuff so stick into the display portion of the device info. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_pci.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h | 2 +-

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Lionel Landwerlin
On 23/06/2022 14:05, Tvrtko Ursulin wrote: On 23/06/2022 09:57, Lionel Landwerlin wrote: On 23/06/2022 11:27, Tvrtko Ursulin wrote: After a vm_unbind, UMD can re-bind to same VA range against an active VM. Though I am not sue with Mesa usecase if that new mapping is required for running

Re: [Intel-gfx] [PATCH 6/6] drm/i915/gt: Serialize TLB invalidates with GT resets

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:40PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Avoid trying to invalidate the TLB in the middle of performing an > engine reset, as this may result in the reset timing out. Currently, > the TLB invalidate is only serialised by its own

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gt: Serialize GRDOM access between multiple engine resets

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:39PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Don't allow two engines to be reset in parallel, as they would both > try to select a reset bit (and send requests to common registers) > and wait on that register, at the same time.

Re: [Intel-gfx] [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-06-23 Thread Mike Lothian
Hi The buddy allocator is still causing me issues in 5.19-rc3 (https://gitlab.freedesktop.org/drm/amd/-/issues/2059) I'm no longer seeing null pointers though, so I think the bulk move fix did it's bit Let me know if there's anything I can help with, now there aren't freezes I can offer remote

Re: [Intel-gfx] [PATCH 4/6] drm/i915/gt: Only invalidate TLBs exposed to user manipulation

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:38PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Don't flush TLBs when the buffer is only used in the GGTT under full > control of the kernel, as there's no risk of of concurrent access > and stale access from prefetch. > > We only need

Re: [Intel-gfx] [PATCH 3/6] drm/i915/gt: Skip TLB invalidations once wedged

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:37PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > Skip all further TLB invalidations once the device is wedged and > had been reset, as, on such cases, it can no longer process instructions > on the GPU and the user no longer has access to

Re: [Intel-gfx] [PATCH 2/6] drm/i915/gt: Invalidate TLB of the OA unit at TLB invalidations

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:36PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > On gen12 HW, ensure that the TLB of the OA unit is also invalidated > as just invalidating the TLB of an engine is not enough. > > Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Tvrtko Ursulin
On 23/06/2022 09:57, Lionel Landwerlin wrote: On 23/06/2022 11:27, Tvrtko Ursulin wrote: After a vm_unbind, UMD can re-bind to same VA range against an active VM. Though I am not sue with Mesa usecase if that new mapping is required for running GPU job or it will be for the next

Re: [Intel-gfx] [PATCH 1/6] drm/i915/gt: Ignore TLB invalidations on idle engines

2022-06-23 Thread Andi Shyti
Hi Mauro, On Wed, Jun 15, 2022 at 04:27:35PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson > > As an extension of the current skip TLB invalidations, > check if the device is powered down prior to any engine activity, > > as, on such cases, all the TLBs were already invalidated, so

Re: [Intel-gfx] [RFC PATCH v3 02/19] KVM: x86: inhibit APICv/AVIC when the guest and/or host changes apic id/base from the defaults.

2022-06-23 Thread Maxim Levitsky
On Thu, 2022-05-19 at 16:06 +, Sean Christopherson wrote: > On Wed, Apr 27, 2022, Maxim Levitsky wrote: > > Neither of these settings should be changed by the guest and it is > > a burden to support it in the acceleration code, so just inhibit > > it instead. > > > > Also add a boolean

Re: [Intel-gfx] [RFC 2/2] drm/i915/display: add intel_display_features.h for feature check macros

2022-06-23 Thread Ville Syrjälä
On Mon, Jun 20, 2022 at 09:03:51PM +0300, Jani Nikula wrote: > Group widely used display feature check macros together in one place. I was also pondering whether we could pull in the whole INTEL_INFO->display struct definition, but dunno if that would just make a bigger mess of the includes. >

Re: [Intel-gfx] [RFC 1/2] drm/i915/display: spread out HAS_*() feature macros

2022-06-23 Thread Ville Syrjälä
On Mon, Jun 20, 2022 at 09:03:50PM +0300, Jani Nikula wrote: > Expand single-use display feature macros around device info flags > in-place, and remove the macros. > > Move display feature macros used in one file only into that file. I suppose one counter argument would be that it might be

Re: [Intel-gfx] i915: crash with 5.19-rc2

2022-06-23 Thread Zdenek Kabelac
Dne 22. 06. 22 v 22:46 Rodrigo Vivi napsal(a): Hi Zdenek, On Wed, Jun 22, 2022 at 01:18:42PM +0200, Zdenek Kabelac wrote: Hello While somewhat oldish hw (T61, 4G, C2D) - I've now witnessed new crash with Xorg: (happened while reopening iconified Firefox window  - running 'standard' rawhide

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Lionel Landwerlin
On 22/06/2022 18:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 04:56, Niranjana Vishwanathapura wrote: VM_BIND and related uapi definitions v2: Reduce the scope to simple Mesa use case. v3: Expand VM_UNBIND documentation

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: expand on struct drm_edid usage (rev6)

2022-06-23 Thread Patchwork
== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev6) URL : https://patchwork.freedesktop.org/series/104309/ State : success == Summary == CI Bug Log - changes from CI_DRM_11795 -> Patchwork_104309v6 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/bios: debug log ddi port info after parsing

2022-06-23 Thread Ville Syrjälä
On Tue, Jun 21, 2022 at 03:37:32PM +0300, Jani Nikula wrote: > The ddc pin and aux channel sanitization may disable DVI/HDMI and DP, > respectively, of ports parsed earlier, in "last one wins" fashion. With > parsing and printing interleaved, we'll end up logging support first and > disabling

Re: [Intel-gfx] [PATCH] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-06-23 Thread Ville Syrjälä
On Thu, Jun 23, 2022 at 10:27:56AM +0300, Jani Nikula wrote: > Convert all the connectors that use cached connector edid and > detect_edid to drm_edid. > > v3: Don't leak vga switcheroo EDID in LVDS init (Ville) > > v2: Don't leak opregion fallback EDID (Ville) > > Signed-off-by: Jani Nikula

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: expand on struct drm_edid usage (rev6)

2022-06-23 Thread Patchwork
== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev6) URL : https://patchwork.freedesktop.org/series/104309/ State : warning == Summary == Error: dim checkpatch failed 81051dc0bb2d drm/edid: move drm_connector_update_edid_property() to drm_edid.c e87e79e1fff3 drm/edid:

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Lionel Landwerlin
On 23/06/2022 11:27, Tvrtko Ursulin wrote: After a vm_unbind, UMD can re-bind to same VA range against an active VM. Though I am not sue with Mesa usecase if that new mapping is required for running GPU job or it will be for the next submission. But ensuring the tlb flush upon unbind, KMD

Re: [Intel-gfx] [PULL] drm-misc-next

2022-06-23 Thread Jani Nikula
On Thu, 23 Jun 2022, Thomas Zimmermann wrote: > Hi > > Am 23.06.22 um 10:26 schrieb Jani Nikula: >> On Thu, 23 Jun 2022, Thomas Zimmermann wrote: >>> I forgot to mention that we backmerged v5.19-rc2. That's why the list of >>> changed files is so long. >> >> I thought we should only backmerge

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Increase timeout for live_parallel_switch (rev2)

2022-06-23 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Increase timeout for live_parallel_switch (rev2) URL : https://patchwork.freedesktop.org/series/105490/ State : success == Summary == CI Bug Log - changes from CI_DRM_11795 -> Patchwork_105490v2

Re: [Intel-gfx] [PULL] drm-misc-next

2022-06-23 Thread Thomas Zimmermann
Hi Am 23.06.22 um 10:26 schrieb Jani Nikula: On Thu, 23 Jun 2022, Thomas Zimmermann wrote: I forgot to mention that we backmerged v5.19-rc2. That's why the list of changed files is so long. I thought we should only backmerge Linus' tree via backmerging drm-next, which avoids this problem

Re: [Intel-gfx] [PATCH v3 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-23 Thread Tvrtko Ursulin
On 22/06/2022 17:44, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 04:57:17PM +0100, Tvrtko Ursulin wrote: On 22/06/2022 16:12, Niranjana Vishwanathapura wrote: On Wed, Jun 22, 2022 at 09:10:07AM +0100, Tvrtko Ursulin wrote: On 22/06/2022 04:56, Niranjana Vishwanathapura wrote:

Re: [Intel-gfx] [PULL] drm-misc-next

2022-06-23 Thread Jani Nikula
On Thu, 23 Jun 2022, Thomas Zimmermann wrote: > I forgot to mention that we backmerged v5.19-rc2. That's why the list of > changed files is so long. I thought we should only backmerge Linus' tree via backmerging drm-next, which avoids this problem altogether. BR, Jani. -- Jani Nikula, Intel

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: expand on struct drm_edid usage (rev5)

2022-06-23 Thread Patchwork
== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev5) URL : https://patchwork.freedesktop.org/series/104309/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11795 -> Patchwork_104309v5 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use non-blocking H2G for waitboost

2022-06-23 Thread Tvrtko Ursulin
On 22/06/2022 22:28, Dixit, Ashutosh wrote: On Wed, 22 Jun 2022 13:30:23 -0700, Belgaumkar, Vinay wrote: On 6/21/2022 5:26 PM, Dixit, Ashutosh wrote: On Sat, 14 May 2022 23:05:06 -0700, Vinay Belgaumkar wrote: The issue I have is what happens when we de-boost (restore min freq to its

Re: [Intel-gfx] [PATCH v4 1/1] drm/i915/guc: Don't update engine busyness stats too frequently

2022-06-23 Thread Tvrtko Ursulin
On 23/06/2022 03:31, Alan Previn wrote: Using two different types of workoads, it was observed that guc_update_engine_gt_clks was being called too frequently and/or causing a CPU-to-lmem bandwidth hit over PCIE. Details on the workloads and numbers are in the notes below. Background: At the

Re: [Intel-gfx] [PULL] drm-misc-next

2022-06-23 Thread Thomas Zimmermann
Hi Am 23.06.22 um 10:02 schrieb Thomas Zimmermann: Hi Dave and Daniel, here's the drm-misc-next PR for this week. I forgot to mention that we backmerged v5.19-rc2. That's why the list of changed files is so long. Best regards Thomas -- Thomas Zimmermann Graphics Driver Developer SUSE

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: expand on struct drm_edid usage (rev5)

2022-06-23 Thread Patchwork
== Series Details == Series: drm/edid: expand on struct drm_edid usage (rev5) URL : https://patchwork.freedesktop.org/series/104309/ State : warning == Summary == Error: dim checkpatch failed 6703c524e9e9 drm/edid: move drm_connector_update_edid_property() to drm_edid.c 59647b362ac2 drm/edid:

Re: [Intel-gfx] [PATCH v3 08/13] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-06-23 Thread Jani Nikula
On Wed, 22 Jun 2022, Ville Syrjälä wrote: > On Wed, Jun 22, 2022 at 01:59:22PM +0300, Jani Nikula wrote: >> @@ -948,27 +948,30 @@ void intel_lvds_init(struct drm_i915_private *dev_priv) >> * preferred mode is the right one. >> */ >> mutex_lock(>mode_config.mutex); >> -if

[Intel-gfx] [PATCH] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2022-06-23 Thread Jani Nikula
Convert all the connectors that use cached connector edid and detect_edid to drm_edid. v3: Don't leak vga switcheroo EDID in LVDS init (Ville) v2: Don't leak opregion fallback EDID (Ville) Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/intel_connector.c| 4 +-

Re: [Intel-gfx] [PATCH v2 10/12] drm/i915/ttm: handle blitter failure on DG2

2022-06-23 Thread Thomas Hellström
On Tue, 2022-06-21 at 11:44 +0100, Matthew Auld wrote: > If the move or clear operation somehow fails, and the memory > underneath > is not cleared, like when moving to lmem, then we currently fallback > to > memcpy or memset. However with small-BAR systems this fallback might > no > longer be

[Intel-gfx] [PULL] drm-misc-fixes

2022-06-23 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2022-06-23: Multiple fixes in sun4i for suspend, DDC, DMA setup; A rework of vc4 to properly split the driver between hardware capabilities that wasn't done properly causing multiple crashes; and a panel quirk for Aya Neo