== Series Details ==
Series: drm/i915/display: Ensure PSR gets disabled if no encoders in new state
(rev3)
URL : https://patchwork.freedesktop.org/series/106168/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11870 -> Patchwork_106168v3
Change is according to the specs. I see similar thing for DP as well,
and its already taken care in disable DP path,
seems like it was missing only for HDMI.
LGTM.
Reviewed-by: Ankit Nautiyal
On 6/17/2022 4:58 PM, Imre Deak wrote:
Starting with TGL the disabling order of HDMI transcoder
On 2022.07.11 21:24:49 +0100, Mauro Carvalho Chehab wrote:
> Some functions seem to have been renamed without updating the kernel-doc
> markup causing warnings. Also, struct intel_vgpu_dmabuf_obj is not
> properly documented, but has a kerneld-doc markup.
>
> Fix those warnings:
>
On Mon, Jul 11, 2022 at 04:31:49PM -0400, Rodrigo Vivi wrote:
> On Mon, Jul 11, 2022 at 10:26:14AM +0200, Christoph Hellwig wrote:
> > Hi i915 and nouveau maintainers,
> >
> > any chance I could get some help to remove the remaining direct
> > driver calls into swiotlb, namely swiotlb_max_segment
== Series Details ==
Series: drm/i915: fix kernel-doc issues
URL : https://patchwork.freedesktop.org/series/106224/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11870_full -> Patchwork_106224v1_full
Summary
---
== Series Details ==
Series: drm/i915: fix kernel-doc issues
URL : https://patchwork.freedesktop.org/series/106224/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11870 -> Patchwork_106224v1
Summary
---
**SUCCESS**
== Series Details ==
Series: drm/i915: fix kernel-doc issues
URL : https://patchwork.freedesktop.org/series/106224/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: fix kernel-doc issues
URL : https://patchwork.freedesktop.org/series/106224/
State : warning
== Summary ==
Error: dim checkpatch failed
637d83030bc5 drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files
-:117: WARNING:SPACE_BEFORE_TAB: please,
On Mon, Jul 11, 2022 at 10:26:14AM +0200, Christoph Hellwig wrote:
> Hi i915 and nouveau maintainers,
>
> any chance I could get some help to remove the remaining direct
> driver calls into swiotlb, namely swiotlb_max_segment and
> is_swiotlb_active. Either should not matter to a driver as they
This file is licensed with MIT license. Change its license text
to use SPDX.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH 00/32] at:
Some functions seem to have been renamed without updating the kernel-doc
markup causing warnings. Also, struct intel_vgpu_dmabuf_obj is not
properly documented, but has a kerneld-doc markup.
Fix those warnings:
drivers/gpu/drm/i915/gvt/aperture_gm.c:308: warning: expecting
prototype for
There are several trivial warnings there, due to trivial things:
- lack of function name at the kerneldoc markup;
- renamed functions;
- wrong parameter syntax.
Fix such warnings:
drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or
member
There are several trivial warnings there, due to trivial things:
- lack of function name at the kerneldoc markup;
- undocumented structs with kernel-doc markups;
- wrong parameter syntax.
Fix such warnings:
drivers/gpu/drm/i915/gt/intel_context.h:107: warning:
There are several trivial issueson kernel-doc markups at gem:
drivers/gpu/drm/i915/gem/i915_gem_create.c:146: warning: This comment
starts with '/**', but isn't a kernel-doc comment. Refer
Documentation/doc-guide/kernel-doc.rst
drivers/gpu/drm/i915/gem/i915_gem_create.c:217:
The documentation for the flags field is missing there. It sounds
that some last-time change converted some bools into flags, but
the kernel-doc change didn't follow it.
Fix those warnings:
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:135: warning: Function
parameter or member 'flags' not
Kernel-doc dump_flags parameter is missing at i915_capture_error_state().
Document it.
Fixes: a6f0f9cf330a ("drm/i915/guc: Plumb GuC-capture into gpu_coredump")
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
This file is licensed with MIT license. Change its license text
to use SPDX.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH 00/32] at:
The return codes for i915_gem_wait_ioctl() have identation issues,
and will be displayed on a very confusing way. Use lists to improve
its output.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH
Prevent this Sphinx warning:
Documentation/foo/i915:728: ./drivers/gpu/drm/i915/i915_gem.c:447:
WARNING: Inline emphasis start-string without end-string.
By using @data to identify the data field, as expected by kernel-doc.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid
The way it is, it produces this warning:
Documentation/gpu/i915:150:
./drivers/gpu/drm/i915/display/skl_scaler.c:213: WARNING: Block quote ends
without a blank line; unexpected unindent.
Use list markups to suppress the warning.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid
There are some occurrences of "/**" that aren't actually part of
a kernel-doc markup. Replace them by "/*", in order to make easier
to identify what i915 files contain kernel-doc markups.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH 00/32] at:
https://lore.kernel.org/all/cover.1657565224.git.mche...@kernel.org/
drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 ++
Building docs currently produces this warning:
Documentation/foo/i915:159:
./drivers/gpu/drm/i915/i915_scatterlist.h:73: WARNING: Inline strong
start-string without end-string.
That's because @foo evaluates into **foo**, and placing anything
after it without spaces cause Sphinx to warn
There are several documented GT kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH
The doc markup should not end with ":", as it would generate a
warning on Sphinx while generating the cross-reference tag.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH 00/32] at:
Fix those kernel-doc warnings:
drivers/gpu/drm/i915/intel_region_ttm.c:199: warning: Function
parameter or member 'offset' not described in 'intel_region_ttm_resource_alloc'
drivers/gpu/drm/i915/i915_vma_resource.h:123: warning: Function
parameter or member 'wakeref' not
The return code table is not properly marked, causing warnings
and being badly parsed by Sphinx:
Documentation/gpu/i915:130:
./drivers/gpu/drm/i915/display/intel_dp_link_training.c:183: WARNING: Block
quote ends without a blank line; unexpected unindent.
Documentation/gpu/i915:130:
The kernel-doc markup for i915_gem_apply_to_region_ops() has some
issues:
1. The field should be marked as @process_obj;
2. The callback parameters aren't document properly, as sphinx
will consider them to be placed at the wrong place.
Fix (1) and change the way the parameters are described,
There are several documented GEM/TTM kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See
There are several documented GVT kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH
There are other files with kernel-doc markups:
$ git grep -l "/\*\*" $(git ls-files|grep drivers/gpu/drm/i915/)
>kernel-doc-files
$ for i in $(cat kernel-doc-files); do if [ "$(git grep $i
Documentation/)" == "" ]; then echo "$i"; fi; done >aaa
Add them to i915.rst as well.
There are several documented kAPI at the display side that
aren't currently part of the docs. Add them, as this allows
identifying issues with badly-formatted tags.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the
There are several kernel-doc markups along the i915 driver that aren't part
of the i915.rst file, nor are included on any other file under Documentation.
Maybe due to that, there are several kernel-doc markups that report problems
when checked with scripts/kernel-doc. More than that, some of them
There are a couple of issues at i915 display kernel-doc markups:
drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning:
Function parameter or member 'intel_connector' not described in
'intel_connector_debugfs_add'
There are several documented GuC kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH
Two new fields were added to __i915_gem_ttm_object_init() without
their corresponding documentation.
Document them.
Fixes: 9b78b5dade2d ("drm/i915: add i915_gem_object_create_region_at()")
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing
Both intel_runtime_pm.h and intel_pm.c contains kAPI for
runtime PM. So, add them to the documentation.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH 00/32] at:
Building docs currently produces two warnings:
Documentation/foo/i915:71: ./drivers/gpu/drm/i915/i915_vma_resource.c:286:
WARNING: Inline strong start-string without end-string.
Documentation/foo/i915:71: ./drivers/gpu/drm/i915/i915_vma_resource.c:370:
WARNING: Inline strong
We can't use %foo[] as this produces a bad markup.
Use instead, the emphasis markup directly.
Fix this issue:
Documentation/gpu/i915:136:
./drivers/gpu/drm/i915/display/intel_fb.c:280: WARNING: Inline strong
start-string without end-string.
Signed-off-by: Mauro Carvalho Chehab
---
To
The DOC: tag waits for a one-line short title for the doc
section. Using multiple lines will produce a weird output.
So, add a shorter description for the title, while keeping
the current content below it.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of
Two documented functions don't match the kernel-doc comments,
as reported by kernel-doc:
drivers/gpu/drm/i915/intel_wakeref.h:117: warning: expecting prototype
for intel_wakeref_get_if_in_use(). Prototype was for
intel_wakeref_get_if_active() instead
Preserving ascii artwork on kernel-docs is tricky, as it needs
to respect both the Sphinx rules and be properly parsed by
kernel-doc script.
The Sphinx syntax require code-blocks, which is:
::
followed by a blank line and indended lines.
But kernel-doc only works fine if the first and
On Mon, Jul 11, 2022 at 05:11:23PM +0200, Mauro Carvalho Chehab wrote:
> On Mon, 11 Jul 2022 10:06:38 -0400
> Rodrigo Vivi wrote:
>
> > On Mon, Jul 11, 2022 at 08:22:33AM -, Patchwork wrote:
> > >Patch Details
> > >
> > >Series: Fix TLB invalidate issues with Broadwell (rev5)
> > >
Hi Andrzej,
On Fri, Jun 24, 2022 at 01:35:28PM +0200, Andrzej Hajda wrote:
> On some machines hole_end can be small enough to cause subtraction
> overflow. On the other side (addr + 2 * min_alignment) can overflow
> in case of mock tests. This patch should handle both cases.
>
> Fixes:
== Series Details ==
Series: drm/doc/rfc: VM_BIND fix a few grammatical slip-ups and typos
URL : https://patchwork.freedesktop.org/series/106202/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11870 -> Patchwork_106202v1
== Series Details ==
Series: drm/i915/display: Add debug print for scaler filter
URL : https://patchwork.freedesktop.org/series/105954/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11850_full -> Patchwork_105954v1_full
== Series Details ==
Series: drm/i915/display: stop HPD workers before display driver unregister
(rev3)
URL : https://patchwork.freedesktop.org/series/105557/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11870_full -> Patchwork_105557v3_full
On Mon, 11 Jul 2022 10:06:38 -0400
Rodrigo Vivi wrote:
> On Mon, Jul 11, 2022 at 08:22:33AM -, Patchwork wrote:
> >Patch Details
> >
> >Series: Fix TLB invalidate issues with Broadwell (rev5)
> >URL: [1]https://patchwork.freedesktop.org/series/105167/
> >State:
== Series Details ==
Series: drm/i915/display: Add debug print for scaler filter
URL : https://patchwork.freedesktop.org/series/105954/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11850_full -> Patchwork_105954v1_full
== Series Details ==
Series: Fix TLB invalidate issues with Broadwell (rev6)
URL : https://patchwork.freedesktop.org/series/105167/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11870 -> Patchwork_105167v6
Summary
---
== Series Details ==
Series: Fix TLB invalidate issues with Broadwell (rev6)
URL : https://patchwork.freedesktop.org/series/105167/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
== Series Details ==
Series: Fix TLB invalidate issues with Broadwell (rev6)
URL : https://patchwork.freedesktop.org/series/105167/
State : warning
== Summary ==
Error: dim checkpatch failed
abc5913bfada drm/i915/gt: Serialize GRDOM access between multiple engine resets
d9d75927a8fd
== Series Details ==
Series: drm/i915/ttm: fix sg_table construction (rev3)
URL : https://patchwork.freedesktop.org/series/106048/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11870_full -> Patchwork_106048v3_full
Summary
On Mon, Jul 11, 2022 at 07:09:20AM +, Vudum, Lakshminarayana wrote:
> Issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/6169
> Few tests - incomplete - pstore logs, Kernel panic - not syncing: Software
> Watchdog Timer expired, RIP: 0010:cpuidle_enter_state
For a moment I
Just a trivial review of an the vm bind document that is still
an rfc document.
Signed-off-by: Andi Shyti
---
Hi,
I'm not a big fan of this kind of patches, but while reading and
reviewing this document I spotted few potential grammatical fixes.
Andi
Documentation/gpu/rfc/i915_vm_bind.rst |
On Fri, Jul 08, 2022 at 10:40:24AM -0400, Rodrigo Vivi wrote:
> On Fri, Jul 08, 2022 at 04:20:13PM +0200, Karolina Drobnik wrote:
> > From: Chris Wilson
> >
> > One impact of commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove
> > dma_resv workaround") is that it stores many, many more fences.
On Mon, Jul 11, 2022 at 02:17:50PM +0300, Jouni Högander wrote:
> Currently PSR is left enabled when all planes are disabled if there
> is no attached encoder in new state. This seems to be causing FIFO
> underruns.
>
> Fix this by checking if encoder exists in new crtc state and disable
> PSR if
On Mon, Jul 11, 2022 at 08:22:33AM -, Patchwork wrote:
>Patch Details
>
>Series: Fix TLB invalidate issues with Broadwell (rev5)
>URL: [1]https://patchwork.freedesktop.org/series/105167/
>State: failure
>Details:
>
On 7/10/2022 7:29 PM, priyanka.dandam...@intel.com wrote:
From: Priyanka Dandamudi
For testing purposes, support forcing the lmem_bar_size through a new
modparam. In CI we only have a limited number of configurations for DG2,
but we still need to be reasonably sure we get a usable device (also
On 7/10/2022 7:29 PM, priyanka.dandam...@intel.com wrote:
From: Akeem G Abodunrin
Add support for the local memory PICe resizable bar, so that
local memory can be resized to the maximum size supported by the device,
and mapped correctly to the PCIe memory bar. It is usual that GPU
devices
== Series Details ==
Series: drm/i915/display: Ensure PSR gets disabled if no encoders in new state
(rev2)
URL : https://patchwork.freedesktop.org/series/106168/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11870 -> Patchwork_106168v2
== Series Details ==
Series: drm/i915/display: stop HPD workers before display driver unregister
(rev3)
URL : https://patchwork.freedesktop.org/series/105557/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11870 -> Patchwork_105557v3
Ping?
On 30/06/2022 11:35, Lionel Landwerlin wrote:
The recommended number of stackIDs for Ray Tracing subsystem is 512
rather than 2048 (default HW programming).
v2: Move the programming to dg2_ctx_gt_tuning_init() (Lucas)
v3: Move programming to general_render_compute_wa_init() (Matt)
Currently PSR is left enabled when all planes are disabled if there
is no attached encoder in new state. This seems to be causing FIFO
underruns.
Fix this by checking if encoder exists in new crtc state and disable
PSR if it doesn't.
v2: Unify disable logic with existing
Cc: Mika Kahola
== Series Details ==
Series: drm/i915/ttm: fix sg_table construction (rev3)
URL : https://patchwork.freedesktop.org/series/106048/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11870 -> Patchwork_106048v3
Summary
---
== Series Details ==
Series: drm/i915/ttm: fix sg_table construction (rev3)
URL : https://patchwork.freedesktop.org/series/106048/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On 7/11/2022 10:58 AM, Matthew Auld wrote:
If we encounter some monster sized local-memory page that exceeds the
maximum sg length (UINT32_MAX), ensure that don't end up with some
misaligned address in the entry that follows, leading to fireworks
later. Also ensure we have some coverage of
On 08/07/2022 10:41, Dan Carpenter wrote:
The shmem_pin_map() function doesn't return error pointers, it returns
NULL.
Fixes: be1cb55a07bf ("drm/i915/gt: Keep a no-frills swappable copy of the default
context state")
Signed-off-by: Dan Carpenter
Reviewed-by: Matthew Auld
Pushed to
On Mon, Jul 11, 2022 at 09:16:01AM +0300, Jouni Högander wrote:
> Currently PSR is left enabled when all planes are disabled if there
> is no attached encoder in new state. This seems to be causing FIFO
> underruns.
>
> Fix this by checking if old and new crtc encoder masks are differing.
> PSR
If we encounter some monster sized local-memory page that exceeds the
maximum sg length (UINT32_MAX), ensure that don't end up with some
misaligned address in the entry that follows, leading to fireworks
later. Also ensure we have some coverage of this in the selftests.
v2(Chris):
- Use
Hi i915 and nouveau maintainers,
any chance I could get some help to remove the remaining direct
driver calls into swiotlb, namely swiotlb_max_segment and
is_swiotlb_active. Either should not matter to a driver as they
should be written to the DMA API.
In the i915 case it seems like the driver
== Series Details ==
Series: Fix TLB invalidate issues with Broadwell (rev5)
URL : https://patchwork.freedesktop.org/series/105167/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11862 -> Patchwork_105167v5
Summary
---
== Series Details ==
Series: drm/i915/display: Ensure PSR gets disabled if no encoders in new state
URL : https://patchwork.freedesktop.org/series/106168/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11862_full -> Patchwork_106168v1_full
== Series Details ==
Series: Fix TLB invalidate issues with Broadwell (rev5)
URL : https://patchwork.freedesktop.org/series/105167/
State : warning
== Summary ==
Error: dim checkpatch failed
dc7354e61b50 drm/i915/gt: Serialize GRDOM access between multiple engine resets
7c8e464dec21
Issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/6169
Few tests - incomplete - pstore logs, Kernel panic - not syncing: Software
Watchdog Timer expired, RIP: 0010:cpuidle_enter_state
Thanks,
Lakshmi.
-Original Message-
From: Roper, Matthew D
Sent: Friday, July 8,
From: Chris Wilson
Don't allow two engines to be reset in parallel, as they would both
try to select a reset bit (and send requests to common registers)
and wait on that register, at the same time. Serialize control of
the reset requests/acks using the uncore->lock, which will also ensure
that
From: Chris Wilson
Avoid trying to invalidate the TLB in the middle of performing an
engine reset, as this may result in the reset timing out. Currently,
the TLB invalidate is only serialised by its own mutex, forgoing the
uncore lock, but we can take the uncore->lock as well to serialise
the
i915 selftest hangcheck is causing the i915 driver timeouts, as reported
by Intel CI bot:
http://gfx-ci.fi.intel.com/cibuglog-ng/issuefilterassoc/24297?query_key=42a999f48fa6ecce068bc8126c069be7c31153b4
When such test runs, the only output is:
[ 68.811639] i915: Performing live
== Series Details ==
Series: drm/i915/display: Ensure PSR gets disabled if no encoders in new state
URL : https://patchwork.freedesktop.org/series/106168/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11862 -> Patchwork_106168v1
On Fri, 8 Jul 2022 10:31:28 -0400
Rodrigo Vivi wrote:
> On Fri, Jul 08, 2022 at 06:00:52AM -, Patchwork wrote:
> >Patch Details
> >
> >Series: Fix TLB invalidate issues with Broadwell (rev4)
> >URL: [1]https://patchwork.freedesktop.org/series/105167/
> >State: failure
On Fri, 8 Jul 2022 10:29:42 -0400
Rodrigo Vivi wrote:
> On Thu, Jul 07, 2022 at 02:47:57PM -, Patchwork wrote:
> > == Series Details ==
> >
> > Series: Fix TLB invalidate issues with Broadwell (rev4)
> > URL : https://patchwork.freedesktop.org/series/105167/
> > State : warning
> >
> >
Currently PSR is left enabled when all planes are disabled if there
is no attached encoder in new state. This seems to be causing FIFO
underruns.
Fix this by checking if old and new crtc encoder masks are differing.
PSR is disabled for encoders not in new crtc state encoder mask.
Cc: Mika Kahola
== Series Details ==
Series: i915: Introduce Meteorlake
URL : https://patchwork.freedesktop.org/series/106075/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11859_full -> Patchwork_106075v1_full
Summary
---
83 matches
Mail list logo
