[Intel-gfx] ✓ Fi.CI.IGT: success for i915: freq caps and perf_limit_reasons changes for MTL

2022-09-02 Thread Patchwork
== Series Details == Series: i915: freq caps and perf_limit_reasons changes for MTL URL : https://patchwork.freedesktop.org/series/108091/ State : success == Summary == CI Bug Log - changes from CI_DRM_12067_full -> Patchwork_108091v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915: Add "standalone media" support for MTL (rev3)

2022-09-02 Thread Patchwork
== Series Details == Series: i915: Add "standalone media" support for MTL (rev3) URL : https://patchwork.freedesktop.org/series/107908/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12067_full -> Patchwork_107908v3_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Initial Meteorlake Support (rev6)

2022-09-02 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev6) URL : https://patchwork.freedesktop.org/series/106786/ State : success == Summary == CI Bug Log - changes from CI_DRM_12067_full -> Patchwork_106786v6_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for Modify debugfs entry from dsc compressed bpp to input bpc

2022-09-02 Thread Patchwork
== Series Details == Series: Modify debugfs entry from dsc compressed bpp to input bpc URL : https://patchwork.freedesktop.org/series/108087/ State : success == Summary == CI Bug Log - changes from CI_DRM_12067_full -> Patchwork_108087v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: freq caps and perf_limit_reasons changes for MTL

2022-09-02 Thread Patchwork
== Series Details == Series: i915: freq caps and perf_limit_reasons changes for MTL URL : https://patchwork.freedesktop.org/series/108091/ State : success == Summary == CI Bug Log - changes from CI_DRM_12067 -> Patchwork_108091v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: freq caps and perf_limit_reasons changes for MTL

2022-09-02 Thread Patchwork
== Series Details == Series: i915: freq caps and perf_limit_reasons changes for MTL URL : https://patchwork.freedesktop.org/series/108091/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: freq caps and perf_limit_reasons changes for MTL

2022-09-02 Thread Patchwork
== Series Details == Series: i915: freq caps and perf_limit_reasons changes for MTL URL : https://patchwork.freedesktop.org/series/108091/ State : warning == Summary == Error: dim checkpatch failed 8ea5bb04f062 drm/i915: Prepare more multi-GT initialization -:79: CHECK:COMPARISON_TO_NULL:

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Add "standalone media" support for MTL (rev3)

2022-09-02 Thread Patchwork
== Series Details == Series: i915: Add "standalone media" support for MTL (rev3) URL : https://patchwork.freedesktop.org/series/107908/ State : success == Summary == CI Bug Log - changes from CI_DRM_12067 -> Patchwork_107908v3 Summary

[Intel-gfx] [PATCH 3/6] drm/i915/xelpmp: Expose media as another GT

2022-09-02 Thread Ashutosh Dixit
From: Matt Roper Xe_LPM+ platforms have "standalone media." I.e., the media unit is designed as an additional GT with its own engine list, GuC, forcewake, etc. Let's allow platforms to include media GTs in their device info. Cc: Aravind Iddamsetty Signed-off-by: Matt Roper ---

[Intel-gfx] [PATCH 6/6] drm/i915/rps: Freq caps for MTL

2022-09-02 Thread Ashutosh Dixit
For MTL, when reading from HW, RP0, RP1 (actuall RPe) and RPn freq use an entirely different set of registers with different fields, bitwidths and units. Cc: Badal Nilawar Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_rps.c | 20

[Intel-gfx] [PATCH 2/6] drm/i915: Rename and expose common GT early init routine

2022-09-02 Thread Ashutosh Dixit
From: Matt Roper The common early GT init is needed for initialization of all GT types (root/primary, remote tile, standalone media). Since standalone media (coming in the next patch) will be implemented in a separate file, rename and expose the function for use. Signed-off-by: Matt Roper

[Intel-gfx] [PATCH 4/6] drm/i915/debugfs: Add perf_limit_reasons in debugfs

2022-09-02 Thread Ashutosh Dixit
From: Tilak Tangudu Add perf_limit_reasons in debugfs. Unlike the lower 16 perf_limit_reasons status bits, the upper 16 log bits remain set until cleared, thereby ensuring the throttling occurrence is not missed. The clear fop clears the upper 16 log bits, the get fop gets all 32 log and status

[Intel-gfx] [PATCH 5/6] drm/i915/mtl: PERF_LIMIT_REASONS changes for MTL

2022-09-02 Thread Ashutosh Dixit
PERF_LIMIT_REASONS register for MTL media gt is different now. Cc: Badal Nilawar Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_gt.h| 8 drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 6 +++---

[Intel-gfx] [PATCH 0/6] i915: freq caps and perf_limit_reasons changes for MTL

2022-09-02 Thread Ashutosh Dixit
This series includes freq caps and perf_limit_reasons changes for MTL. The series depends on: https://patchwork.freedesktop.org/series/107908/ We have included 3 patches from from the above series as part of this series in order for this series to compile. These are the first 3 patches authored

[Intel-gfx] [PATCH 1/6] drm/i915: Prepare more multi-GT initialization

2022-09-02 Thread Ashutosh Dixit
From: Matt Roper We're going to introduce an additional intel_gt for MTL's media unit soon. Let's provide a bit more multi-GT initialization framework in preparation for that. The initialization will pull the list of GTs for a platform from the device info structure. Although necessary for

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Add "standalone media" support for MTL (rev3)

2022-09-02 Thread Patchwork
== Series Details == Series: i915: Add "standalone media" support for MTL (rev3) URL : https://patchwork.freedesktop.org/series/107908/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Add "standalone media" support for MTL (rev3)

2022-09-02 Thread Patchwork
== Series Details == Series: i915: Add "standalone media" support for MTL (rev3) URL : https://patchwork.freedesktop.org/series/107908/ State : warning == Summary == Error: dim checkpatch failed 37274f1f4068 drm/i915: Move locking and unclaimed check into mmio_debug_{suspend, resume}

[Intel-gfx] [PATCH v2 08/12] drm/i915: Handle each GT on init/release and suspend/resume

2022-09-02 Thread Matt Roper
In preparation for enabling a second GT, there are a number of GT/uncore operations that happen during initialization or suspend flows that need to be performed on each GT, not just the primary, Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_driver.c | 59

[Intel-gfx] [PATCH v2 06/12] drm/i915: Use a DRM-managed action to release the PCI bridge device

2022-09-02 Thread Matt Roper
As we start supporting multiple uncore structures in future patches, the MMIO cleanup (which make also get called mid-init if there's a failure) will become more complicated. Moving to DRM-managed actions will help keep things simple. Signed-off-by: Matt Roper ---

[Intel-gfx] [PATCH v2 12/12] drm/i915/mtl: Hook up interrupts for standalone media

2022-09-02 Thread Matt Roper
Top-level handling of standalone media interrupts will be processed as part of the primary GT's interrupt handler (since primary and media GTs share an MMIO space, unlike remote tile setups). When we get down to the point of handling engine interrupts, we need to take care to lookup VCS and VECS

[Intel-gfx] [PATCH v2 07/12] drm/i915: Initialize MMIO access for each GT

2022-09-02 Thread Matt Roper
In a multi-GT system we need to initialize MMIO access for each GT, not just the primary GT. Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_driver.c | 27 ++- drivers/gpu/drm/i915/intel_uncore.c | 5 -

[Intel-gfx] [PATCH v2 11/12] drm/i915/mtl: Use primary GT's irq lock for media GT

2022-09-02 Thread Matt Roper
When we hook up interrupts (in the next patch), interrupts for the media GT are still processed as part of the primary GT's interrupt flow. As such, we should share the same IRQ lock with the primary GT. Let's convert gt->irq_lock into a pointer and just point the media GT's instance at the same

[Intel-gfx] [PATCH v2 05/12] drm/i915: Rename and expose common GT early init routine

2022-09-02 Thread Matt Roper
The common early GT init is needed for initialization of all GT types (root/primary, remote tile, standalone media). Since standalone media (coming in the next patch) will be implemented in a separate file, rename and expose the function for use. Signed-off-by: Matt Roper Reviewed-by:

[Intel-gfx] [PATCH v2 02/12] drm/i915: Only hook up uncore->debug for primary uncore

2022-09-02 Thread Matt Roper
The original intent of intel_uncore_mmio_debug as described in commit 0a9b26306d6a ("drm/i915: split out uncore_mmio_debug") was to be a singleton structure that could be shared between multiple GTs' uncore objects in a multi-tile system. Somehow we went off track and started allocating separate

[Intel-gfx] [PATCH v2 09/12] drm/i915/uncore: Add GSI offset to uncore

2022-09-02 Thread Matt Roper
GT non-engine registers (referred to as "GSI" registers by the spec) have the same relative offsets on standalone media as they do on the primary GT, just with an additional "GSI offset" added to their MMIO address. If we store this GSI offset in the standalone media's intel_uncore structure, it

[Intel-gfx] [PATCH v2 03/12] drm/i915: Use managed allocations for extra uncore objects

2022-09-02 Thread Matt Roper
We're slowly transitioning the init-time kzalloc's of the driver over to DRM-managed allocations; let's make sure the uncore objects allocated for non-root GTs are thus allocated. Signed-off-by: Matt Roper Reviewed-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/gt/intel_gt.c | 6 ++ 1

[Intel-gfx] [PATCH v2 01/12] drm/i915: Move locking and unclaimed check into mmio_debug_{suspend, resume}

2022-09-02 Thread Matt Roper
Moving the locking for MMIO debug (and the final check for unclaimed accesses when resuming debug after a userspace-initiated forcewake) will make it simpler to completely skip MMIO debug handling on uncores that don't support it in future patches. Signed-off-by: Matt Roper Reviewed-by:

[Intel-gfx] [PATCH v2 04/12] drm/i915: Prepare more multi-GT initialization

2022-09-02 Thread Matt Roper
We're going to introduce an additional intel_gt for MTL's media unit soon. Let's provide a bit more multi-GT initialization framework in preparation for that. The initialization will pull the list of GTs for a platform from the device info structure. Although necessary for the immediate MTL

[Intel-gfx] [PATCH v2 10/12] drm/i915/xelpmp: Expose media as another GT

2022-09-02 Thread Matt Roper
Xe_LPM+ platforms have "standalone media." I.e., the media unit is designed as an additional GT with its own engine list, GuC, forcewake, etc. Let's allow platforms to include media GTs in their device info. v2: - Simplify GSI register handling and split it out to a separate patch for ease

[Intel-gfx] [PATCH v2 00/12] i915: Add "standalone media" support for MTL

2022-09-02 Thread Matt Roper
Starting with MTL, media functionality has moved into a new, second GT at the hardware level. This new GT, referred to as "standalone media" in the spec, has its own GuC, power management/forcewake, etc. The general non-engine GT registers for standalone media start at 0x38, but otherwise

[Intel-gfx] ✗ Fi.CI.IGT: failure for Fixes for damage clips handling (rev3)

2022-09-02 Thread Patchwork
== Series Details == Series: Fixes for damage clips handling (rev3) URL : https://patchwork.freedesktop.org/series/106388/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12066_full -> Patchwork_106388v3_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Initial Meteorlake Support (rev6)

2022-09-02 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev6) URL : https://patchwork.freedesktop.org/series/106786/ State : success == Summary == CI Bug Log - changes from CI_DRM_12067 -> Patchwork_106786v6 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Initial Meteorlake Support (rev6)

2022-09-02 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev6) URL : https://patchwork.freedesktop.org/series/106786/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Initial Meteorlake Support (rev6)

2022-09-02 Thread Patchwork
== Series Details == Series: Initial Meteorlake Support (rev6) URL : https://patchwork.freedesktop.org/series/106786/ State : warning == Summary == Error: dim checkpatch failed 400c5e5c3553 drm/i915: Move display and media IP version to runtime info -:34: CHECK:MACRO_ARG_REUSE: Macro argument

[Intel-gfx] [PATCH v4.1] drm/i915: Move display and media IP version to runtime info

2022-09-02 Thread Radhakrishna Sripada
Future platforms can read the IP version from a register and the IP version numbers need not be hard coded in device info. Move the ip version for media and display to runtime info. On platforms where hard coding of IP version is required, update the IP version in __runtime under device_info.

[Intel-gfx] ✓ Fi.CI.BAT: success for Modify debugfs entry from dsc compressed bpp to input bpc

2022-09-02 Thread Patchwork
== Series Details == Series: Modify debugfs entry from dsc compressed bpp to input bpc URL : https://patchwork.freedesktop.org/series/108087/ State : success == Summary == CI Bug Log - changes from CI_DRM_12067 -> Patchwork_108087v1

Re: [Intel-gfx] [PATCH 1/1] drm/i915/display: convert dsc debugfs entry from output_bpp to input_bpc

2022-09-02 Thread Sharma, Swati2
Thanks Jani for the review comments. Have addressed in v2. On 01-Sep-22 1:41 PM, Jani Nikula wrote: On Wed, 31 Aug 2022, Swati Sharma wrote: With this patch, converting DSC debugfs entry from output_bpp to input_bpc. Please drop phrases like "With this patch", and just use imperative mood,

[Intel-gfx] [v2][PATCH 0/1] Modify debugfs entry from dsc compressed bpp to input bpc

2022-09-02 Thread Swati Sharma
Output dsc compressed bpp debufs entry is changed to input bpc dsc to validate input bpc across various platforms. Test-with: 20220831120849.28883-1-swati2.sha...@intel.com Swati Sharma (1): drm/i915/dsc: convert dsc debugfs entry from output_bpp to input_bpc

[Intel-gfx] [v2][PATCH 1/1] drm/i915/dsc: convert dsc debugfs entry from output_bpp to input_bpc

2022-09-02 Thread Swati Sharma
Convert dsc debugfs entry from output_bpp to input_bpc. The rationale is to validate different input bpc across various platforms. v2: -improved commit message (Jani N) -styling fixes (Jani N) Signed-off-by: Swati Sharma --- .../drm/i915/display/intel_display_debugfs.c | 27

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/vdsc: Set VDSC PIC_HEIGHT before using for DP DSC

2022-09-02 Thread Patchwork
== Series Details == Series: drm/i915/vdsc: Set VDSC PIC_HEIGHT before using for DP DSC URL : https://patchwork.freedesktop.org/series/108076/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12064_full -> Patchwork_108076v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Implement WaEdpLinkRateDataReload

2022-09-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Implement WaEdpLinkRateDataReload URL : https://patchwork.freedesktop.org/series/108063/ State : success == Summary == CI Bug Log - changes from CI_DRM_12064_full -> Patchwork_108063v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for damage clips handling (rev3)

2022-09-02 Thread Patchwork
== Series Details == Series: Fixes for damage clips handling (rev3) URL : https://patchwork.freedesktop.org/series/106388/ State : success == Summary == CI Bug Log - changes from CI_DRM_12066 -> Patchwork_106388v3 Summary ---

Re: [Intel-gfx] [PATCH v4 01/11] drm/i915: Move display and media IP version to runtime info

2022-09-02 Thread kernel test robot
tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Radhakrishna-Sripada/Initial-Meteorlake-Support/20220902-140730 base: git

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes for damage clips handling (rev3)

2022-09-02 Thread Patchwork
== Series Details == Series: Fixes for damage clips handling (rev3) URL : https://patchwork.freedesktop.org/series/106388/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -

Re: [Intel-gfx] [PATCH v4 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-02 Thread Ruhl, Michael J
>-Original Message- >From: Dmitry Osipenko >Sent: Friday, September 2, 2022 6:39 AM >To: Ruhl, Michael J ; Dmitry Osipenko >; Jani Nikula ; >Joonas Lahtinen ; Vivi, Rodrigo >; Tvrtko Ursulin ; >Thomas Hellström ; Christian König >; Chris Wilson >Cc: dri-de...@lists.freedesktop.org;

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Move some of the request decisions out of rps_boost function.

2022-09-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move some of the request decisions out of rps_boost function. URL : https://patchwork.freedesktop.org/series/108048/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12062_full -> Patchwork_108048v1_full

Re: [Intel-gfx] [PATCH linux-next] drm/i915: Remove the unneeded result variables

2022-09-02 Thread Jani Nikula
On Fri, 02 Sep 2022, Jani Nikula wrote: > On Fri, 02 Sep 2022, cgel@gmail.com wrote: >> From: zhang songyi >> >> Return the mul_u32_fixed16() and div_fixed16() directly instead of >> redundant variables. >> >> Reported-by: Zeal Robot >> Signed-off-by: zhang songyi > > NAK. And to explain

Re: [Intel-gfx] [PATCH linux-next] drm/i915: Remove the unneeded result variables

2022-09-02 Thread Jani Nikula
On Fri, 02 Sep 2022, cgel@gmail.com wrote: > From: zhang songyi > > Return the mul_u32_fixed16() and div_fixed16() directly instead of > redundant variables. > > Reported-by: Zeal Robot > Signed-off-by: zhang songyi NAK. BR, Jani. > --- > drivers/gpu/drm/i915/intel_pm.c | 9 +++--

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Add some more VBT version number comments

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Document the VBT version dependency of several other fields. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 76 +-- > 1 file changed, 38 insertions(+), 38 deletions(-)

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Define VBT max HDMI FRL rate bits

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > The VBT gained some bits to inidicate the max FRL rate for > HDMI 2.1, define them. > > These just outright replaced the slave_port bits for ganged eDP. > Apparently that feature was never actually used so someone decided > that

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Add the VBT LTTPR transparent vs. non-transparent bits

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > VBT gained a bit to indicate whether LTTPRs should use transparent > or non-transparent mode. Dunno if we should actually look at this... > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Rename ggtt_view as gtt_view

2022-09-02 Thread Patchwork
== Series Details == Series: drm/i915: Rename ggtt_view as gtt_view URL : https://patchwork.freedesktop.org/series/108045/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12062_full -> Patchwork_108045v1_full Summary ---

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Properly define the DP redriver VBT bits

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Split the DP redriver bytes into bitfields. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 16 +++- > 1 file changed, 11 insertions(+), 5

Re: [Intel-gfx] [PATCH 12/12] drm/i915: Parse DP/eDP max lane count from VBT

2022-09-02 Thread Jani Nikula
On Thu, 01 Sep 2022, Ville Syrjälä wrote: > On Tue, Jul 19, 2022 at 06:39:29AM -0400, Rodrigo Vivi wrote: >> On Fri, Jul 15, 2022 at 11:20:44PM +0300, Ville Syrjala wrote: >> > From: Ville Syrjälä >> > >> > Limit the DP lane count based on the new VBT DP/eDP max >> > lane count field. >> > >>

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Let's avoid even early init if SLPC is used.

2022-09-02 Thread Vivi, Rodrigo
On Fri, 2022-09-02 at 07:16 -0700, Dixit, Ashutosh wrote: > On Fri, 02 Sep 2022 02:51:26 -0700, Rodrigo Vivi wrote: > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c > > b/drivers/gpu/drm/i915/gt/intel_rps.c > > index 6fadde4ee7bf..c29652281f2e 100644 > > ---

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Define VBT eDP/DP max lane count bits

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Since version 244 the VBT can llimt the eDP/DP max lane count. > Add the bits. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +- > 1 file changed, 1

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Let's avoid even early init if SLPC is used.

2022-09-02 Thread Dixit, Ashutosh
On Fri, 02 Sep 2022 02:51:26 -0700, Rodrigo Vivi wrote: > > diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c > b/drivers/gpu/drm/i915/gt/intel_rps.c > index 6fadde4ee7bf..c29652281f2e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_rps.c > +++ b/drivers/gpu/drm/i915/gt/intel_rps.c > @@ -1960,6

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Rename some VBT bits

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > The allow vs. block display switch bits are named rather > inconsistently. Fix it up. WTF on the names. :D > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Define all possible VBT device handles

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > We already have LFP1 and LFP2 device handles define. Just > add all the rest as well. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 9 + > 1 file

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Define more VBT driver features block bits

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Define some additoonal bits in the driver features VBT block. *additional > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 14 ++ > 1 file

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Document the sets of bits in the driver features block

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a few comment documenting the sets of bits in the driver > features block. Might make it a bit easier to check against > the spec. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH 08/11] drm/edid: Use the correct formula for standard timings

2022-09-02 Thread Ville Syrjälä
On Fri, Sep 02, 2022 at 04:41:36PM +0300, Jani Nikula wrote: > On Sat, 27 Aug 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Prefer the timing formula indicated by the range > > descriptor for generating the non-DMT standard timings. > > > > Previously we just used CVT for all EDID

Re: [Intel-gfx] [PATCH 11/12] drm/i915: WARN if a port should use VBT provided vswing tables

2022-09-02 Thread Jani Nikula
On Fri, 15 Jul 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > We don't parse the VBT vswing/preemphassis tables at all currently. > Let's WARN if a port wants to use them so we get a heads up that > whether we really need to implement this stuff or not. My > current stash contains no VBTs

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp_mst: Fix mst_mgr lookup during atomic check

2022-09-02 Thread Imre Deak
On Fri, Sep 02, 2022 at 12:03:23PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp_mst: Fix mst_mgr lookup during atomic check > URL : https://patchwork.freedesktop.org/series/108040/ > State : success Thanks for the review, pushed to drm-misc-next. > > == Summary == >

Re: [Intel-gfx] [PATCH 01/11] drm/edid: Handle EDID 1.4 range descriptor h/vfreq offsets

2022-09-02 Thread Ville Syrjälä
On Fri, Aug 26, 2022 at 06:40:12PM -0700, Navare, Manasi wrote: > On Sat, Aug 27, 2022 at 12:34:51AM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > EDID 1.4 introduced some extra flags in the range > > descriptor to support min/max h/vfreq >= 255. Consult them > > to correctly parse

Re: [Intel-gfx] [PATCH 08/11] drm/edid: Use the correct formula for standard timings

2022-09-02 Thread Jani Nikula
On Sat, 27 Aug 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Prefer the timing formula indicated by the range > descriptor for generating the non-DMT standard timings. > > Previously we just used CVT for all EDID 1.4 continuous > frequency displays without even checking if the range >

Re: [Intel-gfx] [PATCH v5 11/31] drm/i915: Call acpi_video_register_backlight() (v3)

2022-09-02 Thread Jani Nikula
On Thu, 25 Aug 2022, Hans de Goede wrote: > On machins without an i915 opregion the acpi_video driver immediately > probes the ACPI video bus and used to also immediately register > acpi_video# backlight devices when supported. > > Once the drm/kms driver then loaded later and possibly registered

Re: [Intel-gfx] [PATCH 07/11] drm/edid: Use GTF2 for inferred modes

2022-09-02 Thread Ville Syrjälä
On Fri, Sep 02, 2022 at 03:25:39PM +0300, Jani Nikula wrote: > On Sat, 27 Aug 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > For some resaon we only use the secondary GTF curve for the > > standard timings. Use it for inferred modes as well. > > > > Signed-off-by: Ville Syrjälä > >

Re: [Intel-gfx] [PATCH 10/11] drm/edid: Make version checks less convoluted

2022-09-02 Thread Jani Nikula
On Sat, 27 Aug 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Get rid of the confusing version_greater() stuff and > simply compare edid->revision directly everwhere. Half > the places already did it this way, and since we actually > reject any EDID with edid->version!=1 it's a perfectly >

Re: [Intel-gfx] [PATCH 09/11] drm/edid: Unconfuse preferred timing stuff a bit

2022-09-02 Thread Jani Nikula
On Sat, 27 Aug 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > For EDID 1.4 the first detailed timing is always preferred, > for older EDIDs there was a feature flag to indicate the same. > While correct, the code setting that up is rather confusing. > Restate it in a slightly more

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev3)

2022-09-02 Thread Patchwork
== Series Details == Series: drm/i915/ttm: Abort suspend on i915_ttm_backup failure (rev3) URL : https://patchwork.freedesktop.org/series/107877/ State : success == Summary == CI Bug Log - changes from CI_DRM_12061_full -> Patchwork_107877v3_full

Re: [Intel-gfx] [PATCH 07/11] drm/edid: Use GTF2 for inferred modes

2022-09-02 Thread Jani Nikula
On Sat, 27 Aug 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > For some resaon we only use the secondary GTF curve for the > standard timings. Use it for inferred modes as well. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 35 ++- >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp_mst: Fix mst_mgr lookup during atomic check

2022-09-02 Thread Patchwork
== Series Details == Series: drm/i915/dp_mst: Fix mst_mgr lookup during atomic check URL : https://patchwork.freedesktop.org/series/108040/ State : success == Summary == CI Bug Log - changes from CI_DRM_12061_full -> Patchwork_108040v1_full

Re: [Intel-gfx] [PATCH] drm/i915/vdsc: Set VDSC PIC_HEIGHT before using for DP DSC

2022-09-02 Thread Kulkarni, Vandita
> -Original Message- > From: Nautiyal, Ankit K > Sent: Friday, September 2, 2022 4:02 PM > To: intel-gfx@lists.freedesktop.org > Cc: Navare, Manasi D ; Kulkarni, Vandita > ; Roper, Matthew D > > Subject: [PATCH] drm/i915/vdsc: Set VDSC PIC_HEIGHT before using for DP > DSC > > Currently,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vdsc: Set VDSC PIC_HEIGHT before using for DP DSC

2022-09-02 Thread Patchwork
== Series Details == Series: drm/i915/vdsc: Set VDSC PIC_HEIGHT before using for DP DSC URL : https://patchwork.freedesktop.org/series/108076/ State : success == Summary == CI Bug Log - changes from CI_DRM_12064 -> Patchwork_108076v1

Re: [Intel-gfx] [PATCH 2/2] drm/i915/bios: Use hardcoded fp_timing size for generating LFP data pointers

2022-09-02 Thread Ville Syrjälä
On Fri, Sep 02, 2022 at 02:12:50PM +0300, Jani Nikula wrote: > On Thu, 18 Aug 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The current scheme for generating the LFP data table pointers > > (when the block including them is missing from the VBT) expects > > the 0x sequence to

Re: [Intel-gfx] [PATCH v7 1/3] drm/i915/hpd: suspend MST at the end of intel_modeset_driver_remove

2022-09-02 Thread Imre Deak
On Fri, Aug 26, 2022 at 04:19:27PM +0200, Andrzej Hajda wrote: > i915->hotplug.dig_port_work can be queued from intel_hpd_irq_handler > called by IRQ handler or by intel_hpd_trigger_irq called from dp_mst. > Since dp_mst is suspended after irq handler uninstall, a cleaner approach > is to cancel

Re: [Intel-gfx] [PATCH 2/2] drm/i915/bios: Use hardcoded fp_timing size for generating LFP data pointers

2022-09-02 Thread Jani Nikula
On Thu, 18 Aug 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > The current scheme for generating the LFP data table pointers > (when the block including them is missing from the VBT) expects > the 0x sequence to only appear in the fp_timing terminator > entries. However some VBTs also

Re: [Intel-gfx] [PATCH v2 4/4] drm/tests: Set also mock plane src_x, src_y, src_w and src_h

2022-09-02 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Tuesday, August 23, 2022 2:29 PM > To: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 4/4] drm/tests: Set also mock plane src_x, > src_y, > src_w and src_h > >

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Use drm helper instead of own loop for damage clips

2022-09-02 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Tuesday, August 23, 2022 2:29 PM > To: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 3/4] drm/i915/display: Use drm helper instead > of > own loop for damage

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bios: Validate fp_timing terminator presence

2022-09-02 Thread Ville Syrjälä
On Fri, Sep 02, 2022 at 01:47:14PM +0300, Jani Nikula wrote: > On Thu, 18 Aug 2022, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Validate the LFP data block a bit hardwer by making sure the > > fp_timing terminators (0x) are where we expect them to be. > > > > Signed-off-by: Ville

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/display: Use original src in psr2 sel fetch area calculation

2022-09-02 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Jouni > Högander > Sent: Tuesday, August 23, 2022 2:29 PM > To: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 2/4] drm/i915/display: Use original src in > psr2 sel > fetch area

Re: [Intel-gfx] [PATCH v2 1/4] drm: Use original src rect while initializing damage iterator

2022-09-02 Thread Kahola, Mika
> -Original Message- > From: dri-devel On Behalf Of Jouni > Högander > Sent: Tuesday, August 23, 2022 2:29 PM > To: dri-de...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Cc: Hogander, Jouni > Subject: [PATCH v2 1/4] drm: Use original src rect while initializing damage >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Don't try to disable host RPS when this was never enabled.

2022-09-02 Thread Das, Nirmoy
LGTM the series is: Acked-by: Nirmoy Das On 9/2/2022 11:51 AM, Rodrigo Vivi wrote: Specially in GT reset case this could be triggered and try to disable things that had never been enabled. Let's add some protection here. Cc: Ashutosh Dixit Signed-off-by: Rodrigo Vivi Reviewed-by: Ashutosh

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bios: Validate fp_timing terminator presence

2022-09-02 Thread Jani Nikula
On Thu, 18 Aug 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Validate the LFP data block a bit hardwer by making sure the > fp_timing terminators (0x) are where we expect them to be. > > Signed-off-by: Ville Syrjälä I wonder if it would be good to debug log at each of the "return

Re: [Intel-gfx] [PATCH v4 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-02 Thread Dmitry Osipenko
02.09.2022 13:31, Dmitry Osipenko пишет: > 01.09.2022 17:02, Ruhl, Michael J пишет: > ... >>> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c >>> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c >>> @@ -331,7 +331,19 @@ static void __i915_gem_free_objects(struct >>> drm_i915_private *i915, >>>

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: convert to using is_hdmi and has_audio from display info

2022-09-02 Thread Patchwork
== Series Details == Series: drm: convert to using is_hdmi and has_audio from display info URL : https://patchwork.freedesktop.org/series/108024/ State : success == Summary == CI Bug Log - changes from CI_DRM_12061_full -> Patchwork_108024v1_full

[Intel-gfx] [PATCH] drm/i915/vdsc: Set VDSC PIC_HEIGHT before using for DP DSC

2022-09-02 Thread Ankit Nautiyal
Currently, pic_height of vdsc_cfg structure is being used to calculate slice_height, before it is set for DP. So taking out the lines to set pic_height from the helper intel_dp_dsc_compute_params() to individual encoders, and setting pic_height, before it is used to calculate slice_height for DP.

Re: [Intel-gfx] [PATCH v4 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-02 Thread Dmitry Osipenko
01.09.2022 17:02, Ruhl, Michael J пишет: ... >> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c >> @@ -331,7 +331,19 @@ static void __i915_gem_free_objects(struct >> drm_i915_private *i915, >> continue; >> } >>

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Start using REG_BIT* macros

2022-09-02 Thread Patchwork
== Series Details == Series: drm/i915: Start using REG_BIT* macros URL : https://patchwork.freedesktop.org/series/108021/ State : success == Summary == CI Bug Log - changes from CI_DRM_12061_full -> Patchwork_108021v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Don't try to disable host RPS when this was never enabled.

2022-09-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Don't try to disable host RPS when this was never enabled. URL : https://patchwork.freedesktop.org/series/108075/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12064 -> Patchwork_108075v1

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move some of the request decisions out of rps_boost function.

2022-09-02 Thread Vivi, Rodrigo
On Fri, 2022-09-02 at 11:07 +0200, Das, Nirmoy wrote: > Hi Rodrigo, > > On 9/1/2022 9:32 PM, Rodrigo Vivi wrote: > > Ideally all the decisions should be made before calling the boost > > function. > > And rps functions only receiving the rps struct. At least lets move > > most > > of the

[Intel-gfx] [PATCH 2/2] drm/i915: Let's avoid even early init if SLPC is used.

2022-09-02 Thread Rodrigo Vivi
SLPC has its own waiboost variables and lock mechanism. No need for these extra stuff, in special no need for the timer. Cc: Ashutosh Dixit Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_rps.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Intel-gfx] [PATCH 1/2] drm/i915: Don't try to disable host RPS when this was never enabled.

2022-09-02 Thread Rodrigo Vivi
Specially in GT reset case this could be triggered and try to disable things that had never been enabled. Let's add some protection here. Cc: Ashutosh Dixit Signed-off-by: Rodrigo Vivi Reviewed-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_rps.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move some of the request decisions out of rps_boost function.

2022-09-02 Thread Das, Nirmoy
Hi Rodrigo, On 9/1/2022 9:32 PM, Rodrigo Vivi wrote: Ideally all the decisions should be made before calling the boost function. And rps functions only receiving the rps struct. At least lets move most of the decisions to the request component, but still leave the test and set of the fence flag

Re: [Intel-gfx] [PATCH v7 14/15] drm/i915/gsc: allocate extended operational memory in LMEM

2022-09-02 Thread Matthew Auld
On Sat, 6 Aug 2022 at 13:34, Tomas Winkler wrote: > > GSC requires more operational memory than available on chip. > Reserve 4M of LMEM for GSC operation. The memory is provided to the > GSC as struct resource to the auxiliary data of the child device. > > Cc: Alan Previn > Signed-off-by: Tomas

Re: [Intel-gfx] [PATCH 2/2] Revert "drm/i915/display: Re-add check for low voltage sku for max dp source rate"

2022-09-02 Thread Jani Nikula
On Fri, 02 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > This reverts commit d5929835080a60f9119d024fa42f315913942f76. > > With the Parade PS8461E MUX workaround (WaEdpLinkRateDataReload) > implemented we can get finally rid of the is_low_voltage_sku() > check that incorrectly

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Implement WaEdpLinkRateDataReload

2022-09-02 Thread Jani Nikula
On Fri, 02 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > A lot of modern laptops use the Parade PS8461E MUX for eDP > switching. The MUX can operate in jitter cleaning mode or > redriver mode, the first one resulting in higher link > quality. The jitter cleaning mode needs to know the

Re: [Intel-gfx] [PATCH] drm/i915: Start using REG_BIT* macros

2022-09-02 Thread Lisovskiy, Stanislav
On Thu, Sep 01, 2022 at 03:14:04PM +0300, Jani Nikula wrote: > On Thu, 01 Sep 2022, Stanislav Lisovskiy > wrote: > > Lets start to use REG_BIT* macros, instead of (x << 0) like expressions. > > Please be more specific in the commit subject, it's not like we haven't > started using REG_BIT in

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Implement WaEdpLinkRateDataReload

2022-09-02 Thread Aaron Ma
Tested-by: Aaron Ma

  1   2   >