Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Iddamsetty, Aravind
On 20-09-2022 13:05, Jani Nikula wrote: > On Tue, 20 Sep 2022, Aravind Iddamsetty wrote: >> As an integrated GPU, MTL does not have local memory and >> HAS_LMEM() returns false. However the platform's stolen memory >> is presented via BAR2 (i.e., the BAR we traditionally consider >> to be the

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Iddamsetty, Aravind
replying here for earlier comments too. On 21-09-2022 01:35, Lucas De Marchi wrote: > On Tue, Sep 20, 2022 at 01:31:49AM -0700, Lucas De Marchi wrote: >> On Tue, Sep 20, 2022 at 12:49:40PM +0530, Aravind Iddamsetty wrote: >>> As an integrated GPU, MTL does not have local memory and >>> HAS_LMEM()

[Intel-gfx] [PATCH] drm/i915/psr: Fix PSR_IMR/IIR field handling

2022-09-20 Thread Jouni Högander
Current PSR code is assuming TRANSCODER_EDP == 0. This is not the case and all fields in PSR_IMR and PSR_IIR are shifted incorrectly if DISPLAY_VER >= 12. Fix this by using TRANSCODER_EDP definition instead of 0. Cc: Mika Kahola Cc: José Roberto de Souza Signed-off-by: Jouni Högander --- dri

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915/dgfx: Release mmap on rpm suspend

2022-09-20 Thread Gupta, Anshuman
> -Original Message- > From: Matthew Auld > Sent: Tuesday, September 20, 2022 7:30 PM > To: Gupta, Anshuman > Cc: intel-gfx@lists.freedesktop.org; ch...@chris-wilson.co.uk; Auld, Matthew > ; Vivi, Rodrigo > Subject: Re: [Intel-gfx] [PATCH v5 2/2] drm/i915/dgfx: Release mmap on rpm > su

Re: [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback

2022-09-20 Thread Kandpal, Suraj
Hi Jani, All patches have been reviewed by Arun it would be great if you could have a Look and give an ACK. Regards, Suraj Kandpal > Subject: [PATCH v6 0/3] Enable Pipewriteback > > A patch series was floated in the drm mailing list which aimed to change the > drm_connector and drm_encoder fields

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Tidy up vfio_device life cycle (rev7)

2022-09-20 Thread Patchwork
== Series Details == Series: Tidy up vfio_device life cycle (rev7) URL : https://patchwork.freedesktop.org/series/107838/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/107838/revisions/7/mbox/ not applied Applying: vfio: Add helpers for unifying

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable Pipewriteback (rev9)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev9) URL : https://patchwork.freedesktop.org/series/107440/ State : success == Summary == CI Bug Log - changes from CI_DRM_12162_full -> Patchwork_107440v9_full Summary --- **WARNIN

[Intel-gfx] [PATCH v4 14/15] vfio: Rename vfio_device_put() and vfio_device_try_get()

2022-09-20 Thread Kevin Tian
With the addition of vfio_put_device() now the names become confusing. vfio_put_device() is clear from object life cycle p.o.v given kref. vfio_device_put()/vfio_device_try_get() are helpers for tracking users on a registered device. Now rename them: - vfio_device_put() -> vfio_device_put_regi

[Intel-gfx] [PATCH v4 15/15] vfio: Add struct device to vfio_device

2022-09-20 Thread Kevin Tian
From: Yi Liu and replace kref. With it a 'vfio-dev/vfioX' node is created under the sysfs path of the parent, indicating the device is bound to a vfio driver, e.g.: /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 It is also a preparatory step toward adding cdev for supporting future devi

[Intel-gfx] [PATCH v4 12/15] vfio/amba: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
Implement amba's own vfio_device_ops. Remove vfio_platform_probe/remove_common() given no user now. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Eric Auger --- drivers/vfio/platform/vfio_amba.c | 72 ++- drivers/vfio/platform/vfio_platform_co

[Intel-gfx] [PATCH v4 13/15] vfio/ccw: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
ccw is the only exception which cannot use vfio_alloc_device() because its private device structure is designed to serve both mdev and parent. Life cycle of the parent is managed by css_driver so vfio_ccw_private must be allocated/freed in css_driver probe/remove path instead of conforming to vfio

[Intel-gfx] [PATCH v4 11/15] vfio/platform: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
Move vfio_device_ops from platform core to platform drivers so device specific init/cleanup can be added. Introduce two new helpers vfio_platform_init/release_common() for the use in driver @init/@release. vfio_platform_probe/remove_common() will be deprecated. Signed-off-by: Kevin Tian Reviewe

[Intel-gfx] [PATCH v4 10/15] vfio/fsl-mc: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu Also add a comment to mark that vfio core releases device_set if @init fails. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/fsl-mc/vfio_fsl_mc.c | 85 ++- 1 file changed, 49 insertions(+), 36 deletions(-

[Intel-gfx] [PATCH v4 09/15] vfio/ap: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu and manage available_instances inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Tony Krowiak Reviewed-by: Jason Gunthorpe --- drivers/s390/crypto/vfio_ap_ops.c | 50 ++- 1 file changed, 29 insertions(+), 21 deletion

[Intel-gfx] [PATCH v4 07/15] vfio/mbochs: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu and manage avail_mbytes inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mbochs.c | 73 -- 1 file changed, 46 insertions(+), 27 deletions(-) diff --git a/samples/vfio-md

[Intel-gfx] [PATCH v4 08/15] drm/i915/gvt: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
Move vfio_device to the start of intel_vgpu as required by the new helpers. Change intel_gvt_create_vgpu() to use intel_vgpu as the first param as other vgpu helpers do. Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/gvt.h | 5 +

[Intel-gfx] [PATCH v4 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu and manage available ports inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mtty.c | 67 +++- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/samples/vfio

[Intel-gfx] [PATCH v4 05/15] vfio/mdpy: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu and manage mdpy_count inside @init/@release. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- samples/vfio-mdev/mdpy.c | 81 +++- 1 file changed, 47 insertions(+), 34 deletions(-) diff --git a/samples/vfio-mdev

[Intel-gfx] [PATCH v4 04/15] vfio/hisi_acc: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu Tidy up @probe so all migration specific initialization logic is moved to migration specific @init callback. Remove vfio_pci_core_{un}init_device() given no user now. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe Reviewed-by: Shameer Kolothum ---

[Intel-gfx] [PATCH v4 03/15] vfio/mlx5: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu mlx5 has its own @init/@release for handling migration cap. Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/mlx5/main.c | 50 ++-- 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH v4 02/15] vfio/pci: Use the new device life cycle helpers

2022-09-20 Thread Kevin Tian
From: Yi Liu Also introduce two pci core helpers as @init/@release for pci drivers: - vfio_pci_core_init_dev() - vfio_pci_core_release_dev() Signed-off-by: Yi Liu Signed-off-by: Kevin Tian Reviewed-by: Jason Gunthorpe --- drivers/vfio/pci/vfio_pci.c | 20 +- drivers/v

[Intel-gfx] [PATCH v4 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-20 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. This is also a preparatory step for adding struct device into vfio_device. New pair of helpers together with a kref in vfio_device: - vfio_alloc_device() - vfio_put_device() Drivers c

[Intel-gfx] [PATCH v4 00/15] Tidy up vfio_device life cycle

2022-09-20 Thread Kevin Tian
The idea is to let vfio core manage the vfio_device life cycle instead of duplicating the logic cross drivers. Besides cleaner code in driver side this also allows adding struct device to vfio_device as the first step toward adding cdev uAPI in the future. Another benefit is that user can now look

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable Pipewriteback (rev9)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev9) URL : https://patchwork.freedesktop.org/series/107440/ State : success == Summary == CI Bug Log - changes from CI_DRM_12162 -> Patchwork_107440v9 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback (rev9)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev9) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev9)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev9) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim checkpatch failed aaa52a3b740d drm/i915: Define WD trancoder for i915 f81ac46ac2d3 drm/i915 : Changing intel_connector iterators -:76: CHECK:

Re: [Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage

2022-09-20 Thread Dixit, Ashutosh
On Tue, 13 Sep 2022 01:50:08 -0700, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 25/08/2022 14:21, Badal Nilawar wrote: > > From: Dale B Stimson > > > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > > index 9a2d10

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dg2: introduce Wa_22015475538

2022-09-20 Thread Patchwork
== Series Details == Series: drm/i915/dg2: introduce Wa_22015475538 URL : https://patchwork.freedesktop.org/series/108795/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12161_full -> Patchwork_108795v1_full Summary ---

Re: [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support

2022-09-20 Thread Dixit, Ashutosh
On Thu, 15 Sep 2022 07:40:37 -0700, Nilawar, Badal wrote: > > On 29-08-2022 23:00, Dixit, Ashutosh wrote: > > On Thu, 25 Aug 2022 06:21:13 -0700, Badal Nilawar wrote: > >> > >> +static int > >> +hwm_in_read(struct hwm_drvdata *ddat, u32 attr, long *val) > >> +{ > >> + struct i915_hwmon *hwmon = dd

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-20 Thread Dixit, Ashutosh
On Fri, 16 Sep 2022 08:00:50 -0700, Badal Nilawar wrote: > > diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon > index e2974f928e58..bc061238e35c 100644 > --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon >

Re: [Intel-gfx] Intel Arc A370M vs Linux 5.19

2022-09-20 Thread Daniel J Blueman
On Fri, 16 Sept 2022 at 00:35, Tvrtko Ursulin wrote: >> On 15/09/2022 15:54, Rodrigo Vivi wrote: > > On Thu, Sep 15, 2022 at 10:40:59PM +0800, Daniel J Blueman wrote: > >> On Thu, 15 Sept 2022 at 22:09, Rodrigo Vivi wrote: > >>> On Thu, Sep 15, 2022 at 09:08:08PM +0800, Daniel J Blueman wrote: >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Do not cleanup obj with NULL bo->resource

2022-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Do not cleanup obj with NULL bo->resource URL : https://patchwork.freedesktop.org/series/108792/ State : success == Summary == CI Bug Log - changes from CI_DRM_12161_full -> Patchwork_108792v1_full Sum

Re: [Intel-gfx] [PATCH v3 15/15] vfio: Add struct device to vfio_device

2022-09-20 Thread Tian, Kevin
> From: Alex Williamson > Sent: Wednesday, September 21, 2022 4:27 AM > > On Fri, 9 Sep 2022 18:22:47 +0800 > Kevin Tian wrote: > > > From: Yi Liu > > > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the > > sysfs path of the parent, indicating the device is bound to a v

Re: [Intel-gfx] [PATCH v3 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-20 Thread Tian, Kevin
> From: Alex Williamson > Sent: Wednesday, September 21, 2022 3:17 AM > > On Fri, 9 Sep 2022 18:22:38 +0800 > Kevin Tian wrote: > > > From: Yi Liu > > > > and manage available ports inside @init/@release. > > > > Signed-off-by: Yi Liu > > Signed-off-by: Kevin Tian > > Reviewed-by: Jason Gun

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Explicit MCR handling and MTL steering

2022-09-20 Thread Matt Roper
On Tue, Sep 20, 2022 at 10:18:20AM +, Patchwork wrote: > == Series Details == > > Series: Explicit MCR handling and MTL steering > URL : https://patchwork.freedesktop.org/series/108755/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108755v

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Andi Shyti
Hi Matt, Lucas, thanks for your feedback, > > > + switch (gms) { > > > + case 0x0 ... 0x10: > > > + return gms * 32; > > > + case 0x20: > > > + return 1024; > > > + case 0x30: > > > + return 1536; > > > + case 0x40: > > > + return 2048; > > > + case 0xf0 ... 0xfe:

Re: [Intel-gfx] [PATCH 0/6] Introduce struct cdclk_step

2022-09-20 Thread Ville Syrjälä
On Tue, Sep 20, 2022 at 06:48:46PM +, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Ville Syrjälä > > Sent: Tuesday, September 20, 2022 1:20 AM > > To: Srivatsa, Anusha > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > > ; Vivi, Rodrigo > > Subject: Re: [PATCH

Re: [Intel-gfx] [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+

2022-09-20 Thread Rodrigo Vivi
On Mon, Sep 19, 2022 at 09:24:01AM -0700, Ashutosh Dixit wrote: > Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for > Gen11+. Therefore ensure perf_limit_reasons sysfs/debugfs files are created > only for Gen11+. Otherwise on Gen < 5 accessing these files results in the > following o

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: introduce Wa_22015475538

2022-09-20 Thread Patchwork
== Series Details == Series: drm/i915/dg2: introduce Wa_22015475538 URL : https://patchwork.freedesktop.org/series/108795/ State : success == Summary == CI Bug Log - changes from CI_DRM_12161 -> Patchwork_108795v1 Summary --- **SUCCE

[Intel-gfx] [PATCH] drm/i915/dg2: introduce Wa_22015475538

2022-09-20 Thread Matt Atwood
Wa_22015475538 applies to all DG2 (and ATSM) skus. The workaround implementation is identical to Wa_16011620976. LSC_CHICKEN_BIT_0_UDW is a general render register instead of rcs so adding this move to the proper wa init function. bspec:54077 Signed-off-by: Matt Atwood --- drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Matt Roper
On Tue, Sep 20, 2022 at 06:57:46PM +0200, Andi Shyti wrote: > Hi Aravind, > > > +static int get_mtl_gms_size(struct intel_uncore *uncore) > > +{ > > + u16 ggc, gms; > > + > > + ggc = intel_uncore_read16(uncore, _MMIO(0x108040)); > > + > > + /* check GGMS, should be fixed 0x3 (8MB) */ > > +

[Intel-gfx] PR for new GuC v70.5.1 and GuC/HuC with new names

2022-09-20 Thread John . C . Harrison
The following changes since commit f09bebf31b0590bdc875d7236aa705279510cfd0: amdgpu: update yellow carp DMCUB firmware (2022-09-13 08:02:23 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware guc_70.5.1_huc_nover for you to fetch changes up to 51fff

Re: [Intel-gfx] [PATCH v3 15/15] vfio: Add struct device to vfio_device

2022-09-20 Thread Alex Williamson
On Fri, 9 Sep 2022 18:22:47 +0800 Kevin Tian wrote: > From: Yi Liu > > and replace kref. With it a 'vfio-dev/vfioX' node is created under the > sysfs path of the parent, indicating the device is bound to a vfio > driver, e.g.: > > /sys/devices/pci\:6f/\:6f\:01.0/vfio-dev/vfio0 > > It

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable Pipewriteback (rev8)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev8) URL : https://patchwork.freedesktop.org/series/107440/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12160_full -> Patchwork_107440v8_full Summary --- **FAILUR

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Lucas De Marchi
On Tue, Sep 20, 2022 at 01:31:49AM -0700, Lucas De Marchi wrote: On Tue, Sep 20, 2022 at 12:49:40PM +0530, Aravind Iddamsetty wrote: As an integrated GPU, MTL does not have local memory and HAS_LMEM() returns false. However the platform's stolen memory is presented via BAR2 (i.e., the BAR we tr

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Lucas De Marchi
On Tue, Sep 20, 2022 at 06:57:46PM +0200, Andi Shyti wrote: Hi Aravind, +static int get_mtl_gms_size(struct intel_uncore *uncore) +{ + u16 ggc, gms; + + ggc = intel_uncore_read16(uncore, _MMIO(0x108040)); + + /* check GGMS, should be fixed 0x3 (8MB) */ + if ((ggc & 0xc0)

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/dgfx: Make failure to setup stolen non-fatal

2022-09-20 Thread Wayne Boyer
On 9/16/22 10:36 AM, Lucas De Marchi wrote: There is no reason to consider the setup of Data Stolen Memory fatal on dgfx and non-fatal on integrated. Move the debug and error propagation around so both have the same behavior: non-fatal. Before this change, loading i915 on a system with TGL + D

Re: [Intel-gfx] [PATCH v3 06/15] vfio/mtty: Use the new device life cycle helpers

2022-09-20 Thread Alex Williamson
On Fri, 9 Sep 2022 18:22:38 +0800 Kevin Tian wrote: > From: Yi Liu > > and manage available ports inside @init/@release. > > Signed-off-by: Yi Liu > Signed-off-by: Kevin Tian > Reviewed-by: Jason Gunthorpe > --- > samples/vfio-mdev/mtty.c | 67 +++- > 1

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Split i915_gem_init_stolen()

2022-09-20 Thread Wayne Boyer
On 9/16/22 10:36 AM, Lucas De Marchi wrote: Add some helpers: adjust_stolen(), request_smem_stolen_() and init_reserved_stolen() that are now called by i915_gem_init_stolen() to initialize each part of the Data Stolen Memory region. Main goal is to split the reserved part within the stolen, a

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Add missing mask when reading GEN12_DSMBASE

2022-09-20 Thread Wayne Boyer
On 9/16/22 10:36 AM, Lucas De Marchi wrote: DSMBASE register is defined so BDSM bitfield contains the bits 63 to 20 of the base address of stolen. For the supported platforms bits 0-19 are zero but that may not be true in future. Add the missing mask. v2: Use REG_GENMASK64() Acked-by: Aravin

Re: [Intel-gfx] [PATCH 0/6] Introduce struct cdclk_step

2022-09-20 Thread Srivatsa, Anusha
> -Original Message- > From: Ville Syrjälä > Sent: Tuesday, September 20, 2022 1:20 AM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > ; Vivi, Rodrigo > Subject: Re: [PATCH 0/6] Introduce struct cdclk_step > > On Fri, Sep 16, 2022 at 05:43:58PM -0700, Anu

Re: [Intel-gfx] [PATCH 6/6] drm/i915/display: Dump the new cdclk config values

2022-09-20 Thread Srivatsa, Anusha
> -Original Message- > From: Jani Nikula > Sent: Tuesday, September 20, 2022 12:27 AM > To: Srivatsa, Anusha ; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 6/6] drm/i915/display: Dump the new cdclk > config values > > On Fri, 16 Sep 2022, Anusha Srivatsa wrote

Re: [Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

2022-09-20 Thread Lucas De Marchi
On Tue, Sep 20, 2022 at 02:04:33PM -0300, Gustavo Sousa wrote: Hi, Jani. On Tue, Sep 20, 2022 at 10:19:53AM +0300, Jani Nikula wrote: On Mon, 19 Sep 2022, Gustavo Sousa wrote: > Make the code more readable, which will be more apparent as new > platforms with different hotplug inversion needs a

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not cleanup obj with NULL bo->resource

2022-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Do not cleanup obj with NULL bo->resource URL : https://patchwork.freedesktop.org/series/108792/ State : success == Summary == CI Bug Log - changes from CI_DRM_12161 -> Patchwork_108792v1 Summary -

Re: [Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource

2022-09-20 Thread Matthew Auld
On 20/09/2022 18:06, Nirmoy Das wrote: For delayed BO release i915_ttm_delete_mem_notify() gets called twice, once with proper bo->resource and another time with NULL. We shouldn't do anything for the 2nd time as we already cleanedup the obj once. References: https://gitlab.freedesktop.org/drm/i

[Intel-gfx] [PATCH] drm/i915: Do not cleanup obj with NULL bo->resource

2022-09-20 Thread Nirmoy Das
For delayed BO release i915_ttm_delete_mem_notify() gets called twice, once with proper bo->resource and another time with NULL. We shouldn't do anything for the 2nd time as we already cleanedup the obj once. References: https://gitlab.freedesktop.org/drm/intel/-/issues/6850 Signed-off-by: Nirmoy

Re: [Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

2022-09-20 Thread Gustavo Sousa
Hi, Jani. On Tue, Sep 20, 2022 at 10:19:53AM +0300, Jani Nikula wrote: > On Mon, 19 Sep 2022, Gustavo Sousa wrote: > > Make the code more readable, which will be more apparent as new > > platforms with different hotplug inversion needs are added. > > > > Signed-off-by: Gustavo Sousa > > --- > >

Re: [Intel-gfx] [PATCH] drm/i915: move i915_coherent_map_type() to i915_gem_pages.c and un-inline

2022-09-20 Thread Matthew Auld
On 15/09/2022 08:49, Tvrtko Ursulin wrote: On 14/09/2022 17:35, Jani Nikula wrote: The inline function has no place in i915_drv.h. Move it away, un-inline, and untangle some header dependencies while at it. Cc: Matthew Auld Cc: Tvrtko Ursulin Signed-off-by: Jani Nikula --- I don't know wh

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Andi Shyti
Hi Aravind, > +static int get_mtl_gms_size(struct intel_uncore *uncore) > +{ > + u16 ggc, gms; > + > + ggc = intel_uncore_read16(uncore, _MMIO(0x108040)); > + > + /* check GGMS, should be fixed 0x3 (8MB) */ > + if ((ggc & 0xc0) != 0xc0) > + return -EIO; > + > + /* r

Re: [Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

2022-09-20 Thread Gustavo Sousa
On Tue, Sep 20, 2022 at 12:01:36AM -0700, Lucas De Marchi wrote: > On Mon, Sep 19, 2022 at 11:56:59AM -0300, Gustavo Sousa wrote: > > Make the code more readable, which will be more apparent as new > > platforms with different hotplug inversion needs are added. > > > > Signed-off-by: Gustavo Sousa

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable Pipewriteback (rev8)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev8) URL : https://patchwork.freedesktop.org/series/107440/ State : success == Summary == CI Bug Log - changes from CI_DRM_12160 -> Patchwork_107440v8 Summary --- **SUCCESS** No

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Pipewriteback (rev8)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev8) URL : https://patchwork.freedesktop.org/series/107440/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12160 -> Patchwork_107440v8 Summary --- **FAILURE** Ser

Re: [Intel-gfx] [PATCH 1/1] drm/i915/guc: Delay disabling guc_id scheduling for better hysteresis

2022-09-20 Thread Tvrtko Ursulin
On 16/09/2022 16:36, Ceraolo Spurio, Daniele wrote: On 9/16/2022 1:58 AM, Tvrtko Ursulin wrote: On 16/09/2022 08:53, Teres Alexis, Alan Previn wrote: [snip] +    /* + * If the context gets closed while the execbuf is ongoing, the context + * close code will race with the bel

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback (rev8)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev8) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev8)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev8) URL : https://patchwork.freedesktop.org/series/107440/ State : warning == Summary == Error: dim checkpatch failed ad3709400df3 drm/i915: Define WD trancoder for i915 eace4fd2c2e8 drm/i915 : Changing intel_connector iterators -:76: CHECK:

Re: [Intel-gfx] [PATCH v5 00/21] Move all drivers to a common dma-buf locking convention

2022-09-20 Thread Sumit Semwal
Hi Dmitry, On Wed, 14 Sept 2022 at 00:58, Dmitry Osipenko wrote: > > Hello, > > This series moves all drivers to a dynamic dma-buf locking specification. > From now on all dma-buf importers are made responsible for holding > dma-buf's reservation lock around all operations performed over dma-buf

Re: [Intel-gfx] [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification

2022-09-20 Thread Sumit Semwal
Hi Dmitry, Thanks very much for the series. On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko wrote: > > Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking > specification by asserting that the reservation lock is held. Thanks for the patch; just a minor nit - I think you mean dma

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915/dgfx: Release mmap on rpm suspend

2022-09-20 Thread Matthew Auld
On Tue, 13 Sept 2022 at 16:27, Anshuman Gupta wrote: > > Release all mmap mapping for all lmem objects which are associated > with userfault such that, while pcie function in D3hot, any access > to memory mappings will raise a userfault. > > Runtime resume the dgpu(when gem object lies in lmem). >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pps: Enable 2nd pps for dual EDP scenario

2022-09-20 Thread Manna, Animesh
> -Original Message- > From: Nikula, Jani > Sent: Friday, September 16, 2022 5:00 PM > To: Manna, Animesh ; Ville Syrjälä > > Cc: intel-gfx@lists.freedesktop.org; Shankar, Uma > Subject: RE: [PATCH 2/2] drm/i915/pps: Enable 2nd pps for dual EDP scenario > > On Fri, 16 Sep 2022, "Manna

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/mtl: enable local stolen memory URL : https://patchwork.freedesktop.org/series/108767/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108767v1_full =

[Intel-gfx] ✗ Fi.CI.IGT: failure for Explicit MCR handling and MTL steering

2022-09-20 Thread Patchwork
== Series Details == Series: Explicit MCR handling and MTL steering URL : https://patchwork.freedesktop.org/series/108755/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108755v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Perf_limit_reasons are only available for Gen11+

2022-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Perf_limit_reasons are only available for Gen11+ URL : https://patchwork.freedesktop.org/series/108747/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108747v1_full ==

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable Pipewriteback (rev7)

2022-09-20 Thread Patchwork
== Series Details == Series: Enable Pipewriteback (rev7) URL : https://patchwork.freedesktop.org/series/107440/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_107440v7_full Summary --- **FAILUR

Re: [Intel-gfx] [PATCH 2/2] drm/i915/fbc: Use lockdep_assert_held()

2022-09-20 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Monday, June 20, 2022 9:29 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/2] drm/i915/fbc: Use lockdep_assert_held() > > From: Ville Syrjälä > > Replace the mutex_is_locked() stuff with

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Lucas De Marchi
On Tue, Sep 20, 2022 at 12:49:40PM +0530, Aravind Iddamsetty wrote: As an integrated GPU, MTL does not have local memory and HAS_LMEM() returns false. However the platform's stolen memory is presented via BAR2 (i.e., the BAR we traditionally consider to be the LMEM BAR) and should be managed by

Re: [Intel-gfx] [PATCH 1/2] drm/i915/fbc: Move flip_pending assignmnt

2022-09-20 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Monday, June 20, 2022 9:29 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/2] drm/i915/fbc: Move flip_pending assignmnt > > From: Ville Syrjälä > > Move the flip_pending assignment into

Re: [Intel-gfx] [PATCH 0/6] Introduce struct cdclk_step

2022-09-20 Thread Ville Syrjälä
On Fri, Sep 16, 2022 at 05:43:58PM -0700, Anusha Srivatsa wrote: > This is a prep series for the actual cdclk refactoring > that will be sent following this. Idea is to have a > struct - cdclk_step that holds the following: > - cdclk action (squash, crawl or modeset) > - cdclk frequency > which get

Re: [Intel-gfx] [PATCH] drm/i915: Do not dereference NULL bo->resource

2022-09-20 Thread Das, Nirmoy
On 9/19/2022 5:29 PM, Gupta, Anshuman wrote: -Original Message- From: Das, Nirmoy Sent: Monday, September 19, 2022 8:33 PM To: intel-gfx@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org; Auld, Matthew ; Gupta, Anshuman Subject: [PATCH] drm/i915: Do not dereference NULL bo->

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Add C6 residency support for MTL SAMedia

2022-09-20 Thread Jani Nikula
On Mon, 19 Sep 2022, "Dixit, Ashutosh" wrote: > On Mon, 19 Sep 2022 05:13:18 -0700, Jani Nikula wrote: >> >> On Mon, 19 Sep 2022, Badal Nilawar wrote: >> > For MTL SAMedia updated relevant functions and places in the code to get >> > Media C6 residency. >> > >> > v2: Fixed review comments (Ashuto

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/mtl: enable local stolen memory URL : https://patchwork.freedesktop.org/series/108767/ State : success == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_108767v1 ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Do not dereference NULL bo->resource

2022-09-20 Thread Patchwork
== Series Details == Series: drm/i915: Do not dereference NULL bo->resource URL : https://patchwork.freedesktop.org/series/108744/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_108744v1_full Summary

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Jani Nikula
On Tue, 20 Sep 2022, Aravind Iddamsetty wrote: > As an integrated GPU, MTL does not have local memory and > HAS_LMEM() returns false. However the platform's stolen memory > is presented via BAR2 (i.e., the BAR we traditionally consider > to be the LMEM BAR) and should be managed by the driver the

Re: [Intel-gfx] [PATCH 0/4] drm/atomic: Lockless blocking commits

2022-09-20 Thread Pekka Paalanen
On Fri, 16 Sep 2022 19:33:27 +0300 Ville Syrjala wrote: > From: Ville Syrjälä > > I've talked about making blocking commits lockless a few > times in the past, so here's finally an attempt at it. > The main benefit I see from this is that TEST_ONLY commits > no longer getting blocked on the mut

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/mtl: enable local stolen memory URL : https://patchwork.freedesktop.org/series/108767/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/mtl: enable local stolen memory URL : https://patchwork.freedesktop.org/series/108767/ State : warning == Summary == Error: dim checkpatch failed 7dfaf4034615 drm/i915/mtl: enable local stolen memory -:231: CHECK:MACRO_ARG_REUSE:

Re: [Intel-gfx] [PATCH 6/6] drm/i915/display: Dump the new cdclk config values

2022-09-20 Thread Jani Nikula
On Fri, 16 Sep 2022, Anusha Srivatsa wrote: > Add a helper function to get stringify values of the > desired cdclk action and dump it with rest of the > cdclk config values > > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 18 -- > 1 file cha

Re: [Intel-gfx] [PATCH] drm/i915: fix device info for devices without display

2022-09-20 Thread Lucas De Marchi
On Mon, Sep 19, 2022 at 11:10:53AM +0300, Jani Nikula wrote: On Fri, 16 Sep 2022, Lucas De Marchi wrote: On Fri, Sep 16, 2022 at 11:26:42AM +0300, Jani Nikula wrote: Commit 00c6cbfd4e8a ("drm/i915: move pipe_mask and cpu_transcoder_mask to runtime info") moved the pipe_mask member from struct

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: ignore the CEA modes not defined in CEA-861-D (rev3)

2022-09-20 Thread Patchwork
== Series Details == Series: drm/edid: ignore the CEA modes not defined in CEA-861-D (rev3) URL : https://patchwork.freedesktop.org/series/104539/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12158 -> Patchwork_104539v3 Su

Re: [Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

2022-09-20 Thread Jani Nikula
On Mon, 19 Sep 2022, Gustavo Sousa wrote: > Make the code more readable, which will be more apparent as new > platforms with different hotplug inversion needs are added. > > Signed-off-by: Gustavo Sousa > --- > drivers/gpu/drm/i915/i915_irq.c | 25 - > 1 file changed, 16

[Intel-gfx] [PATCH 1/1] drm/i915/mtl: enable local stolen memory

2022-09-20 Thread Aravind Iddamsetty
As an integrated GPU, MTL does not have local memory and HAS_LMEM() returns false. However the platform's stolen memory is presented via BAR2 (i.e., the BAR we traditionally consider to be the LMEM BAR) and should be managed by the driver the same way that local memory is on dgpu platforms (which

Re: [Intel-gfx] [PATCH] drm/i915: Move hotplug inversion logic into separate helper

2022-09-20 Thread Lucas De Marchi
On Mon, Sep 19, 2022 at 11:56:59AM -0300, Gustavo Sousa wrote: Make the code more readable, which will be more apparent as new platforms with different hotplug inversion needs are added. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/i915_irq.c | 25 - 1 file chang

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: ignore the CEA modes not defined in CEA-861-D (rev3)

2022-09-20 Thread Patchwork
== Series Details == Series: drm/edid: ignore the CEA modes not defined in CEA-861-D (rev3) URL : https://patchwork.freedesktop.org/series/104539/ State : warning == Summary == Error: dim checkpatch failed 894ed59a7b31 drm/edid: ignore the CEA modes not defined in CEA-861-D -:72: CHECK:PARENTH