Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: disable FBC if its pipe is fused off

2022-09-28 Thread Saarinen, Jani
+Lakshmi. > -Original Message- > From: Intel-gfx On Behalf Of Coelho, > Luciano > Sent: tiistai 27. syyskuuta 2022 14.28 > To: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: disable FBC if > its pipe is > fused off > > Hi, > > This failu

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2022-09-28 Thread Gupta, Anshuman
On 9/27/2022 11:20 AM, Badal Nilawar wrote: From: Dale B Stimson Use i915 HWMON to display/modify dGfx power PL1 limit and TDP setting. v2: - Fix review comments (Ashutosh) - Do not restore power1_max upon module unload/load sequence because on production systems modules are alwa

Re: [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval

2022-09-28 Thread Gupta, Anshuman
On 9/27/2022 11:20 AM, Badal Nilawar wrote: From: Ashutosh Dixit Expose power1_max_interval, that is the tau corresponding to PL1, as a custom hwmon attribute. Some bit manipulation is needed because of the format of PKG_PWR_LIM_1_TIME in GT0_PACKAGE_RAPL_LIMIT register (1.x * power(2,y)).

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: enable local stolen memory (rev3)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev3) URL : https://patchwork.freedesktop.org/series/109066/ State : success == Summary == CI Bug Log - changes from CI_DRM_12185_full -> Patchwork_109066v3_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: disable FBC if its pipe is fused off

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: disable FBC if its pipe is fused off URL : https://patchwork.freedesktop.org/series/109044/ State : success == Summary == CI Bug Log - changes from CI_DRM_12182_full -> Patchwork_109044v1_full Summary

Re: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-28 Thread Tvrtko Ursulin
On 27/09/2022 22:36, Ceraolo Spurio, Daniele wrote: On 9/27/2022 12:45 AM, Tvrtko Ursulin wrote: On 27/09/2022 07:49, Andrzej Hajda wrote: On 27.09.2022 01:34, Ceraolo Spurio, Daniele wrote: On 9/26/2022 3:44 PM, Andi Shyti wrote: Hi Andrzej, On Mon, Sep 26, 2022 at 11:54:09PM +0200

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: disable FBC if its pipe is fused off

2022-09-28 Thread Vudum, Lakshminarayana
Re-reported. -Original Message- From: Saarinen, Jani Sent: Wednesday, September 28, 2022 12:09 AM To: Coelho, Luciano ; intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: RE: ✗ Fi.CI.IGT: failure for drm/i915: disable FBC if its pipe is fused off +Lakshmi. > -Or

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/psr: Fix PSR_IMR/IIR field handling (rev3)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/psr: Fix PSR_IMR/IIR field handling (rev3) URL : https://patchwork.freedesktop.org/series/108811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12191_full -> Patchwork_108811v3_full Sum

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HuC loading for DG2 (rev8)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 (rev8) URL : https://patchwork.freedesktop.org/series/107477/ State : warning == Summary == Error: dim checkpatch failed a0add1869506 mei: add support to GSC extended header 395edf1bb64a mei: bus: enable sending gsc commands 8ea5f3e6ff

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: HuC loading for DG2 (rev8)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 (rev8) URL : https://patchwork.freedesktop.org/series/107477/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 04/16] drm/i915/vm_bind: Add support to create persistent vma

2022-09-28 Thread Tvrtko Ursulin
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: HuC loading for DG2 (rev8)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading for DG2 (rev8) URL : https://patchwork.freedesktop.org/series/107477/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_107477v8 Summary --- **SUCCESS

Re: [Intel-gfx] [PATCH] drm/i915: Add some debug prints for intel_modeset_all_pipes()

2022-09-28 Thread Jani Nikula
On Wed, 28 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Print out on which pipes, and for what reason, we are forcing a > full modeset. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- > drivers/gpu/drm/i915/d

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Don't use port enum as register offset (rev5)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset (rev5) URL : https://patchwork.freedesktop.org/series/108833/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Allow alternate fixed modes always for eDP

2022-09-28 Thread Jani Nikula
On Tue, 27 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Stop considering VBT's static DRRS support when deciding whether > to use alternate fixed modes or not. It looks like Windows more > or less just uses that to decide whether to automagically switch > refresh rates on AC<->batter

[Intel-gfx] [PATCH v13 0/9] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-28 Thread Gwan-gyeong Mun
This patch series fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation, etc. We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead o

[Intel-gfx] [PATCH v13 3/9] overflow: Introduce overflows_type() and castable_to_type()

2022-09-28 Thread Gwan-gyeong Mun
From: Kees Cook Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert() (which requires a constant expression[1][2]) when used on constant values. This must be construc

[Intel-gfx] [PATCH v13 4/9] drm/i915/gem: Typecheck page lookups

2022-09-28 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe. A

[Intel-gfx] [PATCH v13 1/9] overflow: Allow mixed type arguments

2022-09-28 Thread Gwan-gyeong Mun
From: Kees Cook When the check_[op]_overflow() helpers were introduced, all arguments were required to be the same type to make the fallback macros simpler. However, now that the fallback macros have been removed[1], it is fine to allow mixed types, which makes using the helpers much more useful,

[Intel-gfx] [PATCH v13 2/9] overflow: Introduce check_assign() and check_assign_user_ptr()

2022-09-28 Thread Gwan-gyeong Mun
Add check_assign() macro which performs an assigning source value into destination pointer along with an overflow check and check_assign_user_ptr() macro which performs an assigning source value into destination pointer type variable along with an overflow check. If an explicit overflow check is re

[Intel-gfx] [PATCH v13 6/9] drm/i915: Check for integer truncation on the configuration of ttm place

2022-09-28 Thread Gwan-gyeong Mun
There is an impedance mismatch between the first/last valid page frame number of ttm place in unsigned and our memory/page accounting in unsigned long. As the object size is under the control of userspace, we have to be prudent and catch the conversion errors. To catch the implicit truncation as we

[Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

2022-09-28 Thread Gwan-gyeong Mun
From: Chris Wilson There is an impedance mismatch between the scatterlist API using unsigned int and our memory/page accounting in unsigned long. That is we may try to create a scatterlist for a large object that overflows returning a small table into which we try to fit very many pages. As the o

[Intel-gfx] [PATCH v13 7/9] drm/i915: Check if the size is too big while creating shmem file

2022-09-28 Thread Gwan-gyeong Mun
The __shmem_file_setup() function returns -EINVAL if size is greater than MAX_LFS_FILESIZE. To handle the same error as other code that returns -E2BIG when the size is too large, it add a code that returns -E2BIG when the size is larger than the size that can be handled. v4: If BITS_PER_LONG is 32

[Intel-gfx] [PATCH v13 8/9] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large

2022-09-28 Thread Gwan-gyeong Mun
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Signed-off-by:

[Intel-gfx] [PATCH v13 9/9] drm/i915: Remove truncation warning for large objects

2022-09-28 Thread Gwan-gyeong Mun
From: Chris Wilson Having addressed the issues surrounding incorrect types for local variables and potential integer truncation in using the scatterlist API, we have closed all the loop holes we had previously identified with dangerously large object creation. As such, we can eliminate the warnin

Re: [Intel-gfx] [PATCH v2] overflow: Introduce overflows_type() and castable_to_type()

2022-09-28 Thread Gwan-gyeong Mun
Hi Kees, To check the intel-gfx ci results and test results from other mailing lists, I have rebased this patch and included it in this series [1]. [1] https://patchwork.freedesktop.org/series/109169/ G.G On 9/26/22 10:11 PM, Kees Cook wrote: Implement a robust overflows_type() macro to tes

Re: [Intel-gfx] [PATCH 01/12] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-09-28 Thread Balasubramani Vivekanandan
On 19.09.2022 15:32, Matt Roper wrote: > Gen8 was the first time our hardware had multicast registers (or at > least the first time the multicast nature was exposed and MMIO accesses > could be steered). There are some registers that transitioned from > singleton behavior to multicast during the g

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Don't use port enum as register offset (rev5)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/display: Don't use port enum as register offset (rev5) URL : https://patchwork.freedesktop.org/series/108833/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_108833v5 S

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

2022-09-28 Thread Jani Nikula
On Wed, 28 Sep 2022, Gwan-gyeong Mun wrote: > diff --git a/drivers/gpu/drm/i915/i915_scatterlist.h > b/drivers/gpu/drm/i915/i915_scatterlist.h > index 9ddb3e743a3e..1d1802beb42b 100644 > --- a/drivers/gpu/drm/i915/i915_scatterlist.h > +++ b/drivers/gpu/drm/i915/i915_scatterlist.h > @@ -220,4 +220

[Intel-gfx] [core-for-CI][PATCH v2 2/2] Restore "iommu/dma: Fix race condition during iova_domain initialization"

2022-09-28 Thread Janusz Krzysztofik
This reverts commit bc79ef6d5a223ea59acf874f0493b79c835b17d4 that reverted commit ac9a5d522bb80be50ea84965699e1c8257d745ce. That revert is no longer needed with "iommu: Remove iova cpu hotplugging flushing" in place that breaks more instances of the same lockdep loop. Signed-off-by: Janusz Krzysz

[Intel-gfx] [core-for-CI][PATCH v2 0/2] iommu: Remove iova cpu hotplugging flushing

2022-09-28 Thread Janusz Krzysztofik
Manual revert of commit f598a497bc7d ("iova: Add CPU hotplug handler to flush rcaches"). It is trying to instantiate a cpuhp notifier from inside a cpuhp callback. That code replaced intel_iommu implementation of flushing per-IOVA domain CPU rcaches which used a single instance of cpuhp held for

[Intel-gfx] [core-for-CI][PATCH v2 1/2] iommu: Remove iova cpu hotplugging flushing

2022-09-28 Thread Janusz Krzysztofik
From: Chris Wilson Manual revert of commit f598a497bc7d ("iova: Add CPU hotplug handler to flush rcaches"). It is trying to instantiate a cpuhp notifier from inside a cpuhp callback. That code replaced intel_iommu implementation of flushing per-IOVA domain CPU rcaches which used a single instan

Re: [Intel-gfx] [core-for-CI][PATCH v2 0/2] iommu: Remove iova cpu hotplugging flushing

2022-09-28 Thread Tvrtko Ursulin
On 28/09/2022 09:58, Janusz Krzysztofik wrote: Manual revert of commit f598a497bc7d ("iova: Add CPU hotplug handler to flush rcaches"). It is trying to instantiate a cpuhp notifier from inside a cpuhp callback. That code replaced intel_iommu implementation of flushing per-IOVA domain CPU rcac

Re: [Intel-gfx] [PATCH v2] drm/i915/display: Don't disable DDI/Transcoder when setting phy test pattern

2022-09-28 Thread Jani Nikula
On Tue, 27 Sep 2022, "Almahallawy, Khaled" wrote: > On Mon, 2022-09-26 at 19:48 +0300, Jani Nikula wrote: >> On Fri, 16 Sep 2022, Khaled Almahallawy > > wrote: >> > Bspecs has updated recently to remove the restriction to disable >> > DDI/Transcoder before setting PHY test pattern. This update is

Re: [Intel-gfx] [PATCH 02/12] drm/i915/xehp: Create separate reg definitions for new MCR registers

2022-09-28 Thread Balasubramani Vivekanandan
On 19.09.2022 15:32, Matt Roper wrote: > Starting in Xe_HP, several registers our driver works with have been > converted from singleton registers into replicated registers with > multicast behavior. Although the registers are still located at the > same MMIO offsets as on previous platforms, let'

Re: [Intel-gfx] [core-for-CI][PATCH v2 0/2] iommu: Remove iova cpu hotplugging flushing

2022-09-28 Thread Janusz Krzysztofik
On Wednesday, 28 September 2022 11:22:21 CEST Tvrtko Ursulin wrote: > > On 28/09/2022 09:58, Janusz Krzysztofik wrote: > > Manual revert of commit f598a497bc7d ("iova: Add CPU hotplug handler to > > flush rcaches"). It is trying to instantiate a cpuhp notifier from inside > > a cpuhp callback. T

[Intel-gfx] [PATCH 1/4] drm/i915: Move DRRS debugfs next to the implementation

2022-09-28 Thread Ville Syrjala
From: Ville Syrjälä Move the DRRS debugfs stuff next to the actual implementation so that it's easier to deal with the whole. Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_display_debugfs.c | 96 +--- drivers/gpu/drm/i915/display/intel_drrs.c | 106 +

[Intel-gfx] [PATCH 3/4] drm/i915: Make DRRS debugfs per-crtc/connector

2022-09-28 Thread Ville Syrjala
From: Ville Syrjälä Since I already broke anything that relied on the old contents of the DRRS debugfs files might as well finish the breakage and convert the files to be per-crtc/connector so we don't need to have annoying code in igt to parse these. Signed-off-by: Ville Syrjälä --- .../drm/i

[Intel-gfx] [PATCH 4/4] drm/i915: Fix locking in DRRS debugfs

2022-09-28 Thread Ville Syrjala
From: Ville Syrjälä Grab the crtc mutex so that looking at the crtc state is actually safe. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_drrs.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_drrs.c b/

[Intel-gfx] [PATCH 0/4] drm/i915: Per-crtc/connector DRRS debugfs

2022-09-28 Thread Ville Syrjala
From: Ville Syrjälä Chang DRRS debugfs to be per-crtc/connector. Test-with: 20220928060601.12941-2-ville.syrj...@linux.intel.com Ville Syrjälä (4): drm/i915: Move DRRS debugfs next to the implementation drm/i915: Make the DRRS debugfs contents more consistent drm/i915: Make DRRS debugfs p

[Intel-gfx] [PATCH 2/4] drm/i915: Make the DRRS debugfs contents more consistent

2022-09-28 Thread Ville Syrjala
From: Ville Syrjälä The stuff in the DRRS debugs is currently a hodgepode mix of camelcase, lowercase, spaces, undescores, you name it. Convert over to a reasonably common style. Also move the busy bits thing to be the last sine it's generally the least interesting thing in there. Signed-off-by

[Intel-gfx] [PATCH v4] drm/i915/mtl: enable local stolen memory

2022-09-28 Thread Aravind Iddamsetty
As an integrated GPU, MTL does not have local memory and HAS_LMEM() returns false. However the platform's stolen memory is presented via BAR2 (i.e., the BAR we traditionally consider to be the LMEM BAR) and should be managed by the driver the same way that local memory is on dgpu platforms (which

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: enable PS64 support for DG2

2022-09-28 Thread Das, Nirmoy
On 9/27/2022 5:39 PM, Matthew Auld wrote: It turns out that on production DG2/ATS HW we should have support for PS64. This feature allows to provide a 64K TLB hint at the PTE level, which is a lot more flexible than the current method of enabling 64K GTT pages for the entire page-table, since t

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add some debug prints for intel_modeset_all_pipes()

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: Add some debug prints for intel_modeset_all_pipes() URL : https://patchwork.freedesktop.org/series/109157/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v4] drm/i915/mtl: enable local stolen memory

2022-09-28 Thread Gupta, Anshuman
> -Original Message- > From: Intel-gfx On Behalf Of Aravind > Iddamsetty > Sent: Wednesday, September 28, 2022 4:36 PM > To: intel-gfx@lists.freedesktop.org > Cc: De Marchi, Lucas ; dri- > de...@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v4] drm/i915/mtl: enable local stolen me

Re: [Intel-gfx] [PATCH] drm/display: Don't rewrite link config when setting phy test pattern

2022-09-28 Thread Jani Nikula
On Thu, 15 Sep 2022, Khaled Almahallawy wrote: > The sequence for Source DP PHY CTS automation is [2][1]: > 1- Emulate successful Link Training(LT) > 2- Short HPD and change link rates and number of lanes by LT. > (This is same flow for Link Layer CTS) > 3- Short HPD and change PHY test pattern an

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add some debug prints for intel_modeset_all_pipes()

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: Add some debug prints for intel_modeset_all_pipes() URL : https://patchwork.freedesktop.org/series/109157/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_109157v1 Sum

Re: [Intel-gfx] [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+

2022-09-28 Thread Jani Nikula
On Mon, 19 Sep 2022, Ashutosh Dixit wrote: > Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for > Gen11+. Therefore ensure perf_limit_reasons sysfs/debugfs files are created > only for Gen11+. Otherwise on Gen < 5 accessing these files results in the > following oops: > > <1> [88.829

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-09-28 Thread Tangudu, Tilak
@Nikula, Jani, As you know we have reused i915_gem_backup_suspend, i915_gem_suspend_late and i915_gem_resume in runtime_pm_suspend/resume callbacks ,they use runtime pm helpers (intel_runtime_pm_get/put). These need to be avoided in callbacks as they lead to deadlock. This can be done in two w

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-09-28 Thread Tangudu, Tilak
+ > -Original Message- > From: Tangudu, Tilak > Sent: Wednesday, September 28, 2022 5:46 PM > To: Tangudu, Tilak ; Vivi, Rodrigo > ; Nikula, Jani > Cc: Wilson, Chris P ; Gupta, saurabhg > ; intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed hel

Re: [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback

2022-09-28 Thread Swati Sharma
Hi Suraj, CI is not green https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shards-all.html?testfilter=kms_writeback 2/4 subtests are passing writeback-fb-id subtest can be fixed by asserting EINVAL for i915 we need to fix writeback-check-output first On local validation, we were getti

Re: [Intel-gfx] [PATCH 0/4] drm/i915: Per-crtc/connector DRRS debugfs

2022-09-28 Thread Jani Nikula
On Wed, 28 Sep 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Chang DRRS debugfs to be per-crtc/connector. > > Test-with: 20220928060601.12941-2-ville.syrj...@linux.intel.com > On the series, Reviewed-by: Jani Nikula > Ville Syrjälä (4): > drm/i915: Move DRRS debugfs next to the impl

Re: [Intel-gfx] [PATCH] drm/i915/gt: Flush to global observation point before breadcrumb write

2022-09-28 Thread Andi Shyti
Hi Nirmoy and Prathap, On Tue, Sep 27, 2022 at 07:13:13PM +0200, Nirmoy Das wrote: > From: Prathap Kumar Valsan > > Add flag to pipecontrol instruction to ensure in-flight writes are > flushed to global observation point. Also split the pipecontrol > instruction like we have in gen8. > > Refere

Re: [Intel-gfx] [PATCH] drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual

2022-09-28 Thread Gupta, Anshuman
> -Original Message- > From: Auld, Matthew > Sent: Tuesday, September 27, 2022 6:15 PM > To: Gupta, Anshuman ; intel- > g...@lists.freedesktop.org > Cc: joonas.lahti...@linux.intel.com; tvrtko.ursu...@linux.intel.com > Subject: Re: [PATCH] drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_vi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/vm_bind: Add VM_BIND functionality (rev4)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev4) URL : https://patchwork.freedesktop.org/series/105879/ State : warning == Summary == Error: dim checkpatch failed 474cbe064d10 drm/i915/vm_bind: Expose vm lookup function e2f167a71a29 drm/i915/vm_bind: Add __i915_s

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/vm_bind: Add VM_BIND functionality (rev4)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev4) URL : https://patchwork.freedesktop.org/series/105879/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: use surface size for bios fb size check

2022-09-28 Thread Patchwork
== Series Details == Series: i915: use surface size for bios fb size check URL : https://patchwork.freedesktop.org/series/109114/ State : success == Summary == CI Bug Log - changes from CI_DRM_12192_full -> Patchwork_109114v1_full Summary -

Re: [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback

2022-09-28 Thread Kandpal, Suraj
Hi Swati, > Hi Suraj, > > CI is not green > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shards- > all.html?testfilter=kms_writeback > > 2/4 subtests are passing > writeback-fb-id subtest can be fixed by asserting EINVAL for i915 we need to Also we will be sending new patches follo

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vm_bind: Add VM_BIND functionality (rev4)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/vm_bind: Add VM_BIND functionality (rev4) URL : https://patchwork.freedesktop.org/series/105879/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_105879v4 Summary --

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Added is_intel_rpm_allowed helper

2022-09-28 Thread Vivi, Rodrigo
On Wed, 2022-09-28 at 12:31 +, Tangudu, Tilak wrote: > + > > > -Original Message- > > From: Tangudu, Tilak > > Sent: Wednesday, September 28, 2022 5:46 PM > > To: Tangudu, Tilak ; Vivi, Rodrigo > > ; Nikula, Jani > > Cc: Wilson, Chris P ; Gupta, saurabhg > > ; intel-gfx@lists.freedesk

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/109169/ State : warning == Summary == Error: dim checkpatch failed 3f208bf5aace overflow: Allow mix

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/109169/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode use

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/ttm: prevent grabbing page references v2

2022-09-28 Thread Patchwork
== Series Details == Series: drm/ttm: prevent grabbing page references v2 URL : https://patchwork.freedesktop.org/series/109122/ State : success == Summary == CI Bug Log - changes from CI_DRM_12192_full -> Patchwork_109122v1_full Summary --

Re: [Intel-gfx] [PATCH 04/16] drm/i915/vm_bind: Add support to create persistent vma

2022-09-28 Thread Andi Shyti
Hi Niranjana, On Tue, Sep 27, 2022 at 11:19:06PM -0700, Niranjana Vishwanathapura wrote: > Add i915_vma_instance_persistent() to create persistent vmas. > Persistent vmas will use i915_gtt_view to support partial binding. > > vma_lookup is tied to segment of the object instead of section > of VA

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation

2022-09-28 Thread Patchwork
== Series Details == Series: Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation URL : https://patchwork.freedesktop.org/series/109169/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_109169v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for iommu: Remove iova cpu hotplugging flushing (rev2)

2022-09-28 Thread Patchwork
== Series Details == Series: iommu: Remove iova cpu hotplugging flushing (rev2) URL : https://patchwork.freedesktop.org/series/108880/ State : warning == Summary == Error: dim checkpatch failed 197c8a0312f4 iommu: Remove iova cpu hotplugging flushing -:17: WARNING:COMMIT_LOG_LONG_LINE: Possibl

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for iommu: Remove iova cpu hotplugging flushing (rev2)

2022-09-28 Thread Patchwork
== Series Details == Series: iommu: Remove iova cpu hotplugging flushing (rev2) URL : https://patchwork.freedesktop.org/series/108880/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback

2022-09-28 Thread Swati Sharma
Also, please specify in cover-letter, current series WB support is for TGL+ since WB is supported from SKL+ as per bspec https://gfxspecs.intel.com/Predator/Home/Index/4290 On 19-Sep-22 6:35 PM, Kandpal, Suraj wrote: A patch series was floated in the drm mailing list which aimed to change the dr

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Enabling WD Transcoder

2022-09-28 Thread Swati Sharma
This patch ideally should have been split into smaller functional patches. Thoughts @jani nikula? On 19-Sep-22 6:35 PM, Kandpal, Suraj wrote: From: Suraj Kandpal Adding support for writeback transcoder to start capturing frames using interrupt mechanism Signed-off-by: Suraj Kandpal Reviewed-

[Intel-gfx] ✓ Fi.CI.BAT: success for iommu: Remove iova cpu hotplugging flushing (rev2)

2022-09-28 Thread Patchwork
== Series Details == Series: iommu: Remove iova cpu hotplugging flushing (rev2) URL : https://patchwork.freedesktop.org/series/108880/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_108880v2 Summary --

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915: enable PS64 support for DG2

2022-09-28 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: enable PS64 support for DG2 URL : https://patchwork.freedesktop.org/series/109126/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12192_full -> Patchwork_109126v1_full =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Per-crtc/connector DRRS debugfs

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: Per-crtc/connector DRRS debugfs URL : https://patchwork.freedesktop.org/series/109175/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:

[Intel-gfx] [PATCH v4.1] drm/i915/mtl: Define engine context layouts

2022-09-28 Thread Radhakrishna Sripada
From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state on MTL are nearly similar to DG2 (and PVC). The difference being PRT_BB_STATE being replaced with NOP. For render/compute engines, the part of the context images are nearly the s

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Per-crtc/connector DRRS debugfs

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: Per-crtc/connector DRRS debugfs URL : https://patchwork.freedesktop.org/series/109175/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_109175v1 Summary --- **SU

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/edid: Range descriptor stuff (rev3)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/edid: Range descriptor stuff (rev3) URL : https://patchwork.freedesktop.org/series/107824/ State : success == Summary == CI Bug Log - changes from CI_DRM_12192_full -> Patchwork_107824v3_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: enable local stolen memory (rev4)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev4) URL : https://patchwork.freedesktop.org/series/109066/ State : warning == Summary == Error: dim checkpatch failed f2ad97236ae6 drm/i915/mtl: enable local stolen memory -:223: CHECK:MACRO_ARG_REUSE: Macro argument reus

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: enable local stolen memory (rev4)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev4) URL : https://patchwork.freedesktop.org/series/109066/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: enable local stolen memory (rev4)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: enable local stolen memory (rev4) URL : https://patchwork.freedesktop.org/series/109066/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_109066v4 Summary ---

Re: [Intel-gfx] [PATCH 04/16] drm/i915/vm_bind: Add support to create persistent vma

2022-09-28 Thread Niranjana Vishwanathapura
On Wed, Sep 28, 2022 at 08:38:39AM +0100, Tvrtko Ursulin wrote: On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is tied to segment of the object ins

Re: [Intel-gfx] [PATCH 04/16] drm/i915/vm_bind: Add support to create persistent vma

2022-09-28 Thread Niranjana Vishwanathapura
On Wed, Sep 28, 2022 at 04:44:08PM +0200, Andi Shyti wrote: Hi Niranjana, On Tue, Sep 27, 2022 at 11:19:06PM -0700, Niranjana Vishwanathapura wrote: Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is ti

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

2022-09-28 Thread Linus Torvalds
On Wed, Sep 28, 2022 at 1:15 AM Gwan-gyeong Mun wrote: > > + if (check_assign(obj->base.size >> PAGE_SHIFT, &npages)) > + return -E2BIG; I have to say, I find that new "check_assign()" macro use to be disgusting. It's one thing to check for overflows. It's another thing enti

Re: [Intel-gfx] [PATCH 01/16] drm/i915/vm_bind: Expose vm lookup function

2022-09-28 Thread Matthew Auld
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Make i915_gem_vm_lookup() function non-static as it will be used by the vm_bind feature. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti Acked-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject excessive dotclocks early (rev2)

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915: Reject excessive dotclocks early (rev2) URL : https://patchwork.freedesktop.org/series/109141/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_109141v2 Summary ---

Re: [Intel-gfx] [PATCH 02/16] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-09-28 Thread Matthew Auld
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 03/16] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-09-28 Thread Matthew Auld
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 19 ++---

Re: [Intel-gfx] [PATCH 05/16] drm/i915/vm_bind: Implement bind and unbind of object

2022-09-28 Thread Matthew Auld
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be supported only in the newer execbuf3 ioctl. Signed-off-by: Niranja

Re: [Intel-gfx] [PATCH 06/16] drm/i915/vm_bind: Support for VM private BOs

2022-09-28 Thread Matthew Auld
On 28/09/2022 07:19, Niranjana Vishwanathapura wrote: Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage as it requires a single dma_resv object update for all private BOs vs list of dma_resv objects update for s

Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation

2022-09-28 Thread Kees Cook
On Wed, Sep 28, 2022 at 10:09:04AM -0700, Linus Torvalds wrote: > Kees, you need to reign in the craziness in overflow.h. Understood. I've been trying to help the drm folks walk a line between having a bunch of custom macros hidden away in the drm includes and building up generalized versions that

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Define engine context layouts

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define engine context layouts URL : https://patchwork.freedesktop.org/series/109190/ State : success == Summary == CI Bug Log - changes from CI_DRM_12193 -> Patchwork_109190v1 Summary --- **

Re: [Intel-gfx] [PATCH 7/7] drm/i915/guc: handle interrupts from media GuC

2022-09-28 Thread Matt Roper
On Tue, Sep 27, 2022 at 05:22:41PM -0700, Ceraolo Spurio, Daniele wrote: > > > On 9/27/2022 5:10 PM, Matt Roper wrote: > > On Thu, Sep 22, 2022 at 03:11:17PM -0700, Daniele Ceraolo Spurio wrote: > > > The render and media GuCs share the same interrupt enable register, so > > > we can no longer di

[Intel-gfx] [PATCH drm-intel-fixes] drm/i915/gt: Perf_limit_reasons are only available for Gen11+

2022-09-28 Thread Ashutosh Dixit
Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for Gen11+. Therefore ensure perf_limit_reasons sysfs files are created only for Gen11+. Otherwise on Gen < 5 accessing these files results in the following oops: <1> [88.829420] BUG: unable to handle page fault for address: c9bb

Re: [Intel-gfx] [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+

2022-09-28 Thread Dixit, Ashutosh
On Wed, 28 Sep 2022 04:38:46 -0700, Jani Nikula wrote: > > On Mon, 19 Sep 2022, Ashutosh Dixit wrote: > > Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for > > Gen11+. Therefore ensure perf_limit_reasons sysfs/debugfs files are created > > only for Gen11+. Otherwise on Gen < 5 acces

Re: [Intel-gfx] [PATCH 1/4] drm: Add missing DP DSC extended capability definitions.

2022-09-28 Thread Maarten Lankhorst
Op 14-09-2022 om 12:28 schreef Jani Nikula: > On Tue, 13 Sep 2022, Stanislav Lisovskiy > wrote: >> Adding DP DSC register definitions, we might need for further >> DSC implementation, supporting MST and DP branch pass-through mode. >> >> v2: - Fixed checkpatch comment warning >> v3: - Removed fun

Re: [Intel-gfx] [PATCH 7/7] drm/i915/guc: handle interrupts from media GuC

2022-09-28 Thread Ceraolo Spurio, Daniele
On 9/28/2022 11:07 AM, Matt Roper wrote: On Tue, Sep 27, 2022 at 05:22:41PM -0700, Ceraolo Spurio, Daniele wrote: On 9/27/2022 5:10 PM, Matt Roper wrote: On Thu, Sep 22, 2022 at 03:11:17PM -0700, Daniele Ceraolo Spurio wrote: The render and media GuCs share the same interrupt enable regist

Re: [Intel-gfx] [PATCH] drm/i915/guc: do not capture error state on exiting context

2022-09-28 Thread John Harrison
On 9/28/2022 00:19, Tvrtko Ursulin wrote: On 27/09/2022 22:36, Ceraolo Spurio, Daniele wrote: On 9/27/2022 12:45 AM, Tvrtko Ursulin wrote: On 27/09/2022 07:49, Andrzej Hajda wrote: On 27.09.2022 01:34, Ceraolo Spurio, Daniele wrote: On 9/26/2022 3:44 PM, Andi Shyti wrote: Hi Andrzej, On Mon

Re: [Intel-gfx] [PATCH] drm/i915: Perf_limit_reasons are only available for Gen11+

2022-09-28 Thread Rodrigo Vivi
On Wed, Sep 28, 2022 at 11:17:06AM -0700, Dixit, Ashutosh wrote: > On Wed, 28 Sep 2022 04:38:46 -0700, Jani Nikula wrote: > > > > On Mon, 19 Sep 2022, Ashutosh Dixit wrote: > > > Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for > > > Gen11+. Therefore ensure perf_limit_reasons sysf

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Flush to global observation point before breadcrumb write

2022-09-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Flush to global observation point before breadcrumb write URL : https://patchwork.freedesktop.org/series/109133/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12193_full -> Patchwork_109133v1_full ==

[Intel-gfx] [PATCH] drm/i915/gt: Perf_limit_reasons are only available for Gen11+

2022-09-28 Thread Ashutosh Dixit
Register GT0_PERF_LIMIT_REASONS (0x1381a8) is available only for Gen11+. Therefore ensure perf_limit_reasons sysfs files are created only for Gen11+. Otherwise on Gen < 5 accessing these files results in the following oops: <1> [88.829420] BUG: unable to handle page fault for address: c9bb

[Intel-gfx] [PATCH 1/2] drm/i915/display: Do both crawl and squash when changing cdclk

2022-09-28 Thread Anusha Srivatsa
From: Ville Syrjälä For MTL, changing cdclk from between certain frequencies has both squash and crawl. Use the current cdclk config and the new(desired) cdclk config to construtc a mid cdclk config. Set the cdclk twice: - Current cdclk -> mid cdclk - mid cdclk -> desired cdclk v2: Add check in

[Intel-gfx] [PATCH 2/2] drm/i915/display: Add CDCLK Support for MTL

2022-09-28 Thread Anusha Srivatsa
As per bSpec MTL has 38.4 MHz Reference clock. MTL does support squasher like DG2 but only for lower frequencies. Change the has_cdclk_squasher() helper to reflect this. bxt_get_cdclk() is not properly calculating HW clock for MTL, because the squash formula is only prepared for DG2. Apart from ad

  1   2   >