On Sat, 5 Nov 2022 14:13:14 -0700
Linus Torvalds wrote:
> (Comparing output is also fun because the ordering of the patches is
> random, so consecutive runs with the same rule will give different
> patches. I assume that it's just because it's done in parallel, but it
> doesn't help the "try to s
On Sat, 5 Nov 2022 14:13:14 -0700
Linus Torvalds wrote:
> And trying "when != ptr->timer" actually does the right thing in that
> it gets rid of the case where the timer is modified outside of the
> del_timer() case, *but* it also causes odd other changes to the
> output.
>
> Look at what it gen
On Sat, Nov 5, 2022 at 2:03 PM Jason A. Donenfeld wrote:
>
> Something that might help here is changing the `...` into
> `... when exists` or into `... when != ptr` or similar.
I actually tried that.
You don't want "when exists", you'd want "when forall", but that seems
to be the default.
And t
On Sat, Nov 05, 2022 at 12:36:42PM -0400, Steven Rostedt wrote:
> --8<
> @@
> identifier ptr, timer, rfield, slab;
> @@
> (
> - del_timer(&ptr->timer);
> + timer_shutdown(&ptr->timer);
> |
> - del_timer_sync(&ptr->timer);
> + timer_shutdow
On Sat, Nov 05, 2022 at 02:00:24AM -0400, Steven Rostedt wrote:
>
> Back in April, I posted an RFC patch set to help mitigate a common issue
> where a timer gets armed just before it is freed, and when the timer
> goes off, it crashes in the timer code without any evidence of who the
> culprit was
On Sat, Nov 5, 2022 at 11:04 AM Steven Rostedt wrote:
>
> Here's the changes I made after running the script
Please. No.
What part of "I don't want extra crud" was I unclear on?
I'm not interested in converting everything. That's clearly a 6.,2
issue, possibly even longer considering how compli
On Sat, 5 Nov 2022 14:03:56 -0400
Steven Rostedt wrote:
> --- a/drivers/isdn/hardware/mISDN/hfcmulti.c
> +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
> @@ -4544,7 +4544,7 @@ release_port(struct hfc_multi *hc, struct dchannel *dch)
> spin_lock_irqsave(&hc->lock, flags);
>
> if (dch->
On Sat, 5 Nov 2022 12:36:42 -0400
Steven Rostedt wrote:
> --8<
> @@
> identifier ptr, timer, rfield, slab;
> @@
> (
> - del_timer(&ptr->timer);
> + timer_shutdown(&ptr->timer);
> |
> - del_timer_sync(&ptr->timer);
> + timer_shutdown_sync
On Sat, 5 Nov 2022 08:59:36 -0700
Linus Torvalds wrote:
> Others in the series were *definitely* not scripted, doing clearly
> manual cleanups:
>
> -if (dch->timer.function) {
> -del_timer(&dch->timer);
> -dch->timer.function = NULL;
> -}
> +timer_shutdown(&dch->timer
Den 26.10.2022 17.33, skrev max...@cerno.tech:
> The framework will get the drm_display_mode from the drm_cmdline_mode it
> got by parsing the video command line argument by calling
> drm_connector_pick_cmdline_mode().
>
> The heavy lifting will then be done by the drm_mode_create_from_cmdline_
On Sat, 5 Nov 2022 12:36:42 -0400
Steven Rostedt wrote:
> On Sat, 5 Nov 2022 08:59:36 -0700
> Linus Torvalds wrote:
>
> > On Fri, Nov 4, 2022 at 11:01 PM Steven Rostedt wrote:
> >
> > >
> > > Patch 1 fixes an issue with sunrpc/xprt where it incorrectly uses
> > > del_singleshot_timer_sync()
On Sat, 5 Nov 2022 08:59:36 -0700
Linus Torvalds wrote:
> On Fri, Nov 4, 2022 at 11:01 PM Steven Rostedt wrote:
> >
> > Patch 1 fixes an issue with sunrpc/xprt where it incorrectly uses
> > del_singleshot_timer_sync() for something that is not a oneshot timer. As
> > this
> > will be converted
On Fri, Nov 4, 2022 at 11:01 PM Steven Rostedt wrote:
>
> Patch 1 fixes an issue with sunrpc/xprt where it incorrectly uses
> del_singleshot_timer_sync() for something that is not a oneshot timer. As this
> will be converted to shutdown, this needs to be fixed first.
So this is the kind of thing
Hi,
I have a HP Pavilion 15" laptop that occasionally misbehaves after a
resume from suspend mode. The problem is obvious when the screen
updates e.g. after moving the mouse and the window focus changing, or
when a terminal scrolls, I get a ficker of random short horizontal
white lines over the to
On Sat, 5 Nov 2022 07:18:17 -0700
Guenter Roeck wrote:
> Just in case you didn't notice:
>
> Looking through the resulting code, I think some of the remaining
> calls to del_singleshot_timer_sync() can be converted as well.
>
> The calls in drivers/staging/wlan-ng/prism2usb.c:prism2sta_disconne
On Sat, Nov 05, 2022 at 02:00:24AM -0400, Steven Rostedt wrote:
>
> Back in April, I posted an RFC patch set to help mitigate a common issue
> where a timer gets armed just before it is freed, and when the timer
> goes off, it crashes in the timer code without any evidence of who the
> culprit was
Den 26.10.2022 17.33, skrev max...@cerno.tech:
> The current named mode parsing relies only the mode name, and doesn't allow
only the -> only on the
> to specify any other parameter.
>
> Let's convert that string list to an array of a custom structure that will
> hold the name and some additi
Den 26.10.2022 17.33, skrev max...@cerno.tech:
> The current construction of the named mode parsing doesn't allow to extend
> it easily. Let's move it to a separate function so we can add more
> parameters and modes.
>
> In order for the tests to still pass, some extra checks are needed, so
> i
== Series Details ==
Series: Fix live busy stats selftest failure
URL : https://patchwork.freedesktop.org/series/110557/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12346_full -> Patchwork_110557v1_full
Summary
---
== Series Details ==
Series: series starting with [1/2] drm/i915/display: Do both crawl and squash
when changing cdclk
URL : https://patchwork.freedesktop.org/series/110554/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12346_full -> Patchwork_110554v1_full
==
Den 05.11.2022 07.00, skrev Steven Rostedt:
> From: "Steven Rostedt (Google)"
>
> Before a timer is released, timer_shutdown_sync() must be called.
>
> Link: https://lore.kernel.org/all/20221104054053.431922...@goodmis.org/
>
> Cc: "Noralf Trønnes"
> Cc: David Airlie
> Cc: Daniel Vetter
>
== Series Details ==
Series: Add GT oriented dmesg output
URL : https://patchwork.freedesktop.org/series/110550/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12344_full -> Patchwork_110550v1_full
Summary
---
**FAILU
== Series Details ==
Series: vfio-ccw parent rework (rev3)
URL : https://patchwork.freedesktop.org/series/109899/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12344_full -> Patchwork_109899v3_full
Summary
---
**FAIL
23 matches
Mail list logo
