[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: mode clock check related to max dotclk frequency

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/display: mode clock check related to max dotclk frequency URL : https://patchwork.freedesktop.org/series/110686/ State : success == Summary == CI Bug Log - changes from CI_DRM_12358 -> Patchwork_110686v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: mode clock check related to max dotclk frequency

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/display: mode clock check related to max dotclk frequency URL : https://patchwork.freedesktop.org/series/110686/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup

2022-11-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup URL : https://patchwork.freedesktop.org/series/110678/ State : success == Summary == CI Bug Log - changes from CI_DRM_12356_full -> Patchwork_110678v1_full

[Intel-gfx] [PATCH] drm/i915/display: mode clock check related to max dotclk frequency

2022-11-08 Thread Nischal Varide
A check on mode->clock to see if is greater than i915->max_dotclk_freq or greater than 2 * (i915_max_dotclk_freq) in case of big-joiner and return an -EINVAL in both the cases Signed-off-by: Nischal Varide --- drivers/gpu/drm/i915/display/intel_dp.c | 4 1 file changed, 4 insertions(+)

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rps: Query min/max freq from FW when displaying in sysfs

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/rps: Query min/max freq from FW when displaying in sysfs URL : https://patchwork.freedesktop.org/series/110685/ State : success == Summary == CI Bug Log - changes from CI_DRM_12358 -> Patchwork_110685v1

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/7] drm/i915/huc: only load HuC on GTs that have VCS engines (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915/huc: only load HuC on GTs that have VCS engines (rev2) URL : https://patchwork.freedesktop.org/series/110646/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12356_full -> Patchwork_110646v2_full

Re: [Intel-gfx] [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-08 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, November 9, 2022 9:05 AM > > On Tue, Nov 08, 2022 at 03:55:20PM -0700, Alex Williamson wrote: > > > > > So why exactly isn't this an issue for VDPA? Are we just burying our > > > > head in the sand that such platforms exists and can still be useful >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/rps: Query min/max freq from FW when displaying in sysfs

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/rps: Query min/max freq from FW when displaying in sysfs URL : https://patchwork.freedesktop.org/series/110685/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Drop force_probe requirement

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Drop force_probe requirement URL : https://patchwork.freedesktop.org/series/110683/ State : success == Summary == CI Bug Log - changes from CI_DRM_12358 -> Patchwork_110683v1 Summary ---

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dg2: Drop force_probe requirement

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Drop force_probe requirement URL : https://patchwork.freedesktop.org/series/110683/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dg2: Drop force_probe requirement

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Drop force_probe requirement URL : https://patchwork.freedesktop.org/series/110683/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

[Intel-gfx] [CI 0/1] drm/i915/rps: Query min/max freq from FW when displaying in sysfs

2022-11-08 Thread Ashutosh Dixit
CI ONLY, PLEASE DON'T REVIEW Test-with: 20221108215457.2494061-1-ashutosh.di...@intel.com Ashutosh Dixit (1): drm/i915/rps: Query min/max freq from FW when displaying in sysfs drivers/gpu/drm/i915/gt/intel_rps.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-)

[Intel-gfx] [CI 1/1] drm/i915/rps: Query min/max freq from FW when displaying in sysfs

2022-11-08 Thread Ashutosh Dixit
CI ONLY, PLEASE DON'T REVIEW Instead of displaying i915 cached values, query min/max freq from FW when displaying in sysfs. FIXME: "show" functions don't allow you to return error!!! Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/gt/intel_rps.c | 22 -- 1 file

Re: [Intel-gfx] [PATCH v7 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-11-08 Thread Mateusz Kwiatkowski
Hi Maxime, I ran your v7 patchset on my Pi with Xorg, and the mode switching, as well as the preferred mode handling, all work really well now! I just noted that the downstream version of the vc4 driver still has inaccurate field delays in vc4_crtc.c, which causes vertical lines to appear jagged

Re: [Intel-gfx] [PATCH v1] drm/i915/gt: Add sysfs RAPL PL1 interface

2022-11-08 Thread Dixit, Ashutosh
On Thu, 03 Nov 2022 05:37:23 -0700, Sujaritha Sundaresan wrote: > Hi Suja, > Adding the rapl_pl1_freq_mhz sysfs attribute. > > Signed-off-by: Sujaritha Sundaresan > Cc: Ashutosh Dixit > --- > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 20 ++ > drivers/gpu/drm/i915/gt/intel_rps.c

Re: [Intel-gfx] [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-08 Thread Jason Gunthorpe
On Tue, Nov 08, 2022 at 03:55:20PM -0700, Alex Williamson wrote: > > > So why exactly isn't this an issue for VDPA? Are we just burying our > > > head in the sand that such platforms exists and can still be useful > > > given the appropriate risk vs reward trade-off? > > > > Simply that

Re: [Intel-gfx] [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-08 Thread Jason Gunthorpe
On Tue, Nov 08, 2022 at 03:28:31PM -0700, Alex Williamson wrote: > Perhaps this should have been obvious, but I'm realizing that > vfio-noiommu mode is completely missing without VFIO_CONTAINER, which > seems a barrier to deprecating VFIO_CONTAINER and perhaps makes it a Yes, it is the same as

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-08 Thread Matt Roper
On Tue, Nov 08, 2022 at 03:56:23PM -0800, Srivatsa, Anusha wrote: > > > > -Original Message- > > From: Roper, Matthew D > > Sent: Tuesday, November 8, 2022 3:43 PM > > To: Srivatsa, Anusha > > Cc: intel-gfx@lists.freedesktop.org; Vivekanandan, Balasubramani > > > > Subject: Re:

[Intel-gfx] [PATCH] drm/i915/dg2: Drop force_probe requirement

2022-11-08 Thread Matt Roper
DG2 has been very usable for a while now, and all of the uapi changes related to fundamental platform usage have been finalized. Recent CI results have also been healthy, so we're ready to drop the force_probe requirement and enable the platform by default. Cc: Rodrigo Vivi Cc: Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: ELD precompute and readout (rev3)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: ELD precompute and readout (rev3) URL : https://patchwork.freedesktop.org/series/109592/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12355_full -> Patchwork_109592v3_full Summary

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-08 Thread Srivatsa, Anusha
> -Original Message- > From: Roper, Matthew D > Sent: Tuesday, November 8, 2022 3:43 PM > To: Srivatsa, Anusha > Cc: intel-gfx@lists.freedesktop.org; Vivekanandan, Balasubramani > > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Do both crawl and > squash when changing cdclk

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Do both crawl and squash when changing cdclk

2022-11-08 Thread Matt Roper
On Fri, Nov 04, 2022 at 03:26:41PM -0700, Anusha Srivatsa wrote: > From: Ville Syrjälä > > For MTL, changing cdclk from between certain frequencies has > both squash and crawl. Use the current cdclk config and > the new(desired) cdclk config to construtc a mid cdclk config. > Set the cdclk

Re: [Intel-gfx] [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-08 Thread Alex Williamson
On Mon, 7 Nov 2022 14:45:59 -0400 Jason Gunthorpe wrote: > On Mon, Nov 07, 2022 at 11:05:08AM -0700, Alex Williamson wrote: > > > After further consideration... I don't think the option on vfio-main > > makes sense, basically for the same reason that the original option > > existed on the IOMMU

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl+: Enable DC power states on all eDP ports (rev8)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/tgl+: Enable DC power states on all eDP ports (rev8) URL : https://patchwork.freedesktop.org/series/110433/ State : success == Summary == CI Bug Log - changes from CI_DRM_12355_full -> Patchwork_110433v8_full

Re: [Intel-gfx] [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-08 Thread Alex Williamson
On Mon, 7 Nov 2022 20:52:54 -0400 Jason Gunthorpe wrote: > Add a kconfig CONFIG_VFIO_CONTAINER that controls compiling the container > code. If 'n' then only iommufd will provide the container service. All the > support for vfio iommu drivers, including type1, will not be built. > > This

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Analog TV Improvements (rev8)

2022-11-08 Thread Patchwork
== Series Details == Series: drm: Analog TV Improvements (rev8) URL : https://patchwork.freedesktop.org/series/107892/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/107892/revisions/8/mbox/ not applied Applying: drm/tests: Add Kunit Helpers

Re: [Intel-gfx] [Nouveau] [PATCH v7 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-11-08 Thread Mateusz Kwiatkowski
Hi Lukas, Maxime and everyone, W dniu 8.11.2022 o 14:17, Lukas Satin pisze: > They are important for retrogaming and connecting TV out to CRT TV or using > emulator. > > I have PS1 that is using PAL-60 for example. > > Can you add 240p and 288p non-interlaced modes for NTSC and PAL, please? To

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup

2022-11-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup URL : https://patchwork.freedesktop.org/series/110678/ State : success == Summary == CI Bug Log - changes from CI_DRM_12356 -> Patchwork_110678v1

Re: [Intel-gfx] [Nouveau] [PATCH v7 06/23] drm/modes: Add a function to generate analog display modes

2022-11-08 Thread Mateusz Kwiatkowski
Hi Lukas, W dniu 8.11.2022 o 14:28, Lukas Satin pisze: > Hi, your statement: > > "However, analog display usually have fairly loose timings requirements, > the only discrete parameters being the total number of lines and pixel > clock frequency." > > Please do not make it as a rule. You said

Re: [Intel-gfx] [PATCH v7 15/23] drm/modes: Introduce more named modes

2022-11-08 Thread Mateusz Kwiatkowski
Hi Noralf, W dniu 8.11.2022 o 10:38, Noralf Trønnes pisze: > > Den 07.11.2022 19.03, skrev Noralf Trønnes: >> >> Den 07.11.2022 15.16, skrev Maxime Ripard: >>> Now that we can easily extend the named modes list, let's add a few more >>> analog TV modes that were used in the wild, and some unit

[Intel-gfx] [PATCH 3/3] drm/i915/edp: Fix warning as vdd went down without driver knowledge

2022-11-08 Thread Animesh Manna
Kernel warning triggered as vdd went down after certain time during aux transfer in connector init sequence. To solve the kernel warning adjust power domain and vdd wakeref count. Currently issue seen on ADL so add the above adjustment part of ADL platform check, if needed will extend for future

[Intel-gfx] [PATCH 2/3] drm/i915/pps: Enable 2nd pps for dual EDP scenario

2022-11-08 Thread Animesh Manna
>From display gen12 onwards to support dual EDP two instances of pps added. Currently backlight controller and pps instance can be mapped together for a specific panel. Extended support for gen12 for dual EDP usage. v1: Iniital revision v2: Called intel_bios_panel_init w/o PNPID before

[Intel-gfx] [PATCH 1/3] drm/i915/pps: Add get_pps_idx() hook as part of pps_get_register() cleanup

2022-11-08 Thread Animesh Manna
Simplified pps_get_register() which use get_pps_idx() hook to derive the pps instance and get_pps_idx() will be initialized at pps_init(). v1: Initial version. Got r-b from Jani. v2: Corrected unintentional change around memset() call. [Jani] Cc: Jani Nikula Cc: Ville Syrjälä Cc: Uma Shankar

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-08 Thread John Harrison
On 11/8/2022 01:01, Tvrtko Ursulin wrote: On 07/11/2022 19:14, John Harrison wrote: On 11/7/2022 08:17, Tvrtko Ursulin wrote: On 07/11/2022 09:33, Tvrtko Ursulin wrote: On 05/11/2022 01:03, Ceraolo Spurio, Daniele wrote: On 11/4/2022 10:25 AM, john.c.harri...@intel.com wrote: From: John

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/7] drm/i915/huc: only load HuC on GTs that have VCS engines (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915/huc: only load HuC on GTs that have VCS engines (rev2) URL : https://patchwork.freedesktop.org/series/110646/ State : success == Summary == CI Bug Log - changes from CI_DRM_12356 -> Patchwork_110646v2

Re: [Intel-gfx] [PATCH v2] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-08 Thread John Harrison
On 11/8/2022 04:26, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Convert some usages of legacy DRM logging macros into versions which tell us on which device have the events occurred. v2: * Don't have struct drm_device as local. (Jani, Ville) Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-08 Thread John Harrison
On 11/8/2022 01:08, Tvrtko Ursulin wrote: On 07/11/2022 19:45, John Harrison wrote: On 11/7/2022 06:09, Tvrtko Ursulin wrote: On 04/11/2022 17:45, John Harrison wrote: On 11/4/2022 03:01, Tvrtko Ursulin wrote: On 03/11/2022 19:16, John Harrison wrote: On 11/3/2022 02:38, Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ttm: never purge busy objects

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/ttm: never purge busy objects URL : https://patchwork.freedesktop.org/series/110601/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12351_full -> Patchwork_110601v1_full Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/7] drm/i915/huc: only load HuC on GTs that have VCS engines (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915/huc: only load HuC on GTs that have VCS engines (rev2) URL : https://patchwork.freedesktop.org/series/110646/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/7] drm/i915/huc: only load HuC on GTs that have VCS engines (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: series starting with [CI,1/7] drm/i915/huc: only load HuC on GTs that have VCS engines (rev2) URL : https://patchwork.freedesktop.org/series/110646/ State : warning == Summary == Error: dim checkpatch failed 5d5b41d0c6b7 drm/i915/huc: only load HuC on GTs that

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: ELD precompute and readout (rev3)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: ELD precompute and readout (rev3) URL : https://patchwork.freedesktop.org/series/109592/ State : success == Summary == CI Bug Log - changes from CI_DRM_12355 -> Patchwork_109592v3 Summary ---

Re: [Intel-gfx] [PATCH v2 07/11] vfio-iommufd: Support iommufd for physical VFIO devices

2022-11-08 Thread Jason Gunthorpe
On Tue, Nov 08, 2022 at 03:41:25PM +0800, Yi Liu wrote: > On 2022/11/8 14:10, Nicolin Chen wrote: > > On Mon, Nov 07, 2022 at 08:52:51PM -0400, Jason Gunthorpe wrote: > > > > > @@ -795,6 +800,10 @@ static int vfio_device_first_open(struct vfio_device > > > *device) > > > ret =

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Partial abandonment of legacy DRM logging macros (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: Partial abandonment of legacy DRM logging macros (rev2) URL : https://patchwork.freedesktop.org/series/110660/ State : success == Summary == CI Bug Log - changes from CI_DRM_12354_full -> Patchwork_110660v2_full

Re: [Intel-gfx] [PATCH v2 07/11] vfio-iommufd: Support iommufd for physical VFIO devices

2022-11-08 Thread Jason Gunthorpe
On Mon, Nov 07, 2022 at 10:10:59PM -0800, Nicolin Chen wrote: > > @@ -812,6 +821,7 @@ static int vfio_device_first_open(struct vfio_device > > *device) > > device->kvm = NULL; > > if (device->group->container) > > vfio_group_unuse_container(device->group); > > +

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: ELD precompute and readout (rev3)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: ELD precompute and readout (rev3) URL : https://patchwork.freedesktop.org/series/109592/ State : warning == Summary == Error: make htmldocs had i915 warnings ./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: ELD precompute and readout (rev3)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: ELD precompute and readout (rev3) URL : https://patchwork.freedesktop.org/series/109592/ State : warning == Summary == Error: dim checkpatch failed c4aa4dddc007 drm/i915/audio: Don't program the hardware ELD buffer on ilk+ c76e56062fbb drm/i915/audio:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl+: Enable DC power states on all eDP ports (rev8)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/tgl+: Enable DC power states on all eDP ports (rev8) URL : https://patchwork.freedesktop.org/series/110433/ State : success == Summary == CI Bug Log - changes from CI_DRM_12355 -> Patchwork_110433v8

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/tgl+: Enable DC power states on all eDP ports (rev8)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/tgl+: Enable DC power states on all eDP ports (rev8) URL : https://patchwork.freedesktop.org/series/110433/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tgl+: Enable DC power states on all eDP ports (rev8)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/tgl+: Enable DC power states on all eDP ports (rev8) URL : https://patchwork.freedesktop.org/series/110433/ State : warning == Summary == Error: dim checkpatch failed f6043b9389ee drm/i915: Allocate power domain set wakerefs dynamically -:112:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: use i915_sg_dma_sizes() for all backends (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: use i915_sg_dma_sizes() for all backends (rev2) URL : https://patchwork.freedesktop.org/series/110620/ State : success == Summary == CI Bug Log - changes from CI_DRM_12354_full -> Patchwork_110620v2_full

Re: [Intel-gfx] [PATCH v2 04/15] drm/i915/audio: Realign some function arguments

2022-11-08 Thread Jani Nikula
On Tue, 08 Nov 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Fix up some function argument alignment fails. > > Cc: Chaitanya Kumar Borah > Cc: Kai Vehmanen > Cc: Takashi Iwai > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

Re: [Intel-gfx] [PATCH v2 03/15] drm/i915/audio: Unify get_saved_enc()

2022-11-08 Thread Jani Nikula
On Tue, 08 Nov 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Make the two branches of get_saved_enc() look alike. Currently > they look different even though they do exactly the same thing > apart from == vs. != for the MST comparison. > > Cc: Chaitanya Kumar Borah > Cc: Kai Vehmanen >

Re: [Intel-gfx] [PATCH v6 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-11-08 Thread Niranjana Vishwanathapura
On Mon, Nov 07, 2022 at 05:39:34PM -0800, Zanoni, Paulo R wrote: On Mon, 2022-11-07 at 00:52 -0800, Niranjana Vishwanathapura wrote: Asynchronously unbind the vma upon vm_unbind call. Fall back to synchronous unbind if backend doesn't support async unbind or if async unbind fails. No need for

Re: [Intel-gfx] [PATCH] drm/edid/firmware: stop using throwaway platform device

2022-11-08 Thread Matthieu CHARETTE
I didn't test the patch yet. I will do. But even without testing I can tell you that it will work (It will not crash). Currently when the crash occurs, all screens remain black after resume. I'm not able to login with ssh neither. And logs end before the suspend. So the crash seems to be some

[Intel-gfx] [PATCH v2 15/15] drm/i915/audio: Clean up the PCH type checks

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Use explicit PCH type checks to make it more clear which platforms use which codepaths. Also reorder the branches in ibx_audio_regs_init() a bit to be more in chronological order. Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH v2] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-08 Thread Andrzej Hajda
On 08.11.2022 13:26, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Convert some usages of legacy DRM logging macros into versions which tell us on which device have the events occurred. v2: * Don't have struct drm_device as local. (Jani, Ville) Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula

[Intel-gfx] [PATCH v3 9/9] drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP port main links

2022-11-08 Thread Imre Deak
MTL+ requires the AUX_IO power for the main link only on eDP, so don't enable it in other cases. v2: - Rebased on checking intel_encoder_can_psr() instead of crtc->has_psr. Cc: Ville Syrjälä Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- 1 file changed, 1

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/ttm: fix uaf with lmem_userfault_list handling

2022-11-08 Thread Vudum, Lakshminarayana
Known issue. Re-reported. -Original Message- From: Auld, Matthew Sent: Tuesday, November 8, 2022 1:40 AM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/ttm: fix uaf with lmem_userfault_list

[Intel-gfx] [PATCH v2 10/15] drm/i915/sdvo: Only use "presence detect" for has_audio readout

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Align the SDVO audio code with the native HDMI/DP audio and use just the "presence detect" bit for the has_audio readout. The "ELD valid" bit will be used for ELD readout soon. Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 12/15] drm/i915/audio: Hook up ELD into the state checker

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Have the state checker validate the ELD. For now we'll just dump it out as a hex buffer on a mismatch, maybe someone will get inspired to decode it properly at some point... Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Reviewed-by: Jani Nikula

[Intel-gfx] [PATCH v2 03/15] drm/i915/audio: Unify get_saved_enc()

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Make the two branches of get_saved_enc() look alike. Currently they look different even though they do exactly the same thing apart from == vs. != for the MST comparison. Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Signed-off-by: Ville Syrjälä ---

Re: [Intel-gfx] [PATCH v2 00/11] Connect VFIO to IOMMUFD

2022-11-08 Thread Yi Liu
On 2022/11/8 17:19, Nicolin Chen wrote: On Mon, Nov 07, 2022 at 08:52:44PM -0400, Jason Gunthorpe wrote: This is on github: https://github.com/jgunthorpe/linux/commits/vfio_iommufd [...] v2: - Rebase to v6.1-rc3, v4 iommufd series - Fixup comments and commit messages from list remarks

[Intel-gfx] [PATCH v2 02/15] drm/i915/audio: Don't program the hardware ELD buffer on hsw+

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Since we use the audio component to transfer the ELD to the audio driver on hsw+ platforms there is no point in even programming the hardware ELD buffer. Stop doing so. The one slight caveat here is that this is not strictly legal according to the HDA spec. PD=1;ELD=0 is

[Intel-gfx] [PATCH v3 7/9] drm/i915: Factor out function to get/put AUX_IO power for main link

2022-11-08 Thread Imre Deak
Factor out functions to get/put the AUX_IO power domain for the main link on DDI ports. While at it clarify the corresponding code comment. No functional change. v2: - s/(get/put)_aux_power_for_main_link/main_link_aux_power_domain_(get/put) (Jani) - Clarify in the code comment that AUX_IO is

[Intel-gfx] [PATCH v2 08/15] drm/i915/audio: Hardware ELD readout

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Read out the ELD from the hardware buffer, or from our stashed copy for the audio component, so that we can hook up the state checker to validate it. v2: Deal with the platforms using acomp Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Reviewed-by: Jani

[Intel-gfx] [PATCH v2 14/15] drm/i915/audio: s/ilk/ibx/

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Rename the ilk stuff to ibx, as the audio logic lives in the PCH. The only exception are VLV/CHV but their audio hardware was stolen from ibx so the name still fits. Also most of the register defines also use the IBX namespace. Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen

[Intel-gfx] [PATCH v2 00/15] drm/i915: ELD precompute and readout

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Second attempt at ELD precompute + readout. v2: - get rid of the hw ELD buffer entirely on !g4x - actually use the precomputed ELD in acomp .get_eld() - more cleanups/etc. here and there Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Ville Syrjälä (15):

[Intel-gfx] [PATCH v2 06/15] drm/i915/audio: Precompute the ELD

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Stash the ELD into the crtc_state and precompute it. This gets rid of the ugly ELD mutation during intel_audio_codec_enable(), and opens the door for the state checker. v2: Make another copy for the acomp hooks (Chaitanya) Split out the bogus ELD handling change (Jani)

[Intel-gfx] [PATCH v2 13/15] drm/i915/audio: Include ELD in the state dump

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Include the ELD has a hex blob in the crtc state dump. Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_crtc_state_dump.c| 17 + 1 file changed, 17

[Intel-gfx] [PATCH v2 07/15] drm/i915/audio: Don't enable audio with bogus ELD

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Currently we just print a debug message if the ELD is bogus. Maybe we should just not enable audio at all in that case? Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_audio.c | 4 +++- 1

[Intel-gfx] [PATCH v2 04/15] drm/i915/audio: Realign some function arguments

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Fix up some function argument alignment fails. Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_audio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH v2 11/15] drm/i915/sdvo: Do ELD hardware readout

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Read out the ELD from the hw so the state checker can verify it. v2: Check the "ELD valid" bit separately Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Reviewed-by: Jani Nikula #v1 Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 09/15] drm/i915/sdvo: Precompute the ELD

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Use the precomputed crtc_state->eld for audio setup on SDVO just like we do with native HDMI. Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 12

[Intel-gfx] [PATCH v2 05/15] drm/i915/audio: Introduce a struct for the acomp audio state

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Currently we're spreading the stashed state for use of the audio component hooks all over the place. Start collecting it up into a single spot. Cc: Chaitanya Kumar Borah Cc: Kai Vehmanen Cc: Takashi Iwai Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v3 8/9] drm/i915: Don't enable the AUX_IO power for combo-PHY external DP port main links

2022-11-08 Thread Imre Deak
Combo PHY ports require the AUX_IO power only for eDP/PSR, so don't enable it otherwise on these ports. So far the external DP and eDP case was handled the same way due to unclarity when AUX_IO for the main link is needed. However Bspec is clear in which cases it's required: - eDP/PSR on all

[Intel-gfx] [PATCH v3 4/9] drm/i915/tgl+: Enable display DC power states on all eDP ports

2022-11-08 Thread Imre Deak
Starting with TGL eDP is supported on ports B+ (besides port A), so make sure DC states are not blocked on any such ports. For this add an AUX_IO_ power domain for each port with eDP support. These domains similarly to AUX_IO_A enable only the AUX_IO_ power well for an enabled port, whereas the

[Intel-gfx] [PATCH v2 01/15] drm/i915/audio: Don't program the hardware ELD buffer on ilk+

2022-11-08 Thread Ville Syrjala
From: Ville Syrjälä Since we use the audio component to transfer the ELD to the audio driver on ilk+ platforms there is no point in even programming the hardware ELD buffer. Stop doing so. The one slight caveat here is that this is not strictly legal according to the HDA spec. PD=1;ELD=0 is

[Intel-gfx] [PATCH v3 3/9] drm/i915: Use the AUX_IO power domain only for eDP/PSR port

2022-11-08 Thread Imre Deak
Use the AUX_IO_A display power domain only for eDP on port A where PSR is also supported. This is the case where DC states need to be enabled while the output is enabled - ensured by AUX_IO_A domain not enabling the DC_OFF power well. Otherwise port A can be treated the same way as other ports

[Intel-gfx] [PATCH v3 1/9] drm/i915: Allocate power domain set wakerefs dynamically

2022-11-08 Thread Imre Deak
Since the intel_display_power_domain_set struct, currently its current size close to 1kB, can be allocated on the stack, it's better to allocate the per-domain wakeref pointer array - used for debugging - within the struct dynamically, so do this. The memory freeing is guaranteed by the fact that

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ttm: never purge busy objects

2022-11-08 Thread Vudum, Lakshminarayana
Issue is related to https://gitlab.freedesktop.org/drm/intel/-/issues/7379 Lakshmi. -Original Message- From: Auld, Matthew Sent: Tuesday, November 8, 2022 5:49 AM To: intel-gfx@lists.freedesktop.org; Vudum, Lakshminarayana Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915/ttm: never

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: never purge busy objects

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/ttm: never purge busy objects URL : https://patchwork.freedesktop.org/series/110601/ State : success == Summary == CI Bug Log - changes from CI_DRM_12351 -> Patchwork_110601v1 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/ttm: fix uaf with lmem_userfault_list handling

2022-11-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/ttm: fix uaf with lmem_userfault_list handling URL : https://patchwork.freedesktop.org/series/110613/ State : success == Summary == CI Bug Log - changes from CI_DRM_12351_full -> Patchwork_110613v1_full

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ttm: never purge busy objects

2022-11-08 Thread Matthew Auld
On 07/11/2022 17:57, Patchwork wrote: *Patch Details* *Series:* drm/i915/ttm: never purge busy objects *URL:* https://patchwork.freedesktop.org/series/110601/ *State:*failure *Details:*

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Allocate power domain set wakerefs dynamically

2022-11-08 Thread Imre Deak
On Tue, Nov 08, 2022 at 10:54:21AM +0200, Jani Nikula wrote: > On Mon, 07 Nov 2022, Imre Deak wrote: > > Since the intel_display_power_domain_set struct, currently its current > > size close 1kB, can be allocated on the stack, it's better to allocate > > the per-domain wakeref pointer array -

Re: [Intel-gfx] [Nouveau] [PATCH v7 00/23] drm: Analog TV Improvements

2022-11-08 Thread Geert Uytterhoeven
Hi Lukas, On Tue, Nov 8, 2022 at 2:20 PM Lukas Satin wrote: > One can switch from NTSC to PAL now using (on vc4) > > modetest -M vc4 -s 53:720x480i -w 53:'TV mode':1 # NTSC > modetest -M vc4 -s 53:720x576i -w 53:'TV mode':4 # PAL > > NTSC should be 640x480i, not 720. It will probably work on

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: Separate PXP FW interface structures for

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Separate PXP FW interface structures for URL : https://patchwork.freedesktop.org/series/110652/ State : success == Summary == CI Bug Log - changes from CI_DRM_12353_full -> Patchwork_110652v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Partial abandonment of legacy DRM logging macros (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: Partial abandonment of legacy DRM logging macros (rev2) URL : https://patchwork.freedesktop.org/series/110660/ State : success == Summary == CI Bug Log - changes from CI_DRM_12354 -> Patchwork_110660v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Partial abandonment of legacy DRM logging macros (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: Partial abandonment of legacy DRM logging macros (rev2) URL : https://patchwork.freedesktop.org/series/110660/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH v2] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-08 Thread Jani Nikula
On Tue, 08 Nov 2022, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Convert some usages of legacy DRM logging macros into versions which tell > us on which device have the events occurred. Acked-by: Jani Nikula > > v2: > * Don't have struct drm_device as local. (Jani, Ville) > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: use i915_sg_dma_sizes() for all backends (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: use i915_sg_dma_sizes() for all backends (rev2) URL : https://patchwork.freedesktop.org/series/110620/ State : success == Summary == CI Bug Log - changes from CI_DRM_12354 -> Patchwork_110620v2

[Intel-gfx] [PATCH v2] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Convert some usages of legacy DRM logging macros into versions which tell us on which device have the events occurred. v2: * Don't have struct drm_device as local. (Jani, Ville) Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula Cc: John Harrison Cc: Ville Syrjälä ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: use i915_sg_dma_sizes() for all backends (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: use i915_sg_dma_sizes() for all backends (rev2) URL : https://patchwork.freedesktop.org/series/110620/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use i915_sg_dma_sizes() for all backends (rev2)

2022-11-08 Thread Patchwork
== Series Details == Series: drm/i915: use i915_sg_dma_sizes() for all backends (rev2) URL : https://patchwork.freedesktop.org/series/110620/ State : warning == Summary == Error: dim checkpatch failed 681e3d6ac1e4 drm/i915: use i915_sg_dma_sizes() for all backends -:121: WARNING:AVOID_BUG: Do

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Move has_hdmi_sink out from intel_hdmi_compute_config()

2022-11-08 Thread Jani Nikula
On Mon, 07 Nov 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > We'll be wanting to compute has_hdmi_sink a bit differently > for some platforms. To that end compute it in the encoder > .compute_config_hook() before we call intel_hdmi_compute_config(). > intel_hdmi_compute_has_hdmi_sink()

Re: [Intel-gfx] [PATCH] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-08 Thread Tvrtko Ursulin
On 08/11/2022 12:01, Jani Nikula wrote: On Tue, 08 Nov 2022, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Convert some usages of legacy DRM logging macros into versions which tell us on which device have the events occurred. Signed-off-by: Tvrtko Ursulin Cc: Jani Nikula Cc: John Harrison

Re: [Intel-gfx] [PATCH] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-08 Thread Ville Syrjälä
> @@ -2744,6 +2745,7 @@ add_timeline_fence_array(struct i915_execbuffer *eb, >const struct > drm_i915_gem_execbuffer_ext_timeline_fences *timeline_fences) > { > struct drm_i915_gem_exec_fence __user *user_fences; > + struct drm_device *drm = >i915->drm; We've

Re: [Intel-gfx] [PATCH] drm/i915: Partial abandonment of legacy DRM logging macros

2022-11-08 Thread Jani Nikula
On Tue, 08 Nov 2022, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Convert some usages of legacy DRM logging macros into versions which tell > us on which device have the events occurred. > > Signed-off-by: Tvrtko Ursulin > Cc: Jani Nikula > Cc: John Harrison > --- >

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Treat HDMI as DVI when cloning

2022-11-08 Thread Jani Nikula
On Mon, 07 Nov 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > When doing HDMI+non-HDMI cloing the other sink can't get *cloning > the inframes/etc. so stuff like limited range output is *infoframes > not a good idea. > > Similarly when doing HDMI+HDMI cloning on g4x (only platform >

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Force RGB output for DVI sink

2022-11-08 Thread Jani Nikula
On Mon, 07 Nov 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > YCbCr output requires infoframes and whatnot, so don't allow > it when dealing with a DVI sink (or a HDMI sink we wishc to > treat as DVI). *wish Reviewed-by: Jani Nikula > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Introduce g4x_hdmi_compute_config()

2022-11-08 Thread Jani Nikula
On Mon, 07 Nov 2022, Ville Syrjala wrote: > From: Ville Syrjälä > > Start pulling some of the more platform specific things out from > intel_hdmi_compute_config(). has_pch_encoder is clearly one > such thing. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- >

  1   2   >