On 2022-11-25 05:21, Christian König wrote:
We already fallback to a dummy BO with no backing store when we
allocate GDS,GWS and OA resources and to GTT when we allocate VRAM.
Drop all those workarounds and generalize this for GTT as well. This
fixes ENOMEM issues with runaway applications
== Series Details ==
Series: drm/i915/mtl: Add OAG 32 bit format support for MTL (rev3)
URL : https://patchwork.freedesktop.org/series/111512/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12491 -> Patchwork_111512v3
== Series Details ==
Series: drm/i915/mtl: Add OAG 32 bit format support for MTL (rev3)
URL : https://patchwork.freedesktop.org/series/111512/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On MTL, gt->scratch was using stolen lmem. An MI_SRM to stolen lmem
caused a hang that was attributed to saving and restoring the GPR
registers used for noa_wait.
Add an additional page in noa_wait BO to save/restore GPR registers for
the noa_wait logic.
Signed-off-by: Umesh Nerlige Ramappa
0x20cc (WAIT_FOR_RC6_EXIT on other platforms) is repurposed on MTL. Use
a separate mux table to verify oa configs passed by user.
Signed-off-by: Umesh Nerlige Ramappa
Reviewed-by: Ashutosh Dixit
---
drivers/gpu/drm/i915/i915_perf.c | 16 +++-
1 file changed, 15 insertions(+), 1
Similar to ACM, OA timestamp that is part of the OA report is shifted
when compared to the CS timestamp. Add MTL to the WA.
Signed-off-by: Umesh Nerlige Ramappa
Reviewed-by: Ashutosh Dixit
---
drivers/gpu/drm/i915/i915_perf.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
Without an entry in oa_init_supported_formats, OA will not be functional
in MTL. Enable OA support by enabling 32 bit OAG formats for MTL.
Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20228
Signed-off-by: Umesh Nerlige Ramappa
Reviewed-by: Ashutosh Dixit
---
Enable OA for MTL by adding 32-bit OA format support and relevant fixes.
Signed-off-by: Umesh Nerlige Ramappa
Test-with: 20221129010522.994524-1-umesh.nerlige.rama...@intel.com
Umesh Nerlige Ramappa (4):
drm/i915/mtl: Resize noa_wait BO size to save restore GPR regs
drm/i915/mtl: Add
== Series Details ==
Series: drm/i915/display: drop redundant display/ from #includes
URL : https://patchwork.freedesktop.org/series/111803/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12489_full -> Patchwork_111803v1_full
== Series Details ==
Series: drm/i915/mtl: Initial display workarounds (rev3)
URL : https://patchwork.freedesktop.org/series/111592/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12491 -> Patchwork_111592v3
Summary
---
On Fri, Dec 09, 2022 at 02:05:43PM -0800, Matt Atwood wrote:
> From: Jouni Högander
>
> This patch introduces initial workarounds for mtl platform
>
> v2: switch IS_MTL_DISPLAY_STEP to use IS_METEORLAKE from testing display
> ver. (Tvrtko)
>
> v3: clerical issues, extend 16015201720 to mtl.
== Series Details ==
Series: series starting with [v6,1/3] drm/i915/migrate: Account for the
reserved_space (rev2)
URL : https://patchwork.freedesktop.org/series/111583/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12489_full -> Patchwork_111583v2_full
== Series Details ==
Series: drm/i915/mtl: Initial display workarounds (rev3)
URL : https://patchwork.freedesktop.org/series/111592/
State : warning
== Summary ==
Error: dim checkpatch failed
3477070797c1 drm/i915/mtl: Initial display workarounds
-:156: CHECK:MACRO_ARG_REUSE: Macro argument
From: Jouni Högander
This patch introduces initial workarounds for mtl platform
v2: switch IS_MTL_DISPLAY_STEP to use IS_METEORLAKE from testing display
ver. (Tvrtko)
v3: clerical issues, extend 16015201720 to mtl. (MattR)
v4: make sure 16015201720 includes display 13. (MattR)
Bspec: 66624
== Series Details ==
Series: drm/i915: remove struct_member macro
URL : https://patchwork.freedesktop.org/series/111802/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12489_full -> Patchwork_111802v1_full
Summary
---
== Series Details ==
Series: series starting with [1/5] linux/minmax.h: add non-atomic version of
xchg
URL : https://patchwork.freedesktop.org/series/111807/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12490 -> Patchwork_111807v1
== Series Details ==
Series: series starting with [1/5] linux/minmax.h: add non-atomic version of
xchg
URL : https://patchwork.freedesktop.org/series/111807/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Fri, Dec 09, 2022 at 08:56:28PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 09, 2022 at 04:48:39PM +0100, Andrzej Hajda wrote:
...
> > I hope there will be place for such tiny helper in kernel.
> > Quick cocci analyze shows there is probably few thousands places
> > where it could be used, of
On Fri, Dec 09, 2022 at 04:48:39PM +0100, Andrzej Hajda wrote:
> The pattern of setting variable with new value and returning old
> one is very common in kernel. Usually atomicity of the operation
> is not required, so xchg seems to be suboptimal and confusing in
> such cases. Since name xchg is
On Sun, 14 Aug 2022 16:46:54 -0700, Vinay Belgaumkar wrote:
>
> Host Turbo operates at efficient frequency when GT is not idle unless
> the user or workload has forced it to a higher level. Replicate the same
> behavior in SLPC by allowing the algorithm to use efficient frequency.
> We had
== Series Details ==
Series: ALSA: hda/hdmi: i915 keepalive fixes (rev2)
URL : https://patchwork.freedesktop.org/series/111781/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12488_full -> Patchwork_111781v2_full
Summary
On Fri, Dec 9, 2022, at 16:48, Andrzej Hajda wrote:
> The pattern of setting variable with new value and returning old
> one is very common in kernel. Usually atomicity of the operation
> is not required, so xchg seems to be suboptimal and confusing in
> such cases. Since name xchg is already in
Better use recently introduced kernel core helper.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gem/i915_gem_pages.c | 4 ++--
drivers/gpu/drm/i915/gem/i915_gem_stolen.c| 2 +-
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 6 +++---
Better use recently introduced kernel core helper.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
drivers/gpu/drm/i915/gvt/scheduler.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c
Better use recently introduced kernel core helper.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c| 2 +-
drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c | 4 ++--
drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4 ++--
Better use recently introduced kernel core helper.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/display/icl_dsi.c| 2 +-
drivers/gpu/drm/i915/display/intel_ddi.c | 6 ++---
drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
The pattern of setting variable with new value and returning old
one is very common in kernel. Usually atomicity of the operation
is not required, so xchg seems to be suboptimal and confusing in
such cases. Since name xchg is already in use and __xchg is used
in architecture code, proposition is
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev3)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12487_full -> Patchwork_111303v3_full
== Series Details ==
Series: drm/i915/display: drop redundant display/ from #includes
URL : https://patchwork.freedesktop.org/series/111803/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12489 -> Patchwork_111803v1
Summary
== Series Details ==
Series: series starting with [v6,1/3] drm/i915/migrate: Account for the
reserved_space (rev2)
URL : https://patchwork.freedesktop.org/series/111583/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12489 -> Patchwork_111583v2
Drop the redundant sub-directory from #includes under display/. Group
and sort the results.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c| 9 ++--
drivers/gpu/drm/i915/display/intel_display.c | 51 ++--
drivers/gpu/drm/i915/display/intel_psr.c
On 09/12/2022 12:14, Andrzej Hajda wrote:
Since it is used only to get type of member it can be replaced
with typeof_member.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/i915_utils.h | 4 +---
drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +-
2 files changed, 2
On Fri, 09 Dec 2022, Andrzej Hajda wrote:
> Since it is used only to get type of member it can be replaced
> with typeof_member.
Yes, please!
Reviewed-by: Jani Nikula
>
> Signed-off-by: Andrzej Hajda
> ---
> drivers/gpu/drm/i915/i915_utils.h | 4 +---
>
== Series Details ==
Series: drm/i915: remove struct_member macro
URL : https://patchwork.freedesktop.org/series/111802/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12489 -> Patchwork_111802v1
Summary
---
== Series Details ==
Series: drm/i915: Add support for GSC FW loading (rev4)
URL : https://patchwork.freedesktop.org/series/70/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12485_full -> Patchwork_70v4_full
On 09/12/2022 12:04, Tvrtko Ursulin wrote:
On 09/12/2022 11:33, Andrzej Hajda wrote:
On 09.12.2022 11:16, Tvrtko Ursulin wrote:
On 07/12/2022 17:36, Andrzej Hajda wrote:
Whole register/bit selection logic has been moved to separate helper.
Why is missing.
...to clean up
Since it is used only to get type of member it can be replaced
with typeof_member.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/i915_utils.h | 4 +---
drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git
== Series Details ==
Series: series starting with [1/2] drm/i915: fix TLB invalidation for Gen12.50
video and compute engines (rev2)
URL : https://patchwork.freedesktop.org/series/111744/
State : failure
== Summary ==
Error: patch
On 09/12/2022 11:33, Andrzej Hajda wrote:
On 09.12.2022 11:16, Tvrtko Ursulin wrote:
On 07/12/2022 17:36, Andrzej Hajda wrote:
Whole register/bit selection logic has been moved to separate helper.
Why is missing.
...to clean up mmio_invalidate_full function.
Will add.
On 09.12.2022 11:16, Tvrtko Ursulin wrote:
On 07/12/2022 17:36, Andrzej Hajda wrote:
Whole register/bit selection logic has been moved to separate helper.
Why is missing.
...to clean up mmio_invalidate_full function.
Will add.
Signed-off-by: Andrzej Hajda
---
== Series Details ==
Series: series starting with [v12,1/1] drm/i915/pxp: Promote pxp subsystem to
top-level of i915
URL : https://patchwork.freedesktop.org/series/111784/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12484_full -> Patchwork_111784v1_full
== Series Details ==
Series: series starting with [1/4] drm/i915/display: kill fetch_and_zero usage
URL : https://patchwork.freedesktop.org/series/111782/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12484_full -> Patchwork_111782v1_full
On Fri, 09 Dec 2022 11:18:19 +0100,
Kai Vehmanen wrote:
>
> A series with multiple fixes to i915 keepalive (KAE)
> functionality. First patch fixes issue that is hit on
> some A750/770 cards:
> https://gitlab.freedesktop.org/drm/intel/-/issues/7353
>
> The two other improve behaviour especially
== Series Details ==
Series: ALSA: hda/hdmi: i915 keepalive fixes (rev2)
URL : https://patchwork.freedesktop.org/series/111781/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12488 -> Patchwork_111781v2
Summary
---
On Fri, 09 Dec 2022, Arun R Murthy wrote:
> The busy timeout logic checks for the AUX BUSY, then waits for the
> timeout period and then after timeout reads the register for BUSY or
> Success.
> Instead replace interrupt with polling so as to read the AUX CTL
> register often before the timeout
When the new style KAE keep-alive implementation is used on compatible
Intel hardware, the clocks are maintained when codec is in D3. The
generic code in hda_cleanup_all_streams() can however interfere with
generation of audio samples in this mode, by setting the stream and
channel ids to zero.
If the stream-id is zero, the keep-alive (KAE) will only ensure clock is
generated, but no audio samples are sent over display link. This happens
before first real audio stream is played out to a newly connected
receiver.
Reuse the code in silent_stream_enable() to set up stream parameters
to
The i915 display codec may not successfully transition to
normal audio streaming mode, if the stream id is programmed
while codec is actively transmitting data. This can happen
when silent stream is enabled in KAE mode.
Fix the issue by implementing a i915 specific programming
flow, where the
A series with multiple fixes to i915 keepalive (KAE)
functionality. First patch fixes issue that is hit on
some A750/770 cards:
https://gitlab.freedesktop.org/drm/intel/-/issues/7353
The two other improve behaviour especially with certain
USB-C docks.
Changes in v2:
- check for errors from
On 07/12/2022 17:36, Andrzej Hajda wrote:
Whole register/bit selection logic has been moved to separate helper.
Why is missing.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/i915/gt/intel_gt.c | 136 +++--
1 file changed, 51 insertions(+), 85 deletions(-)
== Series Details ==
Series: ALSA: hda/hdmi: i915 keepalive fixes
URL : https://patchwork.freedesktop.org/series/111781/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12484_full -> Patchwork_111781v1_full
Summary
---
On 07/12/2022 17:36, Andrzej Hajda wrote:
In case of Gen12.50 video and compute engines, TLB_INV registers are
masked - to modify one bit, corresponding bit in upper half of the register
must be enabled, otherwise nothing happens.
Fixes: 77fa9efc16a9 ("drm/i915/xehp: Create separate reg
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry include sw delay (rev3)
URL : https://patchwork.freedesktop.org/series/111303/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12487 -> Patchwork_111303v3
On Thu, 08 Dec 2022, Lucas De Marchi wrote:
> On Thu, Dec 08, 2022 at 03:36:38PM +0200, Jani Nikula wrote:
>>Remove an unnecessary include.
>>
>>Signed-off-by: Jani Nikula
>
> maybe we should run a script/something to check for unneeded includes
> and commit everything? Then we can add a check
On Thu, 08 Dec 2022, Lucas De Marchi wrote:
> On Thu, Dec 08, 2022 at 03:36:38PM +0200, Jani Nikula wrote:
>>Remove an unnecessary include.
>>
>>Signed-off-by: Jani Nikula
>
> maybe we should run a script/something to check for unneeded includes
> and commit everything? Then we can add a check
On Wed, 23 Nov 2022, Khaled Almahallawy wrote:
> Bspecs has updated recently to remove the restriction to disable
> DDI/Transcoder before setting PHY test pattern. This update is to
> address PHY compliance test failures observed on a port with LTTPR.
> The issue is that when Transc. is disabled,
Hi,
On Thu, 8 Dec 2022, Amadeusz Sławiński wrote:
> On 12/8/2022 4:43 PM, Kai Vehmanen wrote:
> > @@ -2879,9 +2879,28 @@ static int i915_hsw_setup_stream(struct hda_codec
> > *codec, hda_nid_t cvt_nid,
> > hda_nid_t pin_nid, int dev_id, u32
> > stream_tag,
> >
The busy timeout logic checks for the AUX BUSY, then waits for the
timeout period and then after timeout reads the register for BUSY or
Success.
Instead replace interrupt with polling so as to read the AUX CTL
register often before the timeout period. Looks like there might be some
issue with
58 matches
Mail list logo
