Re: [Intel-gfx] [PATCH v3 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-19 Thread Kandpal, Suraj
> > On Wed, 2022-12-14 at 14:37 +0530, Suraj Kandpal wrote: > > Add function that takes care of sending command to gsc cs. We start of > > with allocation of memory for our command intel_hdcp_gsc_message that > > contains gsc cs memory header as directed in specs followed by the > > actual payload

Re: [Intel-gfx] [PATCH v3 1/7] drm/i915/gsc: Create GSC request submission mechanism

2022-12-19 Thread Kandpal, Suraj
> On Wed, 2022-12-14 at 14:37 +0530, Kandpal, Suraj wrote: > > HDCP and PXP will require a common function to allow it to submit > > commands to the gsc cs. Also adding the gsc mtl header that needs to > > be added on to the existing payloads of HDCP and PXP. > > > > Cc: Daniele Ceraolo Spurio >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use helper func to find out map type (rev2)

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Use helper func to find out map type (rev2) URL : https://patchwork.freedesktop.org/series/112013/ State : success == Summary == CI Bug Log - changes from CI_DRM_12515_full -> Patchwork_112013v2_full S

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence (rev5)

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence (rev5) URL : https://patchwork.freedesktop.org/series/111850/ State : success == Summary == CI Bug Log - changes from CI_DRM_12515_full -> Patchwork_111850v5_full =

[Intel-gfx] [PATCH v2] drm/i915/hdmi: Go for scrambling only if platform supports TMDS clock > 340MHz

2022-12-19 Thread Ankit Nautiyal
There are cases, where devices have an HDMI1.4 retimer, and TMDS clock rate is capped to 340MHz via VBT. In such cases scrambling might be supported by the platform and an HDMI2.0 sink for lower TMDS rates, but not supported by the retimer, causing blankouts. So avoid enabling scrambling, if the T

[Intel-gfx] ✓ Fi.CI.IGT: success for TLB invalidation cleanup

2022-12-19 Thread Patchwork
== Series Details == Series: TLB invalidation cleanup URL : https://patchwork.freedesktop.org/series/112047/ State : success == Summary == CI Bug Log - changes from CI_DRM_12515_full -> Patchwork_112047v1_full Summary --- **SUCCESS**

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Fix a static analysis warning

2022-12-19 Thread John . C . Harrison
From: John Harrison A static analyser was complaining about not checking for null pointers. However, the location of the complaint can only be reached in the first place if said pointer is non-null. Basically, if we are using a v69 GuC then the descriptor pool is guaranteed to be alocated at star

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Fix missing return code checks in submission init

2022-12-19 Thread John . C . Harrison
From: John Harrison The CI results for the 'fast request' patch set (enables error return codes for fire-and-forget H2G messages) hit an issue with the KMD sending context submission requests on an invalid context. That was caused by a fault injection probe failing the context creation of a kerne

[Intel-gfx] [PATCH 3/3] drm/i915/uc: Fix two issues with over-size firmware files

2022-12-19 Thread John . C . Harrison
From: John Harrison In the case where a firmware file is too large (e.g. someone downloaded a web page ASCII dump from github...), the firmware object is released but the pointer is not zerod. If no other firmware file was found then release would be called again leading to a double kfree. Also,

[Intel-gfx] [PATCH 0/3] Fixes for various UC related issues

2022-12-19 Thread John . C . Harrison
From: John Harrison Fix a bunch of assorted issues with firmware loading and GuC intialisation. Signed-off-by: John Harrison John Harrison (3): drm/i915/guc: Fix missing return code checks in submission init drm/i915/guc: Fix a static analysis warning drm/i915/uc: Fix two issues with ov

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add support of Tile4 to MTL

2022-12-19 Thread Juha-Pekka Heikkila
Hi Stan, On 19.12.2022 15.50, Stanislav Lisovskiy wrote: We have some Tile4 tests now skipping, which were supposed to be working. So lets make them work, by adding display_ver 14 as supported. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_fb.c | 8 1 fi

Re: [Intel-gfx] [PATCH v2] drm/i915: Use helper func to find out map type

2022-12-19 Thread Andrzej Hajda
On 19.12.2022 12:29, Nirmoy Das wrote: Use i915_coherent_map_type() function to find out map_type of the shmem obj. v2: handle non-llc platform(Matt) Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 1/1] drm/i915: re-disable RC6p on Sandy Bridge

2022-12-19 Thread Sasa Dragic
RC6p on Sandy Bridge got re-enabled over time, causing visual glitches and GPU hangs. Disabled originally in commit 1c8ecf80fdee ("drm/i915: do not enable RC6p on Sandy Bridge"). Signed-off-by: Sasa Dragic --- drivers/gpu/drm/i915/i915_pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

[Intel-gfx] [PATCH 0/1] fix RC6p related regression on Sandy Bridge

2022-12-19 Thread Sasa Dragic
Hi all, RC6p got re-enabled on Sandy Bridge over time, seemingly by accident over time, causing graphical glitches and occasional GPU hangs on my old ThinkPad T420, severity depending on kernel version. It is a known issue, e.g.: https://wiki.ubuntu.com/Kernel/PowerManagementRC6 https://www.yocto

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Accomodate for nested dma_resv fence addition

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Accomodate for nested dma_resv fence addition URL : https://patchwork.freedesktop.org/series/112054/ State : warning == Summary == Error: dim checkpatch failed ce8f7ee44caa drm/i915: Accomodate for nested dma_resv fence addition -:4: WARNING:TYPO_SPELLING

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use helper func to find out map type (rev2)

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Use helper func to find out map type (rev2) URL : https://patchwork.freedesktop.org/series/112013/ State : success == Summary == CI Bug Log - changes from CI_DRM_12515 -> Patchwork_112013v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Use helper func to find out map type (rev2)

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915: Use helper func to find out map type (rev2) URL : https://patchwork.freedesktop.org/series/112013/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence (rev5)

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence (rev5) URL : https://patchwork.freedesktop.org/series/111850/ State : success == Summary == CI Bug Log - changes from CI_DRM_12515 -> Patchwork_111850v5 ===

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2022-12-19 Thread Andrzej Hajda
On 19.12.2022 11:13, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the corresponding code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise

[Intel-gfx] [PATCH 17/18] fbdev/vga16fb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vga16fb.c | 15 +

[Intel-gfx] [PATCH 10/18] fbdev/efifb: Add struct efifb_par for driver data

2022-12-19 Thread Thomas Zimmermann
The efifb_par structure holds the palette for efifb. It will also be useful for storing the device's aperture range. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/efifb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/driv

[Intel-gfx] [PATCH 13/18] fbdev/offb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/offb.c | 20

[Intel-gfx] [PATCH 12/18] fbdev/offb: Allocate struct offb_par with framebuffer_alloc()

2022-12-19 Thread Thomas Zimmermann
Move the palette array into struct offb_par and allocate both via framebuffer_alloc(), as intended by fbdev. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/offb.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbde

[Intel-gfx] [PATCH 03/18] drm/gma500: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in gma500. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/framebuffer.c | 5 - 1 file changed, 5 deletions(-) diff --git a/d

[Intel-gfx] [PATCH 15/18] fbdev/vesafb: Remove trailing whitespaces

2022-12-19 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vesafb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c index 929d4775cb4b..47ce244e4bb8 100644 --- a/driv

[Intel-gfx] [PATCH 14/18] fbdev/simplefb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/simplefb.c | 19

[Intel-gfx] [PATCH 16/18] fbdev/vesafb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vesafb.c | 27 ++

[Intel-gfx] [PATCH 06/18] drm/fb-helper: Do not allocate unused apertures structure

2022-12-19 Thread Thomas Zimmermann
The apertures field in struct fb_info is not used by DRM drivers. Do not allocate it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/d

[Intel-gfx] [PATCH 01/18] fbcon: Remove trailing whitespaces

2022-12-19 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbcon.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index c0143d38df83..50

[Intel-gfx] [PATCH 09/18] vfio-mdev/mdpy-fb: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in mdpy-fb. Signed-off-by: Thomas Zimmermann --- samples/vfio-mdev/mdpy-fb.c | 8 1 file changed, 8 deletions(-) diff --git a/sample

[Intel-gfx] [PATCH 07/18] fbdev/clps711x-fb: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in clps711x-fb. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/clps711x-fb.c | 10 +- 1 file changed, 1 insertion(+), 9 dele

[Intel-gfx] [PATCH 00/18] drm, fbdev: Remove apertures structure and FBINFO_MISC_FIRMWARE

2022-12-19 Thread Thomas Zimmermann
Remove struct fb_info.apertures and FBINFO_MISC_FIRMWARE from fbdev and handle the aperture ownership without involving the fbdev core. The apertures field in struct fb_info is a remnant from earlier ownership management for framebuffer apertures. When fbdev core code still handled ownership of th

[Intel-gfx] [PATCH 18/18] drm/fbdev: Remove aperture handling and FBINFO_MISC_FIRMWARE

2022-12-19 Thread Thomas Zimmermann
There are no users left of struct fb_info.apertures and the flag FBINFO_MISC_FIRMWARE. Remove both and the aperture-ownership code in the fbdev core. All code for aperture ownership is now located in the fbdev drivers. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbmem.c | 33

[Intel-gfx] [PATCH 11/18] fbdev/efifb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/efifb.c | 24 +++

[Intel-gfx] [PATCH 08/18] fbdev/hyperv-fb: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in hyperv-fb. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/hyperv_fb.c | 17 ++--- 1 file changed, 6 insertions(+), 11

[Intel-gfx] [PATCH 05/18] drm/radeon: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in radeon. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/radeon_fb.c | 4 1 file changed, 4 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH 02/18] Revert "fbcon: don't lose the console font across generic->chip driver switch"

2022-12-19 Thread Thomas Zimmermann
This reverts commit ae1287865f5361fa138d4d3b1b6277908b54eac9. Always free the console font when deinitializing the framebuffer console. Subsequent framebuffer consoles will then use the default font. Rely on userspace to load any user-configured font for these consoles. Commit ae1287865f53 ("fbco

[Intel-gfx] [PATCH 04/18] drm/i915: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in i915. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display/intel_fbdev.c | 7 --- 1 file changed, 7 deletions(-) diff --g

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence (rev5)

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence (rev5) URL : https://patchwork.freedesktop.org/series/111850/ State : warning == Summary == Error: dim checkpatch failed 60bdaba1b923 drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence -:21: WAR

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: implement wa 14015076503

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915/mtl: implement wa 14015076503 URL : https://patchwork.freedesktop.org/series/112049/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12515 -> Patchwork_112049v1 Summary --- **FAILU

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not cover all future platforms in TLB invalidation

2022-12-19 Thread Andrzej Hajda
On 19.12.2022 11:13, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. Signed-off-by: Tvrtko Ursulin Cc: Matt Roper Cc: Balasubramani Vivekanandan Cc: Andrzej Hajda Reviewed-by: Andrzej Hajda Regards Andrzej ---

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/display/vlv: fix pixel overlap register update

2022-12-19 Thread Andrzej Hajda
On 19.12.2022 15:41, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* series starting with [1/2] drm/i915/display/vlv: fix pixel overlap register update *URL:* https://patchwork.freedesktop.org/series/112045/ *State:*failure *Details:* https://intel-gfx-ci.01.org

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: implement wa 14015076503

2022-12-19 Thread Patchwork
== Series Details == Series: drm/i915/mtl: implement wa 14015076503 URL : https://patchwork.freedesktop.org/series/112049/ State : warning == Summary == Error: dim checkpatch failed d1196b447e76 drm/i915/mtl: implement wa 14015076503 -:155: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'base' may

[Intel-gfx] ✓ Fi.CI.BAT: success for TLB invalidation cleanup

2022-12-19 Thread Patchwork
== Series Details == Series: TLB invalidation cleanup URL : https://patchwork.freedesktop.org/series/112047/ State : success == Summary == CI Bug Log - changes from CI_DRM_12515 -> Patchwork_112047v1 Summary --- **SUCCESS** No reg

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/display/vlv: fix pixel overlap register update

2022-12-19 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/vlv: fix pixel overlap register update URL : https://patchwork.freedesktop.org/series/112045/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12515 -> Patchwork_112045v1 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for TLB invalidation cleanup

2022-12-19 Thread Patchwork
== Series Details == Series: TLB invalidation cleanup URL : https://patchwork.freedesktop.org/series/112047/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH] drm/i915/mtl: Add support of Tile4 to MTL

2022-12-19 Thread Stanislav Lisovskiy
We have some Tile4 tests now skipping, which were supposed to be working. So lets make them work, by adding display_ver 14 as supported. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_fb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH] drm/i915/display/dsi: use intel_de_rmw if possible

2022-12-19 Thread Andrzej Hajda
The helper makes the code more compact and readable. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/icl_dsi.c | 256 - 1 file changed, 82 insertions(+), 174 deletions(-) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/ic

Re: [Intel-gfx] [PATCH] drm/i915: Accomodate for nested dma_resv fence addition

2022-12-19 Thread Das, Nirmoy
This needs better explanation and probably CC to stable. Please ignore this, I will resend. Nirmoy On 12/19/2022 1:36 PM, Nirmoy Das wrote: We have below nested fence slot reservation and then fence addition to that dma_resv. dma_resv_reserve_fences() from --> ttm_bo_handle_move_mem()

[Intel-gfx] [PATCH] drm/i915: Accomodate for nested dma_resv fence addition

2022-12-19 Thread Nirmoy Das
We have below nested fence slot reservation and then fence addition to that dma_resv. dma_resv_reserve_fences() from --> ttm_bo_handle_move_mem() dma_resv_reserve_fences() from --> i915_vma_unbind_async() dma_resv_add_fence() from --> i915_vma_unbind_async() dma_resv_add_fence() fro

[Intel-gfx] [PATCH v2] drm/i915: Use helper func to find out map type

2022-12-19 Thread Nirmoy Das
Use i915_coherent_map_type() function to find out map_type of the shmem obj. v2: handle non-llc platform(Matt) Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/shmem_utils.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/shmem_utils.c b/

[Intel-gfx] [PATCH v5] drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence

2022-12-19 Thread Jani Nikula
Starting from ICL, the default for MIPI GPIO sequences seems to be using native GPIOs i.e. GPIOs available in the GPU. These native GPIOs reuse many pins that quite frankly seem scary to poke based on the VBT sequences. We pretty much have to trust that the board is configured such that the relevan

[Intel-gfx] [PATCH] drm/i915/mtl: implement wa 14015076503

2022-12-19 Thread Daniele Ceraolo Spurio
The WA states that before doing a GSC engine reset we need to alert the GSC FW and then wait for 200ms for the FW to get ready for it. The GuC will take care of this for engine reset, but i915 is still responsible for the full GT reset scenario. Given that we do full GT resets in the resume paths

Re: [Intel-gfx] [PATCH v2] drm/i915: improve the catch-all evict to handle lock contention

2022-12-19 Thread Matthew Auld
On Sun, 18 Dec 2022 at 23:50, Mani Milani wrote: > > Thank you for updating the docs Matthew. I am looking forward to this > patch landing. Pushed to drm-intel-gt-next. Thanks for the reviews. > > On Fri, Dec 16, 2022 at 10:35 PM Matthew Auld wrote: > > > > The catch-all evict can fail due to o

Re: [Intel-gfx] [PATCHv6] drm/i915/dp: change aux_ctl reg read to polling read

2022-12-19 Thread Murthy, Arun R
Any comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Thursday, December 15, 2022 4:44 PM > To: intel-gfx@lists.freedesktop.org; ville.syrj...@linux.intel.com; Nikula, > Jani > ; Deak, Imre > Cc: Murthy, Arun R > Subje

[Intel-gfx] [PATCH 1/2] drm/i915: Do not cover all future platforms in TLB invalidation

2022-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. Signed-off-by: Tvrtko Ursulin Cc: Matt Roper Cc: Balasubramani Vivekanandan Cc: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.c | 13 - 1 file changed, 12 insertions(+), 1 de

[Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2022-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise the amount of invariant platform and engine checks during each

[Intel-gfx] [PATCH 0/2] TLB invalidation cleanup

2022-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin First patch to make the platform check not catch all due current lack of automated testing. Second patch to consolidate the code a bit and move invariant setup at engine init time. Don't think I want to merge this one until some test coverage can be had. Tvrtko Ursulin (2):

[Intel-gfx] ✓ Fi.CI.IGT: success for Copy highest enabled wm level to disabled wm levels for gen >= 12

2022-12-19 Thread Patchwork
== Series Details == Series: Copy highest enabled wm level to disabled wm levels for gen >= 12 URL : https://patchwork.freedesktop.org/series/112039/ State : success == Summary == CI Bug Log - changes from CI_DRM_12513_full -> Patchwork_112039v1_full ===

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/vlv: fix pixel overlap register update

2022-12-19 Thread Jani Nikula
On Mon, 19 Dec 2022, Andrzej Hajda wrote: > To update properly bits in the register the mask should be used > to clear old value and then the result should be or-ed with new > value, for such updates there is separate helper intel_de_rmw. > > Signed-off-by: Andrzej Hajda Seems like the right thi

[Intel-gfx] [PATCH 2/2] drm/i915/display/vlv: use intel_de_rmw if possible

2022-12-19 Thread Andrzej Hajda
The helper makes the code more compact and readable. Signed-off-by: Andrzej Hajda Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/vlv_dsi.c | 132 ++--- drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 18 +-- 2 files changed, 41 insertions(+), 109 deletions(-) diff

[Intel-gfx] [PATCH 1/2] drm/i915/display/vlv: fix pixel overlap register update

2022-12-19 Thread Andrzej Hajda
To update properly bits in the register the mask should be used to clear old value and then the result should be or-ed with new value, for such updates there is separate helper intel_de_rmw. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/vlv_dsi.c | 24 +--- 1

Re: [Intel-gfx] [PATCH v3] drm: Only select I2C_ALGOBIT for drivers that actually need it

2022-12-19 Thread Javier Martinez Canillas
Hello Uwe, On 12/19/22 09:36, Uwe Kleine-König wrote: > While working on a drm driver that doesn't need the i2c algobit stuff I > noticed that DRM selects this code even though only 8 drivers actually use > it. While also only some drivers use i2c, keep the select for I2C for the > next cleanup pa

Re: [Intel-gfx] [PATCH v6] drm: Optimise for continuous memory allocation

2022-12-19 Thread Christian König
Am 18.12.22 um 07:57 schrieb xinhui pan: Optimise a little when continuous memory request fails. There are memory holes and continuous memory request usually fails when order is too big. Currently buddy only look for exactly order memory for such request. Now we can try again to look for several

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-19 Thread Wang, Zhi A
On 12/19/2022 9:57 AM, Zheng Wang wrote: > Hi Zhi, > > Thanks again for your reply and clear explaination about the function. > I still have some doubt about the fix. Here is a invoke chain : > ppgtt_populate_spt >->ppgtt_populate_shadow_entry > ->split_2MB_gtt_entry > As far as I'm conce

[Intel-gfx] ✓ Fi.CI.BAT: success for Copy highest enabled wm level to disabled wm levels for gen >= 12

2022-12-19 Thread Patchwork
== Series Details == Series: Copy highest enabled wm level to disabled wm levels for gen >= 12 URL : https://patchwork.freedesktop.org/series/112039/ State : success == Summary == CI Bug Log - changes from CI_DRM_12513 -> Patchwork_112039v1