[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable XE_HP 4Tile support

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915: Enable XE_HP 4Tile support URL : https://patchwork.freedesktop.org/series/112143/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_112143v1 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/display/core: use intel_de_rmw if possible

2022-12-21 Thread Andrzej Hajda
On 22.12.2022 04:07, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* series starting with [1/2] drm/i915/display/core: use intel_de_rmw if possible *URL:* https://patchwork.freedesktop.org/series/112101/ *State:*failure *Details:*

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/fbdev: Implement fb_dirty for intel custom fb helper (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/fbdev: Implement fb_dirty for intel custom fb helper (rev2) URL : https://patchwork.freedesktop.org/series/111433/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_111433v2

[Intel-gfx] [PATCH v4 7/7] drm/i915/mtl: Add HDCP GSC interface

2022-12-21 Thread Suraj Kandpal
MTL uses GSC command streamer i.e gsc cs to send HDCP/PXP commands to GSC f/w. It requires to keep hdcp display driver agnostic to content protection f/w (ME/GSC fw) in the form of i915_hdcp_fw_ops generic ops. Adding HDCP GSC CS interface by leveraging the i915_hdcp_fw_ops generic ops instead of

[Intel-gfx] [PATCH v4 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-21 Thread Suraj Kandpal
Add function that takes care of sending command to gsc cs. We start of with allocation of memory for our command intel_hdcp_gsc_message that contains gsc cs memory header as directed in specs followed by the actual payload hdcp message that we want to send. Spec states that we need to poll pending

[Intel-gfx] [PATCH v4 4/7] drm/i915/hdcp: Refactor HDCP API structures

2022-12-21 Thread Suraj Kandpal
It requires to move intel specific HDCP API structures to i915_cp_fw_hdcp_interface.h from driver/misc/mei/hdcp/mei_hdcp.h so that any content protection fw interfaces can use these structures. Cc: Tomas Winkler Cc: Rodrigo Vivi Cc: Uma Shankar Cc: Ankit Nautiyal Signed-off-by: Anshuman Gupta

[Intel-gfx] [PATCH v4 5/7] drm/i915/hdcp: Fill wired_cmd_in structures at a single place

2022-12-21 Thread Suraj Kandpal
Need to fill wired cmd in structures at a single place as they remain same for both gsc and mei. --v3 -remove inline function from header [Jani] Cc: Ankit Nautiyal Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_hdcp_interface.c |

[Intel-gfx] [PATCH v4 3/7] i915/hdcp: HDCP2.x Refactoring to agnostic hdcp

2022-12-21 Thread Suraj Kandpal
As now we have more then one type of content protection secrity firmware. Let change the i915_cp_fw_hdcp_interface.h header naming convention to suit generic f/w type. %s/MEI_/HDCP_ %s/mei_dev/hdcp_dev As interface to CP FW can be either a non i915 component or i915 intergral component, change

[Intel-gfx] [PATCH v4 2/7] drm/i915/hdcp: Keep cp fw agonstic naming convention

2022-12-21 Thread Suraj Kandpal
From: Anshuman Gupta Change the include/drm/i915_mei_hdcp_interface.h to include/drm/i915_hdcp_interface.h Cc: Tomas Winkler Cc: Rodrigo Vivi Cc: Uma Shankar Cc: Ankit Nautiyal Signed-off-by: Anshuman Gupta Signed-off-by: Suraj Kandpal Acked-by: Tomas Winkler ---

[Intel-gfx] [PATCH v4 1/7] drm/i915/gsc: Create GSC request submission mechanism

2022-12-21 Thread Suraj Kandpal
HDCP and PXP will require a common function to allow it to submit commands to the gsc cs. Also adding the gsc mtl header that needs to be added on to the existing payloads of HDCP and PXP. --v4 -Seprate gsc load and heci cmd submission into different functions in different files for better

[Intel-gfx] [PATCH v4 0/7] Enable HDCP2.x via GSC CS

2022-12-21 Thread Suraj Kandpal
These patches enable HDCP2.x on machines MTL and above. >From MTL onwards CSME is spilt into GSC and CSC and now we use GSC CS instead of MEI to talk to firmware to start HDCP authentication --v2 -Fixing some checkpatch changes which I forgot before sending out the series --v3 -Drop cp and fw to

[Intel-gfx] [PATCH] drm/i915/dsb: Remove check for dsb in dsb_commit

2022-12-21 Thread Ankit Nautiyal
The dsb context should be already checked for NULL, before dsb_commit gets called. So remove the check for dsb inside dsb_commit. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dsb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Make firmware loading backwards-compatible (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Make firmware loading backwards-compatible (rev2) URL : https://patchwork.freedesktop.org/series/112116/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_112116v2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index (rev2) URL : https://patchwork.freedesktop.org/series/112108/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_112108v2_full

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dmc: Make firmware loading backwards-compatible (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Make firmware loading backwards-compatible (rev2) URL : https://patchwork.freedesktop.org/series/112116/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Implement Wa_14015648006 (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/display: Implement Wa_14015648006 (rev2) URL : https://patchwork.freedesktop.org/series/103518/ State : success == Summary == CI Bug Log - changes from CI_DRM_12521 -> Patchwork_103518v2 Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev9)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry include sw delay (rev9) URL : https://patchwork.freedesktop.org/series/111303/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_111303v9_full

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/ddi: Align timeout for DDI_BUF_CTL active with Bspec

2022-12-21 Thread Nautiyal, Ankit K
Hi Lucas, Thanks for catching the issues. For ADL-P I will send a new patch to correct the timeout to 500usec. Thanks & Regards, Ankit On 12/22/2022 5:31 AM, Lucas De Marchi wrote: On Wed, Dec 07, 2022 at 08:24:36PM +0530, Ankit Nautiyal wrote: For Gen12+ wait for 1ms for Combo Phy and

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version URL : https://patchwork.freedesktop.org/series/112120/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_112120v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/color: Add function to load degamma LUT in MTL

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/color: Add function to load degamma LUT in MTL URL : https://patchwork.freedesktop.org/series/112135/ State : success == Summary == CI Bug Log - changes from CI_DRM_12520 -> Patchwork_112135v1 Summary

[Intel-gfx] [PATCH v3] drm/i915/hdmi: Go for scrambling only if platform supports TMDS clock > 340MHz

2022-12-21 Thread Ankit Nautiyal
There are cases, where devices have an HDMI1.4 retimer, and TMDS clock rate is capped to 340MHz via VBT. In such cases scrambling might be supported by the platform and an HDMI2.0 sink for lower TMDS rates, but not supported by the retimer, causing blankouts. So avoid enabling scrambling, if the

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixes for intel fb helper

2022-12-21 Thread Patchwork
== Series Details == Series: Fixes for intel fb helper URL : https://patchwork.freedesktop.org/series/112133/ State : success == Summary == CI Bug Log - changes from CI_DRM_12520 -> Patchwork_112133v1 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: Add support of Tile4 to MTL (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add support of Tile4 to MTL (rev2) URL : https://patchwork.freedesktop.org/series/112063/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_112063v2_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/display/core: use intel_de_rmw if possible

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/core: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/112101/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_112101v1_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ttm: remove the virtualized start hack

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/ttm: remove the virtualized start hack URL : https://patchwork.freedesktop.org/series/112100/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_112100v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index (rev2) URL : https://patchwork.freedesktop.org/series/112108/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_112108v2

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2) URL : https://patchwork.freedesktop.org/series/111967/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_111967v2_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix a use-after-free when intel_edp_init_connector fails

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix a use-after-free when intel_edp_init_connector fails URL : https://patchwork.freedesktop.org/series/112091/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_112091v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: wait on timeout before retry include sw delay (rev9)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/dp: wait on timeout before retry include sw delay (rev9) URL : https://patchwork.freedesktop.org/series/111303/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_111303v9

Re: [Intel-gfx] [PATCH v3 1/7] drm/i915/gsc: Create GSC request submission mechanism

2022-12-21 Thread Teres Alexis, Alan Previn
> > > Alan:[snip] > > > + u8 gsc_address; > > > +#define HECI_MEADDRESS_PXP 17 > > > +#define HECI_MEADDRESS_HDCP 18 > > > + Alan: btw, from the internal specs, if i understand it correctly, at the heci command packet level, this ought to be called "heci_client_id", not "gsc_address".

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version URL : https://patchwork.freedesktop.org/series/112120/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_112120v1

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-21 Thread Lucas De Marchi
On Wed, Dec 21, 2022 at 12:26:26PM +0200, Jani Nikula wrote: On Tue, 20 Dec 2022, Gustavo Sousa wrote: As we do not require specific versions anymore, change the convention for blob filenames to stop using version numbers. This simplifies code maintenance, since we do not need to keep updating

Re: [Intel-gfx] LOOKS GOOD: Possible regression in drm/i915 driver: memleak

2022-12-21 Thread Mirsad Goran Todorovac
On 20. 12. 2022. 20:34, Mirsad Todorovac wrote: On 12/20/22 16:52, Tvrtko Ursulin wrote: On 20/12/2022 15:22, srinivas pandruvada wrote: +Added DRM mailing list and maintainers On Tue, 2022-12-20 at 15:33 +0100, Mirsad Todorovac wrote: Hi all, I have been unsuccessful to find any

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add support of Tile4 to MTL (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Add support of Tile4 to MTL (rev2) URL : https://patchwork.freedesktop.org/series/112063/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_112063v2 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for treewide: Convert del_timer*() to timer_shutdown*()

2022-12-21 Thread Patchwork
== Series Details == Series: treewide: Convert del_timer*() to timer_shutdown*() URL : https://patchwork.freedesktop.org/series/112115/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/112115/revisions/1/mbox/ not applied Applying: treewide:

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/ddi: Align timeout for DDI_BUF_CTL active with Bspec

2022-12-21 Thread Lucas De Marchi
On Wed, Dec 07, 2022 at 08:24:36PM +0530, Ankit Nautiyal wrote: For Gen12+ wait for 1ms for Combo Phy and 3ms for TC Phy for description here doesn't match the code as DG2 is also >= 12. Maybe just mention that the values are following the updated ones in bspec? DDI_BUF_CTL to be active for

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v4,1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14 URL : https://patchwork.freedesktop.org/series/111779/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519_full -> Patchwork_111779v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/display/core: use intel_de_rmw if possible

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/core: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/112101/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_112101v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ttm: remove the virtualized start hack

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/ttm: remove the virtualized start hack URL : https://patchwork.freedesktop.org/series/112100/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_112100v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Possible regression in drm/i915 driver: memleak

2022-12-21 Thread Patchwork
== Series Details == Series: Possible regression in drm/i915 driver: memleak URL : https://patchwork.freedesktop.org/series/112109/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/112109/revisions/1/mbox/ not applied Applying: Possible regression

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2) URL : https://patchwork.freedesktop.org/series/111967/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_111967v2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix a use-after-free when intel_edp_init_connector fails

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix a use-after-free when intel_edp_init_connector fails URL : https://patchwork.freedesktop.org/series/112091/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_112091v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/display/core: use intel_de_rmw if possible

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display/core: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/112101/ State : warning == Summary == Error: dim checkpatch failed d968db4e1183 drm/i915/display/core: use intel_de_rmw if possible -:26:

[Intel-gfx] [PATCH v3 7/7] HAX: force enable PXP Kconfig

2022-12-21 Thread Alan Previn
Force PXP configs on for CI testing to trigger full subtests in IGT's gem_pxp as opposed to the partial "unsupported hw substests". Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Kconfig | 2 +- drivers/misc/mei/pxp/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v3 5/7] drm/i915/pxp: Trigger the global teardown for before suspending

2022-12-21 Thread Alan Previn
A driver bug was recently discovered where the security firmware was receiving internal HW signals indicating that session key expirations had occurred. Architecturally, the firmware was expecting a response from the GuC to acknowledge the event with the firmware side. However the OS was in a

[Intel-gfx] [PATCH v3 6/7] drm/i915/pxp: Pxp hw init should be in resume_complete

2022-12-21 Thread Alan Previn
During suspend flow, i915 currently achors' on the pm_suspend_prepare callback as the location where we quiesce the entire GPU and perform all necessary cleanup in order to go into suspend. PXP is also called during this time to perform the arbitration session teardown (with the assurance no

[Intel-gfx] [PATCH v3 3/7] mei: clean pending read with vtag on bus

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Client on bus have only one vtag map slot and should disregard the vtag value when cleaning pending read flag. Fixes read flow control message unexpectedly generated when clent on bus send messages with different vtags. Signed-off-by: Alexander Usyskin ---

[Intel-gfx] [PATCH v3 1/7] mei: mei-me: resume device in prepare

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Async runtime resume is not possible while system is suspending. The power management subsystem resumes device only in the suspend phase, not in the prepare phase. Force resume device in prepare to allow drivers on mei bus to communicate in prepare callbacks.

[Intel-gfx] [PATCH v3 4/7] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

2022-12-21 Thread Alan Previn
A gap was recently discovered where if an application did not invalidate all of the stream keys (intentionally or not), and the driver did a full PXP global teardown on the GT subsystem, we find that future session creation would fail on the security firmware's side of the equation. i915 is the

[Intel-gfx] [PATCH v3 2/7] drm/i915/pxp: add device link between i915 and mei_pxp

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Add device link with i915 as consumer and mei_pxp as supplier to ensure proper ordering of power flows. V2: condition on absence of heci_pxp to filter out DG Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 7 +++ 1 file changed, 7

[Intel-gfx] [PATCH v3 0/7] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

2022-12-21 Thread Alan Previn
A customer issue was recently discovered and in the process a gap in i915's PXP interaction with HW+FW architecure was also realized. This series adds those missing pieces. This fix includes changes where i915 calls into the mei component interface in order to submit requests to the security

Re: [Intel-gfx] [PATCH v3 0/7] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

2022-12-21 Thread Teres Alexis, Alan Previn
Apologies for the noise, please ignore this thread - will resend. Had unnecessary in-reply-to tag causing split in series URLs. On Wed, 2022-12-21 at 14:54 -0800, Alan Previn wrote: > Add missing cleanup steps for PXP global-teardown

[Intel-gfx] [PATCH v3 7/7] HAX: force enable PXP Kconfig

2022-12-21 Thread Alan Previn
Force PXP configs on for CI testing to trigger full subtests in IGT's gem_pxp as opposed to the partial "unsupported hw substests". Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/Kconfig | 2 +- drivers/misc/mei/pxp/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v3 6/7] drm/i915/pxp: Pxp hw init should be in resume_complete

2022-12-21 Thread Alan Previn
During suspend flow, i915 currently achors' on the pm_suspend_prepare callback as the location where we quiesce the entire GPU and perform all necessary cleanup in order to go into suspend. PXP is also called during this time to perform the arbitration session teardown (with the assurance no

[Intel-gfx] [PATCH v3 4/7] drm/i915/pxp: Invalidate all PXP fw sessions during teardown

2022-12-21 Thread Alan Previn
A gap was recently discovered where if an application did not invalidate all of the stream keys (intentionally or not), and the driver did a full PXP global teardown on the GT subsystem, we find that future session creation would fail on the security firmware's side of the equation. i915 is the

[Intel-gfx] [PATCH v3 5/7] drm/i915/pxp: Trigger the global teardown for before suspending

2022-12-21 Thread Alan Previn
A driver bug was recently discovered where the security firmware was receiving internal HW signals indicating that session key expirations had occurred. Architecturally, the firmware was expecting a response from the GuC to acknowledge the event with the firmware side. However the OS was in a

[Intel-gfx] [PATCH v3 3/7] mei: clean pending read with vtag on bus

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Client on bus have only one vtag map slot and should disregard the vtag value when cleaning pending read flag. Fixes read flow control message unexpectedly generated when clent on bus send messages with different vtags. Signed-off-by: Alexander Usyskin ---

[Intel-gfx] [PATCH v3 1/7] mei: mei-me: resume device in prepare

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Async runtime resume is not possible while system is suspending. The power management subsystem resumes device only in the suspend phase, not in the prepare phase. Force resume device in prepare to allow drivers on mei bus to communicate in prepare callbacks.

[Intel-gfx] [PATCH v3 0/7] drm/i915/pxp: Add missing cleanup steps for PXP global-teardown

2022-12-21 Thread Alan Previn
A customer issue was recently discovered and in the process a gap in i915's PXP interaction with HW+FW architecure was also realized. This series adds those missing pieces. This fix includes changes where i915 calls into the mei component interface in order to submit requests to the security

[Intel-gfx] [PATCH v3 2/7] drm/i915/pxp: add device link between i915 and mei_pxp

2022-12-21 Thread Alan Previn
From: Alexander Usyskin Add device link with i915 as consumer and mei_pxp as supplier to ensure proper ordering of power flows. V2: condition on absence of heci_pxp to filter out DG Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 7 +++ 1 file changed, 7

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2) URL : https://patchwork.freedesktop.org/series/111967/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state (rev2) URL : https://patchwork.freedesktop.org/series/111967/ State : warning == Summary == Error: dim checkpatch failed 3b9a9285f15d drm/i915/dp_mst: log when pulling CRTCs into

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14

2022-12-21 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915/mtl: limit second scaler vertical scaling in ver >= 14 URL : https://patchwork.freedesktop.org/series/111779/ State : success == Summary == CI Bug Log - changes from CI_DRM_12519 -> Patchwork_111779v1

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/mtl: handle some MTL scaler limitations

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: handle some MTL scaler limitations URL : https://patchwork.freedesktop.org/series/112089/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool CC [M]

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-21 Thread Zheng Wang
Hi Zhi, Thanks again for your reply and clear explaination about the function. I still have some doubt about the fix. Here is a invoke chain : ppgtt_populate_spt ->ppgtt_populate_shadow_entry ->split_2MB_gtt_entry As far as I'm concerned, when something error happens in DMA mapping, which

Re: [Intel-gfx] Possible regression in drm/i915 driver: memleak

2022-12-21 Thread Mirsad Goran Todorovac
On 20.12.2022. 20:34, Mirsad Todorovac wrote: On 12/20/22 16:52, Tvrtko Ursulin wrote: On 20/12/2022 15:22, srinivas pandruvada wrote: +Added DRM mailing list and maintainers On Tue, 2022-12-20 at 15:33 +0100, Mirsad Todorovac wrote: Hi all, I have been unsuccessful to find any particular

[Intel-gfx] [PATCH v3] drm: Only select I2C_ALGOBIT for drivers that actually need it

2022-12-21 Thread Uwe Kleine-König
While working on a drm driver that doesn't need the i2c algobit stuff I noticed that DRM selects this code even though only 8 drivers actually use it. While also only some drivers use i2c, keep the select for I2C for the next cleanup patch. Still prepare this already by also selecting I2C for the

Re: [Intel-gfx] Possible regression in drm/i915 driver: memleak

2022-12-21 Thread Mirsad Goran Todorovac
On 20. 12. 2022. 16:52, Tvrtko Ursulin wrote: On 20/12/2022 15:22, srinivas pandruvada wrote: +Added DRM mailing list and maintainers On Tue, 2022-12-20 at 15:33 +0100, Mirsad Todorovac wrote: Hi all, I have been unsuccessful to find any particular Intel i915 maintainer emails, so my best

[Intel-gfx] [RESEND PATCH v4] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-21 Thread Zheng Wang
If intel_gvt_dma_map_guest_page failed, it will call ppgtt_invalidate_spt, which will finally free the spt. But the caller does not notice that, it will free spt again in error path. Fix this by undoing the mapping of DMA address and freeing sub_spt. Fixes: b901b252b6cf ("drm/i915/gvt: Add 2M

[Intel-gfx] [PATCH v5] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-21 Thread Zheng Wang
If intel_gvt_dma_map_guest_page failed, it will call ppgtt_invalidate_spt, which will finally free the spt. But the caller function ppgtt_populate_spt_by_guest_entry does not notice that, it will free spt again in its error path. Fix this by undoing the mapping of DMA address and freeing

Re: [Intel-gfx] [PATCH] treewide: Convert del_timer*() to timer_shutdown*()

2022-12-21 Thread Kalle Valo
Steven Rostedt writes: > [ > Linus, > > I ran the script against your latest master branch: > commit b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf > > As the timer_shutdown*() code is now in your tree, I figured > we can start doing the conversions. At least add the trivial ones >

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-21 Thread Zheng Wang
Wang, Zhi A 于2022年12月19日周一 16:22写道: > > I think it is a case-by-case thing. For example: > > The current scenario in this function looks like below: > > caller pass spt a > function > alloc spt b > something error > free spt a > return error > > The problem is:

[Intel-gfx] [PATCH v4] [PATCH v4] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-21 Thread Zheng Wang
If intel_gvt_dma_map_guest_page failed, it will call ppgtt_invalidate_spt, which will finally free the spt. But the caller does not notice that, it will free spt again in error path. Fix this by undoing the mapping of DMA address and freeing sub_spt. Fixes: b901b252b6cf ("drm/i915/gvt: Add 2M

Re: [Intel-gfx] [cache coherency bug] i915 and PAT attributes

2022-12-21 Thread Andrew Cooper
On 08/12/2022 1:55 pm, Marek Marczykowski-Górecki wrote: > Hi, > > There is an issue with i915 on Xen PV (dom0). The end result is a lot of > glitches, like here: https://openqa.qubes-os.org/tests/54748#step/startup/8 > (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's using Xorg > with

[Intel-gfx] [PATCH] [next] i915/gvt: Replace one-element array with flexible-array member

2022-12-21 Thread Paulo Miguel Almeida
One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in struct gvt_firmware_header and refactor the rest of the code accordingly. Additionally, previous implementation was allocating 8 bytes more

Re: [Intel-gfx] LOOKS GOOD: Possible regression in drm/i915 driver: memleak

2022-12-21 Thread Mirsad Todorovac
On 12/20/22 16:52, Tvrtko Ursulin wrote: On 20/12/2022 15:22, srinivas pandruvada wrote: +Added DRM mailing list and maintainers On Tue, 2022-12-20 at 15:33 +0100, Mirsad Todorovac wrote: Hi all, I have been unsuccessful to find any particular Intel i915 maintainer emails, so my best bet is

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdmi: Go for scrambling only if platform supports TMDS clock > 340MHz (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: Go for scrambling only if platform supports TMDS clock > 340MHz (rev2) URL : https://patchwork.freedesktop.org/series/111877/ State : success == Summary == CI Bug Log - changes from CI_DRM_12518_full -> Patchwork_111877v2_full

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Fix a static analysis warning

2022-12-21 Thread John . C . Harrison
From: John Harrison A static analyser was complaining about not checking for null pointers. However, the location of the complaint can only be reached in the first place if said pointer is non-null. Basically, if we are using a v69 GuC then the descriptor pool is guaranteed to be alocated at

[Intel-gfx] [PATCH 3/3] drm/i915/uc: Fix two issues with over-size firmware files

2022-12-21 Thread John . C . Harrison
From: John Harrison In the case where a firmware file is too large (e.g. someone downloaded a web page ASCII dump from github...), the firmware object is released but the pointer is not zerod. If no other firmware file was found then release would be called again leading to a double kfree.

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Fix missing return code checks in submission init

2022-12-21 Thread John . C . Harrison
From: John Harrison The CI results for the 'fast request' patch set (enables error return codes for fire-and-forget H2G messages) hit an issue with the KMD sending context submission requests on an invalid context. That was caused by a fault injection probe failing the context creation of a

[Intel-gfx] [PATCH 0/3] Fixes for various UC related issues

2022-12-21 Thread John . C . Harrison
From: John Harrison Fix a bunch of assorted issues with firmware loading and GuC intialisation. Signed-off-by: John Harrison John Harrison (3): drm/i915/guc: Fix missing return code checks in submission init drm/i915/guc: Fix a static analysis warning drm/i915/uc: Fix two issues with

Re: [Intel-gfx] [PATCH v3 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-21 Thread Teres Alexis, Alan Previn
On Tue, 2022-12-20 at 07:19 +, Kandpal, Suraj wrote: > > > > On Wed, 2022-12-14 at 14:37 +0530, Suraj Kandpal wrote: > > > > > > Alan: See my review comment on patch #1 - i believe most of this function > > above > > (intel_hdcp_gsc_msg_send) could go into a common > >

[Intel-gfx] ✓ Fi.CI.IGT: success for fix RC6p related regression on Sandy Bridge

2022-12-21 Thread Patchwork
== Series Details == Series: fix RC6p related regression on Sandy Bridge URL : https://patchwork.freedesktop.org/series/112072/ State : success == Summary == CI Bug Log - changes from CI_DRM_12518_full -> Patchwork_112072v1_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdmi: Go for scrambling only if platform supports TMDS clock > 340MHz (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/hdmi: Go for scrambling only if platform supports TMDS clock > 340MHz (rev2) URL : https://patchwork.freedesktop.org/series/111877/ State : success == Summary == CI Bug Log - changes from CI_DRM_12518 -> Patchwork_111877v2

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/mtl: implement wa 14015076503 (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: implement wa 14015076503 (rev2) URL : https://patchwork.freedesktop.org/series/112049/ State : success == Summary == CI Bug Log - changes from CI_DRM_12518_full -> Patchwork_112049v2_full Summary

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for Align DDI_BUF_CTL Active timeouts with Bspec updates (rev5)

2022-12-21 Thread Imre Deak
On Wed, Dec 07, 2022 at 07:50:49PM +, Patchwork wrote: > == Series Details == > > Series: Align DDI_BUF_CTL Active timeouts with Bspec updates (rev5) > URL : https://patchwork.freedesktop.org/series/111373/ > State : success Thanks for the patches, pushed to drm-intel-next. > > ==

[Intel-gfx] [PATCH v3 1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version

2022-12-21 Thread Alan Previn
If PXP arb-session is being attempted on older hardware SKUs or on hardware with older, unsupported, firmware versions, then don't report the failure with a drm_error. Instead, look specifically for the API-version error reply and drm_dbg that reply. In this case, the user-space will eventually

[Intel-gfx] ✓ Fi.CI.BAT: success for fix RC6p related regression on Sandy Bridge

2022-12-21 Thread Patchwork
== Series Details == Series: fix RC6p related regression on Sandy Bridge URL : https://patchwork.freedesktop.org/series/112072/ State : success == Summary == CI Bug Log - changes from CI_DRM_12518 -> Patchwork_112072v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Fixes for various UC related issues

2022-12-21 Thread Patchwork
== Series Details == Series: Fixes for various UC related issues URL : https://patchwork.freedesktop.org/series/112080/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool CC [M] drivers/gpu/drm/i915/gt/uc/intel_uc_fw.o

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/pxp: Use drm_dbg if arb session failed due to fw version

2022-12-21 Thread Teres Alexis, Alan Previn
On Wed, 2022-12-21 at 12:21 +0200, Jani Nikula wrote: > On Tue, 20 Dec 2022, Alan Previn wrote: > > Alan:[snip] > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > @@ -298,6 +298,11 @@ int intel_pxp_tee_cmd_create_arb_session(struct > > intel_pxp *pxp, > > > > if (ret) > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: implement wa 14015076503 (rev2)

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/mtl: implement wa 14015076503 (rev2) URL : https://patchwork.freedesktop.org/series/112049/ State : success == Summary == CI Bug Log - changes from CI_DRM_12518 -> Patchwork_112049v2 Summary ---

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v3] tests/i915/gem_ppgtt: verify GTT eviction with contended locks

2022-12-21 Thread Das, Nirmoy
On 12/20/2022 12:46 PM, Matthew Auld wrote: We should still be able to GTT evict objects during execbuf (old bindings can linger around), even if there is object lock contention. In the worst case the execbuf should just wait on the contented locks. Returning -ENOSPC smells like a regression

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display/dsi: use intel_de_rmw if possible

2022-12-21 Thread Patchwork
== Series Details == Series: drm/i915/display/dsi: use intel_de_rmw if possible URL : https://patchwork.freedesktop.org/series/112062/ State : success == Summary == CI Bug Log - changes from CI_DRM_12517_full -> Patchwork_112062v1_full

Re: [Intel-gfx] [PATCH 2/2] drm/fbdev: Move damage clip check to higher level

2022-12-21 Thread Hogander, Jouni
On Wed, 2022-12-21 at 13:05 +0100, Thomas Zimmermann wrote: > Hi > > Am 21.12.22 um 12:19 schrieb Jouni Högander: > > Checking if damage clip is valid is common to all fb helpers. > > Makes more sense to check it in higher level than adding into > > all helpers. > > It was a deliberate decision

[Intel-gfx] [PATCH] drm/i915: Enable XE_HP 4Tile support

2022-12-21 Thread Jonathan Cavitt
Add .has_4tile tag to XE_HP_FEATURES set. Remove duplicate entry from DG2_FEATURES. Signed-off-by: Jonathan Cavitt Cc: Bommu Krishnaiah Cc: Roper Matthew D Cc: Kempczynski Zbigniew Cc: Telukuntla Sreedhar Acked-by: Matt Roper --- drivers/gpu/drm/i915/i915_pci.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH v3] drm/i915/fbdev: Implement fb_dirty for intel custom fb helper

2022-12-21 Thread Jouni Högander
After splitting generic drm_fb_helper into it's own file it's left to helper implementation to have fb_dirty function. Currently intel fbdev doesn't have it. This is causing problems to features (PSR, FBC, DRRS) relying on dirty callback. Implement simple fb_dirty callback to deliver

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Implement fb_dirty for intel custom fb helper

2022-12-21 Thread Ville Syrjälä
On Wed, Dec 21, 2022 at 04:08:13PM +0100, Thomas Zimmermann wrote: > Hi > > Am 21.12.22 um 15:51 schrieb Ville Syrjälä: > > On Wed, Dec 21, 2022 at 11:49:59AM +0100, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 29.11.22 um 13:43 schrieb Jouni Högander: > >>> After splitting generic drm_fb_helper

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-21 Thread Gustavo Sousa
On Wed, Dec 21, 2022 at 12:26:26PM +0200, Jani Nikula wrote: > > - request_firmware(, dev_priv->display.dmc.fw_path, dev_priv->drm.dev); > > + err = firmware_request_nowarn(, dev_priv->display.dmc.fw_path, > > dev_priv->drm.dev); > > + > > + if (err == -ENOENT &&

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Implement fb_dirty for intel custom fb helper

2022-12-21 Thread Thomas Zimmermann
Hi Am 21.12.22 um 15:51 schrieb Ville Syrjälä: On Wed, Dec 21, 2022 at 11:49:59AM +0100, Thomas Zimmermann wrote: Hi Am 29.11.22 um 13:43 schrieb Jouni Högander: After splitting generic drm_fb_helper into it's own file it's left to helper implementation to have fb_dirty function. Currently

[Intel-gfx] [PATCH v2 2/2] drm/i915/dmc: Use unversioned firmware paths

2022-12-21 Thread Gustavo Sousa
As we do not require specific versions anymore, change the convention for blob filenames to stop using version numbers. This simplifies code maintenance, since we do not need to keep updating blob paths for new DMC releases, and also makes DMC loading compatible with systems that do not have the

  1   2   >