Separate out RPLU device ids and add them to both RPL and
newly created RPL-U subplatforms.
v2: (Matt)
- Sort PCI-IDs numerically
- Name the sub-platform to accurately depict what it is for
- Make RPL-U part of RPL subplatform
v3: revert to RPL-U subplatform (Jani)
Signed-off-by:
A new step of 480MHz has been added on SKUs that have a RPL-U
device id to support 120Hz displays more efficiently. Use a
new quirk to identify the machine for which this change needs
to be applied.
BSpec: 55409
v2: (Matt)
- Add missing clock steps
- Correct reference clock typo
v3: -
A new step of 480MHz has been added on SKUs that have an RPL-U
device id. This particular step is to support 120Hz panels
more efficiently.
This patchset adds a new table to include this new CDCLK
step. Details can be found in BSpec entry 55409.
Create a new sub-platform to identify RPL-U which
Hi all,
The following commit is also in the drm-misc tree as a different commit
(but the same patch):
06b19f46455c ("drm/nouveau/fb/ga102: Replace zero-length array of trailing
structs with flex-array")
This is commit
54d47689c6e3 ("drm/nouveau/fb/ga102: Replace zero-length array of
== Series Details ==
Series: drm/i915/display: add intel_display_limits.h for key enums (rev3)
URL : https://patchwork.freedesktop.org/series/111334/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12588_full -> Patchwork_111334v3_full
== Series Details ==
Series: series starting with [1/2] drm/i915: add struct i915_dsm to wrap dsm
members together
URL : https://patchwork.freedesktop.org/series/112898/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12588_full -> Patchwork_112898v1_full
Hi Vinay,
On Mon, Jan 16, 2023 at 11:35:41AM -0800, Belgaumkar, Vinay wrote:
>
> On 1/16/2023 10:58 AM, Andi Shyti wrote:
> > Hi,
> >
> > On Thu, Jan 12, 2023 at 08:48:11PM -0800, Belgaumkar, Vinay wrote:
> > > On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote:
> > > > On Thu, 12 Jan 2023 20:26:34
== Series Details ==
Series: drm/i915/display: add intel_display_limits.h for key enums (rev3)
URL : https://patchwork.freedesktop.org/series/111334/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12588 -> Patchwork_111334v3
On 1/16/2023 10:58 AM, Andi Shyti wrote:
Hi,
On Thu, Jan 12, 2023 at 08:48:11PM -0800, Belgaumkar, Vinay wrote:
On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote:
On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote:
I think the ABI was changed by the patch mentioned in the commit
== Series Details ==
Series: drm/i915/gt: Add selftests for TLB invalidation
URL : https://patchwork.freedesktop.org/series/112894/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12587_full -> Patchwork_112894v1_full
Hi Rodrigo,
On Wed, Jan 11, 2023 at 12:06:24PM -0500, Rodrigo Vivi wrote:
> On Wed, Jan 11, 2023 at 04:39:36PM +0100, Andi Shyti wrote:
> > Hi Rodrigo,
> >
> > On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote:
> > > On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote:
> > > >
== Series Details ==
Series: drm/i915/display: add intel_display_limits.h for key enums (rev3)
URL : https://patchwork.freedesktop.org/series/111334/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: series starting with [1/2] drm/i915: add struct i915_dsm to wrap dsm
members together
URL : https://patchwork.freedesktop.org/series/112898/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12588 -> Patchwork_112898v1
Hi,
On Thu, Jan 12, 2023 at 08:48:11PM -0800, Belgaumkar, Vinay wrote:
>
> On 1/12/2023 8:37 PM, Dixit, Ashutosh wrote:
> > On Thu, 12 Jan 2023 20:26:34 -0800, Belgaumkar, Vinay wrote:
> > > I think the ABI was changed by the patch mentioned in the commit
> > > (a8a4f0467d70).
> > The ABI was
== Series Details ==
Series: series starting with [1/2] drm/i915: add struct i915_dsm to wrap dsm
members together
URL : https://patchwork.freedesktop.org/series/112898/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
== Series Details ==
Series: series starting with [1/2] drm/i915: add struct i915_dsm to wrap dsm
members together
URL : https://patchwork.freedesktop.org/series/112898/
State : warning
== Summary ==
Error: dim checkpatch failed
05c75413d4b5 drm/i915: add struct i915_dsm to wrap dsm members
Hi Nirmoy,
On Fri, Jan 13, 2023 at 01:00:53PM +0100, Nirmoy Das wrote:
> From: Chris Wilson
>
> Make sure that upon error after we have acquired the wakeref we do
> release it again.
>
> Fixes: 027c38b4121e ("drm/i915/selftests: Grab the runtime pm in shrink_thp")
> Reviewed-by: Matthew Auld
On Mon, Jan 16, 2023 at 6:54 AM Thomas Zimmermann wrote:
>
> (was: drm: Generic fbdev and vga-switcheroo)
>
> This patchset fixes how fbdev helpers interact with vga-switcheroo. The
> first two patches are bug fixes for the existing code. The third patch
> cleans up the drivers.
>
> Patch 1 fixes
== Series Details ==
Series: drm/i915: extract vblank/scanline code to a separate file (rev3)
URL : https://patchwork.freedesktop.org/series/111854/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12587_full -> Patchwork_111854v3_full
== Series Details ==
Series: drm/i915/display: add intel_display_limits.h for key enums (rev2)
URL : https://patchwork.freedesktop.org/series/111334/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12587 -> Patchwork_111334v2
== Series Details ==
Series: drm/i915/display: add intel_display_limits.h for key enums (rev2)
URL : https://patchwork.freedesktop.org/series/111334/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/gt: Add selftests for TLB invalidation
URL : https://patchwork.freedesktop.org/series/112894/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12587 -> Patchwork_112894v1
Summary
---
Since commit 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be
compound literal") it's no longer necessary to cast DEFINE_RES_MEM() to
struct resource.
This also fixes sparse warnings "cast from non-scalar" and "cast to
non-scalar".
Signed-off-by: Jani Nikula
---
Wrap the stolen memory related struct drm_i915_private members (dsm,
dsm_reserved, and stolen_usable_size) together in a a new struct
i915_dsm.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_fbc.c | 10 ++--
drivers/gpu/drm/i915/display/intel_fbdev.c| 2 +-
== Series Details ==
Series: drm/i915: extract vblank/scanline code to a separate file (rev3)
URL : https://patchwork.freedesktop.org/series/111854/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12587 -> Patchwork_111854v3
Move a handful of key enums to a new file intel_display_limits.h. These
are the enum types, and the MAX/NUM enumerations within them, that are
used in other headers. Otherwise, there's no common theme between them.
Replace intel_display.h include with intel_display_limit.h where
relevant, and add
== Series Details ==
Series: drm/i915: extract vblank/scanline code to a separate file (rev3)
URL : https://patchwork.freedesktop.org/series/111854/
State : warning
== Summary ==
Error: dim checkpatch failed
255ef7a91efb drm/i915/irq: split out vblank/scanline code to intel_vblank.[ch]
From: Chris Wilson
Check that we invalidate the TLB cache, the updated physical addresses
are immediately visible to the HW, and there is no retention of the old
physical address for concurrent HW access.
Signed-off-by: Chris Wilson
[ahajda: adjust to upstream driver]
Signed-off-by: Andrzej
== Series Details ==
Series: drm/i915: Use designated initializers for struct pci_device_id init
URL : https://patchwork.freedesktop.org/series/112887/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12586_full -> Patchwork_112887v1_full
On Fri, Jan 13, 2023 at 07:03:51PM -0500, Matthew Rosato wrote:
> Currently it is possible that the final put of a KVM reference comes from
> vfio during its device close operation. This occurs while the vfio group
> lock is held; however, if the vfio device is still in the kvm device list,
>
== Series Details ==
Series: drm/{amdgpu, i915, nouveau, radeon}: Fix fbdev and vga-switcheroo
URL : https://patchwork.freedesktop.org/series/112884/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12586_full -> Patchwork_112884v1_full
== Series Details ==
Series: drm/i915: extract vblank/scanline code to a separate file (rev2)
URL : https://patchwork.freedesktop.org/series/111854/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12587 -> Patchwork_111854v2
== Series Details ==
Series: We need to have additional checks for DP MST UHBR
URL : https://patchwork.freedesktop.org/series/112876/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12586_full -> Patchwork_112876v1_full
== Series Details ==
Series: drm/i915: extract vblank/scanline code to a separate file (rev2)
URL : https://patchwork.freedesktop.org/series/111854/
State : warning
== Summary ==
Error: dim checkpatch failed
f7f0f440ba53 drm/i915/irq: split out vblank/scanline code to intel_vblank.[ch]
== Series Details ==
Series: drm/i915: Use designated initializers for struct pci_device_id init
URL : https://patchwork.freedesktop.org/series/112887/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12586 -> Patchwork_112887v1
On 12/01/2023 21:42, Lucas De Marchi wrote:
On Thu, Jan 05, 2023 at 01:35:52PM +, Tvrtko Ursulin wrote:
Okay to sum it up below with some final notes..
On 04/01/2023 19:34, Matt Roper wrote:
On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote:
On 23/12/2022 18:28, Lucas De
Add intel_de_read64_2x32() wrapper for the uncore version of the same,
and use it to read the high and low frame registers. Avoid duplicating
code for existing helpers.
The slight functional difference is checking that the entire high
register remains the same across two reads, instead of just
Use the intel_de_* functions for display registers.
Cc: Ville Syrjälä
Reviewed-by: Arun R Murthy
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_vblank.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c
cpt_verify_modeset() is roughly the same as
intel_wait_for_pipe_scanline_moving(). Assume it's close enough.
Cc: Ville Syrjälä
Reviewed-by: Arun R Murthy
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 18 +-
1 file changed, 1 insertion(+), 17
Reduce clutter in intel_display.c by moving the scanline moving/stopped
wait functions to intel_vblank.[ch].
Cc: Ville Syrjälä
Reviewed-by: Arun R Murthy
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 36 +---
The vblank/scanline code is fairly isolated in i915_irq.c. Split it out
to new intel_vblank.[ch].
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_crtc.c | 1 +
Basically just https://patchwork.freedesktop.org/series/111854/ with the
two controversial patches dropped for now.
BR,
Jani.
Jani Nikula (5):
drm/i915/irq: split out vblank/scanline code to intel_vblank.[ch]
drm/i915/display: move more scanline functions to intel_vblank.[ch]
== Series Details ==
Series: drm/i915: Use designated initializers for struct pci_device_id init
URL : https://patchwork.freedesktop.org/series/112887/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On 14/01/2023 01:27, John Harrison wrote:
On 1/13/2023 01:22, Tvrtko Ursulin wrote:
On 12/01/2023 20:59, John Harrison wrote:
On 1/12/2023 02:15, Tvrtko Ursulin wrote:
On 12/01/2023 02:53, john.c.harri...@intel.com wrote:
From: John Harrison
Engine resets are supposed to never fail. But
== Series Details ==
Series: drm/{amdgpu, i915, nouveau, radeon}: Fix fbdev and vga-switcheroo
URL : https://patchwork.freedesktop.org/series/112884/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12586 -> Patchwork_112884v1
On 13/01/2023 21:29, John Harrison wrote:
On 1/13/2023 09:46, Hellstrom, Thomas wrote:
On Fri, 2023-01-13 at 09:51 +, Tvrtko Ursulin wrote:
On 12/01/2023 20:40, John Harrison wrote:
On 1/12/2023 02:01, Tvrtko Ursulin wrote:
On 12/01/2023 02:53, john.c.harri...@intel.com wrote:
[snip]
== Series Details ==
Series: drm/{amdgpu, i915, nouveau, radeon}: Fix fbdev and vga-switcheroo
URL : https://patchwork.freedesktop.org/series/112884/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Redefine INTEL_VGA_DEVICE_INIT() instead of INTEL_VGA_DEVICE() for
subplatform init. This is only for completeness as we don't use
subplatforms for Quanta devices.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_device_info.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Use designated initializers for struct pci_device_id init.
Jani Nikula (3):
drm/i915/pciids: add common INTEL_VGA_DEVICE_INIT macro
drm/i915/pciids: use designated initializers for struct pci_device_id
drm/i915: define INTEL_VGA_DEVICE_INIT() for subplatform init
Use designated initializers for struct pci_device_id in kernel to avoid
the dependency on struct pci_device_id remaining unchanged. Recently,
commit 343b7258687e ("PCI: Add 'override_only' field to struct
pci_device_id") added a new member leading to warnings about missing
field initializers.
Any
Add a shared abstraction for the INTEL_VGA_DEVICE() and
INTEL_QUANTA_VGA_DEVICE() initializers to help follow-up changes.
Sprinkle in some underscores and parenthesis to be safe.
Signed-off-by: Jani Nikula
---
include/drm/i915_pciids.h | 23 ---
1 file changed, 12
On 13/01/2023 17:46, Hellstrom, Thomas wrote:
On Fri, 2023-01-13 at 09:51 +, Tvrtko Ursulin wrote:
On 12/01/2023 20:40, John Harrison wrote:
On 1/12/2023 02:01, Tvrtko Ursulin wrote:
On 12/01/2023 02:53, john.c.harri...@intel.com wrote:
From: John Harrison
There was a report of
== Series Details ==
Series: We need to have additional checks for DP MST UHBR
URL : https://patchwork.freedesktop.org/series/112876/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12586 -> Patchwork_112876v1
Summary
Several lastclose helpers call vga_switcheroo_process_delayed_switch().
It's better to call the helper from drm_lastclose() after the kernel
client's screen has been restored. This way, all drivers can benefit
without having to implement their own lastclose helper. For drivers
without
Set the framebuffer info for drivers that support VGA switcheroo. Only
affects the amdgpu and nouveau drivers, which use VGA switcheroo and
generic fbdev emulation. For other drivers, this does nothing.
This fixes a potential regression in the console code. Both, amdgpu and
nouveau, invoked
Always allow switching away via vga-switcheroo if the display is
uninitalized. Instead prevent switching to i915 if the device has
not been initialized.
This issue was introduced by commit 5df7bd130818 ("drm/i915: skip
display initialization when there is no display") protected, which
protects
(was: drm: Generic fbdev and vga-switcheroo)
This patchset fixes how fbdev helpers interact with vga-switcheroo. The
first two patches are bug fixes for the existing code. The third patch
cleans up the drivers.
Patch 1 fixes i915 to do the correct thing if the device has not been
initialized
On 13.01.2023 12:49, Nirmoy Das wrote:
From: Chris Wilson
Make sure that upon error after we have acquired the wakeref we do
release it again.
Signed-off-by: Chris Wilson
Signed-off-by: Nirmoy Das
Reviewed-by: Andrzej Hajda
Regards
Andrzej
---
According to spec, we should check if output_bpp * pixel_rate is less
than DDI clock * 72, if UHBR is used.
HSDES: 1406899791
BSPEC: 49259
v2: - Removed wrong comment(Rodrigo Vivi)
- Added HSDES to the commit msg(Rodrigo Vivi)
- Moved UHBR check to the MST specific code
v3: - Changed
There are might be multiple contraints which we need to check while determining
if we can use desired compressed bpp, so might be good idea to add a special
helper, so that we don't overcomplicate the main bpp calculation function.
Signed-off-by: Stanislav Lisovskiy
---
According to BSpec UHBR might hit hw limitation which must be checked.
So this series adds first some generic checker function, which might
be used to add this or similar checks in future, then we introduce
that particular UHBR check.
Stanislav Lisovskiy (2):
drm/i915: Add generic constraint
On Thu, Jan 5, 2023 at 10:54 AM Andrzej Hajda wrote:
> __xchg will be used for non-atomic xchg macro.
>
> Signed-off-by: Andrzej Hajda
> Reviewed-by: Arnd Bergmann
> ---
> v2: squashed all arch patches into one
> v3: fixed alpha/xchg_local, thx to l...@intel.com
> v4: adjusted indentation
On 1/16/23 01:54, Stephen Rothwell wrote:
Hi all,
Today's linux-next merge of the fbdev tree got a conflict in:
include/linux/fb.h
between commit:
5b6373de4351 ("drm/fbdev: Remove aperture handling and FBINFO_MISC_FIRMWARE")
from the drm-misc tree and commit:
72ac3535c2c5 ("fbdev:
Hello Jani,
Sorry about the previous mail. Replying in-line.
> -Original Message-
> From: Jani Nikula
> Sent: Monday, January 16, 2023 2:42 PM
> To: Borah, Chaitanya Kumar ; intel-
> g...@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix typo for reference
Hello Jani,
There are no bug reports for it. It was pointed out by Matt in another patch
series.
https://patchwork.freedesktop.org/patch/517283/?series=111472=3
Regards
Chaitanya
> -Original Message-
> From: Jani Nikula
> Sent: Monday, January 16, 2023 2:42 PM
> To: Borah, Chaitanya
On Thu, 12 Jan 2023, Chaitanya Kumar Borah
wrote:
> Fix typo for reference clock from 24400 to 24000
Is there a bug report? What's the impact?
It's obvious and easy to say there's a typo, but the harder part is
matching this against observed faulty behaviour, and that's something
people will
66 matches
Mail list logo
