[Intel-gfx] [PATCH v10 13/23] drm/i915/vm_bind: Implement I915_GEM_EXECBUFFER3 ioctl

2023-01-17 Thread Niranjana Vishwanathapura
Implement new execbuf3 ioctl (I915_GEM_EXECBUFFER3) which only works in vm_bind mode. The vm_bind mode only works with this new execbuf3 ioctl. The new execbuf3 ioctl will not have any list of objects to validate bind as all required objects binding would have been requested by the userspace

[Intel-gfx] [PATCH v10 08/23] drm/i915/vm_bind: Add support to handle object evictions

2023-01-17 Thread Niranjana Vishwanathapura
Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: Remove unused I915_VMA_PURGED definition. v3: Properly handle __i915_vma_unbind_async() case. Reviewed-by: Matthew

[Intel-gfx] [PATCH v10 23/23] drm/i915/vm_bind: Support capture of persistent mappings

2023-01-17 Thread Niranjana Vishwanathapura
Support dump capture of persistent mappings upon user request. Capture of a mapping is requested with the VM_BIND ioctl and processed during the GPU error handling. They are synchronously unbound during eviction so that no additional vma resource reference taking is required in the submission

[Intel-gfx] [PATCH v10 14/23] drm/i915/vm_bind: Update i915_vma_verify_bind_complete()

2023-01-17 Thread Niranjana Vishwanathapura
Ensure i915_vma_verify_bind_complete() handles case where bind is not initiated. Also make it non static, add documentation and move it out of CONFIG_DRM_I915_DEBUG_GEM. v2: Fix fence leak Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti ---

[Intel-gfx] [PATCH v10 19/23] drm/i915/vm_bind: Add uapi for user to enable vm_bind_mode

2023-01-17 Thread Niranjana Vishwanathapura
Add getparam support for VM_BIND capability version. Add VM creation time flag to enable vm_bind_mode for the VM. v2: update kernel-doc v3: create vm->root_obj only upon I915_VM_CREATE_FLAGS_USE_VM_BIND v4: replace vm->vm_bind_mode check with i915_gem_vm_is_vm_bind_mode() Reviewed-by: Matthew

[Intel-gfx] [PATCH v10 04/23] drm/i915/vm_bind: Support partially mapped vma resource

2023-01-17 Thread Niranjana Vishwanathapura
As persistent vmas can be partialled mapped to an object, remove restriction which require vma resource sg table to be just pointer to object's sg table. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 3 +-- 1 file changed, 1

[Intel-gfx] [PATCH v10 17/23] drm/i915/vm_bind: userptr dma-resv changes

2023-01-17 Thread Niranjana Vishwanathapura
For persistent (vm_bind) vmas of userptr BOs, handle the user page pinning by using the i915_gem_object_userptr_submit_init() /done() functions v2: Do not double add vma to vm->userptr_invalidated_list v3: Initialize vma->userptr_invalidated_link Reviewed-by: Matthew Auld Signed-off-by:

[Intel-gfx] [PATCH v10 16/23] drm/i915/vm_bind: Handle persistent vmas in execbuf3

2023-01-17 Thread Niranjana Vishwanathapura
Handle persistent (VM_BIND) mappings during the request submission in the execbuf3 path. v2: Ensure requests wait for bindings to complete. v3: Remove short term pinning with PIN_VALIDATE flag. Individualize fences before adding to dma_resv obj. v4: Fix bind completion check, use PIN_NOEVICT,

[Intel-gfx] [PATCH v10 12/23] drm/i915/vm_bind: Use common execbuf functions in execbuf path

2023-01-17 Thread Niranjana Vishwanathapura
Update the execbuf path to use common execbuf functions to reduce code duplication with the newer execbuf3 path. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 513 ++ 1 file changed, 39 insertions(+), 474

[Intel-gfx] [PATCH v10 05/23] drm/i915/vm_bind: Add support to create persistent vma

2023-01-17 Thread Niranjana Vishwanathapura
Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing. ie., multiple mappings (at different VA) point to the

[Intel-gfx] [PATCH v10 10/23] drm/i915/vm_bind: Add out fence support

2023-01-17 Thread Niranjana Vishwanathapura
Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. v3: Remove vm_unbind out fence uapi which is not supported yet. v4: Return error if I915_TIMELINE_FENCE_WAIT fence flag is set. Wait for bind to complete iff

[Intel-gfx] [PATCH v10 21/23] drm/i915/vm_bind: Async vm_unbind support

2023-01-17 Thread Niranjana Vishwanathapura
Asynchronously unbind the vma upon vm_unbind call. Fall back to synchronous unbind if backend doesn't support async unbind or if async unbind fails. No need for vm_unbind out fence support as i915 will internally handle all sequencing and user need not try to sequence any operation with the

[Intel-gfx] [PATCH v10 22/23] drm/i915/vm_bind: Properly build persistent map sg table

2023-01-17 Thread Niranjana Vishwanathapura
Properly build the sg table for persistent mapping which can be partial map of the underlying object. Ensure the sg pages are properly set for page backed regions. The dump capture support requires this for page backed regions. v2: Remove redundant sg_mark_end() call Signed-off-by: Niranjana

[Intel-gfx] [PATCH v10 15/23] drm/i915/vm_bind: Expose i915_request_await_bind()

2023-01-17 Thread Niranjana Vishwanathapura
Rename __i915_request_await_bind() as i915_request_await_bind() and make it non-static as it will be used in execbuf3 ioctl path. v2: add documentation Reviewed-by: Matthew Auld Reviewed-by: Andi Shyti Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_vma.c | 8 +---

[Intel-gfx] [PATCH v10 20/23] drm/i915/vm_bind: Render VM_BIND documentation

2023-01-17 Thread Niranjana Vishwanathapura
Update i915 documentation to include VM_BIND changes and render all VM_BIND related documentation. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- Documentation/gpu/i915.rst | 78 -- 1 file changed, 59 insertions(+), 19 deletions(-)

[Intel-gfx] [PATCH v10 01/23] drm/i915/vm_bind: Expose vm lookup function

2023-01-17 Thread Niranjana Vishwanathapura
Make i915_gem_vm_lookup() function non-static as it will be used by the vm_bind feature. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ++- drivers/gpu/drm/i915/gem/i915_gem_context.h |

[Intel-gfx] [PATCH v10 18/23] drm/i915/vm_bind: Limit vm_bind mode to non-recoverable contexts

2023-01-17 Thread Niranjana Vishwanathapura
Only support vm_bind mode with non-recoverable contexts. With new vm_bind mode with eb3 submission path, we need not support older recoverable contexts. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 ++ 1 file

[Intel-gfx] [PATCH v10 07/23] drm/i915/vm_bind: Support for VM private BOs

2023-01-17 Thread Niranjana Vishwanathapura
Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage as it requires a single dma_resv object update for all private BOs vs list of dma_resv objects update for shared BOs, in the execbuf path. VM private BOs can be

[Intel-gfx] [PATCH v10 11/23] drm/i915/vm_bind: Abstract out common execbuf functions

2023-01-17 Thread Niranjana Vishwanathapura
The new execbuf3 ioctl path and the legacy execbuf ioctl paths have many common functionalities. Abstract out the common execbuf functionalities into a separate file where possible, thus allowing code sharing. v2: Use drm_dbg instead of DRM_DEBUG Reviewed-by: Andi Shyti Reviewed-by: Matthew

[Intel-gfx] [PATCH v10 03/23] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2023-01-17 Thread Niranjana Vishwanathapura
Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 18 +-

[Intel-gfx] [PATCH v10 02/23] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2023-01-17 Thread Niranjana Vishwanathapura
Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_sw_fence.c | 28

[Intel-gfx] [PATCH v10 09/23] drm/i915/vm_bind: Support persistent vma activeness tracking

2023-01-17 Thread Niranjana Vishwanathapura
Do not use i915_vma activeness tracking for persistent vmas. As persistent vmas are part of working set for each execbuf submission on that address space (VM), a persistent vma is active if the VM active. As vm->root_obj->base.resv will be updated for each submission on that VM, it correctly

[Intel-gfx] [PATCH v10 06/23] drm/i915/vm_bind: Implement bind and unbind of object

2023-01-17 Thread Niranjana Vishwanathapura
Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be supported only in the newer execbuf3 ioctl. v2: On older platforms ctx->vm is not set, check for it. In vm_bind call,

[Intel-gfx] [PATCH v10 00/23] drm/i915/vm_bind: Add VM_BIND functionality

2023-01-17 Thread Niranjana Vishwanathapura
DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified address space (VM). Multiple mappings can map to the same physical pages of an object (aliasing). These mappings (also referred to as

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: move snps_phy_failed_calibration to display sub-struct under snps

2023-01-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: move snps_phy_failed_calibration to display sub-struct under snps URL : https://patchwork.freedesktop.org/series/112933/ State : success == Summary == CI Bug Log - changes from CI_DRM_12592_full -> Patchwork_112933v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable YCbCr420 for VDSC

2023-01-17 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC URL : https://patchwork.freedesktop.org/series/112993/ State : success == Summary == CI Bug Log - changes from CI_DRM_12596 -> Patchwork_112993v1 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v9 23/23] drm/i915/vm_bind: Support capture of persistent mappings

2023-01-17 Thread Niranjana Vishwanathapura
On Tue, Dec 13, 2022 at 12:03:07PM +, Matthew Auld wrote: On 12/12/2022 23:15, Niranjana Vishwanathapura wrote: Support dump capture of persistent mappings upon user request. Capture of a mapping is requested with the VM_BIND ioctl and processed during the GPU error handling, thus not

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable YCbCr420 for VDSC

2023-01-17 Thread Patchwork
== Series Details == Series: Enable YCbCr420 for VDSC URL : https://patchwork.freedesktop.org/series/112993/ State : warning == Summary == Error: dim checkpatch failed 744170a1110d drm/dp_helper: Add helper to check if the sink supports given format with DSC 17cba7d62236 drm/i915/dp: Check

[Intel-gfx] [PATCH v8 6/6] drm/i915/vdsc: Check slice design requirement

2023-01-17 Thread Suraj Kandpal
Add function to check if slice design requirements are being met as defined in Bspec: 49259 in the section Slice Design Requirement --v7 -remove full bspec link [Jani] -rename intel_dsc_check_slice_design_req to intel_dsc_slice_dimensions_valid [Jani] --v8 -fix condition to check if slice width

[Intel-gfx] [PATCH v8 5/6] drm/i915: Fill in native_420 field

2023-01-17 Thread Suraj Kandpal
Now that we have laid the groundwork for YUV420 Enablement we fill up native_420 field in vdsc_cfg and add appropriate checks wherever required. ---v2 -adding native_422 field as 0 [Vandita] -filling in second_line_bpg_offset, second_line_offset_adj and nsl_bpg_offset in vds_cfg when native_420

[Intel-gfx] [PATCH v8 4/6] drm/i915: Enable YCbCr420 for VDSC

2023-01-17 Thread Suraj Kandpal
Implementation of VDSC for YCbCr420. Add QP tables for 8,10,12 BPC from rc_tables.h in intel_qp_tables.c (Derived from C-Model, which is given along with DSC1.2a Spec from Vesa) intel_lookup_range_min/max_qp functons need to take into account the output format. Based on that appropriate qp table

[Intel-gfx] [PATCH v8 3/6] drm/i915: Adding the new registers for DSC

2023-01-17 Thread Suraj Kandpal
Adding new DSC register which are introducted MTL onwards Signed-off-by: Suraj Kandpal Reviewed-by: Vandita Kulkarni --- drivers/gpu/drm/i915/i915_reg.h | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH v8 2/6] drm/i915/dp: Check if DSC supports the given output_format

2023-01-17 Thread Suraj Kandpal
From: Ankit Nautiyal Go with DSC only if the given output_format is supported. v2: Use drm helper to get DSC format support for sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 30 + 1 file changed, 30 insertions(+) diff --git

[Intel-gfx] [PATCH v8 1/6] drm/dp_helper: Add helper to check if the sink supports given format with DSC

2023-01-17 Thread Suraj Kandpal
From: Ankit Nautiyal Add helper function to check if the DP sink supports DSC with the given output format. Signed-off-by: Ankit Nautiyal --- include/drm/display/drm_dp_helper.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/drm/display/drm_dp_helper.h

[Intel-gfx] [PATCH v8 0/6] Enable YCbCr420 for VDSC

2023-01-17 Thread Suraj Kandpal
This patch series aims to enable the YCbCr420 format for DSC. Changes are mostly compute params related for hdmi,dp and dsi along with the addition of new rc_tables for native_420 and corresponding changes to macros used to fetch them. ---v2 -add fields missed for vdsc_cfg [Vandita] -add

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: GMCH refactoring (rev2)

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915: GMCH refactoring (rev2) URL : https://patchwork.freedesktop.org/series/112929/ State : success == Summary == CI Bug Log - changes from CI_DRM_12592_full -> Patchwork_112929v2_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: remove a couple of superfluous i915_drm.h includes

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915: remove a couple of superfluous i915_drm.h includes URL : https://patchwork.freedesktop.org/series/112931/ State : success == Summary == CI Bug Log - changes from CI_DRM_12592_full -> Patchwork_112931v1_full

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-17 Thread Deepak R Varma
On Tue, Jan 17, 2023 at 02:29:37PM -0500, Rodrigo Vivi wrote: > On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote: > > On 2023.01.10 13:49:57 -0500, Rodrigo Vivi wrote: > > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with

Re: [Intel-gfx] [PATCH] drm/i915/display: Convert i9xx_pipe_crc_auto_source to void

2023-01-17 Thread Deepak R Varma
On Tue, Jan 17, 2023 at 02:21:59PM -0500, Rodrigo Vivi wrote: > On Sat, Jan 14, 2023 at 07:33:53PM +0530, Deepak R Varma wrote: > > Convert function i9xx_pipe_crc_auto_source() to return void instead > > of int since the current implementation always returns 0 to the caller. > > Issue identified

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-17 Thread Matthew Brost
On Thu, Jan 12, 2023 at 04:39:32PM -0800, John Harrison wrote: > On 1/11/2023 14:56, Jason Ekstrand wrote: > > On Wed, Jan 11, 2023 at 4:32 PM Matthew Brost > > wrote: > > > > On Wed, Jan 11, 2023 at 04:18:01PM -0600, Jason Ekstrand wrote: > > > On Wed, Jan 11, 2023 at 2:50 AM Tvrtko

[Intel-gfx] linux-next: duplicate patch in the drm-intel tree

2023-01-17 Thread Stephen Rothwell
Hi all, The following commit is also in the drm-intel-fixes tree as a different commit (but the same patch): 0fe76b198d48 ("drm/i915/display: Check source height is > 0") this is commit 8565c502e7c1 ("drm/i915/display: Check source height is > 0") in the drm-intel-fixes tree. -- Cheers,

[Intel-gfx] ✗ Fi.CI.BAT: failure for Allow error capture without a request / on reset failure (rev3)

2023-01-17 Thread Patchwork
== Series Details == Series: Allow error capture without a request / on reset failure (rev3) URL : https://patchwork.freedesktop.org/series/111454/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12594 -> Patchwork_111454v3

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Allow error capture without a request / on reset failure (rev3)

2023-01-17 Thread Patchwork
== Series Details == Series: Allow error capture without a request / on reset failure (rev3) URL : https://patchwork.freedesktop.org/series/111454/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Allow error capture without a request / on reset failure (rev3)

2023-01-17 Thread Patchwork
== Series Details == Series: Allow error capture without a request / on reset failure (rev3) URL : https://patchwork.freedesktop.org/series/111454/ State : warning == Summary == Error: dim checkpatch failed 79d89c5b0cf9 drm/i915: Fix request locking during error capture & debugfs dump -:26:

Re: [Intel-gfx] [PATCH 1/1] drm/i915: re-disable RC6p on Sandy Bridge

2023-01-17 Thread Ville Syrjälä
On Wed, Dec 21, 2022 at 09:09:17AM -0500, Rodrigo Vivi wrote: > On Tue, Dec 20, 2022 at 12:32:05PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 19, 2022 at 06:29:27PM +0100, Sasa Dragic wrote: > > > RC6p on Sandy Bridge got re-enabled over time, causing visual glitches > > > and GPU hangs. > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move/adjust register definitions related to Wa_22011450934

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Move/adjust register definitions related to Wa_22011450934 URL : https://patchwork.freedesktop.org/series/112966/ State : success == Summary == CI Bug Log - changes from CI_DRM_12594 -> Patchwork_112966v1

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Unwind hugepages to drop wakeref on error (rev3)

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Unwind hugepages to drop wakeref on error (rev3) URL : https://patchwork.freedesktop.org/series/112801/ State : success == Summary == CI Bug Log - changes from CI_DRM_12590_full -> Patchwork_112801v3_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/drm_vma_manager: Add drm_vma_node_allow_once()

2023-01-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/drm_vma_manager: Add drm_vma_node_allow_once() URL : https://patchwork.freedesktop.org/series/112952/ State : success == Summary == CI Bug Log - changes from CI_DRM_12594 -> Patchwork_112952v1

[Intel-gfx] [PATCH v2 3/5] drm/i915: Allow error capture of a pending request

2023-01-17 Thread John . C . Harrison
From: John Harrison A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state claimed a batch was (maybe) in progress. So, allow capture of the pending request on the grounds that

[Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Add a debug print on GuC triggered reset

2023-01-17 Thread John . C . Harrison
From: John Harrison For understanding bug reports, it can be useful to have an explicit dmesg print when a reset notification is received from GuC. As opposed to simply inferring that this happened from other messages. Signed-off-by: John Harrison Reviewed-by: Tvrtko Ursulin ---

[Intel-gfx] [PATCH v2 2/5] drm/i915: Allow error capture without a request

2023-01-17 Thread John . C . Harrison
From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' from GuC. The problem was not reproducible. However, it is possible to happen if the context in question has no active

[Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-17 Thread John . C . Harrison
From: John Harrison Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much information out of the system as possible. Given that the GuC effectively dies on such a situation, it is not

[Intel-gfx] [PATCH v2 1/5] drm/i915: Fix request locking during error capture & debugfs dump

2023-01-17 Thread John . C . Harrison
From: John Harrison When GuC support was added to error capture, the locking around the request object was broken. Fix it up. The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only request

[Intel-gfx] [PATCH v2 0/5] Allow error capture without a request / on reset failure

2023-01-17 Thread John . C . Harrison
From: John Harrison It is technically possible to get a hung context without a valid request. In such a situation, try to provide as much information in the error capture as possible rather than just aborting and capturing nothing. Similarly, in the case of an engine reset failure the GuC is

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftest: fix intel_selftest_modify_policy argument types

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915/selftest: fix intel_selftest_modify_policy argument types URL : https://patchwork.freedesktop.org/series/112938/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12594 -> Patchwork_112938v1

Re: [Intel-gfx] [PATCH v4] vfio: fix potential deadlock on vfio group lock

2023-01-17 Thread Alex Williamson
On Fri, 13 Jan 2023 19:03:51 -0500 Matthew Rosato wrote: > Currently it is possible that the final put of a KVM reference comes from > vfio during its device close operation. This occurs while the vfio group > lock is held; however, if the vfio device is still in the kvm device list, > then the

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited URL : https://patchwork.freedesktop.org/series/112925/ State : success == Summary == CI Bug Log - changes from CI_DRM_12590_full -> Patchwork_112925v1_full

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-17 Thread John Harrison
On 1/16/2023 04:43, Tvrtko Ursulin wrote: On 14/01/2023 01:27, John Harrison wrote: On 1/13/2023 01:22, Tvrtko Ursulin wrote: On 12/01/2023 20:59, John Harrison wrote: On 1/12/2023 02:15, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftest: fix intel_selftest_modify_policy argument types

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915/selftest: fix intel_selftest_modify_policy argument types URL : https://patchwork.freedesktop.org/series/112938/ State : warning == Summary == Error: dim checkpatch failed ef0c87e4b866 drm/i915/selftest: fix intel_selftest_modify_policy argument types

Re: [Intel-gfx] linux-next: duplicate patch in the kspp tree

2023-01-17 Thread Stephen Rothwell
Hi Karol, On Tue, 17 Jan 2023 14:52:12 +0100 Karol Herbst wrote: > > On Tue, Jan 17, 2023 at 5:02 AM Stephen Rothwell > wrote: > > > > The following commit is also in the drm-misc tree as a different commit > > (but the same patch): > > > > 06b19f46455c ("drm/nouveau/fb/ga102: Replace

[Intel-gfx] [PATCH] drm/i915: Move/adjust register definitions related to Wa_22011450934

2023-01-17 Thread Matt Roper
The implementation of Wa_22011450934 introduced three new register definitions in i915_reg.h that didn't get moved to the GT/engine register headers when all the other registers moved; let's move them to the appropriate headers and tidy up their definitions now for consistency: - STATE_ACK_DEBUG

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Allow error capture without a request

2023-01-17 Thread John Harrison
On 1/16/2023 04:38, Tvrtko Ursulin wrote: On 13/01/2023 21:29, John Harrison wrote: On 1/13/2023 09:46, Hellstrom, Thomas wrote: On Fri, 2023-01-13 at 09:51 +, Tvrtko Ursulin wrote: On 12/01/2023 20:40, John Harrison wrote: On 1/12/2023 02:01, Tvrtko Ursulin wrote: On 12/01/2023 02:53,

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-17 Thread Rodrigo Vivi
On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote: > On 2023.01.10 13:49:57 -0500, Rodrigo Vivi wrote: > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > > function adds the overhead of

Re: [Intel-gfx] [PATCH] drm/i915/display: Convert i9xx_pipe_crc_auto_source to void

2023-01-17 Thread Rodrigo Vivi
On Sat, Jan 14, 2023 at 07:33:53PM +0530, Deepak R Varma wrote: > Convert function i9xx_pipe_crc_auto_source() to return void instead > of int since the current implementation always returns 0 to the caller. > Issue identified using returnvar Coccinelle semantic patch. could you please share the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: move snps_phy_failed_calibration to display sub-struct under snps

2023-01-17 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: move snps_phy_failed_calibration to display sub-struct under snps URL : https://patchwork.freedesktop.org/series/112933/ State : success == Summary == CI Bug Log - changes from CI_DRM_12592 -> Patchwork_112933v1

Re: [Intel-gfx] [PATCH] drm/i915/gt: Move LSC_CHICKEN_BIT* workarounds to correct function

2023-01-17 Thread Rodrigo Vivi
On Thu, Jan 12, 2023 at 10:19:47PM -0300, Gustavo Sousa wrote: > That register doesn't belong to a specific engine, so the proper > placement for workarounds programming it should be > general_render_compute_wa_init(). Looking to the surrounds it seems like we have more registers that are not

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add struct i915_dsm to wrap dsm members together

2023-01-17 Thread Rodrigo Vivi
On Mon, Jan 16, 2023 at 07:34:21PM +0200, Jani Nikula wrote: > Wrap the stolen memory related struct drm_i915_private members (dsm, > dsm_reserved, and stolen_usable_size) together in a a new struct > i915_dsm. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_fbc.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: GMCH refactoring (rev2)

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915: GMCH refactoring (rev2) URL : https://patchwork.freedesktop.org/series/112929/ State : success == Summary == CI Bug Log - changes from CI_DRM_12592 -> Patchwork_112929v2 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915/display: add intel_display_limits.h for key enums

2023-01-17 Thread Rodrigo Vivi
On Mon, Jan 16, 2023 at 06:46:44PM +0200, Jani Nikula wrote: > Move a handful of key enums to a new file intel_display_limits.h. These > are the enum types, and the MAX/NUM enumerations within them, that are > used in other headers. Otherwise, there's no common theme between them. > > Replace

[Intel-gfx] [PATCH 2/2] drm/i915: Fix a memory leak with reused mmap_offset

2023-01-17 Thread Nirmoy Das
drm_vma_node_allow() and drm_vma_node_revoke() should be called in balanced pairs. We call drm_vma_node_allow() once per-file everytime a user calls mmap_offset, but only call drm_vma_node_revoke once per-file on each mmap_offset. As the mmap_offset is reused by the client, the per-file vm_count

[Intel-gfx] [PATCH 1/2] drm/drm_vma_manager: Add drm_vma_node_allow_once()

2023-01-17 Thread Nirmoy Das
Currently there is no easy way for a drm driver to safely check and allow drm_vma_offset_node for a drm file just once. Allow drm drivers to call non-refcounted version of drm_vma_node_allow() so that a driver doesn't need to keep track of each drm_vma_node_allow() to call subsequent

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: extract vblank/scanline code to a separate file

2023-01-17 Thread Ville Syrjälä
On Mon, Jan 16, 2023 at 02:56:11PM +0200, Jani Nikula wrote: > Basically just https://patchwork.freedesktop.org/series/111854/ with the > two controversial patches dropped for now. > > BR, > Jani. > > Jani Nikula (5): > drm/i915/irq: split out vblank/scanline code to intel_vblank.[ch] >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: GMCH refactoring (rev2)

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915: GMCH refactoring (rev2) URL : https://patchwork.freedesktop.org/series/112929/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove a couple of superfluous i915_drm.h includes

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915: remove a couple of superfluous i915_drm.h includes URL : https://patchwork.freedesktop.org/series/112931/ State : success == Summary == CI Bug Log - changes from CI_DRM_12592 -> Patchwork_112931v1

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-17 Thread Jason Ekstrand
On Thu, Jan 12, 2023 at 11:17 AM Matthew Brost wrote: > On Thu, Jan 12, 2023 at 10:54:25AM +0100, Lucas De Marchi wrote: > > On Thu, Jan 05, 2023 at 09:27:57PM +, Matthew Brost wrote: > > > On Tue, Jan 03, 2023 at 12:21:08PM +, Tvrtko Ursulin wrote: > > > > > > > > On 22/12/2022 22:21,

[Intel-gfx] [PATCH] drm/i915/selftest: fix intel_selftest_modify_policy argument types

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann The definition of intel_selftest_modify_policy() does not match the declaration, as gcc-13 points out: drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c:29:5: error: conflicting types for 'intel_selftest_modify_policy' due to enum/integer mismatch; have 'int(struct

Re: [Intel-gfx] [RFC 04/12] drm/cgroup: Track clients per owning process

2023-01-17 Thread Tvrtko Ursulin
On 17/01/2023 16:03, Stanislaw Gruszka wrote: Hi On Thu, Jan 12, 2023 at 04:56:01PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin To enable propagation of settings from the cgroup drm controller to drm we need to start tracking which processes own which drm clients. Implement that by

Re: [Intel-gfx] [PATCH 0/4] drm/i915: GMCH refactoring

2023-01-17 Thread Ville Syrjälä
On Tue, Jan 17, 2023 at 02:33:05PM +0200, Jani Nikula wrote: > Let's see if this sticks. > > Jani Nikula (4): > drm/i915: add gmch substruct to struct drm_i915_private > drm/i915/gmch: split out soc/intel_gmch > drm/i915/gmch: mass rename dev_priv to i915 > drm/i915/gmch: move VGA set

Re: [Intel-gfx] [PATCH 0/4] drm/i915: GMCH refactoring

2023-01-17 Thread Rodrigo Vivi
On Tue, Jan 17, 2023 at 02:33:05PM +0200, Jani Nikula wrote: > Let's see if this sticks. Suddenly all of these 'bridge_dev' makes some sense to me. I believe we could enjoy the refactor here and add some documentation about this... at least the name Graphics Memory Controller Hub name... I also

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-17 Thread Jason Ekstrand
On Thu, Dec 22, 2022 at 4:29 PM Matthew Brost wrote: > Hello, > > This is a submission for Xe, a new driver for Intel GPUs that supports both > integrated and discrete platforms starting with Tiger Lake (first platform > with > Intel Xe Architecture). The intention of this new driver is to have

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-17 Thread Das, Nirmoy
|Reviewed-by: Nirmoy Das | On 1/17/2023 1:32 PM, Nirmoy Das wrote: From: Chris Wilson Make sure that upon error after we have acquired the wakeref we do release it again. v2: add another missing "goto out_wf"(Andi). Fixes: 027c38b4121e ("drm/i915/selftests: Grab the runtime pm in

Re: [Intel-gfx] [RFC 04/12] drm/cgroup: Track clients per owning process

2023-01-17 Thread Stanislaw Gruszka
Hi On Thu, Jan 12, 2023 at 04:56:01PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > To enable propagation of settings from the cgroup drm controller to drm we > need to start tracking which processes own which drm clients. > > Implement that by tracking the struct pid pointer of the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: move chv_dpll_md and bxt_phy_grc to display sub-struct under state

2023-01-17 Thread Rodrigo Vivi
On Tue, Jan 17, 2023 at 04:39:46PM +0200, Jani Nikula wrote: > Move the display related members to the struct drm_i915_private display > sub-struct. Put them under "state", as they are related to storing > values that aren't readable from the hardware, to appease the state > checker. > >

[Intel-gfx] ✓ Fi.CI.IGT: success for Add new CDCLK step for RPL-U (rev5)

2023-01-17 Thread Patchwork
== Series Details == Series: Add new CDCLK step for RPL-U (rev5) URL : https://patchwork.freedesktop.org/series/111472/ State : success == Summary == CI Bug Log - changes from CI_DRM_12589_full -> Patchwork_111472v5_full Summary ---

Re: [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Sam Ravnborg
Hi Nirmoy On Tue, Jan 17, 2023 at 12:53:49PM +0100, Nirmoy Das wrote: > Add a function for ratelimitted debug print. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Reviewed-by: Matthew Auld > Signed-off-by: Nirmoy Das Thanks

Re: [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Das, Nirmoy
Hi Sam, On 1/17/2023 3:49 PM, Sam Ravnborg wrote: Hi Nirmoy On Tue, Jan 17, 2023 at 12:53:49PM +0100, Nirmoy Das wrote: Add a function for ratelimitted debug print. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld

[Intel-gfx] [PATCH 3/3] drm/i915: move chv_dpll_md and bxt_phy_grc to display sub-struct under state

2023-01-17 Thread Jani Nikula
Move the display related members to the struct drm_i915_private display sub-struct. Put them under "state", as they are related to storing values that aren't readable from the hardware, to appease the state checker. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [PATCH 2/3] drm/i915: move pch_ssc_use to display sub-struct under dpll

2023-01-17 Thread Jani Nikula
Move the display related member to the struct drm_i915_private display sub-struct. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_core.h | 5 + drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 4 ++-- drivers/gpu/drm/i915/display/intel_pch_refclk.c | 10

[Intel-gfx] [PATCH 1/3] drm/i915: move snps_phy_failed_calibration to display sub-struct under snps

2023-01-17 Thread Jani Nikula
Move the display related member to the struct drm_i915_private display sub-struct. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/display/intel_display_core.h | 8 drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +-

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: GMCH refactoring

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915: GMCH refactoring URL : https://patchwork.freedesktop.org/series/112929/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12590 -> Patchwork_112929v1 Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Unwind hugepages to drop wakeref on error (rev3)

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Unwind hugepages to drop wakeref on error (rev3) URL : https://patchwork.freedesktop.org/series/112801/ State : success == Summary == CI Bug Log - changes from CI_DRM_12590 -> Patchwork_112801v3

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/print: Add drm_dbg_ratelimited URL : https://patchwork.freedesktop.org/series/112925/ State : success == Summary == CI Bug Log - changes from CI_DRM_12590 -> Patchwork_112925v1

Re: [Intel-gfx] [PATCH] drm/i915: remove a couple of superfluous i915_drm.h includes

2023-01-17 Thread Andi Shyti
Hi Jani, On Tue, Jan 17, 2023 at 02:38:56PM +0200, Jani Nikula wrote: > Remove a couple of unnecessary includes. > > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyti Thanks, Andi > --- > drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 1 - > drivers/gpu/drm/i915/pxp/intel_pxp_huc.c | 2 -- >

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-17 Thread Andi Shyti
Hi Nirmoy, On Tue, Jan 17, 2023 at 01:32:34PM +0100, Nirmoy Das wrote: > From: Chris Wilson > > Make sure that upon error after we have acquired the wakeref we do > release it again. > > v2: add another missing "goto out_wf"(Andi). > > Fixes: 027c38b4121e ("drm/i915/selftests: Grab the

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm

2023-01-17 Thread Andi Shyti
Hi Nirmoy, On Tue, Jan 17, 2023 at 12:53:50PM +0100, Nirmoy Das wrote: > Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause > dmesg spamming. Use ratelimit api to reduce log rate. > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 > Cc: Matthew Auld > >

Re: [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Andi Shyti
Hi, can any of the DRM maintainers please check and eventually ack this patch? On Tue, Jan 17, 2023 at 12:53:49PM +0100, Nirmoy Das wrote: > Add a function for ratelimitted debug print. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel

Re: [Intel-gfx] linux-next: duplicate patch in the kspp tree

2023-01-17 Thread Karol Herbst
On Tue, Jan 17, 2023 at 5:02 AM Stephen Rothwell wrote: > > Hi all, > > The following commit is also in the drm-misc tree as a different commit > (but the same patch): > > 06b19f46455c ("drm/nouveau/fb/ga102: Replace zero-length array of trailing > structs with flex-array") > which branch?

[Intel-gfx] ✓ Fi.CI.BAT: success for Add new CDCLK step for RPL-U (rev5)

2023-01-17 Thread Patchwork
== Series Details == Series: Add new CDCLK step for RPL-U (rev5) URL : https://patchwork.freedesktop.org/series/111472/ State : success == Summary == CI Bug Log - changes from CI_DRM_12589 -> Patchwork_111472v5 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: GMCH refactoring

2023-01-17 Thread Patchwork
== Series Details == Series: drm/i915: GMCH refactoring URL : https://patchwork.freedesktop.org/series/112929/ State : warning == Summary == Error: dim checkpatch failed f3652809952f drm/i915: add gmch substruct to struct drm_i915_private a0209e099f2c drm/i915/gmch: split out soc/intel_gmch

[Intel-gfx] [PATCH] drm/i915: remove a couple of superfluous i915_drm.h includes

2023-01-17 Thread Jani Nikula
Remove a couple of unnecessary includes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 1 - drivers/gpu/drm/i915/pxp/intel_pxp_huc.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c

  1   2   >