Re: [Intel-gfx] [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-27 Thread Thomas Hellström
Hi, On 2/23/23 19:50, Alex Deucher wrote: On Thu, Feb 23, 2023 at 10:03 AM Thomas Hellström wrote: Hi, Daniel, On 2/16/23 21:18, Daniel Vetter wrote: On Thu, Feb 16, 2023 at 05:27:28PM +0100, Thomas Hellström wrote: A slightly unusual cover letter for a single patch. The page table walker

Re: [Intel-gfx] [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-27 Thread Thomas Hellström
Hi, Oded. On 2/26/23 19:56, Oded Gabbay wrote: On Thu, Feb 23, 2023 at 8:50 PM Alex Deucher wrote: On Thu, Feb 23, 2023 at 10:03 AM Thomas Hellström wrote: Hi, Daniel, On 2/16/23 21:18, Daniel Vetter wrote: On Thu, Feb 16, 2023 at 05:27:28PM +0100, Thomas Hellström wrote: A slightly unusu

Re: [Intel-gfx] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Thomas Hellström
Daniel, Dave Ack to merge this to drm through drm-misc-next? /Thomas On 2/24/23 10:51, Thomas Hellström wrote: This series (or at least the suballocator helper) is a prerequisite for the new Xe driver. There was an unresolved issue when the series was last up for review, and that was the per

Re: [Intel-gfx] [Intel-xe] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Thomas Hellström
Hi, Maarten, On 2/27/23 09:55, Maarten Lankhorst wrote: Hey, I can push this to drm-misc-next, I don't think a drm maintainer ack is needed, as long as we have the acks from the amd folk for merging through drm-misc-next. OK, sound good, we have that ack so please go ahead! /Thomas ~Ma

[Intel-gfx] [PATCH] drm/i915/display: Communicate display power demands to pcode more accurately

2023-02-27 Thread Stanislav Lisovskiy
Display to communicate display pipe count/CDCLK/voltage configuration to Pcode for more accurate power accounting for gen >= 12. Existing sequence is only sending the voltage value to the Pcode. Adding new sequence with current cdclk associate with voltage value masking. Adding pcode request when a

Re: [Intel-gfx] [PATCH v5 1/7] arch: rename all internal names __xchg to __arch_xchg

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:44PM +0100, Andrzej Hajda wrote: > __xchg will be used for non-atomic xchg macro. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Arnd Bergmann > Acked-by: Geert Uytterhoeven [m68k] > Acked-by: Palmer Dabbelt [riscv] Reviewed-by: Andi Shyti Thanks,

Re: [Intel-gfx] [PATCH v5 2/7] linux/include: add non-atomic version of xchg

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:45PM +0100, Andrzej Hajda wrote: > The pattern of setting variable with new value and returning old > one is very common in kernel. Usually atomicity of the operation > is not required, so xchg seems to be suboptimal and confusing in > such cases. > > Sig

Re: [Intel-gfx] [PATCH v5 3/7] arch/*/uprobes: simplify arch_uretprobe_hijack_return_addr

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:46PM +0100, Andrzej Hajda wrote: > In all architectures, except x86, arch_uretprobe_hijack_return_addr > is just __xchg. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [Intel-gfx] [PATCH v5 4/7] llist: simplify __llist_del_all

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:47PM +0100, Andrzej Hajda wrote: > llist_del_all uses xchg, let's use __xchg here. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [Intel-gfx] [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer

2023-02-27 Thread Jani Nikula
On Tue, 14 Feb 2023, Arun R Murthy wrote: > Enable SDP error detection configuration, this will set CRC16 in > 128b/132b link layer. > For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is > added to enable/disable SDP CRC applicable for DP2.0 only, but the > default value of this b

Re: [Intel-gfx] [PATCH v5 6/7] qed: use __xchg if possible

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:49PM +0100, Andrzej Hajda wrote: > Recently introduced helper simplifies the code. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915/gt: use __xchg instead of internal helper

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:50PM +0100, Andrzej Hajda wrote: > Prefer core helper if available. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [Intel-gfx] [PATCH v5 5/7] io_uring: use __xchg if possible

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:48PM +0100, Andrzej Hajda wrote: > Recently introduced helper simplifies the code. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/display: Communicate display power demands to pcode more accurately

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode more accurately URL : https://patchwork.freedesktop.org/series/114401/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool CC [M] drivers/gpu/drm/i915

[Intel-gfx] [PULL] drm-intel-next-fixes

2023-02-27 Thread Jani Nikula
Hi Dave & Daniel - Some more fixes for v6.3-rc1. drm-intel-next-fixes-2023-02-27: drm/i915 fixes for v6.3-rc1: - Don't use stolen memory or BAR mappings for ring buffers with LLC - Add inverted backlight quirk for HP 14-r206nv - Fix GSI offset for MCR lookups - GVT fixes (memleak, debugfs attri

[Intel-gfx] [PATCH] drm/tests: Suballocator test

2023-02-27 Thread Thomas Hellström
Add a suballocator test to get some test coverage for the new drm suballocator, and perform some basic timing (elapsed time). Signed-off-by: Thomas Hellström --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/tests/Makefile| 3 +- drivers/gpu/drm/tests/drm_subal

[Intel-gfx] [PATCH v5 01/19] vfio: Allocate per device file structure

2023-02-27 Thread Yi Liu
This is preparation for adding vfio device cdev support. vfio device cdev requires: 1) a per device file memory to store the kvm pointer set by KVM. It will be propagated to vfio_device:kvm after the device cdev file is bound to an iommufd 2) a mechanism to block device access through device

[Intel-gfx] [PATCH v5 00/19] Add vfio_device cdev for iommufd support

2023-02-27 Thread Yi Liu
Existing VFIO provides group-centric user APIs for userspace. Userspace opens the /dev/vfio/$group_id first before getting device fd and hence getting access to device. This is not the desired model for iommufd. Per the conclusion of community discussion[1], iommufd provides device-centric kAPIs an

[Intel-gfx] [PATCH v5 06/19] vfio: Pass struct vfio_device_file * to vfio_device_open/close()

2023-02-27 Thread Yi Liu
This avoids passing too much parameters in multiple functions. Signed-off-by: Yi Liu Reviewed-by: Kevin Tian --- drivers/vfio/group.c | 19 +-- drivers/vfio/vfio.h | 8 drivers/vfio/vfio_main.c | 25 +++-- 3 files changed, 32 insertions(+),

[Intel-gfx] [PATCH v5 07/19] vfio: Block device access via device fd until device is opened

2023-02-27 Thread Yi Liu
Allow the vfio_device file to be in a state where the device FD is opened but the device cannot be used by userspace (i.e. its .open_device() hasn't been called). This inbetween state is not used when the device FD is spawned from the group FD, however when we create the device FD directly by openi

[Intel-gfx] [PATCH v5 02/19] vfio: Refine vfio file kAPIs for KVM

2023-02-27 Thread Yi Liu
This prepares for making the below kAPIs to accept both group file and device file instead of only vfio group file. bool vfio_file_enforced_coherent(struct file *file); void vfio_file_set_kvm(struct file *file, struct kvm *kvm); Besides the above change, vfio_file_is_valid() is added to check

[Intel-gfx] [PATCH v5 03/19] vfio: Accept vfio device file in the KVM facing kAPI

2023-02-27 Thread Yi Liu
This makes the vfio file kAPIs to accepte vfio device files, also a preparation for vfio device cdev support. For the kvm set with vfio device file, kvm pointer is stored in struct vfio_device_file, and use kvm_ref_lock to protect kvm set and kvm pointer usage within VFIO. This kvm pointer will be

[Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-02-27 Thread Yi Liu
to indicate kernel to use the device's bound iommufd_ctx for the device ownership check. Kernel should loop all the opened devices in the dev_set, and check if they are bound to the same iommufd_ctx. For the devices that has not been opened yet but affected, they can be reset by the current users a

[Intel-gfx] [PATCH v5 12/19] vfio-iommufd: Add detach_ioas for emulated VFIO devices

2023-02-27 Thread Yi Liu
this prepares for adding DETACH ioctl for emulated VFIO devices. Signed-off-by: Yi Liu Reviewed-by: Kevin Tian --- drivers/gpu/drm/i915/gvt/kvmgt.c | 1 + drivers/s390/cio/vfio_ccw_ops.c | 1 + drivers/s390/crypto/vfio_ap_ops.c | 1 + drivers/vfio/iommufd.c| 18 +++

[Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-27 Thread Yi Liu
For the device fd opened from cdev, userspace needs to bind it to an iommufd and attach it to IOAS managed by iommufd. With such operations, userspace can set up a secure DMA context and hence access device. This changes the existing vfio_iommufd_bind() to accept a pt_id pointer as an optional inp

[Intel-gfx] [PATCH v5 05/19] kvm/vfio: Accept vfio device file from userspace

2023-02-27 Thread Yi Liu
This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. Old userspace uses KVM_DEV_VFIO_GROUP* works as well. Signed-off-by: Yi Liu --- Documentation/virt/kvm/devices/vfio.rst | 52 + include/uapi/linux/kvm.h| 16 ++-- virt/kvm/vfio.c

[Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-27 Thread Yi Liu
This adds ioctl for userspace to attach device cdev fd to and detach from IOAS/hw_pagetable managed by iommufd. VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach vfio device to IOAS, hw_pagetable managed by iommufd. Attach can be undo b

[Intel-gfx] [PATCH v5 08/19] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset()

2023-02-27 Thread Yi Liu
this suits more on what the code does. Signed-off-by: Yi Liu Reviewed-by: Kevin Tian --- drivers/vfio/pci/vfio_pci_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c index a6492a25ff6a..1bf54beeaef2

[Intel-gfx] [PATCH v5 15/19] vfio: Add cdev for vfio_device

2023-02-27 Thread Yi Liu
This allows user to directly open a vfio device w/o using the legacy container/group interface, as a prerequisite for supporting new iommu features like nested translation. The device fd opened in this manner doesn't have the capability to access the device as the fops open() doesn't open the devi

[Intel-gfx] [PATCH v5 04/19] kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fd

2023-02-27 Thread Yi Liu
Meanwhile, rename related helpers. No functional change is intended. Signed-off-by: Yi Liu Reviewed-by: Kevin Tian Reviewed-by: Eric Auger --- virt/kvm/vfio.c | 115 1 file changed, 58 insertions(+), 57 deletions(-) diff --git a/virt/kvm/vfio.c

[Intel-gfx] [PATCH v5 11/19] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-02-27 Thread Yi Liu
this prepares for adding DETACH ioctl for physical VFIO devices. Signed-off-by: Yi Liu Reviewed-by: Kevin Tian --- Documentation/driver-api/vfio.rst | 8 +--- drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 + drivers/vfio/iommufd.c| 20 ++

[Intel-gfx] [PATCH v5 16/19] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-02-27 Thread Yi Liu
This adds ioctl for userspace to bind device cdev fd to iommufd. VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA control provided by the iommufd. open_device op is called after bind_iommufd op.

[Intel-gfx] [PATCH v5 13/19] vfio: Add cdev_device_open_cnt to vfio_group

2023-02-27 Thread Yi Liu
for counting the devices that are opened via the cdev path. This count is increased and decreased by the cdev path. The group path checks it to achieve exclusion with the cdev path. With this, only one path (group path or cdev path) will claim DMA ownership. This avoids scenarios in which devices w

[Intel-gfx] [PATCH v5 18/19] vfio: Compile group optionally

2023-02-27 Thread Yi Liu
group code is not needed for vfio device cdev, so with vfio device cdev introduced, the group infrastructures can be compiled out if only cdev is needed. Signed-off-by: Yi Liu --- drivers/vfio/Kconfig | 14 + drivers/vfio/Makefile | 2 +- drivers/vfio/vfio.h | 72

[Intel-gfx] [PATCH v5 14/19] vfio: Make vfio_device_open() single open for device cdev path

2023-02-27 Thread Yi Liu
VFIO group has historically allowed multi-open of the device FD. This was made secure because the "open" was executed via an ioctl to the group FD which is itself only single open. However, no known use of multiple device FDs today. It is kind of a strange thing to do because new device FDs can na

[Intel-gfx] [PATCH v5 19/19] docs: vfio: Add vfio device cdev description

2023-02-27 Thread Yi Liu
This gives notes for userspace applications on device cdev usage. Signed-off-by: Yi Liu --- Documentation/driver-api/vfio.rst | 125 ++ 1 file changed, 125 insertions(+) diff --git a/Documentation/driver-api/vfio.rst b/Documentation/driver-api/vfio.rst index 4452742

Re: [Intel-gfx] [PATCH] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Matthew Auld
On 24/02/2023 17:40, Jonathan Cavitt wrote: MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because MTL reports as not supporting 64K pages, or more accurately, the system that reports whether a platform has 64K pages reports false for MTL. This is only half corre

[Intel-gfx] [PATCH] drm/i915: Implement UHBR bandwidth check

2023-02-27 Thread Stanislav Lisovskiy
According to spec, we should check if output_bpp * pixel_rate is less than DDI clock * 72, if UHBR is used. v2: - s/pipe_config/crtc_state/ (Jani Nikula) - Merged previous patch into that one, to remove empty function(Jani Nikula) HSDES: 1406899791 BSPEC: 49259 Signed-off-by: Stanislav Lisov

Re: [Intel-gfx] [PATCH] drm/i915: Set wedged if enable guc communication failed

2023-02-27 Thread Jani Nikula
On Fri, 24 Feb 2023, Zhanjun Dong wrote: > Add err code check for enable_communication on resume path, set wedged if > failed. I can see that this is *what* the code does, but the commit message should answer the question *why*. > > Signed-off-by: Zhanjun Dong > --- > drivers/gpu/drm/i915/gt/

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add vfio_device cdev for iommufd support (rev5)

2023-02-27 Thread Patchwork
== Series Details == Series: Add vfio_device cdev for iommufd support (rev5) URL : https://patchwork.freedesktop.org/series/113696/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/113696/revisions/5/mbox/ not applied Applying: vfio: Allocate per de

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Separate wakeref tracking

2023-02-27 Thread Jani Nikula
On Fri, 24 Feb 2023, Andrzej Hajda wrote: > From: Chris Wilson > > Extract the callstack tracking of intel_runtime_pm.c into its own > utility so that that we can reuse it for other online debugging of > scoped wakerefs. > > Signed-off-by: Chris Wilson > Signed-off-by: Andrzej Hajda > --- > dr

Re: [Intel-gfx] [PATCH] drm/i915/display: Communicate display power demands to pcode more accurately

2023-02-27 Thread kernel test robot
Hi Stanislav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Lisovskiy/drm-i915-display-Communicate-display-power-demands-to-pcode-more-accurately/20230227-175404 base: git

Re: [Intel-gfx] [PATCH] drm/i915/display: Communicate display power demands to pcode more accurately

2023-02-27 Thread kernel test robot
Hi Stanislav, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Lisovskiy/drm-i915-display-Communicate-display-power-demands-to-pcode-more-accurately/20230227-175404 base: git

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix audio ELD handling for DP MST

2023-02-27 Thread Jani Nikula
On Thu, 23 Feb 2023, Ville Syrjälä wrote: > On Thu, Feb 23, 2023 at 05:01:11PM +, Shankar, Uma wrote: >> >> >> > -Original Message- >> > From: Ville Syrjälä >> > Sent: Thursday, February 23, 2023 8:37 PM >> > To: Shankar, Uma >> > Cc: intel-gfx@lists.freedesktop.org >> > Subject: R

Re: [Intel-gfx] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Dmitry Baryshkov
On Mon, 27 Feb 2023 at 01:49, Abhinav Kumar wrote: > > > > On 2/26/2023 5:09 AM, Dmitry Baryshkov wrote: > > On 26/02/2023 02:47, Abhinav Kumar wrote: > >> Hi Dmitry > >> > >> On 2/25/2023 7:23 AM, Dmitry Baryshkov wrote: > >>> On 25/02/2023 02:36, Abhinav Kumar wrote: > > > On 2/24

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-02-27 Thread Oded Gabbay
On Fri, Feb 17, 2023 at 10:51 PM Daniel Vetter wrote: > > Hi all, > > [I thought I've sent this out earlier this week, but alas got stuck, kinda > bad timing now since I'm out next week but oh well] > > So xe is a quite substantial thing, and I think we need a clear plan how to > land > this or i

Re: [Intel-gfx] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Jani Nikula
On Sun, 26 Feb 2023, Abhinav Kumar wrote: > On 2/26/2023 5:09 AM, Dmitry Baryshkov wrote: >> On 26/02/2023 02:47, Abhinav Kumar wrote: >>> Hi Dmitry >>> >>> On 2/25/2023 7:23 AM, Dmitry Baryshkov wrote: On 25/02/2023 02:36, Abhinav Kumar wrote: > > > On 2/24/2023 3:53 PM, Dmitry B

Re: [Intel-gfx] [PATCH] drm/i915/display: Communicate display power demands to pcode more accurately

2023-02-27 Thread kernel test robot
Hi Stanislav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Lisovskiy/drm-i915-display-Communicate-display-power-demands-to-pcode-more-accurately/20230227-175404 base: git

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix audio ELD handling for DP MST

2023-02-27 Thread Shankar, Uma
> -Original Message- > From: Jani Nikula > Sent: Monday, February 27, 2023 6:07 PM > To: Ville Syrjälä ; Shankar, Uma > > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix audio ELD handling for DP > MST > > On Thu, 23 Feb 2023, Ville Syrjälä wr

Re: [Intel-gfx] [Intel-xe] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Christian König
Am 27.02.23 um 10:00 schrieb Thomas Hellström: Hi, Maarten, On 2/27/23 09:55, Maarten Lankhorst wrote: Hey, I can push this to drm-misc-next, I don't think a drm maintainer ack is needed, as long as we have the acks from the amd folk for merging through drm-misc-next. OK, sound good, we h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/tests: Suballocator test

2023-02-27 Thread Patchwork
== Series Details == Series: drm/tests: Suballocator test URL : https://patchwork.freedesktop.org/series/114410/ State : success == Summary == CI Bug Log - changes from CI_DRM_12779 -> Patchwork_114410v1 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Implement UHBR bandwidth check (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915: Implement UHBR bandwidth check (rev2) URL : https://patchwork.freedesktop.org/series/112806/ State : success == Summary == CI Bug Log - changes from CI_DRM_12779 -> Patchwork_112806v2 Summary ---

[Intel-gfx] [PATCH] drm/i915/display: Communicate display power demands to pcode more accurately

2023-02-27 Thread Stanislav Lisovskiy
Display to communicate display pipe count/CDCLK/voltage configuration to Pcode for more accurate power accounting for gen >= 12. Existing sequence is only sending the voltage value to the Pcode. Adding new sequence with current cdclk associate with voltage value masking. Adding pcode request when a

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Communicate display power demands to pcode more accurately (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode more accurately (rev2) URL : https://patchwork.freedesktop.org/series/114401/ State : warning == Summary == Error: dim checkpatch failed 5390f300e150 drm/i915/display: Communicate display power demands t

Re: [Intel-gfx] [PATCH v5 0/7] Introduce __xchg, non-atomic xchg

2023-02-27 Thread Peter Zijlstra
On Thu, Feb 23, 2023 at 10:24:19PM +0100, Andrzej Hajda wrote: > On 22.02.2023 18:04, Peter Zijlstra wrote: > > On Wed, Jan 18, 2023 at 04:35:22PM +0100, Andrzej Hajda wrote: > > > > > Andrzej Hajda (7): > > >arch: rename all internal names __xchg to __arch_xchg > > >linux/include: add non

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Communicate display power demands to pcode more accurately (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode more accurately (rev2) URL : https://patchwork.freedesktop.org/series/114401/ State : success == Summary == CI Bug Log - changes from CI_DRM_12779 -> Patchwork_114401v2 ==

Re: [Intel-gfx] [PATCH] drm/tests: Suballocator test

2023-02-27 Thread kernel test robot
Hi Thomas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-tests-Suballocator-test/20230227-184044 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link

[Intel-gfx] [PATCH] drm/edid: Fix csync detailed mode parsing

2023-02-27 Thread Ville Syrjala
From: Ville Syrjälä Remove the bogus csync check and replace it with something that: - triggers for all forms of csync, not just the basic analog variant - actually populates the mode csync flags so that drivers can decide what to do with the mode Originally the code tried to outright reject c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/tests: Suballocator test

2023-02-27 Thread Patchwork
== Series Details == Series: drm/tests: Suballocator test URL : https://patchwork.freedesktop.org/series/114410/ State : success == Summary == CI Bug Log - changes from CI_DRM_12779_full -> Patchwork_114410v1_full Summary --- **SUCCE

Re: [Intel-gfx] [PATCH] drm/tests: Suballocator test

2023-02-27 Thread kernel test robot
Hi Thomas, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-tests-Suballocator-test/20230227-184044 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link

Re: [Intel-gfx] [PATCH 0/4] drm/displayid: use primary use case to figure out non-desktop

2023-02-27 Thread Jani Nikula
On Mon, 27 Feb 2023, Dmitry Osipenko wrote: > On 2/21/23 19:29, Dmitry Osipenko wrote: >> On 2/20/23 18:44, Dmitry Osipenko wrote: >>> On 2/16/23 23:44, Jani Nikula wrote: Mostly this is prep work and plumbing for easier use of displayid structure version and primary use case for parsing

Re: [Intel-gfx] [Intel-xe] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Alex Deucher
On Mon, Feb 27, 2023 at 8:04 AM Christian König wrote: > > Am 27.02.23 um 10:00 schrieb Thomas Hellström: > > Hi, Maarten, > > > > On 2/27/23 09:55, Maarten Lankhorst wrote: > >> Hey, > >> > >> I can push this to drm-misc-next, I don't think a drm maintainer ack > >> is needed, as long as we have

Re: [Intel-gfx] [PATCH] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Cavitt, Jonathan
-Original Message- From: Auld, Matthew Sent: Monday, February 27, 2023 3:20 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; thomas.hellst...@linux.intel.com; maarten.lankho...@linux.intel.com; Vetter, Daniel ; De Marchi, Lucas ; chris.p.wil...@linux.intel.c

Re: [Intel-gfx] [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-27 Thread Stanislaw Gruszka
On Mon, Feb 27, 2023 at 09:09:14AM +0100, Thomas Hellström wrote: > Hi, Oded. > > On 2/26/23 19:56, Oded Gabbay wrote: > > On Thu, Feb 23, 2023 at 8:50 PM Alex Deucher wrote: > > > On Thu, Feb 23, 2023 at 10:03 AM Thomas Hellström > > > wrote: > > > > Hi, Daniel, > > > > > > > > On 2/16/23 21:1

Re: [Intel-gfx] [PATCH] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Matthew Auld
On 27/02/2023 15:06, Cavitt, Jonathan wrote: -Original Message- From: Auld, Matthew Sent: Monday, February 27, 2023 3:20 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Dutt, Sudeep ; thomas.hellst...@linux.intel.com; maarten.lankho...@linux.intel.com; Vetter, Daniel ; De

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Implement UHBR bandwidth check (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915: Implement UHBR bandwidth check (rev2) URL : https://patchwork.freedesktop.org/series/112806/ State : success == Summary == CI Bug Log - changes from CI_DRM_12779_full -> Patchwork_112806v2_full Summary

Re: [Intel-gfx] [PATCH v4] drm/i915: add guard page to ggtt->error_capture

2023-02-27 Thread Andrzej Hajda
Hi all, As suggested by Rodrigo added CC: Tvrtko and Joonas, see below. On 22.02.2023 21:48, Rodrigo Vivi wrote: On Wed, Feb 22, 2023 at 01:05:16PM +0100, Andrzej Hajda wrote: Hi all, Gently ping on the patch. CI pollution is quite high: $ grep 'PTE Read access' CI/drm-tip/CI_DRM_12768/*/dm

[Intel-gfx] [PATCH v4 1/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Jonathan Cavitt
MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because MTL reports as not supporting 64K pages, or more accurately, the system that reports whether a platform has 64K pages reports false for MTL. This is only half correct, as the 64K page support reporting system o

[Intel-gfx] [PATCH v4 2/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Jonathan Cavitt
Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into live selftests as their requirements have recently become platform-dependent. Additionally, apply necessary platform dependency checks to these tests. Signed-off-by: Jonathan Cavitt --- .../gpu/drm/i915/gem/selftests

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: Fix csync detailed mode parsing

2023-02-27 Thread Patchwork
== Series Details == Series: drm/edid: Fix csync detailed mode parsing URL : https://patchwork.freedesktop.org/series/114424/ State : success == Summary == CI Bug Log - changes from CI_DRM_12786 -> Patchwork_114424v1 Summary --- **SU

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL URL : https://patchwork.freedesktop.org/series/114428/ State : warning == Summary == Error: dim checkpatch failed 39e49179dfa7 drm/i915: Use correct huge page manager for MTL -:6: WARNIN

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915: Use correct huge page manager for MTL URL : https://patchwork.freedesktop.org/series/114428/ State : success == Summary == CI Bug Log - changes from CI_DRM_12786 -> Patchwork_114428v1

Re: [Intel-gfx] [PATCH v2] drm/i915/gen12: Update combo PHY init sequence

2023-02-27 Thread Matt Atwood
On Tue, Feb 21, 2023 at 12:18:36PM -0800, Matt Roper wrote: > The bspec was updated with a minor change to the 'DCC mode select' > setting to be programmed during combo PHY initialization. > > v2: > - Keep the opencoded rmw behavior instead of switching to >intel_de_rmw(). We need to read fr

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen12: Update combo PHY init sequence (rev2)

2023-02-27 Thread Matt Roper
On Tue, Feb 21, 2023 at 11:26:58PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gen12: Update combo PHY init sequence (rev2) > URL : https://patchwork.freedesktop.org/series/114233/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12768_full -> Pa

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Matthew Auld
On 27/02/2023 16:21, Jonathan Cavitt wrote: Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into live selftests as their requirements have recently become platform-dependent. Additionally, apply necessary platform dependency checks to these tests. Signed-off-by: Jonath

[Intel-gfx] [PATCH v3 1/4] drm/i915/power: move dc state members to struct i915_power_domains

2023-02-27 Thread Jani Nikula
There's only one reference to the struct intel_dmc members dc_state, target_dc_state, and allowed_dc_mask within intel_dmc.c, begging the question why they are under struct intel_dmc to begin with. Moreover, the only references to i915->display.dmc outside of intel_dmc.c are to these members. The

[Intel-gfx] [PATCH v5 1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Jonathan Cavitt
Convert the igt_mock_ppgtt_huge_fill and igt_mock_ppgtt_64K mock selftests into live selftests as their requirements have recently become platform-dependent. Additionally, apply necessary platform dependency checks to these tests. v2: Reorder Signed-off-by: Jonathan Cavitt --- .../gpu/drm/i915/

[Intel-gfx] [PATCH v5 2/2] drm/i915: Use correct huge page manager for MTL

2023-02-27 Thread Jonathan Cavitt
MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. This is because MTL reports as not supporting 64K pages, or more accurately, the system that reports whether a platform has 64K pages reports false for MTL. This is only half correct, as the 64K page support reporting system o

[Intel-gfx] [PATCH v3 2/4] drm/i915/dmc: use has_dmc_id_fw() instead of poking dmc->dmc_info directly

2023-02-27 Thread Jani Nikula
This will help in follow-up changes. Cc: Imre Deak Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c index ab4fdedd4

[Intel-gfx] [PATCH v3 3/4] drm/i915/dmc: add i915_to_dmc() and dmc->i915 and use them

2023-02-27 Thread Jani Nikula
Start preparing for dynamically allocated struct intel_dmc by adding i915_to_dmc() and dmc->i915, and using them. Take the future NULL dmc pointer into account already now, and add separate logging for initialization in the DMC debugfs. v2: - Don't reduce debugfs output (Imre) Cc: Imre Deak Sign

[Intel-gfx] [PATCH v3 4/4] drm/i915/dmc: allocate dmc structure dynamically

2023-02-27 Thread Jani Nikula
sizeof(struct intel_dmc) > 1024 bytes, allocated on all platforms as part of struct drm_i915_private, whether they have DMC or not. Allocate struct intel_dmc dynamically, and hide all the dmc details behind an opaque pointer in intel_dmc.c. Care must be taken to take into account all cases: DMC n

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/dmc: allocate dmc structure dynamically

2023-02-27 Thread Jani Nikula
On Fri, 17 Feb 2023, Imre Deak wrote: > On Fri, Feb 17, 2023 at 12:04:14PM +0200, Jani Nikula wrote: >> On Thu, 16 Feb 2023, Imre Deak wrote: >> > On Thu, Feb 16, 2023 at 06:17:39PM +0200, Jani Nikula wrote: >> >> sizeof(struct intel_dmc) > 1024 bytes, allocated on all platforms as >> >> part of

Re: [Intel-gfx] [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Abhinav Kumar
On 2/27/2023 4:45 AM, Dmitry Baryshkov wrote: On Mon, 27 Feb 2023 at 01:49, Abhinav Kumar wrote: On 2/26/2023 5:09 AM, Dmitry Baryshkov wrote: On 26/02/2023 02:47, Abhinav Kumar wrote: Hi Dmitry On 2/25/2023 7:23 AM, Dmitry Baryshkov wrote: On 25/02/2023 02:36, Abhinav Kumar wrote:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live URL : https://patchwork.freedesktop.org/series/114432/ State : warning == Summary == Error: dim checkpatch failed 8e94821ec3ff drm/i915: Migrate platform-dependent m

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Communicate display power demands to pcode more accurately (rev2)

2023-02-27 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode more accurately (rev2) URL : https://patchwork.freedesktop.org/series/114401/ State : success == Summary == CI Bug Log - changes from CI_DRM_12779_full -> Patchwork_114401v2_full

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live

2023-02-27 Thread Patchwork
== Series Details == Series: series starting with [v5,1/2] drm/i915: Migrate platform-dependent mock hugepage selftests to live URL : https://patchwork.freedesktop.org/series/114432/ State : success == Summary == CI Bug Log - changes from CI_DRM_12787 -> Patchwork_114432v1 ===

Re: [Intel-gfx] [PATCH v5 09/19] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:25AM -0800, Yi Liu wrote: > to indicate kernel to use the device's bound iommufd_ctx for the device > ownership check. Kernel should loop all the opened devices in the dev_set, > and check if they are bound to the same iommufd_ctx. For the devices that > has not been o

Re: [Intel-gfx] [PATCH v5 10/19] vfio: Add infrastructure for bind_iommufd from userspace

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:26AM -0800, Yi Liu wrote: > For the device fd opened from cdev, userspace needs to bind it to an > iommufd and attach it to IOAS managed by iommufd. With such operations, > userspace can set up a secure DMA context and hence access device. > > This changes the existin

Re: [Intel-gfx] [PATCH v5 17/19] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:33AM -0800, Yi Liu wrote: > This adds ioctl for userspace to attach device cdev fd to and detach > from IOAS/hw_pagetable managed by iommufd. > > VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach vfio device to IOAS, hw_pagetable > managed by

Re: [Intel-gfx] [PATCH v5 11/19] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:27AM -0800, Yi Liu wrote: > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c > b/drivers/vfio/fsl-mc/vfio_fsl_mc.c > index c89a047a4cd8..d540cf683d93 100644 > --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c > +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c > @@ -594,6 +594,7 @@ static

Re: [Intel-gfx] [PATCH v5 12/19] vfio-iommufd: Add detach_ioas for emulated VFIO devices

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:28AM -0800, Yi Liu wrote: > diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c > index bfaa9876499b..faf2516b0f06 100644 > --- a/drivers/vfio/iommufd.c > +++ b/drivers/vfio/iommufd.c > @@ -165,6 +165,12 @@ int vfio_iommufd_emulated_attach_ioas(struct vfio_dev

Re: [Intel-gfx] [PATCH v5 01/19] vfio: Allocate per device file structure

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:17AM -0800, Yi Liu wrote: > This is preparation for adding vfio device cdev support. vfio device > cdev requires: > 1) a per device file memory to store the kvm pointer set by KVM. It will >be propagated to vfio_device:kvm after the device cdev file is bound >t

Re: [Intel-gfx] [PATCH v5 02/19] vfio: Refine vfio file kAPIs for KVM

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:18AM -0800, Yi Liu wrote: > This prepares for making the below kAPIs to accept both group file > and device file instead of only vfio group file. > > bool vfio_file_enforced_coherent(struct file *file); > void vfio_file_set_kvm(struct file *file, struct kvm *kvm);

Re: [Intel-gfx] [PATCH v5 03/19] vfio: Accept vfio device file in the KVM facing kAPI

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:19AM -0800, Yi Liu wrote: > This makes the vfio file kAPIs to accepte vfio device files, also a > preparation for vfio device cdev support. > > For the kvm set with vfio device file, kvm pointer is stored in struct > vfio_device_file, and use kvm_ref_lock to protect k

Re: [Intel-gfx] [PATCH v5 04/19] kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fd

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:20AM -0800, Yi Liu wrote: > Meanwhile, rename related helpers. No functional change is intended. > > Signed-off-by: Yi Liu > Reviewed-by: Kevin Tian > Reviewed-by: Eric Auger > --- > virt/kvm/vfio.c | 115 > 1 file

Re: [Intel-gfx] [PATCH v5 05/19] kvm/vfio: Accept vfio device file from userspace

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:21AM -0800, Yi Liu wrote: > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > Signed-off-by: Yi Liu > --- > Documentation/virt/kvm/devices/vfio.rst | 52 + > i

Re: [Intel-gfx] [PATCH v5 06/19] vfio: Pass struct vfio_device_file * to vfio_device_open/close()

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:22AM -0800, Yi Liu wrote: > This avoids passing too much parameters in multiple functions. > > Signed-off-by: Yi Liu > Reviewed-by: Kevin Tian > --- > drivers/vfio/group.c | 19 +-- > drivers/vfio/vfio.h | 8 > drivers/vfio/vfio_m

Re: [Intel-gfx] [PATCH v5 07/19] vfio: Block device access via device fd until device is opened

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:23AM -0800, Yi Liu wrote: > Allow the vfio_device file to be in a state where the device FD is > opened but the device cannot be used by userspace (i.e. its .open_device() > hasn't been called). This inbetween state is not used when the device > FD is spawned from the

Re: [Intel-gfx] [PATCH v5 08/19] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset()

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:24AM -0800, Yi Liu wrote: > this suits more on what the code does. > > Signed-off-by: Yi Liu > Reviewed-by: Kevin Tian > --- > drivers/vfio/pci/vfio_pci_core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [Intel-gfx] [PATCH v5 14/19] vfio: Make vfio_device_open() single open for device cdev path

2023-02-27 Thread Jason Gunthorpe
On Mon, Feb 27, 2023 at 03:11:30AM -0800, Yi Liu wrote: > @@ -535,7 +542,8 @@ static int vfio_device_fops_release(struct inode *inode, > struct file *filep) > struct vfio_device_file *df = filep->private_data; > struct vfio_device *device = df->device; > > - vfio_device_group_clo

  1   2   >