== Series Details ==
Series: Add crtc i915_pipe debugfs file
URL : https://patchwork.freedesktop.org/series/115343/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12878 -> Patchwork_115343v1
Summary
---
**SUCCESS**
== Series Details ==
Series: Add MTL DP and HDMI Sequences
URL : https://patchwork.freedesktop.org/series/115339/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12878_full -> Patchwork_115339v1_full
Summary
---
**SUCC
== Series Details ==
Series: Add crtc i915_pipe debugfs file
URL : https://patchwork.freedesktop.org/series/115343/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:117:1: war
== Series Details ==
Series: Add crtc i915_pipe debugfs file
URL : https://patchwork.freedesktop.org/series/115343/
State : warning
== Summary ==
Error: git fetch origin failed
== Series Details ==
Series: Add crtc i915_pipe debugfs file
URL : https://patchwork.freedesktop.org/series/115343/
State : warning
== Summary ==
Error: git fetch origin failed
Hi Radhakrishna,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Radhakrishna-Sripada/drm-i915-mtl-Squashed-Phy-Support/20230318-090025
base: git://anongit.freedesktop.org/drm/drm-tip dr
== Series Details ==
Series: series starting with [v2,1/4] drm/i915: Update vblank timestamping
stuff on seamless M/N change (rev3)
URL : https://patchwork.freedesktop.org/series/114999/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12878_full -> Patchwork_114999v3_full
=
== Series Details ==
Series: drm/i915: Don't use stolen memory for ring buffers with LLC (rev5)
URL : https://patchwork.freedesktop.org/series/115334/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115334/revisions/5/mbox/ not
applied
Applying: dr
== Series Details ==
Series: Add MTL DP and HDMI Sequences
URL : https://patchwork.freedesktop.org/series/115339/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12878 -> Patchwork_115339v1
Summary
---
**SUCCESS**
N
== Series Details ==
Series: Add MTL DP and HDMI Sequences
URL : https://patchwork.freedesktop.org/series/115339/
State : warning
== Summary ==
Error: git fetch origin failed
== Series Details ==
Series: Add MTL DP and HDMI Sequences
URL : https://patchwork.freedesktop.org/series/115339/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Add MTL DP and HDMI Sequences
URL : https://patchwork.freedesktop.org/series/115339/
State : warning
== Summary ==
Error: git fetch origin failed
From: Jani Nikula
The pipe may differ from crtc index if pipes are fused off. For testing
purposes, IGT needs to know the pipe.
There's already a I915_GET_PIPE_FROM_CRTC_ID IOCTL for this. However,
the upcoming Xe driver won't have that IOCTL, and going forward, we'll
want a unified interface fo
From: Jani Nikula
Convert the crtc debugfs code to use struct intel_crtc instead of struct
drm_crtc.
V2: - Fix build failures in CI
Signed-off-by: Jani Nikula
Signed-off-by: Bhanuprakash Modem
---
drivers/gpu/drm/i915/display/intel_crtc.c | 2 +-
.../drm/i915/display/intel_display_debug
The pipe may differ from crtc index if pipes are fused off. For testing
purposes, IGT needs to know the pipe.
There's already a I915_GET_PIPE_FROM_CRTC_ID IOCTL for this. However,
the upcoming Xe driver won't have that IOCTL, and going forward, we'll
want a unified interface for testing i915 and X
On 3/17/2023 05:58, Greg KH wrote:
On Thu, Mar 16, 2023 at 01:58:35PM -0700, John Harrison wrote:
On 3/15/2023 10:57, Greg KH wrote:
On Wed, Mar 15, 2023 at 10:07:53AM -0700, John Harrison wrote:
On 3/15/2023 00:51, Greg KH wrote:
On Mon, Mar 13, 2023 at 07:22:11PM -0700, john.c.harri...@inte
== Series Details ==
Series: series starting with [v2,1/4] drm/i915: Update vblank timestamping
stuff on seamless M/N change (rev3)
URL : https://patchwork.freedesktop.org/series/114999/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12878 -> Patchwork_114999v3
===
== Series Details ==
Series: series starting with [v2,1/4] drm/i915: Update vblank timestamping
stuff on seamless M/N change (rev3)
URL : https://patchwork.freedesktop.org/series/114999/
State : warning
== Summary ==
Error: git fetch origin failed
== Series Details ==
Series: series starting with [v2,1/4] drm/i915: Update vblank timestamping
stuff on seamless M/N change (rev3)
URL : https://patchwork.freedesktop.org/series/114999/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit
== Series Details ==
Series: series starting with [v2,1/4] drm/i915: Update vblank timestamping
stuff on seamless M/N change (rev3)
URL : https://patchwork.freedesktop.org/series/114999/
State : warning
== Summary ==
Error: git fetch origin failed
Jani/Rodrigo,
Original Subject: Re: [Intel-gfx] [PATCH] Revert "drm/i915/hwmon: Enable PL1
power limit"
On Wed, 15 Feb 2023 09:19:07 -0800, Rodrigo Vivi wrote:
>
> On Wed, Feb 15, 2023 at 08:24:51AM -0800, Dixit, Ashutosh wrote:
> > On Wed, 15 Feb 2023 07:37:30 -0800, Jani Nikula wrote:
> > >
>
From: John Harrison
Direction from hardware is that stolen memory should never be used for
ring buffer allocations on platforms with LLC. There are too many
caching pitfalls due to the way stolen memory accesses are routed. So
it is safest to just not use it.
Signed-off-by: John Harrison
Fixes:
== Series Details ==
Series: Add OAM support for MTL
URL : https://patchwork.freedesktop.org/series/115330/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12878_full -> Patchwork_115330v1_full
Summary
---
**SUCCESS**
From: José Roberto de Souza
The differences between MTL and TGL DP sequences are big enough to
MTL have its own functions.
Also it is much easier to follow MTL sequences against spec with
its own functions.
One change worthy to mention is the move of
'intel_display_power_get(dev_priv, dig_port-
From: Ankit Nautiyal
MTL requires the PORT_CTL_WIDTH, TRANS_DDI_FUNC_CTL and DDI_BUF_CTL
to be filled with 4 lanes for TMDS mode.
This patch enables D2D link and fills PORT_WIDTH in appropriate
registers.
Signed-off-by: Ankit Nautiyal
Signed-off-by: Taylor, Clinton A
Signed-off-by: Radhakrishn
Communicating QGV points restriction to PUnit happens via PM Demand
instead of the Pcode mailbox in the previous platforms. GV point
restriction is handled by the PM demand code.
Signed-off-by: Radhakrishna Sripada
---
drivers/gpu/drm/i915/display/intel_bw.c | 3 +++
1 file changed, 3 insertions
This series is dependent on the Meteorlake Phy enabling series
which is being reviewed here [1].
The first patch of the series is a squashed patch of all the
patches in [1].
The second and third patches in the series add Display port
and HDMI programming sequences respectively.
The last patch in
From: John Harrison
Direction from hardware is that stolen memory should never be used for
ring buffer allocations on platforms with LLC. There are too many
caching pitfalls due to the way stolen memory accesses are routed. So
it is safest to just not use it.
Signed-off-by: John Harrison
Fixes:
From: John Harrison
Direction from hardware is that stolen memory should never be used for
ring buffer allocations on platforms with LLC. There are too many
caching pitfalls due to the way stolen memory accesses are routed. So
it is safest to just not use it.
Signed-off-by: John Harrison
Fixes:
== Series Details ==
Series: Add OAM support for MTL
URL : https://patchwork.freedesktop.org/series/115330/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12878 -> Patchwork_115330v1
Summary
---
**SUCCESS**
No regr
From: John Harrison
Direction from hardware is that stolen memory should never be used for
ring buffer allocations on platforms with LLC. There are too many
caching pitfalls due to the way stolen memory accesses are routed. So
it is safest to just not use it.
Signed-off-by: John Harrison
Fixes:
== Series Details ==
Series: Add OAM support for MTL
URL : https://patchwork.freedesktop.org/series/115330/
State : warning
== Summary ==
Error: dim checkpatch failed
93434691b915 drm/i915/perf: Drop wakeref on GuC RC error
c40cc05504d3 drm/i915/mtl: Synchronize i915/BIOS on C6 enabling
d194cc
== Series Details ==
Series: Add OAM support for MTL
URL : https://patchwork.freedesktop.org/series/115330/
State : warning
== Summary ==
Error: git fetch origin failed
== Series Details ==
Series: Add OAM support for MTL
URL : https://patchwork.freedesktop.org/series/115330/
State : warning
== Summary ==
Error: git fetch origin failed
From: John Harrison
Direction from hardware is that stolen memory should never be used for
ring buffer allocations on platforms with LLC. There are too many
caching pitfalls due to the way stolen memory accesses are routed. So
it is safest to just not use it.
Signed-off-by: John Harrison
Fixes:
On Thu, Mar 16, 2023 at 04:46:54PM -0700, Clint Taylor wrote:
> BSPEC has updated the cdclk audio keepalives AUD_TS_CDCLK_M value to 60
> for all supported platforms and refclks.
>
> BSPEC: 54034
> BSPEC: 55409
> BSPEC: 65243
> Cc: Kai Vehmanen
> Cc: Uma Shankar
> Cc: Ville Syrjälä
> Signed-off
From: Vinay Belgaumkar
If BIOS enables/disables C6, i915 should do the same. Also, retain
this value across driver reloads. This is needed only for MTL as
of now due to an existing bug in OA which needs C6 disabled for
it to function. BIOS behavior is also different across platforms
in terms of h
Some of the newer OA formats are not powers of 2. For those formats,
adjust the hw_tail accordingly when checking for new reports.
v2: (Ashutosh)
- Switch to OA_TAKEN for diff calculation
- Use OA_BUFFER_SIZE instead of the vma size
- Update comments
Signed-off-by: Umesh Nerlige Ramappa
Reviewed
One or more engines map to a specific OA unit. All reports from these
engines are captured in the OA buffer managed by this OA unit.
Current i915 OA implementation supports only the OAG unit. OAG primarily
caters to render engine, so i915 OA uses render as the default engine
in the OA implementati
Now that OA formats come in flavor of 64 bit reports, the report header
has 64 bit report-id, timestamp, context-id and gpu-ticks fields. When
filtering these reports, use the right width for these fields.
Note that upper dword of context id is reserved, so squash lower dword
only.
v2: (Ashutosh)
In some cases, perf revision may rely on specific steppings of a
platform. To determine the platform, pass i915 object to the perf
revision helper.
Signed-off-by: Umesh Nerlige Ramappa
Reviewed-by: Ashutosh Dixit
---
drivers/gpu/drm/i915/i915_getparam.c | 2 +-
drivers/gpu/drm/i915/i915_perf.c
MTL introduces additional OA units dedicated to media use cases. Add
support for programming these OA units by passing the media engine class
and instance parameters.
UMD specific changes for GPUvis support:
https://patchwork.freedesktop.org/patch/522827/?series=114023
https://patchwork.freedeskto
i915_perf_init can fail due to OOM. Fail driver init if i915_perf_init
fails.
v2: (Jani)
- Reorder patch in the series
Signed-off-by: Umesh Nerlige Ramappa
Reviewed-by: Ashutosh Dixit
---
drivers/gpu/drm/i915/i915_driver.c | 4 +++-
drivers/gpu/drm/i915/i915_perf.c | 8 ++--
drivers/gpu/
Now that we may have multiple OA units in a single GT as well as on
separate GTs, create an engine group that maps to a single OA unit.
v2: (Jani)
- Drop warning on ENOMEM
- Reorder patch in the series
v3: (Ashutosh)
- Remove unused members from perf structs
- Update comments
- Update engine_supp
From: Chris Wilson
If we fail to adjust the GuC run-control on opening the perf stream,
make sure we unwind the wakeref just taken.
v2: Retain old goto label names (Ashutosh)
Fixes: 01e742746785 ("drm/i915/guc: Support OA when Wa_16011777198 is enabled")
Signed-off-by: Chris Wilson
Reviewed-by
The OAM unit captures OA reports specific to the media engines. Add support to
program the OAM unit on media tile on MTL.
The OAM unit is selected by passing the class:instance of a media engine to perf
parameters. Corresponding UMD changes are posted to the igt-dev repo as part of
supporting the
OAM does not work with media C6 enabled on some steppings of MTL.
Disable OAM if we detect that media C6 was enabled in bios.
v2: (Ashutosh)
- Remove drm_notice from the driver load path
- Log a drm_err when opening an OAM stream on affected steppings
Signed-off-by: Umesh Nerlige Ramappa
---
dr
Once OA supports media engine class:instance, the engine can only be
validated outside the switch since class and instance parameters are
separate entities. Since OA sseu config depends on engine
class:instance, validate OA sseu config outside the switch.
v2: (Ashutosh)
- Clarify commit message
-
On Thu, 16 Mar 2023 15:06:32 -0700, john.c.harri...@intel.com wrote:
>
> From: John Harrison
>
> A failure to load the GuC is occasionally observed where the GuC log
> actually showed that the GuC had loaded just fine. The implication
> being that the load just took ever so slightly longer than th
Further reminder that the nomination period for the X.Org Board of
Director elections finishes in only 2 days, on March 19th.
Please send your nominations or self-nominations as soon as possible
following the instructions below.
Thanks again for your attention.
On Mon, 2023-03-13 at 16:27 +0100,
== Series Details ==
Series: drm/i915/uapi: Replace fake flex-array with flexible-array member
URL : https://patchwork.freedesktop.org/series/115326/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12873_full -> Patchwork_115326v1_full
===
== Series Details ==
Series: series starting with [1/3] drm/i915/psr: move PSR debugfs to intel_psr.c
URL : https://patchwork.freedesktop.org/series/115315/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12873_full -> Patchwork_115315v1_full
== Series Details ==
Series: drm/i915/display: Communicate display power demands to pcode more
accurately (rev3)
URL : https://patchwork.freedesktop.org/series/114401/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12873_full -> Patchwork_114401v3_full
On Fri, Mar 17, 2023 at 12:08 PM Faith Ekstrand wrote:
>
>
> On Wed, Mar 8, 2023 at 9:54 AM Rob Clark wrote:
>>
>> From: Rob Clark
>>
>> Add a new flag to let userspace provide a deadline as a hint for syncobj
>> and timeline waits. This gives a hint to the driver signaling the
>> backing fence
== Series Details ==
Series: drm/i915/uapi: Replace fake flex-array with flexible-array member
URL : https://patchwork.freedesktop.org/series/115326/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12873 -> Patchwork_115326v1
== Series Details ==
Series: drm/i915/uapi: Replace fake flex-array with flexible-array member
URL : https://patchwork.freedesktop.org/series/115326/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115326/revisions/1/mbox/ not
applied
Committer ide
== Series Details ==
Series: drm/i915/uapi: Replace fake flex-array with flexible-array member
URL : https://patchwork.freedesktop.org/series/115326/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115326/revisions/1/mbox/ not
applied
Committer ide
== Series Details ==
Series: drm/i915/uapi: Replace fake flex-array with flexible-array member
URL : https://patchwork.freedesktop.org/series/115326/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115326/revisions/1/mbox/ not
applied
Committer ide
On 3/16/2023 8:43 PM, Dixit, Ashutosh wrote:
On Wed, 15 Mar 2023 18:00:51 -0700, Umesh Nerlige Ramappa wrote:
From: Vinay Belgaumkar
Hi Vinay,
If BIOS enables/disables C6, i915 should do the same.
So MTL bios has a control for enabling/disabling C6? Both RC6 and MC6
individually or collec
== Series Details ==
Series: series starting with [1/3] drm/i915/psr: move PSR debugfs to intel_psr.c
URL : https://patchwork.freedesktop.org/series/115315/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12873 -> Patchwork_115315v1
==
Zero-length arrays as fake flexible arrays are deprecated and we are
moving towards adopting C99 flexible-array members instead.
Address the following warning found with GCC-13 and
-fstrict-flex-arrays=3 enabled:
drivers/gpu/drm/i915/gem/i915_gem_context.c: In function
‘set_proto_ctx_engines.isra
== Series Details ==
Series: series starting with [v2,1/4] drm/i915: Update vblank timestamping
stuff on seamless M/N change (rev2)
URL : https://patchwork.freedesktop.org/series/114999/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/114999/revisi
== Series Details ==
Series: series starting with [1/3] drm/i915/psr: move PSR debugfs to intel_psr.c
URL : https://patchwork.freedesktop.org/series/115315/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115315/revisions/1/mbox/ not
applied
Commit
== Series Details ==
Series: series starting with [1/3] drm/i915/psr: move PSR debugfs to intel_psr.c
URL : https://patchwork.freedesktop.org/series/115315/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115315/revisions/1/mbox/ not
applied
Commit
== Series Details ==
Series: series starting with [1/3] drm/i915/psr: move PSR debugfs to intel_psr.c
URL : https://patchwork.freedesktop.org/series/115315/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115315/revisions/1/mbox/ not
applied
Commit
On Wed, Mar 15, 2023 at 5:22 PM Steven Rostedt wrote:
>
> I hope that this gets in by -rc3, as I want to start basing my next branch
> on that tag.
My tree should have it now as commit c00133a9e87e ("drm/ttm: drop
extra ttm_bo_put in ttm_bo_cleanup_refs").
Linus
On Thu, Mar 16, 2023 at 01:25:45PM -0700, Radhakrishna Sripada wrote:
> From: Matt Roper
>
> Although ADL-P and DG2 both use the same general power well setup, the
> DC5/DC6 requirements are slightly different which means each platform
> should have its own "DC off" power well.
>
> DG2 (i.e., Xe
== Series Details ==
Series: series starting with [1/2] drm/i915/debugfs: switch crtc debugfs to
struct intel_crtc
URL : https://patchwork.freedesktop.org/series/115314/
State : failure
== Summary ==
Error: make failed
CALLscripts/checksyscalls.sh
DESCEND objtool
INSTALL libsubcmd_h
== Series Details ==
Series: High refresh rate PSR fixes (rev2)
URL : https://patchwork.freedesktop.org/series/115109/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/115109/revisions/2/mbox/ not
applied
Committer identity unknown
*** Please tell
The following changes since commit c761dbe804f903cc2df81f251d367cca285eca06:
Merge tag 'iwlwifi-fw-2023-03-13' of
http://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware
(2023-03-13 09:20:47 -0400)
are available in the Git repository at:
git://anongit.freedesktop.org/drm/drm-
== Series Details ==
Series: drm/i915/display: Communicate display power demands to pcode more
accurately (rev3)
URL : https://patchwork.freedesktop.org/series/114401/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12873 -> Patchwork_114401v3
==
On Fri, Mar 17, 2023 at 06:00:23PM +0200, Jani Nikula wrote:
> On Fri, 17 Mar 2023, Ville Syrjälä wrote:
> > On Fri, Mar 17, 2023 at 04:30:37PM +0200, Ville Syrjälä wrote:
> >> On Fri, Mar 17, 2023 at 03:37:09PM +0200, Jani Nikula wrote:
> >> > On Fri, 17 Mar 2023, Ville Syrjälä wrote:
> >> > > O
== Series Details ==
Series: drm/i915/display: Communicate display power demands to pcode more
accurately (rev3)
URL : https://patchwork.freedesktop.org/series/114401/
State : warning
== Summary ==
Error: dim checkpatch failed
da82682afba7 drm/i915/display: Communicate display power demands t
== Series Details ==
Series: drm/i915/display: Communicate display power demands to pcode more
accurately (rev3)
URL : https://patchwork.freedesktop.org/series/114401/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/114401/revisions/3/mbox/ not
ap
== Series Details ==
Series: drm/i915/display: Communicate display power demands to pcode more
accurately (rev3)
URL : https://patchwork.freedesktop.org/series/114401/
State : warning
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/114401/revisions/3/mbox/ not
ap
On Thu, Mar 16, 2023 at 08:43:46PM -0700, Yang, Fei wrote:
> >> From: Fei Yang
> >>
> >> On MTL, objects allocated through i915_gem_object_create_internal() are
> >> mapped as uncached in GPU by default because HAS_LLC is false. However
> >> in the live_hwsp_read selftest these watcher objects are
On Thu, Mar 16, 2023 at 11:06:08PM -0700, Dixit, Ashutosh wrote:
On Thu, 16 Mar 2023 22:14:52 -0700, Dixit, Ashutosh wrote:
On Wed, 15 Mar 2023 18:01:01 -0700, Umesh Nerlige Ramappa wrote:
>
Hi Umesh,
Mostly looks good but one nit below.
> OAM does not work with media C6 enabled on some step
On Fri, Mar 17, 2023 at 8:58 AM Greg KH wrote:
>
> On Thu, Mar 16, 2023 at 01:58:35PM -0700, John Harrison wrote:
> > On 3/15/2023 10:57, Greg KH wrote:
> > > On Wed, Mar 15, 2023 at 10:07:53AM -0700, John Harrison wrote:
> > > > On 3/15/2023 00:51, Greg KH wrote:
> > > > > On Mon, Mar 13, 2023 at
On Fri, Mar 17, 2023, Yan Zhao wrote:
> On Fri, Mar 10, 2023 at 04:22:47PM -0800, Sean Christopherson wrote:
> > From: Yan Zhao
> >
> > Add a new page-track hook, track_remove_region(), that is called when a
> > memslot DELETE operation is about to be committed. The "remove" hook
> > will be use
On Fri, 17 Mar 2023, Ville Syrjälä wrote:
> On Fri, Mar 17, 2023 at 04:30:37PM +0200, Ville Syrjälä wrote:
>> On Fri, Mar 17, 2023 at 03:37:09PM +0200, Jani Nikula wrote:
>> > On Fri, 17 Mar 2023, Ville Syrjälä wrote:
>> > > On Fri, Mar 17, 2023 at 02:53:52PM +0200, Jani Nikula wrote:
>> > >> The
On Fri, Mar 17, 2023 at 3:23 AM Jonas Ådahl wrote:
>
> On Thu, Mar 16, 2023 at 09:28:55AM -0700, Rob Clark wrote:
> > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote:
> > >
> > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote:
> > > > On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl wrot
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
url:
https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-debugfs-add-crtc-i915_pipe-debugfs-file/20230317-205512
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch
On Fri, 17 Mar 2023 00:57:23 +
"Tian, Kevin" wrote:
> > From: Alex Williamson
> > Sent: Friday, March 17, 2023 8:23 AM
> >
> > On Thu, 16 Mar 2023 23:29:21 +
> > "Tian, Kevin" wrote:
> >
> > > > From: Alex Williamson
> > > > Sent: Friday, March 17, 2023 2:46 AM
> > > >
> > > > On Wed
On Thu, Mar 16, 2023 at 11:59 PM Rob Clark wrote:
>
> On Thu, Mar 16, 2023 at 3:22 PM Sebastian Wick
> wrote:
> >
> > On Thu, Mar 16, 2023 at 5:29 PM Rob Clark wrote:
> > >
> > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote:
> > > >
> > > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Cla
On Fri, Mar 17, 2023 at 01:04:37PM +0200, Jouni Högander wrote:
> Implement Wa_1136 for SKL/BXT/ICL.
>
> Bspec: 21664
>
> Signed-off-by: Jouni Högander
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 15 +++
> drivers/gpu/drm/i915/display/skl_watermark.c | 5 -
> 2 files
On Fri, Mar 17, 2023 at 04:30:37PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 17, 2023 at 03:37:09PM +0200, Jani Nikula wrote:
> > On Fri, 17 Mar 2023, Ville Syrjälä wrote:
> > > On Fri, Mar 17, 2023 at 02:53:52PM +0200, Jani Nikula wrote:
> > >> The pipe may differ from crtc index if pipes are fus
On Fri, Mar 17, 2023 at 03:37:09PM +0200, Jani Nikula wrote:
> On Fri, 17 Mar 2023, Ville Syrjälä wrote:
> > On Fri, Mar 17, 2023 at 02:53:52PM +0200, Jani Nikula wrote:
> >> The pipe may differ from crtc index if pipes are fused off. For testing
> >> purposes, IGT needs to know the pipe.
> >>
>
Handle errors first and return early, and reduce indentation on the
happy day code path.
Cc: Jouni Högander
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_psr.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display
Prefer struct intel_connector over struct drm_connector.
Cc: Jouni Högander
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_psr.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
b/drivers/g
Move the debugfs next to the implementation.
Cc: Jouni Högander
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_debugfs.c | 288 +
drivers/gpu/drm/i915/display/intel_psr.c | 302 ++
drivers/gpu/drm/i915/display/intel_psr.h | 3 +
3
On Fri, 17 Mar 2023, Ville Syrjälä wrote:
> On Fri, Mar 17, 2023 at 02:53:52PM +0200, Jani Nikula wrote:
>> The pipe may differ from crtc index if pipes are fused off. For testing
>> purposes, IGT needs to know the pipe.
>>
>> There's already a I915_GET_PIPE_FROM_CRTC_ID IOCTL for this. However,
On Fri, Mar 17, 2023 at 02:53:52PM +0200, Jani Nikula wrote:
> The pipe may differ from crtc index if pipes are fused off. For testing
> purposes, IGT needs to know the pipe.
>
> There's already a I915_GET_PIPE_FROM_CRTC_ID IOCTL for this. However,
> the upcoming Xe driver won't have that IOCTL, a
On Fri, Mar 17, 2023 at 03:15:56PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 17, 2023 at 01:29:13PM +0100, Jonas Ådahl wrote:
> > On Fri, Mar 17, 2023 at 01:21:43PM +0100, Jonas Ådahl wrote:
> > > On Fri, Mar 17, 2023 at 01:33:25PM +0200, Ville Syrjälä wrote:
> > > > On Fri, Mar 17, 2023 at 11:34:1
On Fri, Mar 17, 2023 at 01:29:13PM +0100, Jonas Ådahl wrote:
> On Fri, Mar 17, 2023 at 01:21:43PM +0100, Jonas Ådahl wrote:
> > On Fri, Mar 17, 2023 at 01:33:25PM +0200, Ville Syrjälä wrote:
> > > On Fri, Mar 17, 2023 at 11:34:16AM +0100, Jonas Ådahl wrote:
> > > > On Mon, Mar 13, 2023 at 06:33:11P
On Fri, Mar 17, 2023 at 01:21:40PM +0100, Jonas Ådahl wrote:
> On Fri, Mar 17, 2023 at 01:33:25PM +0200, Ville Syrjälä wrote:
> > On Fri, Mar 17, 2023 at 11:34:16AM +0100, Jonas Ådahl wrote:
> > > On Mon, Mar 13, 2023 at 06:33:11PM +0200, Ville Syrjala wrote:
> > > > From: Ville Syrjälä
> > > >
>
On Thu, Mar 16, 2023 at 01:58:35PM -0700, John Harrison wrote:
> On 3/15/2023 10:57, Greg KH wrote:
> > On Wed, Mar 15, 2023 at 10:07:53AM -0700, John Harrison wrote:
> > > On 3/15/2023 00:51, Greg KH wrote:
> > > > On Mon, Mar 13, 2023 at 07:22:11PM -0700, john.c.harri...@intel.com
> > > > wrote:
On Fri, 2023-03-17 at 14:33 +0200, Ville Syrjälä wrote:
> On Fri, Mar 17, 2023 at 06:54:02AM +, Hogander, Jouni wrote:
> > On Thu, 2023-03-16 at 20:21 +0200, Ville Syrjälä wrote:
> > > On Tue, Mar 14, 2023 at 11:01:41AM +0200, Jouni Högander wrote:
> > > > PSR WM optimization should be disabled
Convert the crtc debugfs code to use struct intel_crtc instead of struct
drm_crtc.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crtc.c | 2 +-
.../drm/i915/display/intel_display_debugfs.c | 20 ++-
.../drm/i915/display/intel_display_debugfs.h | 6 +++-
The pipe may differ from crtc index if pipes are fused off. For testing
purposes, IGT needs to know the pipe.
There's already a I915_GET_PIPE_FROM_CRTC_ID IOCTL for this. However,
the upcoming Xe driver won't have that IOCTL, and going forward, we'll
want a unified interface for testing i915 and X
On Fri, Mar 17, 2023 at 06:54:02AM +, Hogander, Jouni wrote:
> On Thu, 2023-03-16 at 20:21 +0200, Ville Syrjälä wrote:
> > On Tue, Mar 14, 2023 at 11:01:41AM +0200, Jouni Högander wrote:
> > > PSR WM optimization should be disabled based on any wm level being
> > > disabled. Currently it's disa
1 - 100 of 145 matches
Mail list logo
