Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Liu, Yi L
Hi Alex, > From: Alex Williamson > Sent: Thursday, April 6, 2023 3:50 AM > > On Wed, 5 Apr 2023 16:21:09 -0300 > Jason Gunthorpe wrote: > > > On Wed, Apr 05, 2023 at 12:56:21PM -0600, Alex Williamson wrote: > > > Usability needs to be a consideration as well. An interface where the > > > resu

Re: [Intel-gfx] [PATCH 5/7] drm/i915: use pat_index instead of cache_level

2023-04-05 Thread Yang, Fei
> On Mon, Apr 03, 2023 at 07:39:37PM +, Yang, Fei wrote: >>> Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of cache_level >>> >>> On Mon, Apr 03, 2023 at 04:57:21PM +, Yang, Fei wrote: > Subject: Re: [PATCH 5/7] drm/i915: use pat_index instead of > cache_level > >

Re: [Intel-gfx] [PATCH v6 6/8] drm/i915/pxp: MTL-KCR interrupt ctrl's are in GT-0

2023-04-05 Thread Teres Alexis, Alan Previn
> alan:snip > >   void intel_pxp_irq_enable(struct intel_pxp *pxp) > >   { > > - struct intel_gt *gt = pxp->ctrl_gt; > > + struct intel_gt *gt = intel_pxp_get_irq_gt(pxp); > > in this function we use the gt for: > > 1 - the lock: see above about this > > 2 - gen11_gt_reset_one_iir(): this

Re: [Intel-gfx] [PATCH v6 7/8] drm/i915/pxp: On MTL, KCR enabling doesn't wait on tee component

2023-04-05 Thread Teres Alexis, Alan Previn
> alan:snip > > @@ -140,10 +141,15 @@ static void pxp_init_full(struct intel_pxp *pxp) > > if (ret) > > return; > > > > - if (HAS_ENGINE(pxp->ctrl_gt, GSC0)) > > + if (HAS_ENGINE(pxp->ctrl_gt, GSC0)) { > > ret = intel_pxp_gsccs_init(pxp); > > - else > > +

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 06:50:22AM -0700, Rob Clark wrote: > On Wed, Apr 5, 2023 at 6:31 AM Daniel Vetter wrote: > > > > If the crtc is being switched on or off then the semantics of > > computing the timestampe of the next vblank is somewhat ill-defined. > > And indeed, the code splats with a war

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-05 Thread Patchwork
== Series Details == Series: drm/i915/guc: Disable PL1 power limit when loading GuC firmware URL : https://patchwork.freedesktop.org/series/116172/ State : success == Summary == CI Bug Log - changes from CI_DRM_12976 -> Patchwork_116172v1 S

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Liu, Yi L
Hi Eric, > From: Eric Auger > Sent: Thursday, April 6, 2023 1:58 AM [...] > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 25432ef213ee..5a34364e3b94 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -650,11 +650,3

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-05 Thread Patchwork
== Series Details == Series: drm/i915/guc: Disable PL1 power limit when loading GuC firmware URL : https://patchwork.freedesktop.org/series/116172/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86

Re: [Intel-gfx] [PATCH] i915/guc/slpc: Provide sysfs for efficient freq

2023-04-05 Thread Dixit, Ashutosh
On Wed, 05 Apr 2023 13:12:29 -0700, Rodrigo Vivi wrote: > > On Wed, Apr 05, 2023 at 12:42:30PM -0700, Dixit, Ashutosh wrote: > > On Wed, 05 Apr 2023 06:57:42 -0700, Rodrigo Vivi wrote: > > > Hi Rodrigo, > > > > > On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote: > > > > On Fri, 31

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-05 Thread Dixit, Ashutosh
On Tue, 28 Mar 2023 02:14:42 -0700, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 27/03/2023 18:47, Rodrigo Vivi wrote: > > > > +Daniel > > > > On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote: > >> On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote: > >>> > >> > >> Hi Rodrigo, > >>

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-05 Thread Dixit, Ashutosh
On Mon, 27 Mar 2023 10:47:25 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, Sorry for the delay, I got pulled away into a couple of other things and could only now get back to this. > > +Daniel > > On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote: > > On Sun, 26 Mar 2023 04:52:59 -0700,

[Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Block waiting for GuC reset to complete

2023-04-05 Thread Ashutosh Dixit
Instead of erroring out when GuC reset is in progress, block waiting for GuC reset to complete which is a more reasonable uapi behavior. Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_hwmon.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/

[Intel-gfx] [PATCH v4 0/3] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-05 Thread Ashutosh Dixit
Split the v3 patch into 3 patches for easier review, can squash later if needed. Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Ashutosh Dixit (3): drm/i915/hwmon: Get mutex and rpm ref just once in hwm_power_max_write drm/i915/guc: Disable PL1 power limit when loading GuC firmware drm/i915/hwmon: B

[Intel-gfx] [PATCH 2/3] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-05 Thread Ashutosh Dixit
On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were seen in the GL #8062 bug below (where the PL1 power

[Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Get mutex and rpm ref just once in hwm_power_max_write

2023-04-05 Thread Ashutosh Dixit
In preparation for follow-on patches, refactor hwm_power_max_write to take hwmon_lock and runtime pm wakeref at start of the function and release them at the end, therefore acquiring these just once each. Signed-off-by: Ashutosh Dixit --- drivers/gpu/drm/i915/i915_hwmon.c | 28 +++---

Re: [Intel-gfx] [PATCH v9 4/4] drm/i915/selftests: skip comparison of power for discrete graphics

2023-04-05 Thread Dixit, Ashutosh
On Tue, 04 Apr 2023 23:59:30 -0700, Riana Tauro wrote: > Hi Riana, > Hwmon reads the energy/power consumed by discrete soc, > i.e. energy/power includes the power drawn from non-gfx discrete > components > > This test uses the power consumed by GT to validate RC6 > power consumption. > Skip compa

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Jason Gunthorpe
On Wed, Apr 05, 2023 at 01:49:45PM -0600, Alex Williamson wrote: > > > QEMU can make a policy decision today because the kernel provides a > > > sufficiently reliable interface, ie. based on the set of owned groups, a > > > hot-reset is all but guaranteed to work. > > > > And we don't change

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at BO creation

2023-04-05 Thread Yang, Fei
>Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at BO >creation > >On 04/04/2023 19:04, Yang, Fei wrote: >>> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set >>> cache at BO creation >>> >>> On 01/04/2023 09:38, fei.y...@intel.com wrote: From: Fei Yang

Re: [Intel-gfx] [PATCH] drm/i915/guc: Don't capture Gen8 regs on Gen12 devices

2023-04-05 Thread Matt Roper
On Wed, Apr 05, 2023 at 02:13:31PM -0700, John Harrison wrote: > On 4/3/2023 17:34, Matt Roper wrote: > > On Mon, Apr 03, 2023 at 02:33:34PM -0700, john.c.harri...@intel.com wrote: > > > From: John Harrison > > > > > > A pair of pre-Gen12 registers were being included in the Gen12 capture > > > l

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic-helper: Don't set deadline for modesets (rev2)

2023-04-05 Thread Patchwork
== Series Details == Series: drm/atomic-helper: Don't set deadline for modesets (rev2) URL : https://patchwork.freedesktop.org/series/116140/ State : success == Summary == CI Bug Log - changes from CI_DRM_12974 -> Patchwork_116140v2 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/atomic-helper: Don't set deadline for modesets (rev2)

2023-04-05 Thread Patchwork
== Series Details == Series: drm/atomic-helper: Don't set deadline for modesets (rev2) URL : https://patchwork.freedesktop.org/series/116140/ State : warning == Summary == Error: dim checkpatch failed 0989a3e3ca58 drm/atomic-helper: Don't set deadline for modesets -:29: WARNING:BAD_REPORTED_BY

Re: [Intel-gfx] [PATCH] drm/i915/guc: Don't capture Gen8 regs on Gen12 devices

2023-04-05 Thread John Harrison
On 4/3/2023 17:34, Matt Roper wrote: On Mon, Apr 03, 2023 at 02:33:34PM -0700, john.c.harri...@intel.com wrote: From: John Harrison A pair of pre-Gen12 registers were being included in the Gen12 capture list. GuC was rejecting those as being invalid and logging errors about them. So, stop doin

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: > On Wed, Apr 05, 2023 at 07:42:08PM +0200, Javier Martinez Canillas wrote: [...] >> >> Ah, your patch adds it after that indeed. Please ignore my comment then. >> > >> > So rb: you? >> > >> >> Yes, I already provided it in my previous email and has been picked by >> patc

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: Correct description of default value for enable_psr2_sel_fetch

2023-04-05 Thread Patchwork
== Series Details == Series: i915: Correct description of default value for enable_psr2_sel_fetch URL : https://patchwork.freedesktop.org/series/116150/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12974 -> Patchwork_116150v1 ==

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 07:42:08PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: > >> Daniel Vetter writes: > > [...] > > >> > > >> > The __fill_var is after this. I'm honestly not sure what the ex

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at BO creation

2023-04-05 Thread Jordan Justen
On 2023-04-05 00:45:24, Lionel Landwerlin wrote: > On 04/04/2023 19:04, Yang, Fei wrote: > >> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at > >> BO creation > >> > >> Just like the protected content uAPI, there is no way for userspace to tell > >> this feature is availa

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/tc: demote a kernel-doc comment to a regular comment

2023-04-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tc: demote a kernel-doc comment to a regular comment URL : https://patchwork.freedesktop.org/series/116144/ State : success == Summary == CI Bug Log - changes from CI_DRM_12974 -> Patchwork_116144v1 =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/tc: demote a kernel-doc comment to a regular comment

2023-04-05 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tc: demote a kernel-doc comment to a regular comment URL : https://patchwork.freedesktop.org/series/116144/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be check

Re: [Intel-gfx] [PATCH] i915/guc/slpc: Provide sysfs for efficient freq

2023-04-05 Thread Rodrigo Vivi
On Wed, Apr 05, 2023 at 12:42:30PM -0700, Dixit, Ashutosh wrote: > On Wed, 05 Apr 2023 06:57:42 -0700, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote: > > > On Fri, 31 Mar 2023 19:00:49 -0700, Vinay Belgaumkar wrote: > > > > > > > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 16:21:09 -0300 Jason Gunthorpe wrote: > On Wed, Apr 05, 2023 at 12:56:21PM -0600, Alex Williamson wrote: > > Usability needs to be a consideration as well. An interface where the > > result is effectively arbitrary from a user perspective because the > > kernel is solely focus

Re: [Intel-gfx] [PATCH] i915/guc/slpc: Provide sysfs for efficient freq

2023-04-05 Thread Dixit, Ashutosh
On Wed, 05 Apr 2023 06:57:42 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote: > > On Fri, 31 Mar 2023 19:00:49 -0700, Vinay Belgaumkar wrote: > > > > > > > Hi Vinay, > > > > > @@ -478,20 +507,15 @@ int intel_guc_slpc_set_min_freq(struct

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Increase AUX timeout for Type-C (rev2)

2023-04-05 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase AUX timeout for Type-C (rev2) URL : https://patchwork.freedesktop.org/series/116010/ State : success == Summary == CI Bug Log - changes from CI_DRM_12973 -> Patchwork_116010v2 Summary

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Jason Gunthorpe
On Wed, Apr 05, 2023 at 12:56:21PM -0600, Alex Williamson wrote: > Usability needs to be a consideration as well. An interface where the > result is effectively arbitrary from a user perspective because the > kernel is solely focused on whether the operation is allowed, > evaluating constraints th

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 12:56:21 -0600 Alex Williamson wrote: > On Wed, 5 Apr 2023 14:23:43 -0300 > Jason Gunthorpe wrote: > > > On Wed, Apr 05, 2023 at 10:52:15AM -0600, Alex Williamson wrote: > > > On Wed, 5 Apr 2023 13:37:05 -0300 > > > Jason Gunthorpe wrote: > > > > > > > On Wed, Apr 05,

Re: [Intel-gfx] [PULL] drm-misc-fixes

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 08:28:55PM +0200, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > here's this week's PR for drm-misc-fixes. As requested, it comes > a day earlier than usual due to Easter holidays. > > Best regards > Thomas > > drm-misc-fixes-2023-04-05: > Short summary of fixes pull:

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 14:23:43 -0300 Jason Gunthorpe wrote: > On Wed, Apr 05, 2023 at 10:52:15AM -0600, Alex Williamson wrote: > > On Wed, 5 Apr 2023 13:37:05 -0300 > > Jason Gunthorpe wrote: > > > > > On Wed, Apr 05, 2023 at 10:25:45AM -0600, Alex Williamson wrote: > > > > > > > But that kin

[Intel-gfx] ✓ Fi.CI.BAT: success for Add hwmon support for dgfx selftests

2023-04-05 Thread Patchwork
== Series Details == Series: Add hwmon support for dgfx selftests URL : https://patchwork.freedesktop.org/series/116136/ State : success == Summary == CI Bug Log - changes from CI_DRM_12973 -> Patchwork_116136v1 Summary --- **SUCCESS

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add hwmon support for dgfx selftests

2023-04-05 Thread Patchwork
== Series Details == Series: Add hwmon support for dgfx selftests URL : https://patchwork.freedesktop.org/series/116136/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/asm/bitops.h:117

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add hwmon support for dgfx selftests

2023-04-05 Thread Patchwork
== Series Details == Series: Add hwmon support for dgfx selftests URL : https://patchwork.freedesktop.org/series/116136/ State : warning == Summary == Error: dim checkpatch failed 083f9b0b94c1 drm/i915/selftests: Rename librapl library to libpower Traceback (most recent call last): File "scr

[Intel-gfx] [PULL] drm-misc-fixes

2023-04-05 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. As requested, it comes a day earlier than usual due to Easter holidays. Best regards Thomas drm-misc-fixes-2023-04-05: Short summary of fixes pull: * ivpu: DMA fence and suspend fixes * nouveau: Color-depth fixes * panfrost: Fix m

Re: [Intel-gfx] [PATCH v9 04/25] vfio: Accept vfio device file in the KVM facing kAPI

2023-04-05 Thread Eric Auger
Hi Yi, On 4/1/23 17:18, Yi Liu wrote: > This makes the vfio file kAPIs to accept vfio device files, also a > preparation for vfio device cdev support. > > For the kvm set with vfio device file, kvm pointer is stored in struct > vfio_device_file, and use kvm_ref_lock to protect kvm set and kvm > po

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Eric Auger
On 4/5/23 18:25, Alex Williamson wrote: > On Wed, 5 Apr 2023 14:04:51 + > "Liu, Yi L" wrote: > >> Hi Eric, >> >>> From: Eric Auger >>> Sent: Wednesday, April 5, 2023 8:20 PM >>> >>> Hi Yi, >>> On 4/1/23 16:44, Yi Liu wrote: for the users that accept device fds passed from management

Re: [Intel-gfx] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2023-04-05 Thread Rob Clark
On Tue, Jan 31, 2023 at 3:33 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used > to display a sorted by card and usage list of processes using GPUs. > > Borrows a bit of code from intel_gpu_top but for now omits the fa

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Patrik Jakobsson
On Wed, Apr 5, 2023 at 7:15 PM Daniel Vetter wrote: > > On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas > wrote: > > > > Daniel Vetter writes: > > > > > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > > > > [...] > > > > >> > > >/* > > >> > > > * WARNIN

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: > On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas > wrote: >> >> Daniel Vetter writes: [...] >> >> Yeah, agreed that if vga_remove_vgacon() isn't enough and another helper >> is needed then starts to get a little silly. Maybe one option is to add a >> 3rd param to

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: > On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: >> Daniel Vetter writes: [...] >> > >> > The __fill_var is after this. I'm honestly not sure what the exact >> >> Ah, your patch adds it after that indeed. Please ignore my comment then. > > So r

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Jason Gunthorpe
On Wed, Apr 05, 2023 at 10:52:15AM -0600, Alex Williamson wrote: > On Wed, 5 Apr 2023 13:37:05 -0300 > Jason Gunthorpe wrote: > > > On Wed, Apr 05, 2023 at 10:25:45AM -0600, Alex Williamson wrote: > > > > > But that kind of brings to light the question of what does the user do > > > when they en

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > [...] > > >> > >> but only the 'var->xres > fb->width || var->yres > fb->height' from the > >> conditions checked could be false after your __fill_var() call above. > >> > >> You should drop t

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas wrote: > > Daniel Vetter writes: > > > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > > [...] > > >> > > >/* > >> > > > * WARNING: Apparently we must kick fbdev drivers before > >> > > > vgacon, > >> > >

[Intel-gfx] ✓ Fi.CI.BAT: success for Add hwmon support for dgfx selftests (rev9)

2023-04-05 Thread Patchwork
== Series Details == Series: Add hwmon support for dgfx selftests (rev9) URL : https://patchwork.freedesktop.org/series/109850/ State : success == Summary == CI Bug Log - changes from CI_DRM_12972 -> Patchwork_109850v9 Summary --- **

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Add hwmon support for dgfx selftests (rev9)

2023-04-05 Thread Patchwork
== Series Details == Series: Add hwmon support for dgfx selftests (rev9) URL : https://patchwork.freedesktop.org/series/109850/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./arch/x86/include/asm/bitop

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add hwmon support for dgfx selftests (rev9)

2023-04-05 Thread Patchwork
== Series Details == Series: Add hwmon support for dgfx selftests (rev9) URL : https://patchwork.freedesktop.org/series/109850/ State : warning == Summary == Error: dim checkpatch failed 7b4acee0a7ff drm/i915/selftests: Rename librapl library to libpower Traceback (most recent call last): Fi

Re: [Intel-gfx] [PATCH v9 25/25] docs: vfio: Add vfio device cdev description

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 14:00:00 + "Liu, Yi L" wrote: > Hi Eric, > > > From: Eric Auger > > Sent: Wednesday, April 5, 2023 9:46 PM > > > > Hi Yi, > > > > On 4/1/23 17:18, Yi Liu wrote: > > > This gives notes for userspace applications on device cdev usage. > > > > > > Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: [...] >> > > >/* >> > > > * WARNING: Apparently we must kick fbdev drivers before vgacon, >> > > > * otherwise the vga fbdev driver falls over. >> > > > */ >> > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 13:37:05 -0300 Jason Gunthorpe wrote: > On Wed, Apr 05, 2023 at 10:25:45AM -0600, Alex Williamson wrote: > > > But that kind of brings to light the question of what does the user do > > when they encounter this situation. > > What does it do now when it encounters a group_i

Re: [Intel-gfx] [PATCH v3 05/12] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-04-05 Thread Jason Gunthorpe
On Wed, Apr 05, 2023 at 09:36:46AM -0600, Alex Williamson wrote: > > If we don't support singletion dev_set hot-reset, noiommu devices in cdev > > path shall fail the hot-reset if empty-fd array is provided. But we may just > > document that empty-fd array does not work for noiommu. User should >

Re: [Intel-gfx] [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'

2023-04-05 Thread Lee Jones
On Wed, 05 Apr 2023, Jani Nikula wrote: > On Wed, 05 Apr 2023, Lee Jones wrote: > > On Tue, 04 Apr 2023, Jani Nikula wrote: > > > >> On Mon, 03 Apr 2023, Lee Jones wrote: > >> > On Mon, 03 Apr 2023, Jani Nikula wrote: > >> > > >> >> On Fri, 31 Mar 2023, Lee Jones wrote: > >> >> > Fixes the foll

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Jason Gunthorpe
On Wed, Apr 05, 2023 at 10:25:45AM -0600, Alex Williamson wrote: > But that kind of brings to light the question of what does the user do > when they encounter this situation. What does it do now when it encounters a group_id it doesn't understand? Userspace already doesn't know if the foreign gr

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: [...] >> >> but only the 'var->xres > fb->width || var->yres > fb->height' from the >> conditions checked could be false after your __fill_var() call above. >> >> You should drop the 'var->bits_per_pixel > bpp', 'var->xres_virtual > >> fb->width' and 'var->yres_virtual >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 14:04:51 + "Liu, Yi L" wrote: > Hi Eric, > > > From: Eric Auger > > Sent: Wednesday, April 5, 2023 8:20 PM > > > > Hi Yi, > > On 4/1/23 16:44, Yi Liu wrote: > > > for the users that accept device fds passed from management stacks to be > > > able to figure out the host

Re: [Intel-gfx] [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'

2023-04-05 Thread Jani Nikula
On Wed, 05 Apr 2023, Lee Jones wrote: > On Tue, 04 Apr 2023, Jani Nikula wrote: > >> On Mon, 03 Apr 2023, Lee Jones wrote: >> > On Mon, 03 Apr 2023, Jani Nikula wrote: >> > >> >> On Fri, 31 Mar 2023, Lee Jones wrote: >> >> > Fixes the following W=1 kernel build warning(s): >> >> > >> >> > drive

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.23 um 15:18 schrieb Daniel Vetter: > > On Wed, Apr 05, 2023 at 01:16:27PM +0200, Javier Martinez Canillas wrote: > > > Thomas Zimmermann writes: > > > > > > [...] > > > > > > > > > > > Your comment says that i

Re: [Intel-gfx] [PATCH v3 05/12] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 08:01:49 + "Liu, Yi L" wrote: > > From: Liu, Yi L > > Sent: Wednesday, April 5, 2023 3:55 PM > > > > > > > Therefore, I think as written, the singleton dev_set hot-reset is > > > enabled for iommufd and (unintentionally?) for the group path, while > > > also negating a

Re: [Intel-gfx] [PATCH 0/4] log2: make is_power_of_2() more generic

2023-04-05 Thread Steven Price
On 31/03/2023 09:31, Jani Nikula wrote: > On Thu, 30 Mar 2023, Andrew Morton wrote: >> On Thu, 30 Mar 2023 21:53:03 + David Laight >> wrote: >> But wouldn't all these issues be addressed by simply doing #define is_power_of_2(n) (n != 0 && ((n & (n - 1)) == 0)) ?

Re: [Intel-gfx] [PATCH v3 11/12] iommufd: Define IOMMUFD_INVALID_ID in uapi

2023-04-05 Thread Liu, Yi L
> From: Alex Williamson > Sent: Wednesday, April 5, 2023 11:13 PM > > On Wed, 5 Apr 2023 09:31:39 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Wednesday, April 5, 2023 5:01 AM > > > > > > On Sat, 1 Apr 2023 07:44:28 -0700 > > > Yi Liu wrote: > > > > > > > as there are

Re: [Intel-gfx] [PATCH v3 02/12] vfio/pci: Only check ownership of opened devices in hot reset

2023-04-05 Thread Eric Auger
Hi Jason, On 4/5/23 13:41, Jason Gunthorpe wrote: > On Tue, Apr 04, 2023 at 05:59:01PM +0200, Eric Auger wrote: > >>> but the hot reset shall fail as the group is not owned by the user. >> sure it shall but I fail to understand if the reset fails or the device >> plug is somehow delayed until the

Re: [Intel-gfx] [PATCH v3 11/12] iommufd: Define IOMMUFD_INVALID_ID in uapi

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 09:31:39 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, April 5, 2023 5:01 AM > > > > On Sat, 1 Apr 2023 07:44:28 -0700 > > Yi Liu wrote: > > > > > as there are IOMMUFD users that want to know check if an ID generated > > > by IOMMUFD is valid or

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add Wa_14017856879

2023-04-05 Thread Matt Roper
On Tue, Apr 04, 2023 at 03:29:15PM -0300, Gustavo Sousa wrote: > Quoting Haridhar Kalvala (2023-04-04 14:32:20) > > Wa_14017856879 implementation for mtl. > > > > Bspec: 46046 > > > > Signed-off-by: Haridhar Kalvala > > Reviewed-by: Gustavo Sousa Applied to drm-intel-gt-next. Thanks for the

Re: [Intel-gfx] [PATCH v9 16/25] iommufd/device: Add iommufd_access_detach() API

2023-04-05 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, April 5, 2023 10:29 PM > > > > > > > > Does this need to go in via iommufd first? There seems to be quite a > > > > bit of churn in iommufd/device.c vs the vfio_mdev_ops branch (ie. it > > > > doesn't apply). Thanks, > > > > > > I think it is best to sta

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Thomas Zimmermann
Hi Am 05.04.23 um 15:18 schrieb Daniel Vetter: On Wed, Apr 05, 2023 at 01:16:27PM +0200, Javier Martinez Canillas wrote: Thomas Zimmermann writes: [...] Your comment says that it calls a PCI function to clean up to vgacon. That comment explains what is happening, not why. And how the PCI a

Re: [Intel-gfx] [PATCH v9 16/25] iommufd/device: Add iommufd_access_detach() API

2023-04-05 Thread Jason Gunthorpe
On Wed, Apr 05, 2023 at 02:10:19PM +, Liu, Yi L wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, April 5, 2023 7:56 PM > > > > On Tue, Apr 04, 2023 at 04:45:12PM -0600, Alex Williamson wrote: > > > On Sat, 1 Apr 2023 08:18:24 -0700 > > > Yi Liu wrote: > > > > > > > From: Nicolin Chen

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-04-05 Thread Andrzej Hajda
On 31.03.2023 16:16, Andrzej Hajda wrote: From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm Signed-off-by:

Re: [Intel-gfx] [PATCH 4/5] drm/i915/display: Add helper func to get intel_fbdev from drm_fb_helper

2023-04-05 Thread Andrzej Hajda
On 05.04.2023 16:13, Andrzej Hajda wrote: On 04.04.2023 16:30, Nirmoy Das wrote: Add a helper function to retrieve struct intel_fbdev from struct drm_fb_helper. Cc: Matthew Auld Cc: Andi Shyti Cc: Ville Syrjälä Cc: Jani Nikula Cc: Imre Deak Signed-off-by: Nirmoy Das Reviewed-by: Jani

Re: [Intel-gfx] [PATCH 4/5] drm/i915/display: Add helper func to get intel_fbdev from drm_fb_helper

2023-04-05 Thread Andrzej Hajda
On 04.04.2023 16:30, Nirmoy Das wrote: Add a helper function to retrieve struct intel_fbdev from struct drm_fb_helper. Cc: Matthew Auld Cc: Andi Shyti Cc: Ville Syrjälä Cc: Jani Nikula Cc: Imre Deak Signed-off-by: Nirmoy Das Reviewed-by: Jani Nikula Reviewed-by: Andi Shyti Reviewed-by

Re: [Intel-gfx] [PATCH 2/5] drm/i915/display: Set I915_BO_ALLOC_USER for fb

2023-04-05 Thread Andrzej Hajda
On 04.04.2023 16:30, Nirmoy Das wrote: Framebuffer is exposed to userspace so make sure we set proper flags for it. Set I915_BO_PREALLOC for prealloced fb so that ttm won't clear existing data. Cc: Matthew Auld Cc: Andi Shyti Cc: Andrzej Hajda Cc: Ville Syrjälä Cc: Jani Nikula Cc: Imre D

Re: [Intel-gfx] [PATCH v9 16/25] iommufd/device: Add iommufd_access_detach() API

2023-04-05 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, April 5, 2023 7:56 PM > > On Tue, Apr 04, 2023 at 04:45:12PM -0600, Alex Williamson wrote: > > On Sat, 1 Apr 2023 08:18:24 -0700 > > Yi Liu wrote: > > > > > From: Nicolin Chen > > > > > > Previously, the detach routine is only done by the destroy(). A

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Liu, Yi L
Hi Eric, > From: Eric Auger > Sent: Wednesday, April 5, 2023 8:20 PM > > Hi Yi, > On 4/1/23 16:44, Yi Liu wrote: > > for the users that accept device fds passed from management stacks to be > > able to figure out the host reset affected devices among the devices > > opened by the user. This is n

Re: [Intel-gfx] [PATCH v9 25/25] docs: vfio: Add vfio device cdev description

2023-04-05 Thread Liu, Yi L
Hi Eric, > From: Eric Auger > Sent: Wednesday, April 5, 2023 9:46 PM > > Hi Yi, > > On 4/1/23 17:18, Yi Liu wrote: > > This gives notes for userspace applications on device cdev usage. > > > > Reviewed-by: Kevin Tian > > Signed-off-by: Yi Liu > > --- > > Documentation/driver-api/vfio.rst | 1

Re: [Intel-gfx] [PATCH] i915/guc/slpc: Provide sysfs for efficient freq

2023-04-05 Thread Rodrigo Vivi
On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote: > On Fri, 31 Mar 2023 19:00:49 -0700, Vinay Belgaumkar wrote: > > > > Hi Vinay, > > > @@ -478,20 +507,15 @@ int intel_guc_slpc_set_min_freq(struct intel_guc_slpc > > *slpc, u32 val) > > val > slpc->max_freq_softlimit) > >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/ttm: Add I915_BO_PREALLOC

2023-04-05 Thread Andi Shyti
> Add a mechanism to preserve existing data when creating a TTM > object with the I915_BO_ALLOC_USER flag. This will be used in the subsequent > patch where the I915_BO_ALLOC_USER flag will be applied to the framebuffer > object. For a pre-allocated framebuffer without the I915_BO_PREALLOC flag, >

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Rob Clark
On Wed, Apr 5, 2023 at 6:31 AM Daniel Vetter wrote: > > If the crtc is being switched on or off then the semantics of > computing the timestampe of the next vblank is somewhat ill-defined. > And indeed, the code splats with a warning in the timestamp > computation code. Specifically it hits the ch

Re: [Intel-gfx] [PATCH v9 25/25] docs: vfio: Add vfio device cdev description

2023-04-05 Thread Eric Auger
Hi Yi, On 4/1/23 17:18, Yi Liu wrote: > This gives notes for userspace applications on device cdev usage. > > Reviewed-by: Kevin Tian > Signed-off-by: Yi Liu > --- > Documentation/driver-api/vfio.rst | 132 ++ > 1 file changed, 132 insertions(+) > > diff --git a/Docu

Re: [Intel-gfx] [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'

2023-04-05 Thread Lee Jones
On Tue, 04 Apr 2023, Jani Nikula wrote: > On Mon, 03 Apr 2023, Lee Jones wrote: > > On Mon, 03 Apr 2023, Jani Nikula wrote: > > > >> On Fri, 31 Mar 2023, Lee Jones wrote: > >> > Fixes the following W=1 kernel build warning(s): > >> > > >> > drivers/gpu/drm/i915/i915_scatterlist.c:62: warning: F

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Ville Syrjälä
On Wed, Apr 05, 2023 at 03:31:05PM +0200, Daniel Vetter wrote: > If the crtc is being switched on or off then the semantics of > computing the timestampe of the next vblank is somewhat ill-defined. > And indeed, the code splats with a warning in the timestamp > computation code. Specifically it hit

[Intel-gfx] ✗ Fi.CI.IGT: failure for Update DSC Bigjoiner BW check (rev3)

2023-04-05 Thread Patchwork
== Series Details == Series: Update DSC Bigjoiner BW check (rev3) URL : https://patchwork.freedesktop.org/series/115773/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12967_full -> Patchwork_115773v3_full Summary ---

[Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
If the crtc is being switched on or off then the semantics of computing the timestampe of the next vblank is somewhat ill-defined. And indeed, the code splats with a warning in the timestamp computation code. Specifically it hits the check to make sure that atomic drivers have full set up the timin

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 03:25:15PM +0300, Ville Syrjälä wrote: > On Wed, Apr 05, 2023 at 10:16:50AM +0200, Daniel Vetter wrote: > > If the crtc is being switched on or off then the semantics of > > computing the timestampe of the next vblank is somewhat ill-defined. > > And indeed, the code splats

Re: [Intel-gfx] [PATCH 1/3] drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 12:21:11PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > Drivers are supposed to fix this up if needed if they don't outright > > reject it. Uncovered by 6c11df58fd1a ("fbmem: Check virtual screen > > sizes in fb_set_var()"). > > > > Should have a F

Re: [Intel-gfx] [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 12:52:12PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > Apparently drivers need to check all this stuff themselves, which for > > most things makes sense I guess. And for everything else we luck out, > > because modern distros stopped supporting any

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 01:16:27PM +0200, Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > [...] > > > > > Your comment says that it calls a PCI function to clean up to vgacon. > > That comment explains what is happening, not why. And how the PCI and > > vgacon code work togethe

Re: [Intel-gfx] [PATCH 3/8] drm/aperture: Remove primary argument

2023-04-05 Thread Martin Blumenstingl
On Tue, Apr 4, 2023 at 10:18 PM Daniel Vetter wrote: > > Only really pci devices have a business setting this - it's for > figuring out whether the legacy vga stuff should be nuked too. And > with the preceeding two patches those are all using the pci version of I think it's spelled "preceding" [

[Intel-gfx] [PATCH] i915: Correct description of default value for enable_psr2_sel_fetch

2023-04-05 Thread Qiyu Yan
The default value of i915.enable_psr2_sel_fetch is true while the description given in i915_params.c is 0. Changing to correct the description. Signed-off-by: Qiyu Yan --- drivers/gpu/drm/i915/i915_params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] ✓ Fi.CI.IGT: success for fdinfo: Enable some support for GuC based client busyness

2023-04-05 Thread Patchwork
== Series Details == Series: fdinfo: Enable some support for GuC based client busyness URL : https://patchwork.freedesktop.org/series/116120/ State : success == Summary == CI Bug Log - changes from CI_DRM_12967_full -> Patchwork_116120v1_full ===

Re: [Intel-gfx] [PATCH RESEND v3 0/3] drm/ttm: Small fixes / cleanups in prep for shrinking

2023-04-05 Thread Thomas Hellström
On 4/5/23 14:32, Christian König wrote: Am 04.04.23 um 22:06 schrieb Thomas Hellström: I collected the, from my POW, uncontroversial patches from V1 of the TTM shrinker series, some corrected after the initial patch submission, one patch added from the Xe RFC ("drm/ttm: Don't print error messa

Re: [Intel-gfx] [PATCH 1/5] drm/i915/ttm: Add I915_BO_PREALLOC

2023-04-05 Thread Das, Nirmoy
Hi Andi, On 4/5/2023 1:53 PM, Andi Shyti wrote: Hi Nirmoy, Add a mechanism to keep existing data when creating a ttm object with I915_BO_ALLOC_USER flag. why do we need this mechanism? What was the logic behind? These are all questions people might have when checking this commit. Please be a

Re: [Intel-gfx] [PATCH RESEND v3 0/3] drm/ttm: Small fixes / cleanups in prep for shrinking

2023-04-05 Thread Christian König
Am 04.04.23 um 22:06 schrieb Thomas Hellström: I collected the, from my POW, uncontroversial patches from V1 of the TTM shrinker series, some corrected after the initial patch submission, one patch added from the Xe RFC ("drm/ttm: Don't print error message if eviction was interrupted"). It would

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Ville Syrjälä
On Wed, Apr 05, 2023 at 10:16:50AM +0200, Daniel Vetter wrote: > If the crtc is being switched on or off then the semantics of > computing the timestampe of the next vblank is somewhat ill-defined. > And indeed, the code splats with a warning in the timestamp > computation code. Specifically it hit

Re: [Intel-gfx] [PATCH v9 03/25] vfio: Remove vfio_file_is_group()

2023-04-05 Thread Eric Auger
Hi Yi, On 4/1/23 17:18, Yi Liu wrote: > since no user of vfio_file_is_group() now. > > Reviewed-by: Kevin Tian > Reviewed-by: Jason Gunthorpe > Tested-by: Terrence Xu > Tested-by: Nicolin Chen > Tested-by: Yanting Jiang > Signed-off-by: Yi Liu Reviewed-by: Eric Auger Eric > --- > drivers

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Eric Auger
Hi Yi, On 4/1/23 16:44, Yi Liu wrote: > for the users that accept device fds passed from management stacks to be > able to figure out the host reset affected devices among the devices > opened by the user. This is needed as such users do not have BDF (bus, > devfn) knowledge about the devices it

Re: [Intel-gfx] [PATCH v9 16/25] iommufd/device: Add iommufd_access_detach() API

2023-04-05 Thread Jason Gunthorpe
On Tue, Apr 04, 2023 at 04:45:12PM -0600, Alex Williamson wrote: > On Sat, 1 Apr 2023 08:18:24 -0700 > Yi Liu wrote: > > > From: Nicolin Chen > > > > Previously, the detach routine is only done by the destroy(). And it was > > called by vfio_iommufd_emulated_unbind() when the device runs close

  1   2   >