Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Liu, Yi L
> From: Alex Williamson > Sent: Saturday, April 8, 2023 5:07 AM > > On Fri, 7 Apr 2023 15:47:10 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Friday, April 7, 2023 11:14 PM > > > > > > On Fri, 7 Apr 2023 14:04:02 + > > > "Liu, Yi L" wrote: > > > > > > > > From:

Re: [Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-04-07 Thread Matt Roper
On Fri, Apr 07, 2023 at 12:32:37PM +0300, Lionel Landwerlin wrote: > By default the indirect state sampler data (border colors) are stored > in the same heap as the SAMPLER_STATE structure. For userspace drivers > that can be 2 different heaps (dynamic state heap & bindless sampler > state heap).

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Alex Williamson
On Fri, 7 Apr 2023 15:47:10 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, April 7, 2023 11:14 PM > > > > On Fri, 7 Apr 2023 14:04:02 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson > > > > Sent: Friday, April 7, 2023 9:52 PM > > > > > > > > On Fri, 7

Re: [Intel-gfx] [PATCH v8 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-04-07 Thread Dmitry Baryshkov
On 01/04/2023 01:12, Mark Yacoub wrote: From: Sean Paul Add the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Reviewed-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub

Re: [Intel-gfx] [PATCH v8 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-04-07 Thread Dmitry Baryshkov
On 01/04/2023 01:12, Mark Yacoub wrote: From: Sean Paul Add the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Reviewed-by: Douglas Anderson Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub

Re: [Intel-gfx] [PATCH v8 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-04-07 Thread Dmitry Baryshkov
On 01/04/2023 01:12, Mark Yacoub wrote: From: Sean Paul Expand upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, April 7, 2023 11:14 PM > > On Fri, 7 Apr 2023 14:04:02 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Friday, April 7, 2023 9:52 PM > > > > > > On Fri, 7 Apr 2023 13:24:25 + > > > "Liu, Yi L" wrote: > > > > > > > > From: Alex

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Alex Williamson
On Fri, 7 Apr 2023 14:04:02 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, April 7, 2023 9:52 PM > > > > On Fri, 7 Apr 2023 13:24:25 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson > > > > Sent: Friday, April 7, 2023 8:04 PM > > > > > > > > > > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: disable sampler indirect state in bindless heap (rev4)

2023-04-07 Thread Patchwork
== Series Details == Series: drm/i915: disable sampler indirect state in bindless heap (rev4) URL : https://patchwork.freedesktop.org/series/114920/ State : success == Summary == CI Bug Log - changes from CI_DRM_12982_full -> Patchwork_114920v4_full

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, April 7, 2023 9:52 PM > > On Fri, 7 Apr 2023 13:24:25 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Friday, April 7, 2023 8:04 PM > > > > > > > > > > @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev > > > > > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Alex Williamson
On Fri, 7 Apr 2023 13:24:25 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, April 7, 2023 8:04 PM > > > > > > > > @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev > > > > > > *pdev, void > > > > *data) > > > > > > if (!iommu_group) > > > > > >

Re: [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL

2023-04-07 Thread Lucas De Marchi
On Fri, Apr 07, 2023 at 05:45:52AM -0400, Rodrigo Vivi wrote: On Thu, Apr 06, 2023 at 05:37:58PM -0700, Lucas De Marchi wrote: On Fri, Mar 31, 2023 at 03:52:16PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > First release of GuC for Meteorlake. > > NB: As this is still

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, April 7, 2023 8:04 PM > > > > > > @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev > > > > > *pdev, void > > > *data) > > > > > if (!iommu_group) > > > > > return -EPERM; /* Cannot reset non-isolated devices */ [1] >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Alex Williamson
On Fri, 7 Apr 2023 10:09:58 + "Liu, Yi L" wrote: > Hi Alex, > > > From: Alex Williamson > > Sent: Monday, April 3, 2023 11:02 PM > > > > On Mon, 3 Apr 2023 09:25:06 + > > "Liu, Yi L" wrote: > > > > > > From: Liu, Yi L > > > > Sent: Saturday, April 1, 2023 10:44 PM > > > > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for Improvements to GuC error capture list processing

2023-04-07 Thread Patchwork
== Series Details == Series: Improvements to GuC error capture list processing URL : https://patchwork.freedesktop.org/series/116219/ State : success == Summary == CI Bug Log - changes from CI_DRM_12981_full -> Patchwork_116219v1_full

Re: [Intel-gfx] [PATCH 1/3] drm/i915/hwmon: Get mutex and rpm ref just once in hwm_power_max_write

2023-04-07 Thread Rodrigo Vivi
On Wed, Apr 05, 2023 at 09:45:20PM -0700, Ashutosh Dixit wrote: > In preparation for follow-on patches, refactor hwm_power_max_write to take > hwmon_lock and runtime pm wakeref at start of the function and release them > at the end, therefore acquiring these just once each. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-04-07 Thread Rodrigo Vivi
On Wed, Apr 05, 2023 at 09:45:21PM -0700, Ashutosh Dixit wrote: > On dGfx, the PL1 power limit being enabled and set to a low value results > in a low GPU operating freq. It also negates the freq raise operation which > is done before GuC firmware load. As a result GuC firmware load can time >

Re: [Intel-gfx] [PATCH 3/3] drm/i915/hwmon: Block waiting for GuC reset to complete

2023-04-07 Thread Rodrigo Vivi
On Wed, Apr 05, 2023 at 09:45:22PM -0700, Ashutosh Dixit wrote: > Instead of erroring out when GuC reset is in progress, block waiting for > GuC reset to complete which is a more reasonable uapi behavior. > > Signed-off-by: Ashutosh Dixit > --- > drivers/gpu/drm/i915/i915_hwmon.c | 13

Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-07 Thread Liu, Yi L
Hi Eric, > From: Eric Auger > Sent: Friday, April 7, 2023 4:57 PM > > Hi Yi, > > On 4/7/23 05:42, Liu, Yi L wrote: > >> From: Alex Williamson > >> Sent: Friday, April 7, 2023 2:58 AM > You don't say anything about potential restriction, ie. what if the user > calls >

Re: [Intel-gfx] [PATCH v9 10/25] vfio: Make vfio_device_open() single open for device cdev path

2023-04-07 Thread Liu, Yi L
Hi Eric, > From: Eric Auger > Sent: Friday, April 7, 2023 5:48 PM > > Hi Yi, > > On 4/1/23 17:18, Yi Liu wrote: > > VFIO group has historically allowed multi-open of the device FD. This > > was made secure because the "open" was executed via an ioctl to the > > group FD which is itself only

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Liu, Yi L
Hi Alex, > From: Alex Williamson > Sent: Monday, April 3, 2023 11:02 PM > > On Mon, 3 Apr 2023 09:25:06 + > "Liu, Yi L" wrote: > > > > From: Liu, Yi L > > > Sent: Saturday, April 1, 2023 10:44 PM > > > > > @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev *pdev, > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, April 7, 2023 1:54 AM > > On Thu, 6 Apr 2023 10:02:10 + > "Liu, Yi L" wrote: > > > > From: Jason Gunthorpe > > > Sent: Thursday, April 6, 2023 7:23 AM > > > > > > On Wed, Apr 05, 2023 at 01:49:45PM -0600, Alex Williamson wrote: > > > > > > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: disable sampler indirect state in bindless heap (rev4)

2023-04-07 Thread Patchwork
== Series Details == Series: drm/i915: disable sampler indirect state in bindless heap (rev4) URL : https://patchwork.freedesktop.org/series/114920/ State : success == Summary == CI Bug Log - changes from CI_DRM_12982 -> Patchwork_114920v4

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: disable sampler indirect state in bindless heap (rev4)

2023-04-07 Thread Patchwork
== Series Details == Series: drm/i915: disable sampler indirect state in bindless heap (rev4) URL : https://patchwork.freedesktop.org/series/114920/ State : warning == Summary == Error: dim checkpatch failed 7bd3be72199d drm/i915: disable sampler indirect state in bindless heap -:14:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: Add MTL PXP Support (rev7)

2023-04-07 Thread Patchwork
== Series Details == Series: drm/i915/pxp: Add MTL PXP Support (rev7) URL : https://patchwork.freedesktop.org/series/112647/ State : success == Summary == CI Bug Log - changes from CI_DRM_12981_full -> Patchwork_112647v7_full Summary

Re: [Intel-gfx] [PATCH v9 10/25] vfio: Make vfio_device_open() single open for device cdev path

2023-04-07 Thread Eric Auger
Hi Yi, On 4/1/23 17:18, Yi Liu wrote: > VFIO group has historically allowed multi-open of the device FD. This > was made secure because the "open" was executed via an ioctl to the > group FD which is itself only single open. > > However, no known use of multiple device FDs today. It is kind of a

Re: [Intel-gfx] [CI] drm/i915/mtl: Define GuC firmware version for MTL

2023-04-07 Thread Rodrigo Vivi
On Thu, Apr 06, 2023 at 05:37:58PM -0700, Lucas De Marchi wrote: > On Fri, Mar 31, 2023 at 03:52:16PM -0700, john.c.harri...@intel.com wrote: > > From: John Harrison > > > > First release of GuC for Meteorlake. > > > > NB: As this is still pre-release and likely to change, use explicit > >

Re: [Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-04-07 Thread Lionel Landwerlin
On 07/04/2023 12:32, Lionel Landwerlin wrote: By default the indirect state sampler data (border colors) are stored in the same heap as the SAMPLER_STATE structure. For userspace drivers that can be 2 different heaps (dynamic state heap & bindless sampler state heap). This means that border

[Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-04-07 Thread Lionel Landwerlin
By default the indirect state sampler data (border colors) are stored in the same heap as the SAMPLER_STATE structure. For userspace drivers that can be 2 different heaps (dynamic state heap & bindless sampler state heap). This means that border colors have to copied in 2 different places so that

Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-07 Thread Eric Auger
Hi Yi, On 4/7/23 05:42, Liu, Yi L wrote: >> From: Alex Williamson >> Sent: Friday, April 7, 2023 2:58 AM You don't say anything about potential restriction, ie. what if the user calls KVM_DEV_VFIO_FILE with device fds while it has been using legacy >> container/group API?

Re: [Intel-gfx] [PATCH v9 25/25] docs: vfio: Add vfio device cdev description

2023-04-07 Thread Liu, Yi L
> From: Alex Williamson > Sent: Thursday, April 6, 2023 12:58 AM > > On Wed, 5 Apr 2023 14:00:00 + > "Liu, Yi L" wrote: > > > Hi Eric, > > > > > From: Eric Auger > > > Sent: Wednesday, April 5, 2023 9:46 PM > > > > > > Hi Yi, > > > > > > On 4/1/23 17:18, Yi Liu wrote: > > > > This gives

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev2)

2023-04-07 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev2) URL : https://patchwork.freedesktop.org/series/115980/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12982 -> Patchwork_115980v2 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev2)

2023-04-07 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev2) URL : https://patchwork.freedesktop.org/series/115980/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev2)

2023-04-07 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Define MOCS and PAT tables for MTL (rev2) URL : https://patchwork.freedesktop.org/series/115980/ State : warning == Summary == Error: dim checkpatch failed 30f069e7ed60 drm/i915/mtl: Define MOCS and PAT tables for MTL -:86: WARNING:AVOID_BUG: Do not

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/dsc: fix drm_edp_dsc_sink_output_bpp() DPCD high byte usage

2023-04-07 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dsc: fix drm_edp_dsc_sink_output_bpp() DPCD high byte usage URL : https://patchwork.freedesktop.org/series/116192/ State : success == Summary == CI Bug Log - changes from CI_DRM_12981_full -> Patchwork_116192v1_full

[Intel-gfx] [PATCH 2/8] drm/i915/mtl: enforce mtl PTE encode

2023-04-07 Thread fei . yang
From: Fei Yang PTE encode functions are platform dependent. This patch ensures the correct PTE encode function is used by calling pte_encode function pointer instead of the hardcoded gen8 version of PTE encode. Signed-off-by: Fei Yang --- drivers/gpu/drm/i915/display/intel_dpt.c | 2 +-

[Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-07 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out its life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a

[Intel-gfx] [PATCH 6/8] drm/i915: use pat_index instead of cache_level

2023-04-07 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent,

[Intel-gfx] [PATCH 5/8] drm/i915: preparation for using PAT index

2023-04-07 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by

[Intel-gfx] [PATCH 4/8] drm/i915/mtl: end support for set caching ioctl

2023-04-07 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

[Intel-gfx] [PATCH 1/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-07 Thread fei . yang
From: Fei Yang On MTL, GT can no longer allocate on LLC - only the CPU can. This, along with addition of support for ADM/L4 cache calls a MOCS/PAT table update. Also defines PTE encode functions for MTL as it has different PAT index definition than previous platforms. BSpec: 44509, 45101, 44235

[Intel-gfx] [PATCH 7/8] drm/i915: making mtl pte encode generic for gen12

2023-04-07 Thread fei . yang
From: Fei Yang PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms. Cc: Chris Wilson Cc: Matt Roper Cc: Andi Shyti

[Intel-gfx] [PATCH 3/8] drm/i915/mtl: workaround coherency issue for Media

2023-04-07 Thread fei . yang
From: Fei Yang This patch implements Wa_22016122933. In MTL, memory writes initiated by Media tile update the whole cache line even for partial writes. This creates a coherency problem for cacheable memory if both CPU and GPU are writing data to different locations within a single cache line.

[Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-07 Thread fei . yang
From: Fei Yang The series includes patches needed to enable MTL. Also add new extension for GEM_CREATE uAPI to let user space set cache policy for buffer objects. Fei Yang (8): drm/i915/mtl: Define MOCS and PAT tables for MTL drm/i915/mtl: enforce mtl PTE encode drm/i915/mtl: workaround