Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEM_CREATE_EXTENSIONS query item

2023-05-02 Thread Joonas Lahtinen
Hi Jordan, This approach was specifically NACKed in the PAT index thread so please at least mark any such series as RFC if they are intended to facilitate further dialog on the topic. I've still not seen any explanation why this would be needed at this specific case for the PAT index setting

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/hdcp: Check if media_gt exists (rev2)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Check if media_gt exists (rev2) URL : https://patchwork.freedesktop.org/series/117189/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13098_full -> Patchwork_117189v2_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Check if media_gt exists (rev2)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Check if media_gt exists (rev2) URL : https://patchwork.freedesktop.org/series/117189/ State : success == Summary == CI Bug Log - changes from CI_DRM_13098 -> Patchwork_117189v2 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEM_CREATE_EXTENSIONS query item

2023-05-02 Thread kernel test robot
Hi Jordan, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Jordan-Justen/drm-i915-uapi-Add-DRM_I915_QUERY_GEM_CREATE_EXTENSIONS-query-item/20230503-050014 base:

[Intel-gfx] [PATCH] drm/i915/hdcp: Check if media_gt exists

2023-05-02 Thread Suraj Kandpal
Check if media_gt exists if we are using gsc cs --v2 -correct typo [Ankit] -assign gsc variable if gt exists [Ankit] Cc: Ankit Nautiyal Signed-off-by: Suraj Kandpal Reviewed-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_hdcp.c | 8 +--- 1 file changed, 5 insertions(+), 3

[Intel-gfx] ✓ Fi.CI.IGT: success for Improvements to uc firmare management (rev5)

2023-05-02 Thread Patchwork
== Series Details == Series: Improvements to uc firmare management (rev5) URL : https://patchwork.freedesktop.org/series/116517/ State : success == Summary == CI Bug Log - changes from CI_DRM_13098_full -> Patchwork_116517v5_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for Improvements to uc firmare management (rev5)

2023-05-02 Thread Patchwork
== Series Details == Series: Improvements to uc firmare management (rev5) URL : https://patchwork.freedesktop.org/series/116517/ State : success == Summary == CI Bug Log - changes from CI_DRM_13098 -> Patchwork_116517v5 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Improvements to uc firmare management (rev5)

2023-05-02 Thread Patchwork
== Series Details == Series: Improvements to uc firmare management (rev5) URL : https://patchwork.freedesktop.org/series/116517/ State : warning == Summary == Error: dim checkpatch failed ac121650f88b drm/i915/guc: Decode another GuC load failure case dfb69d74ee3f drm/i915/guc: Print status

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Improvements to uc firmare management (rev5)

2023-05-02 Thread Patchwork
== Series Details == Series: Improvements to uc firmare management (rev5) URL : https://patchwork.freedesktop.org/series/116517/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v3 6/6] drm/i915/uc: Make unexpected firmware versions an error in debug builds

2023-05-02 Thread John . C . Harrison
From: John Harrison If the DEBUG_GEM config option is set then escalate the 'unexpected firmware version' message from a notice to an error. This will ensure that the CI system treats such occurences as a failure and logs a bug about it (or fails the pre-merge testing). Signed-off-by: John

[Intel-gfx] [PATCH v3 2/6] drm/i915/guc: Print status register when waiting for GuC to load

2023-05-02 Thread John . C . Harrison
From: John Harrison If the GuC load is taking an excessively long time, the wait loop currently prints the GT frequency. Extend that to include the GuC status as well so we can see if the GuC is actually making progress or not. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio

[Intel-gfx] [PATCH v3 5/6] drm/i915/uc: Reject duplicate entries in firmware table

2023-05-02 Thread John . C . Harrison
From: John Harrison It was noticed that duplicate entries in the firmware table could cause an infinite loop in the firmware loading code if that entry failed to load. Duplicate entries are a bug anyway and so should never happen. Ensure they don't by tweaking the table validation code to reject

[Intel-gfx] [PATCH v3 4/6] drm/i915/uc: Enhancements to firmware table validation

2023-05-02 Thread John . C . Harrison
From: John Harrison The validation of the firmware table was being done inside the code for scanning the table for the next available firmware blob. Which is unnecessary. So pull it out into a separate function that is only called once per blob type at init time. Also, drop the CONFIG_SELFTEST

[Intel-gfx] [PATCH v3 3/6] drm/i915/uc: Track patch level versions on reduced version firmware files

2023-05-02 Thread John . C . Harrison
From: John Harrison When reduced version firmware files were added (matching major component being the only strict requirement), the minor version was still tracked and a notification reported if it was older. However, the patch version should really be tracked as well for the same reasons. The

[Intel-gfx] [PATCH v3 0/6] Improvements to uc firmare management

2023-05-02 Thread John . C . Harrison
From: John Harrison Enhance the firmware table verification code to catch more potential errors and to generally improve the code itself. Track patch level version even on reduced version files to allow user notification of missing bug fixes. Detect another immediate failure case when loading

[Intel-gfx] [PATCH v3 1/6] drm/i915/guc: Decode another GuC load failure case

2023-05-02 Thread John . C . Harrison
From: John Harrison Explain another potential firmware failure mode and early exit the long wait if hit. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 6 ++ 2

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/uapi: Add DRM_I915_QUERY_GEM_CREATE_EXTENSIONS query item

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915/uapi: Add DRM_I915_QUERY_GEM_CREATE_EXTENSIONS query item URL : https://patchwork.freedesktop.org/series/117214/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers LD [M]

[Intel-gfx] [PATCH] drm/i915/uapi: Add DRM_I915_QUERY_GEM_CREATE_EXTENSIONS query item

2023-05-02 Thread Jordan Justen
Cc: Fei Yang Cc: Tvrtko Ursulin Cc: Joonas Lahtinen Cc: Daniel Vetter Signed-off-by: Jordan Justen --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 30 ++ drivers/gpu/drm/i915/gem/i915_gem_create.h | 2 ++ drivers/gpu/drm/i915/i915_query.c | 36

Re: [Intel-gfx] [RFC PATCH] x86/mm: Fix PAT bit missing from page protection modify mask

2023-05-02 Thread Andi Shyti
Hi, a kind reminder on this patch, would be fantastic if anyone from the x86 maintainers cha give it a look. The patch has been tested thoroughly and even if it's marked as an RFC in my opinion it can be already considered for a proper review. Thanks, Andi On Mon, Apr 24, 2023 at 02:35:24PM

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add support for MTL GSC SW Proxy (rev3)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: Add support for MTL GSC SW Proxy (rev3) URL : https://patchwork.freedesktop.org/series/115806/ State : success == Summary == CI Bug Log - changes from CI_DRM_13097_full -> Patchwork_115806v3_full

Re: [Intel-gfx] [PATCH v2 11/15] drm/i915: Initialize dkl_phy spin lock from display code path

2023-05-02 Thread Rodrigo Vivi
On Tue, Apr 25, 2023 at 12:26:20PM -0700, José Roberto de Souza wrote: > drm/i915: Initialize dkl_phy spin lock from display code path double subject! but I realized that this ended up in drm-intel-next like this as well so I kept in here as well... > > Start moving the initialization of

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror URL : https://patchwork.freedesktop.org/series/117207/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13097_full -> Patchwork_117207v1_full

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-02 Thread Jason Gunthorpe
On Sat, Apr 29, 2023 at 12:13:39AM +0800, Yi Liu wrote: > > Whoa, noiommu is inherently unsafe an only meant to expose the vfio > > device interface for userspace drivers that are going to do unsafe > > things regardless. Enabling noiommu to work with mdev, pin pages, or > > anything else should

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-02 Thread Jason Gunthorpe
On Sat, Apr 29, 2023 at 12:07:24AM +0800, Yi Liu wrote: > > The emulated stuff is for mdev only, it should not be confused with > > no-iommu > > hmmm. I guess the confusion is due to the reuse of > vfio_iommufd_emulated_bind(). This is probabl y not a good direction > > Eg if you had a

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: MST+DSC nukage and state stuff (rev2)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff (rev2) URL : https://patchwork.freedesktop.org/series/117201/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13097 -> Patchwork_117201v2 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: MST+DSC nukage and state stuff (rev2)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff (rev2) URL : https://patchwork.freedesktop.org/series/117201/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: MST+DSC nukage and state stuff (rev2)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff (rev2) URL : https://patchwork.freedesktop.org/series/117201/ State : warning == Summary == Error: dim checkpatch failed 787df893c7bf drm/dp_mst: Fix fractional DSC bpp handling 48761d3260fa drm/i915/mst: Remove broken MST

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add support for MTL GSC SW Proxy (rev3)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: Add support for MTL GSC SW Proxy (rev3) URL : https://patchwork.freedesktop.org/series/115806/ State : success == Summary == CI Bug Log - changes from CI_DRM_13097 -> Patchwork_115806v3 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for MTL GSC SW Proxy (rev3)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: Add support for MTL GSC SW Proxy (rev3) URL : https://patchwork.freedesktop.org/series/115806/ State : warning == Summary == Error: dim checkpatch failed c1406c34bdf4 drm/i915/mtl: Define GSC Proxy component interface Traceback (most recent call last):

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add support for MTL GSC SW Proxy (rev3)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: Add support for MTL GSC SW Proxy (rev3) URL : https://patchwork.freedesktop.org/series/115806/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror URL : https://patchwork.freedesktop.org/series/117207/ State : success == Summary == CI Bug Log - changes from CI_DRM_13097 -> Patchwork_117207v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror URL : https://patchwork.freedesktop.org/series/117207/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v3 4/4] drm/i915/gsc: add support for GSC proxy interrupt

2023-05-02 Thread Daniele Ceraolo Spurio
The GSC notifies us of a proxy request via the HECI2 interrupt. The interrupt must be enabled both in the HECI layer and in our usual gt irq programming; for the latter, the interrupt is enabled via the same enable register as the GSC CS, but it does have its own mask register. When the interrupt

[Intel-gfx] [PATCH v3 1/4] drm/i915/mtl: Define GSC Proxy component interface

2023-05-02 Thread Daniele Ceraolo Spurio
From: Alexander Usyskin GSC Proxy component is used for communication between the Intel graphics driver and MEI driver. Cc: Alan Previn Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Acked-by: Greg Kroah-Hartman --- v2: Improve

[Intel-gfx] [PATCH v3 3/4] drm/i915/gsc: add initial support for GSC proxy

2023-05-02 Thread Daniele Ceraolo Spurio
The GSC uC needs to communicate with the CSME to perform certain operations. Since the GSC can't perform this communication directly on platforms where it is integrated in GT, i915 needs to transfer the messages from GSC to CSME and back. The proxy flow is as follow: 1 - i915 submits a request to

[Intel-gfx] [PATCH v3 2/4] mei: gsc_proxy: add gsc proxy driver

2023-05-02 Thread Daniele Ceraolo Spurio
From: Alexander Usyskin Add GSC proxy driver. It to allows messaging between GSC component on Intel graphics card and CSE device. Cc: Alan Previn Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Signed-off-by: Daniele Ceraolo Spurio Acked-by: Greg Kroah-Hartman --- v2:

[Intel-gfx] [PATCH v3 0/4] drm/i915: Add support for MTL GSC SW Proxy

2023-05-02 Thread Daniele Ceraolo Spurio
On platforms where the GSC is part of GT, it needs to communicate with CSME for some of its operations. However, there is no direct HW communication channel, so the i915 and mei drivers must carry the messages back and forth between the 2 units. The protocol is fully described in the i915 patch

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: HuC loading and authentication for MTL (rev3)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading and authentication for MTL (rev3) URL : https://patchwork.freedesktop.org/series/117080/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13097 -> Patchwork_117080v3 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: HuC loading and authentication for MTL (rev3)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading and authentication for MTL (rev3) URL : https://patchwork.freedesktop.org/series/117080/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HuC loading and authentication for MTL (rev3)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: HuC loading and authentication for MTL (rev3) URL : https://patchwork.freedesktop.org/series/117080/ State : warning == Summary == Error: dim checkpatch failed d1701037c3e3 DO NOT REVIEW: drm/i915: Add support for MTL GSC SW Proxy Traceback (most recent

Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Check if media_gt exists

2023-05-02 Thread Gustavo Sousa
Quoting Suraj Kandpal (2023-05-02 05:36:52) >Check if media_gt exits if we are using gsc cs > >Cc: Ankit Nautiyal >Signed-off-by: Suraj Kandpal Reviewed-by: Gustavo Sousa >--- > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git

[Intel-gfx] [PATCH 24/24] drm/i915: use kernel-doc -Werror when CONFIG_DRM_I915_WERROR=y

2023-05-02 Thread Jani Nikula
With CONFIG_DRM_I915_WERROR=y, we enable kernel-doc check for both objects and headers. Now that the kernel-doc warnings have been fixed, also enable kernel-doc -Werror to fail the build on kernel-doc warnings. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 4 ++-- 1 file

[Intel-gfx] [PATCH 23/24] drm/i915/scatterlist: fix kernel-doc parameter documentation

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/i915_scatterlist.h:164: warning: Function parameter or member 'release' not described in 'i915_refct_sgt_ops' drivers/gpu/drm/i915/i915_scatterlist.h:187: warning: Function parameter or member 'rsgt' not described in 'i915_refct_sgt_put'

[Intel-gfx] [PATCH 22/24] drm/i915/scatterlist: fix kernel-doc

2023-05-02 Thread Jani Nikula
Can't document function pointer members as if they are functions. drivers/gpu/drm/i915/i915_scatterlist.h:160: warning: Incorrect use of kernel-doc format: * release() - Free the memory of the struct i915_refct_sgt Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 21/24] drm/i915/pxp: fix kernel-doc for member dev_link

2023-05-02 Thread Jani Nikula
Add /** to make it a kernel-doc. drivers/gpu/drm/i915/pxp/intel_pxp_types.h:96: warning: Function parameter or member 'dev_link' not described in 'intel_pxp' Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/pxp/intel_pxp_types.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[Intel-gfx] [PATCH 20/24] drm/i915/pmu: drop kernel-doc

2023-05-02 Thread Jani Nikula
The comments are closer to not being kernel-doc. drivers/gpu/drm/i915/i915_pmu.h:21: warning: cannot understand function prototype: 'enum i915_pmu_tracked_events ' drivers/gpu/drm/i915/i915_pmu.h:32: warning: cannot understand function prototype: 'enum ' drivers/gpu/drm/i915/i915_pmu.h:41:

[Intel-gfx] [PATCH 19/24] drm/i915/active: fix kernel-doc for function parameters

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or member 'active' not described in '__i915_active_fence_init' drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or member 'fence' not described in '__i915_active_fence_init'

[Intel-gfx] [PATCH 18/24] drm/i915/guc: add intel_guc_state_capture member docs for ads_null_cache and max_mmio_per_node

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'ads_null_cache' not described in 'intel_guc_state_capture' drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:216: warning: Function parameter or member 'max_mmio_per_node' not described in

[Intel-gfx] [PATCH 17/24] drm/i915/guc: drop lots of kernel-doc markers

2023-05-02 Thread Jani Nikula
The documentation is closer to not being kernel-doc, so just drop the kernel-doc markers. drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function parameter or member 'size' not described in '__guc_capture_bufstate' drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h:27: warning: Function

[Intel-gfx] [PATCH 16/24] drm/i915/guc: add dbgfs_node member kernel-doc

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gt/uc/intel_guc.h:274: warning: Function parameter or member 'dbgfs_node' not described in 'intel_guc' Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h

[Intel-gfx] [PATCH 14/24] drm/i915/gtt: fix i915_vm_resv_put() kernel-doc parameter name

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gt/intel_gtt.h:515: warning: Function parameter or member 'vm' not described in 'i915_vm_resv_put' drivers/gpu/drm/i915/gt/intel_gtt.h:515: warning: Excess function parameter 'resv' description in 'i915_vm_resv_put' Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 15/24] drm/i915/engine: hide preempt_hang selftest member from kernel-doc

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gt/intel_engine_types.h:293: warning: Function parameter or member 'preempt_hang' not described in 'intel_engine_execlists' Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_engine_types.h | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] [PATCH 13/24] drm/i915/context: fix kernel-doc parameter descriptions

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gt/intel_context.h:108: warning: Function parameter or member 'ce' not described in 'intel_context_lock_pinned' drivers/gpu/drm/i915/gt/intel_context.h:123: warning: Function parameter or member 'ce' not described in 'intel_context_is_pinned'

[Intel-gfx] [PATCH 11/24] drm/i915/ttm: fix i915_ttm_to_gem() kernel-doc

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gem/i915_gem_ttm.h:50: warning: Function parameter or member 'bo' not described in 'i915_ttm_to_gem' Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.h

[Intel-gfx] [PATCH 12/24] drm/i915/engine: fix kernel-doc function name for intel_engine_cleanup_common()

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gt/intel_engine_cs.c:1525: warning: expecting prototype for intel_engines_cleanup_common(). Prototype was for intel_engine_cleanup_common() instead Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-02 Thread Jani Nikula
You can't document both a sub-struct type and a struct member at the same time. Separate them. drivers/gpu/drm/i915/i915_vma_resource.h:91: warning: Incorrect use of kernel-doc format: * struct i915_vma_bindinfo - Information needed for async bind

[Intel-gfx] [PATCH 09/24] drm/i915/gem: fix i915_gem_object_lookup_rcu() kernel-doc parameter name

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gem/i915_gem_object.h:94: warning: Function parameter or member 'file' not described in 'i915_gem_object_lookup_rcu' drivers/gpu/drm/i915/gem/i915_gem_object.h:94: warning: Excess function parameter 'filp' description in 'i915_gem_object_lookup_rcu' Signed-off-by: Jani

[Intel-gfx] [PATCH 10/24] drm/i915/gem: fix function pointer member kernel-doc

2023-05-02 Thread Jani Nikula
You can't document function pointer member as functions. drivers/gpu/drm/i915/gem/i915_gem_region.h:25: warning: Incorrect use of kernel-doc format: * process_obj - Process the current object drivers/gpu/drm/i915/gem/i915_gem_region.h:35: warning: Function parameter or member

[Intel-gfx] [PATCH 04/24] drm/i915/vma: document struct i915_vma_resource wakeref member

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/i915_vma_resource.h:129: warning: Function parameter or member 'wakeref' not described in 'i915_vma_resource' Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_vma_resource.h | 1 + 1 file changed, 1 insertion(+) diff --git

[Intel-gfx] [PATCH 08/24] drm/i915/request: drop kernel-doc

2023-05-02 Thread Jani Nikula
The documentation is closer to not being kernel-doc. Just drop the kernel-doc /** indicators. drivers/gpu/drm/i915/i915_request.h:176: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Request queue structure.

[Intel-gfx] [PATCH 07/24] drm/i915/error: fix i915_capture_error_state() kernel-doc

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/i915_gpu_error.c:2174: warning: Function parameter or member 'dump_flags' not described in 'i915_capture_error_state' Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 02/24] drm/i915/vma: fix kernel-doc function name for i915_vma_size()

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/i915_vma.h:145: warning: expecting prototype for i915_vma_offset(). Prototype was for i915_vma_size() instead Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_vma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.h

[Intel-gfx] [PATCH 06/24] drm/i915/perf: fix i915_perf_ioctl_version() kernel-doc

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/i915_perf.c:5307: warning: Function parameter or member 'i915' not described in 'i915_perf_ioctl_version' Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_perf.c

[Intel-gfx] [PATCH 03/24] drm/i915/utils: drop kernel-doc from __wait_for()

2023-05-02 Thread Jani Nikula
The parameters aren't documented, and the file isn't included in Sphinx build anyway, so demote the kernel-doc to a regular comment. drivers/gpu/drm/i915/i915_utils.h:284: warning: Function parameter or member 'OP' not described in '__wait_for' drivers/gpu/drm/i915/i915_utils.h:284: warning:

[Intel-gfx] [PATCH 01/24] drm/i915/gvt: fix intel_vgpu_alloc_resource() kernel-doc parameter

2023-05-02 Thread Jani Nikula
drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: Function parameter or member 'conf' not described in 'intel_vgpu_alloc_resource' drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: Excess function parameter 'param' description in 'intel_vgpu_alloc_resource' Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH 00/24] drm/i915: fix kernel-doc warnings, enable kernel-doc -Werror

2023-05-02 Thread Jani Nikula
Fix all the remaining kernel-doc warnings, and enable -Werror for kernel-doc. Jani Nikula (24): drm/i915/gvt: fix intel_vgpu_alloc_resource() kernel-doc parameter drm/i915/vma: fix kernel-doc function name for i915_vma_size() drm/i915/utils: drop kernel-doc from __wait_for() drm/i915/vma:

[Intel-gfx] [PATCH v2] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-05-02 Thread Daniele Ceraolo Spurio
The new binaries that support the 2-step authentication have contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out where this is located in the image, we need to parse the meu manifest of the GSC binary. The manifest consist of a partition header followed by

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: MST+DSC nukage and state stuff

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff URL : https://patchwork.freedesktop.org/series/117201/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13097 -> Patchwork_117201v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: MST+DSC nukage and state stuff

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff URL : https://patchwork.freedesktop.org/series/117201/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: MST+DSC nukage and state stuff

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: MST+DSC nukage and state stuff URL : https://patchwork.freedesktop.org/series/117201/ State : warning == Summary == Error: dim checkpatch failed b98a8e6872f9 drm/dp_mst: Fix fractional DSC bpp handling 81bfa5ca1aa8 drm/i915/mst: Remove broken MST DSC

[Intel-gfx] [PATCH 11/11] drm/i915: Reduce combo PHY log spam

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä We always check whether combo PHYs need to be re-initialized after disabling DC states, which leads to log spam. Switch things around so that we only log something when we actually have to re-initialized a PHY. The log spam was exacerbated by commit 41b4c7fe72b6 ("drm/i915:

[Intel-gfx] [PATCH 10/11] drm/i915: Drop some redundant eDP checks

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä There's no need to check for both eDP and fixed_mode when deciding whether to do the pfit calculations or not. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 09/11] drm/i915: Stop spamming the logs with PLL state

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä encoder->get_config() is not the place where the state should be dumped. Get rid of the spam. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c

[Intel-gfx] [PATCH 07/11] drm/i915: Split some long lines

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä Split some overly long lines. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_fdi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c index

[Intel-gfx] [PATCH 08/11] drm/i915: Introduce crtc_state->enhanced_framing

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä Track DP enhanced framing properly in the crtc state instead of relying just on the cached DPCD everywhere, and hook it up into the state check and dump. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/g4x_dp.c | 10 --

[Intel-gfx] [PATCH 06/11] drm/i915: Fix FEC state dump

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä Stop dumping state while reading it out. We have a proper place for that stuff. Signed-off-by: Ville Syrjälä --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 2 ++ drivers/gpu/drm/i915/display/intel_ddi.c| 13 +++-- 2 files changed, 5

[Intel-gfx] [PATCH 04/11] drm/i915: Fix FEC pipe A vs. DDI A mixup

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä On pre-TGL FEC is a port level feature, not a transcoder level features, and it's DDI A which doesn't have it, not trancodere A. Check for the correct thing when determining whether FEC is supported or not. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH 05/11] drm/i915: Check lane count when determining FEC support

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä ICL doesn't support FEC with a x1 DP link. Make sure we don't try to enable FEC in such cases. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git

[Intel-gfx] [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä The MST DSC code has a myriad of issues: - Platform checks are wrong (MST+DSC is TGL+ only IIRC) - Return values of .mode_valid_ctx() are wrong - .mode_valid_ctx() assumes bigjoiner might be used, but ther rest of the code doesn't agree - compressed bpp calculations don't

[Intel-gfx] [PATCH 03/11] drm/i915/mst: Read out FEC state

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä The MST codepath is missing FEC readout. Add it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index

[Intel-gfx] [PATCH 00/11] drm/i915: MST+DSC nukage and state stuff

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä The big one here is removal of the defunct i915 MST DSC code. That one clearly needs a lot more love, and the big issue there (FEC) probably can't be done in a way that can be easily backported. So IMO we just need to nuke the whole MST+DSC thing for now, or else we'll end up

[Intel-gfx] [PATCH 01/11] drm/dp_mst: Fix fractional DSC bpp handling

2023-05-02 Thread Ville Syrjala
From: Ville Syrjälä The current code does '(bpp << 4) / 16' in the MST PBN calculation, but that is just the same as 'bpp' so the DSC codepath achieves absolutely nothing. Fix it up so that the fractional part of the bpp value is actually used instead of truncated away. 64*1006 has enough zero

Re: [Intel-gfx] [PATCHv3] drm/i915/display/dp: 128/132b LT requirement

2023-05-02 Thread Jani Nikula
On Tue, 25 Apr 2023, Arun R Murthy wrote: > For 128b/132b LT prior to LT DPTX should set power state, DP channel > coding and then link rate. > > v2: added separate function to avoid code duplication(Jani N) > v3: DP2.1 section 3.5.2.16 is ordered, 3.5.1.2 is unordered and hence > discarding

Re: [Intel-gfx] 6.1.23: 0fc6fea41c71 breaks GPD Pocket 3 modeset

2023-05-02 Thread Ville Syrjälä
On Sat, Apr 29, 2023 at 09:55:45PM +0200, Kurt Garloff wrote: > Hi Ville, > > While > 0fc6fea41c71 drm/i915: Disable DC states for all commits > (cherry picked from commit 41b4c7fe72b6105a4b49395eea9aa40cef94288d) > does look correct to me, it does break modesetting on the GPD Pocket 3, > a

Re: [Intel-gfx] [PATCH v4 9/9] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-05-02 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, April 28, 2023 5:55 AM > > On Wed, 26 Apr 2023 07:54:19 -0700 > Yi Liu wrote: > > > This is the way user to invoke hot-reset for the devices opened by cdev > > interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_RESETTABLE > > in the output of

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Check if media_gt exists

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Check if media_gt exists URL : https://patchwork.freedesktop.org/series/117189/ State : success == Summary == CI Bug Log - changes from CI_DRM_13078_full -> Patchwork_117189v1_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Check if media_gt exists

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: Check if media_gt exists URL : https://patchwork.freedesktop.org/series/117189/ State : success == Summary == CI Bug Log - changes from CI_DRM_13078 -> Patchwork_117189v1 Summary ---

Re: [Intel-gfx] [PATCH v3 7/8] drm/i915/mtl: Add support for PM DEMAND

2023-05-02 Thread Jani Nikula
On Thu, 27 Apr 2023, Vinod Govindapillai wrote: > From: Mika Kahola > > Display14 introduces a new way to instruct the PUnit with > power and bandwidth requirements of DE. Add the functionality > to program the registers and handle waits using interrupts. > The current wait time for timeouts is

Re: [Intel-gfx] [PATCH v3 2/8] drm/i915: update the QGV point frequency calculations

2023-05-02 Thread Jani Nikula
On Fri, 28 Apr 2023, "Govindapillai, Vinod" wrote: > On Thu, 2023-04-27 at 18:04 +0300, Ville Syrjälä wrote: >> On Thu, Apr 27, 2023 at 06:00:10PM +0300, Vinod Govindapillai wrote: >> > > From MTL onwwards, pcode locks the QGV point based on peak BW of >> > the intended QGV point passed by the

Re: [Intel-gfx] [PATCH] drm/i915/rc6: throw out set() wrapper

2023-05-02 Thread Jani Nikula
On Fri, 21 Apr 2023, Matt Roper wrote: > On Fri, Apr 21, 2023 at 04:59:48PM +0300, Jani Nikula wrote: >> Remove useless indirection that's just misdirection for the readers. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Matt Roper Thanks for the reviews, pushed to drm-intel-gt-next. BR,

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Communicate display power demands to pcode (rev5)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev5) URL : https://patchwork.freedesktop.org/series/115371/ State : success == Summary == CI Bug Log - changes from CI_DRM_13078_full -> Patchwork_115371v5_full

[Intel-gfx] [PATCH] drm/i915/hdcp: Check if media_gt exists

2023-05-02 Thread Suraj Kandpal
Check if media_gt exits if we are using gsc cs Cc: Ankit Nautiyal Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c

Re: [Intel-gfx] [PATCH 1/2] drm/dsc: fix drm_edp_dsc_sink_output_bpp() DPCD high byte usage

2023-05-02 Thread Jani Nikula
On Thu, 20 Apr 2023, "Nautiyal, Ankit K" wrote: > LGTM. > > Reviewed-by: Ankit Nautiyal Thanks for the reviews, pushed these a week+ ago. BR, Jani. > > On 4/6/2023 7:16 PM, Jani Nikula wrote: >> The operator precedence between << and & is wrong, leading to the high >> byte being completely

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Communicate display power demands to pcode (rev5)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev5) URL : https://patchwork.freedesktop.org/series/115371/ State : success == Summary == CI Bug Log - changes from CI_DRM_13078 -> Patchwork_115371v5

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Communicate display power demands to pcode (rev5)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915/display: Communicate display power demands to pcode (rev5) URL : https://patchwork.freedesktop.org/series/115371/ State : warning == Summary == Error: dim checkpatch failed 0be68d0cac99 drm/i915/display: Communicate display power demands to pcode -:9:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Allow user to set cache at BO creation (rev4)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: Allow user to set cache at BO creation (rev4) URL : https://patchwork.freedesktop.org/series/116870/ State : success == Summary == CI Bug Log - changes from CI_DRM_13078_full -> Patchwork_116870v4_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: use pat_index instead of cache_level (rev2)

2023-05-02 Thread Patchwork
== Series Details == Series: drm/i915: use pat_index instead of cache_level (rev2) URL : https://patchwork.freedesktop.org/series/117082/ State : success == Summary == CI Bug Log - changes from CI_DRM_13078_full -> Patchwork_117082v2_full