[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: implement internal workqueues (rev3)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev3) URL : https://patchwork.freedesktop.org/series/117618/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13203 -> Patchwork_117618v3 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: implement internal workqueues (rev3)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev3) URL : https://patchwork.freedesktop.org/series/117618/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement internal workqueues (rev3)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915: implement internal workqueues (rev3) URL : https://patchwork.freedesktop.org/series/117618/ State : warning == Summary == Error: dim checkpatch failed 722468704c00 drm/i915: use pointer to i915 instead of rpm in wakeref 0b06c13ceb1d drm/i915: add a dedica

Re: [Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser

2023-05-30 Thread Zhenyu Wang
On 2023.05.31 02:04:11 +, Zhi Wang wrote: > Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx(). > commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces > gma_bottom in several functions to calculate the size of the command > buffer. However, some of them are

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use 18 fast wake AUX sync len (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915: Use 18 fast wake AUX sync len (rev2) URL : https://patchwork.freedesktop.org/series/118517/ State : success == Summary == CI Bug Log - changes from CI_DRM_13203 -> Patchwork_118517v2 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/display & drm/i915: more struct drm_edid conversions (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/display & drm/i915: more struct drm_edid conversions (rev2) URL : https://patchwork.freedesktop.org/series/116813/ State : success == Summary == CI Bug Log - changes from CI_DRM_13203 -> Patchwork_116813v2 S

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/display & drm/i915: more struct drm_edid conversions (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/display & drm/i915: more struct drm_edid conversions (rev2) URL : https://patchwork.freedesktop.org/series/116813/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Do not access i915_gem_object members from frontbuffer tracking (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: Do not access i915_gem_object members from frontbuffer tracking (rev2) URL : https://patchwork.freedesktop.org/series/118475/ State : success == Summary == CI Bug Log - changes from CI_DRM_13202 -> Patchwork_118475v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Do not access i915_gem_object members from frontbuffer tracking (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: Do not access i915_gem_object members from frontbuffer tracking (rev2) URL : https://patchwork.freedesktop.org/series/118475/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for Move dma-buf mmap() reservation locking down to exporters (rev4)

2023-05-30 Thread Patchwork
== Series Details == Series: Move dma-buf mmap() reservation locking down to exporters (rev4) URL : https://patchwork.freedesktop.org/series/116000/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13202 -> Patchwork_116000v4

[Intel-gfx] [PATCH -next] drm/i915: remove unreachable code

2023-05-30 Thread Yang Li
The code after the return will not be executed, so remove them. Eliminate the following warning: drivers/gpu/drm/i915/display/intel_color.c:1808 intel_color_prepare_commit() warn: ignoring unreachable code. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5342 Sig

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Move dma-buf mmap() reservation locking down to exporters (rev4)

2023-05-30 Thread Patchwork
== Series Details == Series: Move dma-buf mmap() reservation locking down to exporters (rev4) URL : https://patchwork.freedesktop.org/series/116000/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x8

[Intel-gfx] [PATCH RESEND] drm/i915/gvt: remove unused variable gma_bottom in command parser

2023-05-30 Thread Zhi Wang
Remove unused variable gma_bottom in scan_workload() and scan_wa_ctx(). commit be1da7070aea ("drm/i915/gvt: vGPU command scanner") introduces gma_bottom in several functions to calculate the size of the command buffer. However, some of them are set but actually unused. When compiling the code with

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use 18 fast wake fast wake AUX sync len

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915: Use 18 fast wake fast wake AUX sync len URL : https://patchwork.freedesktop.org/series/118504/ State : success == Summary == CI Bug Log - changes from CI_DRM_13202 -> Patchwork_118504v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/gvt: remove unused variable gma_bottom in command parser

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove unused variable gma_bottom in command parser URL : https://patchwork.freedesktop.org/series/118512/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/118512/revisions/1/mbox/ not applied Applying: drm

[Intel-gfx] ✓ Fi.CI.BAT: success for Change HDCP GSC message flow to use same object

2023-05-30 Thread Patchwork
== Series Details == Series: Change HDCP GSC message flow to use same object URL : https://patchwork.freedesktop.org/series/118499/ State : success == Summary == CI Bug Log - changes from CI_DRM_13202 -> Patchwork_118499v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Change HDCP GSC message flow to use same object

2023-05-30 Thread Patchwork
== Series Details == Series: Change HDCP GSC message flow to use same object URL : https://patchwork.freedesktop.org/series/118499/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bit

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Fix a use-after-free when intel_edp_init_connector fails (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915/display: Fix a use-after-free when intel_edp_init_connector fails (rev2) URL : https://patchwork.freedesktop.org/series/112091/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13202 -> Patchwork_112091v2

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915/mtl/huc: auth HuC via GSC

2023-05-30 Thread Teres Alexis, Alan Previn
On Fri, 2023-05-26 at 17:52 -0700, Ceraolo Spurio, Daniele wrote: > The full authentication via the GSC requires an heci packet submission > to the GSC FW via the GSC CS. The GSC has new PXP command for this > (literally called NEW_HUC_AUTH). > The intel_huc_auth fuction is also updated to handle b

Re: [Intel-gfx] [PATCH v3 3/7] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-05-30 Thread Ceraolo Spurio, Daniele
On 5/30/2023 5:20 PM, John Harrison wrote: On 5/30/2023 17:11, Ceraolo Spurio, Daniele wrote: On 5/30/2023 4:51 PM, John Harrison wrote: On 5/26/2023 17:52, Daniele Ceraolo Spurio wrote: In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enab

Re: [Intel-gfx] [PATCH v4] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-05-30 Thread John Harrison
On 5/30/2023 17:14, Ceraolo Spurio, Daniele wrote: On 5/30/2023 5:01 PM, John Harrison wrote: On 5/30/2023 08:29, Daniele Ceraolo Spurio wrote: Before we add the second step of the MTL HuC auth (via GSC), we need to have the ability to differentiate between them. To do so, the huc authenticatio

Re: [Intel-gfx] [PATCH v3 3/7] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-05-30 Thread John Harrison
On 5/30/2023 17:11, Ceraolo Spurio, Daniele wrote: On 5/30/2023 4:51 PM, John Harrison wrote: On 5/26/2023 17:52, Daniele Ceraolo Spurio wrote: In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enabled blob, so now we can use that to load the Hu

Re: [Intel-gfx] [PATCH v4] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-05-30 Thread Ceraolo Spurio, Daniele
On 5/30/2023 5:01 PM, John Harrison wrote: On 5/30/2023 08:29, Daniele Ceraolo Spurio wrote: Before we add the second step of the MTL HuC auth (via GSC), we need to have the ability to differentiate between them. To do so, the huc authentication check is duplicated for GuC and GSC auth, with

Re: [Intel-gfx] [PATCH v3 3/7] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-05-30 Thread Ceraolo Spurio, Daniele
On 5/30/2023 4:51 PM, John Harrison wrote: On 5/26/2023 17:52, Daniele Ceraolo Spurio wrote: In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enabled blob, so now we can use that to load the HuC via DMA if the fuse is set that way. Note that

Re: [Intel-gfx] [PATCH v3 2/7] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-05-30 Thread John Harrison
On 5/30/2023 17:06, Ceraolo Spurio, Daniele wrote: On 5/30/2023 4:30 PM, John Harrison wrote: On 5/26/2023 17:52, Daniele Ceraolo Spurio wrote: The new binaries that support the 2-step authentication contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out wher

Re: [Intel-gfx] [PATCH v3 2/7] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-05-30 Thread Ceraolo Spurio, Daniele
On 5/30/2023 4:30 PM, John Harrison wrote: On 5/26/2023 17:52, Daniele Ceraolo Spurio wrote: The new binaries that support the 2-step authentication contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out where this is located in the image, we need to parse

Re: [Intel-gfx] [PATCH v4] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-05-30 Thread John Harrison
On 5/30/2023 08:29, Daniele Ceraolo Spurio wrote: Before we add the second step of the MTL HuC auth (via GSC), we need to have the ability to differentiate between them. To do so, the huc authentication check is duplicated for GuC and GSC auth, with meu meu? binaries being considered fully aut

Re: [Intel-gfx] [PATCH v3 3/7] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-05-30 Thread John Harrison
On 5/26/2023 17:52, Daniele Ceraolo Spurio wrote: In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enabled blob, so now we can use that to load the HuC via DMA if the fuse is set that way. Note that we now need to differentiate between "GSC-enabl

Re: [Intel-gfx] [PATCH v3 2/7] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-05-30 Thread John Harrison
On 5/26/2023 17:52, Daniele Ceraolo Spurio wrote: The new binaries that support the 2-step authentication contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out where this is located in the image, we need to parse the manifest of the GSC-enabled HuC binary. The

Re: [Intel-gfx] [PATCH v3 1/7] drm/i915/uc: perma-pin firmwares

2023-05-30 Thread John Harrison
On 5/26/2023 17:52, Daniele Ceraolo Spurio wrote: Now that each FW has its own reserved area, we can keep them always pinned and skip the pin/unpin dance on reset. This will make things easier for the 2-step HuC authentication, which requires the FW to be pinned in GGTT after the xfer is complete

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915_drm.h: fix a typo (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915_drm.h: fix a typo (rev2) URL : https://patchwork.freedesktop.org/series/118479/ State : success == Summary == CI Bug Log - changes from CI_DRM_13200 -> Patchwork_118479v2 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH V2] drm/i915/gem: Use large rings for compute contexts

2023-05-30 Thread Andi Shyti
Hi Tejas, On Wed, May 17, 2023 at 07:27:54PM +0530, Tejas Upadhyay wrote: > From: Chris Wilson > > Allow compute contexts to submit the maximal amount of work without > blocking userspace. > > The original size for user LRC ring's (SZ_16K) was chosen to minimise > memory consumption, without be

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP Cleanup (rev4)

2023-05-30 Thread Patchwork
== Series Details == Series: HDCP Cleanup (rev4) URL : https://patchwork.freedesktop.org/series/117938/ State : success == Summary == CI Bug Log - changes from CI_DRM_13200 -> Patchwork_117938v4 Summary --- **SUCCESS** No regressi

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP Cleanup (rev4)

2023-05-30 Thread Patchwork
== Series Details == Series: HDCP Cleanup (rev4) URL : https://patchwork.freedesktop.org/series/117938/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP Cleanup (rev4)

2023-05-30 Thread Patchwork
== Series Details == Series: HDCP Cleanup (rev4) URL : https://patchwork.freedesktop.org/series/117938/ State : warning == Summary == Error: dim checkpatch failed 2eb29163dd05 drm/i915/hdcp: Rename dev_priv to i915 01eb36f170a2 drm/i915/hdcp: Move away from master naming to arbiter -:248: CHEC

Re: [Intel-gfx] [PATCH V2] drm/i915/gem: Use large rings for compute contexts

2023-05-30 Thread Andi Shyti
Hi Tejas, Just one note... On Wed, May 17, 2023 at 07:27:54PM +0530, Tejas Upadhyay wrote: > From: Chris Wilson > > Allow compute contexts to submit the maximal amount of work without > blocking userspace. > > The original size for user LRC ring's (SZ_16K) was chosen to minimise > memory consu

Re: [Intel-gfx] [PATCH 3/3] drm/i915/guc: Track all sent actions to GuC

2023-05-30 Thread John Harrison
On 5/26/2023 16:55, john.c.harri...@intel.com wrote: From: Michal Wajdeczko For easier debug of any unexpected error responses from GuC that might be related to non-blocking fast requests, track action code (and stack if under DEBUG_GUC config) for every H2G request. Signed-off-by: Michal Wajd

Re: [Intel-gfx] [PATCH V2] drm/i915/gt: Add workaround 14016712196

2023-05-30 Thread Andi Shyti
Hi Tejas, On Wed, May 17, 2023 at 06:52:30PM +0530, Tejas Upadhyay wrote: > Wa_14016712196 implementation for mtl > > Bspec: 72197 > > V2: > - Fix kernel test robot warnings > > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202305121525.3ewdgoby-...@intel

Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: Update log for unsolicited CTB response

2023-05-30 Thread John Harrison
On 5/26/2023 16:55, john.c.harri...@intel.com wrote: From: Michal Wajdeczko Instead of printing message fence twice, include HXG header of the unexpected message and its len. Signed-off-by: Michal Wajdeczko Signed-off-by: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 1/3] drm/i915/guc: Use FAST_REQUEST for non-blocking H2G calls

2023-05-30 Thread John Harrison
On 5/26/2023 16:55, john.c.harri...@intel.com wrote: From: Michal Wajdeczko In addition to the already defined REQUEST HXG message format, which is used when sender expects some confirmation or data, HXG protocol includes definition of the FAST REQUEST message, that may be used when sender does

Re: [Intel-gfx] [PATCH V2] drm/i915/gem: Use large rings for compute contexts

2023-05-30 Thread Andi Shyti
Hi Tejas, On Wed, May 17, 2023 at 07:27:54PM +0530, Tejas Upadhyay wrote: > From: Chris Wilson > > Allow compute contexts to submit the maximal amount of work without > blocking userspace. > > The original size for user LRC ring's (SZ_16K) was chosen to minimise > memory consumption, without be

Re: [Intel-gfx] [PATCH] drm/i915/pxp: Fix size_t format specifier in gsccs_send_message()

2023-05-30 Thread Andi Shyti
Hi Nathan, On Tue, May 30, 2023 at 11:37:56AM -0700, Nathan Chancellor wrote: > When building ARCH=i386 allmodconfig, the following warning occurs: > > In file included from include/linux/device.h:15, >from include/linux/node.h:18, >from include/linux/cpu

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Fix parameter in gmch_ggtt_insert_{entries, page}()

2023-05-30 Thread Yang, Fei
> Subject: [PATCH 2/2] drm/i915/gt: Fix parameter in > gmch_ggtt_insert_{entries,page}() > > When building with clang's -Wincompatible-function-pointer-types-strict, > the following warnings occur: > > drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c:102:23: error: incompatible > function pointer type

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Fix second parameter type of pre-gen8 pte_encode callbacks

2023-05-30 Thread Yang, Fei
> Subject: [PATCH 1/2] drm/i915/gt: Fix second parameter type of pre-gen8 > pte_encode callbacks > > When booting a kernel compiled with CONFIG_CFI_CLANG (kCFI), there is a CFI > failure in ggtt_probe_common() when trying to call hsw_pte_encode() via an > indirect call: > > [5.030027] CFI

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Fix parameter in gmch_ggtt_insert_{entries, page}()

2023-05-30 Thread Andi Shyti
Hi Nathan, On Tue, May 30, 2023 at 11:24:39AM -0700, Nathan Chancellor wrote: > When building with clang's -Wincompatible-function-pointer-types-strict, > the following warnings occur: > > drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c:102:23: error: incompatible > function pointer types assigning

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Fix second parameter type of pre-gen8 pte_encode callbacks

2023-05-30 Thread Andi Shyti
Hi Nathan, On Tue, May 30, 2023 at 11:24:38AM -0700, Nathan Chancellor wrote: > When booting a kernel compiled with CONFIG_CFI_CLANG (kCFI), there is a > CFI failure in ggtt_probe_common() when trying to call hsw_pte_encode() > via an indirect call: > > [5.030027] CFI failure at ggtt_probe_

[Intel-gfx] [PATCH 0/5] s/ADL/ALDERLAKE

2023-05-30 Thread Anusha Srivatsa
Replace all occurences of ADL -> ALDERLAKE in platform and subplatform defines. This way there is a consistent pattern to how platforms are referred. While the change is minor and could be combined to have lesser patches, splitting to per subpaltform for easier cherrypicks, if needed. Anusha Sriva

[Intel-gfx] [PATCH 4/5] drm/i915/adln: s/ADLP/ALDERLAKE_P in ADLN defines

2023-05-30 Thread Anusha Srivatsa
Follow consistent naming convention. Replace ADLP with ALDERLAKE_P Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c| 2 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 5/5] drm/i915/adls: s/ADLS/ALDERLAKE_S in platform and subplatform defines

2023-05-30 Thread Anusha Srivatsa
Driver refers to the platfrom Alderlake S as ADLS in places and ALDERLAKE_S in some. Making the consistent change to avoid confusion of the right naming convention for the platform. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/gt/uc/intel_uc.c| 2 +- drivers/gpu/drm/i915/i915_drv.

[Intel-gfx] [PATCH 2/5] drm/i915/rplp: s/ADLP/ALDERLAKE_P for RPLP defines

2023-05-30 Thread Anusha Srivatsa
Follow consistent naming convention. Replace ADLP with ALDERLAKE_P. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_step.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/

[Intel-gfx] [PATCH 1/5] drm/i915/adlp: s/ADLP/ALDERLAKE_P for display and graphics step

2023-05-30 Thread Anusha Srivatsa
Driver refers to the platfrom Alderlake P as ADLP in places and ALDERLAKE_P in some. Making the consistent change to avoid confusion of the right naming convention for the platform. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] drm/i915/rplu: s/ADLP/ALDERLAKE_P in RPLU defines

2023-05-30 Thread Anusha Srivatsa
Follow consistent naming convention. Replace ADLP with ALDERLAKE_P Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/i915_drv.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/

[Intel-gfx] [PATCH] drm/i915/pxp: Fix size_t format specifier in gsccs_send_message()

2023-05-30 Thread Nathan Chancellor
drm_warn(&i915->drm, "caller with insufficient PXP reply size %u (%ld)\n", + drm_warn(&i915->drm, "caller with insufficient PXP reply size %u (%zu)\n", reply_size, msg_out_size_max); reply_size = msg_out_size_max; } --- base-commit: 08264f85c5c05ecc38d409c84d48cfb00ccd3bc4 change-id: 20230530-i915-pxp-size_t-wformat-1d73ed1f8d23 Best regards, -- Nathan Chancellor

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Fix second parameter type of pre-gen8 pte_encode callbacks

2023-05-30 Thread Nathan Chancellor
When booting a kernel compiled with CONFIG_CFI_CLANG (kCFI), there is a CFI failure in ggtt_probe_common() when trying to call hsw_pte_encode() via an indirect call: [5.030027] CFI failure at ggtt_probe_common+0xd1/0x130 [i915] (target: hsw_pte_encode+0x0/0x30 [i915]; expected type: 0xf5c1d

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Fix parameter in gmch_ggtt_insert_{entries, page}()

2023-05-30 Thread Nathan Chancellor
When building with clang's -Wincompatible-function-pointer-types-strict, the following warnings occur: drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c:102:23: error: incompatible function pointer types assigning to 'void (*)(struct i915_address_space *, dma_addr_t, u64, unsigned int, u32)' (aka 'voi

[Intel-gfx] [PATCH 0/2] drm/i915/gt: Fix recent kCFI violations

2023-05-30 Thread Nathan Chancellor
change-id: 20230530-i915-gt-cache_level-wincompatible-function-pointer-types-strict-32a5c65249a5 Best regards, -- Nathan Chancellor

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove i915_drm_suspend_mode (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915: Remove i915_drm_suspend_mode (rev2) URL : https://patchwork.freedesktop.org/series/112607/ State : success == Summary == CI Bug Log - changes from CI_DRM_13200_full -> Patchwork_112607v2_full Summary -

[Intel-gfx] [PATCH v2] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-05-30 Thread Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 driver init is done. That said, all subsytems th

Re: [Intel-gfx] [PATCH v4 13/13] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-30 Thread Sam Ravnborg
Hi Thomas, > > > - if (helper->funcs->fb_dirty) { > > > - drm_fb_helper_memory_range_to_clip(info, pos, ret, > > > &damage_area); > > > - drm_fb_helper_damage(helper, damage_area.x1, damage_area.y1, > > > - drm_rect_width(&damage_area), > > > -

[Intel-gfx] [PATCH v4] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-05-30 Thread Daniele Ceraolo Spurio
Before we add the second step of the MTL HuC auth (via GSC), we need to have the ability to differentiate between them. To do so, the huc authentication check is duplicated for GuC and GSC auth, with meu binaries being considered fully authenticated only after the GSC auth step. To report the diff

[Intel-gfx] [PATCH v5 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the callbacks. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. v4: * generate deferred-I/O helpers

[Intel-gfx] [PATCH v5 04/13] drm/exynos: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[Intel-gfx] [PATCH v5 05/13] drm/gma500: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Gma500 does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[Intel-gfx] [PATCH v5 13/13] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the fbdev callbacks. i915 was the only caller of the DRM helpers, so remove them from the helper module. i915's fbdev emulation is still incomplete as it do

[Intel-gfx] [PATCH v5 03/13] drm/armada: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[Intel-gfx] [PATCH v5 07/13] drm/fbdev-dma: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Fbdev-dma does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions enti

[Intel-gfx] [PATCH v5 11/13] drm/msm: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely.

[Intel-gfx] [PATCH v5 10/13] drm/fb-helper: Export helpers for marking damage areas

2023-05-30 Thread Thomas Zimmermann
Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which handle damage areas for fbdev emulation. This is a temporary export that allows to move the DRM I/O helpers for fbdev into drivers. Only fbdev-generic and i915 need them. Both will be updated to implement damage handling by thems

[Intel-gfx] [PATCH v5 09/13] drm/tegra: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Tegra does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely

[Intel-gfx] [PATCH v5 02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-30 Thread Thomas Zimmermann
For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback functions with damage handling. Add initializer macros that set struct fb_ops to the generated callbacks. These macros can remove

[Intel-gfx] [PATCH v5 06/13] drm/radeon: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Radeon does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[Intel-gfx] [PATCH v5 08/13] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entire

[Intel-gfx] [PATCH v5 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-30 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does no

[Intel-gfx] [PATCH v5 01/13] fbdev: Add Kconfig options to select different fb_ops helpers

2023-05-30 Thread Thomas Zimmermann
Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig options to select them at once. This will help with making DRM's fbdev emulation code more modular, but can also be used to simplify fbdev's driver configs. v3: * fix select statement (Jingfeng) Signed-off-by: Thomas Zimme

[Intel-gfx] [PATCH v5 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the callbacks. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. v4: * generate deferred-I/O helpers

[Intel-gfx] [PATCH v5 13/13] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the fbdev callbacks. i915 was the only caller of the DRM helpers, so remove them from the helper module. i915's fbdev emulation is still incomplete as it do

[Intel-gfx] [PATCH v5 05/13] drm/gma500: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Gma500 does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[Intel-gfx] [PATCH v5 10/13] drm/fb-helper: Export helpers for marking damage areas

2023-05-30 Thread Thomas Zimmermann
Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which handle damage areas for fbdev emulation. This is a temporary export that allows to move the DRM I/O helpers for fbdev into drivers. Only fbdev-generic and i915 need them. Both will be updated to implement damage handling by thems

[Intel-gfx] [PATCH v5 06/13] drm/radeon: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Radeon does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[Intel-gfx] [PATCH v5 02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-30 Thread Thomas Zimmermann
For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback functions with damage handling. Add initializer macros that set struct fb_ops to the generated callbacks. These macros can remove

[Intel-gfx] [PATCH v5 04/13] drm/exynos: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[Intel-gfx] [PATCH v5 09/13] drm/tegra: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Tegra does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely

[Intel-gfx] [PATCH v5 07/13] drm/fbdev-dma: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Fbdev-dma does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions enti

[Intel-gfx] [PATCH v5 03/13] drm/armada: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[Intel-gfx] [PATCH v5 01/13] fbdev: Add Kconfig options to select different fb_ops helpers

2023-05-30 Thread Thomas Zimmermann
Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig options to select them at once. This will help with making DRM's fbdev emulation code more modular, but can also be used to simplify fbdev's driver configs. v3: * fix select statement (Jingfeng) Signed-off-by: Thomas Zimme

[Intel-gfx] [PATCH v5 08/13] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entire

[Intel-gfx] [PATCH v5 11/13] drm/msm: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely.

[Intel-gfx] [PATCH v5 00/13]

2023-05-30 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does no

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Reset only one lane in case of MFD

2023-05-30 Thread Kahola, Mika
> -Original Message- > From: Luca Coelho > Sent: Tuesday, May 30, 2023 1:08 PM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Reset only one lane in case of > MFD > > On Tue, 2023-05-30 at 09:30 +, Kahola, Mika wrote: > > > -

[Intel-gfx] [PATCH v3 3/3] drm/i915/selftests: add local workqueue for SW fence selftest

2023-05-30 Thread Luca Coelho
Instead of using a global workqueue for the SW fence selftest, allocate a separate one temporarily only while running the test. Cc: Tetsuo Handa Cc: Jani Nikula Cc: Ville Syrjälä Reviewed-by: Tvrtko Ursulin Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/selftests/i915_sw_fence.c | 16 ++

[Intel-gfx] [PATCH v3 2/3] drm/i915: add a dedicated workqueue inside drm_i915_private

2023-05-30 Thread Luca Coelho
In order to avoid flush_scheduled_work() usage, add a dedicated workqueue in the drm_i915_private structure. In this way, we don't need to use the system queue anymore. This change is mostly mechanical and based on Tetsuo's original patch[1]. Link: https://patchwork.freedesktop.org/series/114608

[Intel-gfx] [PATCH v3 1/3] drm/i915: use pointer to i915 instead of rpm in wakeref

2023-05-30 Thread Luca Coelho
Currently a pointer to an intel_runtime_pm structure is stored in the wake reference structures so the runtime data can be accessed. We can save the entire device information (drm_i915_private) instead, since we'll need to reference the new workqueue we'll add in subsequent patches. Reviewed-by:

[Intel-gfx] [PATCH v3 0/3] drm/i915: implement internal workqueues

2023-05-30 Thread Luca Coelho
Hi, This series implements internal workqueues in the i915 driver in order to avoid using the system queue. We add one generic workqueue in the drm_i915_private structure, one specific for wake references and one in a self-test. This is based on Tetsuo's work[1] and is required to get rid of the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove i915_drm_suspend_mode (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915: Remove i915_drm_suspend_mode (rev2) URL : https://patchwork.freedesktop.org/series/112607/ State : success == Summary == CI Bug Log - changes from CI_DRM_13200 -> Patchwork_112607v2 Summary ---

[Intel-gfx] [PATCH v3] drm/i915: Use 18 fast wake AUX sync len

2023-05-30 Thread Jouni Högander
HW default for wake sync pulses is 18. 10 precarge and 8 preamble. There is no reason to change this especially as it is causing problems with certain eDP panels. v3: Change "Fixes:" commit v2: Remove "fast wake" repeat from subject Signed-off-by: Jouni Högander Fixes: e1c71f8f9180 ("drm/i915: F

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Reset only one lane in case of MFD

2023-05-30 Thread Luca Coelho
On Tue, 2023-05-30 at 09:30 +, Kahola, Mika wrote: > > -Original Message- > > From: Luca Coelho > > Sent: Tuesday, May 30, 2023 11:38 AM > > To: Kahola, Mika ; intel- > > g...@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Reset only one lane > > in case of MF

Re: [Intel-gfx] [PATCH] drm/i915: Use 18 fast wake fast wake AUX sync len

2023-05-30 Thread Hogander, Jouni
On Tue, 2023-05-30 at 12:14 +0300, Jani Nikula wrote: > On Mon, 29 May 2023, Jouni Högander wrote: > > HW default for wake sync pulses is 18. 10 precarge and 8 preamble. > > There is > > no reason to change this especially as it is causing problems with > > certain > > eDP panels. > > > > Signed-

Re: [Intel-gfx] [PATCH] drm/i915: Use 18 fast wake fast wake AUX sync len

2023-05-30 Thread Hogander, Jouni
On Tue, 2023-05-30 at 09:06 +, Murthy, Arun R wrote: > > -Original Message- > > From: Intel-gfx On Behalf > > Of Jouni > > Högander > > Sent: Monday, May 29, 2023 6:30 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH] drm/i915: Use 18 fast wake fast wake > > A

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove i915_drm_suspend_mode (rev2)

2023-05-30 Thread Patchwork
== Series Details == Series: drm/i915: Remove i915_drm_suspend_mode (rev2) URL : https://patchwork.freedesktop.org/series/112607/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Reset only one lane in case of MFD

2023-05-30 Thread Kahola, Mika
> -Original Message- > From: Luca Coelho > Sent: Tuesday, May 30, 2023 11:38 AM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Reset only one lane in case of > MFD > > Looks good, I only have some nitpicks. > > On Wed, 2023-05-24 at

  1   2   >