Re: [Intel-gfx] [PATCH v12 20/24] vfio: Only check group->type for noiommu test

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 6:38 AM > On Fri, 2 Jun 2023 05:16:49 -0700 > Yi Liu wrote: > > > group->type can be VFIO_NO_IOMMU only when vfio_noiommu option is true. > > And vfio_noiommu option can only be true if CONFIG_VFIO_NOIOMMU is enabled. > > So checking group-

[Intel-gfx] ✓ Fi.CI.IGT: success for PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-13 Thread Patchwork
== Series Details == Series: PCI/VGA: Introduce is_boot_device function callback to vga_client_register URL : https://patchwork.freedesktop.org/series/119249/ State : success == Summary == CI Bug Log - changes from CI_DRM_13264_full -> Patchwork_119249v1_full =

Re: [Intel-gfx] [PATCHv3] drm/i915/display/dp: On AUX xfer timeout restart freshly

2023-06-13 Thread Imre Deak
On Tue, Jun 13, 2023 at 10:12:39AM +0530, Arun R Murthy wrote: > On AUX transfer timeout, as per DP spec need to retry for 3 times and > has to be restarted freshly. > > v3: handle timeout and dont rely on register value on timeout (Imre) > > Signed-off-by: Arun R Murthy > --- > .../drm/i915/di

Re: [Intel-gfx] [PATCH v7 4/9] iommufd: Add iommufd_ctx_has_group()

2023-06-13 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:15:10AM -0700, Yi Liu wrote: > This adds the helper to check if any device within the given iommu_group > has been bound with the iommufd_ctx. This is helpful for the checking on > device ownership for the devices which have not been bound but cannot be > bound to any oth

Re: [Intel-gfx] [PATCH v7 3/9] iommufd: Reserve all negative IDs in the iommufd xarray

2023-06-13 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:15:09AM -0700, Yi Liu wrote: > With this reservation, IOMMUFD users can encode the negative IDs for > specific purposes. e.g. VFIO needs two reserved values to tell userspace > the ID returned is not valid but has other meaning. > > Tested-by: Terrence Xu > Signed-off-b

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-13 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:15:14AM -0700, Yi Liu wrote: > +/* > + * Return devid for a device which is affected by hot-reset. > + * - valid devid > 0 for the device that is bound to the input > + * iommufd_ctx. > + * - devid == VFIO_PCI_DEVID_OWNED for the device that has not > + * been bound t

Re: [Intel-gfx] [PATCH v7 5/9] iommufd: Add helper to retrieve iommufd_ctx and devid

2023-06-13 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:15:11AM -0700, Yi Liu wrote: > This is needed by the vfio-pci driver to report affected devices in the > hot-reset for a given device. > > Tested-by: Terrence Xu > Signed-off-by: Yi Liu > --- > drivers/iommu/iommufd/device.c | 12 > include/linux/iommufd.

Re: [Intel-gfx] [PATCH v7 7/9] vfio: Add helper to search vfio_device in a dev_set

2023-06-13 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:15:13AM -0700, Yi Liu wrote: > There are drivers that need to search vfio_device within a given dev_set. > e.g. vfio-pci. So add a helper. > > vfio_pci_is_device_in_set() now returns -EBUSY in commit a882c16a2b7e > ("vfio/pci: Change vfio_pci_try_bus_reset() to use the d

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 7:06 AM > > On Fri, 2 Jun 2023 05:16:53 -0700 > Yi Liu wrote: > > > This gives notes for userspace applications on device cdev usage. > > > > Reviewed-by: Kevin Tian > > Signed-off-by: Yi Liu > > --- > > Documentation/driver-api/vfio.rs

Re: [Intel-gfx] [PATCHv3] drm/i915/display/dp: On AUX xfer timeout restart freshly

2023-06-13 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Arun R > Murthy > Sent: Tuesday, June 13, 2023 7:43 AM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani > Subject: [Intel-gfx] [PATCHv3] drm/i915/display/dp: On AUX xfer timeout > restart freshly > > On AUX transfer timeout, a

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-13 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Tuesday, June 13, 2023 7:47 PM > > On Fri, Jun 02, 2023 at 05:15:14AM -0700, Yi Liu wrote: > > +/* > > + * Return devid for a device which is affected by hot-reset. > > + * - valid devid > 0 for the device that is bound to the input > > + * iommufd_ctx. > > + * -

Re: [Intel-gfx] [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Karol Herbst
On Mon, Dec 5, 2022 at 2:40 PM Christian König wrote: > > Am 29.11.22 um 22:14 schrieb Felix Kuehling: > > On 2022-11-25 05:21, Christian König wrote: > >> Instead of a single worker going over the list of delete BOs in regular > >> intervals use a per BO worker which blocks for the resv object an

Re: [Intel-gfx] [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Christian König
Am 13.06.23 um 15:05 schrieb Karol Herbst: On Mon, Dec 5, 2022 at 2:40 PM Christian König wrote: Am 29.11.22 um 22:14 schrieb Felix Kuehling: On 2022-11-25 05:21, Christian König wrote: Instead of a single worker going over the list of delete BOs in regular intervals use a per BO worker which

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 05:46:32 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 5:52 AM > > > > On Fri, 2 Jun 2023 05:16:36 -0700 > > Yi Liu wrote: > > > > > Allow the vfio_device file to be in a state where the device FD is > > > opened but the device cann

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 05:48:46 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 6:27 AM > > > > On Fri, 2 Jun 2023 05:16:47 -0700 > > Yi Liu wrote: > > > > > This adds ioctl for userspace to bind device cdev fd to iommufd. > > > > > > VFIO_DEVICE_BIND_I

Re: [Intel-gfx] [PATCH 3/9] drm/ttm: use per BO cleanup workers

2023-06-13 Thread Karol Herbst
On Tue, Jun 13, 2023 at 3:59 PM Christian König wrote: > > Am 13.06.23 um 15:05 schrieb Karol Herbst: > > On Mon, Dec 5, 2022 at 2:40 PM Christian König > > wrote: > >> Am 29.11.22 um 22:14 schrieb Felix Kuehling: > >>> On 2022-11-25 05:21, Christian König wrote: > Instead of a single worke

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 05:53:42 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 6:42 AM > > > > On Fri, 2 Jun 2023 05:16:50 -0700 > > Yi Liu wrote: > > > > > This moves the noiommu device determination and noiommu taint out of > > > vfio_group_find_or_alloc

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 12:01:51 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 7:06 AM > > > > On Fri, 2 Jun 2023 05:16:53 -0700 > > Yi Liu wrote: > > > > > This gives notes for userspace applications on device cdev usage. > > > > > > Reviewed-by: Kevin Ti

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 10:18 PM > > > > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > > > > index 83cc5dc28b7a..e80a8ac86e46 100644 > > > > --- a/include/linux/vfio.h > > > > +++ b/include/linux/vfio.h > > > > @@ -66,6 +66,7 @@ struct vfio_device { > >

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 12:50:43 + "Liu, Yi L" wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, June 13, 2023 7:47 PM > > > > On Fri, Jun 02, 2023 at 05:15:14AM -0700, Yi Liu wrote: > > > +/* > > > + * Return devid for a device which is affected by hot-reset. > > > + * - valid devid > 0 fo

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 10:19 PM > > On Tue, 13 Jun 2023 05:53:42 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, June 13, 2023 6:42 AM > > > > > > On Fri, 2 Jun 2023 05:16:50 -0700 > > > Yi Liu wrote: > > > > > > > This moves the

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 10:17 PM > > On Tue, 13 Jun 2023 05:46:32 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, June 13, 2023 5:52 AM > > > > > > On Fri, 2 Jun 2023 05:16:36 -0700 > > > Yi Liu wrote: > > > > > > > Allow the vfio_

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:28:43 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:18 PM > > > > > > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > > > > > index 83cc5dc28b7a..e80a8ac86e46 100644 > > > > > --- a/include/linux/vfio.h > > > > > +++ b

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:36:14 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:17 PM > > > > On Tue, 13 Jun 2023 05:46:32 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson > > > > Sent: Tuesday, June 13, 2023 5:52 AM > > > > > > > > On Fri,

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 10:40 PM > > On Tue, 13 Jun 2023 14:28:43 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, June 13, 2023 10:18 PM > > > > > > > > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > > > > > > index 83cc5

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 10:42 PM > > On Tue, 13 Jun 2023 14:36:14 + > "Liu, Yi L" wrote: > > > > > > > > > > > > diff --git a/drivers/vfio/vfio.h b/drivers/vfio/vfio.h > > > > > > index f9eb52eb9ed7..fdf2fc73f880 100644 > > > > > > --- a/drivers/vfio/vfio.h >

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 10:24 PM > > On Tue, 13 Jun 2023 12:01:51 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, June 13, 2023 7:06 AM > > > > > > On Fri, 2 Jun 2023 05:16:53 -0700 > > > Yi Liu wrote: > > > > > > > This gives note

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:33:01 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:19 PM > > > > On Tue, 13 Jun 2023 05:53:42 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson > > > > Sent: Tuesday, June 13, 2023 6:42 AM > > > > > > > > On Fri,

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:42:46 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:40 PM > > > > On Tue, 13 Jun 2023 14:28:43 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson > > > > Sent: Tuesday, June 13, 2023 10:18 PM > > > > > > > > >

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 10:48 PM > > On Tue, 13 Jun 2023 14:33:01 + > "Liu, Yi L" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, June 13, 2023 10:19 PM > > > > > > On Tue, 13 Jun 2023 05:53:42 + > > > "Liu, Yi L" wrote: > > > > > > > > From: A

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:48:02 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:24 PM > > > > On Tue, 13 Jun 2023 12:01:51 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson > > > > Sent: Tuesday, June 13, 2023 7:06 AM > > > > > > > > On Fri,

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Tuesday, June 13, 2023 11:04 PM > > > > > > > > > > > > > > > Unless I missed it, we've not described that vfio device cdev access > > > > > is > > > > > still bound by IOMMU group semantics, ie. there can be one DMA owner > > > > > for the group. That's a pretty

Re: [Intel-gfx] [PATCH] drm/i915/pxp/mtl: intel_pxp_init_hw needs runtime-pm inside pm-complete

2023-06-13 Thread Belgaumkar, Vinay
On 6/1/2023 8:59 AM, Alan Previn wrote: In the case of failed suspend flow or cases where the kernel does not go into full suspend but goes from suspend_prepare back to resume_complete, we get called for a pm_complete but without runtime_pm guaranteed. Thus, ensure we take the runtime_pm when

Re: [Intel-gfx] linux-next: Tree for Jun 13 (drivers/gpu/drm/i915/display/)

2023-06-13 Thread Randy Dunlap
On 6/12/23 23:59, Stephen Rothwell wrote: > Hi all, > > Changes since 20230609: > In file included from : ./../drivers/gpu/drm/i915/display/intel_display_power.h:255:70: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration [-W

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Jason Gunthorpe
On Tue, Jun 13, 2023 at 08:16:47AM -0600, Alex Williamson wrote: > > Not quite get why bit field is going to be incompatible with smp > > lockless operations. Could you elaborate a bit? And should I define > > the access_granted as u8 or "u8:1"? > > Perhaps FUD on my part, but load-acquire type o

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Cleanup usage of phy lane reset

2023-06-13 Thread Gustavo Sousa
Quoting Mika Kahola (2023-06-09 09:21:30-03:00) >From PICA message bus we wait for acknowledgment from >read/write commands. In case of an error, we reset the >bus for the next command. > >Current implementation ends up resetting message bus twice >in cases where error is not the timeout. Since, we

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 15:11:06 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 11:04 PM > > > > > > > > > > > > > > > > > > > Unless I missed it, we've not described that vfio device cdev > > > > > > access is > > > > > > still bound by IOMMU group semanti

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:19:17 -0300 Jason Gunthorpe wrote: > On Tue, Jun 13, 2023 at 08:16:47AM -0600, Alex Williamson wrote: > > > > Not quite get why bit field is going to be incompatible with smp > > > lockless operations. Could you elaborate a bit? And should I define > > > the access_granted

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Jason Gunthorpe
On Tue, Jun 13, 2023 at 11:15:11AM -0600, Alex Williamson wrote: > [Sorry for breaking threading, replying to my own message id with reply > content from Yi since the Cc list got broken] Yikes it is really busted, I think I fixed it? > If we renamed your function above to vfio_device_has_iommu_g

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-13 Thread Jason Gunthorpe
On Tue, Jun 13, 2023 at 08:32:29AM -0600, Alex Williamson wrote: > On Tue, 13 Jun 2023 12:50:43 + > "Liu, Yi L" wrote: > > > > From: Jason Gunthorpe > > > Sent: Tuesday, June 13, 2023 7:47 PM > > > > > > On Fri, Jun 02, 2023 at 05:15:14AM -0700, Yi Liu wrote: > > > > +/* > > > > + * Retur

Re: [Intel-gfx] [PATCH v7 6/9] vfio: Mark cdev usage in vfio_device

2023-06-13 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:15:12AM -0700, Yi Liu wrote: > This can be used to differentiate whether to report group_id or devid in > the revised VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl. At this moment, no > cdev path yet, so the vfio_device_cdev_opened() helper always returns false. > > Reviewed-

Re: [Intel-gfx] [PATCH v7 9/9] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-06-13 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:15:15AM -0700, Yi Liu wrote: > This is the way user to invoke hot-reset for the devices opened by cdev > interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED > in the output of VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl before doing > hot-reset for cde

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-13 Thread Jason Gunthorpe
On Fri, Jun 02, 2023 at 05:15:14AM -0700, Yi Liu wrote: > This allows VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl use the iommufd_ctx > of the cdev device to check the ownership of the other affected devices. > > When VFIO_DEVICE_GET_PCI_HOT_RESET_INFO is called on an IOMMUFD managed > device, the ne

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:35:09 -0300 Jason Gunthorpe wrote: > On Tue, Jun 13, 2023 at 11:15:11AM -0600, Alex Williamson wrote: > > [Sorry for breaking threading, replying to my own message id with reply > > content from Yi since the Cc list got broken] > > Yikes it is really busted, I think I f

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Enhance vfio PCI hot reset for vfio cdev device (rev6)

2023-06-13 Thread Patchwork
== Series Details == Series: Enhance vfio PCI hot reset for vfio cdev device (rev6) URL : https://patchwork.freedesktop.org/series/116991/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/116991/revisions/6/mbox/ not applied Applying: vfio/pci: Upda

Re: [Intel-gfx] [PATCH v2 i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

2023-06-13 Thread Dixit, Ashutosh
On Mon, 12 Jun 2023 12:42:13 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > Verify that SLPC API works as expected after a suspend. Added > another subtest that does multiple GT resets and checks freq api > works as expected after each one. > > We now check requested frequency instead of soft min/m

[Intel-gfx] [linux-next:master] BUILD REGRESSION 1f6ce8392d6ff486af5ca96df9ded5882c4b6977

2023-06-13 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 1f6ce8392d6ff486af5ca96df9ded5882c4b6977 Add linux-next specific files for 20230613 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306082341.uqtcm8po-...@intel.com https

[Intel-gfx] [PATCH] drm/i915: Remove prototype for intel_cx0_phy_ddi_vswing_sequence()

2023-06-13 Thread Gustavo Sousa
That function is not defined anywhere. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_cx0_phy.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.h b/drivers/gpu/drm/i915/display/intel_cx0_phy.h index f99809af257d..4c4db5cdcbd0

[Intel-gfx] [PATCH 1/4] drm/i915: Add a notrace version of intel_de_read_fw

2023-06-13 Thread Radhakrishna Sripada
Around the tracing infrastructure, certain registers are being read resulting in nested traces. Introduce the no trace version of intel_de_read_fw to be used in such scenarios. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_de.h | 10 ++ 1 file changed, 10 ins

[Intel-gfx] [PATCH 2/4] drm/i915: Add a dummy notrace version of intel_de_read64_2x32

2023-06-13 Thread Radhakrishna Sripada
intel_de_read64_2x32 and hence intel_uncore_read64_2x32 do not use any of the tracing api's. It is however important to distinguish between the tracing and non tracing versions to avoid nesting of tracing events. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_de.h | 7

[Intel-gfx] [PATCH 0/4] Use non traceable api in display trace code

2023-06-13 Thread Radhakrishna Sripada
Nesting of tracing events should in general be avoided. Many of the display tracing events use the traceable versions of register read/writes. This patchset replaces them with non traceable versions and defines them if required. This cleanup will be helpful to introduce reg rw tracing of the xe dr

[Intel-gfx] [PATCH 4/4] drm/i915: Make intel_get_crtc_scanline use no trace hw reads

2023-06-13 Thread Radhakrishna Sripada
intel_get_crtc_scanline is used in the display tracing infrastructure. Use no trace hw reads to avoid nested tracing calls. Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/display/intel_vblank.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH 3/4] drm/i915: Make intel_crtc_get_vblank_counter use no trace hw reads

2023-06-13 Thread Radhakrishna Sripada
intel_crtc_get_vblank_counter is used in many places in the display tracing infrastructure. For a clean execution of the tracing assignment, ensure that any necessary HW reads would not further trigger another trace, to prevent nesting of trace events. Suggested-by: Maarten Lankhorst Signed-off-b

[Intel-gfx] [CI] drm/i915/gsc: define gsc fw

2023-06-13 Thread Daniele Ceraolo Spurio
Add FW definition and the matching override modparam. The GSC FW has both a release version, based on platform and a rolling counter, and a compatibility version, which is the one tracking interface changes. Since what we care about is the interface, we use the compatibility version in the binary

[Intel-gfx] [RFC 0/2] Add mmio register rw tracing

2023-06-13 Thread Radhakrishna Sripada
This patchset adds xe_reg_rw mmio tracing event for the xe driver. This tracing event should be helpful for developers especially to debug Display code. Radhakrishna Sripada (2): drm/xe: Move mmio read/write functions to xe_mmio.c drm/xe: Add reg read/write trace .../drm/xe/compat-i915-heade

[Intel-gfx] [RFC 2/2] drm/xe: Add reg read/write trace

2023-06-13 Thread Radhakrishna Sripada
This will help debug register read/writes and provide a way to trace all the mmio transactions. In order to avoid spam from xe_mmio_wait32, xe_mmio_read32_notrace is introduced and used. Signed-off-by: Radhakrishna Sripada --- .../drm/xe/compat-i915-headers/intel_uncore.h | 8 +- drivers/gpu/d

[Intel-gfx] [RFC 1/2] drm/xe: Move mmio read/write functions to xe_mmio.c

2023-06-13 Thread Radhakrishna Sripada
Move the register read/write apis to xe_mmio.c to prepare for adding tracing infrastructure for the same. Adding tracing support in xe_mmio.h messes with the compilation of the display code. Cc: Lucas De Marchi Cc: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/xe/xe_mmio.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove prototype for intel_cx0_phy_ddi_vswing_sequence()

2023-06-13 Thread Patchwork
== Series Details == Series: drm/i915: Remove prototype for intel_cx0_phy_ddi_vswing_sequence() URL : https://patchwork.freedesktop.org/series/119301/ State : success == Summary == CI Bug Log - changes from CI_DRM_13269 -> Patchwork_119301v1

Re: [Intel-gfx] [PATCH v2 i-g-t] tests/i915_pm_freq_api: Add a suspend subtest

2023-06-13 Thread Belgaumkar, Vinay
On 6/13/2023 2:25 PM, Dixit, Ashutosh wrote: On Mon, 12 Jun 2023 12:42:13 -0700, Vinay Belgaumkar wrote: Hi Vinay, Verify that SLPC API works as expected after a suspend. Added another subtest that does multiple GT resets and checks freq api works as expected after each one. We now check req

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Use non traceable api in display trace code

2023-06-13 Thread Patchwork
== Series Details == Series: Use non traceable api in display trace code URL : https://patchwork.freedesktop.org/series/119303/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Use non traceable api in display trace code

2023-06-13 Thread Patchwork
== Series Details == Series: Use non traceable api in display trace code URL : https://patchwork.freedesktop.org/series/119303/ State : success == Summary == CI Bug Log - changes from CI_DRM_13269 -> Patchwork_119303v1 Summary --- **

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gsc: define gsc fw

2023-06-13 Thread Patchwork
== Series Details == Series: drm/i915/gsc: define gsc fw URL : https://patchwork.freedesktop.org/series/119310/ State : warning == Summary == Error: dim checkpatch failed d4e081946b3a drm/i915/gsc: define gsc fw -:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'major_' - possible side-effect

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Use non traceable api in display trace code

2023-06-13 Thread philly j
Why is this going on what do I need to do to secure everything I’m tired of all my devices not working I didn’t ask for this I’ve learned a lot but I’m so frustrated > > On Jun 13, 2023 at 9:02 PM, (mailto:patchw...@emeril.freedesktop.org)> wrote:

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Use non traceable api in display trace code

2023-06-13 Thread philly j
How do I do that? I just need to fix all this Like, how does the system make changes on it when it’s not even plugged in I factory reset it unplug it once you’re done next day it’s like all different settings of configuration files everything > > On Ju

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Add mmio register rw tracing

2023-06-13 Thread Patchwork
== Series Details == Series: Add mmio register rw tracing URL : https://patchwork.freedesktop.org/series/119311/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/119311/revisions/1/mbox/ not applied Applying: drm/xe: Move mmio read/write functions t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gsc: define gsc fw

2023-06-13 Thread Patchwork
== Series Details == Series: drm/i915/gsc: define gsc fw URL : https://patchwork.freedesktop.org/series/119310/ State : success == Summary == CI Bug Log - changes from CI_DRM_13269 -> Patchwork_119310v1 Summary --- **SUCCESS** No

Re: [Intel-gfx] [RFC 1/2] drm/xe: Move mmio read/write functions to xe_mmio.c

2023-06-13 Thread Matt Roper
On Tue, Jun 13, 2023 at 05:13:14PM -0700, Radhakrishna Sripada wrote: > Move the register read/write apis to xe_mmio.c to prepare for > adding tracing infrastructure for the same. Adding tracing support > in xe_mmio.h messes with the compilation of the display code. > > Cc: Lucas De Marchi > Cc:

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Apply min softlimit correctly

2023-06-13 Thread Dixit, Ashutosh
On Fri, 09 Jun 2023 15:02:52 -0700, Vinay Belgaumkar wrote: > Hi Vinay, > We were skipping when min_softlimit was equal to RPn. We need to apply > it rergardless as efficient frequency will push the SLPC min to RPe. regardless > This will break scenarios where user sets a min softlimit < RPe be

Re: [Intel-gfx] [PATCH v3 00/28] drm/i915/gvt: KVM: KVMGT fixes and page-track cleanups

2023-06-13 Thread Ma, Yongwei
> Fix a variety of found-by-inspection bugs in KVMGT, and overhaul KVM's > page-track APIs to provide a leaner and cleaner interface. The motivation for > this series is to (significantly) reduce the number of KVM APIs that KVMGT > uses, with a long-term goal of making all kvm_host.h headers KVM-i

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Liu, Yi L
> From: Alex Williamson > Sent: Wednesday, June 14, 2023 4:11 AM > > On Tue, 13 Jun 2023 14:35:09 -0300 > Jason Gunthorpe wrote: > > > On Tue, Jun 13, 2023 at 11:15:11AM -0600, Alex Williamson wrote: > > > [Sorry for breaking threading, replying to my own message id with reply > > > content fr

[Intel-gfx] [PATCH] drm/i915/display : Remove support for interlace mode

2023-06-13 Thread Ankit Nautiyal
There are multiple panels with which Interlace mode is seen to cause flickering (interlacing artifacts) with different platforms. The issue is seen with both HDMI, DP with CML, CFL, ICL, EHL with different display models from Acer, Benq, Dell etc. There are some models where the issue is not seen

Re: [Intel-gfx] Intel-gfx Digest, Vol 185, Issue 285

2023-06-13 Thread Matt Jack
Man, can someone reply to me is this exactly what’s going on to my devices? What do you want me to do seriously man it’s getting old. Do you want me to compile and make one of these units and then my device will be OK again like what is the deal? Sent from my iPhone > On Jun 13, 2023, at 11:2

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display : Remove support for interlace mode

2023-06-13 Thread Patchwork
== Series Details == Series: drm/i915/display : Remove support for interlace mode URL : https://patchwork.freedesktop.org/series/119319/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13269 -> Patchwork_119319v1 Summary

[Intel-gfx] [PATCH v2 0/3] Move stolen memory handling details into i915_gem_stolen

2023-06-13 Thread Jouni Högander
We are preparing for Xe driver. Stolen memory handling will be different in Xe driver. Due to this we want to remove all stolen memory handling details away from FBC code. v2: - Fix couple of checkpatch warnings - Fix intel_gt_support_legacy_fencing macro Cc: Jani Nikula Cc: Rodrigo Vivi Cc:

[Intel-gfx] [PATCH v2 2/3] drm/i915/fbc: Make FBC check stolen at use time

2023-06-13 Thread Jouni Högander
As a preparation for Xe change stolen memory initialization check to be done in use-time instead of during initialization. In case of xe, stolen memory is initialised much later so it can't be checked during init. There is no specific reason to check this in init for i915 either -> perform the che

[Intel-gfx] [PATCH v2 1/3] drm/i915: Move stolen memory handling into i915_gem_stolen

2023-06-13 Thread Jouni Högander
We are preparing for Xe. Xe stolen memory handling differs from i915 so we want to move stolen memory handling details into i915_gem_stolen. Also add a common type for fbc compressed fb and use it from fbc code instead of underlying type directly. This way we can have common type i915_stolen_fb fo

[Intel-gfx] [PATCH v2 3/3] drm/i915/fbc: Moved fence related code away from intel_fbc

2023-06-13 Thread Jouni Högander
As a preparation for Xe move HW fence details away from intel_fbc code. Add new functions to check support for legacy fencing and fence id and use these in fbc code. Xe doesn't support legacy fencing. v2: Fix intel_gt_support_legacy_fencing macro Signed-off-by: Jouni Högander --- drivers/gpu/dr

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, June 14, 2023 11:24 AM > > > From: Alex Williamson > > Sent: Wednesday, June 14, 2023 4:11 AM > > > > On Tue, 13 Jun 2023 14:35:09 -0300 > > Jason Gunthorpe wrote: > > > > > On Tue, Jun 13, 2023 at 11:15:11AM -0600, Alex Williamson wrote: > > > > [Sorry for

Re: [Intel-gfx] [PATCH v7 6/9] vfio: Mark cdev usage in vfio_device

2023-06-13 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Wednesday, June 14, 2023 1:56 AM > > On Fri, Jun 02, 2023 at 05:15:12AM -0700, Yi Liu wrote: > > This can be used to differentiate whether to report group_id or devid in > > the revised VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl. At this moment, no > > cdev path yet,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Move stolen memory handling details into i915_gem_stolen (rev2)

2023-06-13 Thread Patchwork
== Series Details == Series: Move stolen memory handling details into i915_gem_stolen (rev2) URL : https://patchwork.freedesktop.org/series/119123/ State : warning == Summary == Error: dim checkpatch failed 830cf12c0926 drm/i915: Move stolen memory handling into i915_gem_stolen -:44: WARNING:A

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Move stolen memory handling details into i915_gem_stolen (rev2)

2023-06-13 Thread Patchwork
== Series Details == Series: Move stolen memory handling details into i915_gem_stolen (rev2) URL : https://patchwork.freedesktop.org/series/119123/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Move stolen memory handling details into i915_gem_stolen (rev2)

2023-06-13 Thread Patchwork
== Series Details == Series: Move stolen memory handling details into i915_gem_stolen (rev2) URL : https://patchwork.freedesktop.org/series/119123/ State : success == Summary == CI Bug Log - changes from CI_DRM_13269 -> Patchwork_119123v2 S

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Wednesday, June 14, 2023 1:42 PM > > > From: Liu, Yi L > > Sent: Wednesday, June 14, 2023 11:24 AM > > > > > From: Alex Williamson > > > Sent: Wednesday, June 14, 2023 4:11 AM > > > > > > On Tue, 13 Jun 2023 14:35:09 -0300 > > > Jason Gunthorpe wrote: > > > > > > >

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, June 14, 2023 2:14 PM > > > > With that I think Jason's suggestion is to lift that test into main.c: > > > > int vfio_register_group_dev(struct vfio_device *device) > > { > > /* > > * VFIO always sets IOMMU_CACHE because we offer no way for > userspa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove prototype for intel_cx0_phy_ddi_vswing_sequence()

2023-06-13 Thread Patchwork
== Series Details == Series: drm/i915: Remove prototype for intel_cx0_phy_ddi_vswing_sequence() URL : https://patchwork.freedesktop.org/series/119301/ State : success == Summary == CI Bug Log - changes from CI_DRM_13269_full -> Patchwork_119301v1_full ==