[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/sdvo: DDC rework and fixes

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915/sdvo: DDC rework and fixes URL : https://patchwork.freedesktop.org/series/120253/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13346_full -> Patchwork_120253v1_full Summary ---

Re: [Intel-gfx] [PATCH v3] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-07-05 Thread Balasubrawmanian, Vivaik
On 6/29/2023 6:44 PM, Alan Previn wrote: After recent discussions with Mesa folks, it was requested that we optimize i915's GET_PARAM for the PXP_STATUS without changing the UAPI spec. Add these additional optimizations: - If any PXP initializatoin flow failed, then ensure that we catc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/sdvo: DDC rework and fixes

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915/sdvo: DDC rework and fixes URL : https://patchwork.freedesktop.org/series/120253/ State : success == Summary == CI Bug Log - changes from CI_DRM_13346 -> Patchwork_120253v1 Summary --- **SUCCESS*

Re: [Intel-gfx] [PATCH v3 6/6] drm/i915: Try to initialize DDI/ICL+ DSI ports for every VBT child device

2023-07-05 Thread Ville Syrjälä
On Fri, Jun 30, 2023 at 07:38:38PM +0300, Jani Nikula wrote: > On Fri, 30 Jun 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Try to deal with duplicate child devices for the same DDI port > > by attempting to initialize them in VBT defined order The first > > on to succeed for a speci

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/sdvo: DDC rework and fixes

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915/sdvo: DDC rework and fixes URL : https://patchwork.freedesktop.org/series/120253/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1:

[Intel-gfx] [PATCH 13/13] drm/i915/sdvo: Print out the i2c pin and slave address

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä To reduce the guesswork a bit let's print out the SDVO device i2c bus and slave address during init. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c

[Intel-gfx] [PATCH 12/13] drm/i915/sdvo: Rework DDC bus handling

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä Each SDVO device can have up to three sets of DDC pins. Currently we just register a single i2c_adapter for the entire SDVO device and semi-randomly pick the "correct" set of DDC pins during intel_sdvo_tmds_sink_detect(). This doesn't make any real sense especially if we have

[Intel-gfx] [PATCH 11/13] drm/i915/sdvo: Get rid of the per-connector i2c symlink

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä We should switch over to the standard "ddc" per-connector symlink instead of rolling our own thing. The i2c specific symlink is also in the way of reworking the SDVO DDC handling (which is a mess atm) so get rid of it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH 10/13] drm/i915/sdvo: Nuke the duplicate sdvo->port

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä We already have encoder->port so get rid of the duplicate sdvo->port. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.

[Intel-gfx] [PATCH 09/13] drm/i915/sdvo: Initialize the encoder ealier

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä Call drm_encoder_init() earlier so that we don't have to keep passing the i915/dev_priv around separately. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 35 +++ 1 file changed, 17 insertions(+), 18 deletions(-) diff --git

[Intel-gfx] [PATCH 08/13] drm/i915/sdvo: Nuke attached_output tracking

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä Instead of operating on the output the user specified (via the connector) the current code tends to operate on whichever outputs it has detected as attached. That is not how the kms uapi is supposed to work. So simply get rid of attached_outputs and instead directly operate on

[Intel-gfx] [PATCH 07/13] drm/i915/sdvo: Fail gracefully if the TV dotclock is out of range

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä Instead of warning and continuing with bogus state when the requested dotclock isn't acceptable just print some debug spew and fail gracefully. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 18 +- 1 file changed, 13 insertions(

[Intel-gfx] [PATCH 06/13] drm/i915/sdvo: Pick the TV dotclock from adjusted_mode

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä port_clock is what the encoder/dpll code is supposed to calculate, it is not the input clock. Use the dotclock as the target we're trying to achieve instead. TODO: the SDVO TV clocking is a mess atm and needs further work Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 05/13] drm/i915: Fully populate crtc_state->dpll

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä Call *_calc_dpll_params() even in cases where the encoder has computed the DPLL params for us. The SDVO TV output code doesn't populate crtc_state->dpll.dot leading to the dotclock getting calculated as zero, and that leads to all kinds of real problems. The g4x DP code also

[Intel-gfx] [PATCH 04/13] drm/i915: Don't warn about zero N/P in *_calc_dpll_params()

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä Allow *_calc_dpll_params() to be called even if the N/P dividers are zero without warning. We'll want to call these to make sure the derived values are fully computed, but not all users (VLV DSI in particular) don't even enable the DPLL and thus the dividers will be left at ze

[Intel-gfx] [PATCH 03/13] drm/i915/sdvo: s/sdvo_inputs_mask/sdvo_num_inputs/

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä The SDVO inputs are reportes a simple number, not a bitmask. Adjust the code to match reality. Note that we don't actually support dual input SDVO devices, and we just always use the first input. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c

[Intel-gfx] [PATCH 02/13] drm/i915/sdvo: Protect macro args

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä Put parens around macro argument evaluation for safety. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_sdvo.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/

[Intel-gfx] [PATCH 01/13] drm/i915/sdvo: Issue SetTargetOutput prior ot GetAttachedDisplays

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä I have at least one SDVO device (some Lenovo DVI-I ADD2 card, based on Conexant CX25904) where GetAttachedDisplays returns success but fails to report any attached displays unless wet precede the command with a SetTargetOutput. Make it so. I wasn't able to spot anything in th

[Intel-gfx] [PATCH 00/13] drm/i915/sdvo: DDC rework and fixes

2023-07-05 Thread Ville Syrjala
From: Ville Syrjälä I have plans to switch the whole driver over to using drm_connector_init_with_ddc(), and thus populate the sysfs "ddc" consistently. The biggest hurdle is the SDVO DDC handling, so start by cleaning that up. I also found some other issues with the SDVO code so some additiona

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915/gt: update request engine before removing virtual GuC engine URL : https://patchwork.freedesktop.org/series/120238/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13346_full -> Patchwork_120238v1_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915/gt: update request engine before removing virtual GuC engine URL : https://patchwork.freedesktop.org/series/120238/ State : success == Summary == CI Bug Log - changes from CI_DRM_13346 -> Patchwork_120238v1 =

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915/gt: update request engine before removing virtual GuC engine URL : https://patchwork.freedesktop.org/series/120238/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/120238/revisions/1/mbox/ not found

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Do not disable preemption for resets

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915: Do not disable preemption for resets URL : https://patchwork.freedesktop.org/series/120218/ State : success == Summary == CI Bug Log - changes from CI_DRM_13346_full -> Patchwork_120218v1_full Summary

[Intel-gfx] [PATCH i-g-t 3/3] gputop: Add memory information

2023-07-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Show total and resident memory usage for clients which support it. For simplicity all memory regions are summed up and shown under a single heading. Co-developed-by: Rob Clark Signed-off-by: Tvrtko Ursulin --- tools/gputop.c | 34 +- 1 fil

[Intel-gfx] [PATCH i-g-t 1/3] lib/igt_drm_fdinfo: Parse memory usage

2023-07-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add parsing and memory storage for the memory usage related fdinfo stats. Uses the same approach as the engine utilization code by either auto- discovering different memory regions, or allowing for the caller to pass in a map with predefined index to name relationship. Co-d

[Intel-gfx] [PATCH i-g-t 2/3] lib/igt_drm_clients: Store memory info in the client

2023-07-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Define the storage structure and copy over memory data as parsed by the fdinfo helpers. Signed-off-by: Tvrtko Ursulin Cc: Rob Clark --- lib/igt_drm_clients.c | 31 +++ lib/igt_drm_clients.h | 11 +++ 2 files changed, 42 insertions(+) d

[Intel-gfx] [PATCH i-g-t 0/3] gputop memory usage

2023-07-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Same general approach as with engine utilisation, adding parsing of the relevant fdinfo fields and plumbing to client discovery helpers to finally present some of the available data in gputop: DRM minor 0 PID MEM RSS rendercopy video NAME 8098 124M

Re: [Intel-gfx] [linux-next:master] BUILD REGRESSION e1f6a8eaf1c271a0158114a03e3605f4fba059ad

2023-07-05 Thread Helge Deller
On 7/5/23 18:07, kernel test robot wrote: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e1f6a8eaf1c271a0158114a03e3605f4fba059ad Add linux-next specific files for 20230705 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all

[Intel-gfx] [PATCH] drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-05 Thread Andrzej Hajda
GuC virtual engines can be removed before request removal. On the other side driver expects rq->engine to be a valid pointer for a whole life of request. Setting rq->engine to an always valid engine should solve the issue. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7926 Signed-off-b

[Intel-gfx] [linux-next:master] BUILD REGRESSION e1f6a8eaf1c271a0158114a03e3605f4fba059ad

2023-07-05 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: e1f6a8eaf1c271a0158114a03e3605f4fba059ad Add linux-next specific files for 20230705 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/20230613.hher4zoo-...@intel.com https

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-05 Thread Imre Deak
On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > According to BSpec 49190, when enabling crtcs, we first setup > slave and then master crtc, however for disabling it should go > vice versa, i.e first master, then slave, however current code > does disabling in a same way as en

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove some dead "code"

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915: Remove some dead "code" URL : https://patchwork.freedesktop.org/series/120222/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13346 -> Patchwork_120222v1 Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not disable preemption for resets

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915: Do not disable preemption for resets URL : https://patchwork.freedesktop.org/series/120218/ State : success == Summary == CI Bug Log - changes from CI_DRM_13346 -> Patchwork_120218v1 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-05 Thread Luca Coelho
On Thu, 2023-05-25 at 13:10 +0300, Stanislav Lisovskiy wrote: > According to BSpec 49190, when enabling crtcs, we first setup > slave and then master crtc, however for disabling it should go > vice versa, i.e first master, then slave, however current code > does disabling in a same way as enabling.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Do not disable preemption for resets

2023-07-05 Thread Patchwork
== Series Details == Series: drm/i915: Do not disable preemption for resets URL : https://patchwork.freedesktop.org/series/120218/ State : warning == Summary == Error: dim checkpatch failed 3097d4402754 drm/i915: Do not disable preemption for resets -:14: ERROR:GIT_COMMIT_ID: Please use git co

Re: [Intel-gfx] [PATCH] drm/i915: Remove some dead "code"

2023-07-05 Thread Jani Nikula
On Wed, 05 Jul 2023, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit 2caffbf11762 ("drm/i915: Revoke mmaps and prevent access to fence > registers across reset") removed the temporary implementation of a reset > under stop machine but forgot to remove this one commented out define. > > Si

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Do not use stolen on MTL

2023-07-05 Thread Andrzej Hajda
On 30.06.2023 19:01, Nirmoy Das wrote: Use smem on MTL due to a HW bug in MTL that prevents reading from stolen memory using LMEM BAR. Cc: Oak Zeng Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Andi Shyti Cc: Andrzej Hajda Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/display/intel_fbd

[Intel-gfx] [PATCH] drm/i915: Remove some dead "code"

2023-07-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit 2caffbf11762 ("drm/i915: Revoke mmaps and prevent access to fence registers across reset") removed the temporary implementation of a reset under stop machine but forgot to remove this one commented out define. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/g

[Intel-gfx] __diag_ignore_all(), GCC < 8, extra warnings, and -Werror

2023-07-05 Thread Jani Nikula
For a long time now, i915 has enabled a bunch of W=1 style warnings locally, and we try hard to keep i915 warning free. One of the warnings is -Woverride-init from -Wextra. We need to bypass that in a few cases, and used to do this for the relevant files: CFLAGS_file.o = $(call cc-disab

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not use stolen on MTL

2023-07-05 Thread Andrzej Hajda
On 30.06.2023 19:01, Nirmoy Das wrote: Use smem on MTL due to a HW bug in MTL that prevents reading from stolen memory using LMEM BAR. Cc: Oak Zeng Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Andi Shyti Cc: Andrzej Hajda Signed-off-by: Nirmoy Das Reviewed-by: Andrzej Hajda Regards Andrz

Re: [Intel-gfx] [PATCH v2 06/19] drm/i915/dsb: Avoid corrupting the first register write

2023-07-05 Thread Manna, Animesh
> -Original Message- > From: Manna, Animesh > Sent: Wednesday, July 5, 2023 3:10 PM > To: Ville Syrjala ; intel- > g...@lists.freedesktop.org > Subject: RE: [Intel-gfx] [PATCH v2 06/19] drm/i915/dsb: Avoid corrupting the > first register write > > > > > -Original Message- > > F

Re: [Intel-gfx] [PATCH v2 01/19] drm/i915: Constify LUT entries in checker

2023-07-05 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, June 7, 2023 12:45 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 01/19] drm/i915: Constify LUT entries in > checker > > From: Ville Syrjälä > > The LUT checker doesn't mo

Re: [Intel-gfx] [PATCH v2 06/19] drm/i915/dsb: Avoid corrupting the first register write

2023-07-05 Thread Manna, Animesh
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, June 7, 2023 12:45 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 06/19] drm/i915/dsb: Avoid corrupting the first > register write > > From: Ville Syrjälä > > i915_gem_obj

[Intel-gfx] [PATCH] drm/i915: Do not disable preemption for resets

2023-07-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit ade8a0f59844 ("drm/i915: Make all GPU resets atomic") added a preempt disable section over the hardware reset callback to prepare the driver for being able to reset from atomic contexts. In retrospect I can see that the work item at a time was about removing the struc

[Intel-gfx] ✓ Fi.CI.IGT: success for Add rc_range_params for YUV420

2023-07-05 Thread Patchwork
== Series Details == Series: Add rc_range_params for YUV420 URL : https://patchwork.freedesktop.org/series/120205/ State : success == Summary == CI Bug Log - changes from CI_DRM_13345_full -> Patchwork_120205v1_full Summary --- **SUC