Re: [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers

2023-07-14 Thread Christian Brauner
On Thu, Jul 13, 2023 at 11:10:54AM -0600, Alex Williamson wrote: > On Thu, 13 Jul 2023 12:05:36 +0200 > Christian Brauner wrote: > > > Hey everyone, > > > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > > by removing the count argument which is effectively unused. > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hotplug: Reduce SHPD_FILTER to 250us

2023-07-14 Thread Patchwork
== Series Details == Series: drm/i915/hotplug: Reduce SHPD_FILTER to 250us URL : https://patchwork.freedesktop.org/series/120722/ State : success == Summary == CI Bug Log - changes from CI_DRM_13385 -> Patchwork_120722v1 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Fix LT debug print in SDP CRC enable

2023-07-14 Thread Patchwork
== Series Details == Series: drm/i915/dp: Fix LT debug print in SDP CRC enable URL : https://patchwork.freedesktop.org/series/120719/ State : success == Summary == CI Bug Log - changes from CI_DRM_13385_full -> Patchwork_120719v1_full Summa

Re: [Intel-gfx] [RFC 1/2] drm/i915: Refactor PAT/object cache handling

2023-07-14 Thread Tvrtko Ursulin
On 14/07/2023 06:36, Yang, Fei wrote: [snip] @@ -326,10 +330,10 @@ int i915_gem_get_caching_ioctl(struct drm_device *dev, void *data, goto out; } - if (i915_gem_object_has_cache_level(obj, I915_CACHE_LLC) || - i915_gem_object_has_cache_level(obj, I915_CACHE_

Re: [Intel-gfx] [RFC 2/2] drm/i915: Remove PAT hack from i915_gem_object_can_bypass_llc

2023-07-14 Thread Tvrtko Ursulin
On 14/07/2023 06:43, Yang, Fei wrote: From: Tvrtko Ursulin According to the comment in i915_gem_object_can_bypass_llc the purpose of the function is to return false if the platform/object has a caching mode where GPU can bypass the LLC. So far the only platforms which allegedly can do this a

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-14 Thread Nirmoy Das
On 7/13/2023 4:23 PM, Cavitt, Jonathan wrote: -Original Message- From: Nirmoy Das Sent: Thursday, July 13, 2023 7:12 AM To: Andi Shyti Cc: Cavitt, Jonathan ; Intel GFX ; Roper, Matthew D ; Chris Wilson ; Mika Kuoppala Subject: Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gt: Ensure memo

[Intel-gfx] [PATCH] drm/i915: Start using plane scale factor for relative data rate

2023-07-14 Thread Stanislav Lisovskiy
BSpec 68907 clearly instructs us to use plane scale factor when calculating relative data rate to be used when allocating DDB blocks for each plane. For some reason we use scale factor for data_rate calculation, which is used for BW calculations, however we are not using it for DDB calculations. S

Re: [Intel-gfx] [PATCH v9 09/10] vfio/pci: Copy hot-reset device info to userspace in the devices loop

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:31:25PM -0700, Yi Liu wrote: > @@ -1311,29 +1296,17 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info( > ret = vfio_pci_for_each_slot_or_bus(vdev->pdev, vfio_pci_fill_devs, > &fill, slot); > mutex_unlock(&vdev->vdev

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Start using plane scale factor for relative data rate

2023-07-14 Thread Patchwork
== Series Details == Series: drm/i915: Start using plane scale factor for relative data rate URL : https://patchwork.freedesktop.org/series/120767/ State : success == Summary == CI Bug Log - changes from CI_DRM_13385 -> Patchwork_120767v1 S

Re: [Intel-gfx] [PATCH v14 14/26] iommufd/device: Add iommufd_access_detach() API

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:16PM -0700, Yi Liu wrote: > From: Nicolin Chen > > Previously, the detach routine is only done by the destroy(). And it was > called by vfio_iommufd_emulated_unbind() when the device runs close(), so > all the mappings in iopt were cleaned in that setup, when the cal

Re: [Intel-gfx] [PATCH v14 17/26] vfio: Move device_del() before waiting for the last vfio_device registration refcount

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:19PM -0700, Yi Liu wrote: > device_del() destroys the vfio-dev/vfioX under the sysfs for vfio_device. > There is no reason to keep it while the device is going to be unregistered. > > This movement is also a preparation for adding vfio_device cdev. Kernel > should rem

Re: [Intel-gfx] [PATCH v14 19/26] vfio: Test kvm pointer in _vfio_device_get_kvm_safe()

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:21PM -0700, Yi Liu wrote: > This saves some lines when adding the kvm get logic for the vfio_device > cdev path. > > This also renames _vfio_device_get_kvm_safe() to be > vfio_device_get_kvm_safe(). > > Suggested-by: Jason Gunthorpe > Signed-off-by: Yi Liu > --- >

Re: [Intel-gfx] [PATCH v14 20/26] iommufd: Add iommufd_ctx_from_fd()

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:22PM -0700, Yi Liu wrote: > It's common to get a reference to the iommufd context from a given file > descriptor. So adds an API for it. Existing users of this API are compiled > only when IOMMUFD is enabled, so no need to have a stub for the IOMMUFD > disabled case. >

Re: [Intel-gfx] [PATCH v14 21/26] vfio: Avoid repeated user pointer cast in vfio_device_fops_unl_ioctl()

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:23PM -0700, Yi Liu wrote: > This adds a local variable to store the user pointer cast result from arg. > It avoids the repeated casts in the code when more ioctls are added. > > Signed-off-by: Yi Liu > --- > drivers/vfio/vfio_main.c | 3 ++- > 1 file changed, 2 inse

Re: [Intel-gfx] [PATCH v14 22/26] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:24PM -0700, Yi Liu wrote: > +static inline long vfio_df_ioctl_bind_iommufd(struct vfio_device_file *df, > + struct vfio_device_bind_iommufd > __user *arg) > +{ > + return -EOPNOTSUPP; > +} This should be -ENOTTY > @@ -1

Re: [Intel-gfx] [PATCH v14 23/26] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:25PM -0700, Yi Liu wrote: > This adds ioctl for userspace to attach device cdev fd to and detach > from IOAS/hw_pagetable managed by iommufd. > > VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach vfio device to IOAS or hw_pagetable > managed b

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/gt: Do not use stolen on MTL (rev2)

2023-07-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Do not use stolen on MTL (rev2) URL : https://patchwork.freedesktop.org/series/120683/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./

Re: [Intel-gfx] [PATCH v14 24/26] vfio: Move the IOMMU_CAP_CACHE_COHERENCY check in __vfio_register_dev()

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:26PM -0700, Yi Liu wrote: > The IOMMU_CAP_CACHE_COHERENCY check only applies to the physical devices > that are IOMMU-backed. But it is now in the group code. If want to compile > vfio_group infrastructure out, this check needs to be moved out of the group > code. > >

Re: [Intel-gfx] [PATCH v14 26/26] docs: vfio: Add vfio device cdev description

2023-07-14 Thread Jason Gunthorpe
On Mon, Jul 10, 2023 at 07:59:28PM -0700, Yi Liu wrote: > This gives notes for userspace applications on device cdev usage. > > Reviewed-by: Kevin Tian > Signed-off-by: Yi Liu > --- > Documentation/driver-api/vfio.rst | 139 ++ > 1 file changed, 139 insertions(+) Re

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Do not use stolen on MTL (rev2)

2023-07-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Do not use stolen on MTL (rev2) URL : https://patchwork.freedesktop.org/series/120683/ State : success == Summary == CI Bug Log - changes from CI_DRM_13385 -> Patchwork_120683v2 ===

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Start using plane scale factor for relative data rate

2023-07-14 Thread Patchwork
== Series Details == Series: drm/i915: Start using plane scale factor for relative data rate URL : https://patchwork.freedesktop.org/series/120767/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13385_full -> Patchwork_120767v1_full =

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gt: Do not use stolen on MTL (rev2)

2023-07-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Do not use stolen on MTL (rev2) URL : https://patchwork.freedesktop.org/series/120683/ State : success == Summary == CI Bug Log - changes from CI_DRM_13385_full -> Patchwork_120683v2_full =

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Extract sync spinner API

2023-07-14 Thread Rodrigo Vivi
On Tue, Jul 11, 2023 at 05:02:13PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Sync spinner API is identical and compatible with regular spinners just > that it tries to make sure spinner is actually running on the hardware > before returning from the constructor. > > A few tests alr

Re: [Intel-gfx] [PATCH v4 20/21] config TEST_DYNAMIC_DEBUG default m

2023-07-14 Thread jim . cromie
On Thu, Jul 13, 2023 at 1:04 PM Randy Dunlap wrote: > > Hi Jim, > > On 7/13/23 09:36, Jim Cromie wrote: > > Signed-off-by: Jim Cromie > > --- > > lib/Kconfig.debug | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index d4f

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] tests/i915_pm_rps: Exercise sysfs thresholds

2023-07-14 Thread Rodrigo Vivi
On Tue, Jul 11, 2023 at 05:02:14PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Exercise a bunch of up and down rps thresholds to verify hardware > is happy with them all. > > To limit the overall runtime relies on probability and number of runs > to approach complete coverage. > > v

Re: [Intel-gfx] [PATCH v4 21/21] dyndbg-doc: add classmap info to howto

2023-07-14 Thread jim . cromie
On Thu, Jul 13, 2023 at 1:13 PM Randy Dunlap wrote: > > > > On 7/13/23 09:36, Jim Cromie wrote: > > Add some basic info on classmap usage and api > > > > Signed-off-by: Jim Cromie > > --- > > .../admin-guide/dynamic-debug-howto.rst | 64 ++- > > 1 file changed, 63 insertion

Re: [Intel-gfx] [RFC 2/2] drm/i915: Remove PAT hack from i915_gem_object_can_bypass_llc

2023-07-14 Thread Yang, Fei
> On 14/07/2023 06:43, Yang, Fei wrote: >>> From: Tvrtko Ursulin >>> >>> According to the comment in i915_gem_object_can_bypass_llc the >>> purpose of the function is to return false if the platform/object has >>> a caching mode where GPU can bypass the LLC. >>> >>> So far the only platforms which

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [RFC,1/2] drm/i915: Refactor PAT/object cache handling (rev2)

2023-07-14 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: Refactor PAT/object cache handling (rev2) URL : https://patchwork.freedesktop.org/series/120686/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/120686/revisions/2/mbox/ not app

Re: [Intel-gfx] [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure

2023-07-14 Thread Ville Syrjälä
On Fri, Jul 14, 2023 at 08:56:15AM +0200, Christian König wrote: > Am 13.07.23 um 21:47 schrieb Ville Syrjala: > > From: Ville Syrjälä > > > > Currently dma_resv_get_fences() will leak the previously > > allocated array if the fence iteration got restarted and > > the krealloc_array() fails. > > >

[Intel-gfx] [CI] PR for GuC 70.8.0 for DG2

2023-07-14 Thread Daniele Ceraolo Spurio
The following changes since commit d3f66064cf43bd7338a79174bd0ff60c4ecbdf6d: Partially revert "amdgpu: DMCUB updates for DCN 3.1.4 and 3.1.5" (2023-07-07 15:24:32 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dg2_guc_7.8 for you to fetch chan

Re: [Intel-gfx] [RFC 2/2] drm/i915: Remove PAT hack from i915_gem_object_can_bypass_llc

2023-07-14 Thread Matt Roper
On Fri, Jul 14, 2023 at 11:11:30AM +0100, Tvrtko Ursulin wrote: > > On 14/07/2023 06:43, Yang, Fei wrote: > > > From: Tvrtko Ursulin > > > > > > According to the comment in i915_gem_object_can_bypass_llc the > > > purpose of the function is to return false if the platform/object > > > has a cach

Re: [Intel-gfx] [PATCH v14 20/26] iommufd: Add iommufd_ctx_from_fd()

2023-07-14 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Friday, July 14, 2023 10:21 PM > > On Mon, Jul 10, 2023 at 07:59:22PM -0700, Yi Liu wrote: > > It's common to get a reference to the iommufd context from a given file > > descriptor. So adds an API for it. Existing users of this API are compiled > > only when IOMMU

Re: [Intel-gfx] [PATCH v14 22/26] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-07-14 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Friday, July 14, 2023 10:42 PM > > On Mon, Jul 10, 2023 at 07:59:24PM -0700, Yi Liu wrote: > > > +static inline long vfio_df_ioctl_bind_iommufd(struct vfio_device_file *df, > > + struct vfio_device_bind_iommufd > > __user >

Re: [Intel-gfx] [PATCH v9 09/10] vfio/pci: Copy hot-reset device info to userspace in the devices loop

2023-07-14 Thread Liu, Yi L
> From: Jason Gunthorpe > Sent: Friday, July 14, 2023 9:37 PM > > On Mon, Jul 10, 2023 at 07:31:25PM -0700, Yi Liu wrote: > > > @@ -1311,29 +1296,17 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info( > > ret = vfio_pci_for_each_slot_or_bus(vdev->pdev, vfio_pci_fill_devs, > >