[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Refactor plane size calculation by core helper functions

2023-07-19 Thread Patchwork
== Series Details == Series: drm: Refactor plane size calculation by core helper functions URL : https://patchwork.freedesktop.org/series/121012/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13396_full -> Patchwork_121012v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Refactor plane size calculation by core helper functions

2023-07-19 Thread Patchwork
== Series Details == Series: drm: Refactor plane size calculation by core helper functions URL : https://patchwork.freedesktop.org/series/121012/ State : success == Summary == CI Bug Log - changes from CI_DRM_13396 -> Patchwork_121012v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Refactor plane size calculation by core helper functions

2023-07-19 Thread Patchwork
== Series Details == Series: drm: Refactor plane size calculation by core helper functions URL : https://patchwork.freedesktop.org/series/121012/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Refactor plane size calculation by core helper functions

2023-07-19 Thread Patchwork
== Series Details == Series: drm: Refactor plane size calculation by core helper functions URL : https://patchwork.freedesktop.org/series/121012/ State : warning == Summary == Error: dim checkpatch failed a5fc4b7c1a46 drm: Remove plane hsub/vsub alignment requirement for core helpers -:16:

[Intel-gfx] [PATCH v2 2/2] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-07-19 Thread Carlos Eduardo Gallo Filho
The functions drm_framebuffer_plane_{width,height} and fb_plane_{width,height} do exactly the same job of its equivalents drm_format_info_plane_{width,height} from drm_fourcc. The only reason to have these functions on drm_framebuffer would be if they would added a abstraction layer to call it

[Intel-gfx] [PATCH v2 1/2] drm: Remove plane hsub/vsub alignment requirement for core helpers

2023-07-19 Thread Carlos Eduardo Gallo Filho
The drm_format_info_plane_{height,width} functions was implemented using regular division for the plane size calculation, which cause issues [1][2] when used on contexts where the dimensions are misaligned with relation to the subsampling factors. So, replace the regular division by the

[Intel-gfx] [PATCH v2 0/2] drm: Refactor plane size calculation by core helper functions

2023-07-19 Thread Carlos Eduardo Gallo Filho
There's duplicated functions on drm that do the same job of calculating the size of planes from a drm_format_info and the size of its first plane. So this patchset throw away the more specific version intended to be used from a given framebuffer and make the generic version way more portable

Re: [Intel-gfx] [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-19 Thread Matt Roper
On Wed, Jul 19, 2023 at 05:07:15PM -0700, Yang, Fei wrote: > [snip] > >> @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct > >> drm_i915_gem_object *obj) > > > > The code change here looks accurate, but while we're here, I have a side > > question about this function in general...it

Re: [Intel-gfx] [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-19 Thread Yang, Fei
[snip] >> @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct >> drm_i915_gem_object *obj) > > The code change here looks accurate, but while we're here, I have a side > question about this function in general...it was originally introduced > in commit 48004881f693 ("drm/i915: Mark CPU

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Eliminate IS_MTL_GRAPHICS_STEP

2023-07-19 Thread Matt Roper
On Wed, Jul 19, 2023 at 08:28:12AM -0700, Matt Roper wrote: > On Wed, Jul 19, 2023 at 09:01:58AM +0100, Tvrtko Ursulin wrote: > > > > On 18/07/2023 23:27, Matt Roper wrote: > > > Several workarounds are guarded by IS_MTL_GRAPHICS_STEP. However none > > > of these workarounds are actually tied to

Re: [Intel-gfx] [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread suijingfeng
On 2023/7/20 03:32, Bjorn Helgaas wrote: but I think it's just confusing to mention this in the commit log, so I would just remove it. Ok, will be done at the next version.

Re: [Intel-gfx] [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread Sui Jingfeng
On 2023/7/20 06:32, suijingfeng wrote: it will be works no matter CONFIG_DRM_AST=m or CONFIG_DRM_AST=y It will be works regardless of CONFIG_DRM_AST=m or CONFIG_DRM_AST=y. When vgaarb call to the device driver, device driver already loaded successfully. and the PCI(e) device emulation

Re: [Intel-gfx] [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread suijingfeng
Hi, On 2023/7/20 03:32, Bjorn Helgaas wrote: [+cc linux-pci (please cc in the future since the bulk of this patch is in drivers/pci/)] On Wed, Jul 12, 2023 at 12:43:05AM +0800, Sui Jingfeng wrote: From: Sui Jingfeng Currently, the strategy of selecting the default boot on a multiple video

Re: [Intel-gfx] [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-19 Thread Matt Roper
On Wed, Jul 19, 2023 at 01:37:30PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") has > introduced PAT indices to i915 internal APIs, partially replacing the > usage of driver internal cache_level, but has also added

Re: [Intel-gfx] [PATCH v3 3/9] PCI/VGA: Switch to aperture_contain_firmware_fb_nonreloc()

2023-07-19 Thread suijingfeng
Hi, On 2023/7/20 04:43, Bjorn Helgaas wrote: [+cc linux-pci; I don't apply or ack PCI patches unless they appear there] On Wed, Jul 12, 2023 at 12:43:04AM +0800, Sui Jingfeng wrote: From: Sui Jingfeng The observation behind this is that we should avoid accessing the global screen_info

[Intel-gfx] [CI] PR for MTL and DG2 FW updates

2023-07-19 Thread Daniele Ceraolo Spurio
This is a unified version of the 3 separate PRs that I've sent in the last week. If there are no CI issues, this version will be sent to linux-firmware instead of the other 3. The following changes since commit d3f66064cf43bd7338a79174bd0ff60c4ecbdf6d: Partially revert "amdgpu: DMCUB updates

Re: [Intel-gfx] [PATCH v3 1/9] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-07-19 Thread suijingfeng
Hi, On 2023/7/20 04:43, Bjorn Helgaas wrote: On Wed, Jul 12, 2023 at 12:43:02AM +0800, Sui Jingfeng wrote: From: Sui Jingfeng This patch adds the aperture_contain_firmware_fb() function to do the determination. Unfortunately, due to the fact that the apertures list will be freed

Re: [Intel-gfx] [PATCH v2] drm/i915/dpt: Use shmem for dpt objects

2023-07-19 Thread Yang, Fei
> On 18/07/2023 23:51, Radhakrishna Sripada wrote: >> Dpt objects that are created from internal get evicted when there is >> memory pressure and do not get restored when pinned during scanout. >> The pinned page table entries look corrupted and programming the >> display engine with the incorrect

Re: [Intel-gfx] [PATCH v3 1/9] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-07-19 Thread Bjorn Helgaas
On Wed, Jul 12, 2023 at 12:43:02AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > This patch adds the aperture_contain_firmware_fb() function to do the > determination. Unfortunately, due to the fact that the apertures list > will be freed dynamically, the location and size information of

Re: [Intel-gfx] [PATCH v3 3/9] PCI/VGA: Switch to aperture_contain_firmware_fb_nonreloc()

2023-07-19 Thread Bjorn Helgaas
[+cc linux-pci; I don't apply or ack PCI patches unless they appear there] On Wed, Jul 12, 2023 at 12:43:04AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The observation behind this is that we should avoid accessing the global > screen_info directly. Call the

Re: [Intel-gfx] [RFC v5 00/17] DRM cgroup controller with scheduling control and memory stats

2023-07-19 Thread T.J. Mercier
On Wed, Jul 12, 2023 at 4:47 AM Tvrtko Ursulin wrote: > > drm.memory.stat > A nested file containing cumulative memory statistics for the whole > sub-hierarchy, broken down into separate GPUs and separate memory > regions supported by the latter. > > For

Re: [Intel-gfx] [PATCH 7/8] drm/i915/display: Eliminate IS_METEORLAKE checks

2023-07-19 Thread Gustavo Sousa
Quoting Gustavo Sousa (2023-07-19 16:39:25-03:00) >Quoting Matt Roper (2023-07-18 19:28:01-03:00) >>Most of the IS_METEORLAKE checks in the display code shouldn't actually >>be tied to MTL as a platform, but rather to the Xe_LPD+ display IP >>(which is used in MTL, but may show up again in future

Re: [Intel-gfx] [PATCH 7/8] drm/i915/display: Eliminate IS_METEORLAKE checks

2023-07-19 Thread Gustavo Sousa
Quoting Matt Roper (2023-07-18 19:28:01-03:00) >Most of the IS_METEORLAKE checks in the display code shouldn't actually >be tied to MTL as a platform, but rather to the Xe_LPD+ display IP >(which is used in MTL, but may show up again in future platforms). In >cases where we're trying to match

Re: [Intel-gfx] [PATCH v3 0/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, Jul 12, 2023 at 12:43:01AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > Currently, the default VGA device selection is not perfect. Potential > problems are: > > 1) This function is a no-op on non-x86 architectures. > 2) It does not take the PCI Bar may get

Re: [Intel-gfx] [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread Bjorn Helgaas
[+cc linux-pci (please cc in the future since the bulk of this patch is in drivers/pci/)] On Wed, Jul 12, 2023 at 12:43:05AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > Currently, the strategy of selecting the default boot on a multiple video > card coexistence system is not perfect.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: use direct alias for i915 in requests

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915: use direct alias for i915 in requests URL : https://patchwork.freedesktop.org/series/120991/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13396 -> Patchwork_120991v1 Summary ---

Re: [Intel-gfx] [PATCH 6/8] drm/i915/mtl: Eliminate subplatforms

2023-07-19 Thread Gustavo Sousa
Quoting Matt Roper (2023-07-18 19:28:00-03:00) >Now that we properly match the Xe_LPG IP versions associated with >various workarounds, there's no longer any need to define separate MTL >subplatform in the driver. Nothing in the code is conditional on MTL-M >or MTL-P base platforms. Furthermore,

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Eliminate IS_MTL_DISPLAY_STEP

2023-07-19 Thread Gustavo Sousa
Quoting Matt Roper (2023-07-18 19:27:59-03:00) >Stepping-specific display behavior shouldn't be tied to MTL as a >platform, but rather specifically to the Xe_LPM+ IP. Future non-MTL s/Xe_LPD+/Xe_LPDM+/ ? The changes for this and the previous two patches look correct to me, but I would also be

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: use direct alias for i915 in requests

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915: use direct alias for i915 in requests URL : https://patchwork.freedesktop.org/series/120991/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use direct alias for i915 in requests

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915: use direct alias for i915 in requests URL : https://patchwork.freedesktop.org/series/120991/ State : warning == Summary == Error: dim checkpatch failed 98626971c431 drm/i915: use direct alias for i915 in requests -:122: WARNING:AVOID_BUG: Do not crash

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request""

2023-07-19 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" URL : https://patchwork.freedesktop.org/series/120990/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13396 -> Patchwork_120990v1

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/tv: avoid possible division by zero (rev2)

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915/tv: avoid possible division by zero (rev2) URL : https://patchwork.freedesktop.org/series/120851/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13396_full -> Patchwork_120851v2_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request""

2023-07-19 Thread Patchwork
== Series Details == Series: Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request"" URL : https://patchwork.freedesktop.org/series/120990/ State : warning == Summary == Error: dim checkpatch failed 08ce05640e8f Revert "Revert "drm/i915: Hold reference to

Re: [Intel-gfx] [PATCH 2/8] drm/i915/xelpg: Call Xe_LPG workaround functions based on IP version

2023-07-19 Thread Gustavo Sousa
Quoting Matt Roper (2023-07-18 19:27:56-03:00) >Although some of our Xe_LPG workarounds were already being applied based >on IP version correctly, others were matching on MTL as a base platform, >which is incorrect. Although MTL is the only platform right now that >uses Xe_LPG IP, this may not

Re: [Intel-gfx] [PATCH 6/8] drm/i915/mtl: Eliminate subplatforms

2023-07-19 Thread Garg, Nemesa
> -Original Message- > From: Roper, Matthew D > Sent: Wednesday, July 19, 2023 3:58 AM > To: intel-gfx@lists.freedesktop.org > Cc: Roper, Matthew D > Subject: [Intel-gfx] [PATCH 6/8] drm/i915/mtl: Eliminate subplatforms > > Now that we properly match the Xe_LPG IP versions associated

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Consolidate condition for Wa_22011802037

2023-07-19 Thread Gustavo Sousa
Quoting Matt Roper (2023-07-18 19:27:55-03:00) >The workaround bounds for Wa_22011802037 are somewhat complex and are >replicated in several places throughout the code. Pull the condition >out to a helper function to prevent mistakes if this condition needs to >change again in the future. >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tv: avoid possible division by zero (rev2)

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915/tv: avoid possible division by zero (rev2) URL : https://patchwork.freedesktop.org/series/120851/ State : success == Summary == CI Bug Log - changes from CI_DRM_13396 -> Patchwork_120851v2 Summary

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/tc: some clean-ups in max lane count handling code

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915/tc: some clean-ups in max lane count handling code URL : https://patchwork.freedesktop.org/series/120980/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M]

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Start using plane scale factor for relative data rate (rev3)

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Start using plane scale factor for relative data rate (rev3) URL : https://patchwork.freedesktop.org/series/120767/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13395_full -> Patchwork_120767v3_full

Re: [Intel-gfx] [PATCH 4/4] drm/i915/tc: remove "fia" from intel_tc_port_fia_max_lane_count()

2023-07-19 Thread kernel test robot
Hi Luca, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Luca-Coelho/drm-i915-tc-rename-mtl_tc_port_get_pin_assignment_mask/20230719-213204 base: git://anongit.freedesktop.org/drm/drm-tip

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Eliminate IS_MTL_GRAPHICS_STEP

2023-07-19 Thread Matt Roper
On Wed, Jul 19, 2023 at 09:01:58AM +0100, Tvrtko Ursulin wrote: > > On 18/07/2023 23:27, Matt Roper wrote: > > Several workarounds are guarded by IS_MTL_GRAPHICS_STEP. However none > > of these workarounds are actually tied to MTL as a platform; they only > > relate to the Xe_LPG graphics IP,

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Replace several IS_METEORLAKE with proper IP version checks

2023-07-19 Thread Matt Roper
On Wed, Jul 19, 2023 at 08:57:15AM +0100, Tvrtko Ursulin wrote: > > On 18/07/2023 23:28, Matt Roper wrote: > > Many of the IS_METEORLAKE conditions throughout the driver are supposed > > to be checks for Xe_LPG and/or Xe_LPM+ IP, not for the MTL platform > > specifically. Update those checks to

[Intel-gfx] [PATCH] drm/i915: use direct alias for i915 in requests

2023-07-19 Thread Andrzej Hajda
i915_request contains direct alias to i915, there is no point to go via rq->engine->i915. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- drivers/gpu/drm/i915/gt/gen2_engine_cs.c | 2 +- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 18

Re: [Intel-gfx] [PATCH 3/4] drm/i915/tc: move legacy code out of the main _max_lane_count() func

2023-07-19 Thread kernel test robot
Hi Luca, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Luca-Coelho/drm-i915-tc-rename-mtl_tc_port_get_pin_assignment_mask/20230719-213204 base: git://anongit.freedesktop.org/drm/drm-tip

[Intel-gfx] [PATCH] Revert "Revert "drm/i915: Hold reference to intel_context over life of i915_request""

2023-07-19 Thread Andrzej Hajda
This reverts commit bcb9aa45d5a0e11ef91245330c53cde214d15e8d. The problem with this patch is that it makes rq->engine dangling pointer after context removal. At least two places were located where it ends with errors: - i915_fence_release: intel_engine_is_virtual(rq->engine), -

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Refactor PAT/object cache handling (rev2)

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Refactor PAT/object cache handling (rev2) URL : https://patchwork.freedesktop.org/series/120924/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13395 -> Patchwork_120924v2 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Refactor PAT/object cache handling (rev2)

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Refactor PAT/object cache handling (rev2) URL : https://patchwork.freedesktop.org/series/120924/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Refactor PAT/object cache handling (rev2)

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Refactor PAT/object cache handling (rev2) URL : https://patchwork.freedesktop.org/series/120924/ State : warning == Summary == Error: dim checkpatch failed 17d1cb1da24d drm/i915: Refactor PAT/object cache handling Traceback (most recent call last):

Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-19 Thread Su Hui
On 2023/7/18 19:28, Andrzej Hajda wrote: On 18.07.2023 12:10, Su Hui wrote: On 2023/7/18 13:39, Dan Carpenter wrote: On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22

Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-19 Thread Su Hui
On 2023/7/18 13:39, Dan Carpenter wrote: On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and

[Intel-gfx] [PATCH v2] drm/i915/tv: avoid possible division by zero

2023-07-19 Thread Su Hui
Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, then division by zero will happen. Fixes: 1bba5543e4fe ("drm/i915: Fix TV encoder clock computation") Signed-off-by: Su Hui ---

Re: [Intel-gfx] [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-19 Thread Su Hui
On 2023/7/17 22:52, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, then division by zero will happen. Fixes: 1bba5543e4fe

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume (rev2)

2023-07-19 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume (rev2) URL : https://patchwork.freedesktop.org/series/120931/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13395 -> Patchwork_120931v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume (rev2)

2023-07-19 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume (rev2) URL : https://patchwork.freedesktop.org/series/120931/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume (rev2)

2023-07-19 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume (rev2) URL : https://patchwork.freedesktop.org/series/120931/ State : warning == Summary == Error: dim checkpatch failed eef2b2d4e3b7 drm/i915: Avoid endless HPD

[Intel-gfx] ✗ Fi.CI.BAT: failure for Update AUX invalidation sequence (rev6)

2023-07-19 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev6) URL : https://patchwork.freedesktop.org/series/119798/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13395 -> Patchwork_119798v6 Summary ---

Re: [Intel-gfx] [PATCH v2] drm/i915/dpt: Use shmem for dpt objects

2023-07-19 Thread Tvrtko Ursulin
On 18/07/2023 23:51, Radhakrishna Sripada wrote: Dpt objects that are created from internal get evicted when there is memory pressure and do not get restored when pinned during scanout. The pinned page table entries look corrupted and programming the display engine with the incorrect pte's

[Intel-gfx] [PATCH 2/4] drm/i915/tc: make intel_tc_port_get_lane_mask() static

2023-07-19 Thread Luca Coelho
This function is only used locally, so make it static and remove the definition from the header file. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_tc.c | 2 +- drivers/gpu/drm/i915/display/intel_tc.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 4/4] drm/i915/tc: remove "fia" from intel_tc_port_fia_max_lane_count()

2023-07-19 Thread Luca Coelho
It is irrelevant for the caller that the max lane count is being derived from a FIA register, so having "fia" in the function name is irrelevant. Rename the function accordingly. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--

[Intel-gfx] [PATCH 3/4] drm/i915/tc: move legacy code out of the main _max_lane_count() func

2023-07-19 Thread Luca Coelho
This makes the code a bit more symmetric and readable, especially when we start adding more display version-specific alternatives. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_tc.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 1/4] drm/i915/tc: rename mtl_tc_port_get_pin_assignment_mask()

2023-07-19 Thread Luca Coelho
This function doesn't really return the pin assigment mask, but the max lane count derived from that. So rename the function to mtl_tc_port_get_max_lane_count() to better reflect what it really does. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_tc.c | 4 ++-- 1 file

[Intel-gfx] [PATCH 0/4] drm/i915/tc: some clean-ups in max lane count handling code

2023-07-19 Thread Luca Coelho
Hi, Here are four patches with some clean-ups in the code that handles the max lane count of Type-C connections. This is done mostly in preparation for a new way to read the pin assignments and lane count in future devices. Please review. Cheers, Luca. Luca Coelho (4): drm/i915/tc: rename

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update AUX invalidation sequence (rev6)

2023-07-19 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev6) URL : https://patchwork.freedesktop.org/series/119798/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update AUX invalidation sequence (rev6)

2023-07-19 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev6) URL : https://patchwork.freedesktop.org/series/119798/ State : warning == Summary == Error: dim checkpatch failed 501b25e131de drm/i915/gt: Cleanup aux invalidation registers cab2ff5e8756 drm/i915: Add the has_aux_ccs device

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Start using plane scale factor for relative data rate (rev3)

2023-07-19 Thread Patchwork
== Series Details == Series: drm/i915: Start using plane scale factor for relative data rate (rev3) URL : https://patchwork.freedesktop.org/series/120767/ State : success == Summary == CI Bug Log - changes from CI_DRM_13395 -> Patchwork_120767v3

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-19 Thread Tvrtko Ursulin
On 19/07/2023 11:41, Andrzej Hajda wrote: On 18.07.2023 17:48, Tvrtko Ursulin wrote: On 17/07/2023 19:03, John Harrison wrote: On 7/13/2023 05:11, Tvrtko Ursulin wrote: On 13/07/2023 12:09, Andrzej Hajda wrote: Hi, On 13.07.2023 09:39, Tvrtko Ursulin wrote: On 12/07/2023 19:54, John

[Intel-gfx] [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") has introduced PAT indices to i915 internal APIs, partially replacing the usage of driver internal cache_level, but has also added a few questionable design decisions which this patch tries to improve

[Intel-gfx] [PATCH v2 1/3] drm/i915: Avoid endless HPD poll detect loop via runtime suspend/resume

2023-07-19 Thread Imre Deak
The issue fixed in commit a8ddac7c9f06 ("drm/i915: Avoid HPD poll detect triggering a new detect cycle") on VLV, CHV is still present on platforms where the display hotplug detection functionality is available whenever the device is in D0 state (hence these platforms switch to HPD polling only

[Intel-gfx] [PATCH v6 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-19 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")

[Intel-gfx] [PATCH v6 8/9] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-19 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc:

[Intel-gfx] [PATCH v6 7/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-19 Thread Andi Shyti
Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). The VE and BCS engines need to add the flush part in their command streamer. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all

[Intel-gfx] [PATCH v6 6/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-19 Thread Andi Shyti
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Matt Roper ---

[Intel-gfx] [PATCH v6 5/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-19 Thread Andi Shyti
Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git

[Intel-gfx] [PATCH v6 1/9] drm/i915/gt: Cleanup aux invalidation registers

2023-07-19 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist

[Intel-gfx] [PATCH v6 4/9] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-19 Thread Andi Shyti
In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only

[Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-19 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ Reviewed-by:

[Intel-gfx] [PATCH v6 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-19 Thread Andi Shyti
We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true as it requires some further per device checks. Add the "has_aux_ccs" flag in the intel_device_info structure in order to have a per device flag indicating of the AUX CCS.

[Intel-gfx] [PATCH v6 0/9] Update AUX invalidation sequence

2023-07-19 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

Re: [Intel-gfx] [PATCH] drm/i915: Start using plane scale factor for relative data rate

2023-07-19 Thread Garg, Nemesa
> -Original Message- > From: Lisovskiy, Stanislav > Sent: Wednesday, July 19, 2023 4:19 PM > To: intel-gfx@lists.freedesktop.org > Cc: Lisovskiy, Stanislav ; Saarinen, Jani > ; Garg, Nemesa > Subject: [PATCH] drm/i915: Start using plane scale factor for relative data > rate > > BSpec

[Intel-gfx] [PATCH] drm/i915: Start using plane scale factor for relative data rate

2023-07-19 Thread Stanislav Lisovskiy
BSpec clearly instructs us to use plane scale factor when calculating relative data rate to be used when allocating DDB blocks for each plane. For some reason we use scale factor for data_rate calculation, which is used for BW calculations, however we are not using it for DDB calculations. So lets

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: update request engine before removing virtual GuC engine

2023-07-19 Thread Andrzej Hajda
On 18.07.2023 17:48, Tvrtko Ursulin wrote: On 17/07/2023 19:03, John Harrison wrote: On 7/13/2023 05:11, Tvrtko Ursulin wrote: On 13/07/2023 12:09, Andrzej Hajda wrote: Hi, On 13.07.2023 09:39, Tvrtko Ursulin wrote: On 12/07/2023 19:54, John Harrison wrote: On 7/12/2023 09:27, Andrzej

Re: [Intel-gfx] Intel-gfx Digest, Vol 186, Issue 211

2023-07-19 Thread Garg, Nemesa
> -Original Message- > From: Intel-gfx On Behalf Of intel- > gfx-requ...@lists.freedesktop.org > Sent: Friday, July 14, 2023 7:10 PM > To: intel-gfx@lists.freedesktop.org > Subject: Intel-gfx Digest, Vol 186, Issue 211 > > Send Intel-gfx mailing list submissions to >

Re: [Intel-gfx] [PATCH i-g-t] tests/i915_pm_rps: Fix test after silent conflict harder

2023-07-19 Thread Tvrtko Ursulin
On 18/07/2023 19:37, Dixit, Ashutosh wrote: On Tue, 18 Jul 2023 01:40:41 -0700, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Feature test also needs adjusting after sysfs helper API changes... Signed-off-by: Tvrtko Ursulin Fixes: d86ca7e17b58 ("tests/i915_pm_rps: Exercise sysfs

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Eliminate IS_MTL_GRAPHICS_STEP

2023-07-19 Thread Tvrtko Ursulin
On 18/07/2023 23:27, Matt Roper wrote: Several workarounds are guarded by IS_MTL_GRAPHICS_STEP. However none of these workarounds are actually tied to MTL as a platform; they only relate to the Xe_LPG graphics IP, regardless of what platform it appears in. At the moment MTL is the only

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Replace several IS_METEORLAKE with proper IP version checks

2023-07-19 Thread Tvrtko Ursulin
On 18/07/2023 23:28, Matt Roper wrote: Many of the IS_METEORLAKE conditions throughout the driver are supposed to be checks for Xe_LPG and/or Xe_LPM+ IP, not for the MTL platform specifically. Update those checks to ensure that the code will still operate properly if/when these IP versions

Re: [Intel-gfx] [PATCH] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-07-19 Thread Maxime Ripard
Hi, On Mon, Jul 17, 2023 at 04:04:43PM -0300, Carlos wrote: > On 7/12/23 20:30, André Almeida wrote: > > Hi Carlos, > > > > Em 27/06/2023 15:22, Carlos Eduardo Gallo Filho escreveu: > > [...] > > > > > > So, replace each drm_framebuffer_plane_{width,height} and > > > fb_plane_{width,height}