[Intel-gfx] [PATCH v2 3/4] drm/i915: Add new frontbuffer tracking interface to queue flush

2023-07-26 Thread Jouni Högander
We want to wait dma fences in dirtyfb ioctl. As we don't want to make dirtyfb ioctl as blocking call we need to use dma_fence_add_callback. Callback used for dma_fence_add_callback is called from atomic context. Due to this we need to add a new frontbuffer tracking interface to queue flush. v2:

[Intel-gfx] [PATCH v2 4/4] drm/i915: Handle dma fences in dirtyfb callback

2023-07-26 Thread Jouni Högander
Take into account dma fences in dirtyfb callback. If there is no unsignaled dma fences perform flush immediately. If there are unsignaled dma fences perform invalidate and add callback which will queue flush when the fence gets signaled. v2: Use dma_resv_get_singleton Signed-off-by: Jouni

[Intel-gfx] [PATCH v2 0/4] Handle dma fences in dirtyfb ioctl

2023-07-26 Thread Jouni Högander
Currently i915 dirtyfb ioctl is not taking dma fences into account. This works with features like FBC, PSR, DRRS because our gem code is triggering flush again when rendering completes. We are targeting in getting rid of frontbuffer tracking code: Flusing hook from gem code will be removed as

[Intel-gfx] [PATCH v2 2/4] drm/i915/psr: Clear frontbuffer busy bits on flip

2023-07-26 Thread Jouni Högander
We are planning to move flush performed from work queue. This means it is possible to have invalidate -> flip -> flush sequence. Handle this by clearing possible busy bits on flip. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_psr.c | 6 ++ 1 file changed, 6

[Intel-gfx] [PATCH v2 1/4] drm/i915/fbc: Clear frontbuffer busy bits on flip

2023-07-26 Thread Jouni Högander
We are planning to move flush performed from work queue. This means it is possible to have invalidate -> flip -> flush sequence. Handle this by clearing possible busy bits on flip. Signed-off-by: Ville Syrjälä Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fbc.c | 6

[Intel-gfx] ✗ Fi.CI.IGT: failure for Replace acronym with full platform name in defines.

2023-07-26 Thread Patchwork
== Series Details == Series: Replace acronym with full platform name in defines. URL : https://patchwork.freedesktop.org/series/121387/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13426_full -> Patchwork_121387v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev8)

2023-07-26 Thread Patchwork
== Series Details == Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev8) URL : https://patchwork.freedesktop.org/series/117713/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13426_full -> Patchwork_117713v8_full

Re: [Intel-gfx] [PATCH v7] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-26 Thread Ceraolo Spurio, Daniele
On 7/20/2023 4:01 PM, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915

[Intel-gfx] ✓ Fi.CI.BAT: success for Replace acronym with full platform name in defines.

2023-07-26 Thread Patchwork
== Series Details == Series: Replace acronym with full platform name in defines. URL : https://patchwork.freedesktop.org/series/121387/ State : success == Summary == CI Bug Log - changes from CI_DRM_13426 -> Patchwork_121387v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Replace acronym with full platform name in defines.

2023-07-26 Thread Patchwork
== Series Details == Series: Replace acronym with full platform name in defines. URL : https://patchwork.freedesktop.org/series/121387/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Replace acronym with full platform name in defines.

2023-07-26 Thread Patchwork
== Series Details == Series: Replace acronym with full platform name in defines. URL : https://patchwork.freedesktop.org/series/121387/ State : warning == Summary == Error: dim checkpatch failed 26b2934657f0 drm/i915/hsw: s/HSW/HASWELL for platform/subplatform defines -:46:

[Intel-gfx] PR for ADLP DMC v2.20 and MTL DMC v2.13

2023-07-26 Thread Gustavo Sousa
The following changes since commit b6ea35ff6b9869470a0c68813f1668acb3d356a8: copy-firmware: Fix linking directories when using compression (2023-07-25 06:53:30 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dmc-adlp_2.20-mtl_2.13 for you to

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection

2023-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection URL : https://patchwork.freedesktop.org/series/121373/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13426_full -> Patchwork_121373v1_full

[Intel-gfx] [PATCH v4 13/14] drm/i915/adln: s/ADLP/ALDERLAKE_P in ADLN defines

2023-07-26 Thread Dnyaneshwar Bhadane
From: Anusha Srivatsa Follow consistent naming convention. Replace ADLP with ALDERLAKE_P Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c| 2 +- drivers/gpu/drm/i915/i915_drv.h | 2 +-

[Intel-gfx] [PATCH v3 07/14] drm/i915/rkl: s/RKL/ROCKETLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace RKL with ROCKETLAKE.Replace IS_RKL_GRAPHICS_STEP with IS_ROCKETLAKE && IS_DISPLAY_STEP. v2: - s/RKL/rkl in the subject prefix(Anusha) v3: - Unrolled wrapper IS_RKL_DISPLAY_STEP. - Replace IS_PLATFORM && IS_DISPLAY_STEP (Jani/Tvrtko) Cc: Tvrtko

[Intel-gfx] [PATCH v2 12/14] drm/i915/rplu: s/ADLP_RPLU/RAPTORLAKE_U in RPLU defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace ADLP with ALDERLAKE_P v2: - Replace IS_ADLP_RPLU with IS_RAPTORLAKE_U (Tvrtko/Lucas) - Change the subject Cc: Tvrtko Ursulin Cc: Jani Nikula Cc: Anusha Srivatsa Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2

[Intel-gfx] [PATCH v4 09/14] drm/i915/tgl: s/TGL/TIGERLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace TGL with TIGERLAKE.Replace IS_TGL_DISPLAY_STEP with IS_TIGERLAKE() && IS_DISPLAY_STEP(). v2: - s/TGL/tgl in the subject prefix(Anusha) v3: - Unrolled wrapper IS_TGL_DISPLAY_STEP and Replace - Replace IS_PLATFORM && DISPLAY_STEP (Jani/Tvrtko). v4: -

[Intel-gfx] [PATCH v3 14/14] drm/i915/adls: s/ADLS_RPLS/RAPTORLAKE_S in platform and subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Driver refers to the platform Alderlake S as ADLS_RPLS in places and RAPTORLAKE_S in some. v2: - Unrolled wrapper IS_ADLS_GRAPHICS_STEP v3: - Replace IS_RAPTORLAKE_S instead of IS_ADLS_RPLS. (Tvrtko/Lucas). - Remove unused macro IS_ADLS_GRAPHICS/DISPLAY_STEP - Change the subject Cc: Tvrtko

[Intel-gfx] [PATCH v2 11/14] drm/i915/rplp: s/ADLP_RPLP/RAPTORLAKE_P for RPLP defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace ADLP with ALDERLAKE_P. v2: - Replace IS_ADLP_RPLP with IS_RAPTORLAKE_P. (Tvrtko/Lucas) - Change the subject Cc: Tvrtko Ursulin Cc: Jani Nikula Cc: Anusha Srivatsa Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/i915_drv.h | 2 +-

[Intel-gfx] [PATCH v3 10/14] drm/i915/adlp: s/ADLP/ALDERLAKE_P for display and graphics step

2023-07-26 Thread Dnyaneshwar Bhadane
Driver refers to the platform Alderlake P as ADLP in places and ALDERLAKE_P in some. Making the consistent change to avoid confusion of the right naming convention for the platform. v2: - Unrolled wrapper IS_ADLP_GRAPHICS_STEP and Replace - Added IS_ALDERLAKE_P() && IS_GRAPHICS_STEP()

[Intel-gfx] [PATCH v4 08/14] drm/i915/jsl: s/JSL/JASPERLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace JSL with JASPERLAKE. Unroll IS_JSL_EHL() define with IS_JASPERLAKE() || IS_ELKHARTLAKE() condition. Change in the display step define for Jasperlake. v2: - Change subject prefix skl instead of SKL(Anusha) v3: - Remove the use of define IS_JSL_EHL. -

[Intel-gfx] [PATCH v1 05/14] drm/i915/cfl: s/CFL/COFFEELAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace CFL with COFFEELAKE. Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h| 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH v4 06/14] drm/i915/cml: s/CML/COMETLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace CML with COMETLAKE. Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h| 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH v4 04/14] drm/i915/kbl: s/KBL/KABYLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace KBL with KABYLAKE.Replace IS_KBL_GRAPHICS_STEP with IS_KABYLAKE () && IS_GRAPHICS_STEP(). v2: - s/KBL/kbl in the subject prefix(Anusha) v3: - Unrolled wrapper IS_KBL_GRAPHICS_STEP. - Replace with IS_PLATFORM && DISPLAY_STEP(tvrtko/jani) v4: - Removed

[Intel-gfx] [PATCH v4 03/14] drm/i915/skl: s/SKL/SKYLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace SKL with SKYLAKE and Replace IS_SKL_GRAPHICS_STEP with IS_SKYLAKE() && IS_GRAPHICS_STEP(). v2: - Change subject skl instead of SKL(Anusha) v3: - Unrolled wrapper IS_SKL_GRAPHICS_STEP. - Replace with IS_PLATFORM && DISPLAY_STEP(tvrtko/jani) v4: -

[Intel-gfx] [PATCH v1 02/14] drm/i915/bdw: s/BDW/BROADWELL for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace BDW with BROADWELL. Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_cdclk.c | 4 ++-- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-

[Intel-gfx] [PATCH v4 00/14] Replace acronym with full platform name in defines.

2023-07-26 Thread Dnyaneshwar Bhadane
Replacing the acronym used in platform/sub platform defines. This series covers Haswell, Broadwell, Skylake, Kabylake, Coffeelake, Cometlake, Rocketlake, Jasperlake, Elkhartlake, Tigerlake, Alderlake, platform define.This way there is a consistent pattern to how platforms are referred.splitting

[Intel-gfx] [PATCH v1 01/14] drm/i915/hsw: s/HSW/HASWELL for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace HSW with HASWELL. Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c| 2 +- drivers/gpu/drm/i915/display/intel_display_device.h | 2 +-

Re: [Intel-gfx] [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-26 Thread Tejun Heo
Hello, On Wed, Jul 26, 2023 at 05:44:28PM +0100, Tvrtko Ursulin wrote: ... > > So, yeah, if you want to add memory controls, we better think through how > > the fd ownership migration should work. > > It would be quite easy to make the implicit migration fail - just the matter > of failing the

Re: [Intel-gfx] [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-26 Thread Tejun Heo
Hello, On Wed, Jul 26, 2023 at 12:14:24PM +0200, Maarten Lankhorst wrote: > > So, yeah, if you want to add memory controls, we better think through how > > the fd ownership migration should work. > > I've taken a look at the series, since I have been working on cgroup memory > eviction. > > The

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Replace acronym with full platform name in defines.

2023-07-26 Thread Patchwork
== Series Details == Series: Replace acronym with full platform name in defines. URL : https://patchwork.freedesktop.org/series/121385/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/121385/revisions/1/mbox/ not applied Applying: drm/i915/hsw:

[Intel-gfx] [PATCH v1 13/14] drm/i915/adln: s/ADLP/ALDERLAKE_P in ADLN defines

2023-07-26 Thread Dnyaneshwar Bhadane
From: Anusha Srivatsa Follow consistent naming convention. Replace ADLP with ALDERLAKE_P Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c| 2 +- drivers/gpu/drm/i915/i915_drv.h | 2 +-

[Intel-gfx] [PATCH v3 14/14] drm/i915/adls: s/ADLS_RPLS/RAPTORLAKE_S in platform and subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Driver refers to the platform Alderlake S as ADLS_RPLS in places and RAPTORLAKE_S in some. v2: - Unrolled wrapper IS_ADLS_GRAPHICS_STEP v3: - Replace IS_RAPTORLAKE_S instead of IS_ADLS_RPLS. (Tvrtko/Lucas). - Remove unused macro IS_ADLS_GRAPHICS/DISPLAY_STEP - Change the subject Cc: Tvrtko

[Intel-gfx] [PATCH v3 10/14] drm/i915/adlp: s/ADLP/ALDERLAKE_P for display and graphics step

2023-07-26 Thread Dnyaneshwar Bhadane
Driver refers to the platform Alderlake P as ADLP in places and ALDERLAKE_P in some. Making the consistent change to avoid confusion of the right naming convention for the platform. v2: - Unrolled wrapper IS_ADLP_GRAPHICS_STEP and Replace - Added IS_ALDERLAKE_P() && IS_GRAPHICS_STEP()

[Intel-gfx] [PATCH v4 09/14] drm/i915/tgl: s/TGL/TIGERLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace TGL with TIGERLAKE.Replace IS_TGL_DISPLAY_STEP with IS_TIGERLAKE() && IS_DISPLAY_STEP(). v2: - s/TGL/tgl in the subject prefix(Anusha) v3: - Unrolled wrapper IS_TGL_DISPLAY_STEP and Replace - Replace IS_PLATFORM && DISPLAY_STEP (Jani/Tvrtko). v4: -

[Intel-gfx] [PATCH v4 08/14] drm/i915/jsl: s/JSL/JASPERLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace JSL with JASPERLAKE. Unroll IS_JSL_EHL() define with IS_JASPERLAKE() || IS_ELKHARTLAKE() condition. Change in the display step define for Jasperlake. v2: - Change subject prefix skl instead of SKL(Anusha) v3: - Remove the use of define IS_JSL_EHL. -

[Intel-gfx] [PATCH v2 12/14] drm/i915/rplu: s/ADLP_RPLU/RAPTORLAKE_U in RPLU defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace ADLP with ALDERLAKE_P v2: - Replace IS_ADLP_RPLU with IS_RAPTORLAKE_U (Tvrtko/Lucas) - Change the subject Cc: Tvrtko Ursulin Cc: Jani Nikula Cc: Anusha Srivatsa Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_cdclk.c |

[Intel-gfx] [PATCH v1 05/14] drm/i915/cfl: s/CFL/COFFEELAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace CFL with COFFEELAKE. Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h| 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH v2 11/14] drm/i915/rplp: s/ADLP_RPLP/RAPTORLAKE_P for RPLP defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace ADLP with ALDERLAKE_P. v2: - Replace IS_ADLP_RPLP with IS_RAPTORLAKE_P. (Tvrtko/Lucas) - Change the subject Cc: Tvrtko Ursulin Cc: Jani Nikula Cc: Anusha Srivatsa Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/i915_drv.h | 2 +-

[Intel-gfx] [PATCH v4 03/14] drm/i915/skl: s/SKL/SKYLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace SKL with SKYLAKE and Replace IS_SKL_GRAPHICS_STEP with IS_SKYLAKE() && IS_GRAPHICS_STEP(). v2: - Change subject skl instead of SKL(Anusha) v3: - Unrolled wrapper IS_SKL_GRAPHICS_STEP. - Replace with IS_PLATFORM && DISPLAY_STEP(tvrtko/jani) v4: -

[Intel-gfx] [PATCH v1 06/14] drm/i915/cml: s/CML/COMETLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace CML with COMETLAKE. Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h| 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH v4 04/14] drm/i915/kbl: s/KBL/KABYLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace KBL with KABYLAKE.Replace IS_KBL_GRAPHICS_STEP with IS_KABYLAKE () && IS_GRAPHICS_STEP(). v2: - s/KBL/kbl in the subject prefix(Anusha) v3: - Unrolled wrapper IS_KBL_GRAPHICS_STEP. - Replace with IS_PLATFORM && DISPLAY_STEP(tvrtko/jani) v4: - Removed

[Intel-gfx] [PATCH v3 07/14] drm/i915/rkl: s/RKL/ROCKETLAKE for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace RKL with ROCKETLAKE.Replace IS_RKL_GRAPHICS_STEP with IS_ROCKETLAKE && IS_DISPLAY_STEP. v2: - s/RKL/rkl in the subject prefix(Anusha) v3: - Unrolled wrapper IS_RKL_DISPLAY_STEP. - Replace IS_PLATFORM && IS_DISPLAY_STEP (Jani/Tvrtko) Cc: Tvrtko

[Intel-gfx] [PATCH v1 02/14] drm/i915/bdw: s/BDW/BROADWELL for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace BDW with BROADWELL. Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_cdclk.c | 4 ++-- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +-

[Intel-gfx] [PATCH v1 01/14] drm/i915/hsw: s/HSW/HASWELL for platform/subplatform defines

2023-07-26 Thread Dnyaneshwar Bhadane
Follow consistent naming convention. Replace HSW with HASWELL. Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c| 2 +- drivers/gpu/drm/i915/display/intel_display_device.h | 2 +-

[Intel-gfx] [PATCH v4 00/14] Replace acronym with full platform name in defines.

2023-07-26 Thread Dnyaneshwar Bhadane
Replacing the acronym used in platform/sub platform defines. This series covers Haswell, Broadwell, Skylake, Kabylake, Coffeelake, Cometlake, Rocketlake, Jasperlake, Elkhartlake, Tigerlake, Alderlake, platoform define.This way there is a consistent pattern to how platforms are referred.splitting

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev8)

2023-07-26 Thread Patchwork
== Series Details == Series: drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev8) URL : https://patchwork.freedesktop.org/series/117713/ State : success == Summary == CI Bug Log - changes from CI_DRM_13426 -> Patchwork_117713v8

Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

2023-07-26 Thread Simon Ser
On Monday, July 24th, 2023 at 23:14, Michał Winiarski wrote: > Having a limit of 64 DRM devices is not good enough for modern world > where we have multi-GPU servers, SR-IOV virtual functions and virtual > devices used for testing. > Let's utilize full minor range for DRM devices. > To avoid

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests (rev7)

2023-07-26 Thread Teres Alexis, Alan Previn
> IGT changes > Possible regressions > > * igt@vgem_basic@dmabuf-fence-before: > * fi-kbl-soraka: > PASS > -> >

Re: [Intel-gfx] [PATCH i-g-t 3/3] gputop: Add memory information

2023-07-26 Thread Kamil Konieczny
Hi Tvrtko, On 2023-07-05 at 17:31:05 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Show total and resident memory usage for clients which support it. > > For simplicity all memory regions are summed up and shown under a single > heading. > > Co-developed-by: Rob Clark >

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_drm_fdinfo: Parse memory usage

2023-07-26 Thread Kamil Konieczny
Hi Tvrtko, please check your patches with Linux kernel script checkpatch.pl Some of it's warnings seems strange, like: WARNING: Co-developed-by and Signed-off-by: name/email do not match #12: Co-developed-by: Rob Clark Signed-off-by: Tvrtko Ursulin On 2023-07-05 at 17:31:03 +0100, Tvrtko

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib/igt_drm_clients: Store memory info in the client

2023-07-26 Thread Kamil Konieczny
Hi Tvrtko, On 2023-07-05 at 17:31:04 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Define the storage structure and copy over memory data as parsed by the > fdinfo helpers. > > Signed-off-by: Tvrtko Ursulin > Cc: Rob Clark > --- > lib/igt_drm_clients.c | 31

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection

2023-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection URL : https://patchwork.freedesktop.org/series/121373/ State : success == Summary == CI Bug Log - changes from CI_DRM_13426 -> Patchwork_121373v1

Re: [Intel-gfx] [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-26 Thread Tvrtko Ursulin
On 21/07/2023 23:21, Tejun Heo wrote: On Wed, Jul 12, 2023 at 12:46:04PM +0100, Tvrtko Ursulin wrote: $ cat drm.memory.stat card0 region=system total=12898304 shared=0 active=0 resident=12111872 purgeable=167936 card0 region=stolen-system total=0 shared=0 active=0 resident=0

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection

2023-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection URL : https://patchwork.freedesktop.org/series/121373/ State : warning == Summary == Error: dim checkpatch failed dd84f9f99c63 drm/i915/gt: Simplify

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection

2023-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection URL : https://patchwork.freedesktop.org/series/121373/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Invalidate secondary IOMMU TLB on permission upgrade

2023-07-26 Thread Patchwork
== Series Details == Series: Invalidate secondary IOMMU TLB on permission upgrade URL : https://patchwork.freedesktop.org/series/121355/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/121355/revisions/1/mbox/ not applied Applying: arm64/smmu: Use

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Regression in linux-next

2023-07-26 Thread Patchwork
== Series Details == Series: Regression in linux-next URL : https://patchwork.freedesktop.org/series/121356/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/121356/revisions/1/mbox/ not applied Applying: Regression in linux-next Using index info

[Intel-gfx] [PATCH 2/3] drm/i915: Make i915_coherent_map_type GT-centric

2023-07-26 Thread Jonathan Cavitt
Refactor i915_coherent_map_type to be GT-centric rather than device-centric. Each GT may require different coherency handling due to hardware workarounds. Since the function now takes a GT instead of the i915, the function is renamed and moved to the gt folder. Suggested-by: Matt Roper

[Intel-gfx] [PATCH 3/3] drm/i915/gt: Apply workaround 22016122933 correctly

2023-07-26 Thread Jonathan Cavitt
WA_22016122933 was recently applied to all MeteorLake engines, which is simultaneously too broad (should only apply to Media engines) and too specific (should apply to all platforms that use the same media engine as MeteorLake). Correct this in cases where coherency settings are modified. There

[Intel-gfx] [PATCH 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection

2023-07-26 Thread Jonathan Cavitt
The object pin created for shmem_create_from_object is just a single use mapping with the sole purpose of reading the contents of the whole object in bulk. And the whole source object is also even a throw-away. Ergo, the additional logic required by i915_coherent_map_type can be safely dropped

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Add getter/setter for i915_gem_object->frontbuffer

2023-07-26 Thread Nirmoy Das
Hi Jouni, On 5/29/2023 8:27 AM, Jouni Högander wrote: Add getter/setter for i915_gem_object->frontbuffer and use it instead of directly touching i915_gem_object->frontbuffer frontbuffer pointer. Signed-off-by: Jouni Högander --- .../gpu/drm/i915/display/intel_frontbuffer.c | 18 ++---

Re: [Intel-gfx] [PATCH v15 00/26] Add vfio_device cdev for iommufd support

2023-07-26 Thread Jason Gunthorpe
On Tue, Jul 25, 2023 at 12:00:09PM -0600, Alex Williamson wrote: > On Mon, 24 Jul 2023 13:09:22 -0600 > Alex Williamson wrote: > > > On Tue, 18 Jul 2023 13:57:46 -0300 > > Jason Gunthorpe wrote: > > > > > On Tue, Jul 18, 2023 at 06:55:25AM -0700, Yi Liu wrote: > > > > Existing VFIO provides

Re: [Intel-gfx] [PATCH] drm/i915: Do not disable preemption for resets

2023-07-26 Thread Sebastian Andrzej Siewior
On 2023-07-05 10:30:25 [+0100], Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit ade8a0f59844 ("drm/i915: Make all GPU resets atomic") added a > preempt disable section over the hardware reset callback to prepare the > driver for being able to reset from atomic contexts. > … This looks

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use the i915_vma_flush_writes helper (rev6)

2023-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Use the i915_vma_flush_writes helper (rev6) URL : https://patchwork.freedesktop.org/series/121122/ State : success == Summary == CI Bug Log - changes from CI_DRM_13423_full -> Patchwork_121122v6_full

[Intel-gfx] [PATCH v4 1/5] arm64/smmu: Use TLBI ASID when invalidating entire range

2023-07-26 Thread Alistair Popple
The ARM SMMU has a specific command for invalidating the TLB for an entire ASID. Currently this is used for the IO_PGTABLE API but not for ATS when called from the MMU notifier. The current implementation of notifiers does not attempt to invalidate such a large address range, instead walking each

[Intel-gfx] [PATCH v4 2/5] mmu_notifiers: Fixup comment in mmu_interval_read_begin()

2023-07-26 Thread Alistair Popple
The comment in mmu_interval_read_begin() refers to a function that doesn't exist and uses the wrong call-back name. The op for mmu interval notifiers is mmu_interval_notifier_ops->invalidate() so fix the comment up to reflect that. Signed-off-by: Alistair Popple Reviewed-by: Jason Gunthorpe ---

[Intel-gfx] [PATCH v4 5/5] mmu_notifiers: Rename invalidate_range notifier

2023-07-26 Thread Alistair Popple
There are two main use cases for mmu notifiers. One is by KVM which uses mmu_notifier_invalidate_range_start()/end() to manage a software TLB. The other is to manage hardware TLBs which need to use the invalidate_range() callback because HW can establish new TLB entries at any time. Hence using

Re: [Intel-gfx] [PATCH v2] drm/i915/tv: avoid possible division by zero

2023-07-26 Thread Su Hui
On 2023/7/25 13:51, Dan Carpenter wrote: The reason why the first five attempts had bugs is because we are trying to write it in the most complicated way possible, shifting by logical not what? Wonderful! Should I add your name as signed-of-by? I will send a v3 patch later. Really thanks for

Re: [Intel-gfx] Regression in linux-next

2023-07-26 Thread Alistair Popple
Thanks Chaitanya for the detailed report. Dan Carpenter also reported a Smatch warning for this: https://lore.kernel.org/linux-mm/38ed0627-1283-4da2-827a-e90484d7bd7d@moroto.mountain/ The below should fix the problem, will respin the series to include the fix. --- diff --git

Re: [Intel-gfx] [PATCH v2] drm/i915/tv: avoid possible division by zero

2023-07-26 Thread Su Hui
On 2023/7/25 01:35, Andi Shyti wrote: On Tue, Jul 18, 2023 at 09:32:17AM +0800, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1, then division by zero will happen. Fixes:

[Intel-gfx] [PATCH v4 0/5] Invalidate secondary IOMMU TLB on permission upgrade

2023-07-26 Thread Alistair Popple
The main change is to move secondary TLB invalidation mmu notifier callbacks into the architecture specific TLB flushing functions. This makes secondary TLB invalidation mostly match CPU invalidation while still allowing efficient range based invalidations based on the existing TLB batching code.

[Intel-gfx] [PATCH v4 4/5] mmu_notifiers: Don't invalidate secondary TLBs as part of mmu_notifier_invalidate_range_end()

2023-07-26 Thread Alistair Popple
Secondary TLBs are now invalidated from the architecture specific TLB invalidation functions. Therefore there is no need to explicitly notify or invalidate as part of the range end functions. This means we can remove mmu_notifier_invalidate_range_end_only() and some of the ptep_*_notify()

Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

2023-07-26 Thread James Zhu
On 2023-07-24 17:14, Michał Winiarski wrote: Having a limit of 64 DRM devices is not good enough for modern world where we have multi-GPU servers, SR-IOV virtual functions and virtual devices used for testing. Let's utilize full minor range for DRM devices. To avoid regressing the existing

[Intel-gfx] [PATCH v4 3/5] mmu_notifiers: Call invalidate_range() when invalidating TLBs

2023-07-26 Thread Alistair Popple
The invalidate_range() is going to become an architecture specific mmu notifier used to keep the TLB of secondary MMUs such as an IOMMU in sync with the CPU page tables. Currently it is called from separate code paths to the main CPU TLB invalidations. This can lead to a secondary TLB not getting

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the i915_vma_flush_writes helper (rev6)

2023-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Use the i915_vma_flush_writes helper (rev6) URL : https://patchwork.freedesktop.org/series/121122/ State : success == Summary == CI Bug Log - changes from CI_DRM_13423 -> Patchwork_121122v6 Summary

Re: [Intel-gfx] [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-26 Thread Tvrtko Ursulin
On 26/07/2023 11:14, Maarten Lankhorst wrote: Hey, On 2023-07-22 00:21, Tejun Heo wrote: On Wed, Jul 12, 2023 at 12:46:04PM +0100, Tvrtko Ursulin wrote:    $ cat drm.memory.stat    card0 region=system total=12898304 shared=0 active=0 resident=12111872 purgeable=167936    card0

[Intel-gfx] ✗ Fi.CI.IGT: failure for Update AUX invalidation sequence (rev13)

2023-07-26 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev13) URL : https://patchwork.freedesktop.org/series/119798/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13423_full -> Patchwork_119798v13_full Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use the i915_vma_flush_writes helper (rev5)

2023-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Use the i915_vma_flush_writes helper (rev5) URL : https://patchwork.freedesktop.org/series/121122/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13423 -> Patchwork_121122v5 Summary

Re: [Intel-gfx] [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-26 Thread Maarten Lankhorst
Hey, On 2023-07-22 00:21, Tejun Heo wrote: On Wed, Jul 12, 2023 at 12:46:04PM +0100, Tvrtko Ursulin wrote: $ cat drm.memory.stat card0 region=system total=12898304 shared=0 active=0 resident=12111872 purgeable=167936 card0 region=stolen-system total=0 shared=0 active=0 resident=0

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Use the i915_vma_flush_writes helper (rev4)

2023-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Use the i915_vma_flush_writes helper (rev4) URL : https://patchwork.freedesktop.org/series/121122/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13423 -> Patchwork_121122v4 Summary

Re: [Intel-gfx] [PATCH dii-client 1/2] drm/i915: Make i915_coherent_map_type GT-centric

2023-07-26 Thread Tvrtko Ursulin
On 25/07/2023 18:39, Cavitt, Jonathan wrote: -Original Message- From: Tvrtko Ursulin Sent: Tuesday, July 25, 2023 9:23 AM To: Cavitt, Jonathan ; intel-gfx@lists.freedesktop.org Cc: Shyti, Andi ; Roper, Matthew D ; chris.p.wil...@linux.intel.com; Das, Nirmoy Subject: Re: [Intel-gfx]

[Intel-gfx] ✓ Fi.CI.BAT: success for Update AUX invalidation sequence (rev13)

2023-07-26 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev13) URL : https://patchwork.freedesktop.org/series/119798/ State : success == Summary == CI Bug Log - changes from CI_DRM_13423 -> Patchwork_119798v13 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update AUX invalidation sequence (rev13)

2023-07-26 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev13) URL : https://patchwork.freedesktop.org/series/119798/ State : warning == Summary == Error: dim checkpatch failed 83c202cba4ad drm/i915/gt: Cleanup aux invalidation registers 24756b4dcb54 drm/i915: Add the

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Update AUX invalidation sequence (rev13)

2023-07-26 Thread Patchwork
== Series Details == Series: Update AUX invalidation sequence (rev13) URL : https://patchwork.freedesktop.org/series/119798/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH dii-client 2/2] drm/i915/gt: Apply workaround 22016122933 correctly

2023-07-26 Thread Yang, Fei
> Subject: [PATCH dii-client 2/2] drm/i915/gt: Apply workaround 22016122933 > correctly Remove dii-client from the subject. Otherwise LGTM. Acked-by: Fei Yang > WA_22016122933 was recently applied to all MeteorLake engines, > which is simultaneously too broad (should only apply to Media >

Re: [Intel-gfx] [PATCH dii-client 1/2] drm/i915: Make i915_coherent_map_type GT-centric

2023-07-26 Thread Yang, Fei
> Refactor i915_coherent_map_type to be GT-centric rather than > device-centric. Each GT may require different coherency handling > due to hardware workarounds. > > Since the function now takes a GT instead of the i915, the function > is renamed and moved to the gt folder. Remove dii-client in

[Intel-gfx] ✓ Fi.CI.IGT: success for MTL Degamma implementation (rev3)

2023-07-26 Thread Patchwork
== Series Details == Series: MTL Degamma implementation (rev3) URL : https://patchwork.freedesktop.org/series/119844/ State : success == Summary == CI Bug Log - changes from CI_DRM_13419_full -> Patchwork_119844v3_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/hotplug: Reduce SHPD_FILTER to 250us

2023-07-26 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of > Shankar, > Uma > Sent: Thursday, July 20, 2023 3:41 PM > To: Kandpal, Suraj ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/hotplug: Reduce SHPD_FILTER to 250us > > > > > -Original Message-

[Intel-gfx] ✗ Fi.CI.IGT: failure for MTL Degamma implementation (rev3)

2023-07-26 Thread Patchwork
== Series Details == Series: MTL Degamma implementation (rev3) URL : https://patchwork.freedesktop.org/series/119844/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13419_full -> Patchwork_119844v3_full Summary ---