Re: [Intel-gfx] [RESEND 0/2] drm/i915/uncore: unclaimed reg debug race fix

2023-08-02 Thread Jani Nikula
On Tue, 01 Aug 2023, Jani Nikula wrote: > Resend of the first two patches of [1], dropping the third. Pushed to din. > > BR, > Jani. > > [1] https://patchwork.freedesktop.org/series/120167/ > > Jani Nikula (2): > drm/i915/uncore: split unclaimed_reg_debug() to header and footer > drm/i915/un

Re: [Intel-gfx] [PULL] gvt-fixes

2023-08-02 Thread Tvrtko Ursulin
On 02/08/2023 06:54, Zhenyu Wang wrote: Hi, Here is one gvt fix for bug in AUX CH register message length get. Please help to pick. Pulled, thank you! Regards, Tvrtko Thanks! -- The following changes since commit e354f67733115b4453268f61e6e072e9b1ea7a2f: drm/i915: Fix an error handl

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Move stolen memory handling into i915_gem_stolen

2023-08-02 Thread Nirmoy Das
On 8/1/2023 10:33 AM, Hogander, Jouni wrote: On Tue, 2023-08-01 at 10:02 +0200, Nirmoy Das wrote: Hi Jouni, On 6/14/2023 7:17 AM, Jouni Högander wrote: We are preparing for Xe. Xe stolen memory handling differs from i915 so we want to move stolen memory handling details into i915_gem_stolen.

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Move stolen memory handling into i915_gem_stolen

2023-08-02 Thread Hogander, Jouni
On Wed, 2023-08-02 at 09:51 +0200, Nirmoy Das wrote: > > On 8/1/2023 10:33 AM, Hogander, Jouni wrote: > > On Tue, 2023-08-01 at 10:02 +0200, Nirmoy Das wrote: > > > Hi Jouni, > > > > > > On 6/14/2023 7:17 AM, Jouni Högander wrote: > > > > We are preparing for Xe. Xe stolen memory handling differs

Re: [Intel-gfx] [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-02 Thread Neil Armstrong
On 29/07/2023 02:49, Dmitry Baryshkov wrote: If the created connector type supports subconnector type property, create and attach corresponding it. The default subtype value is 0, which maps to the DRM_MODE_SUBCONNECTOR_Unknown type. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bri

Re: [Intel-gfx] [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-02 Thread Dmitry Baryshkov
On Wed, 2 Aug 2023 at 11:35, Neil Armstrong wrote: > > On 29/07/2023 02:49, Dmitry Baryshkov wrote: > > If the created connector type supports subconnector type property, > > create and attach corresponding it. The default subtype value is 0, > > which maps to the DRM_MODE_SUBCONNECTOR_Unknown typ

[Intel-gfx] [PATCH v2] drm/modes: Fix division by zero error

2023-08-02 Thread Ziqi Zhao
In the bug reported by Syzbot, the variable `den == (1 << 22)` and `mode->vscan == (1 << 10)`, causing the multiplication to overflow and accidentally make `den == 0`. To prevent any chance of overflow, we replace `num` and `den` with 64-bit unsigned integers, and explicitly check if the divisor `d

[Intel-gfx] [PATCH] drm/i915/xelpd: Calculate first_line_bpg_offset for DSC 1.1

2023-08-02 Thread William Tseng
This change is required for DSC 1.1 because the current calculation is for DSC 1.2 and may get a calculated value which is not recommended by DSC 1.1, for example, the calculated value at 8bpp becomes 15, not the value of 12 recommened by DSC 1.1. Cc: Ankit Nautiyal Cc: Juha-Pekka Heikkil Signed

Re: [Intel-gfx] [PATCH] drm/i915/xelpd: Calculate first_line_bpg_offset for DSC 1.1

2023-08-02 Thread Kandpal, Suraj
1.1 > > This change is required for DSC 1.1 because the current calculation is for DSC > 1.2 and may get a calculated value which is not recommended by DSC 1.1, for > example, the calculated value at 8bpp becomes 15, not the value of 12 > recommened by DSC 1.1. > > Cc: Ankit Nautiyal > Cc: Juha-

Re: [Intel-gfx] [PATCH] drm/i915/xelpd: Calculate first_line_bpg_offset for DSC 1.1

2023-08-02 Thread Nautiyal, Ankit K
On 8/2/2023 4:45 PM, Kandpal, Suraj wrote: 1.1 This change is required for DSC 1.1 because the current calculation is for DSC 1.2 and may get a calculated value which is not recommended by DSC 1.1, for example, the calculated value at 8bpp becomes 15, not the value of 12 recommened by DSC 1.1.

Re: [Intel-gfx] [PATCH 08/20] drm/display/dp: Fix the DP DSC Receiver cap size

2023-08-02 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:38AM +0530, Ankit Nautiyal wrote: > DP DSC Receiver Capabilities are exposed via DPCD 60h-6Fh. > Fix the DSC RECEIVER CAP SIZE accordingly. > > Fixes: ffddc4363c28 ("drm/dp: Add DP DSC DPCD receiver capability size define > and missing SHIFT") > Cc: Anusha Srivatsa

Re: [Intel-gfx] [PATCH 09/20] drm/i915/dp: Avoid forcing DSC BPC for MST case

2023-08-02 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:39AM +0530, Ankit Nautiyal wrote: > For MST the bpc is hardcoded to 8, and pipe bpp to 24. > So avoid forcing DSC bpc for MST case. > > v2: Warn and ignore the debug flag than to bail out. (Jani) > > v3: Fix dbg message to mention forced bpc instead of bpp. > > v4:

Re: [Intel-gfx] [PATCH 10/20] drm/i915/dp: Add functions to get min/max src input bpc with DSC

2023-08-02 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:40AM +0530, Ankit Nautiyal wrote: > Separate out functions for getting maximum and minimum input BPC based > on platforms, when DSC is used. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 38 +++-- > 1 file ch

Re: [Intel-gfx] [PATCH] drm/i915/xelpd: Calculate first_line_bpg_offset for DSC 1.1

2023-08-02 Thread kernel test robot
Hi William, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next-fixes] [also build test ERROR on linus/master v6.5-rc4 next-20230802] [cannot apply to drm-tip/drm-tip drm-intel/for-linux-next] [If your patch is applied to the wrong git tree

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/modes: Fix division by zero error

2023-08-02 Thread Patchwork
== Series Details == Series: drm/modes: Fix division by zero error URL : https://patchwork.freedesktop.org/series/121879/ State : warning == Summary == Error: dim checkpatch failed 1beffd9a2b07 drm/modes: Fix division by zero error -:18: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be imm

Re: [Intel-gfx] [PATCH] drm/i915/xelpd: Calculate first_line_bpg_offset for DSC 1.1

2023-08-02 Thread kernel test robot
Hi William, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next-fixes] [also build test ERROR on linus/master v6.5-rc4 next-20230802] [cannot apply to drm-tip/drm-tip drm-intel/for-linux-next] [If your patch is applied to the wrong git tree

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/xelpd: Calculate first_line_bpg_offset for DSC 1.1

2023-08-02 Thread Patchwork
== Series Details == Series: drm/i915/xelpd: Calculate first_line_bpg_offset for DSC 1.1 URL : https://patchwork.freedesktop.org/series/121882/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drivers/gp

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/modes: Fix division by zero error

2023-08-02 Thread Patchwork
== Series Details == Series: drm/modes: Fix division by zero error URL : https://patchwork.freedesktop.org/series/121879/ State : success == Summary == CI Bug Log - changes from CI_DRM_13460 -> Patchwork_121879v1 Summary --- **SUCCES

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2023-08-02 Thread Doug Anderson
Hi, On Tue, Aug 1, 2023 at 9:17 PM Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/gpu/todo.rst:469: ERROR: Unexpected indentation. > > Introduced by commit > > d2aacaf07395 ("drm/panel: Chec

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2023-08-02 Thread Doug Anderson
Hi, On Tue, Aug 1, 2023 at 9:21 PM Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/drm/drm_panel.h:270: warning: Function parameter or member > 'follower_lock' not described in 'drm_panel' > > Intro

[Intel-gfx] [topic/core-for-ci] iommu/vt-d: Check domain flags before setting snp bit in page-control

2023-08-02 Thread Radhakrishna Sripada
From: Ashok Raj Check domain flags before setting snp bit in PTE. Signed-off-by: Ashok Raj Signed-off-by: Radhakrishna Sripada --- drivers/iommu/intel/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index 5c

[Intel-gfx] [CI] PR for PVC FWs for Xe

2023-08-02 Thread Daniele Ceraolo Spurio
The following changes since commit 253cc179d849fc82489773b2b553a49858d8725f: amdgpu: Update DMCUB for DCN314 & Yellow Carp (2023-07-31 11:22:02 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware xe_pvc for you to fetch changes up to 3b72a71413f8ef7

[Intel-gfx] ✓ Fi.CI.BAT: success for iommu/vt-d: Check domain flags before setting snp bit in page-control

2023-08-02 Thread Patchwork
== Series Details == Series: iommu/vt-d: Check domain flags before setting snp bit in page-control URL : https://patchwork.freedesktop.org/series/121893/ State : success == Summary == CI Bug Log - changes from CI_DRM_13462 -> Patchwork_121893v1 =

[Intel-gfx] [PATCH v4 1/1] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-08-02 Thread Alan Previn
After recent discussions with Mesa folks, it was requested that we optimize i915's GET_PARAM for the PXP_STATUS without changing the UAPI spec. Add these additional optimizations: - If any PXP initializatoin flow failed, then ensure that we catch it so that we can change the returned PXP_S

Re: [Intel-gfx] [PATCH] drm/i915/pxp/mtl: intel_pxp_init_hw needs runtime-pm inside pm-complete

2023-08-02 Thread Teres Alexis, Alan Previn
> > > > alan:snip Thanks Vinay and Daniele - i'll respin with below fix. > > @@ -48,7 +50,8 @@ void intel_pxp_resume_complete() > > if (!HAS_ENGINE(pxp->ctrl_gt, GSC0) && !pxp->pxp_component) > > return; > > > > - intel_pxp_init_hw(pxp); > > + with_intel_runtime_pm(&pxp-

Re: [Intel-gfx] [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-02 Thread Laurent Pinchart
On Wed, Aug 02, 2023 at 12:05:50PM +0300, Dmitry Baryshkov wrote: > On Wed, 2 Aug 2023 at 11:35, Neil Armstrong wrote: > > On 29/07/2023 02:49, Dmitry Baryshkov wrote: > > > If the created connector type supports subconnector type property, > > > create and attach corresponding it. The default subt

[Intel-gfx] [PATCH] drm/i915/guc: Fix potential null pointer deref in GuC 'steal id' test

2023-08-02 Thread John . C . Harrison
From: John Harrison It was noticed that if the very first 'stealing' request failed to create for some reason then the 'steal all ids' loop would immediately exit with 'last' still being NULL. The test would attempt to continue but using a null pointer. Fix that by aborting the test if it fails t

Re: [Intel-gfx] [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-02 Thread Dmitry Baryshkov
On 02/08/2023 21:46, Laurent Pinchart wrote: On Wed, Aug 02, 2023 at 12:05:50PM +0300, Dmitry Baryshkov wrote: On Wed, 2 Aug 2023 at 11:35, Neil Armstrong wrote: On 29/07/2023 02:49, Dmitry Baryshkov wrote: If the created connector type supports subconnector type property, create and attach co

Re: [Intel-gfx] [PATCH 1/4] drm: allow specifying default subtype for the DP subconnector property

2023-08-02 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:10AM +0300, Dmitry Baryshkov wrote: > In the embedded usecases the default subtype depends on the bridge > chain, so it is easier to specify the subtype at the proprety attachment s/proprety/property/ > type rather than specifyin

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-02 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > To properly define the USB-C DP altmode connectors, add the USB > subconnector type. > > Suggested-by: Simon Ser > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_connector.c |

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-02 Thread Dmitry Baryshkov
On 02/08/2023 21:55, Laurent Pinchart wrote: Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: To properly define the USB-C DP altmode connectors, add the USB subconnector type. Suggested-by: Simon Ser Signed-off-by: Dmitry Baryshkov ---

Re: [Intel-gfx] [PATCH 1/4] drm: allow specifying default subtype for the DP subconnector property

2023-08-02 Thread Dmitry Baryshkov
On 02/08/2023 21:54, Laurent Pinchart wrote: Hi Dmitry, Thank you for the patch. On Sat, Jul 29, 2023 at 03:49:10AM +0300, Dmitry Baryshkov wrote: In the embedded usecases the default subtype depends on the bridge chain, so it is easier to specify the subtype at the proprety attachment s/pro

[Intel-gfx] [PATCH v2 1/1] drm/i915/pxp/mtl: intel_pxp_init_hw needs runtime-pm inside pm-complete

2023-08-02 Thread Alan Previn
In the case of failed suspend flow or cases where the kernel does not go into full suspend but goes from suspend_prepare back to resume_complete, we get called for a pm_complete but without runtime_pm guaranteed. Thus, ensure we take the runtime_pm when calling intel_pxp_init_hw from within intel_

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-02 Thread Laurent Pinchart
On Wed, Aug 02, 2023 at 10:01:19PM +0300, Dmitry Baryshkov wrote: > On 02/08/2023 21:55, Laurent Pinchart wrote: > > Hi Dmitry, > > > > Thank you for the patch. > > > > On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshkov wrote: > >> To properly define the USB-C DP altmode connectors, add t

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-02 Thread Dmitry Baryshkov
2 августа 2023 г. 22:13:51 GMT+03:00, Laurent Pinchart пишет: >On Wed, Aug 02, 2023 at 10:01:19PM +0300, Dmitry Baryshkov wrote: >> On 02/08/2023 21:55, Laurent Pinchart wrote: >> > Hi Dmitry, >> > >> > Thank you for the patch. >> > >> > On Sat, Jul 29, 2023 at 03:49:12AM +0300, Dmitry Baryshko

[Intel-gfx] [PATCH] drm/i915/perf: Determine context valid in OA reports

2023-08-02 Thread Umesh Nerlige Ramappa
When supporting OA for TGL, it was seen that the context valid bit in the report ID was not defined, however revisiting the spec seems to have this bit defined. The bit is used to determine if a context is valid on a context switch and is essential to determine active and idle periods for a context

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/1] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-08-02 Thread Patchwork
== Series Details == Series: series starting with [v4,1/1] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS URL : https://patchwork.freedesktop.org/series/121899/ State : success == Summary == CI Bug Log - changes from CI_DRM_13463 -> Patchwork_121899v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix potential null pointer deref in GuC 'steal id' test

2023-08-02 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix potential null pointer deref in GuC 'steal id' test URL : https://patchwork.freedesktop.org/series/121903/ State : success == Summary == CI Bug Log - changes from CI_DRM_13463 -> Patchwork_121903v1 =

Re: [Intel-gfx] [PATCH 1/4] drm/i915/cx0: Add intel_cx0_get_owned_lane_mask()

2023-08-02 Thread Taylor, Clinton A
On Tue, 2023-07-25 at 18:27 -0300, Gustavo Sousa wrote: > There are more parts of C10/C20 programming that need to take owned > lanes into account. Define the function intel_cx0_get_owned_lane_mask() > and use it. There will be new users of that function in upcoming > changes. > > BSpec: 64539 > S

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/1] drm/i915/pxp/mtl: intel_pxp_init_hw needs runtime-pm inside pm-complete

2023-08-02 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] drm/i915/pxp/mtl: intel_pxp_init_hw needs runtime-pm inside pm-complete URL : https://patchwork.freedesktop.org/series/121905/ State : success == Summary == CI Bug Log - changes from CI_DRM_13463 -> Patchwork_121905v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Determine context valid in OA reports (rev3)

2023-08-02 Thread Patchwork
== Series Details == Series: drm/i915/perf: Determine context valid in OA reports (rev3) URL : https://patchwork.freedesktop.org/series/119426/ State : success == Summary == CI Bug Log - changes from CI_DRM_13463 -> Patchwork_119426v3 Summa

[Intel-gfx] [PATCH v1 0/3] Resolve suspend-resume racing with GuC destroy-context-worker

2023-08-02 Thread Alan Previn
This series is the result of debugging issues root caused to races between the GuC's destroyed_worker_func being triggered vs repeating suspend-resume cycles with concurrent delayed fence signals for engine-freeing. The reproduction steps require that an app is created right before the start of th

[Intel-gfx] [PATCH v1 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-08-02 Thread Alan Previn
When suspending, add a timeout when calling intel_gt_pm_wait_for_idle else if we have a lost G2H event that holds a wakeref (which would be indicating of a bug elsewhere in the driver), we get to complete the suspend-resume cycle, albeit without all the lower power hw counters hitting its targets,

[Intel-gfx] [PATCH v1 2/3] drm/i915/guc: Close deregister-context race against CT-loss

2023-08-02 Thread Alan Previn
If we are at the end of suspend or very early in resume its possible an async fence signal could lead us to the execution of the context destruction worker (after the prior worker flush). Even if checking that the CT is enabled before calling destroyed_worker_func, guc_lrc_desc_unpin may still fai

[Intel-gfx] [PATCH v1 1/3] drm/i915/guc: Flush context destruction worker at suspend

2023-08-02 Thread Alan Previn
Suspend is not like reset, it can unroll, so we have to properly flush pending context-guc-id deregistrations to complete before we return from suspend calls. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 6 +- drivers/gpu/drm/i915/gt/uc/intel_guc_submiss

Re: [Intel-gfx] [PATCH v1 0/3] Resolve suspend-resume racing with GuC destroy-context-worker

2023-08-02 Thread Teres Alexis, Alan Previn
On Wed, 2023-08-02 at 16:34 -0700, Teres Alexis, Alan Previn wrote: > This series is the result of debugging issues root caused to > races between the GuC's destroyed_worker_func being triggered vs > repeating suspend-resume cycles with concurrent delayed > fence signals for engine-freeing. > > Th

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Resolve suspend-resume racing with GuC destroy-context-worker

2023-08-02 Thread Patchwork
== Series Details == Series: Resolve suspend-resume racing with GuC destroy-context-worker URL : https://patchwork.freedesktop.org/series/121916/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for Resolve suspend-resume racing with GuC destroy-context-worker

2023-08-02 Thread Patchwork
== Series Details == Series: Resolve suspend-resume racing with GuC destroy-context-worker URL : https://patchwork.freedesktop.org/series/121916/ State : success == Summary == CI Bug Log - changes from CI_DRM_13463 -> Patchwork_121916v1 Sum

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-08-02 Thread Iddamsetty, Aravind
On 27-07-2023 15:43, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use the newly added drm_print_memory_stats helper to show memory > utilisation of our objects in drm/driver specific fdinfo output. > > To collect the stats we walk the per memory regions object lists > and accumulate objec

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Add ability for tracking buffer objects per client

2023-08-02 Thread Iddamsetty, Aravind
On 27-07-2023 15:43, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In order to show per client memory usage lets add some infrastructure > which enables tracking buffer objects owned by clients. > > We add a per client list protected by a new per client lock and to support > delayed destru

[Intel-gfx] [PATCH v2] drm/i915/xelpd: Calculate first_line_bpg_offset for DSC 1.1

2023-08-02 Thread William Tseng
This change is required for DSC 1.1 because the current calculation is for DSC 1.2 and may get a calculated value which is not recommended by DSC 1.1, for example, the calculated value at 8bpp becomes 15, not the value of 12 recommened by DSC 1.1. v2: - change the if-condition from minor version 2