Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/tc: remove "fia" from intel_tc_port_fia_max_lane_count()

On Fri, Jul 21, 2023 at 02:11:21PM +0300, Luca Coelho wrote: It is irrelevant for the caller that the max lane count is being derived from a FIA register, so having "fia" in the function name is irrelevant. Rename the function accordingly. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/di

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/tc: rename mtl_tc_port_get_pin_assignment_mask()

On Wed, Aug 16, 2023 at 09:08:44AM +, Coelho, Luciano wrote: On Wed, 2023-08-16 at 08:13 +, Kandpal, Suraj wrote: > This function doesn't really return the pin assignment mask, but > the max lane > count derived from that. So rename the function to > mtl_tc_port_get_max_lane_count() to

Re: [Intel-gfx] [PATCH v3 0/4] drm/i915/tc: some clean-ups in max lane count handling code

On Fri, Jul 21, 2023 at 02:11:17PM +0300, Luca Coelho wrote: Hi, Here are four patches with some clean-ups in the code that handles the max lane count of Type-C connections. This is done mostly in preparation for a new way to read the pin assignments and lane count in future devices. In v2:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Remove unused POWER_DOMAIN_MODESET

== Series Details == Series: drm/i915/display: Remove unused POWER_DOMAIN_MODESET URL : https://patchwork.freedesktop.org/series/122593/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13534_full -> Patchwork_122593v1_full Su

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Improve BW management on shared display links

== Series Details == Series: drm/i915: Improve BW management on shared display links URL : https://patchwork.freedesktop.org/series/122589/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13534_full -> Patchwork_122589v1_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/color: cleanups and refactoring

== Series Details == Series: drm/i915/color: cleanups and refactoring URL : https://patchwork.freedesktop.org/series/122588/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13534_full -> Patchwork_122588v1_full Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for DSC misc fixes (rev8)

== Series Details == Series: DSC misc fixes (rev8) URL : https://patchwork.freedesktop.org/series/117662/ State : success == Summary == CI Bug Log - changes from CI_DRM_13533_full -> Patchwork_117662v8_full Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Dual refresh rate fastset fixes with VRR fastset (rev4)

== Series Details == Series: drm/i915/display: Dual refresh rate fastset fixes with VRR fastset (rev4) URL : https://patchwork.freedesktop.org/series/122252/ State : success == Summary == CI Bug Log - changes from CI_DRM_13536 -> Patchwork_122252v4

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner (rev2)

== Series Details == Series: series starting with [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner (rev2) URL : https://patchwork.freedesktop.org/series/122651/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libs

Re: [Intel-gfx] [PATCH] drm/i915/display: Remove unused POWER_DOMAIN_MODESET

On Thu, Aug 17, 2023 at 02:53:12PM -0300, Gustavo Sousa wrote: > That power domain became unused after commit 41b4c7fe72b6 ("drm/i915: > Disable DC states for all commits"). > > Signed-off-by: Gustavo Sousa Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display_power.c

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Dual refresh rate fastset fixes with VRR fastset (rev4)

== Series Details == Series: drm/i915/display: Dual refresh rate fastset fixes with VRR fastset (rev4) URL : https://patchwork.freedesktop.org/series/122252/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Dual refresh rate fastset fixes with VRR fastset (rev4)

== Series Details == Series: drm/i915/display: Dual refresh rate fastset fixes with VRR fastset (rev4) URL : https://patchwork.freedesktop.org/series/122252/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No

[Intel-gfx] [PATCH 3/3] drm/i915: Enable GGTT blitting in MTL

From: Nirmoy Das MTL can hang because of a HW bug while parallel reading/writing from/to LMEM/GTTMMADR BAR so try to reduce GGTT update related pci transactions with blitter command as recommended for Wa_22018444074. To issue blitter commands, the driver must be primed to receive requests. Maint

[Intel-gfx] [PATCH 2/3] drm/i915: Implement GGTT update method with blitter

From: Nirmoy Das Implement GGTT update method with blitter command, MI_UPDATE_GTT and install those handlers if a platform requires that. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 189 +++ 1 file changed, 189 insertions(+) diff --git a/driver

[Intel-gfx] [CI] drm/i915/gt: Refactor hangcheck selftest to use igt_spinner

From: Jonathan Cavitt The hangcheck live selftest contains duplicate declarations of some functions that already exist in igt_spinner.c, such as the creation and deconstruction of a spinning batch buffer (spinner) that hangs an engine. It's undesireable to have such code duplicated, as the requir

[Intel-gfx] [PATCH 1/3] drm/i915: Create a blitter context for GGTT updates

From: Nirmoy Das Create a separate blitter context if a platform requires GGTT updates using MI_UPDATE_GTT blitter command. Subsequent patch will introduce methods to update GGTT using this blitter context and MI_UPDATE_GTT blitter command. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/g

[Intel-gfx] [PATCH v4] drm/i915/display: Dual refresh rate fastset fixes with VRR fastset

Dual refresh rate (DRR) fastset seamlessly lets refresh rate throttle without needing a full modeset. However with the recent VRR fastset patches that got merged this logic was broken. This is broken because now with VRR fastset VRR parameters are calculated by default at the nominal refresh rate s

[Intel-gfx] ✗ Fi.CI.BAT: failure for Define a final failure state when link training fails

== Series Details == Series: Define a final failure state when link training fails URL : https://patchwork.freedesktop.org/series/122644/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13536 -> Patchwork_122644v1 Summary ---

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp_link_training: Add a final failing state to link training fallback

Thank you for the patch and all your work to improve the link training fallback logic and to correctly reflect the link status to the userspace. Chiming in some of the findings and this logic justification below so it will help the reviewers further. On Fri, Aug 18, 2023 at 10:02 AM Gil Dekel w

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Define a final failure state when link training fails

== Series Details == Series: Define a final failure state when link training fails URL : https://patchwork.freedesktop.org/series/122644/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Define a final failure state when link training fails

== Series Details == Series: Define a final failure state when link training fails URL : https://patchwork.freedesktop.org/series/122644/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.BAT: failure for Implement MBUS state changes according to spec

== Series Details == Series: Implement MBUS state changes according to spec URL : https://patchwork.freedesktop.org/series/122641/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13536 -> Patchwork_122641v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Implement MBUS state changes according to spec

== Series Details == Series: Implement MBUS state changes according to spec URL : https://patchwork.freedesktop.org/series/122641/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Implement MBUS state changes according to spec

== Series Details == Series: Implement MBUS state changes according to spec URL : https://patchwork.freedesktop.org/series/122641/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] [PATCH 3/3] drm/i915/dp_link_training: Emit a link-status=Bad uevent with trigger property

When a link-training attempt fails, emit a uevent to user space that includes the trigger property, which in this case will be link-statue=Bad. This will allow userspace to parse the uevent property and better understand the reason for the previous display configuration failure. Cc: Jani Nikula

[Intel-gfx] [PATCH 2/3] drm/i915/dp_link_training: Add a final failing state to link training fallback for MST

Currently, MST link training has no fallback whatsoever. This means that if an MST base connector fails to link-train once, the training completely fails, which makes this case significantly more common than a complete SST link training failure. Until MST fallback is fully implemented, this patch

[Intel-gfx] [PATCH 1/3] drm/i915/dp_link_training: Add a final failing state to link training fallback

Instead of silently giving up when all link-training fallback values are exhausted, this patch modifies the fallback's failure branch to reduces both max_link_lane_count and max_link_rate to zero (0) and continues to emit uevents until userspace stops attempting to modeset. By doing so, we ensure

[Intel-gfx] [PATCH 0/3] Define a final failure state when link training fails

Currently, when link training fails after all fallback values have been exhausted, the i915 driver seizes to send uevents to userspace. This leave userspace thinking that the last passing atomic commit was successful, and that all connectors (displays) are connected and operational, when in fact, t

[Intel-gfx] [PATCH 2/2] drm/i915: Implement vblank synchronized MBUS join changes

Currently we can't change MBUS join status without doing a modeset, because we are lacking mechanism to synchronize those with vblank. However then this means that we can't do a fastset, if there is a need to change MBUS join state. Fix that by implementing such change. We already call corresponden

[Intel-gfx] [PATCH 1/2] drm/i915: Update mbus in intel_dbuf_mbus_update and do it properly

According to BSpec we need to do correspondent MBUS updates before or after DBUF reallocation, depending on whether we are reducing or increasing amount of pipes(typical scenario is swithing between multiple and single displays). As of BSpec 49213 if we are swithing from multiple to single display

[Intel-gfx] [PATCH 0/2] Implement MBUS state changes according to spec

We were previsously updating MBUS/DBOX/DBUF CTL registers incorrectly, doing it in a single place, even though BSpec instructs to do it before or after DDB reallocation depending on the scenario, also we missed a vblank wait in one scenario, which forced us to use a full modeset in all cases when M

Re: [Intel-gfx] [PATCH 0/3] Get optimal audio frequency and channels

Hi, On Thu, 17 Aug 2023, Mitul Golani wrote: > Currently we do not check if there is enough bandwidth for > audio, and what channels and freq it can really support. > Also sometimes there can be HW constraints e.g. GLK where audio > channels supported are only 2. [...] > Mitul Golani (3): > drm

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/vma: constify unbind_fence_ops

== Series Details == Series: drm/i915/vma: constify unbind_fence_ops URL : https://patchwork.freedesktop.org/series/122627/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13536 -> Patchwork_122627v1 Summary --- **FAIL

Re: [Intel-gfx] [PATCH 02/17] drm/i915/dp: Track the pipe and link bpp limits separately

On Fri, Aug 18, 2023 at 11:24:26AM +0300, Kandpal, Suraj wrote: > [...] > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.h > > > b/drivers/gpu/drm/i915/display/intel_dp.h > > > index 22099de3ca458..a1789419c0d19 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp.h > > > +++ b/drivers/

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/vma: constify unbind_fence_ops

== Series Details == Series: drm/i915/vma: constify unbind_fence_ops URL : https://patchwork.freedesktop.org/series/122627/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/vma: constify unbind_fence_ops

== Series Details == Series: drm/i915/vma: constify unbind_fence_ops URL : https://patchwork.freedesktop.org/series/122627/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

Re: [Intel-gfx] [PATCH 02/17] drm/i915/dp: Track the pipe and link bpp limits separately

On Thu, Aug 17, 2023 at 07:27:24PM +0300, Jani Nikula wrote: > On Thu, 17 Aug 2023, Imre Deak wrote: > > A follow-up patch will need to limit the output link bpp both in the > > non-DSC and DSC configuration, so track the pipe and link bpp limits > > separately in the link_config_limits struct. >

[Intel-gfx] ✗ Fi.CI.BAT: failure for SDP split for DP-MST (rev2)

== Series Details == Series: SDP split for DP-MST (rev2) URL : https://patchwork.freedesktop.org/series/122460/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13536 -> Patchwork_122460v2 Summary --- **FAILURE** Ser

Re: [Intel-gfx] [PATCH] drm/i915: Add intel_pcode_probe

On Fri, Aug 18, 2023 at 11:32:27AM +0530, Sundaresan, Sujaritha wrote: > > On 8/18/2023 11:30 AM, Gupta, Anshuman wrote: > > > > > -Original Message- > > > From: Intel-gfx On Behalf Of > > > Sujaritha Sundaresan > > > Sent: Friday, August 18, 2023 8:16 AM > > > To: intel-gfx@lists.freede

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for SDP split for DP-MST (rev2)

== Series Details == Series: SDP split for DP-MST (rev2) URL : https://patchwork.freedesktop.org/series/122460/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for SDP split for DP-MST (rev2)

== Series Details == Series: SDP split for DP-MST (rev2) URL : https://patchwork.freedesktop.org/series/122460/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] [PATCH] drm/i915/vma: constify unbind_fence_ops

unbind_fence_ops can be const and placed in rodata. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c b/drivers/gpu/drm/i915/i915_vma_resource.c index 6ba7a7feceba.

[Intel-gfx] [PATCH v4 4/4] drm/i915/display: configure SDP split for DP-MST

Extend the SDP split audio config for DP-MST Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/display/intel_dp.h | 3 +++ drivers/gpu/drm/i915/display/intel_dp_mst.c | 21 - 3 files changed, 8 insertions(+),

[Intel-gfx] [PATCH v4 3/4] drm/i915/display: update intel_dp_has_audio to support MST

Modify intel_dp_has_audio to handle DP-MST as well. Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_dp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c ind

[Intel-gfx] [PATCH v4 2/4] drm/i915/display: combine DP audio compute config steps

Combine all DP audio configs into a single function Signed-off-by: Vinod Govindapillai --- drivers/gpu/drm/i915/display/intel_dp.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c in

[Intel-gfx] [PATCH v4 1/4] drm/i915/display: remove redundant parameter from sdp split update

The needed functionality can be performed using crtc_state here. Signed-off-by: Vinod Govindapillai Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_audio.c | 6 +++--- drivers/gpu/drm/i915/display/intel_audio.h | 3 +-- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- 3 files

[Intel-gfx] [PATCH v4 0/4] SDP split for DP-MST

SDP split config for DP-MST v2: Style changes and patch splits (Jani Nikula) v3: More style changes and reorder patches (Jani Nikula) v4: call sdp split register update before enable trancoder in MST Vinod Govindapillai (4): drm/i915/display: remove redundant parameter from sdp split update

Re: [Intel-gfx] [RESEND PATCH] drm/i915: constify pointers to hwmon_channel_info

On Thu, 25 May 2023, Jani Nikula wrote: > On Thu, 11 May 2023, Krzysztof Kozlowski > wrote: >> Statically allocated array of pointers to hwmon_channel_info can be made >> const for safety. > > Btw if you want to further make things const, the compound literals > defined by HWMON_CHANNEL_INFO() s

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

On 18/08/2023 09:24, Simon Ser wrote: On Thursday, August 17th, 2023 at 21:33, Dmitry Baryshkov wrote: We have been looking for a way to document that the corresponding DP port is represented by the USB connector on the device. Consequently, I believe the best way to document it, would be to

Re: [Intel-gfx] [PATCH 3/3] drm/i915/display: Add wrapper to Compute SAD

On Thu, 17 Aug 2023, Mitul Golani wrote: > Compute SADs that takes into account the supported rate > and channel based on the capabilities of the audio source. > This wrapper function should encapsulate the logic for > determining the supported rate and channel and should > return a set of SADs th

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Handle legacy cursor update as normal update

amic subtest all-pipes The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20230818/202308181627.2fec1157-oliver.s...@intel.com -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

Re: [Intel-gfx] [PATCH 02/17] drm/i915/dp: Track the pipe and link bpp limits separately

> > On Thu, 17 Aug 2023, Imre Deak wrote: > > A follow-up patch will need to limit the output link bpp both in the > > non-DSC and DSC configuration, so track the pipe and link bpp limits > > separately in the link_config_limits struct. > > > > Use .4 fixed point format for link bpp matching the

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: add lock while printing frontbuffer tracking bits to debugfs (rev2)

== Series Details == Series: drm/i915/display: add lock while printing frontbuffer tracking bits to debugfs (rev2) URL : https://patchwork.freedesktop.org/series/122429/ State : success == Summary == CI Bug Log - changes from CI_DRM_13530_full -> Patchwork_122429v2_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/display/dp: Fix the DP DSC Receiver cap size

== Series Details == Series: drm/display/dp: Fix the DP DSC Receiver cap size URL : https://patchwork.freedesktop.org/series/122612/ State : success == Summary == CI Bug Log - changes from CI_DRM_13535 -> Patchwork_122612v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/display/dp: Fix the DP DSC Receiver cap size

== Series Details == Series: drm/display/dp: Fix the DP DSC Receiver cap size URL : https://patchwork.freedesktop.org/series/122612/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/display/dp: Fix the DP DSC Receiver cap size

== Series Details == Series: drm/display/dp: Fix the DP DSC Receiver cap size URL : https://patchwork.freedesktop.org/series/122612/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or directory