[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Invalidate the TLBs on each GT

2023-10-02 Thread Patchwork
== Series Details == Series: drm/i915: Invalidate the TLBs on each GT URL : https://patchwork.freedesktop.org/series/124528/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13702_full -> Patchwork_124528v1_full Summary

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm tree

2023-10-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_drv.h between commits: c9517783060a ("drm/i915/dg2: Drop Wa_16011777198") 5a213086a025 ("drm/i915: Eliminate IS_MTL_GRAPHICS_STEP") 81af8abe6513 ("drm/i915: Eliminate IS_MTL_MEDIA_STEP")

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-02 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines URL : https://patchwork.freedesktop.org/series/124535/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13702 -> Patchwork_124535v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-02 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines URL : https://patchwork.freedesktop.org/series/124535/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-02 Thread Patchwork
== Series Details == Series: series starting with [v3,1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines URL : https://patchwork.freedesktop.org/series/124535/ State : warning == Summary == Error: dim checkpatch failed bedea6a0f331 drm/i915: Define and use GuC and CTB TLB

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Invalidate the TLBs on each GT

2023-10-02 Thread Patchwork
== Series Details == Series: drm/i915: Invalidate the TLBs on each GT URL : https://patchwork.freedesktop.org/series/124528/ State : success == Summary == CI Bug Log - changes from CI_DRM_13702 -> Patchwork_124528v1 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Block in cleanup for legacy cursor updates

2023-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Block in cleanup for legacy cursor updates URL : https://patchwork.freedesktop.org/series/124519/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13702 -> Patchwork_124519v1

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Block in cleanup for legacy cursor updates

2023-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Block in cleanup for legacy cursor updates URL : https://patchwork.freedesktop.org/series/124519/ State : warning == Summary == Error: dim checkpatch failed 73442a8a986f drm/i915: Block in cleanup for legacy cursor updates

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Block in cleanup for legacy cursor updates

2023-10-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Block in cleanup for legacy cursor updates URL : https://patchwork.freedesktop.org/series/124519/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.BAT: failure for sysctl: Remove sentinel elements from drivers (rev2)

2023-10-02 Thread Patchwork
== Series Details == Series: sysctl: Remove sentinel elements from drivers (rev2) URL : https://patchwork.freedesktop.org/series/124409/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13700 -> Patchwork_124409v2 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: nuke i915->gt0

2023-10-02 Thread Patchwork
== Series Details == Series: drm/i915: nuke i915->gt0 URL : https://patchwork.freedesktop.org/series/124508/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13700 -> Patchwork_124508v1 Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-02 Thread Rodrigo Vivi
On Mon, Oct 02, 2023 at 07:58:30PM +0300, Jani Nikula wrote: > On Mon, 02 Oct 2023, Rodrigo Vivi wrote: > > On Mon, Oct 02, 2023 at 10:41:14AM +0300, Jani Nikula wrote: > >> On Fri, 29 Sep 2023, Rodrigo Vivi wrote: > >> > The goal is to have this function ready for Xe to use > >> > directly. So,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: nuke i915->gt0

2023-10-02 Thread Patchwork
== Series Details == Series: drm/i915: nuke i915->gt0 URL : https://patchwork.freedesktop.org/series/124508/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix rb-tree/llist/list confusion (rev4)

2023-10-02 Thread Patchwork
== Series Details == Series: drm/i915: fix rb-tree/llist/list confusion (rev4) URL : https://patchwork.freedesktop.org/series/123282/ State : success == Summary == CI Bug Log - changes from CI_DRM_13700 -> Patchwork_123282v4 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: fix rb-tree/llist/list confusion (rev4)

2023-10-02 Thread Patchwork
== Series Details == Series: drm/i915: fix rb-tree/llist/list confusion (rev4) URL : https://patchwork.freedesktop.org/series/123282/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix rb-tree/llist/list confusion (rev4)

2023-10-02 Thread Patchwork
== Series Details == Series: drm/i915: fix rb-tree/llist/list confusion (rev4) URL : https://patchwork.freedesktop.org/series/123282/ State : warning == Summary == Error: dim checkpatch failed 1a14c2ee81d7 drm/i915: Register engines early to avoid type confusion -:40: ERROR:BAD_SIGN_OFF:

[Intel-gfx] [PATCH v3 1/4] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-02 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back

[Intel-gfx] [PATCH v3 4/4] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-02 Thread Jonathan Cavitt
For the gt_tlb live selftest, increase the timeout from 10 ms to 200 ms. 200 ms should be more than enough time, and 10 ms was too aggressive. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/selftest_tlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v3 2/4] drm/i915: No TLB invalidation on wedged or suspended GT

2023-10-02 Thread Jonathan Cavitt
From: Fei Yang In case of GT is suspended or wedged, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John

[Intel-gfx] [PATCH v3 3/4] drm/i915: Perform TLB invalidation on all GTs during suspend/resume

2023-10-02 Thread Jonathan Cavitt
Consider multi-gt support when cancelling all tlb invalidations on suspend, and when submitting tlb invalidations on resume. Suggested-by: Tvrtko Ursulin Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison --- drivers/gpu/drm/i915/i915_driver.c | 13 + 1 file

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Kees Cook
On Mon, Oct 02, 2023 at 08:11:41PM +0200, Christian König wrote: > Am 02.10.23 um 20:08 schrieb Kees Cook: > > On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: > > > Am 02.10.23 um 18:53 schrieb Kees Cook: > > > > On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: > > >

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 02.10.23 um 20:08 schrieb Kees Cook: On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: Am 02.10.23 um 18:53 schrieb Kees Cook: On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: Am 29.09.23 um 21:33 schrieb

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Kees Cook
On Mon, Oct 02, 2023 at 08:01:57PM +0200, Christian König wrote: > Am 02.10.23 um 18:53 schrieb Kees Cook: > > On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: > > > On Mon, Oct 2, 2023 at 5:20 AM Christian König > > > wrote: > > > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > > > >

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 02.10.23 um 18:53 schrieb Kees Cook: On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: Am 29.09.23 um 21:33 schrieb Kees Cook: On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: This is a batch of patches touching drm

Re: [Intel-gfx] [PATCH 0/3] drm/i915: nuke i915->gt0

2023-10-02 Thread Michał Winiarski
On Mon, Oct 02, 2023 at 04:04:51PM +0200, Andi Shyti wrote: > Hi Jani, > > adding a few folks in Cc for some extra eyes on this series. > > On Mon, Oct 02, 2023 at 11:47:01AM +0300, Jani Nikula wrote: > > Chopping up [1] to more digestable pieces. Start off with nuking > > i915->gt0. > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-02 Thread Jani Nikula
On Mon, 02 Oct 2023, Rodrigo Vivi wrote: > On Mon, Oct 02, 2023 at 10:41:14AM +0300, Jani Nikula wrote: >> On Fri, 29 Sep 2023, Rodrigo Vivi wrote: >> > The goal is to have this function ready for Xe to use >> > directly. So, let's use the available macro. >> >> Seesm wrong to use

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Kees Cook
On Mon, Oct 02, 2023 at 11:06:19AM -0400, Alex Deucher wrote: > On Mon, Oct 2, 2023 at 5:20 AM Christian König > wrote: > > > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > > >> This is a batch of patches touching drm for preparing for the

Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-02 Thread Rodrigo Vivi
On Mon, Oct 02, 2023 at 10:41:14AM +0300, Jani Nikula wrote: > On Fri, 29 Sep 2023, Rodrigo Vivi wrote: > > The goal is to have this function ready for Xe to use > > directly. So, let's use the available macro. > > Seesm wrong to use DISPLAY_INFO() as an lvalue to be really honestly I don't

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Alex Deucher
On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > >> This is a batch of patches touching drm for preparing for the coming > >> implementation by GCC and Clang of the __counted_by attribute.

Re: [Intel-gfx] [PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Nirmoy Das
Hi Andi, On 10/2/2023 3:45 PM, Andi Shyti wrote: Hi Nirmoy, On Mon, Oct 02, 2023 at 02:20:32PM +0200, Nirmoy Das wrote: Don't return early if one of the GT doesn't require any flushing. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Cc: Chris Wilson Cc: Fei Yang Cc: Mauro

Re: [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

2023-10-02 Thread Nirmoy Das
+dri-devel On 10/2/2023 4:07 PM, Jonathan Cavitt wrote: From: Chris Wilson With multi-GT devices, the object may have been bound on each GT and so we need to invalidate the TLBs across all GT before releasing the pages back to the system. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs

Re: [Intel-gfx] [PATCH 0/3] drm/i915: nuke i915->gt0

2023-10-02 Thread Andi Shyti
Hi Jani, > adding a few folks in Cc for some extra eyes on this series. > > On Mon, Oct 02, 2023 at 11:47:01AM +0300, Jani Nikula wrote: > > Chopping up [1] to more digestable pieces. Start off with nuking > > i915->gt0. > > > > [1] https://patchwork.freedesktop.org/series/124418/ > > > > Jani

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: remove i915->gt0 in favour of i915->gt[0]

2023-10-02 Thread Gustavo Sousa
Quoting Jani Nikula (2023-10-02 05:47:04-03:00) >Since gt0 == i915->gt[0], just drop the former. > >Signed-off-by: Jani Nikula Reviewed-by: Gustavo Sousa >--- > drivers/gpu/drm/i915/gt/intel_gt.c | 4 +--- > drivers/gpu/drm/i915/i915_drv.h | 8 +--- >

Re: [Intel-gfx] [PATCH 2/3] drm/i915: allocate i915->gt0 dynamically

2023-10-02 Thread Gustavo Sousa
Quoting Jani Nikula (2023-10-02 05:47:03-03:00) >Convert i915->gt0 to a pointer, and allocate it dynamically. > >Signed-off-by: Jani Nikula Reviewed-by: Gustavo Sousa >--- > drivers/gpu/drm/i915/gt/intel_gt.c | 8 +++- > drivers/gpu/drm/i915/i915_drv.h| 8 > 2 files changed, 11

[Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT

2023-10-02 Thread Jonathan Cavitt
From: Chris Wilson With multi-GT devices, the object may have been bound on each GT and so we need to invalidate the TLBs across all GT before releasing the pages back to the system. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Signed-off-by: Chris Wilson Signed-off-by:

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Invalidate the TLBs on each GT

2023-10-02 Thread Andi Shyti
Hi Jonathan, On Fri, Sep 29, 2023 at 01:18:37PM -0700, Jonathan Cavitt wrote: > From: Chris Wilson > > With multi-GT devices, the object may have been bound on each GT and so > we need to invalidate the TLBs across all GT before releasing the pages > back to the system. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 1/3] drm/i915/mocs: use to_gt() instead of direct >gt

2023-10-02 Thread Gustavo Sousa
Quoting Jani Nikula (2023-10-02 05:47:02-03:00) >Have to give up the const on i915 pointer, but it's not big of a deal What if patch #2 ("drm/i915: allocate i915->gt0 dynamically") was the first in the series? I see it changes to_gt() to receive a const struct drm_i915_private *i915. Either way,

Re: [Intel-gfx] [PATCH 0/3] drm/i915: nuke i915->gt0

2023-10-02 Thread Andi Shyti
Hi Jani, adding a few folks in Cc for some extra eyes on this series. On Mon, Oct 02, 2023 at 11:47:01AM +0300, Jani Nikula wrote: > Chopping up [1] to more digestable pieces. Start off with nuking > i915->gt0. > > [1] https://patchwork.freedesktop.org/series/124418/ > > Jani Nikula (3): >

Re: [Intel-gfx] [PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Andi Shyti
Hi Nirmoy, On Mon, Oct 02, 2023 at 02:20:32PM +0200, Nirmoy Das wrote: > Don't return early if one of the GT doesn't require > any flushing. > > Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") > Cc: Chris Wilson > Cc: Fei Yang > Cc: Mauro Carvalho Chehab > Cc: Andi Shyti >

[Intel-gfx] PR for MTL DMC v2.17

2023-10-02 Thread Gustavo Sousa
The following changes since commit 8b855f3797e6b1d207b7a2b8dae0e9913f907e5b: Merge branch 'main' into 'main' (2023-09-26 18:31:16 +) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware dmc-mtl_2.17 for you to fetch changes up to

Re: [Intel-gfx] [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Phillip Potter
On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados > > > > > > This commit comes at the tail end of a

Re: [Intel-gfx] [PATCH v2] drm/i915: Warn on if set frontbuffer return value is not NULL on release

2023-10-02 Thread Gustavo Sousa
Quoting Jani Nikula (2023-10-02 04:08:40-03:00) >On Fri, 29 Sep 2023, Gustavo Sousa wrote: >> Quoting Jani Nikula (2023-09-28 04:43:13-03:00) >>>On Thu, 28 Sep 2023, Jouni Högander wrote: i915_gem_object_set_frontbuffer returns set frontbuffer pointer. When we are releasing

Re: [Intel-gfx] [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Christophe Leroy
Link to v1: > https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com > > Comments/feedback greatly appreciated Same problem on powerpc CI tests, all boot target failed, most of them with similar OOPS, see https://patchwork.ozlabs.org/pro

[Intel-gfx] [PATCH] drm/i915: Invalidate all GTs in flush_tlb_invalidate()

2023-10-02 Thread Nirmoy Das
Don't return early if one of the GT doesn't require any flushing. Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT") Cc: Chris Wilson Cc: Fei Yang Cc: Mauro Carvalho Chehab Cc: Andi Shyti Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Nirmoy Das

[Intel-gfx] [PATCH 2/2] drm/i915: Use drm_atomic_helper_update_plane for cursor updates

2023-10-02 Thread maarten . lankhorst
From: Maarten Lankhorst Regular path should be fast enough, even for i915. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_cursor.c | 146 +--- 1 file changed, 1 insertion(+), 145 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c

[Intel-gfx] [PATCH 1/2] drm/i915: Block in cleanup for legacy cursor updates

2023-10-02 Thread maarten . lankhorst
From: Maarten Lankhorst On cursor updates we should never unpin before the cursor is no longer active. This means that we need to add a delay. The vblank worker may cancel certain updates, so we/ only use it as a barrier to see if a vblank has completed, and then wait for that in the cleanup

Re: [Intel-gfx] [PATCH v3] drm/i915/display/lspcon: Increase LSPCON mode settle timeout

2023-10-02 Thread Jani Nikula
On Wed, 16 Aug 2023, Pablo Ceballos wrote: > This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled", > followed by link training errors. Intel engineers recommended increasing > this timeout and that does resolve the issue. > > On some CometLake-based device designs the Parade

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Christian König
Am 29.09.23 um 21:33 schrieb Kees Cook: On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: This is a batch of patches touching drm for preparing for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their

Re: [Intel-gfx] [PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Christophe Leroy
Le 02/10/2023 à 10:47, Joel Granados a écrit : > On Thu, Sep 28, 2023 at 04:31:30PM +, Christophe Leroy wrote: > I followed this trace and proc_handler is correctly defined in tty_table > (struct ctl_table) in drivers/tty/tty_io.c:tty_init and there is not > path that changes these values.

Re: [Intel-gfx] [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Greg Kroah-Hartman
On Mon, Oct 02, 2023 at 08:47:53AM +, Christophe Leroy wrote: > > > Le 02/10/2023 à 10:17, Jiri Slaby a écrit : > > On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: > >> From: Joel Granados > >> > >> This commit comes at the tail end of a greater effort to remove the > >> empty

Re: [Intel-gfx] [PATCH v2 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Jiri Slaby
On 02. 10. 23, 10:55, Joel Granados via B4 Relay wrote: From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by

[Intel-gfx] [PATCH v2 09/15] char-misc: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 10/15] vrf: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 07/15] macintosh: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 14/15] Drivers: hv: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 08/15] infiniband: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 13/15] raid: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 15/15] intel drm: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 05/15] scsi: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 12/15] fw loader: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 11/15] sgi-xp: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 03/15] xen: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 06/15] parport: Remove the now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 02/15] hpet: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link :

[Intel-gfx] [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Joel Granados via B4 Relay
From: Joel Granados What? These commits remove the sentinel element (last empty element) from the sysctl arrays of all the files under the "drivers/" directory that use a sysctl array for registration. The merging of the preparation patches (in

Re: [Intel-gfx] [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Christophe Leroy
Le 02/10/2023 à 10:17, Jiri Slaby a écrit : > On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: >> From: Joel Granados >> >> This commit comes at the tail end of a greater effort to remove the >> empty elements at the end of the ctl_table arrays (sentinels) which >> will reduce the

[Intel-gfx] [PATCH 3/3] drm/i915/gt: remove i915->gt0 in favour of i915->gt[0]

2023-10-02 Thread Jani Nikula
Since gt0 == i915->gt[0], just drop the former. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_gt.c | 4 +--- drivers/gpu/drm/i915/i915_drv.h | 8 +--- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 - 3 files changed, 2 insertions(+), 11

[Intel-gfx] [PATCH 2/3] drm/i915: allocate i915->gt0 dynamically

2023-10-02 Thread Jani Nikula
Convert i915->gt0 to a pointer, and allocate it dynamically. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_gt.c | 8 +++- drivers/gpu/drm/i915/i915_drv.h| 8 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c

[Intel-gfx] [PATCH 1/3] drm/i915/mocs: use to_gt() instead of direct >gt

2023-10-02 Thread Jani Nikula
Have to give up the const on i915 pointer, but it's not big of a deal considering non-const i915 gets passed all over the place. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/gt/intel_mocs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 0/3] drm/i915: nuke i915->gt0

2023-10-02 Thread Jani Nikula
Chopping up [1] to more digestable pieces. Start off with nuking i915->gt0. [1] https://patchwork.freedesktop.org/series/124418/ Jani Nikula (3): drm/i915/mocs: use to_gt() instead of direct >gt drm/i915: allocate i915->gt0 dynamically drm/i915/gt: remove i915->gt0 in favour of i915->gt[0]

Re: [Intel-gfx] [PATCH 00/15] sysctl: Remove sentinel elements from drivers

2023-10-02 Thread Joel Granados
On Thu, Sep 28, 2023 at 04:31:30PM +, Christophe Leroy wrote: > > > Le 28/09/2023 à 15:21, Joel Granados via B4 Relay a écrit : > > From: Joel Granados > > Automatic test fails on powerpc, see >

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: No TLB invalidation on wedged or suspended GT

2023-10-02 Thread Tvrtko Ursulin
On 29/09/2023 21:18, Jonathan Cavitt wrote: From: Fei Yang In case of GT is suspended or wedged, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang

Re: [Intel-gfx] [PATCH i-g-t] tools/intel_gpu_top: Restore user friendly error message

2023-10-02 Thread Tvrtko Ursulin
On 29/09/2023 16:40, Umesh Nerlige Ramappa wrote: On Fri, Sep 29, 2023 at 12:09:49PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We have a nice error message displayed when an user with insufficient permissions tries to run the tool, but that got lost while Meteorlake support was

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: No TLB invalidation on wedged or suspended GT

2023-10-02 Thread Tvrtko Ursulin
On 02/10/2023 08:53, Jani Nikula wrote: On Fri, 29 Sep 2023, Jonathan Cavitt wrote: From: Fei Yang In case of GT is suspended or wedged, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or

Re: [Intel-gfx] [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Jiri Slaby
On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote: From: Joel Granados This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: add one header file for GT

2023-10-02 Thread Jani Nikula
On Fri, 29 Sep 2023, Jonathan Cavitt wrote: > From: Fei Yang > > Add a new header file for GT related Macros. > Move I915_MAX_GT to this new header file because it doesn't > belong to the i915 level. > > Suggested-by: Andi Shyti > Signed-off-by: Fei Yang > Signed-off-by: Jonathan Cavitt > CC:

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: No TLB invalidation on wedged or suspended GT

2023-10-02 Thread Jani Nikula
On Fri, 29 Sep 2023, Jonathan Cavitt wrote: > From: Fei Yang > > In case of GT is suspended or wedged, don't allow submission of new TLB > invalidation request and cancel all pending requests. The TLB entries > will be invalidated either during GuC reload or on system resume. > > Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe

2023-10-02 Thread Jani Nikula
On Fri, 29 Sep 2023, Rodrigo Vivi wrote: > The goal is to have this function ready for Xe to use > directly. So, let's use the available macro. Seesm wrong to use DISPLAY_INFO() as an lvalue, and I'm not sure why this wouldn't work as-is. But *shrug*. Reviewed-by: Jani Nikula for merging to

Re: [Intel-gfx] [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

2023-10-02 Thread Joel Granados
On Sat, Sep 30, 2023 at 05:52:17PM +0100, Phillip Potter wrote: > On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay > > > wrote: > > > >

Re: [Intel-gfx] [PATCH 2/5] drm/i915/fbc: Split plane stride checks per-platform

2023-10-02 Thread Govindapillai, Vinod
Thanks for clarifications.. This is now Reviewed-by: Vinod Govindapillai On Mon, 2023-10-02 at 10:02 +0300, Ville Syrjälä wrote: > On Sun, Oct 01, 2023 at 10:53:37AM +, Govindapillai, Vinod wrote: > > Hi Ville, > > > > > > On Thu, 2023-09-14 at 14:38 +0300, Ville Syrjala wrote: > > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Warn on if set frontbuffer return value is not NULL on release

2023-10-02 Thread Jani Nikula
On Fri, 29 Sep 2023, Gustavo Sousa wrote: > Quoting Jani Nikula (2023-09-28 04:43:13-03:00) >>On Thu, 28 Sep 2023, Jouni Högander wrote: >>> i915_gem_object_set_frontbuffer returns set frontbuffer pointer. When we >>> are releasing frontbuffer we are clearing the pointer from the object. Warn

Re: [Intel-gfx] [PATCH 2/5] drm/i915/fbc: Split plane stride checks per-platform

2023-10-02 Thread Ville Syrjälä
On Sun, Oct 01, 2023 at 10:53:37AM +, Govindapillai, Vinod wrote: > Hi Ville, > > > On Thu, 2023-09-14 at 14:38 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Carve up stride_is_valid() into per-platform variants to > > make it easier to see what limits are actually being

Re: [Intel-gfx] [PATCH] drm/i915/uapi: fix doc typos

2023-10-02 Thread Randy Dunlap
Hi-- On 10/1/23 23:47, Ville Syrjälä wrote: > On Sun, Oct 01, 2023 at 06:08:24PM -0700, Randy Dunlap wrote: >> Correct typo of "its". >> Add a comma for clarity. >> >> Signed-off-by: Randy Dunlap >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: Tvrtko Ursulin >> Cc:

Re: [Intel-gfx] [PATCH] MAINTAINERS: drm/ci: add entries for xfail files

2023-10-02 Thread neil . armstrong
On 19/09/2023 20:22, Helen Koike wrote: DRM CI keeps track of which tests are failing, flaking or being skipped by the ci in the expectations files. Add entries for those files to the corresponding driver maintainer, so they can be notified when they change. Signed-off-by: Helen Koike --- For

Re: [Intel-gfx] [PATCH 3/5] drm/i915/fbc: Split plane tiling checks per-platform

2023-10-02 Thread Ville Syrjälä
On Sun, Oct 01, 2023 at 11:00:44AM +, Govindapillai, Vinod wrote: > Hi Ville, > > On Thu, 2023-09-14 at 14:38 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Carve up tiling_is_valid() into per-platform variants to > > make it easier to see what limits are actually being

Re: [Intel-gfx] [PATCH] drm/i915/uapi: fix doc typos

2023-10-02 Thread Ville Syrjälä
On Sun, Oct 01, 2023 at 06:08:24PM -0700, Randy Dunlap wrote: > Correct typo of "its". > Add a comma for clarity. > > Signed-off-by: Randy Dunlap > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: intel-gfx@lists.freedesktop.org > Cc: Maarten Lankhorst >