[Intel-gfx] [PATCH v4 09/23] drm/i915/display: Move enable_dc module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 5 + drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/i915_params.c | 5

[Intel-gfx] [PATCH v4 08/23] drm/i915/display: Move vbt_sdvo_panel_type module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_bios.c | 2 +- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/i915_params.c | 4

[Intel-gfx] [PATCH v4 07/23] drm/i915/display: Move panel_use_ssc module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_panel.c | 4 ++-- drivers/gpu/drm/i915/i915_params.c |

[Intel-gfx] [PATCH v4 04/23] drm/i915/display: Move psr related module parameters under display

Move psr related module parameters under display. Also fix error in enable_psr2_sel_fetch module parameter descrtiption. It was saying disabled by default while it's vice versa. Also psr_safest_params was missing default value in description. This is now added. v2: - Fix enable_psr2_sel_fetch de

[Intel-gfx] [PATCH v4 06/23] drm/i915/display: Move lvds_channel_mode module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_lvds.c | 4 ++-- drivers/gpu/drm/i915/i915_params.c |

[Intel-gfx] [PATCH v4 05/23] drm/i915/display: Move vbt_firmware module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_opregion.c | 2 +- drivers/gpu/drm/i915/i915_params.c | 3 -

[Intel-gfx] [PATCH v4 03/23] drm/i915/display: Move enable_fbc module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 3 ++- drivers/gpu/drm/i915/display/intel_fbc.c

[Intel-gfx] [PATCH v4 02/23] drm/i915/display: Dump also display parameters

GPU error dump contained all module parameters. If we are moving display parameters to intel_display_params.[ch] they are not dumped into GPU error dump. This patch is adding moved display parameters back to GPU error dump. Display parameters are also included in i915_capabilities v2: Add paramete

[Intel-gfx] [PATCH v4 01/23] drm/i915/display: Add framework to add parameters specific to display

Currently all module parameters are handled by i915_param.c/h. This is a problem for display parameters when Xe driver is used. Add a mechanism to add parameters specific to the display. This is mainly copied from i915_[debugfs]_params.[ch]. Parameters are not yet moved. This is done by subsequent

[Intel-gfx] [PATCH v4 00/23] Framework for display parameters

Currently all module parameters are handled by i915_param.c/h. This is a problem for display parameters when Xe driver is used. This patch set adds a mechanism to add parameters specific to the display. This is mainly copied from existing i915 parameters implementation with some naming changes and

Re: [Intel-gfx] [PATCH 08/29] drm/dp: Add helpers to calculate the link BW overhead

Hi Imre, kernel test robot noticed the following build errors: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Imre-Deak/drm-dp_mst-Fix-fractional-DSC-bpp-handling/20231024-091920 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch

Re: [Intel-gfx] [PATCH 3/3] drm/i915/pmu: rearrange hrtimer pointer chasing

Hi Jani, On Mon, Oct 23, 2023 at 06:02:56PM +0300, Jani Nikula wrote: > Do the logical step of first getting from struct hrtimer to struct > i915_pmu, and then from struct i915_pmu to struct drm_i915_private, > instead of hrtimer->i915->pmu. > > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyt

Re: [Intel-gfx] [PATCH 2/3] drm/i915/pmu: add event_to_pmu() helper

Hi Jani, On Mon, Oct 23, 2023 at 06:02:55PM +0300, Jani Nikula wrote: > It's tedious to duplicate the container_of() everywhere. Add a helper. > > Also do the logical steps of first getting from struct perf_event to > struct i915_pmu, and then from struct i915_pmu to struct > drm_i915_private if

Re: [Intel-gfx] [PATCH 1/3] drm/i915/pmu: add pmu_to_i915() helper

Hi Jani, On Mon, Oct 23, 2023 at 06:02:54PM +0300, Jani Nikula wrote: > It's tedious to duplicate the container_of() everywhere. Add a helper. > > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH] drm/i915/gt: Use proper priority enum instead of 0

Hi Nirmoy, On Mon, Oct 23, 2023 at 02:13:05PM +0200, Nirmoy Das wrote: > I915_PRIORITY_NORMAL is 0 so use that instead for better > readability. > > Cc: John Harrison > Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

Hi Umesh, On Fri, Oct 20, 2023 at 08:24:41AM -0700, Umesh Nerlige Ramappa wrote: > When the driver unbinds, pmu is unregistered and i915->uabi_engines is > set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine > events, it issues a warn_on because engine lookup fails. > > All perf h

Re: [Intel-gfx] [PATCH v2 21/24] drm/i915/display: Move verbose_state_checks under display

On Tue, 2023-10-24 at 15:12 +0300, Jani Nikula wrote: > On Tue, 24 Oct 2023, Luca Coelho wrote: > > On Tue, 2023-10-24 at 08:22 +, Hogander, Jouni wrote: > > > On Mon, 2023-10-23 at 17:00 +0300, Luca Coelho wrote: > > > > On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: > > > > > Signe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Add Wa_14019821291 (rev2)

== Series Details == Series: drm/i915/mtl: Add Wa_14019821291 (rev2) URL : https://patchwork.freedesktop.org/series/125282/ State : success == Summary == CI Bug Log - changes from CI_DRM_13779 -> Patchwork_125282v2 Summary --- **SUCC

Re: [Intel-gfx] [PATCH v2 24/24] drm/i915/display: Use same permissions for enable_sagv as for rest

On Tue, 24 Oct 2023, Luca Coelho wrote: > On Tue, 2023-10-24 at 08:51 +, Hogander, Jouni wrote: >> On Mon, 2023-10-23 at 17:06 +0300, Luca Coelho wrote: >> > On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: >> > > Generally we have writable device parameters in debugfs. No need >> > >

Re: [Intel-gfx] [PATCH v2 21/24] drm/i915/display: Move verbose_state_checks under display

On Tue, 24 Oct 2023, Luca Coelho wrote: > On Tue, 2023-10-24 at 08:22 +, Hogander, Jouni wrote: >> On Mon, 2023-10-23 at 17:00 +0300, Luca Coelho wrote: >> > On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: >> > > Signed-off-by: Jouni Högander >> > > --- >> > >  drivers/gpu/drm/i915/d

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

Hi Umesh, On Thu, Oct 19, 2023 at 11:28:36AM -0700, Umesh Nerlige Ramappa wrote: > When the driver unbinds, pmu is unregistered and i915->uabi_engines is > set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine > events, it issues a warn_on because engine lookup fails. > > All perf h

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Add Wa_14019821291 (rev2)

== Series Details == Series: drm/i915/mtl: Add Wa_14019821291 (rev2) URL : https://patchwork.freedesktop.org/series/125282/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./drivers/gpu/drm/i915/intel_uncor

Re: [Intel-gfx] [PATCH v2] drm/i915/mcr: Hold GT forcewake during steering operations

Hi Matt, On Thu, Oct 19, 2023 at 10:02:42AM -0700, Matt Roper wrote: > The steering control and semaphore registers are inside an "always on" > power domain with respect to RC6. However there are some issues if > higher-level platform sleep states are entering/exiting at the same time > these reg

Re: [Intel-gfx] [RFC 0/3] drm/i915: split display from drm_i915_private and i915_drv.h

On Fri, 20 Oct 2023, Matt Roper wrote: > On Tue, Sep 26, 2023 at 08:15:40PM +0300, Jani Nikula wrote: >> We've been gradually separating display code from the rest of the i915 >> driver code over the past few years. We can't get much further than this >> without some more drastic changes. >> >> O

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mcr: Hold GT forcewake during steering operations (rev2)

== Series Details == Series: drm/i915/mcr: Hold GT forcewake during steering operations (rev2) URL : https://patchwork.freedesktop.org/series/125356/ State : success == Summary == CI Bug Log - changes from CI_DRM_13779 -> Patchwork_125356v2

Re: [Intel-gfx] [PATCH v3 13/23] drm/i915/display: Move enable_ips module parameter under display

On Tue, 2023-10-24 at 13:32 +0300, Jouni Högander wrote: > Move enable_ips module parameter under display and change it as boolean. > > v2: > - Change enable_ip as boolean > - Fix copy paste error (i915_param -> intel_display_param) > > Cc: Luca Coelho > > Signed-off-by: Jouni Högander > -

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

Hi Andrzej, On Mon, Oct 23, 2023 at 10:21:48PM +0200, Andrzej Hajda wrote: > From: Jonathan Cavitt > > Set copy engine arbitration into round robin mode > for part of Wa_16018031267 / Wa_16018063123 mitigation. > > Signed-off-by: Nirmoy Das > Signed-off-by: Jonathan Cavitt > Reviewed-by: Andr

Re: [Intel-gfx] [PATCH v3 04/23] drm/i915/display: Move psr related module parameters under display

On Tue, 2023-10-24 at 13:32 +0300, Jouni Högander wrote: > Move psr related module parameters under display. Also fix error in > enable_psr2_sel_fetch module parameter descrtiption. It was saying disabled > by default while it's vice versa. Also psr_safest_params was missing > default value in desc

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915/gt: add selftest to exercise WABB

Hi Andrzej, On Mon, Oct 23, 2023 at 10:21:47PM +0200, Andrzej Hajda wrote: > Test re-uses logic form indirect ctx BB selftest. > > Co-developed-by: Nirmoy Das > Co-developed-by: Jonathan Cavitt Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt > Signed-off-by: Andrzej Hajda Reviewe

Re: [Intel-gfx] [PATCH v4 2/4] drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123

Hi Andrzej, On Mon, Oct 23, 2023 at 10:21:46PM +0200, Andrzej Hajda wrote: > Apply WABB blit for Wa_16018031267 / Wa_16018063123. > > v3: drop unused enum definition > v4: move selftest to separate patch, use wa only on BCS0. > > Co-developed-by: Nirmoy Das > Co-developed-by: Jonathan Cavitt

Re: [Intel-gfx] [PATCH v2 24/24] drm/i915/display: Use same permissions for enable_sagv as for rest

On Tue, 2023-10-24 at 08:51 +, Hogander, Jouni wrote: > On Mon, 2023-10-23 at 17:06 +0300, Luca Coelho wrote: > > On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: > > > Generally we have writable device parameters in debugfs. No need > > > to allow writing module parameters. > > > > >

Re: [Intel-gfx] [PATCH v2 21/24] drm/i915/display: Move verbose_state_checks under display

On Tue, 2023-10-24 at 08:22 +, Hogander, Jouni wrote: > On Mon, 2023-10-23 at 17:00 +0300, Luca Coelho wrote: > > On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: > > > Signed-off-by: Jouni Högander > > > --- > > >  drivers/gpu/drm/i915/display/intel_display.h    | 2 +- > > >  driv

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Flush WC GGTT only on required platforms (rev10)

== Series Details == Series: drm/i915: Flush WC GGTT only on required platforms (rev10) URL : https://patchwork.freedesktop.org/series/125111/ State : success == Summary == CI Bug Log - changes from CI_DRM_13779 -> Patchwork_125111v10 Summa

[Intel-gfx] [PATCH v3 23/23] drm/i915/display: Move enable_dp_mst under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/i915_params.c |

[Intel-gfx] [PATCH v3 17/23] drm/i915/display: Move load_detect_test parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_crt.c| 4 ++-- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/i915_params.c |

[Intel-gfx] [PATCH v3 22/23] drm/i915/display: Move nuclear_pageflip under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_device.c | 2 +- drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/i915_params.c | 3 -

[Intel-gfx] [PATCH v3 18/23] drm/i915/display: Move force_reset_modeset_test parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_display_reset.c | 2 +- drivers/gpu/drm/i915/i915_params.c | 4

[Intel-gfx] [PATCH v3 20/23] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN

Also make module parameter as non writable. Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display.h | 2 +- drivers/gpu/drm/i915/i915_params.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH v3 19/23] drm/i915/display: Move disable_display parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_device.c | 3 ++- drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/i915_params.c | 3

[Intel-gfx] [PATCH v3 21/23] drm/i915/display: Move verbose_state_checks under display

Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_display.h| 2 +- drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/i915_params.c | 3 --- drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v3 16/23] drm/i915/display: Move enable_dpcd_backlight module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- drivers/gpu/drm/i915/i915_params.c

[Intel-gfx] [PATCH v3 15/23] drm/i915/display: Move edp_vswing module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_bios.c | 4 ++-- drivers/gpu/drm/i915/display/intel_display_params.c | 6 ++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/i915_params.c

[Intel-gfx] [PATCH v3 14/23] drm/i915/display: Move invert_brightness module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_backlight.c | 9 + drivers/gpu/drm/i915/display/intel_display_params.c | 7 +++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/i915_params.c

[Intel-gfx] [PATCH v3 11/23] drm/i915/display: Move enable_sagv module parameter under display

Move enable_sagv module parameter under display and change the parameter permissions to non-writblase (0400) v2: Change permissions to 0400 Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ drivers/gpu/drm/i915/display/intel

[Intel-gfx] [PATCH v3 12/23] drm/i915/display: Move disable_power_well module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_display_power.c | 12 ++-- drivers/gpu/drm/i915/i915_params.c

[Intel-gfx] [PATCH v3 10/23] drm/i915/display: Move enable_dpt module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_dpt.c| 6 -- drivers/gpu/drm/i915/display/intel_fb.c |

[Intel-gfx] [PATCH v3 13/23] drm/i915/display: Move enable_ips module parameter under display

Move enable_ips module parameter under display and change it as boolean. v2: - Change enable_ip as boolean - Fix copy paste error (i915_param -> intel_display_param) Cc: Luca Coelho Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/hsw_ips.c | 4 ++-- drivers/gpu

[Intel-gfx] [PATCH v3 09/23] drm/i915/display: Move enable_dc module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 5 + drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- drivers/gpu/drm/i915/i915_params.c | 5

[Intel-gfx] [PATCH v3 08/23] drm/i915/display: Move vbt_sdvo_panel_type module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_bios.c | 2 +- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/i915_params.c | 4

[Intel-gfx] [PATCH v3 06/23] drm/i915/display: Move lvds_channel_mode module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_lvds.c | 4 ++-- drivers/gpu/drm/i915/i915_params.c |

[Intel-gfx] [PATCH v3 07/23] drm/i915/display: Move panel_use_ssc module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_panel.c | 4 ++-- drivers/gpu/drm/i915/i915_params.c |

[Intel-gfx] [PATCH v3 05/23] drm/i915/display: Move vbt_firmware module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ drivers/gpu/drm/i915/display/intel_display_params.h | 1 + drivers/gpu/drm/i915/display/intel_opregion.c | 2 +- drivers/gpu/drm/i915/i915_params.c | 3 -

[Intel-gfx] [PATCH v3 04/23] drm/i915/display: Move psr related module parameters under display

Move psr related module parameters under display. Also fix error in enable_psr2_sel_fetch module parameter descrtiption. It was saying disabled by default while it's vice versa. Also psr_safest_params was missing default value in description. This is now added. v2: - Fix enable_psr2_sel_fetch de

[Intel-gfx] [PATCH v3 03/23] drm/i915/display: Move enable_fbc module parameter under display

Signed-off-by: Jouni Högander Reviewed-by: Luca Coelho --- drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +- drivers/gpu/drm/i915/display/intel_display_params.c | 4 drivers/gpu/drm/i915/display/intel_display_params.h | 3 ++- drivers/gpu/drm/i915/display/intel_fbc.c

[Intel-gfx] [PATCH v3 00/23] Framework for display parameters

Currently all module parameters are handled by i915_param.c/h. This is a problem for display parameters when Xe driver is used. This patch set adds a mechanism to add parameters specific to the display. This is mainly copied from existing i915 parameters implementation with some naming changes and

[Intel-gfx] [PATCH v3 01/23] drm/i915/display: Add framework to add parameters specific to display

Currently all module parameters are handled by i915_param.c/h. This is a problem for display parameters when Xe driver is used. Add a mechanism to add parameters specific to the display. This is mainly copied from i915_[debugfs]_params.[ch]. Parameters are not yet moved. This is done by subsequent

[Intel-gfx] [PATCH v3 02/23] drm/i915/display: Dump also display parameters

GPU error dump contained all module parameters. If we are moving display parameters to intel_display_params.[ch] they are not dumped into GPU error dump. This patch is adding moved display parameters back to GPU error dump. Display parameters are also included in i915_capabilities v2: Add paramete

[Intel-gfx] [PATCH v2 23/29] drm/i915/dp_mst: Enable DSC passthrough

Enable passing through DSC streams to the sink in last branch devices. v2: - Fix the DPCD register address while setting/clearing the passthrough flag. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp.c | 26 - 1 file changed, 25 insertions(+), 1 dele

[Intel-gfx] [PATCH v2 22/29] drm/i915/dp: Enable DSC via the connector decompression AUX

Enable DSC using the DSC AUX device stored for this purpose in the connector. This prepares for a follow-up patch which toggles DSC for each stream as needed, but for now keeps the current behavior, as DSC is still only enabled for the first MST stream. While at it set/clear only the DP_DECOMPRESS

[Intel-gfx] [PATCH v2 08/29] drm/dp: Add helpers to calculate the link BW overhead

Add helpers drivers can use to calculate the BW allocation overhead - due to SSC, FEC, DSC and data alignment on symbol cycles - and the channel coding efficiency - due to the 8b/10b, 128b/132b encoding. On 128b/132b links the FEC overhead is part of the coding efficiency, so not accounted for in t

[Intel-gfx] [PATCH v2 07/29] drm/dp_mst: Add HBLANK expansion quirk for Synaptics MST hubs

Add a quirk for Synaptics MST hubs, which require a workaround - at leat on i915 - for some modes, on which the hub applies HBLANK expansion. These modes will only work by enabling DSC decompression for them, a follow-up patch will do this in i915. v2: - Fix the quirk name in its docbook descripti

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915: Reserve some kernel space per vm

Hi Andrzej, On Mon, Oct 23, 2023 at 10:21:45PM +0200, Andrzej Hajda wrote: > Reserve one page in each vm for kernel space to use for things > such as workarounds. > > v2: use real memory, do not decrease vm.total > v4: reserve only one page and explain flag > > Suggested-by: Chris Wilson > Sign

Re: [Intel-gfx] [PATCH v2 24/24] drm/i915/display: Use same permissions for enable_sagv as for rest

On Mon, 2023-10-23 at 17:06 +0300, Luca Coelho wrote: > On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: > > Generally we have writable device parameters in debugfs. No need > > to allow writing module parameters. > > > > Signed-off-by: Jouni Högander > > --- > >  drivers/gpu/drm/i915/dis

Re: [Intel-gfx] [PATCH] drm/i915/mcr: Hold GT forcewake during steering operations

On 10/19/2023 6:39 PM, Matt Roper wrote: The steering control and semaphore registers are inside an "always on" power domain with respect to RC6. However there are some issues if higher-level platform sleep states are entering/exiting at the same time these registers are accessed. Grabbing GT

Re: [Intel-gfx] [PATCH v2 21/24] drm/i915/display: Move verbose_state_checks under display

On Mon, 2023-10-23 at 17:00 +0300, Luca Coelho wrote: > On Mon, 2023-10-16 at 14:16 +0300, Jouni Högander wrote: > > Signed-off-by: Jouni Högander > > --- > >  drivers/gpu/drm/i915/display/intel_display.h    | 2 +- > >  drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++ > >  drivers/g

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915/gt: add selftest to exercise WABB

Hi Andrzej, On 10/23/2023 10:21 PM, Andrzej Hajda wrote: Test re-uses logic form indirect ctx BB selftest. Co-developed-by: Nirmoy Das You can remove above and add my Reviewed-by: Nirmoy Das for this patch. Co-developed-by should be followed by a signed-off. Same for the previous patch.

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123

On 10/23/2023 10:21 PM, Andrzej Hajda wrote: From: Jonathan Cavitt Set copy engine arbitration into round robin mode for part of Wa_16018031267 / Wa_16018063123 mitigation. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt Reviewed-by: Andrzej Hajda Reviewed-by: Nirmoy Das ---

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915: Reserve some kernel space per vm

On 10/23/2023 10:21 PM, Andrzej Hajda wrote: Reserve one page in each vm for kernel space to use for things such as workarounds. v2: use real memory, do not decrease vm.total v4: reserve only one page and explain flag Suggested-by: Chris Wilson Signed-off-by: Andrzej Hajda Reviewed-by: Jona

<    1   2