[Intel-gfx] ✗ Fi.CI.BAT: failure for Prepare intel_fb for Xe (rev3)

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev3) URL : https://patchwork.freedesktop.org/series/126507/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13885 -> Patchwork_126507v3 Summary --- **FAILURE**

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/i915: don't use uncore spinlock to protect critical section in vblank

2023-11-16 Thread Ville Syrjälä
On Thu, Nov 16, 2023 at 01:27:00PM +0200, Luca Coelho wrote: > Since we're abstracting the display code from the underlying driver > (i.e. i915 vs xe), we can't use the uncore's spinlock to protect > critical sections of our code. > > After further inspection, it seems that the spinlock is not nee

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use a different vblank worker for atomic unpin

2023-11-16 Thread Ville Syrjälä
On Thu, Nov 09, 2023 at 04:34:50PM +0100, Maarten Lankhorst wrote: > For the atomic codepath we unpin_work in old_plane_state to unpin the > old fb. As this happened after swapping state, this is allowed. > > Use the unpin_work only as a barrier, and keep doing the actual > unpinning in the atomic

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Use vblank worker to unpin old legacy cursor fb safely

2023-11-16 Thread Ville Syrjälä
On Thu, Nov 16, 2023 at 07:49:40AM +, Shankar, Uma wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of > > Maarten > > Lankhorst > > Sent: Thursday, November 9, 2023 9:05 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx] [PATCH 2/3] drm/i915: Use vbl

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Prepare intel_fb for Xe (rev3)

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev3) URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warn

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prepare intel_fb for Xe (rev3)

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev3) URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim checkpatch failed 4ea134ab3c7f drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c 5f89b4ae2e8a drm/i915/display: Convert intel_fb_modi

[Intel-gfx] [PATCH v3 3/3] drm/i915/display: Split i915 specific code away from intel_fb.c

2023-11-16 Thread Jouni Högander
We are preparing for Xe driver. Backing object implementation is differing between i915 and Xe. Split i915 specific code into separate source file built only for i915. v3: Fix failure handling in intel_framebuffer_init v2: Couple of fixes to error value handling Signed-off-by: Jouni Högander ---

[Intel-gfx] [PATCH v3 2/3] drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static

2023-11-16 Thread Jouni Högander
We are about to split i915 specific code from intel_fb.c. Convert intel_fb_modifier_to_tiling as non-static to allow calling it from split code. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fb.c | 40 - drivers/gpu/drm/i915/display/intel_fb.h | 2

[Intel-gfx] [PATCH v3 1/3] drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c

2023-11-16 Thread Jouni Högander
We are preparing for Xe driver. I915 and Xe object implementation are differing. Do not use i915_gem_object->base directly. Instead use intel_bo_to_drm_bo. Also use drm_gem_object_put instead of i915_gem_object_put. This should be ok as i915_gem_object_put is really just doing __drm_gem_object_p

[Intel-gfx] [PATCH v3 0/3] Prepare intel_fb for Xe

2023-11-16 Thread Jouni Högander
Intel fb creation is differing between Xe and i915 due to different implementations of backing object. This patch set is splitting i915 specific code into it's own source file. Similar source files will be introduced for Xe as well. Also use intel_bo_to_drm_bo instead of directly referring i915_ge

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v1,1/1] drm/i915/pxp: Bail early in pxp tee backend on first teardown error

2023-11-16 Thread Patchwork
== Series Details == Series: series starting with [v1,1/1] drm/i915/pxp: Bail early in pxp tee backend on first teardown error URL : https://patchwork.freedesktop.org/series/126559/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13885 -> Patchwork_126559v1

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-16 Thread Luben Tuikov
On 2023-11-16 04:22, Maxime Ripard wrote: > Hi, > > On Mon, Nov 13, 2023 at 09:56:32PM -0500, Luben Tuikov wrote: >> On 2023-11-13 21:45, Stephen Rothwell wrote: >>> Hi Luben, >>> >>> On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: On 2023-11-13 20:08, Luben Tuikov wrote: > O

Re: [Intel-gfx] [PATCH v2 04/11] drm/i915/dp: Replace intel_dp_is_uhbr_rate() with drm_dp_is_uhbr_rate()

2023-11-16 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Imre > Deak > Sent: Thursday, November 16, 2023 6:49 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH v2 04/11] drm/i915/dp: Replace > intel_dp_is_uhbr_rate() with drm_dp_is_uhbr_rate() > > Replace intel_dp_is_uhbr_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Update Wa_22018931422

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update Wa_22018931422 URL : https://patchwork.freedesktop.org/series/126554/ State : success == Summary == CI Bug Log - changes from CI_DRM_13885 -> Patchwork_126554v1 Summary --- **SUCCESS*

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/mtl: Update Wa_22018931422

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Update Wa_22018931422 URL : https://patchwork.freedesktop.org/series/126554/ State : warning == Summary == Error: dim checkpatch failed 2828e452ce71 drm/i915/mtl: Update Wa_22018931422 -:6: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per l

Re: [Intel-gfx] [PATCH v1 1/1] drm/i915/pxp: Bail early in pxp tee backend on first teardown error

2023-11-16 Thread Teres Alexis, Alan Previn
On Thu, 2023-11-16 at 15:20 -0800, Teres Alexis, Alan Previn wrote: > For Gen12 when using mei-pxp tee backend tranport, if we are coming > up from a cold boot or from a resume (not runtime resume), we can > optionally quicken the very first session cleanup that would occur > as part of starting up

[Intel-gfx] [PATCH v1 1/1] drm/i915/pxp: Bail early in pxp tee backend on first teardown error

2023-11-16 Thread Alan Previn
For Gen12 when using mei-pxp tee backend tranport, if we are coming up from a cold boot or from a resume (not runtime resume), we can optionally quicken the very first session cleanup that would occur as part of starting up a default PXP session. Typically a cleanup from a cold-start is expected to

[Intel-gfx] ✗ Fi.CI.BAT: failure for Test MTL DMC v2.19 (rev9)

2023-11-16 Thread Patchwork
== Series Details == Series: Test MTL DMC v2.19 (rev9) URL : https://patchwork.freedesktop.org/series/126497/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126497v9 Summary --- **FAILURE** Serio

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Also check for VGA converter in eDP probe (rev3)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915: Also check for VGA converter in eDP probe (rev3) URL : https://patchwork.freedesktop.org/series/126404/ State : success == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126404v3 Summar

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Update Wa_22018931422

2023-11-16 Thread Matt Roper
On Thu, Nov 16, 2023 at 01:25:11PM -0800, Radhakrishna Sripada wrote: > Commit 78cc55e0b64c ("drm/i915/mcr: Hold GT forcewake during steering > operations") > introduced the workaround which was in early stages. With a valid > lineage number update Workaround for future tracking. > > Cc: Matt Rop

[Intel-gfx] [PATCH] drm/i915/mtl: Update Wa_22018931422

2023-11-16 Thread Radhakrishna Sripada
Commit 78cc55e0b64c ("drm/i915/mcr: Hold GT forcewake during steering operations") introduced the workaround which was in early stages. With a valid lineage number update Workaround for future tracking. Cc: Matt Roper Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/gt/intel_gt_mcr

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev2) URL : https://patchwork.freedesktop.org/series/126538/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126538v2 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev2) URL : https://patchwork.freedesktop.org/series/126538/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev2) URL : https://patchwork.freedesktop.org/series/126538/ State : warning == Summary == Error: dim checkpatch failed 0d8793c8afbd drm/i915/display: Separate xe and

[Intel-gfx] [PATCH 1/1] [CI] drm/i915/dmc: Hardcode path to MTL DMC v2.19

2023-11-16 Thread Gustavo Sousa
NOT TO BE REVIEWED/MERGED Hardcode path to DMC firmware for CI purposes only. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH 0/1] [CI] Test MTL DMC v2.19

2023-11-16 Thread Gustavo Sousa
The following changes since commit 817619ea70a74598b4216dd25c0f49f61b09309b: [CI] i915: Add mtl DMC v2.19 (2023-11-15 19:36:22 -0300) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware 88364c11402c5a0cdb3a07530b76eef32882a54b for you to fetch changes up

[Intel-gfx] ✗ Fi.CI.BUILD: failure for DP DSC min/max src bpc fixes (rev4)

2023-11-16 Thread Patchwork
== Series Details == Series: DP DSC min/max src bpc fixes (rev4) URL : https://patchwork.freedesktop.org/series/125571/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/125571/revisions/4/mbox/ not applied Applying: drm/i915/dp: Simplify checks for

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vma: Fix VMA UAF on destroy against deactivate race (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/vma: Fix VMA UAF on destroy against deactivate race (rev2) URL : https://patchwork.freedesktop.org/series/126530/ State : success == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126530v2 ===

Re: [Intel-gfx] [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-16 Thread Alex Deucher
On Mon, Nov 13, 2023 at 3:55 PM Wolfram Sang wrote: > > > > We're not in a hurry. It's just my experience with patch series' affecting > > multiple subsystems that typically the decision was to apply the full > > series via one tree. Also to avoid inquires from maintainers like: > > Shall I take i

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4) URL : https://patchwork.freedesktop.org/series/125977/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_125977v4 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4) URL : https://patchwork.freedesktop.org/series/125977/ State : warning == Summary == Error: dim checkpatch failed 22cc49190b54 drm/i915/dsi: assume BXT gpio works for non-native GPIO c6f82321ce26 drm/i915/dsi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: move *_crtc_clock_get() to intel_dpll.c (rev3)

2023-11-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: move *_crtc_clock_get() to intel_dpll.c (rev3) URL : https://patchwork.freedesktop.org/series/126388/ State : success == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126388v3 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/3] drm/i915: move *_crtc_clock_get() to intel_dpll.c (rev3)

2023-11-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: move *_crtc_clock_get() to intel_dpll.c (rev3) URL : https://patchwork.freedesktop.org/series/126388/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: move *_crtc_clock_get() to intel_dpll.c (rev3)

2023-11-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: move *_crtc_clock_get() to intel_dpll.c (rev3) URL : https://patchwork.freedesktop.org/series/126388/ State : warning == Summary == Error: dim checkpatch failed 35cbbdaf6d00 drm/i915: move *_crtc_clock_get() to intel_dpll.c

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev8)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev8) URL : https://patchwork.freedesktop.org/series/126250/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126250v8 ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev8)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Remove dead code around intel_atomic_helper->free_list (rev8) URL : https://patchwork.freedesktop.org/series/126250/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separa

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix UHBR data, link M/N/TU and PBN values

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix UHBR data, link M/N/TU and PBN values URL : https://patchwork.freedesktop.org/series/126526/ State : success == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126526v1 Summary -

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

2023-11-16 Thread Jani Nikula
On Thu, 16 Nov 2023, Patchwork wrote: > == Series Details == > > Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2) > URL : https://patchwork.freedesktop.org/series/125977/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_13883 -> Patchwork_125977v2 > ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix UHBR data, link M/N/TU and PBN values

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix UHBR data, link M/N/TU and PBN values URL : https://patchwork.freedesktop.org/series/126526/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix UHBR data, link M/N/TU and PBN values

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix UHBR data, link M/N/TU and PBN values URL : https://patchwork.freedesktop.org/series/126526/ State : warning == Summary == Error: dim checkpatch failed e043aedaf8b4 drm/dp_mst: Store the MST PBN divider value in fixed point format -:41: WARNING:LONG_L

[Intel-gfx] ✗ Fi.CI.BAT: failure for Prepare intel_fb for Xe (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev2) URL : https://patchwork.freedesktop.org/series/126507/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126507v2 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Prepare intel_fb for Xe (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev2) URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warn

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prepare intel_fb for Xe (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe (rev2) URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim checkpatch failed 8ebe4445e6fd drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c beff2e6980ad drm/i915/display: Convert intel_fb_modi

[Intel-gfx] [PATCH 1/1] [CI] drm/i915/dmc: Hardcode path to MTL DMC v2.19

2023-11-16 Thread Gustavo Sousa
NOT TO BE REVIEWED/MERGED Hardcode path to DMC firmware for CI purposes only. Signed-off-by: Gustavo Sousa --- drivers/gpu/drm/i915/display/intel_dmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/in

[Intel-gfx] [PATCH 0/1] [CI] Test MTL DMC v2.19

2023-11-16 Thread Gustavo Sousa
The following changes since commit 44a9510c94ac0334931b6c89dd240ffe5bf1e5fa: i915: Add GuC v70.13.1 for DG2, TGL, ADL-P and MTL (2023-10-13 11:34:26 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware 817619ea70a74598b4216dd25c0f49f61b09309b for yo

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: don't use uncore spinlock to protect critical section in vblank

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915: don't use uncore spinlock to protect critical section in vblank URL : https://patchwork.freedesktop.org/series/126518/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_126518v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add bigjoiner force enable option to debugfs (rev6)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915: Add bigjoiner force enable option to debugfs (rev6) URL : https://patchwork.freedesktop.org/series/124730/ State : success == Summary == CI Bug Log - changes from CI_DRM_13884 -> Patchwork_124730v6 Sum

[Intel-gfx] [PATCH 1/3] drm/i915/display: Separate xe and i915 common dpt code into own file

2023-11-16 Thread Juha-Pekka Heikkila
Here created intel_dpt_common.c to hold intel_dpt_configure which is needed for both xe and i915. Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Jouni Högander --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/d

[Intel-gfx] [PATCH 3/3] drm/i915/display: In intel_framebuffer_init switch to use intel_bo_to_drm_bo

2023-11-16 Thread Juha-Pekka Heikkila
We are preparing for Xe driver. I915 and Xe object implementation are differing. Use intel_bo_to_drm_bo instead of &obj->base. Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Jouni Högander Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- 1 file changed, 1 insertion

[Intel-gfx] [PATCH 2/3] drm/i915/display: in skl_surf_address check for dpt-vma

2023-11-16 Thread Juha-Pekka Heikkila
touch dpt_vma->node only if dpt-vma is not NULL Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Jouni Högander --- drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drive

[Intel-gfx] [PATCH 1/4] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc

2023-11-16 Thread Ankit Nautiyal
In helper intel_dp_dsc_max_src_input_bpc it is assumed that platforms earlier to ICL do not support DSC, and the function returns 0 for those platforms. Use HAS_DSC macro instead and return 0 for platforms that do not support DSC. v2: Updated commit message with clarification. (Jani) Signed-off-

[Intel-gfx] [PATCH v3] drm/i915/vma: Fix VMA UAF on destroy against deactivate race

2023-11-16 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object from when parking a GPU tile believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915]

[Intel-gfx] [PULL] drm-misc-fixes

2023-11-16 Thread Maarten Lankhorst
Hi Dave, Daniel, Small pull request, mostly nouveau fixes. Cheers, ~Maarten Mostly drm-misc-fixes-2023-11-16: Assorted fixes for v6.7-rc2: - Nouveau GSP fixes. - Fix nouveau driver load without display. - Use rwlock for nouveau's event lock to break a lockdep splat. - Add orientation quirk for

Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2023-11-16 Thread Modem, Bhanuprakash
On Thu-16-11-2023 04:07 pm, Stanislav Lisovskiy wrote: For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs. Do we have any IGT to validate this? - Bhanu v2: - Apparently

[Intel-gfx] [PATCH v2 11/11] drm/i915/dp: Reuse intel_dp_{max, effective}_data_rate in intel_link_compute_m_n()

2023-11-16 Thread Imre Deak
Reuse intel_dp_max_data_rate() and intel_dp_effective_data_rate() in intel_link_compute_m_n(), instead of open-coding the equivalent. Note the kbit/sec -> kByte/sec unit change in the M/N values, but this not reducing the precision, as the link rate value is based anyway on a less precise 10 kbit/s

[Intel-gfx] [PATCH v2 07/11] drm/i915/dp_mst: Calculate the BW overhead in intel_dp_mst_find_vcpi_slots_for_bpp()

2023-11-16 Thread Imre Deak
The next patch will calculate the PBN value directly from the pixel data rate and the BW allocation overhead, not requiring the data, link M/N and TU values for this. To prepare for that move the calculation of BW overheads from intel_dp_mst_compute_m_n() to intel_dp_mst_find_vcpi_slots_for_bpp().

[Intel-gfx] [PATCH v2 04/11] drm/i915/dp: Replace intel_dp_is_uhbr_rate() with drm_dp_is_uhbr_rate()

2023-11-16 Thread Imre Deak
Replace intel_dp_is_uhbr_rate() with the recently added drm_dp_is_uhbr_rate(). Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_dp.c | 7 +-- drivers/gpu/drm/i915/display/intel_dp.h | 1 - 3 files changed, 2 insert

[Intel-gfx] [PATCH v2 08/11] drm/i915/dp_mst: Fix PBN / MTP_TU size calculation for UHBR rates

2023-11-16 Thread Imre Deak
Atm the allocated MST PBN value is calculated from the TU size (number of allocated MTP slots) as PBN = TU * pbn_div pbn_div being the link BW for each MTP slot. For DP 1.4 link rates this worked, as pbn_div there is guraranteed to be an integer number, however on UHBR this isn't the case. To g

[Intel-gfx] [PATCH v2 06/11] drm/i915/dp: Fix UHBR link M/N values

2023-11-16 Thread Imre Deak
The link M/N ratio is the data rate / link symbol clock rate, fix things up accordingly. On DP 1.4 this ratio was correct as the link symbol clock rate in that case matched the link data rate (in bytes/sec units, the symbol size being 8 bits), however it wasn't correct for UHBR rates where the symb

[Intel-gfx] [PATCH v2 09/11] drm/i915/dp: Report a rounded-down value as the maximum data rate

2023-11-16 Thread Imre Deak
Callers of intel_dp_max_data_rate() use the return value as an upper bound for the BW a given mode requires. As such the rounding shouldn't result in a bigger value than the actual upper bound. Use round-down instead of -closest accordingly. Cc: Jani Nikula Signed-off-by: Imre Deak --- drivers/

[Intel-gfx] [PATCH v2 10/11] drm/i915/dp: Simplify intel_dp_max_data_rate()

2023-11-16 Thread Imre Deak
Simplify intel_dp_max_data_rate() using drm_dp_bw_channel_coding_efficiency() to calculate the max data rate for both DP1.4 and UHBR link rates. This trades a redundant multiply/divide for readability. Cc: Jani Nikula Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp.c | 26 +++

[Intel-gfx] [PATCH v2 05/11] drm/i915/dp: Account for channel coding efficiency on UHBR links

2023-11-16 Thread Imre Deak
Apply the correct BW allocation overhead and channel coding efficiency on UHBR link rates, similarly to DP1.4 link rates. Reviewed-by: Arun R Murthy Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_display.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/g

[Intel-gfx] [PATCH v2 03/11] drm/dp_mst: Add kunit tests for drm_dp_get_vc_payload_bw()

2023-11-16 Thread Imre Deak
Add kunit test cases for drm_dp_get_vc_payload_bw() with all the DP1.4 and UHBR link configurations. Cc: Lyude Paul Cc: dri-de...@lists.freedesktop.org Signed-off-by: Imre Deak --- .../gpu/drm/tests/drm_dp_mst_helper_test.c| 145 ++ 1 file changed, 145 insertions(+) diff --

[Intel-gfx] [PATCH v2 02/11] drm/dp_mst: Fix PBN divider calculation for UHBR rates

2023-11-16 Thread Imre Deak
The current way of calculating the pbn_div value, the link BW per each MTP slot, worked only for DP 1.4 link rates. Fix things up for UHBR rates calculating with the correct channel coding efficiency based on the link rate. v2: - Return the fractional pbn_div value from drm_dp_get_vc_payload_bw().

[Intel-gfx] [PATCH v2 01/11] drm/dp_mst: Store the MST PBN divider value in fixed point format

2023-11-16 Thread Imre Deak
On UHBR links the PBN divider is a fractional number, accordingly store it in fixed point format. For now drm_dp_get_vc_payload_bw() always returns a whole number and all callers will use only the integer part of it which should preserve the current behavior. The next patch will fix drm_dp_get_vc_p

[Intel-gfx] [PATCH v2 00/11] drm/i915: Fix UHBR data, link M/N/TU and PBN values

2023-11-16 Thread Imre Deak
This is v2 of [1], with the following changes: - Store the pbn_div value in fixed point format. - Fix PBN calculation in patch 8. - Reuse intel_dp_max_data_rate(), intel_dp_effective_data_rate() in intel_link_compute_m_n() (Jani). [1] https://lore.kernel.org/all/20231113201110.510724-1-imre.d...

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2) URL : https://patchwork.freedesktop.org/series/125977/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13883 -> Patchwork_125977v2 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2) URL : https://patchwork.freedesktop.org/series/125977/ State : warning == Summary == Error: dim checkpatch failed 585aceddae24 drm/i915/dsi: assume BXT gpio works for non-native GPIO 0491ae016322 drm/i915/dsi

Re: [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

2023-11-16 Thread Andrzej Hajda
On 16.11.2023 12:45, Andi Shyti wrote: Hi Andrzej, On Wed, Nov 15, 2023 at 01:10:33PM +0100, Andrzej Hajda wrote: Trace requires new-line at the end of message (in opposition to printk), otherwise trace dump becomes messy. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thx all, p

Re: [Intel-gfx] [PATCH v2] drm/i915: do not clean GT table on error path

2023-11-16 Thread Andrzej Hajda
On 16.11.2023 12:44, Andi Shyti wrote: Hi Andrzej, On Wed, Nov 15, 2023 at 11:54:03AM +0100, Andrzej Hajda wrote: The only task of intel_gt_release_all is to zero gt table. Calling it on error path prevents intel_gt_driver_late_release_all (called from i915_driver_late_release) to cleanup GT

Re: [Intel-gfx] [PATCH] drm/i915/gt: add missing new-line to GT_TRACE

2023-11-16 Thread Andi Shyti
Hi Andrzej, On Wed, Nov 15, 2023 at 01:10:33PM +0100, Andrzej Hajda wrote: > Trace requires new-line at the end of message (in opposition to printk), > otherwise trace dump becomes messy. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [Intel-gfx] [PATCH v2] drm/i915: do not clean GT table on error path

2023-11-16 Thread Andi Shyti
Hi Andrzej, On Wed, Nov 15, 2023 at 11:54:03AM +0100, Andrzej Hajda wrote: > The only task of intel_gt_release_all is to zero gt table. Calling > it on error path prevents intel_gt_driver_late_release_all (called from > i915_driver_late_release) to cleanup GTs, causing leakage. > After i915_driver

[Intel-gfx] [PATCH v2 3/3] drm/i915/display: Split i915 specific code away from intel_fb.c

2023-11-16 Thread Jouni Högander
We are preparing for Xe driver. Backing object implementation is differing between i915 and Xe. Split i915 specific code into separate source file built only for i915. v2: Couple of fixes to error value handling Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/Makefile | 1 +

[Intel-gfx] [PATCH v2 2/3] drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static

2023-11-16 Thread Jouni Högander
We are about to split i915 specific code from intel_fb.c. Convert intel_fb_modifier_to_tiling as non-static to allow calling it from split code. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fb.c | 40 - drivers/gpu/drm/i915/display/intel_fb.h | 2

[Intel-gfx] [PATCH v2 1/3] drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c

2023-11-16 Thread Jouni Högander
We are preparing for Xe driver. I915 and Xe object implementation are differing. Do not use i915_gem_object->base directly. Instead use intel_bo_to_drm_bo. Also use drm_gem_object_put instead of i915_gem_object_put. This should be ok as i915_gem_object_put is really just doing __drm_gem_object_p

[Intel-gfx] [PATCH v2 0/3] Prepare intel_fb for Xe

2023-11-16 Thread Jouni Högander
Intel fb creation is differing between Xe and i915 due to different implementations of backing object. This patch set is splitting i915 specific code into it's own source file. Similar source files will be introduced for Xe as well. Also use intel_bo_to_drm_bo instead of directly referring i915_ge

[Intel-gfx] [PATCH] drm/i915: don't use uncore spinlock to protect critical section in vblank

2023-11-16 Thread Luca Coelho
Since we're abstracting the display code from the underlying driver (i.e. i915 vs xe), we can't use the uncore's spinlock to protect critical sections of our code. After further inspection, it seems that the spinlock is not needed at all and this can be handled by disabling preemption and interrup

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Use int type for entry_setup_frames

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/display: Use int type for entry_setup_frames URL : https://patchwork.freedesktop.org/series/126513/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13882 -> Patchwork_126513v1 Summary ---

[Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2023-11-16 Thread Stanislav Lisovskiy
For validation purposes, it might be useful to be able to force Bigjoiner mode, even if current dotclock/resolution do not require that. Lets add such to option to debugfs. v2: - Apparently intel_dp_need_bigjoiner can't be used, when debugfs entry is created so lets just check manually

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gsc: Mark internal GSC engine with reserved uabi class (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/gsc: Mark internal GSC engine with reserved uabi class (rev2) URL : https://patchwork.freedesktop.org/series/126455/ State : success == Summary == CI Bug Log - changes from CI_DRM_13882 -> Patchwork_126455v2

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-11-16 Thread Tvrtko Ursulin
On 14/11/2023 19:48, Teres Alexis, Alan Previn wrote: On Tue, 2023-11-14 at 17:52 +, Tvrtko Ursulin wrote: On 14/11/2023 17:37, Teres Alexis, Alan Previn wrote: On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote: On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: On Wed, 2023-10

Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

2023-11-16 Thread Jani Nikula
On Thu, 16 Nov 2023, Hans de Goede wrote: > Ok, this now has been testen on both a BYT and a CHT device which > actually use GPIO controls in their MIPI sequences so this > series is: > > Tested-by: Hans de Goede > > And the code of the entire series also looks good to me: > > Reviewed-by: Hans d

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gsc: Mark internal GSC engine with reserved uabi class (rev2)

2023-11-16 Thread Patchwork
== Series Details == Series: drm/i915/gsc: Mark internal GSC engine with reserved uabi class (rev2) URL : https://patchwork.freedesktop.org/series/126455/ State : warning == Summary == Error: dim checkpatch failed f6f01f34060f drm/i915/gsc: Mark internal GSC engine with reserved uabi class -:8

[Intel-gfx] ✗ Fi.CI.BAT: failure for Prepare intel_fb for Xe

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe URL : https://patchwork.freedesktop.org/series/126507/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13882 -> Patchwork_126507v1 Summary --- **FAILURE** Serious

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prepare intel_fb for Xe

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim checkpatch failed edbacde37ec5 drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c 154645913940 drm/i915/display: Convert intel_fb_modifier_to

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Prepare intel_fb for Xe

2023-11-16 Thread Patchwork
== Series Details == Series: Prepare intel_fb for Xe URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning: un

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-16 Thread Maxime Ripard
Hi, On Mon, Nov 13, 2023 at 09:56:32PM -0500, Luben Tuikov wrote: > On 2023-11-13 21:45, Stephen Rothwell wrote: > > Hi Luben, > > > > On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: > >> > >> On 2023-11-13 20:08, Luben Tuikov wrote: > >>> On 2023-11-13 15:55, Stephen Rothwell wrote: >

[Intel-gfx] [PATCH] drm/i915/display: Use int type for entry_setup_frames

2023-11-16 Thread Mika Kahola
entry_setup_frames variable is defined as u8. However, the function call intel_psr_entry_setup_frames() can return negative error code. There is a type mismatch here, so let's switch to use int here as well. Fixes: 2b981d57e480 ("drm/i915/display: Support PSR entry VSC packet to be transmitted on

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Use int for entry setup frames

2023-11-16 Thread Kahola, Mika
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, November 15, 2023 11:58 PM > To: Kahola, Mika > Cc: intel-gfx@lists.freedesktop.org; Hogander, Jouni > > Subject: Re: [PATCH] drm/i915/mtl: Use int for entry setup frames > > On Mon, Nov 13, 2023 at 11:37:37AM +0200, Mika Ka

Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

2023-11-16 Thread Hans de Goede
Hi, On 11/3/23 21:18, Andy Shevchenko wrote: > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct > talking to GPIO IP behind the actual driver's back. A second attempt > to fix that is here. > > If I understood correctly, my approach should work in the similar way as > the cur

[Intel-gfx] [PATCH v2] drm/i915/gsc: Mark internal GSC engine with reserved uabi class

2023-11-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin The GSC CS is not exposed to the user, so we skipped assigning a uabi class number for it. However, the trace logs use the uabi class and instance to identify the engine, so leaving uabi class unset makes the GSC CS show up as the RCS in those logs. Given that the engine is

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-16 Thread Daniel Vetter
On Thu, Nov 16, 2023 at 09:11:43AM +0100, Maxime Ripard wrote: > On Tue, Nov 14, 2023 at 06:46:21PM -0500, Luben Tuikov wrote: > > On 2023-11-13 22:08, Stephen Rothwell wrote: > > > BTW, cherry picking commits does not avoid conflicts - in fact it can > > > cause conflicts if there are further chan

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-misc tree

2023-11-16 Thread Maxime Ripard
On Tue, Nov 14, 2023 at 06:46:21PM -0500, Luben Tuikov wrote: > On 2023-11-13 22:08, Stephen Rothwell wrote: > > BTW, cherry picking commits does not avoid conflicts - in fact it can > > cause conflicts if there are further changes to the files affected by > > the cherry picked commit in either the

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use a different vblank worker for atomic unpin

2023-11-16 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Maarten > Lankhorst > Sent: Thursday, November 9, 2023 9:05 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 3/3] drm/i915: Use a different vblank worker for > atomic unpin > > For the atomic codepath we unpin_wo

[Intel-gfx] [PATCH 0/3] Prepare intel_fb for Xe

2023-11-16 Thread Jouni Högander
Intel fb creation is differing between Xe and i915 due to different implementations of backing object. This patch set is splitting i915 specific code into it's own source file. Similar source files will be introduced for Xe as well. Also use intel_bo_to_drm_bo instead of directly referring i915_ge

[Intel-gfx] [PATCH 3/3] drm/i915/display: Split i915 specific code away from intel_fb.c

2023-11-16 Thread Jouni Högander
We are preparing for Xe driver. Backing object implementation is differing between i915 and Xe. Split i915 specific code into separate source file built only for i915. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_fb.c

[Intel-gfx] [PATCH 1/3] drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c

2023-11-16 Thread Jouni Högander
We are preparing for Xe driver. I915 and Xe object implementation are differing. Do not use i915_gem_object->base directly. Instead use intel_bo_to_drm_bo. Also use drm_gem_object_put instead of i915_gem_object_put. This should be ok as i915_gem_object_put is really just doing __drm_gem_object_p

[Intel-gfx] [PATCH 2/3] drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static

2023-11-16 Thread Jouni Högander
We are about to split i915 specific code from intel_fb.c. Convert intel_fb_modifier_to_tiling as non-static to allow calling it from split code. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fb.c | 40 - drivers/gpu/drm/i915/display/intel_fb.h | 2