Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Split i915 specific code away from intel_fb.c

On Mon, 2023-11-20 at 16:23 +0200, Ville Syrjälä wrote: > On Mon, Nov 20, 2023 at 12:08:33PM +0200, Jouni Högander wrote: > > We are preparing for Xe driver. Backing object implementation is > > differing > > between i915 and Xe. Split i915 specific code into separate source > > file > > built

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static

On Mon, 2023-11-20 at 16:19 +0200, Ville Syrjälä wrote: > On Mon, Nov 20, 2023 at 12:08:32PM +0200, Jouni Högander wrote: > > We are about to split i915 specific code from intel_fb.c. Convert > > intel_fb_modifier_to_tiling as non-static to allow calling it from > > split > > code. > > We should

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Audio fastset, and some fixes (rev3)

== Series Details == Series: drm/i915: Audio fastset, and some fixes (rev3) URL : https://patchwork.freedesktop.org/series/126041/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13901 -> Patchwork_126041v3 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Audio fastset, and some fixes (rev3)

== Series Details == Series: drm/i915: Audio fastset, and some fixes (rev3) URL : https://patchwork.freedesktop.org/series/126041/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Adjust LUT rounding rules

> -Original Message- > From: Ville Syrjälä > Sent: Monday, November 20, 2023 7:57 PM > To: Borah, Chaitanya Kumar > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [PATCH 2/4] drm/i915: Adjust LUT rounding rules > > On Mon, Nov 20, 2023 at

[Intel-gfx] [PATCH v2 11/11] drm/i915: Implement audio fastset

From: Ville Syrjälä There's no real reason why we'd need a full modeset for audio changes. So let's allow audio to be toggled during fastset. In case the ELD changes while has_audio isn't changing state we force both audio disable and enable so the new ELD gets propagated to the audio driver.

[Intel-gfx] [PATCH v2 10/11] drm/i915: Push audio_{enable, disable}() to the pre/post pane update stage

From: Ville Syrjälä Relocate the audio enable/disable from the full modeset hooks into the common pre/post plane update stage of the commit. Audio fastset is within easy reach now. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 31

[Intel-gfx] [PATCH v2 09/11] drm/i915: Hoist the encoder->audio_{enable, disable}() calls higher up

From: Ville Syrjälä Push the encoder->audio_{enable,disable}() calls out from the encoder->{enable,disable}() hooks. Moving towards audio fastset. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/g4x_dp.c| 2 -

[Intel-gfx] [PATCH v2 08/11] drm/i915: Convert audio enable/disable into encoder vfuncs

From: Ville Syrjälä Add encoder vfuncs for audio enable/disable. This will allow audio to be enabled/disabled during fastsets. An encoder hook is necessary as on pre-hsw platforms different encoder types implement audio in different ways. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH v2 07/11] drm/i915: Split g4x+ HDMI audio presence detect from port enable

From: Ville Syrjälä Follow the hsw+ approach toggle the audio presence detect when we set up the ELD, instead of doing it when turning the port on/off. This will facilitate audio enable/disable to happen during fastsets instead of requiring a full modeset. Reviewed-by: Jani Nikula

[Intel-gfx] [PATCH v2 06/11] drm/i915: Split g4x+ DP audio presence detect from port enable

From: Ville Syrjälä Follow the hsw+ approach toggle the audio presence detect when we set up the ELD, instead of doing it when turning the port on/off. This will facilitate audio enable/disable to happen during fastsets instead of requiring a full modeset. Reviewed-by: Jani Nikula

[Intel-gfx] [PATCH v2 05/11] drm/i915: Wrap g4x+ DP/HDMI audio enable/disable

From: Ville Syrjälä Put a wrapper around the intel_audio_codec_{enable,disable}() calls in the g4x+ DP/HDMI code. We shall move the presence detect enable/disable into the wrappers later. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/g4x_dp.c | 26

[Intel-gfx] [PATCH v2 04/11] drm/i915: Push audio enable/disable further out

From: Ville Syrjälä Push the audio enable/disable to be the last/first thing respectively that is done in the encoder enable/disable hooks. The goal is to move it further out of these encoder hooks entirely. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 03/11] drm/i915: Polish some RMWs

From: Ville Syrjälä Doing the if-else around RMWs is kinda silly. Just set/clear the apporiate bits with a single RMW. Also unify the coding style a bit icl_wa_cursorclkgating() while at it. Reviewed-by: Jani Nikula Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 02/11] drm/i915: Call intel_pre_plane_updates() also for pipes getting enabled

From: Ville Syrjälä We used to call intel_pre_plane_updates() for any pipe going through a modeset whether the pipe was previously enabled or not. This in fact needed to apply all the necessary clock gating workarounds/etc. Restore the correct behaviour. Fixes: 39919997322f ("drm/i915: Disable

[Intel-gfx] [PATCH v2 01/11] drm/i915: Check pipe active state in {planes, vrr}_{enabling, disabling}()

From: Ville Syrjälä {planes,vrr}_{enabling,disabling}() are supposed to indicate whether the specific hardware feature is supposed to be enabling or disabling. That can only makes sense if the pipe is active overall. So check for that before we go poking at the hardware. I think we're semi-safe

[Intel-gfx] [PATCH v2 00/11] drm/i915: Audio fastset, and some fixes

From: Ville Syrjälä Implement audio fastset. Probably mosy useful in avoiding some fastboot blinks, runtime audio fastset is less likely to be a typical use case. Also try to fix up a mess with pre_plane_update() vs. already disabled pipe. v2: Rebase Ville Syrjälä (11): drm/i915: Check pipe

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Do not check psr2 if psr/panel replay is not supported

== Series Details == Series: drm/i915/display: Do not check psr2 if psr/panel replay is not supported URL : https://patchwork.freedesktop.org/series/126651/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13901 -> Patchwork_126651v1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix UHBR data, link M/N/TU and PBN values (rev6)

== Series Details == Series: drm/i915: Fix UHBR data, link M/N/TU and PBN values (rev6) URL : https://patchwork.freedesktop.org/series/126526/ State : success == Summary == CI Bug Log - changes from CI_DRM_13901 -> Patchwork_126526v6

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix UHBR data, link M/N/TU and PBN values (rev6)

== Series Details == Series: drm/i915: Fix UHBR data, link M/N/TU and PBN values (rev6) URL : https://patchwork.freedesktop.org/series/126526/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix UHBR data, link M/N/TU and PBN values (rev6)

== Series Details == Series: drm/i915: Fix UHBR data, link M/N/TU and PBN values (rev6) URL : https://patchwork.freedesktop.org/series/126526/ State : warning == Summary == Error: dim checkpatch failed 3513c76cbe67 drm/dp_mst: Store the MST PBN divider value in fixed point format -:45:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev4)

== Series Details == Series: series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev4) URL : https://patchwork.freedesktop.org/series/126538/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13900 -> Patchwork_126538v4

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev4)

== Series Details == Series: series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev4) URL : https://patchwork.freedesktop.org/series/126538/ State : warning == Summary == Error: dim checkpatch failed 4544fd359e55 drm/i915/display: Separate xe and

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev4)

== Series Details == Series: series starting with [1/3] drm/i915/display: Separate xe and i915 common dpt code into own file (rev4) URL : https://patchwork.freedesktop.org/series/126538/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: ATS-M device ID update

== Series Details == Series: drm/i915: ATS-M device ID update URL : https://patchwork.freedesktop.org/series/126646/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13900 -> Patchwork_126646v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)

== Series Details == Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5) URL : https://patchwork.freedesktop.org/series/125977/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13900 -> Patchwork_125977v5 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)

== Series Details == Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5) URL : https://patchwork.freedesktop.org/series/125977/ State : warning == Summary == Error: dim checkpatch failed 718e25fcdd2a drm/i915/dsi: assume BXT gpio works for non-native GPIO a6aab2794a1f

[Intel-gfx] ✓ Fi.CI.BAT: success for Prepare intel_fb for Xe (rev4)

== Series Details == Series: Prepare intel_fb for Xe (rev4) URL : https://patchwork.freedesktop.org/series/126507/ State : success == Summary == CI Bug Log - changes from CI_DRM_13900 -> Patchwork_126507v4 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Prepare intel_fb for Xe (rev4)

== Series Details == Series: Prepare intel_fb for Xe (rev4) URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prepare intel_fb for Xe (rev4)

== Series Details == Series: Prepare intel_fb for Xe (rev4) URL : https://patchwork.freedesktop.org/series/126507/ State : warning == Summary == Error: dim checkpatch failed d12deb0b9794 drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c 5d9896b24b8b drm/i915/display: Convert

[Intel-gfx] ✓ Fi.CI.BAT: success for Implement sel_fetch disable for planes (rev4)

== Series Details == Series: Implement sel_fetch disable for planes (rev4) URL : https://patchwork.freedesktop.org/series/114224/ State : success == Summary == CI Bug Log - changes from CI_DRM_13900 -> Patchwork_114224v4 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Implement sel_fetch disable for planes (rev4)

== Series Details == Series: Implement sel_fetch disable for planes (rev4) URL : https://patchwork.freedesktop.org/series/114224/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH v4 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support

After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

[Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support

After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this

Re: [Intel-gfx] [PATCH] drm/i915/display: Do not check psr2 if psr/panel replay is not supported

> -Original Message- > From: Hogander, Jouni > Sent: Monday, November 20, 2023 6:32 PM > To: intel-gfx@lists.freedesktop.org > Cc: Hogander, Jouni ; Manna, Animesh > > Subject: [PATCH] drm/i915/display: Do not check psr2 if psr/panel replay is > not supported > > Do not continue to

Re: [Intel-gfx] [PATCH] drm/i915: ATS-M device ID update

On Mon, Nov 20, 2023 at 05:07:31PM +0530, Haridhar Kalvala wrote: > ATS-M device ID update. > > BSpec: 44477 > > Signed-off-by: Haridhar Kalvala Reviewed-by: Matt Roper > --- > include/drm/i915_pciids.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 0/4] drm/i915: Fix LUT rounding

On Fri, Oct 13, 2023 at 04:13:58PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The current LUT rounding is generating weird results. Adjust > it to follow the OpenGL int<->float conversion rules. > > Ville Syrjälä (4): > drm: Fix color LUT rounding ^ I'd like to merge this via

Re: [Intel-gfx] [PATCH 1/4] drm: Fix color LUT rounding

On Mon, Nov 20, 2023 at 01:17:05PM +, Borah, Chaitanya Kumar wrote: > > > > -Original Message- > > From: Borah, Chaitanya Kumar > > Sent: Monday, November 20, 2023 6:33 PM > > To: Ville Syrjälä > > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Jani > > Nikula

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Adjust LUT rounding rules

On Mon, Nov 20, 2023 at 06:08:57AM +, Borah, Chaitanya Kumar wrote: > Hello Ville, > > > -Original Message- > > From: dri-devel On Behalf Of Ville > > Syrjala > > Sent: Friday, October 13, 2023 6:44 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: dri-de...@lists.freedesktop.org >

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/display: Split i915 specific code away from intel_fb.c

On Mon, Nov 20, 2023 at 12:08:33PM +0200, Jouni Högander wrote: > We are preparing for Xe driver. Backing object implementation is differing > between i915 and Xe. Split i915 specific code into separate source file > built only for i915. > > v4: Move drm_any_plane_has_format check into

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static

On Mon, Nov 20, 2023 at 12:08:32PM +0200, Jouni Högander wrote: > We are about to split i915 specific code from intel_fb.c. Convert > intel_fb_modifier_to_tiling as non-static to allow calling it from split > code. We should only need this in the i915 path. > > Signed-off-by: Jouni Högander >

Re: [Intel-gfx] [PATCH v2 00/11] drm/i915: Fix UHBR data, link M/N/TU and PBN values

On Mon, 20 Nov 2023, Imre Deak wrote: > On Mon, Nov 20, 2023 at 02:31:34PM +0200, Jani Nikula wrote: >> On Thu, 16 Nov 2023, Imre Deak wrote: >> > This is v2 of [1], with the following changes: >> > - Store the pbn_div value in fixed point format. >> > - Fix PBN calculation in patch 8. >> > -

Re: [Intel-gfx] [PATCH 1/4] drm: Fix color LUT rounding

> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Monday, November 20, 2023 6:33 PM > To: Ville Syrjälä > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Jani > Nikula > Subject: RE: [Intel-gfx] [PATCH 1/4] drm: Fix color LUT rounding > > Hello Ville,

Re: [Intel-gfx] [PATCH] drm/i915/display: Do not check psr2 if psr/panel replay is not supported

On Mon, 20 Nov 2023, Jouni Högander wrote: > Do not continue to psr2 checks if psr or panel replay is not supported. > > Cc: Animesh Manna > > Fixes: b8cf5b5d266e ("drm/i915/panelreplay: Initializaton and compute config > for panel replay") > Closes:

Re: [Intel-gfx] [PATCH v2 00/11] drm/i915: Fix UHBR data, link M/N/TU and PBN values

On Mon, Nov 20, 2023 at 02:31:34PM +0200, Jani Nikula wrote: > On Thu, 16 Nov 2023, Imre Deak wrote: > > This is v2 of [1], with the following changes: > > - Store the pbn_div value in fixed point format. > > - Fix PBN calculation in patch 8. > > - Reuse intel_dp_max_data_rate(),

Re: [Intel-gfx] [PATCH 1/4] drm: Fix color LUT rounding

Hello Ville, > -Original Message- > From: dri-devel On Behalf Of Ville > Syrjälä > Sent: Tuesday, October 31, 2023 9:37 PM > To: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/4] drm: Fix color LUT rounding > > On

[Intel-gfx] [PATCH] drm/i915/display: Do not check psr2 if psr/panel replay is not supported

Do not continue to psr2 checks if psr or panel replay is not supported. Cc: Animesh Manna Fixes: b8cf5b5d266e ("drm/i915/panelreplay: Initializaton and compute config for panel replay") Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9670 Signed-off-by: Jouni Högander ---

Re: [Intel-gfx] [PATCH] drm/i915: Also check for VGA converter in eDP probe

On Tue, 14 Nov 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Unfortunately even the HPD based detection added in > commit cfe5bdfb27fa ("drm/i915: Check HPD live state during eDP probe") > fails to detect that the VBT's eDP/DDI-A is a ghost on > Asus B360M-A (CFL+CNP). On that board

[Intel-gfx] [PATCH v5 03/11] drm/dp_mst: Add kunit tests for drm_dp_get_vc_payload_bw()

Add kunit test cases for drm_dp_get_vc_payload_bw() with all the DP1.4 and UHBR link configurations. v2: - List test cases in decreasing rate,lane count order matching the corresponding DP Standard tables. (Ville) - Add references to the DP Standard tables. v3: - Sort the testcases properly.

Re: [Intel-gfx] [PATCH 1/3] drm/i915/fbc: Split plane size vs. surface size checks apart

Took a while to comprehend what the spec says and how it translate into code but I think this is correct fix. entire set is Reviewed-by: Juha-Pekka Heikkila On 17.11.2023 19.18, Ville Syrjala wrote: From: Ville Syrjälä Do separate checks for the visible plane size vs. the surface size

Re: [Intel-gfx] [PATCH v2 00/11] drm/i915: Fix UHBR data, link M/N/TU and PBN values

On Thu, 16 Nov 2023, Imre Deak wrote: > This is v2 of [1], with the following changes: > - Store the pbn_div value in fixed point format. > - Fix PBN calculation in patch 8. > - Reuse intel_dp_max_data_rate(), intel_dp_effective_data_rate() in > intel_link_compute_m_n() (Jani). > > [1]

Re: [Intel-gfx] â Fi.CI.IGT: success for drm/i915: use ref_tracker library in i915 (rev4)

On 18.11.2023 04:21, Patchwork wrote: *Patch Details* *Series:* drm/i915: use ref_tracker library in i915 (rev4) *URL:* https://patchwork.freedesktop.org/series/125770/ *State:*success *Details:*

[Intel-gfx] [PATCH] drm/i915: ATS-M device ID update

ATS-M device ID update. BSpec: 44477 Signed-off-by: Haridhar Kalvala --- include/drm/i915_pciids.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 1c9ea6ab3eb9..fcf1849aa47c 100644 --- a/include/drm/i915_pciids.h

Re: [Intel-gfx] [RFC v4 1/2] drm/i915: Add RPL-U sub platform

On Fri, 17 Nov 2023, Lucas De Marchi wrote: > On Mon, Jan 30, 2023 at 03:38:05PM +0530, Chaitanya Kumar Borah wrote: >>Separate out RPLU device ids and add them to both RPL and >>newly created RPL-U subplatforms. >> >>v2: (Matt) >>- Sort PCI-IDs numerically >>- Name the sub-platform to

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add __rcu annotation to cursor when iterating client objects

Hi Tvrtko, On Mon, Nov 13, 2023 at 08:54:57AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > __rcu annotation is needed to avoid the sparse warnings such as: > > .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in > comparison expression (different address spaces): >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove return type from i915_drm_client_remove_object

Hi Tvrtko, On Mon, Nov 13, 2023 at 08:54:56AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > There is no need to return anything in the version which was merged and > also the implementation of the !CONFIG_PROC_FS wasn't returning anything, > causing a build failure there. > >

[Intel-gfx] [PATCH v4 2/3] drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static

We are about to split i915 specific code from intel_fb.c. Convert intel_fb_modifier_to_tiling as non-static to allow calling it from split code. Signed-off-by: Jouni Högander --- drivers/gpu/drm/i915/display/intel_fb.c | 40 - drivers/gpu/drm/i915/display/intel_fb.h | 2

[Intel-gfx] [PATCH v4 3/3] drm/i915/display: Split i915 specific code away from intel_fb.c

We are preparing for Xe driver. Backing object implementation is differing between i915 and Xe. Split i915 specific code into separate source file built only for i915. v4: Move drm_any_plane_has_format check into intel_fb_bo.c v3: Fix failure handling in intel_framebuffer_init v2: Couple of fixes

[Intel-gfx] [PATCH v4 0/3] Prepare intel_fb for Xe

Intel fb creation is differing between Xe and i915 due to different implementations of backing object. This patch set is splitting i915 specific code into it's own source file. Similar source files will be introduced for Xe as well. Also use intel_bo_to_drm_bo instead of directly referring

[Intel-gfx] [PATCH v4 1/3] drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c

We are preparing for Xe driver. I915 and Xe object implementation are differing. Do not use i915_gem_object->base directly. Instead use intel_bo_to_drm_bo. Also use drm_gem_object_put instead of i915_gem_object_put. This should be ok as i915_gem_object_put is really just doing

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add __rcu annotation to cursor when iterating client objects

On Mon, 13 Nov 2023, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > __rcu annotation is needed to avoid the sparse warnings such as: > > .../i915_drm_client.c:92:9: sparse: sparse: incompatible types in > comparison expression (different address spaces): > .../i915_drm_client.c:92:9:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove return type from i915_drm_client_remove_object

On Mon, 13 Nov 2023, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > There is no need to return anything in the version which was merged and > also the implementation of the !CONFIG_PROC_FS wasn't returning anything, > causing a build failure there. > > Signed-off-by: Tvrtko Ursulin > Fixes:

Re: [Intel-gfx] [PULL] drm-misc-next

On Fri, Nov 17, 2023 at 10:41:34AM +0100, Maxime Ripard wrote: > Hi, > > Here's the first drm-misc-next PR for what will become 6.8. > > There's one missing SoB on the commit 0da611a87021 ("dma-buf: add > dma_fence_timestamp helper") from the committer. They provided their SoB > on the ML here

[Intel-gfx] [PATCH v3 2/2] drm/i915/psr: Add proper handling for disabling sel fetch for planes

Currently we are enabling selective fetch for all planes that are visible. This is suboptimal as we might be fetching for memory for planes that are not part of selective update. Fix this by adding proper handling for disabling plane selective fetch: If plane previously part of selective update

[Intel-gfx] [PATCH v3 1/2] drm/i915/psr: Move plane sel fetch configuration into plane source files

Currently selective fetch configuration for planes is implemented in psr code. More suitable place for this code is where everything else is configured for planes -> move it into skl_universal_plane.c and intel_cursor.c. This also allows us to drop hooks for cursor handling. v3: Checkpatch

[Intel-gfx] [PATCH v3 0/2] Implement sel_fetch disable for planes

Move plane sel fetch configuration into plane source files and implement selective fetch disable for planes that are not part of selective update. v3: Checkpatch warnings fixed v2: Move some changes from patch 1. to patch 2. Cc: Ville Syrjälä Cc: Mika Kahola Jouni Högander (2):