On Mon, Dec 11, 2023 at 11:37:46PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Fix the weird flip_done/etc. issues plaguing ADL+ by disabling all dodgy
> DMC events that we definitely don't need. Also improve the debugs to
> make it easier to see what we're doing.
This (at least a
On Wed, Dec 13, 2023 at 09:35:54AM +0200, Imre Deak wrote:
> On Tue, Dec 12, 2023 at 12:06:48AM +, Patchwork wrote:
> > == Series Details ==
> >
> > Series: drm/i915/dmc: DMC event stuff
> > URL : https://patchwork.freedesktop.org/series/127648/
> > State : failure
> >
> > == Summary ==
>
On Tue, Dec 12, 2023 at 12:06:48AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/dmc: DMC event stuff
> URL : https://patchwork.freedesktop.org/series/127648/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_14008_full -> Patchwork_127648v1_full
>
> -Original Message-
> From: Deak, Imre
> Sent: Wednesday, December 13, 2023 9:14 AM
> To: Kahola, Mika
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH v2] drm/i915/display: Wait for PHY readiness not needed
> for disabling sequence
>
> On Tue, Dec 12, 2023 at 01:51:30PM
On Tue, Dec 12, 2023 at 01:51:30PM +0200, Mika Kahola wrote:
> When going through the disconnection flow we don't need to wait for PHY
> readiness and hence we can skip the wait part. For disabling the function
> returns false as an indicator that the power is not enabled. After all,
> we are not
+ @Illipilli, TejasreeX
-Original Message-
From: I915-ci-infra On Behalf Of
Jani Nikula
Sent: Tuesday, December 12, 2023 5:57 PM
To: i915-ci-in...@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/edid:
On 12/11/2023 9:26 PM, Matt Roper wrote:
On Mon, Dec 11, 2023 at 05:08:48PM +0530, Kalvala, Haridhar wrote:
On 12/6/2023 1:54 AM, Matt Roper wrote:
On Tue, Dec 05, 2023 at 02:41:05PM +0530, Haridhar Kalvala wrote:
Enable Force Dispatch Ends Collection for DG2.
BSpec: 46001
Signed-off-by:
Enable Force Dispatch Ends Collection for DG2.
BSpec: 46001
Signed-off-by: Haridhar Kalvala
Reviewed-by: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++
drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++
2 files changed, 6 insertions(+)
diff --git
== Series Details ==
Series: drm/i915: (stolen) memory region related fixes (rev2)
URL : https://patchwork.freedesktop.org/series/127721/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_127721v2
Summary
Use "its" for possessive form instead of "it's".
Hyphenate multi-word adjectives.
Correct some spelling.
End one line of code with ';' instead of ','. The before and after
object files are identical.
Signed-off-by: Randy Dunlap
Cc: Jani Nikula
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: Tvrtko
== Series Details ==
Series: drm/i915: (stolen) memory region related fixes (rev2)
URL : https://patchwork.freedesktop.org/series/127721/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: (stolen) memory region related fixes (rev2)
URL : https://patchwork.freedesktop.org/series/127721/
State : warning
== Summary ==
Error: dim checkpatch failed
43431d68ff99 drm/i915: Use struct resource for memory region IO as well
-:385:
== Series Details ==
Series: drm/i915: (stolen) memory region related fixes
URL : https://patchwork.freedesktop.org/series/127721/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_127721v1
Summary
---
== Series Details ==
Series: drm/i915: (stolen) memory region related fixes
URL : https://patchwork.freedesktop.org/series/127721/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: (stolen) memory region related fixes
URL : https://patchwork.freedesktop.org/series/127721/
State : warning
== Summary ==
Error: dim checkpatch failed
57aa292bab73 drm/i915: Use struct resource for memory region IO as well
-:385: WARNING:LONG_LINE: line
On Wed, Dec 13, 2023 at 02:42:26AM +0200, Ville Syrjala wrote:
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev_fb.c
> b/drivers/gpu/drm/i915/display/intel_fbdev_fb.c
> index 717c3a3237c4..1ac05d90b2e8 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev_fb.c
> +++
From: Ville Syrjälä
There's no reason the caller of intel_initial_plane_config() should
have to loop over the CRTCs. Pull the loop into the function to
make life simpler for the caller.
Signed-off-by: Ville Syrjälä
---
.../drm/i915/display/intel_display_driver.c | 7 +---
From: Ville Syrjälä
Declutter initial_plane_vma() a bit by pulling the lmem and smem
readout paths into their own functions.
TODO: the smem path should still be fixed to get and validate
the dma address from the pte as well
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
The address we read from the PTE is a dma address, not a physical
address. Rename the variable to say so.
Signed-off-by: Ville Syrjälä
---
.../gpu/drm/i915/display/intel_plane_initial.c| 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git
From: Ville Syrjälä
MTL stolen memory looks more like local memory, so use the
(now fixed) lmem path when doing the initial plane readout.
Signed-off-by: Ville Syrjälä
---
.../drm/i915/display/intel_plane_initial.c| 25 +--
1 file changed, 18 insertions(+), 7 deletions(-)
From: Ville Syrjälä
On MTL the stolen region starts at offset 8MiB from the start of
LMEMBAR. The dma addresses are thus also offset by 8MiB. However the
mm_node/etc. is zero based, and i915_pages_create_for_stolen() will
add the appropriate region.start into the sg dma address. So when
we do
From: Ville Syrjälä
When multiple pipes are enabled by the BIOS we try to read out each
in turn. But we do the readout for the second only after the inherited
vma for the first has been rebound into its original place (and thus
the PTEs have been rewritten). Unlike the BIOS we set some high
From: Ville Syrjälä
0x108100 and 0x1080c0 have been around since snb. Rename the
defines appropriately.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4 ++--
drivers/gpu/drm/i915/gt/intel_ggtt.c| 2 +-
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +-
From: Ville Syrjälä
Now that the GGTT PTE updates go straight to GSMBASE (bypassing
GTTMMADR) there should be no more risk of system hangs? So the
"binder" (ie. update the PTEs via MI_UPDATE_GTT) is no longer
necessary, disable it.
TODO: MI_UPDATE_GTT might be interesting as an optimization
From: Ville Syrjälä
On MTL accessing stolen memory via the BARs is somehow borked,
and it can hang the machine. As a workaround let's bypass the
BARs and just go straight to DSMBASE/GSMBASE instead.
Note that on every other platform this itself would hang the
machine, but on MTL the system
From: Ville Syrjälä
Now that intel_memory_regions_hw_probe() prints out each and every
memory region there's no reason to have ad-hoc debugs to do similar
things elsewhere.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4
From: Ville Syrjälä
Dump the details about every memory region into dmesg at probe time.
Avoids having to dig those out from random places when debugging stuff.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_memory_region.c | 18 ++
1 file changed, 18
From: Ville Syrjälä
mem->region is a struct resource, but mem->io_start and
mem->io_size are not for whatever reason. Let's unify this
and convert the io stuff into a struct resource as well.
Should make life a little less annoying when you don't have
juggle between two different approaches all
From: Ville Syrjälä
Attempt to fix the mess around stolen memory, especially on MTL
with it's special (and apparenly broken) not-actually-lmem stolen.
The series is made up of roughtly three parts:
1. General refactoring/debug improvement for mem regions
2. Deal with the broken BAR stuff on MTL
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev10)
URL : https://patchwork.freedesktop.org/series/126998/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_126998v10
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev10)
URL : https://patchwork.freedesktop.org/series/126998/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev10)
URL : https://patchwork.freedesktop.org/series/126998/
State : warning
== Summary ==
Error: dim checkpatch failed
e63dc2e81ead drm/i915/gem: Atomically invalidate userptr on mmu-notifier
-:117:
== Series Details ==
Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev10)
URL : https://patchwork.freedesktop.org/series/121916/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_121916v10
== Series Details ==
Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev10)
URL : https://patchwork.freedesktop.org/series/121916/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: ALSA: hda/hdmi: align force-connect quirks with upstream
URL : https://patchwork.freedesktop.org/series/127706/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_127706v1
Summary
Add one more older NUC model that requires quirk to force all pins to be
connected. The display codec pins are not registered properly without
the force-connect quirk. The codec will report only one pin as having
external connectivity, but i915 finds all three connectors on the
system, so the two
On ASUSTeK Z170M PLUS and Z170 PRO GAMING systems, the display codec
pins are not registered properly without the force-connect quirk. The
codec will report only one pin as having external connectivity, but i915
finds all three connectors on the system, so the two drivers are not
in sync.
Issue
This reverts commit 6b2bcf964cad023bd9695a5cd842390578a7d1c9.
Signed-off-by: Kai Vehmanen
---
sound/pci/hda/patch_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 8bf91fe25c65..3d7f8f510ec7 100644
---
This reverts commit 684f8de2b9715c0a60bcf8b42ee4743624bd4b05.
Signed-off-by: Kai Vehmanen
---
sound/pci/hda/patch_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index b152c941414f..1cde2a69bdb4 100644
---
This reverts commit e83118f4e6ac13d5b1becb65e525c0e0265bbd61.
Signed-off-by: Kai Vehmanen
---
sound/pci/hda/patch_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 3d7f8f510ec7..5232c46a32a7 100644
---
This reverts commit 6fb89f11e23453b081ec4695e5e66ccb4deb2fd0.
Signed-off-by: Kai Vehmanen
---
sound/pci/hda/patch_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 5232c46a32a7..b152c941414f 100644
---
The recent work on display audio force-connect quirks got merged
upstream, but in a slightly modified form. This series replaces the patches
in drm-intel/topic/core-for-CI with clean versions of patches merged
to sound upstream.
There is one functional difference, the upstream version dropped
== Series Details ==
Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev9)
URL : https://patchwork.freedesktop.org/series/121916/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_121916v9
== Series Details ==
Series: Resolve suspend-resume racing with GuC destroy-context-worker (rev9)
URL : https://patchwork.freedesktop.org/series/121916/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev9)
URL : https://patchwork.freedesktop.org/series/126998/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_126998v9
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev9)
URL : https://patchwork.freedesktop.org/series/126998/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev9)
URL : https://patchwork.freedesktop.org/series/126998/
State : warning
== Summary ==
Error: dim checkpatch failed
9609d66f15e9 drm/i915/gem: Atomically invalidate userptr on mmu-notifier
-:117:
If we are at the end of suspend or very early in resume
its possible an async fence signal (via rcu_call) is triggered
to free_engines which could lead us to the execution of
the context destruction worker (after a prior worker flush).
Thus, when suspending, insert rcu_barriers at the start
of
When suspending, flush the context-guc-id
deregistration worker at the final stages of
intel_gt_suspend_late when we finally call gt_sanitize
that eventually leads down to __uc_sanitize so that
the deregistration worker doesn't fire off later as
we reset the GuC microcontroller.
Signed-off-by:
This series is the result of debugging issues root caused to
races between the GuC's destroyed_worker_func being triggered
vs repeating suspend-resume cycles with concurrent delayed
fence signals for engine-freeing.
The reproduction steps require that an app is launched right
before the start of
On Tue, 12 Dec 2023, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/2] drm/edid: replace __attribute__((packed))
> with __packed (rev2)
> URL : https://patchwork.freedesktop.org/series/127680/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from
== Series Details ==
Series: series starting with [1/2] drm/edid: replace __attribute__((packed))
with __packed (rev2)
URL : https://patchwork.freedesktop.org/series/127680/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_127680v2
== Series Details ==
Series: series starting with [1/2] drm/edid: replace __attribute__((packed))
with __packed (rev2)
URL : https://patchwork.freedesktop.org/series/127680/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be
== Series Details ==
Series: drm/edid: prefer forward declarations over includes in drm_edid.h
URL : https://patchwork.freedesktop.org/series/127695/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_127695v1
On Tue, Dec 12, 2023 at 07:22:18AM -0800, Guenter Roeck wrote:
> On 12/12/23 03:41, Uwe Kleine-König wrote:
> > Several affected maintainers already acked, so I guess it's fine to take
> > this via the pwm tree. An Ack from the remaining maintainers would be
> > very welcome, an alternative would
On 12/12/23 03:41, Uwe Kleine-König wrote:
On Tue, Dec 12, 2023 at 08:34:00AM +, Sean Young wrote:
In order to introduce a pwm api which can be used from atomic context,
we will need two functions for applying pwm changes:
int pwm_apply_might_sleep(struct pwm *, struct pwm_state
== Series Details ==
Series: drm/edid: prefer forward declarations over includes in drm_edid.h
URL : https://patchwork.freedesktop.org/series/127695/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
There's no need to include either linux/hdmi.h or drm/drm_mode.h. They
can be removed by using forward declarations.
While at it, group the forward declarations together, and remove the
unnecessary ones.
Signed-off-by: Jani Nikula
---
include/drm/drm_edid.h | 12 +---
1 file changed, 5
Hi Tvrtko,
Thanks for pointing this mail out once more, I've totally missed it.
Am 12.12.23 um 11:37 schrieb Tvrtko Ursulin:
On 25/09/2023 14:16, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Allow mmap forwarding for imported buffers in order to allow minigbm
mmap
to work on aperture-less
== Series Details ==
Series: series starting with [1/2] drm/edid: replace __attribute__((packed))
with __packed
URL : https://patchwork.freedesktop.org/series/127680/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_127680v1
== Series Details ==
Series: series starting with [1/2] drm/edid: replace __attribute__((packed))
with __packed
URL : https://patchwork.freedesktop.org/series/127680/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
__packed is preferred over __attribute__((packed)).
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_ioc32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c
index 129e2b91dbfe..e6b5b06de148 100644
---
__packed is preferred over __attribute__((packed)).
Signed-off-by: Jani Nikula
---
include/drm/drm_edid.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index 518d1b8106c7..54cc6f04a708
== Series Details ==
Series: drm/i915/display: Wait for PHY readiness not needed for disabling
sequence (rev2)
URL : https://patchwork.freedesktop.org/series/127674/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14010 -> Patchwork_127674v2
When going through the disconnection flow we don't need to wait for PHY
readiness and hence we can skip the wait part. For disabling the function
returns false as an indicator that the power is not enabled. After all,
we are not even using the return value when Type-C is disconnecting.
v2:
On Tue, Dec 12, 2023 at 08:34:00AM +, Sean Young wrote:
> In order to introduce a pwm api which can be used from atomic context,
> we will need two functions for applying pwm changes:
>
> int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);
> int pwm_apply_atomic(struct
== Series Details ==
Series: drm/i915/display: Get bigjoiner config before dsc config during readout
(rev3)
URL : https://patchwork.freedesktop.org/series/126742/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14008_full -> Patchwork_126742v3_full
On 25/09/2023 14:16, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Allow mmap forwarding for imported buffers in order to allow minigbm mmap
to work on aperture-less platforms such as Meteorlake.
So far i915 did not allow mmap on imported buffers but from minigbm
perspective that worked
> -Original Message-
> From: Deak, Imre
> Sent: Tuesday, December 12, 2023 12:08 PM
> To: Kahola, Mika
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/i915/display: Wait for PHY readiness not needed for
> disabling sequence
>
> On Tue, Dec 12, 2023 at 11:55:20AM +0200,
On Tue, Dec 12, 2023 at 11:55:20AM +0200, Mika Kahola wrote:
> When going through the disconnection flow we don't need to wait for PHY
> readiness and hence we can skip the wait part. For disabling the function
> returns false as an indicator that the power is not enabled. After all,
> we are not
When going through the disconnection flow we don't need to wait for PHY
readiness and hence we can skip the wait part. For disabling the function
returns false as an indicator that the power is not enabled. After all,
we are not even using the return value when Type-C is disconnecting.
BSpec:
On Tue, 12 Dec 2023, "Murthy, Arun R" wrote:
>> -Original Message-
>> From: Intel-gfx On Behalf Of Nemesa
>> Garg
>> Sent: Friday, October 27, 2023 3:24 PM
>> To: intel-gfx@lists.freedesktop.org
>> Subject: [Intel-gfx] [v2 1/2] drm/i915/display: Add support for darskscreen
>> detection
In order to introduce a pwm api which can be used from atomic context,
we will need two functions for applying pwm changes:
int pwm_apply_might_sleep(struct pwm *, struct pwm_state *);
int pwm_apply_atomic(struct pwm *, struct pwm_state *);
This commit just deals with renaming
hi, Jani,
On Fri, Dec 08, 2023 at 11:59:43AM +0200, Jani Nikula wrote:
> On Thu, 07 Dec 2023, kernel test robot wrote:
> > Hello,
> >
> > kernel test robot noticed "assertion_failure" on:
> >
> > commit: 9bb66c179f50e61df20ba13c9b34ca17d00b05fb ("drm/i915: Reserve some
> > kernel space per vm")
74 matches
Mail list logo