Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Enable Wa_16019325821

On 10/27/2023 2:18 PM, john.c.harri...@intel.com wrote: From: John Harrison Some platforms require holding RCS context switches until CCS is idle (the reverse w/a of Wa_14014475959). Some platforms require both versions. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/gen8_engine_cs

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/guc: Enable Wa_14019159160

On 10/27/2023 2:18 PM, john.c.harri...@intel.com wrote: From: John Harrison Use the new w/a KLV support to enable a MTL w/a. Note, this w/a is a super-set of Wa_16019325821, so requires turning that one as well as setting the new flag for Wa_14019159160 itself. Signed-off-by: John Harrison

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/guc: Add support for w/a KLVs

On 10/27/2023 2:18 PM, john.c.harri...@intel.com wrote: From: John Harrison To prevent running out of bits, new w/a enable flags are being added via a KLV system instead of a 32 bit flags word. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 1 + drivers

[PATCH] drm/i915/guc: Change wa registers to MCR type

some of the wa registers are MCR registers, which has different read/write process with normal MMIO registers. As the MCR process also work for normal MMIO registers, change all wa registers to MCR process for simplicity. Signed-off-by: Shuicheng Lin Cc: Matt Roper --- drivers/gpu/drm/i915/gt/u

✗ Fi.CI.IGT: failure for series starting with [1/3] drm/i915: Allow the initial async flip to change modifier (rev2)

== Series Details == Series: series starting with [1/3] drm/i915: Allow the initial async flip to change modifier (rev2) URL : https://patchwork.freedesktop.org/series/127754/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14017_full -> Patchwork_127754v2_full

✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Allow the initial async flip to change modifier (rev2)

== Series Details == Series: series starting with [1/3] drm/i915: Allow the initial async flip to change modifier (rev2) URL : https://patchwork.freedesktop.org/series/127754/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_127754v2 ==

✓ Fi.CI.IGT: success for drm/i915/mtl: Fix HDMI/DP PLL clock selection

== Series Details == Series: drm/i915/mtl: Fix HDMI/DP PLL clock selection URL : https://patchwork.freedesktop.org/series/12/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017_full -> Patchwork_12v1_full Summary -

✓ Fi.CI.IGT: success for drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev11)

== Series Details == Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev11) URL : https://patchwork.freedesktop.org/series/126998/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017_full -> Patchwork_126998v11_full

Re: [PATCH 04/12] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

On Wed, Dec 13, 2023 at 08:18:15PM +, Sripada, Radhakrishna wrote: > Hi Ville, > > +Nirmoy > > > -Original Message- > > From: Ville Syrjälä > > Sent: Wednesday, December 13, 2023 1:30 AM > > To: Joonas Lahtinen > > Cc: intel-gfx@lists.freedesktop.org; Sripada, Radhakrishna > > > >

✓ Fi.CI.BAT: success for drm/i915/mtl: Fix HDMI/DP PLL clock selection

== Series Details == Series: drm/i915/mtl: Fix HDMI/DP PLL clock selection URL : https://patchwork.freedesktop.org/series/12/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_12v1 Summary ---

✗ Fi.CI.IGT: failure for series starting with [v4,1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

== Series Details == Series: series starting with [v4,1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names URL : https://patchwork.freedesktop.org/series/127768/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14017_full -> Patchwork_127768v1_full ==

✓ Fi.CI.BAT: success for drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev11)

== Series Details == Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev11) URL : https://patchwork.freedesktop.org/series/126998/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_126998v11 ==

✗ Fi.CI.SPARSE: warning for drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev11)

== Series Details == Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev11) URL : https://patchwork.freedesktop.org/series/126998/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev11)

== Series Details == Series: drm/i915/gem: Atomically invalidate userptr on mmu-notifier (rev11) URL : https://patchwork.freedesktop.org/series/126998/ State : warning == Summary == Error: dim checkpatch failed c353a8998892 drm/i915/gem: Atomically invalidate userptr on mmu-notifier -:117: WAR

✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

== Series Details == Series: series starting with [v4,1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names URL : https://patchwork.freedesktop.org/series/127768/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_127768v1

✓ Fi.CI.IGT: success for drm/i915: Add Wa_14019877138 (rev4)

== Series Details == Series: drm/i915: Add Wa_14019877138 (rev4) URL : https://patchwork.freedesktop.org/series/127346/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017_full -> Patchwork_127346v4_full Summary ---

✗ Fi.CI.SPARSE: warning for series starting with [v4,1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

== Series Details == Series: series starting with [v4,1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names URL : https://patchwork.freedesktop.org/series/127768/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be chec

✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

== Series Details == Series: series starting with [v4,1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names URL : https://patchwork.freedesktop.org/series/127768/ State : warning == Summary == Error: dim checkpatch failed fff3da8c3b65 drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test p

Re: [Intel-gfx] [PATCH] drm/i915/cdclk: Remove divider field from tables

On Mon, Dec 04, 2023 at 11:13:52AM -0300, Gustavo Sousa wrote: > Quoting Gustavo Sousa (2023-12-04 11:04:20-03:00) > >Quoting Matt Roper (2023-12-01 20:07:48-03:00) > >>On Tue, Nov 28, 2023 at 11:51:43AM +0200, Ville Syrjälä wrote: > >>> On Tue, Nov 28, 2023 at 10:43:36AM +0200, Ville Syrjälä wrote

✗ Fi.CI.BAT: failure for Revert "drm/i915/gt: Temporarily disable CPU caching into DMA for MTL"

== Series Details == Series: Revert "drm/i915/gt: Temporarily disable CPU caching into DMA for MTL" URL : https://patchwork.freedesktop.org/series/127763/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_127763v1

✓ Fi.CI.BAT: success for drm/i915: Add Wa_14019877138 (rev4)

== Series Details == Series: drm/i915: Add Wa_14019877138 (rev4) URL : https://patchwork.freedesktop.org/series/127346/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_127346v4 Summary --- **SUCCESS*

✓ Fi.CI.IGT: success for drm/i915/dmc: DMC event stuff (rev2)

== Series Details == Series: drm/i915/dmc: DMC event stuff (rev2) URL : https://patchwork.freedesktop.org/series/127648/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017_full -> Patchwork_127648v2_full Summary ---

✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Allow the initial async flip to change modifier

== Series Details == Series: series starting with [1/3] drm/i915: Allow the initial async flip to change modifier URL : https://patchwork.freedesktop.org/series/127754/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_127754v1 =

✓ Fi.CI.IGT: success for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/127752/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017_full -> Patchwork_127752v1_full =

RE: [PATCH] drm/i915/mtl: Fix HDMI/DP PLL clock selection

> -Original Message- > From: Deak, Imre > Sent: Wednesday, December 13, 2023 2:05 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kahola, Mika ; Sripada, Radhakrishna > > Subject: [PATCH] drm/i915/mtl: Fix HDMI/DP PLL clock selection > > Select the HDMI specific PLL clock only for HDMI

✓ Fi.CI.BAT: success for drm/i915/dmc: DMC event stuff (rev2)

== Series Details == Series: drm/i915/dmc: DMC event stuff (rev2) URL : https://patchwork.freedesktop.org/series/127648/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_127648v2 Summary --- **SUCCESS

[PATCH] drm/i915/mtl: Fix HDMI/DP PLL clock selection

Select the HDMI specific PLL clock only for HDMI outputs. Fixes: 62618c7f117e ("drm/i915/mtl: C20 PLL programming") Cc: Mika Kahola Cc: Radhakrishna Sripada Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -

✗ Fi.CI.SPARSE: warning for drm/i915/dmc: DMC event stuff (rev2)

== Series Details == Series: drm/i915/dmc: DMC event stuff (rev2) URL : https://patchwork.freedesktop.org/series/127648/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1

✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: DMC event stuff (rev2)

== Series Details == Series: drm/i915/dmc: DMC event stuff (rev2) URL : https://patchwork.freedesktop.org/series/127648/ State : warning == Summary == Error: dim checkpatch failed 45567c45ed93 drm/i915/dmc: Don't enable any pipe DMC events fcc22fee32de drm/i915/dmc: Also disable the flip queue

✓ Fi.CI.BAT: success for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/127752/ State : success == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_127752v1 ===

✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/127752/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

== Series Details == Series: series starting with [1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space URL : https://patchwork.freedesktop.org/series/127752/ State : warning == Summary == Error: dim checkpatch failed 2d6d981a7c8c drm/ttm: return ENOSPC from ttm_bo_mem_space -:35: WARNING:FROM_SI

Re: [PATCH v8 2/2] drm/i915/guc: Close deregister-context race against CT-loss

On Tue, Dec 12, 2023 at 08:57:16AM -0800, Alan Previn wrote: > If we are at the end of suspend or very early in resume > its possible an async fence signal (via rcu_call) is triggered > to free_engines which could lead us to the execution of > the context destruction worker (after a prior worker fl

[PATCH v4 3/3] drm/i915/dp: Fix passing the correct DPCD_REV for drm_dp_set_phy_test_pattern

Using link_status to get DPCD_REV fails when disabling/defaulting phy pattern. Use intel_dp->dpcd to access DPCD_REV correctly. Fixes: 8cdf72711928 ("drm/i915/dp: Program vswing, pre-emphasis, test-pattern") Cc: Jani Nikula Cc: Imre Deak Cc: Lee Shawn C Signed-off-by: Khaled Almahallawy --- d

[PATCH v4 2/3] drm/i915/dp: Add TPS4 PHY test pattern support

Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests. v2: rebase v3: - Enable TPS4 only for supported platforms (Jani) - Uppercase in macro names (Jani) - Fix indentation (Jani) - Use drm_warn instead of WARN v4: Disable TPS4 pattern on supported platforms only Bspec: 50482

[PATCH v4 1/3] drm/i915/dp: Use LINK_QUAL_PATTERN_* Phy test pattern names

Starting from DP2.0 specs, DPCD 248h is renamed LINK_QUAL_PATTERN_SELECT and it has the same values of registers DPCD 10Bh-10Eh. Use the PHY pattern names defined for DPCD 10Bh-10Eh in order to add CP2520 Pattern 3 (TPS4) phy pattern support in the next patch of this series and DP2.1 PHY patterns f

✗ Fi.CI.BAT: failure for drm/i915: Cursor vblank evasion

== Series Details == Series: drm/i915: Cursor vblank evasion URL : https://patchwork.freedesktop.org/series/127744/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14017 -> Patchwork_127744v1 Summary --- **FAILURE**

✗ Fi.CI.SPARSE: warning for drm/i915: Cursor vblank evasion

== Series Details == Series: drm/i915: Cursor vblank evasion URL : https://patchwork.freedesktop.org/series/127744/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: war

RE: [PATCH 04/12] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

Hi Ville, +Nirmoy > -Original Message- > From: Ville Syrjälä > Sent: Wednesday, December 13, 2023 1:30 AM > To: Joonas Lahtinen > Cc: intel-gfx@lists.freedesktop.org; Sripada, Radhakrishna > > Subject: Re: [PATCH 04/12] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL > stolen memory access >

[PATCH] Revert "drm/i915/gt: Temporarily disable CPU caching into DMA for MTL"

This reverts commit 34df0a031d8f3488fe72627b041a1f82437fa6ec. It appears that the temporary workaround to prevent CAT errors is no longer required, as even with it reverted the CAT errors didn't occur when tested manually. Signed-off-by: Jonathan Cavitt --- drivers/gpu/drm/i915/gt/intel_gtt.c |

✓ Fi.CI.IGT: success for DP DSC min/max src bpc fixes (rev7)

== Series Details == Series: DP DSC min/max src bpc fixes (rev7) URL : https://patchwork.freedesktop.org/series/125571/ State : success == Summary == CI Bug Log - changes from CI_DRM_14014_full -> Patchwork_125571v7_full Summary ---

Re: [PATCH] drm/i915: Reject async flips with bigjoiner

On Mon, Dec 11, 2023 at 10:11:34AM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently async flips are busted when bigjoiner is in use. > As a short term fix simply reject async flips in that case. > > Cc: sta...@vger.kernel.org > Closes: https://gitlab.freedesktop.org/drm/intel/-/is

✓ Fi.CI.BAT: success for DP DSC min/max src bpc fixes (rev7)

== Series Details == Series: DP DSC min/max src bpc fixes (rev7) URL : https://patchwork.freedesktop.org/series/125571/ State : success == Summary == CI Bug Log - changes from CI_DRM_14014 -> Patchwork_125571v7 Summary --- **SUCCESS*

Re: [PATCH v3 1/2] drm/i915/display: Add support for darskscreen detection

On Wed, Dec 13, 2023 at 02:36:40PM +0530, Nemesa Garg wrote: > Darkscreen detection checks if all the pixels of the frame are less then > or equal to the comparision value. The comparision value is set to 256 > i.e black. So upon getting black pixels from the pipe, the dark screen > detect bit is s

✓ Fi.CI.IGT: success for drm/i915/uapi: fix typos/spellos and punctuation

== Series Details == Series: drm/i915/uapi: fix typos/spellos and punctuation URL : https://patchwork.freedesktop.org/series/127730/ State : success == Summary == CI Bug Log - changes from CI_DRM_14014_full -> Patchwork_127730v1_full Summar

✗ Fi.CI.SPARSE: warning for DP DSC min/max src bpc fixes (rev7)

== Series Details == Series: DP DSC min/max src bpc fixes (rev7) URL : https://patchwork.freedesktop.org/series/125571/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1:

Re: â Fi.CI.BAT: failure for drm/i915: (stolen) memory region related fixes

On 13/12/2023 17:24, Tvrtko Ursulin wrote: Hi Andrzej, On 13/12/2023 16:13, Andrzej Hajda wrote: On 13.12.2023 02:37, Patchwork wrote: *Patch Details* *Series:*    drm/i915: (stolen) memory region related fixes *URL:*    https://patchwork.freedesktop.org/series/127721/

Re: â Fi.CI.BAT: failure for drm/i915: (stolen) memory region related fixes

Hi Andrzej, On 13/12/2023 16:13, Andrzej Hajda wrote: On 13.12.2023 02:37, Patchwork wrote: *Patch Details* *Series:*    drm/i915: (stolen) memory region related fixes *URL:*    https://patchwork.freedesktop.org/series/127721/ *State:*    f

✓ Fi.CI.BAT: success for drm/i915: Add Wa_14019877138 (rev3)

== Series Details == Series: drm/i915: Add Wa_14019877138 (rev3) URL : https://patchwork.freedesktop.org/series/127346/ State : success == Summary == CI Bug Log - changes from CI_DRM_14014 -> Patchwork_127346v3 Summary --- **SUCCESS*

✗ Fi.CI.BUILD: failure for Enable Darkscreen Feature (rev3)

== Series Details == Series: Enable Darkscreen Feature (rev3) URL : https://patchwork.freedesktop.org/series/125563/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/125563/revisions/3/mbox/ not applied Applying: drm/i915/display: Add support for da

Re: [PATCH 01/12] drm/i915: Use struct resource for memory region IO as well

On Wed, Dec 13, 2023 at 02:59:07AM +0200, Ville Syrjälä wrote: > On Wed, Dec 13, 2023 at 02:42:26AM +0200, Ville Syrjala wrote: > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev_fb.c > > b/drivers/gpu/drm/i915/display/intel_fbdev_fb.c > > index 717c3a3237c4..1ac05d90b2e8 100644 > > --- a/d

Re: [PATCH 02/12] drm/i915: Print memory region info during probe

On Wed, Dec 13, 2023 at 06:26:13PM +0200, Ville Syrjälä wrote: > On Wed, Dec 13, 2023 at 05:05:21PM +0100, Andrzej Hajda wrote: > > On 13.12.2023 01:42, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Dump the details about every memory region into dmesg at probe time. > > > Avoids hav

✓ Fi.CI.BAT: success for drm/i915/uapi: fix typos/spellos and punctuation

== Series Details == Series: drm/i915/uapi: fix typos/spellos and punctuation URL : https://patchwork.freedesktop.org/series/127730/ State : success == Summary == CI Bug Log - changes from CI_DRM_14014 -> Patchwork_127730v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915/uapi: fix typos/spellos and punctuation

== Series Details == Series: drm/i915/uapi: fix typos/spellos and punctuation URL : https://patchwork.freedesktop.org/series/127730/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 02/12] drm/i915: Print memory region info during probe

On Wed, Dec 13, 2023 at 05:05:21PM +0100, Andrzej Hajda wrote: > On 13.12.2023 01:42, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Dump the details about every memory region into dmesg at probe time. > > Avoids having to dig those out from random places when debugging stuff. > > > > Sign

Re: â Fi.CI.BAT: failure for drm/i915: (stolen) memory region related fixes

On 13.12.2023 02:37, Patchwork wrote: *Patch Details* *Series:* drm/i915: (stolen) memory region related fixes *URL:* https://patchwork.freedesktop.org/series/127721/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/dr

Re: [PATCH 01/12] drm/i915: Use struct resource for memory region IO as well

On Wed, Dec 13, 2023 at 04:52:54PM +0100, Andrzej Hajda wrote: > On 13.12.2023 01:42, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > mem->region is a struct resource, but mem->io_start and > > mem->io_size are not for whatever reason. Let's unify this > > and convert the io stuff into a str

Re: [PATCH 03/12] drm/i915: Remove ad-hoc lmem/stolen debugs

On 13.12.2023 01:42, Ville Syrjala wrote: From: Ville Syrjälä Now that intel_memory_regions_hw_probe() prints out each and every memory region there's no reason to have ad-hoc debugs to do similar things elsewhere. Signed-off-by: Ville Syrjälä Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [PATCH 02/12] drm/i915: Print memory region info during probe

On 13.12.2023 01:42, Ville Syrjala wrote: From: Ville Syrjälä Dump the details about every memory region into dmesg at probe time. Avoids having to dig those out from random places when debugging stuff. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_memory_region.c | 18 +++

Re: [Intel-gfx] â Fi.CI.BAT: failure for drm/i915/display: Check GGTT to determine phys_base (rev2)

On Fri, Dec 08, 2023 at 09:32:00AM +0100, Andrzej Hajda wrote: > On 07.12.2023 12:26, Andrzej Hajda wrote: > > On 07.12.2023 11:10, Andrzej Hajda wrote: > > > > After taking a look on panic log [1], I have found: > > [drm:i915_init_ggtt [i915]] Failed to reserve top of GGTT for GuC > > > > I don'

Re: [PATCH 01/12] drm/i915: Use struct resource for memory region IO as well

On 13.12.2023 01:42, Ville Syrjala wrote: From: Ville Syrjälä mem->region is a struct resource, but mem->io_start and mem->io_size are not for whatever reason. Let's unify this and convert the io stuff into a struct resource as well. Should make life a little less annoying when you don't have j

[PATCH 3/3] drm/i915: Don't use memcpy() when assignment will do

From: Ville Syrjälä Replace pointless memcpy()s of structures. A normal assignment will do just fine, thank you. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 3 +-- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- 2 files changed, 3 insertions

[PATCH 2/3] drm/i915: Indicate which pipe failed the fastset check overall

From: Ville Syrjälä intel_crtc_check_fastset() is done per-pipe, so it would be nice to know which pipe it was that failed its checkup. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH 1/3] drm/i915: Allow the initial async flip to change modifier

From: Ville Syrjälä With Xorg+modesetting on skl+ we see the following behaviour: 1. root pixmap is X-tiled 2. client submitted buffers can be Y-tiled (w/ 'Option "dmabuf_capable"') 3. we try to switch from the X-tiled buffer to the Y-tiled buffer using an async flip (when vsync is disabled).

Re: [PATCH 9/9] Revert "drm/i915/xe2lpd: Treat cursor plane as regular plane for DDB allocation"

On Wed, Dec 13, 2023 at 05:15:06PM +0200, Ville Syrjälä wrote: > On Wed, Dec 13, 2023 at 01:28:15PM +0200, Lisovskiy, Stanislav wrote: > > On Wed, Dec 13, 2023 at 12:25:19PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > This reverts commit cfeff354f70bb1d0deb0279506e3f7989bc16

Re: [PATCH 9/9] Revert "drm/i915/xe2lpd: Treat cursor plane as regular plane for DDB allocation"

On Wed, Dec 13, 2023 at 01:28:15PM +0200, Lisovskiy, Stanislav wrote: > On Wed, Dec 13, 2023 at 12:25:19PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > This reverts commit cfeff354f70bb1d0deb0279506e3f7989bc16e28. > > > > A core design consideration with legacy cursor updates is t

[PATCH v2 3/4] drm/i915/dmc: Also disable HRR event on TGL/ADLS main DMC

From: Ville Syrjälä Unlike later platforms TGL/ADLS has the half refresh rate (HRR) event on the main DMC (as opposed to the pipe DMC). Since we're disabling that event on all later platforms already let's do the same on TGL/ADLS as well. There is supposedly a bit somewhere (DMC_CHICKEN on TGL)

Re: [PATCH 3/4] drm/i915/dmc: Also disable HRR event on TGL main DMC

On Wed, Dec 13, 2023 at 05:02:52PM +0200, Ville Syrjälä wrote: > On Wed, Dec 13, 2023 at 12:58:08PM +0200, Imre Deak wrote: > > On Wed, Dec 13, 2023 at 11:31:24AM +0200, Ville Syrjälä wrote: > > > On Wed, Dec 13, 2023 at 10:17:58AM +0200, Imre Deak wrote: > > > > On Mon, Dec 11, 2023 at 11:37:49PM

✓ Fi.CI.IGT: success for series starting with [1/2] drm/edid: replace __attribute__((packed)) with __packed (rev2)

== Series Details == Series: series starting with [1/2] drm/edid: replace __attribute__((packed)) with __packed (rev2) URL : https://patchwork.freedesktop.org/series/127680/ State : success == Summary == CI Bug Log - changes from CI_DRM_14010_full -> Patchwork_127680v2_full ==

Re: [PATCH 3/4] drm/i915/dmc: Also disable HRR event on TGL main DMC

On Wed, Dec 13, 2023 at 12:58:08PM +0200, Imre Deak wrote: > On Wed, Dec 13, 2023 at 11:31:24AM +0200, Ville Syrjälä wrote: > > On Wed, Dec 13, 2023 at 10:17:58AM +0200, Imre Deak wrote: > > > On Mon, Dec 11, 2023 at 11:37:49PM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > > > >

Re: [PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

Before anybody wonders why no additional people are on CC: I just send that out to get feedback from the CI systems. Regards, Christian. Am 13.12.23 um 15:42 schrieb Christian König: Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo

[PATCH 4/4] drm/amdgpu: use GTT only as fallback for VRAM|GTT

Try to fill up VRAM as well by setting the busy flag on GTT allocations. This fixes the issue that when VRAM was evacuated for suspend it's never filled up again unless the application is restarted. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 ++ 1 file

[PATCH 1/4] drm/ttm: return ENOSPC from ttm_bo_mem_space

Only convert it to ENOMEM in ttm_bo_validate. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index edf10618fe2b..8c1eaa74fa21 100644 --- a/drivers/

[PATCH 3/4] drm/ttm: improve idle/busy handling

Previously we would never try to move a BO into the preferred placements when it ever landed in a busy placement since those were considered compatible. Rework the whole handling and finally unify the idle and busy handling. ttm_bo_validate() is now responsible to try idle placement first and then

[PATCH 2/4] drm/ttm: replace busy placement with flags v3

From: Somalapuram Amaranath Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. v2: add missing TTM_PL_FLAG_IDLE for i915 v3: fix auto build test ERROR on drm-tip/drm-tip Signed-off-by: Christian K

RE: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/edid: replace __attribute__((packed)) with __packed (rev2)

Hi, https://patchwork.freedesktop.org/series/127680/ - Re-reported Thanks, Tejasree -Original Message- From: Musial, Ewelina Sent: Wednesday, December 13, 2023 12:29 PM To: Nikula, Jani ; i915-ci-in...@lists.freedesktop.org; Illipilli, TejasreeX Cc: intel-gfx@lists.freedesktop.org Su

[PULL] drm-intel-fixes

Hi Dave & Sima - Fixes for -rc6, majority of them stable material. drm-intel-fixes-2023-12-13: drm/i915 fixes for v6.7-rc6: - Fix selftest engine reset count storage for multi-tile - Fix out-of-bounds reads for engine reset counts - Fix ADL+ remapped stride with CCS - Fix intel_atomic_setup_sca

Re: [RFC] drm/i915: Allow dmabuf mmap forwarding

Am 13.12.23 um 12:46 schrieb Tvrtko Ursulin: Hi, On 12/12/2023 14:10, Christian König wrote: Hi Tvrtko, Thanks for pointing this mail out once more, I've totally missed it. That's okay, if it was really urgent I would have re-raised the thread earlier. :) As it stands so far it is only abo

✓ Fi.CI.BAT: success for series starting with [1/2] drm/edid: replace __attribute__((packed)) with __packed (rev2)

== Series Details == Series: series starting with [1/2] drm/edid: replace __attribute__((packed)) with __packed (rev2) URL : https://patchwork.freedesktop.org/series/127680/ State : success == Summary == CI Bug Log - changes from CI_DRM_14010 -> Patchwork_127680v2

RE: [PATCH 3/3] drm/i915/mtl: Rename the link_bit_rate to clock in C20 pll_state

Hi. > -Original Message- > From: Intel-gfx On Behalf Of > Sripada, > Radhakrishna > Sent: Friday, December 8, 2023 9:30 PM > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Subject: RE: [PATCH 3/3] drm/i915/mtl: Rename the link_bit_rate to clock in > C20 > pll_state > > Thank you

Re: [RFC] drm/i915: Allow dmabuf mmap forwarding

Hi, On 12/12/2023 14:10, Christian König wrote: Hi Tvrtko, Thanks for pointing this mail out once more, I've totally missed it. That's okay, if it was really urgent I would have re-raised the thread earlier. :) As it stands so far it is only about acceptance test suites failing and no kno

Re: [PATCH 9/9] Revert "drm/i915/xe2lpd: Treat cursor plane as regular plane for DDB allocation"

On Wed, Dec 13, 2023 at 12:25:19PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > This reverts commit cfeff354f70bb1d0deb0279506e3f7989bc16e28. > > A core design consideration with legacy cursor updates is that the > cursor must not touch any other plane, even if we were to force it > to

Re: [PATCH] drm/i915/uapi: fix typos/spellos and punctuation

Hi Randy, On 13/12/2023 04:40, Randy Dunlap wrote: Use "its" for possessive form instead of "it's". Hyphenate multi-word adjectives. Correct some spelling. End one line of code with ';' instead of ','. The before and after object files are identical. Signed-off-by: Randy Dunlap Cc: Jani N

Re: [PATCH 3/4] drm/i915/dmc: Also disable HRR event on TGL main DMC

On Wed, Dec 13, 2023 at 11:31:24AM +0200, Ville Syrjälä wrote: > On Wed, Dec 13, 2023 at 10:17:58AM +0200, Imre Deak wrote: > > On Mon, Dec 11, 2023 at 11:37:49PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Unlike later platforms TGL has the half refresh rate (HRR) event > >

RE: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hwmon: Fix analysis tool reported issues

Pushed to drm-intel-gt-next. Thanks for patch. Br, Anshuman Gupta. From: Intel-gfx On Behalf Of Patchwork Sent: Thursday, December 7, 2023 1:41 PM To: Poosa, Karthik Cc: intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hwmon: Fix analysis tool reported iss

[PATCH 9/9] Revert "drm/i915/xe2lpd: Treat cursor plane as regular plane for DDB allocation"

From: Ville Syrjälä This reverts commit cfeff354f70bb1d0deb0279506e3f7989bc16e28. A core design consideration with legacy cursor updates is that the cursor must not touch any other plane, even if we were to force it to take the slow path. That is the real reason why the cursor uses a fixed ddb a

[PATCH 8/9] drm/i915: Perform vblank evasion around legacy cursor updates

From: Ville Syrjälä Our legacy cursor updates are actually mailbox updates. Ie. the hardware latches things once per frame on start of vblank, but we issue an number of updates per frame, withough any attempt to synchronize against the vblank in software. So in theory only the last update issued

[PATCH 7/9] drm/i915: Move intel_vblank_evade() & co. into intel_vblank.c

From: Ville Syrjälä intel_vblank.c seems like the appropriate place for the core vblank evasion code. Move it there. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.c | 135 drivers/gpu/drm/i915/display/intel_vblank.c | 130 +++ d

[PATCH 6/9] drm/i915: Move the min/max scanline sanity check into intel_vblank_evade()

From: Ville Syrjälä There isn't really any reason to make the caller suffer through checking the vblank evasion min/max scanlines. If we somehow ended up with bogus values (which really shouldn't happen) then just skip the actual vblank evasion loop but otherwise plow ahead as normal. The only "

[PATCH 5/9] drm/i915: Extract intel_vblank_evade()

From: Ville Syrjälä Pull the core vblank evasion loop into its own function, so that we can reuse it elsewhere later. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.c | 135 -- 1 file changed, 75 insertions(+), 60 deletions(-) diff --git a/drivers

[PATCH 4/9] drm/i915: Include need_vlv_dsi_wa in intel_vblank_evade_ctx

From: Ville Syrjälä Pull the need_vlv_dsi_wa details into intel_vblank_evade_init() so that caller doesn't have to care about it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/

[PATCH 3/9] drm/i915: Introduce struct intel_vblank_evade_ctx

From: Ville Syrjälä Collect the information needed for vblank evasions into a structure that we can pass around more easily. And let's rename intel_crtc_vblank_evade_scanlines() to just intel_vblank_evade_init() so that better describes the intended usage of initializing the context. Signed-off

[PATCH 2/9] drm/i915: Reorder drm_vblank_put() vs. need_vlv_dsi_wa

From: Ville Syrjälä Drop the vblank reference only after we've done the hideous need_vlv_dsi_wa stuff. This will make it easier to reuse the the vblank evasion machinery elsewhere. Keeping the vblank reference for a bit longer is not a problem. In fact we might want to not drop it at all until i

[PATCH 1/9] drm/i915: Decouple intel_crtc_vblank_evade_scanlines() from atomic commits

From: Ville Syrjälä We'll be needing to do vblank evasion around legacy cursor updates, which don't have the intel_atomic_state around. So let's remove this dependency on a full commit and pass the crtc state in by hand. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_crtc.

[PATCH 0/9] drm/i915: Cursor vblank evasion

From: Ville Syrjälä MTL seems very good at racing the cursor mailbox updates against the vblank, causing things to not latch for long enough to cause GTT faults. Attempt to hook up vblank evasions into the legacy cursor path to avoid this. Also revert a dangerous wm/ddb change related to cursors

Re: [PATCH v3 1/2] drm/i915/display: Add support for darskscreen detection

On Wed, 13 Dec 2023, Nemesa Garg wrote: > Darkscreen detection checks if all the pixels of the frame are less then > or equal to the comparision value. The comparision value is set to 256 > i.e black. So upon getting black pixels from the pipe, the dark screen > detect bit is set and an error mess

Re: [PATCH v3 0/2] Enable Darkscreen Feature

On Wed, 13 Dec 2023, Nemesa Garg wrote: > The logic checks for any black screen at pipe level and > upon such detection prints error. Darkscreen compares the > pixels with the compare value(0x00 - black) for the detection > purpose. This feature can be enables/disabled through debugfs. This does

Re: [PATCH 3/4] drm/i915/dmc: Also disable HRR event on TGL main DMC

On Wed, Dec 13, 2023 at 10:17:58AM +0200, Imre Deak wrote: > On Mon, Dec 11, 2023 at 11:37:49PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Unlike later platforms TGL has the half refresh rate (HRR) event > > on the main DMC (as opposed to the pipe DMC). Since we're disabling > >

Re: [PATCH] drm/i915/display: Get bigjoiner config before dsc config during readout

On 11/23/2023 11:57 AM, Kandpal, Suraj wrote: -Original Message- From: Nautiyal, Ankit K Sent: Wednesday, November 22, 2023 12:16 PM To: intel-gfx@lists.freedesktop.org Cc: Kandpal, Suraj ; Manna, Animesh ; jani.nik...@linux.intel.com; Nautiyal, Ankit K Subject: [PATCH] drm/i915/dis

Re: [PATCH 04/12] drm/i915: Bypass LMEMBAR/GTTMMADR for MTL stolen memory access

On Wed, Dec 13, 2023 at 11:09:38AM +0200, Joonas Lahtinen wrote: > Quoting Ville Syrjala (2023-12-13 02:42:29) > > From: Ville Syrjälä > > > > On MTL accessing stolen memory via the BARs is somehow borked, > > and it can hang the machine. As a workaround let's bypass the > > BARs and just go stra

  1   2   >